| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Add a unit test for the password change form https://review.opendev.org/c/openstack/horizon/+/828381 | 12:22 |
|---|---|---|
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Add a unit test for the password change form https://review.opendev.org/c/openstack/horizon/+/828381 | 13:02 |
| amotoki | prometheanfire: I see your comment. Is there anything we should check? https://meetings.opendev.org/irclogs/%23openstack-horizon/%23openstack-horizon.2022-02-08.log.html#t2022-02-08T19:39:43 | 13:29 |
| opendevreview | Rodrigo Barbieri proposed openstack/horizon master: Implement pagination in admin/proj network tab https://review.opendev.org/c/openstack/horizon/+/806454 | 13:53 |
| opendevreview | Rodrigo Barbieri proposed openstack/horizon master: Implement pagination in admin/proj network tab https://review.opendev.org/c/openstack/horizon/+/806454 | 14:24 |
| vishalmanchanda | #startmeeting horizon | 15:00 |
| opendevmeet | Meeting started Wed Feb 9 15:00:25 2022 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| vishalmanchanda | hello everyone | 15:00 |
| ganso | o/ | 15:01 |
| vishalmanchanda | let's wait for few minutes if more people join us. | 15:01 |
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Add a unit test for the password change form https://review.opendev.org/c/openstack/horizon/+/828381 | 15:01 |
| e0ne | hi | 15:02 |
| rdopiera | o/ | 15:03 |
| amotoki | o/ | 15:03 |
| vishalmanchanda | Let's start the meeting. | 15:03 |
| vishalmanchanda | Agenda for today meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities (at line 32) | 15:03 |
| vishalmanchanda | #topic Notices | 15:04 |
| vishalmanchanda | I have few announcements to make for this week | 15:04 |
| vishalmanchanda | As usual Yoga Schedule https://releases.openstack.org/yoga/schedule.html | 15:04 |
| vishalmanchanda | This week is R-7 week. | 15:05 |
| vishalmanchanda | We have only 2 weeks left for feature freeze. | 15:05 |
| vishalmanchanda | I'll add review-priority for feature patches to get more attention. | 15:05 |
| vishalmanchanda | moving to next announcement | 15:06 |
| vishalmanchanda | Team Signup for Z cycle PTG. | 15:06 |
| vishalmanchanda | http://lists.openstack.org/pipermail/openstack-discuss/2022-February/027051.html | 15:06 |
| vishalmanchanda | It is actually a action item for me, I will create a etherpad to collect topic and doodle poll to select the time which work for all of us and will share it on open-discuss ML. | 15:07 |
| vishalmanchanda | I will try to book the same time slots which we use for previous virtual ptg. | 15:08 |
| e0ne | vishalmanchanda: +1 | 15:08 |
| vishalmanchanda | meanwhile register yourself for ptg to get all ptg related updates | 15:10 |
| vishalmanchanda | #registration link https://openinfra-ptg.eventbrite.com/ | 15:10 |
| vishalmanchanda | moving to next announcement | 15:10 |
| vishalmanchanda | PTL and TC nomination for Z cycle started | 15:10 |
| vishalmanchanda | #link http://lists.openstack.org/pipermail/openstack-discuss/2022-February/027070.html | 15:10 |
| vishalmanchanda | If you want to nominate yourself, please go ahead, Deadline for that is Feb 15,23:45 UTC. | 15:11 |
| vishalmanchanda | let me know if anyone of you interested in PTL role. | 15:12 |
| vishalmanchanda | In case no-one come forward, I can serve as PTL for Z cycle. | 15:13 |
| vishalmanchanda | that's all announcement from my side for this week | 15:14 |
| vishalmanchanda | If anyone else have any announcement to make please go ahead. | 15:14 |
| vishalmanchanda | Otherwise I'll move to next topic | 15:14 |
| vishalmanchanda | moving to next topic | 15:16 |
| vishalmanchanda | #topic On-Demand Agenda | 15:16 |
| vishalmanchanda | There is a bug reported in horizon for pyScss doesn't work with python 3.10 | 15:17 |
| vishalmanchanda | #link https://bugs.launchpad.net/horizon/+bug/1960204 | 15:17 |
| e0ne | vishalmanchanda: do you have a link? | 15:17 |
| vishalmanchanda | A pull request to fix it is already up https://github.com/Kronuz/pyScss/pull/411 | 15:18 |
| e0ne | vishalmanchanda: thanks! will review and release it today pr tomorrow | 15:18 |
| vishalmanchanda | e0ne: awesome:) | 15:19 |
| vishalmanchanda | Once the PR request is merged and a new release is up with that change. I will update pyscss version in horizon or others. | 15:20 |
| vishalmanchanda | Next is a review request for https://review.opendev.org/c/openstack/horizon/+/806454 | 15:21 |
| ganso | vishalmanchanda: not really a review request | 15:21 |
| ganso | I just wanted to draw attention to that patch because now the unit tests for that class are not failing anymore, tests seem to have been removed, this looks strange as if there are things not being tested anymore. Before, my patch would break a bunch of tests for that class, but now there is no longer any breakage, but I believe there should have been | 15:21 |
| ganso | vishalmanchanda: regarding my patch, it is up and waiting for reviews, discussion specific to it can happen there, but I just wanted to highlight that specific thing about the Django patch in this meeting | 15:22 |
| amotoki | ganso: what is "that specific thing about the Django patch"? | 15:24 |
| vishalmanchanda | ganso: ok I am the one who pushed that Django patch, Could you point me to that test cases you want to highlight. | 15:25 |
| ganso | vishalmanchanda: openstack_dashboard/dashboards/project/instances/tests.py | 15:26 |
| ganso | vishalmanchanda: it is just that before I rebased there were a lot of unit tests in that classes affected by my changes, and after I rebased, there weren't any anymore | 15:27 |
| ganso | the instances screen is certainly affected by my patch, as it invokes neutron to list networks for the instances | 15:27 |
| amotoki | openstack_dashboard/dashboards/project/instances/tests.py was changed a lot as we dropped the Django implementation of the launch instance form. | 15:28 |
| amotoki | I think this is what you hit. | 15:28 |
| ganso | amotoki: yes, but the new changes now cause it to not any breakages with my patch, this looks odd, I'm not sure if coverage was affected by the changes that test class. I'm just raising awareness that something may be of concern there | 15:29 |
| vishalmanchanda | ganso: Hmm Please add your comment on the patch if you think if I have dropped any of tests which I shouldn't. | 15:30 |
| vishalmanchanda | https://review.opendev.org/c/openstack/horizon/+/816303/9/openstack_dashboard/dashboards/project/instances/tests.py | 15:30 |
| ganso | vishalmanchanda: ok, I will take a deeper look into that. Thanks! | 15:31 |
| amotoki | in the angular implementation, network list is requested via openstack_dashboard/api/rest/neutron.py. I havent' checked how the pagination is supported in the angular launch instance form | 15:31 |
| amotoki | but it just calls the network listing. | 15:31 |
| ganso | amotoki: hmmm I think that means the asserts are being done in a different layer now, no longer in project/instances/tests.py | 15:32 |
| amotoki | ganso: right, project/instances/ no longer handles the launch instance | 15:33 |
| vishalmanchanda | ok I have one more thing to discuss. | 15:33 |
| ganso | amotoki: oh so that must be it, thanks! | 15:33 |
| rdopiera | by the way, the integration tests for the angular launch instance dialog are still being skipped, maybe that's why we don't have tests failing? there is a patch up that enables them back | 15:34 |
| vishalmanchanda | rdopiera: you mean this one https://review.opendev.org/c/openstack/horizon/+/819725 ? | 15:35 |
| rdopiera | yup | 15:35 |
| rdopiera | wink, wink, nudge, nudge | 15:35 |
| tmazur | There's also a navigation fixed for angular tables | 15:35 |
| tmazur | So when we have it merged we can add more tests on angular tables | 15:36 |
| vishalmanchanda | tmazur: thanks for working on it, I will review it asap. | 15:36 |
| tmazur | Thank you! | 15:36 |
| vishalmanchanda | Last week I was investigating a bug and was unable to reproduce it in my local | 15:37 |
| vishalmanchanda | env. https://bugs.launchpad.net/horizon/+bug/1956552 | 15:37 |
| tmazur | I tried to reproduce it but no success too | 15:37 |
| amotoki | tmazur: does https://review.opendev.org/c/openstack/horizon/+/819725 cover what you mentioned? | 15:37 |
| vishalmanchanda | tmazur: ok I see. | 15:37 |
| tmazur | amotoki: yes | 15:38 |
| amotoki | tmazur: thanks | 15:38 |
| rdopiera | vishalmanchanda: could be caching issue | 15:38 |
| amotoki | regarding the translation bug, I sometimes hit it but full reloading usually solves it. | 15:39 |
| amotoki | I don't know the exact reason.... | 15:39 |
| rdopiera | it may depend on the browser being used | 15:39 |
| vishalmanchanda | rdopiera: amotoki : okay I will check with bug owner and add my comments there. | 15:40 |
| amotoki | I guess it is related to the browser cache. I usually use Chrome (on mac, windows) | 15:40 |
| rdopiera | chrome here too, and I think I've seen it too | 15:40 |
| rdopiera | but it's random and a refresh helps | 15:40 |
| amotoki | yeah, it is really random | 15:41 |
| rdopiera | magic | 15:41 |
| vishalmanchanda | Last one, there is a series of patches to fix django40-warnings from amotoki , all of patches LGTM. | 15:41 |
| ganso | one more thing before we close, quick request for one more extra pair of eyes on this patch that already has a +2 and a concern comment from rdopiera : https://review.opendev.org/c/openstack/horizon/+/809230 | 15:42 |
| vishalmanchanda | #link https://review.opendev.org/q/topic:django40-warnings | 15:42 |
| vishalmanchanda | Please take a look once you have time. | 15:42 |
| amotoki | re: the change ganso mentioned, I will look at it in detail too | 15:43 |
| rdopiera | I don't have a problem with that change per se, I just wanted to point out the side effect | 15:44 |
| prometheanfire | amotoki: I'm not sure what else to check, I've tried wallaby, xena and master horizon (rest of openstack is on xena), master needs newer keystone maybe? the other two failed to boot an instance that the command line could boot | 15:44 |
| amotoki | prometheanfire: I did not know what is the original one. I just saw your message with that url above.... we are in the meeting so let me ask you a bit later. | 15:45 |
| vishalmanchanda | prometheanfire: hi, Could you please open a bug for that and details there. | 15:46 |
| opendevreview | Tatiana Ovchinnikova proposed openstack/horizon master: Add a unit test for the password change form https://review.opendev.org/c/openstack/horizon/+/828381 | 15:46 |
| ganso | amotoki: thank you | 15:48 |
| amotoki | if there is no other topic in On-Demand agenda, I have one thing I would like to discuss. | 15:48 |
| vishalmanchanda | amotoki: please go ahead. | 15:48 |
| amotoki | during reviewing https://review.opendev.org/c/openstack/horizon/+/808102, I noticed the negative side of our microvesion support. | 15:48 |
| amotoki | the issue was caused by the difference of the server responss around nova API versions | 15:49 |
| amotoki | nova API changed the server resposne in API 2.47 | 15:49 |
| amotoki | but our code around flavor did not catch up with the change. | 15:49 |
| amotoki | to simplify the code, I wonder it is time to bump the min version of nova API to some version. | 15:50 |
| amotoki | for example, nova API version four release before. | 15:50 |
| e0ne | amotoki: +1, there is no need to support old veresions | 15:50 |
| amotoki | our default version of nova is still 2.1. we cannot support too many combinations of API versions..... | 15:51 |
| opendevreview | Merged openstack/horizon master: Replace deprecated imp module https://review.opendev.org/c/openstack/horizon/+/823028 | 15:51 |
| amotoki | last time we discussed the same topic, we did not do so because we cannot test all cases in every release | 15:52 |
| amotoki | but we might need to consider bumping the min periodically | 15:52 |
| vishalmanchanda | amotoki: I am fine with that. | 15:53 |
| amotoki | I don't think we have a conclusion now. I just want to raise this topic to have it in your minds :) | 15:53 |
| vishalmanchanda | amotoki: noted, thanks for raising it. | 15:54 |
| amotoki | thanks for the feedbacks. I contineu to explore how we can bump the min version and maintain it easily. that's all from me today | 15:55 |
| vishalmanchanda | Does anyone have any other topic to discuss? | 15:55 |
| e0ne | a quick question to rdopiera | 15:56 |
| e0ne | rdopiera: could you please rebase https://review.opendev.org/c/openstack/horizon/+/794809? I'm hitting issues with dependencies and failed to run horizon with this patch :( | 15:56 |
| vishalmanchanda | rdopiera: I can rebase it if it's fine for you... | 15:57 |
| vishalmanchanda | rdopiera: In case you don't have time to update it. | 15:57 |
| rdopiera | e0ne: I think it's old enough that there might have been considerable changes in the mean time | 15:58 |
| rdopiera | I will look into it | 15:58 |
| e0ne | yes:( | 15:58 |
| e0ne | rdopiera: thanks | 15:58 |
| vishalmanchanda | ok if nothing else to discuss, we can end this meeting. | 15:59 |
| vishalmanchanda | Thanks, everyone for your contributions! | 15:59 |
| vishalmanchanda | See you next week. | 15:59 |
| vishalmanchanda | #endmeeting | 15:59 |
| opendevmeet | Meeting ended Wed Feb 9 15:59:52 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:59 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-02-09-15.00.html | 15:59 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-02-09-15.00.txt | 15:59 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-02-09-15.00.log.html | 15:59 |
| *** ralonsoh_ is now known as ralonsoh | 16:40 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!