| opendevreview | Akihiro Motoki proposed openstack/horizon master: Declare python_requires >=3.6 in setup.cfg https://review.opendev.org/c/openstack/horizon/+/829629 | 05:38 |
|---|---|---|
| amotoki | lajoskatona: hi, I reviewd the QoS rule support patch https://review.opendev.org/c/openstack/horizon/+/805360 | 05:50 |
| amotoki | lajoskatona: there are not small number of feedbacks but I believe they can be fixed as a follow-up patch. | 05:50 |
| amotoki | lajoskatona: if you are okay, I can update label texts I pointed out in the review. | 05:51 |
| lajoskatona | amotoki: Hi, thanks | 07:06 |
| lajoskatona | amotoki: I just quickly checked | 07:07 |
| opendevreview | Merged openstack/horizon master: Fix for "Resize instance" button https://review.opendev.org/c/openstack/horizon/+/808102 | 07:16 |
| lajoskatona | amotoki: I check your comments in details, due to reorg we lost Nitish who started to work on this is why it lost momentum | 07:45 |
| opendevreview | Thomas Goirand proposed openstack/horizon stable/xena: Fix for "Resize instance" button https://review.opendev.org/c/openstack/horizon/+/829662 | 09:37 |
| opendevreview | Thomas Goirand proposed openstack/horizon stable/wallaby: Fix for "Resize instance" button https://review.opendev.org/c/openstack/horizon/+/829663 | 09:38 |
| zigo | vishalmanchanda: I was able to succesfully backport the patch to Wallaby and Xena, but I failed having unit testing to work in Victoria, even though the issue is fixed (we tried in our preprod env). Indeed, openstack_dashboard/dashboards/project/instances/tests.py changed quite a bit between Victoria and Wallaby. | 09:39 |
| zigo | Do you think you can do the backport work for Victoria? | 09:39 |
| zigo | Victoria is important for me, because that's what is in Debian Bullseye, and I'd love to have it fixed properly so I can convince the Debian Stable release team in an easier way that it's safe to upgrade. | 09:40 |
| zigo | vmarkov: Maybe *you* have a working Victoria version of the patch? | 09:41 |
| vishalmanchanda | zigo: ok, I will take a look and purpose a patch for ussuri and victoria stable branches. | 09:45 |
| zigo | Great, thanks ! | 09:46 |
| hemanth_n | zigo: thanks for the backport patches. (Infact i am about to submit backport patches and saw you already did :-) ) | 09:55 |
| opendevreview | Vishal Manchanda proposed openstack/horizon stable/victoria: Fix for "Resize instance" button https://review.opendev.org/c/openstack/horizon/+/829686 | 11:59 |
| vishalmanchanda | zigo: ^^ | 12:00 |
| opendevreview | Lajos Katona proposed openstack/horizon master: Add Rules operation to Network QoS Policy https://review.opendev.org/c/openstack/horizon/+/805360 | 12:33 |
| opendevreview | Lajos Katona proposed openstack/horizon master: Add Rules operation to Network QoS Policy https://review.opendev.org/c/openstack/horizon/+/805360 | 12:40 |
| ganso | vishalmanchanda: thanks for the RP+1 and recheck! =) | 12:46 |
| zigo | vishalmanchanda: Great, thanks a lot and well done! Let me see what I couldn't do ... :P | 12:46 |
| amotoki | lajoskatona: thanks for the update. I understand the situation. I will check it again. | 14:15 |
| lajoskatona | amotoki: I addressed your comments | 14:38 |
| amotoki | lajoskatona: yeah, I saw it, thanks :) | 14:39 |
| lajoskatona | amotoki: for the visible edit/delete actions even of there's no item to edit/delete I try to find somebody who can work on it | 14:39 |
| amotoki | lajoskatona: for that, I think we can improve it later. at the moment, I think the current behavior is okay. | 14:40 |
| lajoskatona | amotoki: thanks | 14:47 |
| opendevreview | Rodrigo Barbieri proposed openstack/horizon stable/ussuri: Fix for "Resize instance" button https://review.opendev.org/c/openstack/horizon/+/829706 | 16:31 |
| *** eandersson8 is now known as eandersson | 17:19 | |
| *** kopecmartin_ is now known as kopecmartin | 19:11 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!