| opendevreview | Vishal Manchanda proposed openstack/horizon master: Drop lower-constraints.txt and its testing https://review.opendev.org/c/openstack/horizon/+/840220 | 12:38 |
|---|---|---|
| opendevreview | Vishal Manchanda proposed openstack/horizon master: Drop Nodejs14 job https://review.opendev.org/c/openstack/horizon/+/845133 | 13:25 |
| *** whoami-rajat__ is now known as whoami-rajat | 14:16 | |
| vishalmanchanda | #startmeeting horizon | 15:00 |
| opendevmeet | Meeting started Wed Jun 8 15:00:33 2022 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| vishalmanchanda | hi | 15:01 |
| tmazur | o/ | 15:01 |
| rdopiera | o/ | 15:02 |
| vishalmanchanda | There is no topic added in etherpad for today's discussion https://etherpad.opendev.org/p/horizon-release-priorities#L39 | 15:03 |
| vishalmanchanda | I also have no update for this week. | 15:04 |
| rdopiera | \o/ | 15:04 |
| vishalmanchanda | So moving to open-discussion. | 15:04 |
| vishalmanchanda | #topic Open-discussion | 15:04 |
| tmazur | I want to talk about AngularJS update :) | 15:05 |
| vishalmanchanda | tmazur: ok please go ahead. | 15:05 |
| tmazur | Apparently the patches https://review.opendev.org/c/openstack/requirements/+/843505 and https://review.opendev.org/c/openstack/horizon/+/843346 are kind of depend on each other | 15:05 |
| vishalmanchanda | tmazur: yes | 15:06 |
| vishalmanchanda | tmazur: So, I have one question | 15:06 |
| tmazur | The horizon one needs a new requirement, and the requirements one needs fixes from horizon | 15:06 |
| vishalmanchanda | tmazur: What if you don't update 'requirements.txt' in horizon patch | 15:07 |
| vishalmanchanda | https://review.opendev.org/c/openstack/horizon/+/843346/1/requirements.txt | 15:07 |
| tmazur | vishalmanchanda: that's exactly what I'm thinking about | 15:07 |
| tmazur | It seems the only one reasonable option to have them both | 15:07 |
| vishalmanchanda | You can update requirements.txt after you bump angular version in openstack/requirements | 15:07 |
| vishalmanchanda | tmazur: yeah that should work. | 15:08 |
| amotoki | tmazur: can we make horizon work with AngularJS 1.5.8 and 1.8.2? If possible it would be ideal | 15:09 |
| tmazur | I don't know, I haven't tried yet. | 15:10 |
| amotoki | tmazur: np. if it is possbile, we can land the horizon patch first and then update the upper-constraints.txt | 15:11 |
| tmazur | I will, and if my changes work with 1.5.8, keeping the old version until the requirements patch is merged is the solution | 15:11 |
| amotoki | I am also afraid that bumping AngularJS to 1.8.2 would break AngularJS based plugins considering the current test failure in the requirements patch. | 15:11 |
| tmazur | amotoki: yes | 15:11 |
| vishalmanchanda | :( | 15:12 |
| tmazur | I am going to write some notes on what I did to make Horizon work with the new version. That should help with plugins too | 15:13 |
| amotoki | I am a fan of upgading AngularJS to 1.8.2, but at least it would be better to try some (1 or 2?) plugins. it will show how simple the upgrade is. | 15:13 |
| amotoki | on the other hand, we are in the middle of the dev cycle, so it would be a good chance to upgrade AngularJS. | 15:14 |
| amotoki | tmazur: thanks. let's try | 15:14 |
| tmazur | Ok, so the plan is: I'll see first if my changes work with 1.5.8. If yes, we can merge the patch and then go with upper constraints | 15:16 |
| vishalmanchanda | I am just wondering why 'horizon-cross-ironic-ui-npm' didn't run on patch https://review.opendev.org/c/openstack/horizon/+/843346 | 15:16 |
| vishalmanchanda | tmazur: yes, if that works we can cut a new release of horizon that work with both angular version 1.5.8 and 1.8.2 | 15:18 |
| vishalmanchanda | tmazur: don't worry about release thing, I can take care of that. | 15:20 |
| vishalmanchanda | We follow the same approch during Django migration. | 15:20 |
| vishalmanchanda | about testing the plugins we can push a DNM patch in horizon adding horizon-cross-npm job for plugins using angularjs. | 15:23 |
| tmazur | vishalmanchanda: that's a good idea | 15:23 |
| amotoki | vishalmanchanda: re: cross-ironic-ui, https://opendev.org/openstack/horizon/src/branch/master/.zuul.d/cross-jobs.yaml#L22 | 15:24 |
| amotoki | the parent job is nodejs *10* surprisingly | 15:24 |
| vishalmanchanda | amotoki: oops, I will update that. | 15:25 |
| amotoki | but I am not sure why zuul config-error is detected | 15:25 |
| vishalmanchanda | Does anyone have any other topic to discuss? | 15:27 |
| amotoki | I just would like to request reviews https://review.opendev.org/c/openstack/horizon/+/829629 and https://review.opendev.org/c/openstack/horizon/+/830936 | 15:27 |
| amotoki | the first one is just a maintenance patch | 15:28 |
| amotoki | I would like to have the latter in a backport. Otherwise, UT coverage in the backport is nothing. | 15:28 |
| vishalmanchanda | I have already reviewed both of the patches. | 15:29 |
| vishalmanchanda | tmazur: rdopiera : Please take a look. | 15:29 |
| tmazur | will do | 15:29 |
| vishalmanchanda | thanks | 15:29 |
| amotoki | thanks | 15:30 |
| vishalmanchanda | If no other topic to discuss, let's end this meeting. | 15:32 |
| vishalmanchanda | Thanks everyone for your contribution! | 15:32 |
| vishalmanchanda | See you next week. | 15:32 |
| tmazur | Thanks everyone! | 15:32 |
| vishalmanchanda | #endmeeting | 15:32 |
| opendevmeet | Meeting ended Wed Jun 8 15:32:59 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:32 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-06-08-15.00.html | 15:32 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-06-08-15.00.txt | 15:32 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-06-08-15.00.log.html | 15:32 |
| amotoki | o/ | 15:33 |
| *** whoami-rajat__ is now known as whoami-rajat | 15:38 | |
| opendevreview | Tobias Urdin proposed openstack/horizon master: Update OPENSTACK_ENDPOINT_TYPE documentation https://review.opendev.org/c/openstack/horizon/+/844573 | 16:16 |
| opendevreview | Tobias Urdin proposed openstack/horizon master: Add OPENSTACK_KEYSTONE_ENDPOINT_TYPE config opt https://review.opendev.org/c/openstack/horizon/+/844574 | 16:17 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: Update nodejs version in parent job of "horizon-cross-ironic-ui-npm" https://review.opendev.org/c/openstack/horizon/+/845158 | 16:33 |
| opendevreview | Tatiana Ovchinnikova proposed openstack/horizon master: Migrate to AngularJS v1.8.2 https://review.opendev.org/c/openstack/horizon/+/843346 | 19:07 |
| opendevreview | Tatiana Ovchinnikova proposed openstack/horizon master: Migrate to AngularJS v1.8.2 https://review.opendev.org/c/openstack/horizon/+/843346 | 20:43 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!