| opendevreview | Akihiro Motoki proposed openstack/horizon master: Workaround for NBSP in application credential form https://review.opendev.org/c/openstack/horizon/+/870885 | 07:29 |
|---|---|---|
| opendevreview | Merged openstack/horizon master: Fix Image Filter for images with None names https://review.opendev.org/c/openstack/horizon/+/869400 | 07:46 |
| opendevreview | Akihiro Motoki proposed openstack/horizon master: Preparation for Django 4.0 https://review.opendev.org/c/openstack/horizon/+/851261 | 08:12 |
| opendevreview | Akihiro Motoki proposed openstack/horizon master: Make site_branding tag work with Django 4.0 https://review.opendev.org/c/openstack/horizon/+/851262 | 08:12 |
| opendevreview | Akihiro Motoki proposed openstack/horizon master: Django 4.x: fix csrf reason list https://review.opendev.org/c/openstack/horizon/+/848100 | 08:12 |
| opendevreview | Akihiro Motoki proposed openstack/horizon stable/xena: Add a Note Under Install and configure Section in documentation https://review.opendev.org/c/openstack/horizon/+/870895 | 09:02 |
| vishalmanchanda | #startmeeting horizon | 15:00 |
| opendevmeet | Meeting started Wed Jan 18 15:00:10 2023 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| rdopiera | o/ | 15:00 |
| vishalmanchanda | Hello everyone | 15:01 |
| amotoki | hi | 15:01 |
| tmazur | o/ | 15:02 |
| vishalmanchanda | There is no topic added in our agenda etherpad for today's meeting https://etherpad.opendev.org/p/horizon-release-priorities#L34 | 15:02 |
| vishalmanchanda | I also have no update to share for this week. | 15:03 |
| vishalmanchanda | So directly going to open-discussion | 15:04 |
| vishalmanchanda | #topic open-discussion | 15:04 |
| vishalmanchanda | if anyone have some topic to discuss, please go ahead. | 15:04 |
| rdopiera | so I talked with the MoinMoin developers about the xstatic packages | 15:05 |
| rdopiera | we agreed that two of the packages that are currently under the openstack org should be maintained by the moinmoin project instead | 15:06 |
| rdopiera | the discussion is here: https://github.com/moinwiki/moin/issues/1326 | 15:07 |
| rdopiera | so the next step would be to basically remove xstatic-font-awesome and xstatic-jquery.tablesorter from the opendstack org | 15:07 |
| vishalmanchanda | if someone don't know what radomir is discussing please go through the logs of last weekly meeting https://meetings.opendev.org/irclogs/%23openstack-horizon/%23openstack-horizon.2023-01-11.log.html#t2023-01-11T15:24:31 | 15:08 |
| rdopiera | I'm not sure who has the power to actually do that, I was planning to write an e-mail on the mailing list about it | 15:08 |
| amotoki | one question: do they accept xstatic-font-awesome update even when they have no need for update (from POV of moinmoin)? | 15:08 |
| rdopiera | yes | 15:09 |
| rdopiera | they have accepted updates for jquery previously | 15:09 |
| rdopiera | and several other packages under their care | 15:09 |
| rdopiera | related to this, we should probably pin all versions of our xstatic packages | 15:10 |
| amotoki | because these PyPI packages are now external, right? | 15:11 |
| rdopiera | only those two | 15:11 |
| rdopiera | we keep all the rest | 15:11 |
| amotoki | thanks. same as my understanidng | 15:11 |
| vishalmanchanda | I can purpose a patch to pin all versions of our xstatic packages. | 15:13 |
| amotoki | can't we depend on upper-constraints instead of pinning them? | 15:14 |
| amotoki | if some new package breaks horizon, we can block it. I think it is what we usually do. | 15:15 |
| vishalmanchanda | amotoki: that is also fine. | 15:16 |
| vishalmanchanda | I noticed one more thing. | 15:16 |
| vishalmanchanda | upper-constraint for any xstatic package will not be bumped in openstack/requirements until we done a release for that | 15:18 |
| vishalmanchanda | For e.g. we updated xstatic-angular https://review.opendev.org/c/openstack/xstatic-angular/+/843342 and then done a release for the same https://review.opendev.org/c/openstack/releases/+/843670 | 15:19 |
| amotoki | vishalmanchanda: if a library is our (i.e. openstack) deliverable, u-c is only updated when a release is cut. | 15:20 |
| vishalmanchanda | after that it is updated here https://review.opendev.org/c/openstack/requirements/+/844099 | 15:20 |
| amotoki | if a library is external, a periodic job checks it and propose an update of u-c file | 15:20 |
| vishalmanchanda | but then why xstatic-font-awesome latest version is used? | 15:21 |
| vishalmanchanda | https://pypi.org/project/XStatic-Font-Awesome/ | 15:21 |
| vishalmanchanda | it is still using older version https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L68 | 15:22 |
| amotoki | vishalmanchanda: where is the new xstatic-font-awesome used? | 15:23 |
| vishalmanchanda | I mean we are not using new version | 15:23 |
| amotoki | so, what is a problem? | 15:25 |
| rdopiera | the original problem was that the TC was concerned that a release was made of the font awesome without following the openstack release process | 15:27 |
| rdopiera | despite the fact that it was hosted on opendev | 15:27 |
| rdopiera | turns out that when we adopted all those xstatic packages into opendev, we mistakenly took those two packages which were actually being maintained by moinmoin, thinking they are unmaintained | 15:28 |
| rdopiera | (note that like all open source projects, the moinmoin wiki project had a bit of worse years lately) | 15:29 |
| gmann | and if xstatic-font-awesome is not maintained by external maintainer (non-openstack) then it is fine to handover to them and horizon can be one of the user? unless they want to come and contribute/maintain as pert of openstack ? | 15:31 |
| amotoki | I think I understand the original problem above | 15:31 |
| gmann | because currently xstatic-font-awesome is one of the Horizon deliverables https://governance.openstack.org/tc/reference/projects/horizon.html#deliverables | 15:32 |
| amotoki | what I don't understand is vishalmanchanda noticed that u-c was not updated and I am not what is a prbolem | 15:32 |
| rdopiera | gmann: they are happy to maintain those two packages, they find the opendev/openstack process to be too heavy and slow for themn | 15:32 |
| vishalmanchanda | amotoki: sorry for confusion. | 15:32 |
| amotoki | * I am not sure what is a problem | 15:32 |
| gmann | rdopiera: I see, I can understand that. | 15:32 |
| gmann | amotoki: ohk | 15:33 |
| vishalmanchanda | rdopiera: for removing static-font-awesome and xstatic-jquery.tablesorter from the opendstack org, we have to follow the same process we did for django-openstack-auth | 15:34 |
| gmann | I think if they are happy and horizon team also ok then we can proceed to move them out from horizon deliverables and use as they are maintained outside like any other deps | 15:34 |
| vishalmanchanda | rdopiera: see https://review.opendev.org/c/openstack/governance/+/800471 | 15:34 |
| vishalmanchanda | https://review.opendev.org/q/topic:retire-django-openstack-auth | 15:35 |
| gmann | it seems they are and will maintain it in https://github.com/FortAwesome/Font-Awesome ? and not in https://github.com/openstack/xstatic-font-awesome ? | 15:36 |
| amotoki | gmann: the github repo you mentioned is the upstream of font-awesome | 15:37 |
| gmann | former is the location in PyPi page "repository" https://pypi.org/project/XStatic-Font-Awesome/ | 15:37 |
| amotoki | there is no repo for xstatic-font-awesome after we drop our xstaic-font-awesome repo | 15:37 |
| gmann | amotoki: ohk, that is linked in PyPi page which seems incorrect | 15:38 |
| amotoki | gmann: this is what I would like to ask too | 15:38 |
| rdopiera | gmann: they are going to be kept either in https://github.com/xstatic-py or https://github.com/python-xstatic, depending on which one they decide is going to be the canonical one (right now some are in one and some are in the other) | 15:38 |
| gmann | ohk | 15:39 |
| rdopiera | gmann: the repository ulr on pypi is the link to the original project being packaged, not the xstatic repo | 15:39 |
| rdopiera | I suggested it should be made more clear too | 15:39 |
| gmann | yeah | 15:39 |
| gmann | I think in any case, we can do the retirement which will reflect in opendev repo as well as in https://github.com/openstack/xstatic-font-awesome | 15:39 |
| rdopiera | we should probably update our pypi links as well | 15:39 |
| amotoki | rdopiera: great. that's what I would like to ask :-) | 15:39 |
| gmann | +1 | 15:40 |
| rdopiera | we should probably update our pypi links as well | 15:40 |
| rdopiera | sorry, double message | 15:40 |
| amotoki | np | 15:40 |
| gmann | if we go with the retirement process then same will reflect in README.rst for opendev repo as well as in https://github.com/openstack/xstatic-font-awesome | 15:41 |
| gmann | and we can mention the location they are maintaining it in case anyone want to help them | 15:41 |
| amotoki | gmann: +1 | 15:41 |
| amotoki | vishalmanchanda: a governance patch is not a thing we need to do. let's follow the retirement process documented in the project team guide. | 15:42 |
| amotoki | * is not an only thing * | 15:42 |
| vishalmanchanda | amotoki: sure. | 15:42 |
| gmann | +1 on complete retirement process. | 15:42 |
| gmann | amotoki: thanks for pointing that, otherwise we left with many cleanup for retired repo :) | 15:43 |
| amotoki | :-) | 15:43 |
| amotoki | besides xstatic-font-awesome, is it better that we check the current maintainers of other xstatic packages hosted by openstack? | 15:43 |
| amotoki | i mean maintainers of PyPI packages | 15:43 |
| rdopiera | yes, we should remove rob at least | 15:43 |
| vishalmanchanda | agreed | 15:44 |
| gmann | +1, that is next question/audit TC would like every project to ask as part of the PyPi maintainer cleanup | 15:44 |
| gmann | please do | 15:44 |
| rdopiera | probably remove me as well, so it's not repeated when I don't work on openstack anymore | 15:44 |
| gmann | TC is planning to keep only 'openstackci' only in PyPi maintainer list | 15:44 |
| rdopiera | that's sane | 15:44 |
| vishalmanchanda | gmann: +1. | 15:44 |
| rdopiera | not sure I can remove myself | 15:45 |
| rdopiera | I will try | 15:45 |
| gmann | rdopiera: thanks, or I think any existing member can do addition/remove but let me know. TC will reach to opendev admin to do those cleanup for many other repo too. | 15:45 |
| vishalmanchanda | I will start the retirement process as mentioned here https://docs.openstack.org/project-team-guide/repository.html#retiring-a-repository once rdopiera send the mail that we are retiring these project from openstack tree. | 15:48 |
| gmann | thanks amotoki vishalmanchanda rdopiera for discussing and handling it. | 15:49 |
| amotoki | gmann: you too | 15:50 |
| vishalmanchanda | Does anyone have any other topic to discuss? | 15:52 |
| amotoki | I have a topic on a sec bug about agnular in older branches | 15:52 |
| amotoki | but it is a sec issue so I will send a mail to you | 15:53 |
| vishalmanchanda | amotoki: I was also looking at same bug... | 15:53 |
| vishalmanchanda | amotoki: sure let's discuss it on mail. | 15:53 |
| vishalmanchanda | if no other topic to discuss, let's end this meeting and triage some bugs. | 15:54 |
| vishalmanchanda | Thanks everyone for joining, see you next week. | 15:55 |
| amotoki | o/ | 15:55 |
| vishalmanchanda | #endmeeting | 15:55 |
| opendevmeet | Meeting ended Wed Jan 18 15:55:39 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:55 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-01-18-15.00.html | 15:55 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-01-18-15.00.txt | 15:55 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-01-18-15.00.log.html | 15:55 |
| opendevreview | Tatiana Ovchinnikova proposed openstack/horizon stable/zed: Fix instance error with attribute cells. https://review.opendev.org/c/openstack/horizon/+/870900 | 16:50 |
| opendevreview | Jan Jasek proposed openstack/horizon stable/yoga: Fix instance error with attribute cells. https://review.opendev.org/c/openstack/horizon/+/870901 | 17:21 |
| opendevreview | Jan Jasek proposed openstack/horizon stable/xena: Fix instance error with attribute cells. https://review.opendev.org/c/openstack/horizon/+/870902 | 17:21 |
| opendevreview | Jan Jasek proposed openstack/horizon stable/wallaby: Fix instance error with attribute cells. https://review.opendev.org/c/openstack/horizon/+/870903 | 17:22 |
| *** gmann is now known as gmann_afk | 17:29 | |
| *** gmann_afk is now known as gmann | 17:41 | |
| opendevreview | Tatiana Ovchinnikova proposed openstack/horizon stable/zed: Integration test navigation machinery for Angular pages https://review.opendev.org/c/openstack/horizon/+/870904 | 17:44 |
| opendevreview | Tatiana Ovchinnikova proposed openstack/horizon stable/yoga: Integration test navigation machinery for Angular pages https://review.opendev.org/c/openstack/horizon/+/870905 | 17:44 |
| *** gmann is now known as gmann_afk | 18:06 | |
| *** gmann_afk is now known as gmann | 18:56 | |
| opendevreview | Tatiana Ovchinnikova proposed openstack/horizon stable/xena: Integration test navigation machinery for Angular pages https://review.opendev.org/c/openstack/horizon/+/871002 | 21:29 |
| opendevreview | Tatiana Ovchinnikova proposed openstack/horizon stable/wallaby: Integration test navigation machinery for Angular pages https://review.opendev.org/c/openstack/horizon/+/870906 | 21:31 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!