opendevreview | Vishal Manchanda proposed openstack/xstatic-font-awesome master: Retire xstatic-font-awesome https://review.opendev.org/c/openstack/xstatic-font-awesome/+/872106 | 12:33 |
---|---|---|
opendevreview | Vishal Manchanda proposed openstack/horizon master: Remove reference of xstatic-font-awesome https://review.opendev.org/c/openstack/horizon/+/872410 | 13:40 |
vishalmanchanda | #startmeeting horizon | 15:00 |
opendevmeet | Meeting started Wed Feb 1 15:00:21 2023 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
vishalmanchanda | hi anyone around for horizon weekly meeting? | 15:02 |
vishalmanchanda | rdopiera: tmazur amotoki : ping for horizon weekly meeting | 15:03 |
tmazur | o/ | 15:04 |
rdopiera | o/ | 15:04 |
vishalmanchanda | let's start the meeting | 15:04 |
vishalmanchanda | agenda of meeting can found here https://etherpad.opendev.org/p/horizon-release-priorities#L34 | 15:04 |
vishalmanchanda | #topic Notices | 15:04 |
vishalmanchanda | I have two announcements for this week. | 15:05 |
vishalmanchanda | moving stable rocky branch to EOL | 15:05 |
vishalmanchanda | Release team sent a mail about moving the stable rocky branch to EOL. | 15:06 |
vishalmanchanda | Please see https://lists.openstack.org/pipermail/openstack-discuss/2023-January/031922.html | 15:06 |
vishalmanchanda | I am fine with moving the horizon stable/rocky branch to EOL. | 15:07 |
vishalmanchanda | The last patch merged in the horizon for the stable/rocky branch is in March 2021. | 15:07 |
vishalmanchanda | https://review.opendev.org/q/project:openstack%252Fhorizon+branch:stable%252Frocky+status:merged | 15:07 |
vishalmanchanda | Please let me know if anyone have any objection with moving stable/rocky for horizon to EOL. | 15:08 |
vishalmanchanda | I consider it as no obejction here. | 15:09 |
vishalmanchanda | moving to the next announcement | 15:10 |
vishalmanchanda | Combined PTL+TC elections | 15:10 |
vishalmanchanda | Nomination for PTL+TC election will start today Feb 01, 2023 at 23:45 UTC. | 15:10 |
vishalmanchanda | Deadline for PTL+TC nomination is Feb 15, 2023 23:45 UTC. | 15:11 |
vishalmanchanda | For more info. please refer https://lists.openstack.org/pipermail/openstack-discuss/2023-January/031960.html | 15:11 |
vishalmanchanda | I have no other announcements to make, if anyone have any announcement to make. please go ahead | 15:11 |
vishalmanchanda | moving to next topic | 15:12 |
vishalmanchanda | #topic On-Demand Agenda | 15:12 |
vishalmanchanda | Xstatic Packagaes Audit | 15:13 |
vishalmanchanda | I have done a audit for the XStatic Packages which horizon is using. | 15:13 |
vishalmanchanda | Please take a look https://etherpad.opendev.org/p/openstack-pypi-maintainers-cleanup#L58 | 15:14 |
vishalmanchanda | There are many packages like xstatic-font-awesome which have external maintainers | 15:15 |
amotoki | hi, sorry for late | 15:15 |
vishalmanchanda | I would like to discuss what we should do with those packages. | 15:15 |
vishalmanchanda | amotoki: hello | 15:15 |
vishalmanchanda | xstatic, xstatic-jquery, xstatic-font-awosome, xstatic-jquery-ui are also used by moinmoin | 15:16 |
vishalmanchanda | I guess they are happy to maintain it. | 15:17 |
vishalmanchanda | I will check with them about xstatic, xstatic-jquery packages wether they can maintain it or not like we did for xstatic-font-awosome | 15:18 |
amotoki | vishalmanchanda: question: what repos are listed? horizon dependencies or openstack maintained repos? | 15:18 |
amotoki | i am confused. | 15:18 |
amotoki | s/repos/PyPI packages/ | 15:18 |
amotoki | for example, xstatic is not under openstack | 15:19 |
vishalmanchanda | amotoki: yeah you are right, that things I missed to check. | 15:20 |
vishalmanchanda | amotoki: will check that after the meeting and update in etherpad. | 15:20 |
amotoki | in my understanding, what we need to check are xstatic pypi package listed at https://governance.openstack.org/tc/reference/projects/horizon.html#deliverables | 15:21 |
vishalmanchanda | amotoki: yeah. | 15:22 |
amotoki | in addition, perhaps we would like to cover https://opendev.org/x/xstatic-angular-fileupload | 15:23 |
gmann | vishalmanchanda: amotoki: there is extracted list of packages which has additional pypi developers so horizon repo in that list can be audited https://gist.github.com/knikolla/7303a65a5ddaa2be553fc6e54619a7a1 | 15:23 |
amotoki | yeah, we used this list when neutron team discussed it | 15:24 |
gmann | +1 | 15:25 |
vishalmanchanda | gmann: ok, thanks | 15:25 |
vishalmanchanda | What we should do with repos like https://opendev.org/x/xstatic-angular-fileupload which have external maintainer like jsomara ? | 15:27 |
vishalmanchanda | see https://etherpad.opendev.org/p/openstack-pypi-maintainers-cleanup#L65 | 15:27 |
amotoki | the point around xstatic-angular-fileupload is that it is under not "openstack" namespace but "x" namaspace | 15:28 |
amotoki | so it is considered as third party PyPI package, but IIRC horizon team is the only maintainer | 15:28 |
vishalmanchanda | amotoki: that I understood. | 15:29 |
amotoki | it is not openstack deliverable so it is not a target of our current pypi audit | 15:30 |
amotoki | but perhaps we need to discuss its future and maintenance | 15:30 |
amotoki | it is not directly related to the audit, but relaeted from POV of xstatic maintenance | 15:31 |
vishalmanchanda | my question is we should remove jsomara, robcresswell and keep openstackci as a maintainer? | 15:31 |
amotoki | on which PyPI one? | 15:32 |
vishalmanchanda | fro pypi like xstatic-angular-fileupload | 15:32 |
amotoki | it is not an OpneStack deliverable | 15:33 |
amotoki | so openstackci is not actually used | 15:33 |
amotoki | and i wonder openstackci would not like to be a maintainer for such case | 15:34 |
vishalmanchanda | amotoki: ok got it, thanks for clarifying. | 15:34 |
amotoki | this is an opposite case of our current audit | 15:35 |
vishalmanchanda | ok | 15:35 |
amotoki | in case of xstatic-angular-fileupload, we first need to disucss its maintenance as x/xstatic-angular-fileupload repo | 15:35 |
vishalmanchanda | what about repos like xstatic-roboto-fontface which come under horizon deliverables and has external maintainers and not active maintainers | 15:37 |
amotoki | i think we can contact Rob and ask him to add openstackci | 15:39 |
vishalmanchanda | xstatic-roboto-fontface Maintainers: hurgleburgler(Looks External maintainer), openstackci, robcresswell(not active in openstack from long time) | 15:39 |
vishalmanchanda | openstackci is already maintainer there | 15:39 |
amotoki | at least, he replied in the github issue comment on xstatic-font-awesome | 15:39 |
vishalmanchanda | amotoki: yes | 15:39 |
amotoki | ah I see | 15:39 |
vishalmanchanda | https://etherpad.opendev.org/p/openstack-pypi-maintainers-cleanup#L105 | 15:39 |
vishalmanchanda | shoudl we remove hurgleburgler and robscresswell as a maintainer? | 15:40 |
amotoki | do we want to discuss one by one? | 15:40 |
amotoki | can we discuss our direction in general? | 15:41 |
vishalmanchanda | I guess we should discuss in general and follow the same thing for all pypi. | 15:41 |
vishalmanchanda | rdopiera: what you think, should we remove these external and inactive maintainers? | 15:43 |
vishalmanchanda | rdopiera: you are also a maintainers in lot of these packages. | 15:43 |
amotoki | Looking at the etherpad, richard is ex-horizon PTL. perhaps hurgleburgler and MaxV were involved in horizon when we worked on xstatic. | 15:46 |
rdopiera | vishalmanchanda: yes, totally | 15:48 |
amotoki | I am not sure about jsomara | 15:48 |
rdopiera | he's not working on openstack anymore | 15:48 |
vishalmanchanda | rdopiera:ok. | 15:49 |
amotoki | I am fine to drop all maintainers except openstackci and rdopiera from openstack PyPI deliverables | 15:50 |
vishalmanchanda | rdopiera: should we keep you as a maintainer or only openstackci? | 15:50 |
vishalmanchanda | amotoki: +1. | 15:50 |
rdopiera | vishalmanchanda: I think it should only be openstackci | 15:50 |
vishalmanchanda | rdopiera: noted | 15:50 |
amotoki | sounds good | 15:51 |
vishalmanchanda | I will update the same in etherpad https://etherpad.opendev.org/p/openstack-pypi-maintainers-cleanup#L58 | 15:51 |
vishalmanchanda | gmann: what about pypi like https://opendev.org/x/xstatic-angular-fileupload which is not a horizon deliverable but openstackci as a maintainer? | 15:52 |
gmann | vishalmanchanda: we need to cover openstack deliverables first. which is nothing but openstack/ namespace | 15:53 |
vishalmanchanda | Also who will take care of removing all these maintainers for horizon xstatic packages? | 15:53 |
gmann | vishalmanchanda: we will discuss that in TC once audit are comopleted | 15:53 |
gmann | completed | 15:53 |
vishalmanchanda | gmann: +1. | 15:53 |
vishalmanchanda | gmann: thanks, I will update this info. in the etherpad. | 15:54 |
amotoki | we first need to discuss the future of xstatic-angular-fileupload | 15:54 |
amotoki | the future would be either to become an openstack deliverable or to keep it external and drop openstackci from pypi maintainer | 15:55 |
amotoki | I think openstackci pypi account is dedicated to openstack deliverables | 15:55 |
vishalmanchanda | second option: drop openstackci from pypi maintainer looks convenient to me now. | 16:01 |
vishalmanchanda | In future if we want a new release for xstatic-angular-fileupload we can add it under OpenStack deliverable and do that. | 16:02 |
vishalmanchanda | amotoki: rdopiera tmazur : what's your opinion on both options? | 16:03 |
vishalmanchanda | gmann: ^^ | 16:04 |
amotoki | one downside on dropping openstckci from xstatic-angular-fileupload is that it means we no longerr have active maintainers in x-a-fileupload PyPI...... | 16:05 |
vishalmanchanda | amotoki: but above you are saying. it is not an OpneStack deliverable so openstackci is not actually used. | 16:07 |
amotoki | it is a horizon dependency, so my one cent is to move it to openstack | 16:07 |
vishalmanchanda | amotoki: I am also fine with that. | 16:07 |
vishalmanchanda | not sure why it is dropped in the past from horizon deliverables. | 16:07 |
vishalmanchanda | ok let's move pypi like xstatic-angular-fileupload under horizon deliverables and remove external maintainers and keep openstackci as only maintainer. | 16:09 |
vishalmanchanda | Does anyone have any issue with that? | 16:10 |
amotoki | +1 | 16:11 |
vishalmanchanda | I considered it as no objection in that. | 16:11 |
rdopiera | +1 | 16:11 |
vishalmanchanda | I will update this in etherpad and start the process to include under horizon deliverables. | 16:12 |
vishalmanchanda | I have one more update | 16:12 |
vishalmanchanda | I strated the retiring process for xstatic-font-awesome | 16:13 |
vishalmanchanda | Please take a look https://review.opendev.org/q/topic:retire-xstatic-font-awesome | 16:13 |
vishalmanchanda | Does anyone have any other topic to discuss? | 16:14 |
rdopiera | I asked about that tablesorter in the git issue, and Reimar said it's fine to leave it under OpenStack... sigh. Sorry for this. | 16:15 |
vishalmanchanda | rdopiera: tmazur : Can you take a look at https://review.opendev.org/c/openstack/horizon/+/866840 so ironic-ui cross job run in horizon gate. | 16:15 |
rdopiera | it looks like they don't want to maintain it after all | 16:15 |
vishalmanchanda | rdopiera: ok, I saw your comments there https://github.com/moinwiki/moin/issues/1326 | 16:16 |
vishalmanchanda | rdopiera: Now we only need to check about xstatic-jquery | 16:17 |
vishalmanchanda | rdopiera: they are also maintaing it https://github.com/xstatic-py/xstatic-jquery | 16:18 |
vishalmanchanda | if no other topic to discuss, let's end this meeting. | 16:19 |
vishalmanchanda | Thanks everyone for joining and your contributions. | 16:19 |
vishalmanchanda | See you next week. | 16:19 |
vishalmanchanda | #endmeeting | 16:20 |
opendevmeet | Meeting ended Wed Feb 1 16:20:01 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:20 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-02-01-15.00.html | 16:20 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-02-01-15.00.txt | 16:20 |
opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-02-01-15.00.log.html | 16:20 |
vishalmanchanda | amotoki: any idea why gate is failing here https://review.opendev.org/c/openstack/xstatic-font-awesome/+/872106 ? | 16:21 |
vishalmanchanda | Does it is related to https://review.opendev.org/c/openstack/releases/+/872407 ? | 16:21 |
amotoki | vishalmanchanda: no. you need to merge the first patch about project-config first. | 16:22 |
amotoki | vishalmanchanda: the release job tries to generate python deliverable and your patch drops setup.py, so it fails. | 16:23 |
vishalmanchanda | amotoki: ok, I add Depends-on tag but Ci still fails. | 16:23 |
amotoki | vishalmanchanda: test-release-openstack job already starts and it fetches your project-config patch inside the job | 16:25 |
amotoki | vishalmanchanda: so Depends-on does not help :p | 16:25 |
vishalmanchanda | amotoki: ok, thanks | 16:25 |
opendevreview | Merged openstack/horizon master: Update nodejs version in parent job of "horizon-cross-ironic-ui-npm" https://review.opendev.org/c/openstack/horizon/+/866840 | 18:19 |
opendevreview | Merged openstack/horizon stable/wallaby: Get ports directly instead of via loop https://review.opendev.org/c/openstack/horizon/+/866891 | 23:57 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!