| vishalmanchanda | #startmeeting horizon | 15:00 |
|---|---|---|
| opendevmeet | Meeting started Wed Feb 22 15:00:15 2023 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| vishalmanchanda | hi, anyone around for horizon weekly meeting? | 15:01 |
| vishalmanchanda | I guess, we have no topic for discussion for today's meeting. | 15:06 |
| vishalmanchanda | Just few updates from my sides, if anyone look at meeting logs | 15:06 |
| vishalmanchanda | I have purpose a patch to cut a release of horizon for antelope cycle. | 15:07 |
| vishalmanchanda | I am hoping if we can merge Floating-Ip-PortForwarding feature. | 15:08 |
| vishalmanchanda | https://review.opendev.org/c/openstack/horizon/+/868368 | 15:08 |
| vishalmanchanda | let me know if any other patch you are planning to land in antelope cycle. | 15:08 |
| vishalmanchanda | rdopiera: tmazur amotoki :^^ | 15:09 |
| amotoki | hi | 15:10 |
| amotoki | anything to discuss? | 15:10 |
| vishalmanchanda | amotoki: hello | 15:10 |
| vishalmanchanda | I am just asking the core team if they can review Floating-Ip-PortForwarding feature. | 15:11 |
| vishalmanchanda | It's look good to me now. | 15:11 |
| amotoki | re: FIP port fw patch, at least I am against the version check in the code as we cover such kind of thing in requirements.txt so far. | 15:11 |
| amotoki | do we ahve any reason we need to have a version check in the code rather than requirements.txt? | 15:11 |
| vishalmanchanda | amotoki: you mean this https://review.opendev.org/c/openstack/horizon/+/868368/12/openstack_dashboard/api/neutron.py#938 ? | 15:12 |
| amotoki | vishalmanchanda: yes | 15:12 |
| amotoki | having version requirements in multiple places would be confusing | 15:13 |
| amotoki | this is the main reason | 15:13 |
| vishalmanchanda | amotoki: I am not sure of that, I just mentioned in my review comment that we use microversion for cinder and nove but not sure if we can follow the same in neutron. | 15:14 |
| amotoki | neutron does not have microversion mechanism | 15:14 |
| vishalmanchanda | amotoki: ok. | 15:15 |
| amotoki | when we support a specfic feature, we depend on a specific version of neutronclient or newer | 15:15 |
| amotoki | so it is reasonable to require neutroncleint >= x.y.z | 15:15 |
| amotoki | neutron API consumers need to check which neutron APi extensions aree available to check which features are avaialable | 15:16 |
| vishalmanchanda | amotoki: api extension is also added by the author. | 15:17 |
| amotoki | it is not surprising that a newer release of horizon depends on a newer version of neutronclient | 15:18 |
| vishalmanchanda | amotoki: Could you please drop these comments on the patch about not using version check in code? | 15:18 |
| vishalmanchanda | amotoki: or I can do that. | 15:18 |
| amotoki | vishalmanchanda: sure | 15:18 |
| vishalmanchanda | amotoki: thanks | 15:18 |
| amotoki | in addition, the neturon team plans to switch python bindings for neutron from neutronclient to openstacksdk | 15:19 |
| vishalmanchanda | amotoki: yeah I remember you mentioned that already in previous meeting. | 15:19 |
| amotoki | i think FIP port-fw is supported by openstacksdk, but it would be nice if the author can confirm it is implemented in sdk already | 15:19 |
| vishalmanchanda | amotoki: make sense. | 15:20 |
| amotoki | I will also add a comment on this | 15:20 |
| vishalmanchanda | amotoki: cool | 15:20 |
| vishalmanchanda | amotoki: Do you have any topic to discuss? | 15:21 |
| amotoki | one thing | 15:21 |
| amotoki | does anyone look at https://bugs.launchpad.net/horizon/+bug/2007574 in detail? | 15:21 |
| amotoki | Following a discussion in setuptools, it seems that the issue exist around all xstatic packages | 15:22 |
| amotoki | it looks like that the way used in xstatic packages are discouraged now | 15:23 |
| vishalmanchanda | amotoki: hmm, I didn't receive a notification about this bug. looking at the bug now. | 15:23 |
| vishalmanchanda | amotoki: will go through the github discussion, thanks for bringing it here. | 15:25 |
| amotoki | it was posted to openstack-discuss too | 15:25 |
| amotoki | https://lists.openstack.org/pipermail/openstack-discuss/2023-February/032244.html | 15:25 |
| vishalmanchanda | amotoki: sorry, I missed that mail. | 15:27 |
| amotoki | there are two aspects on this | 15:27 |
| amotoki | the one is taht we need to raise it as a broader discussion around xstatic | 15:28 |
| amotoki | the other one is whether we need to depends on xstatic (as JS lib distributor which mean we continue to ship newer release of xstatic version of JS libs) | 15:28 |
| amotoki | personally I am not so motivated on the first point, although it needs to be addressed in a short-term | 15:29 |
| amotoki | at the moment kolla team pins setuptools version and it does not impact them immediately | 15:30 |
| amotoki | but it should be resolved soon | 15:30 |
| vishalmanchanda | amotoki: just want to confirm they are facing this issue for XStatic-Moment-Timezone pypi only? | 15:34 |
| amotoki | vishalmanchanda: no. it is not limited to a specif xstatic packages | 15:34 |
| amotoki | the second package to be installed would hit the issue | 15:34 |
| amotoki | anyway horizon installation would fail | 15:35 |
| vishalmanchanda | yeah. | 15:36 |
| vishalmanchanda | Don't we have any job in our CI that check such issues? | 15:36 |
| vishalmanchanda | I am investigating this bug now and let's see if found some solution. | 15:38 |
| amotoki | i haven't check how these dependenies are checked | 15:38 |
| amotoki | but it is not limited to openstack world so it would need more disucciosn in the xstatic world | 15:39 |
| vishalmanchanda | yeah because many other people using these pypi facing the same issues. | 15:40 |
| amotoki | I have some referneces | 15:41 |
| amotoki | https://github.com/pypa/setuptools/issues/3824 | 15:41 |
| amotoki | https://github.com/pypa/setuptools/pull/2149 | 15:41 |
| amotoki | the first one was raised by an author who filed the horizon bug | 15:42 |
| amotoki | the latter one is mentioned during the discussion in the first one | 15:42 |
| vishalmanchanda | thanks for the references. | 15:42 |
| amotoki | that's all from me | 15:43 |
| vishalmanchanda | As we have no other topic to discuss, ending this meeting | 15:44 |
| amotoki | I believe rdopiera has his opinion on the xstatic issue too | 15:44 |
| amotoki | I will continue to check it too | 15:44 |
| vishalmanchanda | thanks | 15:45 |
| vishalmanchanda | amotoki: Also, Please drop your comment about version-checking and opensdk and any other asap https://review.opendev.org/c/openstack/horizon/+/868368 | 15:45 |
| vishalmanchanda | #endmeeting | 15:45 |
| opendevmeet | Meeting ended Wed Feb 22 15:45:49 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:45 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-02-22-15.00.html | 15:45 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-02-22-15.00.txt | 15:45 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-02-22-15.00.log.html | 15:45 |
| amotoki | vishalmanchanda: sure | 15:46 |
| opendevreview | Pedro Henrique Pereira Martins proposed openstack/horizon master: Add NAT rules to the floating IP workflow https://review.opendev.org/c/openstack/horizon/+/868368 | 21:35 |
| opendevreview | Vadym Markov proposed openstack/horizon master: Add error handling for Floating IP workflow https://review.opendev.org/c/openstack/horizon/+/873623 | 22:21 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!