opendevreview | Vishal Manchanda proposed openstack/horizon master: Update jQuery click event to remove deprecation warning https://review.opendev.org/c/openstack/horizon/+/880144 | 10:54 |
---|---|---|
opendevreview | Vishal Manchanda proposed openstack/horizon master: Fix deprecated use of 'jQuery.fn.mouseenter()' shorthand event https://review.opendev.org/c/openstack/horizon/+/880151 | 13:20 |
vishalmanchanda | #startmeeting horizon | 15:00 |
opendevmeet | Meeting started Wed Apr 12 15:00:21 2023 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
tmazur | o/ | 15:01 |
vishalmanchanda | hello | 15:01 |
vishalmanchanda | Looks like only two of us for today's meeting. | 15:03 |
vishalmanchanda | let's start the meeting | 15:03 |
amotoki | hi | 15:03 |
vishalmanchanda | agenda of meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L31 | 15:04 |
vishalmanchanda | #topic Notices | 15:04 |
vishalmanchanda | I have pushed the patch to cut final release of stable/xena branch https://review.opendev.org/c/openstack/releases/+/880157 | 15:05 |
vishalmanchanda | Please take a look once you have time. | 15:05 |
vishalmanchanda | Once above patch is merged, I will update the same in https://review.opendev.org/c/openstack/releases/+/878896 | 15:06 |
vishalmanchanda | moving to next announcement | 15:06 |
vishalmanchanda | I am not travelling to Vancouver summit, also I haven't booked horizon slot for horizon in-person PTG in vancouver as I was not sure if anyone of us travelling. | 15:08 |
vishalmanchanda | that's all announcement from my side for this week. | 15:10 |
vishalmanchanda | moving to next topic | 15:10 |
vishalmanchanda | #topic Release priorities | 15:10 |
vishalmanchanda | There is one update from my side on JQuery migration. | 15:11 |
vishalmanchanda | I have pushed some patches this week to fix some deprecated function. | 15:12 |
vishalmanchanda | As of now, I have pushed a separate patch for each deprecated function, If you want I can squash them in a single patch? | 15:13 |
vishalmanchanda | https://review.opendev.org/q/topic:update-jquery | 15:13 |
amotoki | I prsonally prefer separate patches as they clarify what are changed | 15:14 |
amotoki | as long as we have a rasson to squiash them | 15:14 |
amotoki | s/a reasn/no reason/ | 15:15 |
tmazur | +1 for keep them separated | 15:16 |
vishalmanchanda | The only issue with that there will be a lot of patches, I guess but at the same time easy to review as patches are smaller. | 15:16 |
vishalmanchanda | noted, thanks | 15:16 |
vishalmanchanda | Please review them, once you have time. | 15:16 |
amotoki | thanks for pushing them :-) | 15:17 |
vishalmanchanda | amotoki: yw. | 15:17 |
vishalmanchanda | next update from my side, I have open a new bp for improving integration test job https://blueprints.launchpad.net/horizon/+spec/improve-integration-tests | 15:18 |
vishalmanchanda | but there is no progress for this week. | 15:19 |
vishalmanchanda | that's all update from my side on this topic. | 15:20 |
vishalmanchanda | moving to next topic | 15:22 |
vishalmanchanda | #topic open-discussion | 15:22 |
vishalmanchanda | Does anyone have topic or any update to discuss? | 15:22 |
tmazur | Nothing from me today | 15:23 |
amotoki | I see some bugs we need to care | 15:23 |
amotoki | one is https://bugs.launchpad.net/horizon/+bug/2015258 | 15:23 |
amotoki | according to the bug report, there is a regression in zed | 15:24 |
amotoki | another one is https://bugs.launchpad.net/horizon/+bug/2007574 | 15:25 |
amotoki | it is not a new one, but horizon needs to tackle it sooner or later | 15:25 |
amotoki | I think the latter one needs to be considered as critical | 15:26 |
amotoki | because it means horizon cannot be installed in future | 15:26 |
amotoki | that's all from my side | 15:27 |
vishalmanchanda | amotoki: ack. I was unable to reproduce this issue, 2nd one. | 15:28 |
amotoki | re: the first one, it may be a regression in horizon zed as well. | 15:29 |
vishalmanchanda | Do we have to fix something in XStatic-Moment-Timezone pypi, or in horizon side, just asking | 15:29 |
amotoki | vishalmanchanda: why do you mention XStatic-Moment-Timezone especially? | 15:30 |
vishalmanchanda | I am looking at error logs on https://github.com/pypa/setuptools/issues/3824 | 15:31 |
amotoki | vishalmanchanda: if you just looked at the description of the github issue, it is just one of the symptom | 15:32 |
amotoki | vishalmanchanda: it happens depending on the order of xstatic package installation and it could happen for all xstatic packages. | 15:32 |
vishalmanchanda | amotoki: ok, let me try to reproduce it again today in my local env. | 15:33 |
amotoki | I think https://github.com/pypa/setuptools/issues/3824#issuecomment-1432964898 is the highlight | 15:33 |
amotoki | and it explains how to repro it in detail | 15:34 |
amotoki | it needs be fixed in each xstatic package and perhaps we need to move it forward as one of heavy users of xstatic packages | 15:35 |
vishalmanchanda | I will look into this on priority. | 15:37 |
vishalmanchanda | anyone have any other topic to discuss? | 15:40 |
amotoki | none from me | 15:40 |
vishalmanchanda | if no other topic to discuss, let's end this meeting. | 15:40 |
vishalmanchanda | Thanks everyone for joining, See you next week. | 15:41 |
tmazur | Thanks! | 15:41 |
vishalmanchanda | #endmeeting | 15:41 |
opendevmeet | Meeting ended Wed Apr 12 15:41:45 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:41 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-04-12-15.00.html | 15:41 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-04-12-15.00.txt | 15:41 |
opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-04-12-15.00.log.html | 15:41 |
opendevreview | Vishal Manchanda proposed openstack/horizon master: Update jQuery click event to remove deprecation warning https://review.opendev.org/c/openstack/horizon/+/880144 | 16:47 |
opendevreview | Vishal Manchanda proposed openstack/horizon master: Fix deprecation warning for jQuery.fn.keydown() event shorthand https://review.opendev.org/c/openstack/horizon/+/880230 | 19:25 |
opendevreview | Vishal Manchanda proposed openstack/horizon master: Fix deprecation warning for jQuery.fn.keyup() event shorthand https://review.opendev.org/c/openstack/horizon/+/880239 | 20:03 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!