| opendevreview | Vishal Manchanda proposed openstack/horizon master: [DNM] Test chromedriver with integartion job https://review.opendev.org/c/openstack/horizon/+/886867 | 07:44 |
|---|---|---|
| opendevreview | Vishal Manchanda proposed openstack/horizon master: [DNM] Test chromedriver with integartion job https://review.opendev.org/c/openstack/horizon/+/886867 | 14:42 |
| vishalmanchanda | #startmeeting horizon | 15:00 |
| opendevmeet | Meeting started Wed Jun 28 15:00:17 2023 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| tmazur | o/ | 15:00 |
| vishalmanchanda | hello everyone | 15:00 |
| vishalmanchanda | agenda of the meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L32 | 15:02 |
| vishalmanchanda | only two of us:( | 15:04 |
| vishalmanchanda | anyway let's start the meeting | 15:04 |
| vishalmanchanda | I have no announcements for this week. | 15:04 |
| vishalmanchanda | so moving release priorities topic | 15:04 |
| vishalmanchanda | #topic Release priorities | 15:05 |
| vishalmanchanda | horizon-integration job failure. | 15:05 |
| vishalmanchanda | As discussed in the last weekly meeting, I have added a integration job which uses chrome browser. | 15:06 |
| vishalmanchanda | we can also see browser logs for "horizon-integration-tests-with-chrome" job. | 15:08 |
| vishalmanchanda | unfortunately I am not succeed in getting the same issue in my local env. | 15:10 |
| vishalmanchanda | I am trying to get the same error in my local env., so that I can fix those warning which we can see in ``browser.log``. | 15:11 |
| vishalmanchanda | rdopiera: around? | 15:11 |
| rdopiera | vishalmanchanda: sorry I'm late | 15:12 |
| vishalmanchanda | As you suggested to use latest version of selenium, I tried that in our CI job but all tests fail with that version. | 15:12 |
| vishalmanchanda | see https://zuul.opendev.org/t/openstack/build/d8d6833078c94ceabcbab8d808272f81 | 15:12 |
| rdopiera | vishalmanchanda: well, our code is not compatible with the last version of selenium, by "I will try to update selenium" I meant I will work on our code to make it work with it | 15:13 |
| rdopiera | we will want to upgrade it eventually anyways | 15:13 |
| tmazur | I was investigating Volume tests failures, and I've got the same issues on my local env, but that was because I had old cirros image. After fixing it, I was not able to reproduce the issues :/ | 15:13 |
| vishalmanchanda | yeah horizon code not compatible with selenium version 4.1.0 for now. | 15:14 |
| rdopiera | I'm working onit | 15:15 |
| vishalmanchanda | cirros image again got change to 0.6.2 from 0.6.1 version, I have updated in our test patch 886867 | 15:16 |
| rdopiera | I wonder if we could somehow get that image name automatically? | 15:16 |
| vishalmanchanda | tmazur: you are running integration test with chrome or firefox in your local env? | 15:17 |
| tmazur | Both | 15:17 |
| vishalmanchanda | ok | 15:17 |
| vishalmanchanda | did you done any changes in karma.conf file for running it with chrome browser? | 15:18 |
| tmazur | My env is rather old, so I have old cirros image there, but I've just added a new one manually | 15:18 |
| rdopiera | the main problem with chrome right now is that because the instances page refreshes right after starting an instance, we never see the info message that confirms the launch | 15:18 |
| tmazur | Karma.conf is for npm tests, and I was not touching it | 15:18 |
| rdopiera | karma.conf is for the unit tests | 15:18 |
| vishalmanchanda | ohh | 15:18 |
| tmazur | For running it with chrome browser I just manually start the tests like this | 15:20 |
| tmazur | INTEGRATION_TESTS=1 SELENIUM_CHROME=1 pytest ./openstack_dashboard/test/integration_tests --ds=openstack_dashboard.test.settings -v -k test_volumes | 15:20 |
| rdopiera | btw, we should add a pytest.conf file with that --ds=openstack_dashboard.test.settings setting, so that we don't have to specify it each time | 15:21 |
| rdopiera | but that's after we fix everything, of course | 15:21 |
| tmazur | good idea | 15:22 |
| vishalmanchanda | rdopiera: for get that image name automatically, you mean image version doesn't depends on devstack config? | 15:23 |
| vishalmanchanda | for horizon integration job? | 15:23 |
| rdopiera | vishalmanchanda: we could get it from that devstack config | 15:24 |
| vishalmanchanda | hmm | 15:24 |
| rdopiera | or just run an openstack cli command before running the tests to check the image name and populate the test config | 15:24 |
| rdopiera | that's what we do downstream | 15:24 |
| rdopiera | well, not for image name, but for other things, like network name | 15:25 |
| vishalmanchanda | ok | 15:26 |
| rdopiera | but again, let's fix everything first, then we can talk about improvements | 15:27 |
| vishalmanchanda | yeah. | 15:27 |
| rdopiera | I have tested some things with pytest, and I have a lot of ideas for improvements to the tests | 15:27 |
| vishalmanchanda | tmazur: one last question you are using chromium or google-chrome for running the job? | 15:28 |
| tmazur | I have Chrome | 15:29 |
| vishalmanchanda | also on which Os your devstack env. running if you can tell. | 15:29 |
| tmazur | The one with volumes is 18.04 | 15:30 |
| vishalmanchanda | ohh on older env. , integartion jobs are running for me but I am facing issue with ubuntu jammy | 15:30 |
| rdopiera | is it too... jammy? | 15:31 |
| tmazur | yeah, I am planning to deploy a new one. But again, the issue with wrong image looks the same | 15:31 |
| vishalmanchanda | now I will try again with older env. where it is running fine and try to reproduce the issue. | 15:31 |
| vishalmanchanda | with jammy I face many issues. | 15:32 |
| vishalmanchanda | even with firefox I am unable to run horizon-integration job. | 15:32 |
| vishalmanchanda | some firefox profile issue. | 15:32 |
| tmazur | Do we run our tests on jammy? | 15:32 |
| rdopiera | firefox really became the new msie | 15:33 |
| vishalmanchanda | for our CI we are now using debian-bullseye | 15:33 |
| tmazur | vishalmanchanda, thanks | 15:34 |
| vishalmanchanda | because again some snap package issue with ubuntu jammy for horizon integration job | 15:34 |
| vishalmanchanda | I am fine with skipping 4-5 tests to at least make the CI green for now. | 15:35 |
| vishalmanchanda | because CI is failing for almost 3 weeks for now. | 15:35 |
| vishalmanchanda | Do we have any other topic to discuss? | 15:42 |
| vishalmanchanda | #topic open-discussion | 15:44 |
| vishalmanchanda | If no other topic to discuss, let's end this meeting and try to fix our CI job asap. | 15:46 |
| vishalmanchanda | Thanks everyone for your contributions. | 15:46 |
| vishalmanchanda | See you next week. | 15:46 |
| tmazur | o/ | 15:46 |
| vishalmanchanda | JFYI I am on PTO from 30th June - 4th July. | 15:47 |
| vishalmanchanda | #endmeeting | 15:47 |
| opendevmeet | Meeting ended Wed Jun 28 15:47:16 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:47 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-06-28-15.00.html | 15:47 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-06-28-15.00.txt | 15:47 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-06-28-15.00.log.html | 15:47 |
| tmazur | Enjoy! | 15:47 |
| vishalmanchanda | tmazur: thanks | 15:47 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: [DNM] Test chromedriver with integartion job https://review.opendev.org/c/openstack/horizon/+/886867 | 18:18 |
| opendevreview | Tatiana Ovchinnikova proposed openstack/horizon master: [DNM] Test chromedriver with integartion job https://review.opendev.org/c/openstack/horizon/+/886867 | 21:03 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!