opendevreview | Vishal Manchanda proposed openstack/horizon master: Bump XStatic-JQuery to make it work with jquery-migrate https://review.opendev.org/c/openstack/horizon/+/887548 | 07:30 |
---|---|---|
opendevreview | Vishal Manchanda proposed openstack/horizon master: Bump XStatic-JQuery to make it work with jquery-migrate https://review.opendev.org/c/openstack/horizon/+/887548 | 08:31 |
vishalmanchanda | rdopiera: hello, around? | 10:54 |
vishalmanchanda | rdopiera: I was thinking, if we can force merge https://review.opendev.org/c/openstack/horizon/+/887548 | 11:00 |
vishalmanchanda | Once it's merge https://review.opendev.org/c/openstack/requirements/+/887607 will pass | 11:01 |
vishalmanchanda | then we will make horizon-integration job voting again | 11:01 |
vishalmanchanda | because cirros image version and quotes related changes we have to merge for sure. | 11:20 |
vishalmanchanda | let me know what you think about that? | 11:20 |
rdopiera | but https://review.opendev.org/c/openstack/requirements/+/887607 is wrong, we want jquery 3 | 12:16 |
vishalmanchanda | sorry I mean this one https://review.opendev.org/c/openstack/requirements/+/887933 will pass | 12:19 |
vishalmanchanda | If you want I can also update Xstatic-jQuery version to 3.3.1.1 in https://review.opendev.org/c/openstack/requirements/+/887933 | 12:27 |
opendevreview | Pedro Henrique Pereira Martins proposed openstack/horizon master: Centralize the export credentials in users menu https://review.opendev.org/c/openstack/horizon/+/879163 | 12:39 |
opendevreview | Vishal Manchanda proposed openstack/horizon master: Bump XStatic-JQuery to make it work with jquery-migrate https://review.opendev.org/c/openstack/horizon/+/887548 | 12:39 |
rdopiera | vishalmanchanda: yeah, I think we should upgrade to the latest version we have | 12:44 |
rdopiera | I'm thinking about upgrading the xstatic package too | 12:44 |
rdopiera | according to https://github.com/jquery/jquery-migrate#version-compatibility we need 3.x | 12:46 |
vishalmanchanda | rdopiera: ack, I will update Xstatic-jQuery version to 3.3.1.1 in https://review.opendev.org/c/openstack/requirements/+/887933 | 12:46 |
opendevreview | Vishal Manchanda proposed openstack/horizon master: Bump XStatic-JQuery to make it work with jquery-migrate https://review.opendev.org/c/openstack/horizon/+/887548 | 12:47 |
vishalmanchanda | Done the same in https://review.opendev.org/c/openstack/horizon/+/887548 | 12:48 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!