opendevreview | Radomir Dopieralski proposed openstack/horizon master: Fix test_credentials for Chrome browser in integration tests https://review.opendev.org/c/openstack/horizon/+/886260 | 09:48 |
---|---|---|
opendevreview | Radomir Dopieralski proposed openstack/horizon master: Raise exception if transfer_available_resource fails https://review.opendev.org/c/openstack/horizon/+/864405 | 09:49 |
rdopiera | selenium.common.exceptions.NoSuchElementException: Message: Not found resource with text: ['cirros-0.6.2-x86_64-disk (20.4 MB)'] | 11:42 |
rdopiera | the image name changed again? | 11:42 |
rdopiera | ah, nvm | 11:43 |
opendevreview | Radomir Dopieralski proposed openstack/horizon master: Add pytest-based selenium tests https://review.opendev.org/c/openstack/horizon/+/890086 | 11:45 |
zigo | rdopiera: https://review.opendev.org/c/openstack/horizon/+/885570 <--- It passes the CI, and the comments from vishalmanchanda have been addressed. | 12:02 |
rdopiera | zigo: what version of keystone do I need to test it? It doesn't seem to be in the current documentation | 12:55 |
zigo | rdopiera: It's been YEARS that Keystone has such a support. | 13:00 |
zigo | We tested it with even Victoria, it was fine. | 13:00 |
rdopiera | zigo: maybe they could update the docs then and add it to the available methods here: https://docs.openstack.org/keystone/latest/configuration/config-options.html#auth.methods | 13:18 |
rdopiera | anyways, that's great, means I don't have to install the latest to test it | 13:18 |
rdopiera | zigo: I won't be able to test your patch today, but I left a few nitpicks and questions, and found one typo | 15:09 |
zigo | Thanks ! :) | 15:40 |
zigo | FYI, we'll backport the patch to set it up in production once it's merged. That's our usual workflow. | 15:41 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!