| opendevreview | Ashish Gupta proposed openstack/horizon master: Pytest based selenium test : Add volumes snapshot pagination tests https://review.opendev.org/c/openstack/horizon/+/898798 | 07:36 |
|---|---|---|
| zigo | vishalmanchanda: Hi there! | 09:22 |
| zigo | Regarding your comment here: https://review.opendev.org/c/openstack/horizon/+/897310/3/openstack_dashboard/dashboards/project/instances/tests.py | 09:22 |
| zigo | I very much agree that the test fails with Django 4.2, as I have blacklisted the test in my Debian packaging and saw it, however, I have no clue how / what to fix ! Can you help ? | 09:22 |
| vishalmanchanda | zigo: ok, I see i will take a look. | 09:27 |
| vishalmanchanda | for now I am removing my -1 then. | 09:28 |
| vishalmanchanda | I thought one of test can be fixed with similar approach you are using in your patch. | 09:29 |
| zigo | vishalmanchanda: The other one you found, I did add list(repr, <FOO>)) as you suggesetd... I'm about to push it. | 09:33 |
| zigo | Do you know why that test_instance_details_metadata() fails though? | 09:33 |
| opendevreview | Thomas Goirand proposed openstack/horizon master: Use list(map(repr, <OBJ>)) to compare objects with str https://review.opendev.org/c/openstack/horizon/+/897310 | 09:34 |
| zigo | vishalmanchanda: Pushed with that one fix. Please +2 again ... :) | 09:35 |
| vishalmanchanda | zigo: sure. let's the CI job pass. | 09:38 |
| zigo | Ok. | 09:38 |
| zigo | That one has the same type of fix: https://review.opendev.org/c/openstack/neutron-vpnaas-dashboard/+/897408 | 09:39 |
| vishalmanchanda | zigo: about test_instance_details_metadata() , I need to check. | 09:39 |
| zigo | ok | 09:40 |
| vishalmanchanda | ack, will review it asap. | 09:40 |
| zigo | I just staired at the code, unable to find a correct approach ... :) | 09:40 |
| zigo | Hopefully, only the test is broken, not Horizon. | 09:40 |
| vishalmanchanda | I hope so | 09:40 |
| vishalmanchanda | I am planning to test all the panel with Django 4.2 where we have done changes in the test cases. | 09:41 |
| zigo | vishalmanchanda: It passed the CI ! :) | 10:07 |
| zigo | I do support adding Django 4.2 testing everywhere where it can be done... | 10:08 |
| opendevreview | Ashish Gupta proposed openstack/horizon master: Pytest based selenium test : Add volumes snapshot pagination tests https://review.opendev.org/c/openstack/horizon/+/898798 | 10:48 |
| opendevreview | Akihiro Motoki proposed openstack/horizon master: Add unit tests with Django 4.2 https://review.opendev.org/c/openstack/horizon/+/851261 | 13:18 |
| amotoki | vishalmanchanda: I will be PTO tomorrow. feel free to update ^ if needed. we can enable django42 job for all plugins too once it is merged. | 13:22 |
| opendevreview | Ashish Gupta proposed openstack/horizon master: Pytest based selenium test : Add volumes snapshot pagination tests https://review.opendev.org/c/openstack/horizon/+/898798 | 14:08 |
| opendevreview | Jan Jasek proposed openstack/horizon master: pytest-based selenium tests add floatingips tests + add instance params https://review.opendev.org/c/openstack/horizon/+/898835 | 15:23 |
| vishalmanchanda | tmazur: hi, could you take a look at https://review.opendev.org/c/openstack/horizon/+/897310 | 18:11 |
| vishalmanchanda | sorry this one https://review.opendev.org/c/openstack/horizon/+/851261 | 18:12 |
| vishalmanchanda | to add Django 4.2 non-voting job | 18:12 |
| tmazur | The first one, I agree with amotoki. | 18:27 |
| opendevreview | Tatiana Ovchinnikova proposed openstack/horizon master: Use placement API for the hypervisor stats https://review.opendev.org/c/openstack/horizon/+/890525 | 20:10 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!