opendevreview | Merged openstack/horizon stable/2023.1: bandit: Install baseline extra https://review.opendev.org/c/openstack/horizon/+/906889 | 07:06 |
---|---|---|
opendevreview | Merged openstack/horizon master: Make "horizon-tox-python3-django42" job voting https://review.opendev.org/c/openstack/horizon/+/905864 | 07:39 |
opendevreview | Vishal Manchanda proposed openstack/horizon master: Drop Django 3.2 support https://review.opendev.org/c/openstack/horizon/+/907194 | 11:08 |
opendevreview | Vishal Manchanda proposed openstack/horizon master: Drop Django 3.2 support https://review.opendev.org/c/openstack/horizon/+/907194 | 11:32 |
ganso | vishalmanchanda: hi! Do you know if Vadym Markov is still around so I can ask him questions about a commit? | 11:41 |
vishalmanchanda | ganso: hello | 11:41 |
vishalmanchanda | no idea | 11:41 |
ganso | vishalmanchanda: hmm ok, do you have any idea why it was decided to not list images by ID anymore, but instead list all of them? See this commit: https://github.com/openstack/horizon/commit/4a2a1db14540a726f2162475b485cd0ac1082753 | 11:43 |
ganso | it reverts what was implemented in this older commit: https://github.com/openstack/horizon/commit/deb55b8411434b32a2ea92f1a825e7dea36deea5 | 11:44 |
ganso | I am trying to write an optimization patch which introduces it back: https://review.opendev.org/c/openstack/horizon/+/906547 | 11:44 |
ganso | but I'd like to understand why it was removed, or whether that approach is discouraged | 11:47 |
ganso | vishalmanchanda: the way I understand it, listing all images is more expensive than listing only by ID | 11:47 |
vishalmanchanda | I don't see any harm if you introduce it back until it doesn't introduce a new bug in the code. | 12:24 |
tkajinam | vishalmanchanda, do you have the permission to abandon https://review.opendev.org/c/openstack/zaqar-ui/+/851394 ? wanted to clean the patches with that tag, not to leave anything for django 4 | 13:02 |
tkajinam | the duplicate patch you mentioned is already merged so I believe we no longer need it | 13:02 |
vishalmanchanda | tkajinam: done. | 14:02 |
tkajinam | vishalmanchanda, thx ! | 14:27 |
opendevreview | Pedro Henrique Pereira Martins proposed openstack/horizon master: Centralize the export credentials in users menu https://review.opendev.org/c/openstack/horizon/+/879163 | 16:55 |
opendevreview | Merged openstack/horizon stable/2023.2: bandit: Install baseline extra https://review.opendev.org/c/openstack/horizon/+/906887 | 18:59 |
opendevreview | Merged openstack/horizon stable/2023.1: Use Placement API along with the hypervisor stats https://review.opendev.org/c/openstack/horizon/+/905915 | 20:07 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!