opendevreview | Pavlo Shchelokovskyy proposed openstack/horizon master: Allow non-admins to cold migrate instances https://review.opendev.org/c/openstack/horizon/+/922022 | 13:48 |
---|---|---|
opendevreview | Pavlo Shchelokovskyy proposed openstack/horizon master: Relax *POLICY* definition requirements https://review.opendev.org/c/openstack/horizon/+/922023 | 13:49 |
lajoskatona | Hi, I have the 1st patch for changing to SDK for Networking: https://review.opendev.org/c/openstack/horizon/+/891205 , if you have some free time shall I ask the review of it? | 15:30 |
tmazur | lajoskatona, I am looking at it right now :) | 15:35 |
tmazur | lajoskatona, could you please answer a comment there? It's not quite clear why we need to test for network=private? | 15:36 |
lajoskatona | tmazur: checking | 15:45 |
lajoskatona | tmazur: I checked again and now that line in the commit message is not needed. As I remember I added that when I had issues with the logic of how pagination works + non-admin networks | 15:50 |
opendevreview | Lajos Katona proposed openstack/horizon master: SDK for Neutron networks and subnets https://review.opendev.org/c/openstack/horizon/+/891205 | 15:51 |
tmazur | lajoskatona, great, thank you for the clarification! | 15:51 |
lajoskatona | tmazur: yeah, I found my own comment from ps13 for that when I was struggling with that part | 15:51 |
lajoskatona | tmazur: thanks for the help and review | 15:51 |
tmazur | lajoskatona, it's in our priorities now. As soon as it passes the tests, I'll +2 it | 15:57 |
lajoskatona | tmazur: thanks, I try to allocate time for the coming parts to continue this work | 16:03 |
tmazur | lajoskatona, thank you! | 16:03 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!