| opendevreview | Merged openstack/horizon master: Migrate to pre-commit for linter checks https://review.opendev.org/c/openstack/horizon/+/978795 | 01:59 |
|---|---|---|
| mnasiadka | Hello - can somebody from Horizon team tell us this is the way to go (and does it need to be backported to 2026.1)? https://review.opendev.org/c/openstack/magnum-ui/+/983238 | 13:36 |
| rdopiera | mnasiadka: yes and yes | 15:20 |
| mnasiadka | thanks :) | 15:20 |
| mnasiadka | rdopiera: although it’s interesting nothing fails in magnum-ui Zuul jobs now: https://review.opendev.org/c/openstack/magnum-ui/+/983744 | 15:21 |
| rdopiera | mnasiadka: perhaps the job doesn't do collestatic/compress step? | 15:24 |
| rdopiera | then you would only see the error when actually visiting the page in a browser | 15:25 |
| rdopiera | and we only have that kind of tests for manilla-ui so far | 15:25 |
| mnasiadka | Ah, you probably mean this: https://review.opendev.org/c/openstack/manila-ui/+/956098 | 15:27 |
| mnasiadka | Another thing on my list to improve | 15:27 |
| mnasiadka | Thanks for the background, let me merge this. | 15:27 |
| rdopiera | mnasiadka: yeah, we are happy to assist with it, but we don't really know what needs to be tested, so the tests themselves would need to be written by people familiar with magnum | 15:28 |
| mnasiadka | That’s understandable | 15:29 |
| opendevreview | Tatiana Ovchinnikova proposed openstack/horizon master: Move Enmerkar extraction logic to Horizon https://review.opendev.org/c/openstack/horizon/+/983236 | 19:20 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!