| opendevreview | Dmitry Krasovskyi proposed openstack/horizon stable/2025.1: Fix compatibility with openstackSDK for PortForwardingManager https://review.opendev.org/c/openstack/horizon/+/1004576 | 09:49 |
|---|---|---|
| opendevreview | Dmitry Krasovskyi proposed openstack/horizon stable/2025.2: Fix compatibility with openstackSDK for PortForwardingManager https://review.opendev.org/c/openstack/horizon/+/1004577 | 09:50 |
| opendevreview | Dmitry Krasovskyi proposed openstack/horizon stable/2026.1: Fix compatibility with openstackSDK for PortForwardingManager https://review.opendev.org/c/openstack/horizon/+/1004578 | 09:51 |
| opendevreview | sean mooney proposed openstack/horizon master: xstatic is not a runtime dep of horizon https://review.opendev.org/c/openstack/horizon/+/1004579 | 11:29 |
| sean-k-mooney | hi folks i just want to bring https://review.opendev.org/c/openstack/horizon/+/1004579 to your attention | 11:50 |
| sean-k-mooney | horizon currently list xstatic as a depency even though it is never imported in the horizon repo | 11:50 |
| sean-k-mooney | xstatic is not buildable form sdist with setuptools >=82 because pkg_resouces was removed | 11:51 |
| sean-k-mooney | so if you use moderne setuptools with horizons requirements.txt you cant install it from sdist | 11:51 |
| sean-k-mooney | im fixing our downstream builds to work around it | 11:52 |
| sean-k-mooney | but it woudl be good if we could remove xstatic form the requireemnt.txt | 11:52 |
| sean-k-mooney | devstack is only passing today because its pulling the prebuilt wheel same for tox | 11:52 |
| sean-k-mooney | ci is sitll in flight but its looking good sofar https://zuul.openstack.org/status?change=1004579 | 11:53 |
| sean-k-mooney | if horizon has not cut rc1 yet it woudl be good to include that chagne | 11:53 |
| sean-k-mooney | rdopiera: ^ fyi | 11:54 |
| sean-k-mooney | jjasek: ^ | 11:55 |
| jjasek | sean-k-mooney, thanks for the info and the patch! Will take a look at it. | 12:28 |
| rdopiera | sean-k-mooney: why not just install pkg_resources, it's now a separate package | 12:35 |
| sean-k-mooney | well for one even if it is xstatic is not a runtime dep | 12:35 |
| sean-k-mooney | so listing it in requirements.txt is incorrect | 12:35 |
| sean-k-mooney | you could portially do that as well but that increase the security surface | 12:36 |
| sean-k-mooney | if horizon used pkg_resouces direcly it woudl be fien but if its not a direct dependcy of horizon or the openstack dash board it shoudl not be in requirements.txt | 12:37 |
| rdopiera | but it is a runtime dependency, without xstatic installed, we can't import any of the xstatic-* modules | 12:38 |
| rdopiera | because they are submodules of the xstatic module | 12:39 |
| sean-k-mooney | they are not submoutle sof that | 12:39 |
| sean-k-mooney | they are seperate namespaces pakcages | 12:40 |
| rdopiera | sorry, it's very hard for me to read what you are typing, I'm not a native English speaker | 12:41 |
| rdopiera | what is submoutle? | 12:41 |
| sean-k-mooney | sorry they are not sub moudles | 12:42 |
| sean-k-mooney | each xstatic package is an independet namespaces package | 12:42 |
| sean-k-mooney | https://zuul.opendev.org/t/openstack/buildset/0ec321e7c75f488183238c772b3f9d9e | 12:42 |
| sean-k-mooney | the last job has not completed yet but the majority fo the check jobs have already run and passed | 12:43 |
| sean-k-mooney | the xstatic python package is entirly optional none of the xstatic-* packages we use in horizon depend on it eitehr. https://zuul.opendev.org/t/openstack/build/1ac79c911dcb4ec1af81d2a2097fe38b/log/controller/logs/devstacklog.txt#12052 | 12:45 |
| rdopiera | I guess it changed somewhere along the way | 12:46 |
| sean-k-mooney | not recently, but maybe as part of the work stephen did last cycle to remove the pkg_resocues deps | 12:47 |
| rdopiera | if it works, I'm sure it's fine and if it changes again we can always bring it back | 12:47 |
| rdopiera | sean-k-mooney: no, it must have been earlier than that, where the namespace packages changed in python | 12:48 |
| rdopiera | xstatic started when they were the new hot thing | 12:48 |
| rdopiera | sean-k-mooney: are you also going to be removing it from global requirements? | 12:50 |
| sean-k-mooney | we could but i was not planning too | 12:50 |
| sean-k-mooney | if we have no deps anywayer on it we could | 12:50 |
| sean-k-mooney | i was not sure if anything else might use it? | 12:50 |
| rdopiera | I don't see what they would be using it for? | 12:50 |
| rdopiera | if it's not needed to import the xstatic-* packages | 12:51 |
| sean-k-mooney | it looks like https://opendev.org/openstack/xstatic-angular/src/branch/master/setup.py#L2 is usign xstatic directly | 12:52 |
| sean-k-mooney | but i dont knwo if xstatic-angular is still used | 12:54 |
| sean-k-mooney | it missing a pyproject.toml | 12:54 |
| sean-k-mooney | so it can be released with our current tooling since that is now requried i belive | 12:54 |
| rdopiera | it is https://github.com/openstack/horizon/blob/master/openstack_dashboard/utils/settings.py#L234 | 12:56 |
| sean-k-mooney | so i coudl be wrong but that is not importign xstatic its importhing the namespacesed moduels | 12:57 |
| rdopiera | sean-k-mooney: that `from xstatic.pkg import angular` is how every program that uses xstatic-* packages imports them | 12:57 |
| rdopiera | so if that breaks, it will also break everywhere else | 12:57 |
| sean-k-mooney | https://github.com/openstack/horizon/blob/master/openstack_dashboard/utils/settings.py#L288 | 12:58 |
| sean-k-mooney | so you are using importlib to do the import | 12:58 |
| sean-k-mooney | not xstatic | 12:58 |
| sean-k-mooney | https://github.com/openstack/horizon/blob/master/openstack_dashboard/utils/settings.py#L14 | 12:59 |
| rdopiera | yes, but it does the equivalent of that line of code | 12:59 |
| rdopiera | it does `import xstatic.pkg.angular` basically | 13:01 |
| sean-k-mooney | yes but again its an namespace package which may or may not actully need xstatic | 13:01 |
| sean-k-mooney | btu you have other problems with the xstatic packaging as well | 13:01 |
| sean-k-mooney | ye have not added pyproject.toml files to all the xstatic repos | 13:02 |
| rdopiera | then what's wrong with that line in xstatic-angular's setup.py? | 13:02 |
| sean-k-mooney | no | 13:02 |
| sean-k-mooney | so there are two things | 13:02 |
| sean-k-mooney | https://opendev.org/openstack/xstatic-angular | 13:02 |
| sean-k-mooney | does not have a pyproject.toml which si now requried by the pti for python packages | 13:03 |
| sean-k-mooney | setup.py and setup.cfg can be kept for backward compatiblty | 13:03 |
| rdopiera | I really find it hard to understand you, sorry, I need a break | 13:03 |
| sean-k-mooney | but the release tooling requries a pyproject.toml now | 13:03 |
| sean-k-mooney | https://opendev.org/openstack/xstatic-angular/src/branch/master/setup.py#L2 is importing from the current package | 13:04 |
| sean-k-mooney | so while that looks like its importing an xstatic subpackage i dont think it actully is | 13:04 |
| sean-k-mooney | there are no requiremets expressed in https://opendev.org/openstack/xstatic-angular/src/branch/master/setup.py#L23 | 13:05 |
| sean-k-mooney | so the current setup.py is basiclly declaring that it has no dependencies | 13:05 |
| rdopiera | maybe you could come tomorrow to the team meeting, there will be native English speakers present then who can handle it better | 13:05 |
| rdopiera | it has no dependencies, it only holds data files | 13:07 |
| rdopiera | that's the entire idea of xstatic-* packages | 13:07 |
| sean-k-mooney | yep | 13:07 |
| sean-k-mooney | and if you look at the package layout https://opendev.org/openstack/xstatic-angular/src/branch/master/xstatic/pkg/angular | 13:08 |
| sean-k-mooney | you can see its declaring itself as xstatic.pkg.angular so it will be placed in xstatic/pkg/angular under sitepackages | 13:08 |
| sean-k-mooney | anyway ci passes, https://review.opendev.org/c/openstack/horizon/+/1004579 i can see if i can attend the meetign tomorrow, from an outsdie perspective it does not look like xstatic is a runtime requirement but i may have missed something | 13:11 |
| rdopiera | I mean it looks like it works, as I said, in the worst case we will put it back. I meant the other problems for the meeting. | 13:12 |
| rdopiera | if they require pyproject.toml now, I expect they are going to have a lot of problems with a lot of packages | 13:12 |
| sean-k-mooney | we haveen been adding pyproject.toml to all python repos for the last 2 release | 13:13 |
| sean-k-mooney | and updated the pti to reflect that earlier in the year | 13:13 |
| sean-k-mooney | https://github.com/openstack/governance/commit/42f6cf0fb2923d7c4fadea1547d80b7287d537d5 | 13:13 |
| sean-k-mooney | this cycle we are not requiring all metadata to move to pyproject.toml but the minium stub is expected to be in place | 13:14 |
| sean-k-mooney | without a pyproject.toml pip will not use pbr, perhaps xstatic is not using pbr today and it may work without it but it would not be complient with the pti | 13:16 |
| rdopiera | I guess we need to add a topic to the PTG to plan this as a release priority next cycle | 13:17 |
| rdopiera | as I said, it's just data files and a python file with metadata, there is really nothing we would need pbr for | 13:18 |
| sean-k-mooney | all it gives you is automatic generation of package metadata such as the git sha it was buitl from | 13:19 |
| rdopiera | yeah, not needed here | 13:19 |
| sean-k-mooney | but its more a case of that is the specifed packaging tool for all python deliverables | 13:19 |
| rdopiera | parhaps we should move those xstatic-* packages out of the openstack repos then | 13:20 |
| rdopiera | I think opendev had some place for projects that are not officially part of openstack? | 13:21 |
| sean-k-mooney | maybe or just add the file its pretty trivial. but that kind of up to ye | 13:21 |
| sean-k-mooney | you can create seperate namespaces via a patch to project-cofnig | 13:21 |
| rdopiera | if we add pbr in there, all other projects that use those modules (moinmoin wiki) will suddenly depend on pbr | 13:21 |
| sean-k-mooney | but you cannot use the release repo for reelase if you do that | 13:21 |
| rdopiera | anyways, I think it's something for the ptg | 13:22 |
| rdopiera | thank you for letting us know | 13:22 |
| sean-k-mooney | you could proably create horizon-extra/xtatic ... | 13:22 |
| sean-k-mooney | but you could also just propose an update to the pti | 13:22 |
| sean-k-mooney | and specificly call out xstatic as not requireing pbr | 13:23 |
| sean-k-mooney | its an evolving document so you can just propsos an update as the xstatic packages are really javascript/html/css asset packages that hapen to use python packaging rahter then python packges in the normal sense | 13:24 |
| opendevreview | Merged openstack/horizon master: tox: Drop redundant passenv https://review.opendev.org/c/openstack/horizon/+/1004221 | 15:17 |
| opendevreview | Merged openstack/horizon master: Stop using deprecated SDK attribute names in tests https://review.opendev.org/c/openstack/horizon/+/1004343 | 15:17 |
| zigo | Hi team! The current requirements.txt of Horizon 26.0.0 claims Horizon is compatible with openstacksdk 4.5.0. Reality check of unit tests: it didn't even pass unit tests with sdk 4.10, I had to increase the version in debian/control so it would take 4.19 from Debian Experimental. | 19:20 |
| zigo | I would strongly suggest fixing this during the RC period. | 19:21 |
| opendevreview | Tatiana Ovchinnikova proposed openstack/horizon master: SDK for Nova hypervisors https://review.opendev.org/c/openstack/horizon/+/1003616 | 20:37 |
| tmazur | Thank you zigo, we will update the requirements | 21:15 |
| opendevreview | Kevin Allioli proposed openstack/horizon master: Fix flaky test_image_filtration_admin test https://review.opendev.org/c/openstack/horizon/+/993023 | 22:09 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!