| seongsoocho[m] | ianychoi: I’d like to get your opinion on this comment. Clark Boylan suggested that we might also push and track the .pot files together with the translations. https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/921878/comment/d7b5d515_af6a40cd/ | 08:57 |
|---|---|---|
| ianychoi | No, he asked why pot files are also pushed | 08:58 |
| seongsoocho[m] | ohhh.. I misunderstood the comment. | 08:59 |
| ianychoi | Have you tested the script files? | 09:01 |
| seongsoocho[m] | As far as I remember, I tested this with antraxmin before, but after reviewing it again, I found that some items were missing ( for example, common_translation_update.sh). I am working on fix it now | 09:06 |
| ianychoi | I don’t want you to fix it such a way - does the common*.sh file really needed? | 09:08 |
| seongsoocho[m] | It uses the file from prepare-zanata-client/files. and Do you want antraxmin to make this change? | 09:10 |
| ianychoi | He didn’t do so i wanted to do follow-up stuff. | 09:12 |
| seongsoocho[m] | Ah, I got it | 09:13 |
| ianychoi | I couldn’t find which parts of the proposed files call the functions in common*.sh | 09:14 |
| seongsoocho[m] | https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/921878/21/roles/prepare-weblate-client/files/upstream_translation_update_weblate.sh | 09:14 |
| seongsoocho[m] | Here. Line 24 | 09:14 |
| ianychoi | Even you didn’t comment more than 6 weeks | 09:15 |
| seongsoocho[m] | propose_translation_update_weblate also use same file | 09:15 |
| ianychoi | My question is so which parts of the file use the functions in common*.sh | 09:15 |
| ianychoi | Deleting l24 would work? | 09:16 |
| seongsoocho[m] | What kind of comment do you mean? Are you referring to leaving my final opinion on this patch as a comment? | 09:16 |
| seongsoocho[m] | Functions such as setup_venv and setup_git are defined in common, and they are referenced and used by upstream* and propose*. | 09:17 |
| ianychoi | Do you want to proceed the patch or want others help this patch? | 09:17 |
| seongsoocho[m] | I made the initial proposal for this patch and later mentored antraxmin to work on it. However since there are no futher follow up from antraxmin, I was planning to make the additional changes myself and upload them. | 09:20 |
| ianychoi | Okay but just adding common* is not a complete solution i think. Let me ask differently. How do you want to move forward on this patch? | 09:21 |
| ianychoi | But.. you also did not do anything for more than six weeks. Do you want to lead the patch from now? | 09:23 |
| seongsoocho[m] | Yes. I will take the lead from now on. I'd like to see it through to the end. | 09:25 |
| ianychoi | The please upload the script files into openstack/i18n. | 09:25 |
| ianychoi | with paste logs for complete execution | 09:26 |
| ianychoi | I first want to see how the script files work well and move forward with the your shared patch not to overload infra team | 09:27 |
| ianychoi | This “complete execution” has not validated and even did not shared.. | 09:27 |
| ianychoi | Do you agree with this? | 09:27 |
| seongsoocho[m] | Yes I agree with you. | 09:28 |
| seongsoocho[m] | I’ll be away from the keyboard for a little while. thanks for your comment | 09:29 |
| ianychoi | Thanks for sharing your status | 09:32 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!