openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: Replace entry_points console_scripts https://review.openstack.org/38000 | 00:05 |
---|---|---|
openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: Replace entry_points console_scripts https://review.openstack.org/38000 | 00:32 |
openstackgerrit | Paul Belanger proposed a change to openstack-infra/zuul: Make E123 pep clean https://review.openstack.org/38054 | 00:33 |
openstackgerrit | Paul Belanger proposed a change to openstack-infra/zuul: Make E125 pep8 clean https://review.openstack.org/38055 | 00:41 |
openstackgerrit | Paul Belanger proposed a change to openstack-infra/zuul: Make E123 pep8 clean https://review.openstack.org/38054 | 00:41 |
mordred | heh | 00:42 |
mordred | pabelanger: jeblair is not going to accept those ^^ ... we should probably put a comment into the tox.ini file... | 00:43 |
*** sdake has joined #openstack-infra | 00:43 | |
*** sdake has joined #openstack-infra | 00:43 | |
pabelanger | mordred, Oh, why is that? | 00:43 |
mordred | pabelanger: E125 is not actually in pep8 | 00:43 |
pabelanger | Ah | 00:44 |
pabelanger | mordred, abandoned E125 :) | 00:45 |
mordred | :) | 00:45 |
*** ladquin has quit IRC | 01:17 | |
*** changbl has joined #openstack-infra | 01:23 | |
*** koolhead17 has quit IRC | 01:25 | |
*** mriedem has joined #openstack-infra | 01:25 | |
*** CaptTofu has quit IRC | 01:33 | |
*** CaptTofu has joined #openstack-infra | 01:33 | |
*** CaptTofu has quit IRC | 01:38 | |
*** mriedem has quit IRC | 01:40 | |
openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: Replace entry_points console_scripts https://review.openstack.org/38000 | 01:45 |
*** sdake has quit IRC | 01:45 | |
*** odyi has quit IRC | 01:47 | |
*** odyi has joined #openstack-infra | 01:47 | |
*** dkliban has quit IRC | 01:48 | |
*** Shrews_ is now known as Shrews | 02:19 | |
openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: Replace entry_points console_scripts https://review.openstack.org/38000 | 02:31 |
*** sdake_ has quit IRC | 03:20 | |
*** Ryan_Lane has quit IRC | 03:38 | |
*** SergeyLukjanov has joined #openstack-infra | 03:53 | |
*** dkliban has joined #openstack-infra | 04:05 | |
*** pcrews has joined #openstack-infra | 04:14 | |
*** pcrews has quit IRC | 04:22 | |
*** dkliban has quit IRC | 04:23 | |
*** changbl has quit IRC | 04:27 | |
*** linuxmohan has joined #openstack-infra | 04:45 | |
openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: Replace entry_points console_scripts https://review.openstack.org/38000 | 05:02 |
* mordred sucks | 05:02 | |
*** koudaddy1981 has joined #openstack-infra | 05:03 | |
*** SergeyLukjanov has quit IRC | 05:10 | |
*** koudaddy1981 has quit IRC | 05:10 | |
*** vogxn has joined #openstack-infra | 05:36 | |
*** michchap has joined #openstack-infra | 05:40 | |
*** blamar has quit IRC | 06:05 | |
*** marktraceur has quit IRC | 06:12 | |
*** dguitarbite has joined #openstack-infra | 06:13 | |
*** jjmb1 has joined #openstack-infra | 06:22 | |
*** jjmb has quit IRC | 06:24 | |
*** cody-somerville has quit IRC | 06:29 | |
*** cody-somerville has joined #openstack-infra | 06:45 | |
*** Ryan_Lane has joined #openstack-infra | 07:06 | |
*** vipul is now known as vipul-away | 07:13 | |
*** vogxn has quit IRC | 07:14 | |
*** vipul-away is now known as vipul | 07:17 | |
*** koolhead17 has joined #openstack-infra | 07:23 | |
*** linuxmohan has quit IRC | 07:27 | |
*** linuxmohan has joined #openstack-infra | 07:54 | |
*** linuxmohan has quit IRC | 07:57 | |
*** vipul is now known as vipul-away | 08:16 | |
*** Ryan_Lane has quit IRC | 08:18 | |
*** Ryan_Lane has joined #openstack-infra | 08:23 | |
*** linuxmohan has joined #openstack-infra | 08:57 | |
*** Ng_ is now known as Ng | 08:58 | |
*** linuxmohan has quit IRC | 09:02 | |
*** linuxmohan has joined #openstack-infra | 09:08 | |
*** linuxmohan has quit IRC | 09:12 | |
*** dguitarbite has left #openstack-infra | 09:13 | |
*** Ryan_Lane has quit IRC | 09:13 | |
*** SergeyLukjanov has joined #openstack-infra | 10:04 | |
*** odyssey4me has joined #openstack-infra | 10:11 | |
*** linuxmohan has joined #openstack-infra | 10:15 | |
*** odyssey4me has quit IRC | 10:28 | |
*** koolhead17 has quit IRC | 10:32 | |
*** mikal has quit IRC | 10:46 | |
*** mikal has joined #openstack-infra | 10:48 | |
*** SergeyLukjanov has quit IRC | 11:07 | |
*** SergeyLukjanov has joined #openstack-infra | 11:09 | |
*** dkliban has joined #openstack-infra | 12:11 | |
*** koolhead17 has joined #openstack-infra | 12:18 | |
*** michchap has quit IRC | 12:26 | |
*** koolhead17 has quit IRC | 12:38 | |
*** michchap has joined #openstack-infra | 12:56 | |
dhellmann_ | mordred: I don't see where jenkins is running the integration tests for pbr. :-/ | 13:00 |
*** dhellmann_ is now known as dhellmann | 13:01 | |
*** michchap has quit IRC | 13:05 | |
*** CaptTofu has joined #openstack-infra | 13:20 | |
*** prad has joined #openstack-infra | 13:21 | |
*** linuxmohan has quit IRC | 13:26 | |
*** linuxmohan has joined #openstack-infra | 13:31 | |
*** mikal has quit IRC | 13:38 | |
*** mikal has joined #openstack-infra | 13:40 | |
*** linuxmohan has quit IRC | 13:45 | |
*** CaptTofu has quit IRC | 13:55 | |
*** CaptTofu has joined #openstack-infra | 13:55 | |
*** CaptTofu has quit IRC | 13:55 | |
*** CaptTofu has joined #openstack-infra | 13:56 | |
openstackgerrit | Jeremy Stanley proposed a change to openstack-infra/config: Jeepyb depends on PBR. https://review.openstack.org/38066 | 13:59 |
*** woodspa has joined #openstack-infra | 14:08 | |
*** prad_ has joined #openstack-infra | 14:19 | |
fungi | mordred: newer pbr turns out not to have helped get jeepyb to upgrade on review-dev, unless you meant we need newer than the most recent pbr on pypi... http://paste.openstack.org/show/41124/ | 14:20 |
*** prad has quit IRC | 14:22 | |
*** prad_ has quit IRC | 14:25 | |
*** prad has joined #openstack-infra | 14:26 | |
*** prad has quit IRC | 14:36 | |
*** changbl has joined #openstack-infra | 14:46 | |
*** linuxmohan has joined #openstack-infra | 14:55 | |
*** CaptTofu has quit IRC | 14:58 | |
*** CaptTofu has joined #openstack-infra | 14:58 | |
openstackgerrit | Doug Hellmann proposed a change to openstack-dev/pbr: Do not assume the tests run as jenkins https://review.openstack.org/38071 | 14:59 |
openstackgerrit | Doug Hellmann proposed a change to openstack-dev/pbr: Use shunit2 for integration tests https://review.openstack.org/38072 | 14:59 |
*** dhellmann is now known as dhellmann_ | 14:59 | |
*** linuxmohan has quit IRC | 15:01 | |
*** CaptTofu has quit IRC | 15:03 | |
*** pcrews has joined #openstack-infra | 15:14 | |
mordred | dhellmann_: http://logs.openstack.org/00/38000/9/check/gate-pbr-devstack-vm-rawinstall/241 | 15:28 |
mordred | dhellmann_: neat! | 15:28 |
*** erfanian has quit IRC | 15:35 | |
openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: Replace entry_points console_scripts https://review.openstack.org/38000 | 15:38 |
mordred | fungi: gah. we need a new version of pbr cut. that's a bug that I fixed 3 weeks ago | 15:41 |
*** cody-somerville has quit IRC | 15:42 | |
fungi | mordred: okay, that makes sense. the sooner the better i guess, since it's preventing jeepyb updates at least on the gerrit servers. are there outstanding pbr changes you're trying to get merged before you release? if so i'll reprioritize my review queue | 15:50 |
*** koolhead17 has joined #openstack-infra | 15:52 | |
*** vogxn has joined #openstack-infra | 15:54 | |
*** vogxn has joined #openstack-infra | 15:55 | |
*** dhellmann_ is now known as dhellmann | 15:58 | |
mordred | fungi: diskimage-builder needs this: https://review.openstack.org/#/c/35730/ | 15:59 |
mordred | if we can get integration_tests to pass on https://review.openstack.org/#/c/38000/ I'd like to get it in for nova | 15:59 |
mordred | and https://review.openstack.org/#/c/30522/ would make everyone happier, but I still need to write a test for it | 16:00 |
dhellmann | mordred: I thought the "Distribution contains no modules or packages for namespace package" error in pbr was fixed? | 16:00 |
*** SergeyLukjanov has quit IRC | 16:01 | |
mordred | dhellmann: it is. in trunk | 16:01 |
dhellmann | aw | 16:01 |
* dhellmann broke virtualenvwrapper | 16:01 | |
mordred | well, possibly different breakages | 16:01 |
mordred | there used to be one where it would bomb on blank lines | 16:01 |
dhellmann | the files are in the package, but it won't install | 16:01 |
*** vogxn has quit IRC | 16:01 | |
*** dkliban has quit IRC | 16:01 | |
mordred | how about we release current trunk of pbr | 16:02 |
mordred | and then make another when these next set land | 16:02 |
mordred | it's not like releasing is a bad thing | 16:02 |
dhellmann | yes, please | 16:02 |
dhellmann | how can I help? | 16:02 |
dhellmann | hmm, even the work-around of listing namespace_packages in setup.py didn't fix it | 16:03 |
mordred | it's because the depends are already installed | 16:03 |
mordred | ok. 0.5.19 pushed to gerrit | 16:03 |
mordred | should hit pypi soon | 16:03 |
dhellmann | ok | 16:04 |
*** sarob has joined #openstack-infra | 16:05 | |
fungi | mordred: awesome. i'll re-try my change on review-dev once that's up | 16:06 |
mordred | ++ | 16:06 |
fungi | you are quick like ninja | 16:06 |
fungi | looks like it's already hit pypi.p.o | 16:07 |
mordred | fungi, dhellmann: https://review.openstack.org/#/c/38049/ could use a double +2 and an APRV | 16:07 |
* fungi will take a look. gerrit is a little sluggish on airline wifi | 16:08 | |
dhellmann | mordred: +2, but I hope that's not a long-term solution to ensuring the test environment is set up properly | 16:08 |
mordred | dhellmann: nope. | 16:08 |
mordred | dhellmann: definitely not | 16:08 |
* dhellmann should have read the test script before running it and losing his .pip/pip.cfg | 16:08 | |
* mordred bows head | 16:09 | |
fungi | mordred: lgtm. aproved | 16:09 |
fungi | approved too | 16:09 |
mordred | thank you | 16:12 |
dhellmann | mordred: pbr 0.5.19 didn't fix my issue :-( | 16:12 |
mordred | dhellmann: no? can you point me at something to look at? | 16:12 |
mordred | fungi, dhellmann while I'm looking at that - should we mirror our repos to bitbucket too? | 16:13 |
*** sarob has quit IRC | 16:13 | |
dhellmann | mordred: git clone git@bitbucket.org:dhellmann/virtualenvwrapper.git | 16:13 |
mordred | there isn't really anything special about github other than convenience for some people - but a lot of python folks are bitbucket folks | 16:14 |
dhellmann | then build an sdist and try to install it in a virtualenv | 16:14 |
mordred | dhellmann: ok. on it | 16:14 |
fungi | mordred: 0.5.19 allowed jeepyb to upgrade on review-dev, so that's solved at least. thanks! | 16:14 |
*** sarob has joined #openstack-infra | 16:14 | |
dhellmann | mordred: bitbucket wouldn't hurt, but I think most of the bitbucket folks are hg folks, too | 16:14 |
mordred | well, _that_ I'm not going to do | 16:15 |
dhellmann | mordred: so I'm not sure it buys us much | 16:15 |
dhellmann | right, no, I wasn't suggesting it :-) | 16:15 |
* mordred was more thinking to drive home the fact that github is 'just a mirror' | 16:15 | |
dhellmann | ah | 16:15 |
fungi | mordred: i see little difference between github and bitbucket philosophically, so if we're going to continue mirroring to one i have nothing against mirroring to both | 16:15 |
dhellmann | when you put it that way, fungi, I agree | 16:16 |
mordred | dhellmann: so, now that 0.5.19 is out ... | 16:17 |
fungi | though to me, mirroring to either is about like mirroring to facebook | 16:17 |
dhellmann | aw, that's extreme | 16:17 |
dhellmann | you can get stuff from both github and bitbucket without an account | 16:17 |
fungi | you can apparently get stuff from facebook without an account too | 16:18 |
*** sarob has quit IRC | 16:18 | |
fungi | because i've got no facebook account and can see some people's published content | 16:18 |
dhellmann | and bitbucket at least supports exporting all of the data associated with a repository, including the bug reports | 16:18 |
dhellmann | I'm not supporting facebook, I'm just sayin', these sites have their uses, esp. for smaller projects | 16:19 |
* fungi imagines commit messages splatted to the openstack facebook wall | 16:19 | |
* dhellmann wonders if facebook would throttle the api client doing that | 16:19 | |
fungi | dhellmann: granted, i'm not saying the services aren't useful | 16:20 |
fungi | but the ways openstack uses github is basically social networking + cdn | 16:20 |
dhellmann | fungi: does the infra gerrit puppet setup depend on launchpad for identity, or could someone create an account just on our gerrit server? | 16:21 |
dhellmann | fungi: sure | 16:21 |
fungi | dhellmann: yes and no | 16:21 |
fungi | dhellmann: interactive user accounts depend on openid, but service accounts (e.g. for third-party test result submission) do not | 16:21 |
dhellmann | fungi: here's the background: I'm thinking about making a canned image for DreamCompute consisting of a "mostly" configured infra setup, to make it easy for projects to set up their own instances | 16:22 |
*** SergeyLukjanov has joined #openstack-infra | 16:22 | |
dhellmann | it seems like I need an openid server, then | 16:22 |
mordred | dhellmann: https://bitbucket.org/dhellmann/virtualenvwrapper/pull-request/1/take-advantage-of-pbr-0519 | 16:22 |
* dhellmann raises an eyebrow at keystone | 16:22 | |
dhellmann | mordred: oh, man | 16:22 |
fungi | dhellmann: so... gerrit itself can use internal accounts for users, or multiple openid providers, or ldap, or... | 16:22 |
fungi | our gerrit is just locked down in that regard | 16:23 |
dhellmann | fungi: cool, I'll learn more about that if we decide to go ahead with the idea | 16:23 |
mordred | dhellmann: I have a copy running inside of HP that uses ldap | 16:23 |
fungi | but if you were to spin up your own openstack-infra-like gerrit and related bits, you could pretty easily diverge a little on account management if you wanted | 16:23 |
dhellmann | yeah, that's more or less what I expected | 16:24 |
mordred | in fact, I believe I submitted a patch to support ldap in our puppet modules | 16:24 |
fungi | it's just configuration changes | 16:24 |
dhellmann | I wasn't sure if the dependency was "openid" or "launchpad's openid" | 16:24 |
mordred | dhellmann: so, that PR works for _me_ - but it's possible it doesn't fix your problem | 16:24 |
dhellmann | mordred: I'll give it a try | 16:24 |
mordred | hrm. ok. looks like I did not | 16:25 |
* mordred has a patch he needs to submit that will add configurable ldap support | 16:25 | |
dhellmann | mordred: wfm, thanks | 16:25 |
mordred | w00t | 16:25 |
* dhellmann wonders why tox did not report an installation failure for this issue | 16:25 | |
mordred | because of evil maybe? to be fair - your previous incantation also should have worked | 16:28 |
mordred | and I do not understand why it did not | 16:28 |
dhellmann | hrm | 16:29 |
*** prad has joined #openstack-infra | 16:29 | |
*** pcrews has quit IRC | 16:32 | |
dhellmann | ugh: Could not find suitable distribution for Requirement.parse('pytest-runner') | 16:35 |
mordred | that's because of evilfail | 16:36 |
dhellmann | pytest-runner is in the *setup_requires* list for python-keyring? | 16:36 |
*** prad has quit IRC | 16:36 | |
mordred | yes | 16:36 |
mordred | so we have it in test-requirements.txt in openstack/requrements so that our mirror will pick it up | 16:36 |
dhellmann | http://logs.openstack.org/71/38071/1/check/gate-pbr-devstack-vm-rawinstall/242/console.html | 16:37 |
mordred | yes. this is the error I currently find baffling | 16:37 |
mordred | because it _is_ in the mirror | 16:38 |
mordred | and we _do_ configure .pydistutils.cfg and .pip/pip.conf | 16:38 |
* mordred blames dstufft | 16:38 | |
dhellmann | mordred: https://bitbucket.org/kang/python-keyring-lib/pull-request/34/remove-pytest-runner-from-setup_requires/diff | 16:45 |
dhellmann | and https://bitbucket.org/kang/python-keyring-lib/issue/106/should-not-require-pytest-runner-to | 16:46 |
*** dhellmann is now known as dhellmann_ | 16:52 | |
mordred | dhellmann_: I have approved it | 16:53 |
openstackgerrit | A change was merged to openstack-dev/pbr: Add libffi-dev https://review.openstack.org/38049 | 16:54 |
*** dkliban has joined #openstack-infra | 16:55 | |
*** dkliban has quit IRC | 17:10 | |
*** dhellmann_ is now known as dhellmann | 17:16 | |
dhellmann | mordred: you have commit access to keyring? | 17:16 |
dhellmann | mordred: ah, apparently "approve" doesn't mean the same thing on bitbucket as gerrit | 17:18 |
mordred | dhellmann: :) | 17:20 |
mordred | dhellmann: so - I've got a couple of fun patches coming... | 17:20 |
mordred | dhellmann: and in making them, realized that I _do_ have a better way to unittest the entry_points change | 17:21 |
dhellmann | cool | 17:21 |
mordred | dhellmann: that said - it would be stellar if the integration test script wasn't bombing out on that keyring thing - it makes no sense to me | 17:21 |
openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: Set defaults directly in option processing https://review.openstack.org/38078 | 17:22 |
openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: Move d2to1 more into the source tree https://review.openstack.org/38079 | 17:22 |
openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: Remove the need to specify the pbr hook https://review.openstack.org/38080 | 17:22 |
*** sarob has joined #openstack-infra | 17:22 | |
mordred | oh - wait | 17:22 |
mordred | we're bulding a local mirror | 17:23 |
mordred | dhellmann: the reason those are failing isn't actually a pytest-runner issue | 17:23 |
mordred | it's that the local mirror we build in the integration test is failing half-way through | 17:23 |
mordred | trying to build libffi | 17:23 |
dhellmann | ah | 17:23 |
mordred | but the "add libffi-dev" patch should be landed now, so re-checking all of those should work | 17:24 |
dhellmann | mordred: in https://review.openstack.org/#/c/38080/ what causes "pbr code paths" to be run? | 17:24 |
mordred | dhellmann: anyway - on the other thing - d2to1 has a testpackage and tests that operating on it does stuff | 17:24 |
mordred | dhellmann: using pbr | 17:24 |
mordred | dhellmann: pbr.hooks.setup_hook(config) in https://review.openstack.org/#/c/38080/1/pbr/util.py | 17:25 |
dhellmann | so just listing pbr in setup_requires? | 17:25 |
mordred | dhellmann: saying "pbr=True" in the setup call | 17:25 |
dhellmann | ah, ok | 17:26 |
dhellmann | the commit message led me to think neither was needed | 17:26 |
mordred | oop | 17:26 |
mordred | oops | 17:26 |
dhellmann | you're just saying I don't need to do both | 17:26 |
mordred | yup | 17:27 |
mordred | or won't, once the patch lands | 17:27 |
dhellmann | right | 17:27 |
clarkb | mordred where did we add libffi-dev? it was already on the static slaves | 17:28 |
mordred | clarkb: pbr integration.sh runs on devstack slaves | 17:29 |
mordred | clarkb: so I needed to add it to the things integration.sh installed | 17:29 |
mordred | clarkb: we should make a better systemic answer for this | 17:29 |
mordred | but for now, this should do | 17:31 |
*** dhellmann is now known as dhellmann_ | 17:32 | |
sarob | im getting a failure on validate.py | 17:38 |
sarob | its looking for an url that likely doesnt exist | 17:39 |
sarob | http://logs.openstack.org/13/37613/4/gate/gate-openstack-manuals-validate/1608/console.html.gz | 17:39 |
sarob | ideas on how to fix? | 17:40 |
*** CaptTofu has joined #openstack-infra | 17:41 | |
*** sarob has quit IRC | 17:51 | |
*** sarob has joined #openstack-infra | 17:52 | |
*** sarob has quit IRC | 17:56 | |
*** guitarza1 is now known as guitarzan | 17:58 | |
*** jpeeler1 has quit IRC | 18:21 | |
*** CaptTofu has quit IRC | 18:21 | |
*** CaptTofu has joined #openstack-infra | 18:22 | |
*** sarob has joined #openstack-infra | 18:22 | |
*** CaptTofu has quit IRC | 18:26 | |
*** jpeeler1 has joined #openstack-infra | 18:27 | |
*** sarob has quit IRC | 18:31 | |
fungi | sarob: i'm getting the same exception on the tip of master, so something seems to have broken it. looking to see if i can tell whether it's run successfully recently/ever | 18:31 |
fungi | seems to have run successfully for https://review.openstack.org/38016 so i'll see if i can tell what changed since then | 18:34 |
fungi | nope, not enough details in the logs. guess it needs debugging | 18:37 |
*** jpeeler1 has quit IRC | 18:38 | |
*** changbl has quit IRC | 18:38 | |
*** ttx has quit IRC | 18:38 | |
*** hughsaunders has quit IRC | 18:38 | |
*** annegentle_ has quit IRC | 18:38 | |
*** juice has quit IRC | 18:38 | |
*** cp16net|away has quit IRC | 18:38 | |
*** sileht has quit IRC | 18:38 | |
*** briancline has quit IRC | 18:38 | |
*** EntropyWorks has quit IRC | 18:38 | |
*** jcooley has quit IRC | 18:38 | |
openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: Replace entry_points console_scripts https://review.openstack.org/38000 | 18:41 |
openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: Remove the need to specify the pbr hook https://review.openstack.org/38080 | 18:41 |
mordred | dhellmann_: okie. ^^ | 18:41 |
mordred | dhellmann_: there's docs updated on the one - and UNIT TESTS on the other | 18:41 |
*** jpeeler has joined #openstack-infra | 18:42 | |
*** dkliban has joined #openstack-infra | 18:43 | |
*** ttx has joined #openstack-infra | 18:47 | |
*** briancline has joined #openstack-infra | 18:47 | |
*** cp16net has joined #openstack-infra | 18:47 | |
*** ttx has quit IRC | 18:47 | |
*** ttx has joined #openstack-infra | 18:47 | |
*** hughsaunders has joined #openstack-infra | 18:48 | |
*** EntropyWorks has joined #openstack-infra | 18:48 | |
*** annegentle has joined #openstack-infra | 18:48 | |
*** changbl has joined #openstack-infra | 18:49 | |
*** jcooley has joined #openstack-infra | 18:49 | |
*** dhellmann_ is now known as dhellmann | 18:52 | |
dhellmann | mordred: I'm looking at https://review.openstack.org/#/c/38000/11/pbr/packaging.py | 18:52 |
dhellmann | the bit with the global feels odd | 18:52 |
*** juice has joined #openstack-infra | 18:53 | |
dhellmann | mordred: I left a comment with a suggestion for cleaning it up a little; otherwise looks fine to me | 18:56 |
*** dhellmann is now known as dhellmann_ | 18:56 | |
*** sarob has joined #openstack-infra | 18:57 | |
*** pcrews has joined #openstack-infra | 19:00 | |
*** sarob has quit IRC | 19:01 | |
fungi | sarob: http://paste.openstack.org/show/41141/ | 19:02 |
*** linuxmohan has joined #openstack-infra | 19:03 | |
fungi | gah, not here now | 19:03 |
*** pcrews has quit IRC | 19:05 | |
*** linuxmohan has quit IRC | 19:09 | |
*** klrmn1 has joined #openstack-infra | 19:11 | |
*** klrmn1 has left #openstack-infra | 19:13 | |
*** dkliban_ has joined #openstack-infra | 19:13 | |
fungi | anyway, if anyone else from docs pops in here complaining about gate-openstack-manuals-validate suddenly failing, the answer is https://review.openstack.org/38082 | 19:18 |
fungi | i'll let them know in #openstack-docs too | 19:18 |
*** locke1051 has joined #openstack-infra | 19:18 | |
fungi | or not. that channel is a ghost town | 19:18 |
*** rwsu_ has joined #openstack-infra | 19:19 | |
*** dkliban has quit IRC | 19:20 | |
*** locke105 has quit IRC | 19:20 | |
*** klrmn has quit IRC | 19:20 | |
*** rwsu-away has quit IRC | 19:20 | |
fungi | docs ml notified instead | 19:24 |
* dhellmann_ has a sad that pbr seems to be broken on python 3 | 19:25 | |
*** hashar has joined #openstack-infra | 19:25 | |
*** klrmn has joined #openstack-infra | 19:27 | |
openstackgerrit | Doug Hellmann proposed a change to openstack-dev/pbr: Fix integer_types type under python 3 https://review.openstack.org/38083 | 19:28 |
fungi | dhellmann_: don't tell me that! i just confirmed that py33 unit tests for oslo.config won't work because test-requirements-py3.txt wants bzr+lp:testrepository | 19:30 |
dhellmann_ | fungi: yeah | 19:30 |
*** dhellmann_ is now known as dhellmann | 19:30 | |
fungi | so i was about to punch the button on testing my python3.3 slave with pbr's tests instead | 19:31 |
dhellmann | no, pbr's tests fail under 3.3 too | 19:32 |
dhellmann | pbr sort of works, minus the fix I just submitted | 19:32 |
dhellmann | but the tests fail because of the testr thing | 19:32 |
* dhellmann assumed testr was python 3 compatible, and can't believe it's not | 19:32 | |
fungi | do we have *any* project with a working tox -epy33 on its master branch yet? | 19:32 |
fungi | dhellmann: if that line in the test-requirements-py3.txt is because of the "print statement not print() function" issue, lifeless released a fixed version | 19:32 |
dhellmann | fungi: I'll test with the pypi version | 19:32 |
fungi | so we should be able to just pip install it normally | 19:32 |
dhellmann | fungi: I know zul is working hard on that. I don't know how close he is. Possibly oslo.config? | 19:33 |
fungi | that happened last week | 19:33 |
dhellmann | cool! I'm behind, but I know he's submitted patches to lots of projects for python 3 compatibility | 19:33 |
fungi | dhellmann: well, as i said, oslo.config currently wants a bzr client on the slave so it can pull in trunk testrepository, so it is still a minor failure from a production gating perspective | 19:34 |
Alex_Gaynor | I don't know if it works, but swift has py33 in its tox.ini on master | 19:34 |
dhellmann | Alex_Gaynor: we have the stanza in several projects, but most of them don't work | 19:34 |
Alex_Gaynor | ah | 19:34 |
dhellmann | the plan is to get some subset of tests working and add those to the tox.ini explicitly so they *stay* working | 19:34 |
dhellmann | Alex_Gaynor: https://etherpad.openstack.org/havana-python3 | 19:35 |
dhellmann | fungi: changing the requirements file fixed the python 3.3 change | 19:35 |
dhellmann | fungi, mordred : can we turn on python 3.3 gating for pbr, pretty please? | 19:35 |
fungi | dhellmann: if you patch it not to want stuff from bzr, sure! | 19:36 |
openstackgerrit | Doug Hellmann proposed a change to openstack-dev/pbr: Fix python 3.3 test requirements https://review.openstack.org/38084 | 19:36 |
Alex_Gaynor | dhellmann: I guess I've performed a useful functiont hen, next xattr release will have py3k support | 19:36 |
dhellmann | fungi: ^^ | 19:36 |
fungi | i just wanted to have *some* working project i could use to test our first py3k jenkins slave before i go spin up several more | 19:36 |
dhellmann | Alex_Gaynor: one step at a time | 19:36 |
Alex_Gaynor | dhellmann: I'm just a computer person trying to do a thing (more importantly it now supports pypy :P) | 19:37 |
fungi | dhellmann: i'll try making it pull that ref for the job i'm about to fire off and see how it fares | 19:37 |
dhellmann | fungi: sounds good | 19:37 |
dstufft | Alex_Gaynor: want PyPy3K | 19:37 |
dstufft | :D | 19:38 |
Alex_Gaynor | dstufft: it's becoming a thing, slowly, they're getting close to release, they want to fix up some performance regressions first | 19:38 |
mordred | dhellmann: awesome. I like comments on how to clean things up | 19:38 |
dstufft | Alex_Gaynor: awesome | 19:38 |
mordred | dhellmann, fungi testr WAS compat, then I added a non-compat patch | 19:39 |
dhellmann | mordred: the thing that was breaking was the bzr checkout | 19:39 |
mordred | but if you're using recent pbr, you shouldn't need to touch the non-py3 compat code path | 19:39 |
mordred | that I can't help with :) | 19:39 |
dhellmann | yeah | 19:39 |
mordred | but I don't think we need it anymore | 19:39 |
dhellmann | see my patch ^^ | 19:39 |
mordred | since we released pbr thig morning | 19:40 |
mordred | where patch? | 19:40 |
dhellmann | https://review.openstack.org/38084 | 19:40 |
dhellmann | mordred: also https://review.openstack.org/#/c/38083/ | 19:40 |
* dhellmann has python3/virtualenvwrapper users breathing down his neck on that one | 19:41 | |
mordred | dhellmann: 38032 +2/aprvd | 19:41 |
fungi | mordred: yeah, lifeless let me know it was all your fault testr ceased to work on py3k | 19:42 |
mordred | fungi: yes. and pbr provides the codepath for that now | 19:42 |
fungi | but latest release of it is fixed now | 19:42 |
*** vipul has joined #openstack-infra | 19:42 | |
mordred | and of pbr | 19:42 |
dhellmann | mordred: I don't know what you approved, but 38032 isn't mine :-) | 19:43 |
*** GheRiver1 has joined #openstack-infra | 19:43 | |
mordred | dhellmann: I meant 38083 | 19:43 |
dhellmann | got it | 19:43 |
mordred | dhellmann: for 84 - how about we just remove the | 19:43 |
mordred | test-requirements-py3.txt | 19:43 |
mordred | file | 19:43 |
mordred | ? | 19:43 |
dhellmann | oh, we could do that | 19:43 |
dhellmann | I assumed there were more differences | 19:44 |
openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: Replace entry_points console_scripts https://review.openstack.org/38000 | 19:44 |
* dhellmann rewrites patch | 19:44 | |
mordred | nope. it was just there for the bzr thing | 19:44 |
*** SpamapS_ has joined #openstack-infra | 19:44 | |
mordred | also - thanks for the entry_points review- I should have done that anyway :) | 19:44 |
*** Daviey_ has joined #openstack-infra | 19:45 | |
dhellmann | mordred: looking at that one again now | 19:45 |
*** swifterdarrell_ has joined #openstack-infra | 19:45 | |
dhellmann | mordred: +2 on the new version | 19:46 |
mordred | dhellmann: woot! | 19:46 |
*** changbl_ has joined #openstack-infra | 19:46 | |
* mordred thinks that many of these are going to land today | 19:46 | |
dhellmann | man, I thought tox was cool before but with detox it's even better | 19:46 |
*** bnemec_ has joined #openstack-infra | 19:46 | |
mordred | what's detox? | 19:46 |
*** woodspa_ has joined #openstack-infra | 19:46 | |
dhellmann | runs each tox env at the same time | 19:47 |
mordred | ah. neat | 19:47 |
Alex_Gaynor | dhellmann: someone should ask holger to merge that into tox proper | 19:47 |
*** NobodyCa1 has joined #openstack-infra | 19:47 | |
dhellmann | Alex_Gaynor: yeah, that would be cool -- I haven't looked at the implementation, so I don't know how hard it would be | 19:47 |
mordred | dhellmann: did I tell you I got setup.py develop support into tox too? | 19:48 |
Alex_Gaynor | dhellmann: I think it uses eventlet and just shells out to tox itself possibly *hand waves* | 19:48 |
dhellmann | mordred: the virtualenvwrapper tests take forever because they're all integration tests for a shell script, so detox cuts the wait time appreciably | 19:48 |
mordred | holy jeez | 19:48 |
dhellmann | mordred: no, that's great, though! | 19:48 |
mordred | dhellmann: so, you know that you should be able to run shunit stuff with testr as well *hand waves* | 19:48 |
dhellmann | Alex_Gaynor: there is eventlet involved, but it also only builds the package once so I think there's something smarter going on | 19:49 |
*** cp16net_ has joined #openstack-infra | 19:49 | |
mordred | if there's a way to get shunit to output subunut | 19:49 |
dhellmann | mordred: I'm not sure shunit2 is compatible with subunit | 19:49 |
mordred | dhellmann: subunit is just an output encoding | 19:50 |
dhellmann | maybe that could be added to shunit2, then | 19:50 |
dhellmann | right now it just prints crap to the screen | 19:50 |
mordred | we should get lifeless to do that | 19:50 |
dhellmann | and shunit2 doesn't let you run a single test, iirc | 19:50 |
*** crank_ has joined #openstack-infra | 19:50 | |
mordred | ah, well, that might be a larger thing :) | 19:50 |
dhellmann | I'm not sure how the parallelization part for testr would work | 19:50 |
dhellmann | yeah | 19:50 |
* mordred is super happy about the pbr re-org from this morning though - I think I can write a BUNCH more unittests sensibly now | 19:51 | |
openstackgerrit | Doug Hellmann proposed a change to openstack-dev/pbr: Fix python 3.3 tests https://review.openstack.org/38084 | 19:52 |
*** jgriffit1 has joined #openstack-infra | 19:52 | |
*** vipul-away has quit IRC | 19:52 | |
mordred | k. +2/APRV | 19:52 |
*** SergeyLu_ has joined #openstack-infra | 19:52 | |
*** changbl has quit IRC | 19:52 | |
*** Daviey has quit IRC | 19:52 | |
*** GheRivero has quit IRC | 19:52 | |
*** Daviey_ is now known as Daviey | 19:53 | |
mordred | fungi: once those land, pbr should be a great candidate for your first py3 slave | 19:53 |
*** woodspa has quit IRC | 19:53 | |
*** jaypipes has quit IRC | 19:53 | |
*** swifterdarrell has quit IRC | 19:53 | |
*** bnemec has quit IRC | 19:53 | |
*** SpamapS has quit IRC | 19:53 | |
mordred | fungi: and I fully support adding gating | 19:53 |
*** cp16net has quit IRC | 19:53 | |
*** SergeyLukjanov has quit IRC | 19:53 | |
*** arosen has quit IRC | 19:53 | |
*** s1rp_ has quit IRC | 19:53 | |
*** crank has quit IRC | 19:53 | |
*** jesusaurus has quit IRC | 19:53 | |
*** NobodyCam has quit IRC | 19:53 | |
*** jgriffith has quit IRC | 19:53 | |
*** cp16net_ is now known as cp16net | 19:53 | |
dhellmann | mordred: assuming the tests pass, could we do another release of pbr today so I can bump virtualenvwrapper again and python 3 users can install it? | 19:53 |
mordred | devananda: yes | 19:53 |
mordred | gah | 19:53 |
mordred | dhellmann: yes | 19:53 |
fungi | mordred: excellent. i have just a handful more teensy patches i need to submit to puppet for to with the precisepy3k happymaking, but i'll have some prelim results here momentarily | 19:54 |
mordred | dhellmann: I'm going to be a bit aggressive about landing the outstanding things we have that we know that are good but that we've been blocking to ensure that the gate was solid. I think the gate is solid now | 19:54 |
* dhellmann nodsd | 19:54 | |
dhellmann | nods even | 19:54 |
fungi | dhellmann: i also recommend proposing the equivalent of 38084 to oslo.config as well, if you haven't already | 19:55 |
*** zaro0508 has joined #openstack-infra | 19:57 | |
dhellmann | fungi: thanks for the tip, I'll do that | 19:57 |
mordred | fungi: if you've got a sec, I'd like to land the sequence of patches dhellmann +2'd here: https://review.openstack.org/#/c/38000/ (and dependencies) | 19:57 |
*** sileht has joined #openstack-infra | 19:57 | |
fungi | mordred: i'll check as many as i can, but we're about to land and then i need to go find my hotel room | 19:58 |
mordred | fungi: no worries | 19:58 |
fungi | so it may be a few hours | 19:58 |
*** SergeyLu_ has quit IRC | 19:58 | |
*** swifterdarrell_ is now known as swifterdarrell | 19:58 | |
*** crank has joined #openstack-infra | 19:58 | |
*** ekarlso- has joined #openstack-infra | 19:58 | |
*** jaypipes has joined #openstack-infra | 19:58 | |
*** crank_ has quit IRC | 19:59 | |
*** ekarlso has quit IRC | 19:59 | |
*** jcooley has quit IRC | 19:59 | |
*** jcooley has joined #openstack-infra | 20:00 | |
fungi | dhellmann: mordred: works running pbr py33 unit tests on a precisepy3k slave with patchset #1 of 38084 (haven't tested ps2 but i expect it to be similarly fine) https://jenkins.openstack.org/job/fungi-node-tester/32/consoleText | 20:01 |
dhellmann | \o/ | 20:02 |
mordred | w00t! | 20:02 |
dhellmann | I'm getting failures with oslo.config and python 3 because pip can't figure out how to install pbr | 20:02 |
dhellmann | my env may be borked, though | 20:02 |
fungi | once i get checked into the hotel and then do early checkin for the conference, i'll get the straggler puppetry changes up for review so i can spin up an official batch of these slaves | 20:03 |
mordred | w00t | 20:03 |
dhellmann | excellent | 20:03 |
dhellmann | interesting | 20:04 |
dhellmann | tox does not use the virtualenv for the packaging step | 20:04 |
mordred | right. | 20:05 |
mordred | that's actually one of the reasons I wrote the setup.py develop patch | 20:05 |
mordred | which runs the setup.py in the context of the virtualenv | 20:06 |
dhellmann | ok, now I've got pbr installed locally but building the env fails trying to install hacking | 20:06 |
mordred | so that this problem goes away | 20:06 |
dhellmann | makes sense | 20:06 |
mordred | oh - what's wrong with hacking? | 20:06 |
dhellmann | it's trying to install pbr, but can't find it | 20:06 |
dhellmann | hacking 0.5.6 from my cache, maybe I need a newer one? | 20:06 |
dhellmann | this is on os x, because I don't have python 3 on my linux vm yet | 20:07 |
mordred | it should work ... | 20:07 |
mordred | although there is a newer hacking | 20:08 |
fungi | mordred: looking over 38079 i see shutil.copytree... it worth noting i've been seeing nondeterministic behavior out of copytree and rmtree in dina's git-review test change ( https://review.openstack.org/35104 ). not sure why or whether that's terribly relevant, but wanted to mention it | 20:08 |
mordred | thanks. | 20:08 |
fungi | also not sure whether that's potentially an artifact of the systems where i'm running it, but if it's a pattern we're copying around between testsuites then i'd be interested to know the underlying cause | 20:10 |
mordred | very much so | 20:10 |
fungi | when i see it break, it looks like http://paste.openstack.org/show/40021/ | 20:10 |
*** s1rp has joined #openstack-infra | 20:11 | |
mordred | yikes. | 20:11 |
fungi | re-running it repeatedly, sometimes the tests pass and sometimes they fail in either copytree or rmtree, seemingly at random | 20:11 |
*** arosen has joined #openstack-infra | 20:12 | |
fungi | and hunting around for similar examples, i see many people mention that you should implement your own exception handling for those multi-operation functions to retry or ignore as appropriate | 20:13 |
fungi | on my test system, that's running on reiserfs on lvm on ssd, so it's possible something in that stack there gives those functions grief. i'll try to see if it also happens on a vm like one of our slaves | 20:17 |
fungi | anyway, landing... back later | 20:17 |
*** Ryan_Lane has joined #openstack-infra | 20:18 | |
*** linuxmohan has joined #openstack-infra | 20:19 | |
*** hashar has quit IRC | 20:22 | |
*** ladquin has joined #openstack-infra | 20:23 | |
*** linuxmohan has quit IRC | 20:25 | |
lifeless | mordred: dhellmann: I have shunit bindings in subunit | 20:27 |
openstackgerrit | A change was merged to openstack-dev/pbr: Fix integer_types type under python 3 https://review.openstack.org/38083 | 20:27 |
lifeless | a shunit2 set should be straight forward; doing an upgrade to subunit2 will be a little more complex, but subunit-1to2 exists | 20:27 |
*** koolhead17 has quit IRC | 20:28 | |
*** hashar has joined #openstack-infra | 20:38 | |
*** hashar has quit IRC | 20:51 | |
*** ladquin has quit IRC | 20:51 | |
dhellmann | lifeless: cool, I'll look for those | 20:54 |
*** dhellmann is now known as dhellmann_ | 20:56 | |
*** dkliban_ has quit IRC | 20:56 | |
*** sarob has joined #openstack-infra | 20:59 | |
*** sarob has quit IRC | 21:03 | |
lifeless | (shunit2 didn't exist when I started subunit, and I just haven't gotten around to upgrading | 21:06 |
dhellmann_ | lifeless: I don't think I ever saw the original shunit. Same author? | 21:21 |
openstackgerrit | A change was merged to openstack-dev/pbr: Set defaults directly in option processing https://review.openstack.org/38078 | 21:22 |
lifeless | dhellmann_: AFAIK shunit2 is a Google thing. | 21:27 |
lifeless | dhellmann_: http://shunit.sourceforge.net/ | 21:27 |
lifeless | is shunit. | 21:27 |
*** jesusaurus has joined #openstack-infra | 21:45 | |
dhellmann_ | lifeless: shunit looks different, maybe better | 21:56 |
*** sarob has joined #openstack-infra | 21:59 | |
lifeless | dhellmann_: :) | 22:01 |
*** sarob has quit IRC | 22:04 | |
*** sgviking has joined #openstack-infra | 22:05 | |
*** koobs has quit IRC | 22:08 | |
*** CaptTofu has joined #openstack-infra | 22:37 | |
*** sarob has joined #openstack-infra | 22:48 | |
openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: Replace setuptools_git with a smarter approach https://review.openstack.org/30522 | 22:59 |
openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: We force installs via pip, we should declare it. https://review.openstack.org/34154 | 22:59 |
*** ianw has joined #openstack-infra | 23:01 | |
openstackgerrit | Aleksey Maksimov proposed a change to openstack-infra/jenkins-job-builder: Updated documentation for 'shallow-clone' param https://review.openstack.org/38091 | 23:04 |
zul | yeah i have som oslo.config python3 patches to queue up | 23:21 |
*** CaptTofu has quit IRC | 23:22 | |
*** CaptTofu has joined #openstack-infra | 23:23 | |
zul | i can start queueing them tonight if you want | 23:24 |
*** michchap has joined #openstack-infra | 23:27 | |
*** CaptTofu has quit IRC | 23:28 | |
sarob | same validation error on build jeremy | 23:54 |
sarob | fungi: same validation error on build | 23:55 |
sarob | fungi:https://review.openstack.org/#/c/37613/ | 23:56 |
Alex_Gaynor | When will using testr for tempest become the only way of doing it? | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!