*** manishg has quit IRC | 00:00 | |
morganfainberg | clarkb, not a bother at all, rather explain it if that makes the infra folks happier about the change :) | 00:00 |
---|---|---|
*** mrmartin has joined #openstack-infra | 00:00 | |
clarkb | morganfainberg: then when we are ready to gate everything on this I think some partition of the existing jobs should just use apache instead | 00:00 |
clarkb | morganfainberg: eg apache keystone with postgres or with neutron or whatever | 00:00 |
*** manishg has joined #openstack-infra | 00:01 | |
morganfainberg | clarkb, ++ my goal is to make keystone's default deployment in devstack apache (long term) | 00:01 |
morganfainberg | clarkb, in either case, i totally agree combining deployment types at some point. | 00:01 |
clarkb | now I am waiting for gertty to catch up with the -1 I left so that it doesn't override my +2 that I want to give | 00:01 |
morganfainberg | clarkb, hehe thanks :) | 00:01 |
openstackgerrit | A change was merged to openstack-infra/config: Clean up some variable references https://review.openstack.org/88475 | 00:02 |
clarkb | should have this approved shortly | 00:02 |
anteaya | StevenK: it said it didn't work to send it to keyserver.ubuntu.com and it sent it to keys.gnupg.net | 00:02 |
anteaya | StevenK: how do I confirm it is there? | 00:02 |
morganfainberg | clarkb, awesome! this will make us keystone folks happy. | 00:02 |
StevenK | anteaya: --keyserver argument passing to gnupg is terrible at best. | 00:02 |
*** fifieldt has joined #openstack-infra | 00:03 | |
StevenK | anteaya: keys.gnupg.net has a web interface, but the search is broken. | 00:04 |
StevenK | Which is just lol-tastic | 00:04 |
*** zns has quit IRC | 00:04 | |
clarkb | morganfainberg: and approved | 00:04 |
morganfainberg | clarkb, i agree we should add those to devstack/tempest as well (perhaps ds-g) | 00:04 |
*** manishg has quit IRC | 00:05 | |
morganfainberg | clarkb, do you want that as a separate patch? or in the child? | 00:05 |
anteaya | gpg --send-keys <8 digit key id> keyserver.ubuntu.com | 00:05 |
anteaya | that is the command I had used | 00:05 |
clarkb | morganfainberg: I would wait a bit and maybe we can just go straight to gating on this everywhere | 00:05 |
anteaya | what should I have done? | 00:05 |
*** ramashri has joined #openstack-infra | 00:05 | |
clarkb | morganfainberg: if this works properly as is I think it would be safe to pick some subset of jobs and use apache there | 00:05 |
morganfainberg | clarkb, great. works for me. | 00:05 |
StevenK | anteaya: --keyserver after the key id | 00:05 |
openstackgerrit | A change was merged to openstack-infra/config: Upload tooz tarballs to PyPI https://review.openstack.org/91769 | 00:05 |
morganfainberg | clarkb, ++ | 00:05 |
anteaya | StevenK: I will try that | 00:05 |
*** manishg has joined #openstack-infra | 00:06 | |
morganfainberg | clarkb, thanks again! | 00:06 |
StevenK | anteaya: The 8 digit key id is public information, too, so you don't need to snip it out. :-) | 00:06 |
openstackgerrit | A change was merged to openstack-infra/config: Set Alpha Channel for better looking favicon https://review.openstack.org/91441 | 00:06 |
*** bhuvan has quit IRC | 00:06 | |
clarkb | mordred: arg I just approved a thing you approved | 00:07 |
*** matsuhashi has joined #openstack-infra | 00:07 | |
clarkb | mordred: there are definitely some rought edges to gertty | 00:07 |
anteaya | StevenK: http://paste.openstack.org/show/79498/ | 00:07 |
morganfainberg | clarkb, i keep meaning to try out gertty | 00:07 |
anteaya | okay | 00:07 |
morganfainberg | clarkb, sounds like it isn't 100% there yet. | 00:07 |
anteaya | morganfainberg: worth a test drive | 00:08 |
clarkb | morganfainberg: well this most recent thing is related to it being an offline review tool | 00:08 |
clarkb | morganfainberg: which means it may get slightly out of sync. But you can review on an airplane | 00:08 |
*** yamahata has joined #openstack-infra | 00:08 | |
anteaya | morganfainberg: fairly easy to set up | 00:08 |
clarkb | morganfainberg: it is pretty amazing otherwise | 00:08 |
*** SumitNaiksatam has quit IRC | 00:08 | |
StevenK | anteaya: This is what I was saying, gnupg's option parsing is terrible. | 00:08 |
anteaya | it does eat cpu when you subscribe though | 00:08 |
morganfainberg | clarkb, oooh on the plane! | 00:08 |
anteaya | StevenK: k | 00:08 |
StevenK | anteaya: gnupg --send-keys --keyserver keyserver.ubuntu.com 0x<8 digit key> | 00:08 |
anteaya | StevenK: I'll try that | 00:09 |
mordred | clarkb: yah. the async part, although awesome, is also not my favorite at moments | 00:09 |
morganfainberg | i'll def look into it | 00:09 |
morganfainberg | anteaya, clarkb, thanks :) | 00:09 |
clarkb | dims are you around? | 00:09 |
mordred | I kinda of want a commit button that's synchronous that i can use to make sure I'm in sync | 00:09 |
clarkb | mordred: jhesketh on 92016 that span class name is auto generated right? | 00:09 |
clarkb | makes me worry about breaking the css when we update gerrit | 00:09 |
anteaya | StevenK: thanks, taht looks like it worked | 00:09 |
*** manishg has quit IRC | 00:10 | |
anteaya | StevenK: how can I verify? | 00:10 |
clarkb | mordred: yeah | 00:10 |
StevenK | anteaya: keyserver.ubuntu.com has a web interface, search for your key id | 00:10 |
*** james_li has quit IRC | 00:10 | |
StevenK | anteaya: I see it, first hex digit is A, last is 4. | 00:10 |
*** manishg has joined #openstack-infra | 00:10 | |
jhesketh | clarkb: I'm not sure, to be honest | 00:11 |
openstackgerrit | A change was merged to openstack-infra/config: Add tool to parse puppet reports https://review.openstack.org/91207 | 00:11 |
jhesketh | clarkb: I inspected the html and the class was on the correct parts | 00:11 |
anteaya | StevenK: yes, thanks | 00:11 |
*** timrc-afk is now known as timrc | 00:11 | |
*** pcrews has quit IRC | 00:11 | |
jhesketh | but I'm not sure if it's hard coded, configured or generated | 00:11 |
StevenK | anteaya: You're very welcome :-) | 00:12 |
* StevenK scampers off to raid the kitchen for some breakfast | 00:12 | |
clarkb | jhesketh: ya I am trying to look into that now | 00:13 |
*** crc32 has quit IRC | 00:13 | |
clarkb | but not seeing that span in the source of the change I have open | 00:13 |
anteaya | happy breakfast | 00:13 |
*** manishg has quit IRC | 00:15 | |
*** manishg has joined #openstack-infra | 00:15 | |
* clarkb has no idea what he is doing looking for that string | 00:15 | |
*** oomichi has joined #openstack-infra | 00:16 | |
*** Alexandra_ has quit IRC | 00:17 | |
morganfainberg | so i just noticed something odd. it looks like zuul popped something frmo check to gate before the check finished? | 00:19 |
*** manishg has quit IRC | 00:20 | |
clarkb | jhesketh: where did you find it? | 00:20 |
morganfainberg | it was a dependant change. | 00:20 |
clarkb | morganfainberg: did someone push a new patchset? | 00:20 |
morganfainberg | clarkb, no this was the infra ones you just approved | 00:20 |
clarkb | https://review.openstack.org/#/c/91739/4 that one? | 00:20 |
morganfainberg | clarkb, the 2nd patch 91739 appeared in gate ebfore check finished | 00:20 |
morganfainberg | clarkb, yeah | 00:20 |
*** manishg has joined #openstack-infra | 00:20 | |
*** rwsu has joined #openstack-infra | 00:20 | |
morganfainberg | clarkb, i've seen that happen every now and again come to think of it | 00:21 |
clarkb | it +1'd it | 00:21 |
openstackgerrit | A change was merged to openstack-infra/config: Add apache-configured devstack tempest test https://review.openstack.org/91738 | 00:21 |
morganfainberg | clarkb, ah ok. | 00:21 |
morganfainberg | clarkb, yeah it finished normally. i think i've seen a case where it still -1'd and ended up +2ing the gate | 00:22 |
openstackgerrit | A change was merged to openstack-infra/config: Enable apache-configured-service tempest for keystone https://review.openstack.org/91739 | 00:22 |
morganfainberg | clarkb, i'll keep my eyes peeled and see if i can find one of those / let you know if it happens | 00:22 |
morganfainberg | clarkb, if anything it seems infrequent / edge case at best | 00:22 |
clarkb | morganfainberg: you mean it -1'd in check then went on to gate and got +2? | 00:22 |
morganfainberg | clarkb, yeah i think i've seen that before, something (child patchset) moved to gate ebfore check finished | 00:23 |
clarkb | in that case it should report the -1 then next time someone bumps it it will check + gate again | 00:23 |
clarkb | jhesketh: I am derpy when it comes to css but I can't find that in chromium or firefox | 00:23 |
jeblair | morganfainberg: yeah, it's possible (but fortunately we still have gate checks that will prevent that from merging) | 00:23 |
jeblair | morganfainberg: we recently merged a change to zuul that will let us plug that logic hole | 00:24 |
jhesketh | clarkb: https://review.openstack.org/#/c/90870/ | 00:24 |
morganfainberg | jeblair, ++ cool | 00:24 |
jhesketh | clarkb: expand all the comments | 00:24 |
jeblair | morganfainberg: but we're waiting on a more comprehensive test before we change the config to use it | 00:24 |
jhesketh | clarkb: it's the ones where they overrun the comment field | 00:24 |
jhesketh | because they are formatted as code blocks | 00:24 |
morganfainberg | jeblair, makes sense to me. | 00:24 |
morganfainberg | jeblair, it means i'm not taking crazy pills :) | 00:24 |
jeblair | morganfainberg: cause, well, there are a lot of possible branches :) | 00:24 |
clarkb | jeblair: oh is that part of the requires change? | 00:25 |
*** manishg has quit IRC | 00:25 | |
jeblair | clarkb: yeah -- because a +1 verify requirement on a trigger is not checked when a change is pulled in because it's a mergable dependency | 00:25 |
jeblair | clarkb: whereas putting the requirement in the pipeline enqueue check will make it enforced all the time | 00:25 |
clarkb | gotcha | 00:25 |
*** manishg has joined #openstack-infra | 00:26 | |
clarkb | jhesketh: there it is thanks | 00:27 |
clarkb | going to zgrep on a couple gerrit wars | 00:27 |
jeblair | clarkb, mordred: if you have interesting gertty debug logs from when it behaved unexpectedly, that could be helpful | 00:27 |
clarkb | jeblair: rgr so far I think most of the issues have been expected | 00:27 |
mordred | jeblair: yah - not an issue as much as just the way busy things work I believe | 00:28 |
*** matsuhashi has quit IRC | 00:28 | |
mordred | jeblair: well, I have crashed gerrty a few times by reviewing too quickly and hitting a sqlite lock | 00:28 |
mordred | jeblair: and by reviewing too quickly - I mean "marking as read" too quickly | 00:29 |
*** manishg has quit IRC | 00:30 | |
dims | clarkb, pong | 00:30 |
jeblair | mordred: ok. me might need to check that review uploads get high priority (i think they do) -- but we may also need to double check that refreshes of changes that have just had their review uploaded also get high priority | 00:30 |
*** manishg has joined #openstack-infra | 00:31 | |
clarkb | dims: 92016 that span class name doesn't look reliable to me | 00:31 |
clarkb | dims: any idea if it is consistent across gerrit builds? | 00:31 |
clarkb | dims: I am looking int othat too | 00:31 |
*** matsuhas_ has joined #openstack-infra | 00:31 | |
jeblair | mordred: ok; i've tried to avoid the sqlite lock issue by keeping the sections that actually use the db very small, but other than that, have done basically nothing around sqlite tuning, so there's probably much more we can do there | 00:32 |
bknudson | seen this before? http://logs.openstack.org/26/92726/1/check/check-grenade-dsvm/aa65a79/console.html#_2014-05-07_23_48_18_154 | 00:32 |
bknudson | Non-zero exit code (2) from test listing. stdout='\xb | 00:32 |
mordred | jeblair: I can look at it on a plane trip ;0 | 00:32 |
mordred | wow. that was not the smiley I wanted to type | 00:32 |
dims | clarkb, is there a gerrit instance with that update? | 00:32 |
*** msabramo has quit IRC | 00:33 | |
clarkb | dims: right now we don't have a gerrit with different versions | 00:33 |
jeblair | mordred: ++ | 00:33 |
clarkb | we do have different wars at http://tarballs.openstack.org/ci/gerrit/ though | 00:33 |
mordred | jeblair: I did use gertty a lot this afternoon and found it quite pleasant | 00:33 |
jeblair | yay! | 00:33 |
clarkb | dims: I grabbed the same version we have deployed and zgrep doesn't find that JDC* string either | 00:33 |
clarkb | not sure if zgrep is at fault or if multiple levels of compression | 00:33 |
mordred | jeblair: with one or two ui things that I haven't felt like I've used it long enough to suggest as bugs- so I should have real feedback by the summit | 00:34 |
dims | clarkb, looking | 00:34 |
*** manishg has quit IRC | 00:35 | |
*** manishg has joined #openstack-infra | 00:36 | |
*** aconrad has quit IRC | 00:36 | |
clarkb | dims: ok I unzipped the wars and used grep -r and it shows up in 2.8.1something and 2.8.4something | 00:38 |
clarkb | so we are probably ok | 00:38 |
*** etoews has joined #openstack-infra | 00:38 | |
clarkb | dims: also what editor do you use? you should teach it that files end with a newline :) | 00:39 |
*** prad_ has quit IRC | 00:39 | |
anteaya | I just updated my gertty repo, what command to start gertty now? | 00:39 |
dims | clarkb, will do :) switching laptops now (ubuntu->osx) all my tools are in a mess/flux | 00:40 |
clarkb | dims: my last comment is shouldn't you use pre-wrap instead of pre-line? | 00:40 |
clarkb | dims: nnnooooo | 00:40 |
clarkb | use the linux :) | 00:40 |
anteaya | I tried python gertty/app.py which didn't work | 00:40 |
*** manishg has quit IRC | 00:40 | |
clarkb | anteaya: just `gertty` after pip installing gertty | 00:40 |
*** matsuhas_ has quit IRC | 00:40 | |
*** matsuhashi has joined #openstack-infra | 00:41 | |
*** mrmartin has quit IRC | 00:41 | |
*** manishg has joined #openstack-infra | 00:41 | |
*** msabramo has joined #openstack-infra | 00:41 | |
anteaya | ah I handn't done pip install | 00:41 |
openstackgerrit | K Jonathan Harker proposed a change to openstack-infra/devstack-gate: Allow for an alternate fallback branch https://review.openstack.org/92736 | 00:42 |
jeblair | anteaya: if you do 'pip install -e .' in the repo, then you won't need to install it again when you git pull | 00:43 |
anteaya | great, I will do that | 00:44 |
*** manishg has quit IRC | 00:45 | |
mattoliverau | jeblair: awesome work on gertty btw! What an great tool :) | 00:46 |
anteaya | I still can so no reviews in gertty | 00:46 |
*** manishg has joined #openstack-infra | 00:46 | |
anteaya | perhaps I am missing something | 00:46 |
clarkb | anteaya: you have to hit l to list all projects then subscribe to some projects iwth s | 00:47 |
anteaya | I have | 00:47 |
clarkb | it should then clone and sync then hit enter on a project whihc will take you to the project's change list | 00:47 |
anteaya | I am subscribed to 4 of them | 00:47 |
anteaya | I will try hitting enter some more | 00:47 |
*** timrc is now known as timrc-afk | 00:48 | |
clarkb | dims: well I decided it should be pre-wrap so I -1'd | 00:49 |
*** jasondotstar has joined #openstack-infra | 00:50 | |
openstackgerrit | A change was merged to openstack-infra/config: TripleO: use the common-venv element by default. https://review.openstack.org/91870 | 00:50 |
*** melwitt has quit IRC | 00:50 | |
*** manishg has quit IRC | 00:50 | |
jeblair | mattoliverau: thanks -- it's early days yet, lots left to do! (i'm trying not to over-promise it yet) | 00:50 |
dims | clarkb, cool, will resubmit | 00:51 |
*** manishg has joined #openstack-infra | 00:51 | |
clarkb | dims: otherwise I think anyone doing code blocks that go long will lose their formatting whitespace | 00:51 |
*** markmcclain1 has quit IRC | 00:52 | |
*** jhesketh has quit IRC | 00:53 | |
mgagne | has anyone installed the openstack summit android app? | 00:53 |
clarkb | no, previous summits have made me use the website instead | 00:54 |
mgagne | clarkb: what is the account linked to? is it a standalone account for the sole purpose of using the app or is it linked to launchpad or something? | 00:54 |
clarkb | mgagne: its the sched.org account | 00:55 |
clarkb | whcih is standalone or facebook or linked in iirc | 00:55 |
clarkb | I use standalone | 00:55 |
*** manishg has quit IRC | 00:55 | |
mgagne | clarkb: right, would have been great to mention it somewhere on the sign in screen ^^' | 00:55 |
clarkb | mgagne: the mobile site works great | 00:56 |
anteaya | jeblair: ArxCruz likes http://docs.python-requests.org/en/latest/index.html as a suggestion for nodepool/jenkins communication | 00:57 |
anteaya | jeblair: he tweeted but you aren't on the twitter | 00:57 |
mgagne | clarkb: doesn't look to be linked to sched.org | 00:57 |
clarkb | mgagne: huh | 00:58 |
ArxCruz | :) | 00:58 |
clarkb | mgagne: you are going to get me to install this thing | 00:58 |
mgagne | clarkb: the app looks to be written with/by guidebook.com | 00:59 |
clarkb | mgagne: is it in the play store? | 01:00 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack-infra/config: Gerrit - Break up long lines to fit https://review.openstack.org/92016 | 01:01 |
mgagne | clarkb: yep, 2s | 01:01 |
mgagne | clarkb: https://play.google.com/store/apps/details?id=com.guidebook.apps.OpenStack.android&awesm=awe.sm_gKL9f&rdid=com.guidebook.apps.OpenStack.android | 01:01 |
*** sdake_ has quit IRC | 01:01 | |
mgagne | clarkb: link found here: https://twitter.com/OpenStack/status/463784431820341248 | 01:01 |
*** mrodden has joined #openstack-infra | 01:02 | |
anteaya | ArxCruz: it looks interesting to me | 01:03 |
clarkb | and suddenly I am reminded why I don't install these things | 01:03 |
clarkb | it wants access to the accounts on my phone wtf | 01:03 |
ArxCruz | anteaya: yes, pretty much, and much more readable | 01:03 |
anteaya | ArxCruz: would there be bugs it would address, do you think? | 01:04 |
mgagne | clarkb: probably to store his own account | 01:04 |
ArxCruz | yup | 01:04 |
*** aconrad has joined #openstack-infra | 01:05 | |
clarkb | mgagne: it looks like this is completely independent of sched | 01:07 |
*** Ryan_Lane has quit IRC | 01:08 | |
*** mestery has quit IRC | 01:08 | |
clarkb | mgagne: https://guidebook.com/l/sched/ nevermind | 01:10 |
*** jhesketh has joined #openstack-infra | 01:10 | |
*** SumitNaiksatam has joined #openstack-infra | 01:10 | |
mgagne | clarkb: looks to be "linked" only for the event organizer, not the attendees | 01:11 |
ArxCruz | anteaya: I will see if I can work this weekend with this :) | 01:11 |
ArxCruz | if beers permits :D | 01:11 |
*** dims has quit IRC | 01:11 | |
*** zns has joined #openstack-infra | 01:11 | |
*** dims has joined #openstack-infra | 01:11 | |
clarkb | mgagne: confirmed I can't login with my sched account | 01:12 |
mgagne | clarkb: I tried too already =) | 01:12 |
*** msabramo has quit IRC | 01:12 | |
jeblair | ArxCruz: python-jenkins is on stackforge now | 01:12 |
*** dims has quit IRC | 01:13 | |
ArxCruz | jeblair: cool, I will try write some code replacing urlib with python-requests :) | 01:14 |
*** msabramo has joined #openstack-infra | 01:14 | |
*** dims has joined #openstack-infra | 01:15 | |
*** dims has quit IRC | 01:15 | |
*** dims has joined #openstack-infra | 01:15 | |
clarkb | mgagne: you should twitter @openstack and get it fixed | 01:15 |
clarkb | mgagne: but the mobile sched site works pretty well | 01:16 |
*** marcoemorais has quit IRC | 01:16 | |
*** dims has quit IRC | 01:16 | |
*** mriedem has joined #openstack-infra | 01:16 | |
mgagne | clarkb: I'm sure it works well. I however got curious about the app after reading about it on twitter | 01:17 |
*** dims has joined #openstack-infra | 01:18 | |
*** bhuvan has joined #openstack-infra | 01:19 | |
*** msabramo has quit IRC | 01:19 | |
*** msabramo has joined #openstack-infra | 01:19 | |
*** mrodden has quit IRC | 01:19 | |
anteaya | ArxCruz: beer fueled patches, I hear they are good | 01:20 |
*** dims has quit IRC | 01:20 | |
*** spredzy has joined #openstack-infra | 01:20 | |
*** dims has joined #openstack-infra | 01:21 | |
*** dims has quit IRC | 01:22 | |
ArxCruz | anteaya: :D | 01:22 |
*** dims has joined #openstack-infra | 01:22 | |
ArxCruz | anteaya: I though I was a good beer drinker until I see sdague list of beers... makes me very very sad... | 01:22 |
ArxCruz | anteaya: https://untappd.com/user/sdague | 01:23 |
openstackgerrit | Matthew Oliver proposed a change to stackforge/gertty: Add '?' as another way show help dialog https://review.openstack.org/92742 | 01:23 |
*** mrodden has joined #openstack-infra | 01:23 | |
*** mestery has joined #openstack-infra | 01:25 | |
*** mbacchi has quit IRC | 01:25 | |
*** aconrad has quit IRC | 01:25 | |
mattoliverau | jeblair: http://is.gd/VtREOw Added the ? key as another way of diesplaying the help dialog as gnome-terminal intercepts the <F1> key. | 01:25 |
mattoliverau | *displaying | 01:26 |
*** jaypipes has quit IRC | 01:28 | |
anteaya | ArxCruz: sdague writes some good code, I wonder if data should be collected about beer and patch quality | 01:28 |
ArxCruz | anteaya: indeed | 01:28 |
anteaya | mattoliverau: one small grammar comment about the commit message | 01:30 |
*** spredzy has left #openstack-infra | 01:32 | |
*** etoews has quit IRC | 01:33 | |
*** mestery has quit IRC | 01:34 | |
openstackgerrit | James E. Blair proposed a change to stackforge/gertty: Use alembic https://review.openstack.org/92744 | 01:36 |
openstackgerrit | James E. Blair proposed a change to stackforge/gertty: Add some helper methods to deal with sqlite migrations https://review.openstack.org/92745 | 01:36 |
openstackgerrit | James E. Blair proposed a change to stackforge/gertty: Increase the status field width and drop 'hidden' https://review.openstack.org/92746 | 01:36 |
*** UtahDave has joined #openstack-infra | 01:37 | |
jeblair | SergeyLukjanov: ^ alembic sqlite stuff based on what you did a while ago. would be great if you have a minute to take a look | 01:37 |
openstackgerrit | Clark Boylan proposed a change to stackforge/gertty: Remove MERGED changes from unreviewed list. https://review.openstack.org/92747 | 01:37 |
clarkb | jeblair: ^ thats a quick stab at fixing a minor annoyance but as the commit message says I am not quite sure it fixes the entire problem | 01:38 |
*** msabramo has quit IRC | 01:38 | |
jeblair | clarkb: that's actually what i was about to start on a few days ago when i noticed i needed a schema change and went down that branch; i'll take a look real quick and see how close it is to what i was about to do | 01:39 |
clarkb | jeblair: also I didn't need or_ anymore I should remove that but will wait for you to make a decision on whether or not that change is useful first | 01:41 |
openstackgerrit | Arnaud Legendre proposed a change to openstack-infra/config: Create glance-specs git repo https://review.openstack.org/90461 | 01:41 |
*** arnaud has joined #openstack-infra | 01:41 | |
jeblair | clarkb: that approach wfm for now, but we should do status not in ['MERGED', 'ABANDONED'] | 01:41 |
clarkb | oh right, I will update | 01:41 |
clarkb | and remove or_ | 01:41 |
jeblair | clarkb: maybe make the _closed_status class var a module level global and use it both places | 01:42 |
openstackgerrit | Ian Wienand proposed a change to openstack-infra/devstack-gate: Add distro check functions https://review.openstack.org/92748 | 01:42 |
jeblair | clarkb: oh, different module, that's in sync... | 01:42 |
jeblair | clarkb: whatever you think best. :) | 01:42 |
*** mrodden has quit IRC | 01:43 | |
clarkb | oh this has a counterpart in sync? probably trying to sync abandoned and merged changes | 01:43 |
clarkb | I will poke at it | 01:43 |
*** Ryan_Lane has joined #openstack-infra | 01:43 | |
*** zns has quit IRC | 01:43 | |
jeblair | clarkb: right now it doesn't _initially_ sync abandoned and merged, but it will keep updating them once they are imported | 01:43 |
jeblair | clarkb: but yeah, at some point we'll probably want to purge the db for efficiency. but thankfully not yet. :) | 01:44 |
*** nosnos has joined #openstack-infra | 01:44 | |
openstackgerrit | Ian Wienand proposed a change to openstack-infra/devstack-gate: Add distro check functions for Ubuntu and Fedora https://review.openstack.org/92748 | 01:45 |
*** homeless has quit IRC | 01:47 | |
*** mestery has joined #openstack-infra | 01:48 | |
*** unicell has joined #openstack-infra | 01:49 | |
*** jasondotstar has quit IRC | 01:50 | |
*** yaguang has joined #openstack-infra | 01:51 | |
*** UtahDave has quit IRC | 01:53 | |
*** UtahDave has joined #openstack-infra | 01:53 | |
mattoliverau | anteaya: thanks, I'll fix it up :) | 01:53 |
*** zehicle_at_dell has quit IRC | 01:55 | |
*** zehicle_at_dell has joined #openstack-infra | 01:56 | |
anteaya | mattoliverau: :D | 01:57 |
openstackgerrit | Clark Boylan proposed a change to stackforge/gertty: Ignore closed changes more. https://review.openstack.org/92747 | 01:57 |
clarkb | jeblair: ^ I want to say I perceived that chewing more cpu time but that may just be initial startup where it goes and syncs all the things | 01:57 |
mattoliverau | anteaya: I don't see the extra d you mention?... maybe my spelling is just that bad :P | 01:58 |
*** UtahDave has quit IRC | 01:58 | |
*** thomasem has joined #openstack-infra | 01:59 | |
*** UtahDave has joined #openstack-infra | 01:59 | |
*** thomasem has quit IRC | 01:59 | |
anteaya | and | 02:00 |
openstackgerrit | Matthew Oliver proposed a change to stackforge/gertty: Add '?' as another way show help dialog https://review.openstack.org/92742 | 02:00 |
anteaya | should that not be an | 02:00 |
anteaya | yes, you got it | 02:00 |
jeblair | clarkb: you went too far :) | 02:01 |
jeblair | (inline review) | 02:01 |
fungi | okay, https://wiki.openstack.org/wiki/OpenPGP_Web_of_Trust/Juno_Summit has now been updated too. calling it a night | 02:01 |
anteaya | fungi: great, the md5sum works for me | 02:01 |
anteaya | thanks | 02:01 |
anteaya | night all | 02:01 |
jeblair | fungi: good night, and thanks! | 02:01 |
*** harlowja has quit IRC | 02:03 | |
clarkb | jeblair gah. I know how to fix that though | 02:03 |
clarkb | my original pass at it was correct then I optimised | 02:03 |
*** harlowja has joined #openstack-infra | 02:04 | |
*** mengxd has joined #openstack-infra | 02:04 | |
jeblair | clarkb: ok -- i mean, i'm happy with the logic as-is there... :) | 02:04 |
*** LarsN has left #openstack-infra | 02:04 | |
openstackgerrit | Arnaud Legendre proposed a change to openstack-infra/config: Create glance-specs git repo https://review.openstack.org/90461 | 02:04 |
mattoliverau | anteaya: lol, I see, there extra d was in and.. to make it an.. of course! sorry, maybe I need another coffee or something :) | 02:04 |
mattoliverau | s/there/the/ | 02:05 |
*** arnaud has quit IRC | 02:05 | |
mattoliverau | night anteaya and fungi | 02:06 |
*** thomasem has joined #openstack-infra | 02:06 | |
*** thomasem has quit IRC | 02:06 | |
*** thomasem has joined #openstack-infra | 02:07 | |
*** signed8bit has quit IRC | 02:09 | |
clarkb | jeblair no I had an intermediate step | 02:11 |
clarkb | I didnt push it | 02:11 |
*** gokrokve has quit IRC | 02:11 | |
clarkb | walking home then dinner then I will fix | 02:12 |
*** mriedem has quit IRC | 02:12 | |
*** zz_gondoi is now known as gondoi | 02:12 | |
openstackgerrit | James E. Blair proposed a change to stackforge/gertty: Sync parent changes https://review.openstack.org/92753 | 02:13 |
jeblair | clarkb: ok. btw, ^ that change probably wants to be based on yours because it's another place that needs to know the list of closed states. | 02:14 |
clarkb | k | 02:14 |
jeblair | (i just marked that a todo for now) | 02:14 |
*** dims has quit IRC | 02:16 | |
*** thomasem has quit IRC | 02:16 | |
jhesketh | fungi: so I missed the keysigning sign up because I'm lame... are others allowed to participate somehow? For example, I could bring a printout of my key to hand to people and they can verify my ID as I give it to them | 02:16 |
*** dims has joined #openstack-infra | 02:16 | |
*** zhiyan_ is now known as zhiyan | 02:17 | |
*** UtahDave has quit IRC | 02:19 | |
jeblair | jhesketh: well, i for one will be happy to find time to verify your id regardless. :) | 02:20 |
jhesketh | :-) | 02:20 |
jeblair | mattoliverau: is there a pass-through modifier you can use with gnome-terminal for f1? | 02:20 |
* jhesketh will bring some printed fingerprints anyway and see what happens - even if just in the hallway | 02:21 | |
jeblair | mattoliverau: i tried to provide helpful suggestions in the welcome message about dealing with that problem | 02:21 |
jeblair | mattoliverau: but i don't actually have it, so i'm writing blind. :) | 02:21 |
greghaynes | "...bring a printout of my key": I hope youre not actually going to print out your key and hand those pages out | 02:22 |
clarkb | I disable f1 | 02:22 |
jeblair | mattoliverau: i think i'm ok with adding ?, but i also expect that we might add more fkeys | 02:22 |
clarkb | for help | 02:22 |
jeblair | clarkb: ++ | 02:22 |
clarkb | works great | 02:22 |
jeblair | jhesketh: sounds like a plan | 02:23 |
*** Alexandra_ has joined #openstack-infra | 02:27 | |
openstackgerrit | Nikhil Manchanda proposed a change to openstack-infra/config: Add new gate-trove-buildimage-mysql job https://review.openstack.org/92755 | 02:30 |
*** amcrn has joined #openstack-infra | 02:31 | |
Alex_Gaynor | Can someone who understands how testr works take a look at Alastair's comment https://review.openstack.org/#/c/92593/ ? | 02:34 |
*** oomichi has quit IRC | 02:35 | |
*** maxbit has joined #openstack-infra | 02:36 | |
*** etoews has joined #openstack-infra | 02:36 | |
*** dims has quit IRC | 02:37 | |
*** dims has joined #openstack-infra | 02:38 | |
clarkb | Alex_Gaynor: http://logs.openstack.org/93/92593/2/check/gate-python-swiftclient-python33/26eb8cb/console.html#_2014-05-07_15_44_04_341 failed to catch this | 02:39 |
clarkb | Alex_Gaynor: which is annoying | 02:39 |
Alex_Gaynor | clarkb: yeah, trying to understand why it's running 0 on py3k though, tests run fine on py2 | 02:39 |
clarkb | Alex_Gaynor: what does `.tox/py33/bin/testr last` spit out? | 02:39 |
clarkb | after running tox -epy27 | 02:39 |
*** UtahDave has joined #openstack-infra | 02:40 | |
clarkb | er tox -epy33 | 02:40 |
Alex_Gaynor | checking locally | 02:40 |
*** dims has quit IRC | 02:40 | |
Alex_Gaynor | clarkb: PASSED (id=42) | 02:40 |
clarkb | Alex_Gaynor: but not Ran X tests? | 02:41 |
Alex_Gaynor | Nope: | 02:41 |
Alex_Gaynor | https://www.irccloud.com/pastebin/Xv4efPaD | 02:41 |
clarkb | Alex_Gaynor: can you also paste `.tox/py33/bin/testr run --parallel` and `.tox/py33/bin/python -m subunit.run discover` | 02:42 |
clarkb | Alex_Gaynor: I think no tests are being matched and thus it says +1 | 02:42 |
*** gokrokve has joined #openstack-infra | 02:42 | |
clarkb | Alex_Gaynor: we have a check in place to try and catch that but its failing according to that console log | 02:42 |
Alex_Gaynor | https://www.irccloud.com/pastebin/EqeTf31W | 02:42 |
Alex_Gaynor | clarkb: discover prints... tons of binary stuff out, do you want me to pastebin it? | 02:43 |
clarkb | Alex_Gaynor: no thats fine | 02:43 |
*** UtahDave has quit IRC | 02:43 | |
*** harlowja has quit IRC | 02:44 | |
clarkb | Alex_Gaynor: `.tox/py33/bin/testr run --parallel tests.unit` would be the last intereting thing I can come up with | 02:44 |
*** gokrokve_ has joined #openstack-infra | 02:44 | |
clarkb | oh you know I know | 02:44 |
*** harlowja has joined #openstack-infra | 02:44 | |
clarkb | the test filter happens after discovery | 02:44 |
clarkb | is discovery failing and testr with a fitler does something different than testr without it? | 02:44 |
clarkb | lifeless: ^ | 02:44 |
Alex_Gaynor | https://www.irccloud.com/pastebin/72XDfTn7 | 02:44 |
clarkb | hrm no its fails in both cases correctly | 02:45 |
*** zns has joined #openstack-infra | 02:45 | |
lifeless | Alex_Gaynor: that looks like a sane error :) | 02:45 |
*** zns has quit IRC | 02:45 | |
lifeless | clarkb: whats up ? | 02:45 |
clarkb | ya running testr directly works fine | 02:45 |
clarkb | running tox -epy33 runs no tests | 02:46 |
clarkb | lifeless: http://logs.openstack.org/93/92593/2/check/gate-python-swiftclient-python33/26eb8cb/console.html | 02:46 |
Alex_Gaynor | (and passes!) | 02:46 |
clarkb | python swiftclient tox -epy33 runs no tests and apsses | 02:46 |
*** zns has joined #openstack-infra | 02:46 | |
clarkb | our check for that isn't working but also curious to why it runs zero tests | 02:46 |
Alex_Gaynor | There also doesn't appear to be an "all" import anywhere in swiftclient :/ | 02:46 |
clarkb | I don't have python33 handy on this machine (still precise) | 02:46 |
*** gokrokve has quit IRC | 02:47 | |
Alex_Gaynor | clarkb: if you feel like doing stuff, the deadsnakes PPA may be useful | 02:47 |
*** gokrokve_ has quit IRC | 02:49 | |
*** mestery has quit IRC | 02:49 | |
mattoliverau | jeblair: fair enough, using function keys is nice, but I think help should be a special case, as users will need to be able to easily use it so they can figure out how to use each view. We could make it 'h' instead, as you use 'l' and other letters for using most the views. | 02:50 |
mattoliverau | Anyway lunch time :) | 02:50 |
*** gondoi is now known as zz_gondoi | 02:51 | |
*** otherwiseguy has joined #openstack-infra | 02:52 | |
*** bhuvan has quit IRC | 02:53 | |
*** dims has joined #openstack-infra | 02:54 | |
*** moted has quit IRC | 02:55 | |
*** zz_gondoi is now known as gondoi | 02:56 | |
*** moted has joined #openstack-infra | 02:57 | |
*** moted_ has joined #openstack-infra | 03:00 | |
*** msabramo has joined #openstack-infra | 03:00 | |
openstackgerrit | Clark Boylan proposed a change to openstack-infra/config: Fix zero tests ran unittest check. https://review.openstack.org/92759 | 03:01 |
clarkb | Alex_Gaynor: ^ that should fix the test and make it fail | 03:01 |
*** moted has quit IRC | 03:01 | |
*** moted_ is now known as moted | 03:01 | |
clarkb | but its still a defensive thing not an actual make py33 work | 03:02 |
*** david-lyle has joined #openstack-infra | 03:02 | |
clarkb | Alex_Gaynor: after you run those tox commands that say non zero exit code from test listing what is $? ? | 03:02 |
clarkb | is it not 0? | 03:02 |
Alex_Gaynor | clarkb: 3 | 03:02 |
Alex_Gaynor | 3 is a cool status | 03:02 |
*** renlt has joined #openstack-infra | 03:04 | |
*** dims has quit IRC | 03:05 | |
* clarkb tries a thing | 03:06 | |
Alex_Gaynor | yay for things :-) | 03:07 |
*** signed8bit has joined #openstack-infra | 03:07 | |
clarkb | Alex_Gaynor: https://review.openstack.org/92760 lets see how that does | 03:07 |
clarkb | Alex_Gaynor: https://git.openstack.org/cgit/openstack-dev/pbr/tree/pbr/packaging.py#n456 | 03:08 |
Alex_Gaynor | clarkb: it's going to fail the same way default does (import errors inside the tests), you need to rebase it on https://review.openstack.org/#/c/92593/ to get useful knowledge | 03:08 |
clarkb | Alex_Gaynor: right but if it fails then we figured it out | 03:09 |
clarkb | pass or fail if it does the correct thing thats fine | 03:09 |
clarkb | https://jenkins02.openstack.org/job/gate-python-swiftclient-python33/184/console is the job | 03:09 |
clarkb | I think the testr command comes from testr itself and mordred made it broken | 03:10 |
clarkb | the test command from pbr however should work | 03:10 |
*** otherwiseguy has quit IRC | 03:10 | |
clarkb | mordred shoudl buy a round at the summit if I am correct ;) | 03:11 |
Alex_Gaynor | I'll buy anyone who wants anything they want if this solves it :-) | 03:11 |
clarkb | SUCCESS! | 03:11 |
clarkb | and by success I mean the job failed but it did so properly | 03:11 |
Alex_Gaynor | clarkb: FWIW a casual grep shows that "setup.py testr" is used allover | 03:11 |
clarkb | Alex_Gaynor: I will rebase it now and see if things are good | 03:12 |
clarkb | Alex_Gaynor: ya | 03:12 |
*** dkehn_ has joined #openstack-infra | 03:12 | |
clarkb | ok rebased | 03:12 |
clarkb | Alex_Gaynor: long story short mordred made a small mistake in the testr setup.py testr command | 03:13 |
clarkb | never fixed it and updated pbr instead with a test command | 03:13 |
clarkb | hwoever the testr command seems to have stuck around | 03:13 |
Alex_Gaynor | ~~computers~~ :-) | 03:14 |
clarkb | I can propose a ton of changes tomorrow to s/testr/test/ if mordred doesn't beat me to it | 03:14 |
clarkb | https://jenkins04.openstack.org/job/gate-python-swiftclient-python33/51/ | 03:14 |
clarkb | or maybe he did fix it but then upstram never cut a release | 03:14 |
*** dkehn has quit IRC | 03:15 | |
*** dkehnx has quit IRC | 03:15 | |
Alex_Gaynor | clarkb: "2014-05-08 03:16:00.132 | PASSED (id=0)" womp womp :-( | 03:16 |
*** dkehn has joined #openstack-infra | 03:17 | |
clarkb | huh | 03:17 |
clarkb | why did the behavior change after the rebase? | 03:17 |
clarkb | https://jenkins02.openstack.org/job/gate-python-swiftclient-python33/184/console clearly did the right thing | 03:18 |
Alex_Gaynor | clarkb: I think the errors we saw before (import errors inside swiftclient/tests) happen before it gets to whatever makes this fail | 03:18 |
clarkb | oh I see, so this change gets us past that | 03:19 |
clarkb | hrm | 03:19 |
*** maxbit has quit IRC | 03:19 | |
*** otherwiseguy has joined #openstack-infra | 03:19 | |
*** aconrad has joined #openstack-infra | 03:20 | |
*** zns has quit IRC | 03:21 | |
clarkb | https://git.openstack.org/cgit/openstack-dev/pbr/tree/pbr/testr_command.py#n85 is the code running | 03:21 |
*** changbl has quit IRC | 03:21 | |
*** oomichi has joined #openstack-infra | 03:21 | |
*** lcheng_ has joined #openstack-infra | 03:21 | |
*** etoews_ has joined #openstack-infra | 03:22 | |
renlt | clarkb: I have queries about manage stackforge project. yesterday we got our stackforge/powervc-driver created, then we open a bug https://bugs.launchpad.net/openstack-ci/+bug/1316893, to request initial group member, could you please take a look at it if time permits? | 03:22 |
uvirtbot | Launchpad bug 1316893 in openstack-ci "Initial group member request for stackforge/powervc-driver" [Undecided,New] | 03:22 |
renlt | clarkb: and another query is do we need create a launchpad project to trace bugs and blueprints | 03:23 |
*** david-lyle has quit IRC | 03:23 | |
*** etoews has quit IRC | 03:23 | |
*** matsuhashi has quit IRC | 03:24 | |
renlt | clarkb: and if we need to create a launchpad project, I still don't quite understand the relationship between this prject and the 2 teams of project-bugs & project-drivers team mentioned in https://wiki.openstack.org/wiki/Project_Group_Management | 03:27 |
*** etoews_ has quit IRC | 03:27 | |
renlt | clarkb: thanks in advance! | 03:27 |
clarkb | renlt: launchpad projects are all on you | 03:27 |
clarkb | we don't manage them for you | 03:27 |
renlt | clarb: ok | 03:28 |
renlt | clarkb:ok | 03:28 |
clarkb | renlt: bug teams manage bugs, drivers manage blueprints | 03:28 |
openstackgerrit | Clark Boylan proposed a change to stackforge/gertty: Ignore closed changes more. https://review.openstack.org/92747 | 03:29 |
clarkb | jeblair: ^ I think that should do it | 03:29 |
*** james_li has joined #openstack-infra | 03:29 | |
clarkb | renlt: if you look at the bug the email addresses are hidden | 03:30 |
renlt | clarkb: so we need create a project first, and then create 2 teams if we need | 03:31 |
clarkb | typically we just add a single member and they can manage the rest. Is there one person I should add to the core group and the ptl group in gerrit? | 03:31 |
clarkb | renlt: yes | 03:31 |
lifeless | clarkb: so discover is finding no tests | 03:32 |
lifeless | clarkb: and not indicating any error | 03:32 |
renlt | clarkb: I'm sorry? if you look at the bug the email addresses are hidden? | 03:32 |
clarkb | renlt: yes, open the bug all of the email addresses you provided are <email address hidden> | 03:33 |
clarkb | renlt: if you give me a gerrit account here in irc I can go ahead and add that person and they can add the rest | 03:33 |
*** krtaylor has joined #openstack-infra | 03:33 | |
renlt | clarkb: oh..why I can see them | 03:34 |
renlt | clarb: https://github.com/stackforge/powervc-driver | 03:34 |
renlt | gerrit initial group members: | 03:34 |
renlt | powervc-driver-core: mengxd@cn.ibm.com, lincai@cn.ibm.com, yaohaif@cn.ibm.com, jmzhang@cn.ibm.com | 03:34 |
renlt | powervc-driver-milestone: mengxd@cn.ibm.com, lincai@cn.ibm.com, yaohaif@cn.ibm.com, jmzhang@cn.ibm.com | 03:34 |
renlt | powervc-driver-ptl: mengxd@cn.ibm.com | 03:34 |
*** blamar has quit IRC | 03:35 | |
clarkb | renlt: http://git.openstack.org/cgit/openstack-infra/config/tree/modules/openstack_project/files/gerrit/acls/stackforge/powervc-driver.config there is no milestone group | 03:35 |
clarkb | renlt: if I add megxd to -core and -ptl they can add the remaining members | 03:36 |
clarkb | done | 03:36 |
renlt | clarkb: thanks, then we can do the remain management work by ourselves. | 03:37 |
clarkb | ooohhhh I had to log in now I can see the email addresses | 03:37 |
renlt | clarkb: oh..that must be some launchpad acl.. | 03:39 |
renlt | clarkb: thanks again | 03:39 |
*** nosnos has quit IRC | 03:41 | |
*** lcheng_ has quit IRC | 03:45 | |
*** gokrokve has joined #openstack-infra | 03:45 | |
*** lcheng_ has joined #openstack-infra | 03:46 | |
*** gokrokve has quit IRC | 03:50 | |
*** arnaud has joined #openstack-infra | 03:50 | |
*** unicell1 has joined #openstack-infra | 03:53 | |
*** unicell has quit IRC | 03:54 | |
*** eharney has quit IRC | 03:56 | |
*** unicell1 has quit IRC | 03:58 | |
*** unicell has joined #openstack-infra | 03:58 | |
*** etoews has joined #openstack-infra | 04:00 | |
*** otherwiseguy has quit IRC | 04:01 | |
*** UtahDave has joined #openstack-infra | 04:04 | |
*** etoews has quit IRC | 04:04 | |
openstackgerrit | Clark Boylan proposed a change to stackforge/gertty: Ignore closed changes more. https://review.openstack.org/92747 | 04:06 |
clarkb | jeblair: ^ is tested to actually do stuff | 04:06 |
clarkb | and seems to work | 04:06 |
*** esker has quit IRC | 04:07 | |
clarkb | I couldn't figure out how to make the sqlalchemy relationship use the list of statuses | 04:07 |
*** ArxCruz has quit IRC | 04:08 | |
*** blamar has joined #openstack-infra | 04:08 | |
*** msabramo has quit IRC | 04:12 | |
*** msabramo has joined #openstack-infra | 04:13 | |
openstackgerrit | Clark Boylan proposed a change to stackforge/gertty: Delete closed changes from local DB https://review.openstack.org/92767 | 04:13 |
*** blamar has quit IRC | 04:16 | |
*** blamar has joined #openstack-infra | 04:16 | |
jgriffith | mordred: hey-yo... is there an example of what I need for abandon/unbandon on that patch? | 04:20 |
jgriffith | mordred: suppose I could check what's in the queue | 04:20 |
clarkb | jgriffith: we just merged a ton of edits | 04:20 |
clarkb | jgriffith: just open an acl file from another project on tip of master | 04:21 |
clarkb | jgriffith: or if you give me a link to your change I can commetn on it | 04:21 |
jgriffith | clarkb: I did , but maybe my pull from master was no bueno | 04:21 |
jgriffith | I didn't see it | 04:21 |
jgriffith | clarkb: https://review.openstack.org/#/c/91723/ | 04:22 |
*** yfried has quit IRC | 04:23 | |
*** MarkAtwood has joined #openstack-infra | 04:23 | |
clarkb | jgriffith: done | 04:23 |
jgriffith | clarkb: thank you sir | 04:23 |
*** mestery has joined #openstack-infra | 04:24 | |
jgriffith | clarkb: perfect | 04:24 |
clarkb | np | 04:25 |
openstackgerrit | John Griffith proposed a change to openstack-infra/config: Create cinder-specs git repo https://review.openstack.org/91723 | 04:26 |
*** aconrad has quit IRC | 04:26 | |
clarkb | jgriffith: ETABS | 04:27 |
clarkb | jgriffith: iirc gerrit actually complains about that | 04:27 |
*** che-arne has quit IRC | 04:27 | |
*** che-arne has joined #openstack-infra | 04:27 | |
jgriffith | geesh | 04:27 |
*** mengxd has quit IRC | 04:28 | |
clarkb | it does weird stuff with whitespace in its ini conf files | 04:28 |
openstackgerrit | John Griffith proposed a change to openstack-infra/config: Create cinder-specs git repo https://review.openstack.org/91723 | 04:28 |
jgriffith | clarkb: :) | 04:28 |
jgriffith | clarkb: I need to set my vimrc for yaml and .config | 04:28 |
jgriffith | I've slipped on that one far too many times | 04:29 |
*** nosnos has joined #openstack-infra | 04:29 | |
clarkb | I do so much python I just default to no tabs and set noexpandtab if necessary | 04:29 |
jgriffith | clarkb: indeed...I set that by file type, I should just make it global | 04:30 |
jgriffith | our C++ standard sadly enough is tabs :( | 04:31 |
*** wenlock has joined #openstack-infra | 04:32 | |
*** arnaud has quit IRC | 04:33 | |
*** gondoi is now known as zz_gondoi | 04:34 | |
*** wenlock has quit IRC | 04:34 | |
*** wenlock has joined #openstack-infra | 04:35 | |
*** matsuhashi has joined #openstack-infra | 04:37 | |
*** rcarrill` has quit IRC | 04:38 | |
*** lcheng_ has quit IRC | 04:39 | |
*** rcarrillocruz has joined #openstack-infra | 04:44 | |
*** gokrokve has joined #openstack-infra | 04:44 | |
*** zhiyan is now known as zhiyan_ | 04:46 | |
*** gokrokve has quit IRC | 04:49 | |
*** Longgeek has joined #openstack-infra | 04:55 | |
*** lcheng_ has joined #openstack-infra | 04:56 | |
*** MarkAtwood has quit IRC | 05:02 | |
*** FallenPegasus has joined #openstack-infra | 05:02 | |
*** FallenPegasus has quit IRC | 05:02 | |
*** salv-orlando has quit IRC | 05:18 | |
*** amotoki has joined #openstack-infra | 05:19 | |
*** matsuhashi has quit IRC | 05:19 | |
*** matsuhashi has joined #openstack-infra | 05:20 | |
*** UtahDave has quit IRC | 05:23 | |
openstackgerrit | Khai Do proposed a change to openstack-infra/config: add a build-timeout macro https://review.openstack.org/84637 | 05:31 |
*** lcheng_ has quit IRC | 05:32 | |
*** etoews has joined #openstack-infra | 05:32 | |
openstackgerrit | Khai Do proposed a change to openstack-infra/config: add a build-timeout macro https://review.openstack.org/84637 | 05:35 |
*** chandan_kumar has joined #openstack-infra | 05:37 | |
*** james_li has quit IRC | 05:38 | |
*** marcoemorais has joined #openstack-infra | 05:38 | |
openstackgerrit | Andreas Jaeger proposed a change to openstack-infra/config: Add database-api publishing jobs to trove https://review.openstack.org/88050 | 05:38 |
*** etoews has quit IRC | 05:39 | |
*** krotscheck has quit IRC | 05:40 | |
*** marcoemorais1 has joined #openstack-infra | 05:41 | |
openstackgerrit | Khai Do proposed a change to openstack-infra/config: update the jjb timeout global defaults https://review.openstack.org/92773 | 05:41 |
*** marcoemorais has quit IRC | 05:42 | |
openstackgerrit | Andreas Jaeger proposed a change to openstack-infra/config: Add database-api publishing jobs to trove https://review.openstack.org/88050 | 05:42 |
openstackgerrit | Nikhil Manchanda proposed a change to openstack-infra/config: Add new gate-trove-buildimage-mysql job https://review.openstack.org/92755 | 05:44 |
*** gokrokve has joined #openstack-infra | 05:44 | |
*** Alexandra_ has quit IRC | 05:45 | |
*** krotscheck has joined #openstack-infra | 05:45 | |
*** gokrokve_ has joined #openstack-infra | 05:46 | |
*** gokrokve has quit IRC | 05:49 | |
*** gokrokve_ has quit IRC | 05:50 | |
zaro | clarkb: check out my comment on 88432 | 05:55 |
*** wenlock has quit IRC | 05:55 | |
clarkb | zaro: so I am really confused | 05:55 |
clarkb | zaro: we explicitly stopped logging at debug level on those loggers | 05:55 |
clarkb | which is why that file says WARNING today | 05:56 |
*** rcarrill` has joined #openstack-infra | 05:56 | |
clarkb | we updated gearman plugin to log less verbosely and now we are going to go more verbose on our installs? | 05:56 |
*** yfried has joined #openstack-infra | 05:56 | |
clarkb | I get logging the plugin more verbosely because it reduced its default verbosity | 05:56 |
clarkb | but I don't think we want the gearman lib to be more verbose | 05:56 |
*** rcarrillocruz has quit IRC | 05:57 | |
*** dstanek_zzz is now known as dstanek | 05:59 | |
*** zhiyan_ is now known as zhiyan | 05:59 | |
*** oomichi_ has joined #openstack-infra | 06:00 | |
*** oomichi has quit IRC | 06:02 | |
*** zhiyan is now known as zhiyan_ | 06:05 | |
*** morganfainberg is now known as morganfainberg_Z | 06:05 | |
openstackgerrit | Maria Nita proposed a change to openstack/requirements: Add xvfbwrapper package for running Selenium tests headless https://review.openstack.org/80393 | 06:06 |
*** gyee has quit IRC | 06:06 | |
*** zhiyan_ is now known as zhiyan | 06:08 | |
*** zhiyan has left #openstack-infra | 06:08 | |
*** signed8bit is now known as signed8bit_ZZZzz | 06:08 | |
*** harlowja is now known as harlowja_away | 06:08 | |
*** zhiyan has joined #openstack-infra | 06:09 | |
*** lcheng_ has joined #openstack-infra | 06:10 | |
openstackgerrit | Ian Wienand proposed a change to openstack-infra/config: Ensure jenkins user has useful secure_path https://review.openstack.org/92777 | 06:11 |
*** zhiyan is now known as zhiyan_ | 06:12 | |
*** zhiyan_ is now known as zhiyan | 06:12 | |
*** WaltNik has joined #openstack-infra | 06:15 | |
*** wenlock has joined #openstack-infra | 06:16 | |
*** lcheng_ has quit IRC | 06:17 | |
*** ildikov has quit IRC | 06:29 | |
*** zhiyan is now known as zhiyan_ | 06:30 | |
*** zhiyan_ is now known as zhiyan | 06:34 | |
*** zhiyan is now known as zhiyan_ | 06:37 | |
*** gokrokve has joined #openstack-infra | 06:44 | |
*** salv-orlando has joined #openstack-infra | 06:47 | |
*** gokrokve has quit IRC | 06:49 | |
nibalizer | krotscheck: working with your module now | 06:52 |
*** praneshp has quit IRC | 06:58 | |
*** etoews has joined #openstack-infra | 07:00 | |
*** ramashri has quit IRC | 07:00 | |
*** praneshp has joined #openstack-infra | 07:01 | |
*** mrmartin has joined #openstack-infra | 07:02 | |
*** praneshp has quit IRC | 07:02 | |
*** etoews has quit IRC | 07:05 | |
*** amcrn has quit IRC | 07:06 | |
*** sandywalsh has quit IRC | 07:06 | |
*** _nadya_ has joined #openstack-infra | 07:06 | |
*** sandywalsh has joined #openstack-infra | 07:07 | |
*** flaper87|afk is now known as flaper87 | 07:08 | |
*** ildikov has joined #openstack-infra | 07:08 | |
*** Ryan_Lane has quit IRC | 07:10 | |
*** SumitNaiksatam_ has joined #openstack-infra | 07:11 | |
*** SumitNaiksatam has quit IRC | 07:13 | |
*** SumitNaiksatam_ has quit IRC | 07:17 | |
*** dizquierdo has joined #openstack-infra | 07:21 | |
*** _nadya_ has quit IRC | 07:25 | |
*** _nadya_ has joined #openstack-infra | 07:29 | |
mattoliverau | I'm stopping for the day, night all | 07:30 |
*** ominakov has joined #openstack-infra | 07:37 | |
*** gokrokve has joined #openstack-infra | 07:44 | |
*** gokrokve has quit IRC | 07:49 | |
*** matsuhashi has quit IRC | 07:54 | |
*** dstanek is now known as dstanek_zzz | 07:55 | |
*** e0ne has joined #openstack-infra | 07:55 | |
*** matsuhashi has joined #openstack-infra | 07:55 | |
*** ildikov has quit IRC | 07:57 | |
*** ildikov has joined #openstack-infra | 07:57 | |
*** wenlock has quit IRC | 07:58 | |
*** geertj has joined #openstack-infra | 07:58 | |
*** jpich has joined #openstack-infra | 08:00 | |
*** mrmartin has quit IRC | 08:03 | |
*** etoews has joined #openstack-infra | 08:03 | |
*** andreaf has joined #openstack-infra | 08:07 | |
*** etoews has quit IRC | 08:08 | |
openstackgerrit | Maria Nita proposed a change to openstack/requirements: Add xvfbwrapper package for running Selenium tests headless https://review.openstack.org/80393 | 08:09 |
*** lcheng_ has joined #openstack-infra | 08:10 | |
*** derekh_ has joined #openstack-infra | 08:11 | |
*** lcheng_ has quit IRC | 08:12 | |
*** renlt has quit IRC | 08:22 | |
*** dkehn__ has joined #openstack-infra | 08:22 | |
*** jcoufal has joined #openstack-infra | 08:24 | |
*** dkehn__ has quit IRC | 08:24 | |
*** dkehn_ has quit IRC | 08:25 | |
*** dkehn has quit IRC | 08:25 | |
*** dkehn__ has joined #openstack-infra | 08:25 | |
*** dkehn has joined #openstack-infra | 08:27 | |
*** jcoufal has quit IRC | 08:27 | |
*** salv-orlando_ has joined #openstack-infra | 08:27 | |
*** darraghb has joined #openstack-infra | 08:27 | |
*** salv-orlando has quit IRC | 08:29 | |
*** salv-orlando_ is now known as salv-orlando | 08:29 | |
*** dkehn_ has joined #openstack-infra | 08:38 | |
*** jcoufal has joined #openstack-infra | 08:40 | |
*** dkehn_ has quit IRC | 08:40 | |
*** dkehn has quit IRC | 08:40 | |
*** dkehn__ has quit IRC | 08:41 | |
*** dkehn_ has joined #openstack-infra | 08:41 | |
*** ociuhandu has quit IRC | 08:42 | |
*** dkehn has joined #openstack-infra | 08:42 | |
*** gokrokve has joined #openstack-infra | 08:44 | |
*** jcoufal has quit IRC | 08:45 | |
*** jcoufal has joined #openstack-infra | 08:45 | |
*** markmc has joined #openstack-infra | 08:48 | |
*** gokrokve has quit IRC | 08:49 | |
*** salv-orlando has quit IRC | 08:56 | |
*** andreykurilin_ has joined #openstack-infra | 08:57 | |
*** e0ne has quit IRC | 09:03 | |
*** katyafervent is now known as katyafervent_awa | 09:03 | |
*** e0ne has joined #openstack-infra | 09:04 | |
*** katyafervent_awa is now known as katyafervent | 09:05 | |
*** rlandy has joined #openstack-infra | 09:08 | |
*** jcoufal has quit IRC | 09:09 | |
*** jcoufal has joined #openstack-infra | 09:09 | |
*** rcarrillocruz has joined #openstack-infra | 09:09 | |
*** hashar has joined #openstack-infra | 09:10 | |
*** rcarrill` has quit IRC | 09:11 | |
*** skolekonov has joined #openstack-infra | 09:11 | |
*** _nadya_ has quit IRC | 09:15 | |
*** hashar has quit IRC | 09:20 | |
*** dangers is now known as dangers_away | 09:28 | |
*** jasondotstar has joined #openstack-infra | 09:28 | |
*** marun is now known as marun_afk | 09:35 | |
*** danpb has joined #openstack-infra | 09:39 | |
danpb | can anyone here see by Jenkins has gone insane on this https://review.openstack.org/#/c/89650/ | 09:40 |
danpb | it is starting the test jobs over & over every minute, without any re-check request that I see | 09:40 |
*** dkehn__ has joined #openstack-infra | 09:42 | |
*** gokrokve has joined #openstack-infra | 09:44 | |
*** dkehn_ has quit IRC | 09:45 | |
*** jasondotstar has quit IRC | 09:46 | |
*** marcoemorais1 has quit IRC | 09:46 | |
*** ociuhandu has joined #openstack-infra | 09:49 | |
*** gokrokve has quit IRC | 09:49 | |
*** jasondotstar has joined #openstack-infra | 09:49 | |
*** Alexei_987 has joined #openstack-infra | 09:50 | |
*** e0ne has quit IRC | 09:59 | |
*** e0ne has joined #openstack-infra | 10:05 | |
*** etoews has joined #openstack-infra | 10:07 | |
*** e0ne has quit IRC | 10:08 | |
*** e0ne has joined #openstack-infra | 10:08 | |
*** e0ne has quit IRC | 10:12 | |
*** etoews has quit IRC | 10:13 | |
*** Alexandra_ has joined #openstack-infra | 10:15 | |
*** _nadya_ has joined #openstack-infra | 10:23 | |
*** matsuhashi has quit IRC | 10:27 | |
*** Alexandra_ has quit IRC | 10:28 | |
*** oomichi_ has quit IRC | 10:29 | |
*** matsuhashi has joined #openstack-infra | 10:40 | |
*** jasondotstar has quit IRC | 10:41 | |
*** maxbit has joined #openstack-infra | 10:43 | |
*** e0ne has joined #openstack-infra | 10:43 | |
*** gokrokve has joined #openstack-infra | 10:44 | |
*** e0ne has quit IRC | 10:44 | |
*** e0ne has joined #openstack-infra | 10:45 | |
*** e0ne_ has joined #openstack-infra | 10:47 | |
*** e0ne has quit IRC | 10:47 | |
*** _nadya_ has quit IRC | 10:48 | |
*** KurtMartin has joined #openstack-infra | 10:48 | |
*** _nadya_ has joined #openstack-infra | 10:48 | |
*** miqui_ has joined #openstack-infra | 10:49 | |
*** gokrokve has quit IRC | 10:49 | |
*** thingee_ has joined #openstack-infra | 10:50 | |
*** YorikSar_ has joined #openstack-infra | 10:51 | |
*** e0ne_ has quit IRC | 10:51 | |
*** maurosr- has joined #openstack-infra | 10:54 | |
*** geertj has quit IRC | 10:54 | |
*** dkliban1 has joined #openstack-infra | 10:55 | |
*** spy1 has joined #openstack-infra | 10:55 | |
*** thingee has quit IRC | 10:55 | |
*** Clabbe has quit IRC | 10:55 | |
*** maurosr has quit IRC | 10:55 | |
*** antonym has quit IRC | 10:55 | |
*** dkliban has quit IRC | 10:55 | |
*** kmartin has quit IRC | 10:55 | |
*** miqui has quit IRC | 10:55 | |
*** YorikSar has quit IRC | 10:55 | |
*** maurosr- is now known as maurosr | 10:55 | |
*** Clabbe has joined #openstack-infra | 10:55 | |
*** ildikov is now known as ildikov_fan_repa | 10:57 | |
*** ildikov_fan_repa has quit IRC | 10:57 | |
openstackgerrit | Derek Higgins proposed a change to openstack-infra/config: Scale back on tripleo testing https://review.openstack.org/92808 | 10:58 |
*** danpb has left #openstack-infra | 10:59 | |
*** _nadya_ has quit IRC | 11:00 | |
*** davidlenwell_ has joined #openstack-infra | 11:02 | |
*** YorikSar has joined #openstack-infra | 11:04 | |
*** dizquierdo is now known as dizquierdo_afk | 11:05 | |
*** che-arne has quit IRC | 11:06 | |
*** maxbit has quit IRC | 11:08 | |
*** dims has joined #openstack-infra | 11:12 | |
*** rcarrill` has joined #openstack-infra | 11:15 | |
anteaya | danpb the comment on patchset 3 seems to have set it off | 11:17 |
*** rcarrillocruz has quit IRC | 11:17 | |
anteaya | it seems to have stopped 21/2 hours ago | 11:17 |
sdague | anteaya: I was assume the positive results are actually what stopped it | 11:20 |
*** mbacchi has joined #openstack-infra | 11:21 | |
sdague | I think there is some logic challenges with clean check and the gerrit | 11:21 |
anteaya | I agree | 11:21 |
anteaya | and yes, I assume the same about the positive results being the cause the exited the loop | 11:22 |
anteaya | I look forward to fungi's assessment of the logs | 11:22 |
*** matsuhas_ has joined #openstack-infra | 11:22 | |
*** YorikSar_ has quit IRC | 11:23 | |
*** matsuhashi has quit IRC | 11:23 | |
*** Alexei_987 has quit IRC | 11:23 | |
*** ociuhandu has quit IRC | 11:23 | |
*** davidlenwell has quit IRC | 11:23 | |
*** isviridov has quit IRC | 11:23 | |
*** jamielennox is now known as jamielennox|away | 11:26 | |
*** che-arne has joined #openstack-infra | 11:29 | |
skolekonov | hello. could you please take a look on this patch https://review.openstack.org/#/c/92513/ ? | 11:36 |
anteaya | skolekonov: what are you seeing? | 11:38 |
anteaya | oh you are looking for reviews | 11:39 |
*** Alexei_987 has joined #openstack-infra | 11:41 | |
skolekonov | yes, if it's possible :) I've made a mistake in my previous patch when I didn't enable Tempest | 11:41 |
*** e0ne has joined #openstack-infra | 11:42 | |
*** gokrokve has joined #openstack-infra | 11:44 | |
*** e0ne_ has joined #openstack-infra | 11:44 | |
*** e0ne has quit IRC | 11:44 | |
anteaya | skolekonov: +1 | 11:46 |
*** ArxCruz has joined #openstack-infra | 11:47 | |
*** isviridov has joined #openstack-infra | 11:48 | |
*** ociuhandu has joined #openstack-infra | 11:48 | |
*** e0ne_ has quit IRC | 11:49 | |
*** gokrokve has quit IRC | 11:49 | |
skolekonov | anteaya, thank you | 11:52 |
anteaya | np | 11:55 |
*** weshay has joined #openstack-infra | 12:02 | |
*** pdmars has joined #openstack-infra | 12:03 | |
*** tteggel has quit IRC | 12:04 | |
*** cyeoh has quit IRC | 12:04 | |
*** mkoderer has quit IRC | 12:04 | |
*** exz has quit IRC | 12:04 | |
*** mancdaz has quit IRC | 12:04 | |
*** johnthetubaguy has quit IRC | 12:04 | |
*** blamar has quit IRC | 12:04 | |
*** blamar has joined #openstack-infra | 12:04 | |
*** e0ne has joined #openstack-infra | 12:07 | |
*** e0ne has joined #openstack-infra | 12:07 | |
*** yaguang has quit IRC | 12:08 | |
*** blamar has quit IRC | 12:09 | |
*** blamar has joined #openstack-infra | 12:09 | |
*** che-arne has quit IRC | 12:09 | |
*** e0ne has quit IRC | 12:09 | |
*** etoews has joined #openstack-infra | 12:10 | |
*** etoews has quit IRC | 12:17 | |
*** tteggel has joined #openstack-infra | 12:18 | |
*** cyeoh has joined #openstack-infra | 12:18 | |
*** mkoderer has joined #openstack-infra | 12:18 | |
*** exz has joined #openstack-infra | 12:18 | |
*** mancdaz has joined #openstack-infra | 12:18 | |
*** johnthetubaguy has joined #openstack-infra | 12:18 | |
*** adalbas has joined #openstack-infra | 12:19 | |
*** geertj has joined #openstack-infra | 12:32 | |
*** julim has joined #openstack-infra | 12:33 | |
*** sandywalsh has quit IRC | 12:35 | |
phschwartz | Morning infra | 12:35 |
*** sandywalsh has joined #openstack-infra | 12:36 | |
*** etoews has joined #openstack-infra | 12:38 | |
anteaya | morning phschwartz | 12:39 |
*** aysyd has joined #openstack-infra | 12:41 | |
*** gokrokve has joined #openstack-infra | 12:44 | |
*** rfolco has joined #openstack-infra | 12:47 | |
*** bknudson has quit IRC | 12:48 | |
*** gokrokve has quit IRC | 12:49 | |
*** signed8bit_ZZZzz is now known as signed8bit | 12:50 | |
*** zehicle_at_dell has quit IRC | 12:51 | |
openstackgerrit | João Vale proposed a change to openstack-infra/jenkins-job-builder: Support variable-specific substitutions in templates. https://review.openstack.org/85383 | 12:51 |
*** smarcet has joined #openstack-infra | 12:51 | |
*** dkranz has joined #openstack-infra | 12:52 | |
*** geertj has quit IRC | 12:59 | |
*** dprince has joined #openstack-infra | 13:00 | |
*** jcoufal has quit IRC | 13:00 | |
fungi | i'll take a look | 13:00 |
*** e0ne has joined #openstack-infra | 13:04 | |
*** zehicle_at_dell has joined #openstack-infra | 13:05 | |
*** geertj has joined #openstack-infra | 13:05 | |
*** e0ne has quit IRC | 13:05 | |
*** andreykurilin_ has quit IRC | 13:05 | |
*** e0ne has joined #openstack-infra | 13:06 | |
*** fifieldt has quit IRC | 13:06 | |
openstackgerrit | A change was merged to openstack-infra/config: Fix zero tests ran unittest check. https://review.openstack.org/92759 | 13:08 |
*** bknudson has joined #openstack-infra | 13:09 | |
*** e0ne has quit IRC | 13:10 | |
*** azneita has joined #openstack-infra | 13:11 | |
*** david-lyle has joined #openstack-infra | 13:11 | |
fungi | danpb seems to have vaporied | 13:12 |
fungi | vaporized | 13:12 |
openstackgerrit | Arx Cruz proposed a change to openstack-infra/devstack-gate: Add qpid config https://review.openstack.org/92820 | 13:12 |
*** dkranz has quit IRC | 13:12 | |
*** dkranz has joined #openstack-infra | 13:13 | |
fungi | looks like jenkins was looping trying to report on patchset #3, which was closed | 13:14 |
fungi | the current patchset was #6 | 13:14 |
fungi | s/jenkins/zuul/ really | 13:14 |
anteaya | yeah | 13:15 |
anteaya | why would it pick patchset #3 to chew on? | 13:15 |
anteaya | because that was the one with the comment | 13:15 |
fungi | oho, because the comment which set it off was on patchset #3 | 13:15 |
anteaya | but patchset 6 was the latest | 13:16 |
fungi | i think we have a logic issue with the patchset matching | 13:16 |
*** skolekonov has quit IRC | 13:16 | |
anteaya | looks like it | 13:16 |
fungi | yes, latest patchset was #6 but you can still leave comments on older patchsets | 13:16 |
fungi | zuul then tried to retest *that* patchset and vote on it, which gerrit won't let you do | 13:16 |
fungi | but it still left a comment, saw its comment and no recent vote... loop | 13:16 |
anteaya | why did zuul behave as expected with gerrit 2.4? | 13:17 |
fungi | so another flavor of what we were fixing with the "don't test closed changes in some pipelines" fix | 13:17 |
anteaya | ah | 13:17 |
fungi | to accommodate a difference in the behavior of 2.8 we made it so that zuul would leave a comment even if gerrit refused to accept a vote with it | 13:18 |
*** changbl has joined #openstack-infra | 13:18 | |
anteaya | oh yes now I remember | 13:18 |
*** mriedem has joined #openstack-infra | 13:19 | |
*** james_li has joined #openstack-infra | 13:21 | |
openstackgerrit | João Vale proposed a change to openstack-infra/jenkins-job-builder: Support variable-specific substitutions in templates. https://review.openstack.org/85383 | 13:21 |
*** mflobo has joined #openstack-infra | 13:22 | |
*** zehicle_at_dell has quit IRC | 13:23 | |
*** chandan_kumar has quit IRC | 13:28 | |
*** james_li has quit IRC | 13:28 | |
anteaya | if I star a gerrit patchset, does a new patchset remove the star? | 13:28 |
BobBall_Away | no anteaya - at least it didn't used to :) | 13:29 |
*** dstanek_zzz is now known as dstanek | 13:29 | |
BobBall_Away | I had a starred changeset for several patches before I'm sure | 13:29 |
*** mwagner_ has quit IRC | 13:29 | |
anteaya | BobBall_Away: okay thanks, not asking because I noticed a change in behaviour, asking to learn what the behaviour is | 13:29 |
anteaya | I've never known | 13:30 |
BobBall_Away | I was just qualifying because I don't know for sure the new behaviour is the same as the old :) | 13:30 |
* anteaya nods | 13:30 | |
BobBall_Away | Looks like it should be because the star is associated with the change rather than patchset (i.e. where you select the star and how it appears in your list) | 13:30 |
anteaya | taking advantage of the lull to improve my gerrit search foo | 13:31 |
anteaya | kk | 13:31 |
anteaya | I'm looking to see if there is anything that toggles triggered on a new patchset | 13:31 |
*** azneita has quit IRC | 13:31 | |
anteaya | as in, have _I_ reviewed this patchset already? | 13:32 |
*** lcostantino has joined #openstack-infra | 13:33 | |
anteaya | reviewer:self appears to be any changeset I have reviewed or subscribed to | 13:33 |
openstackgerrit | A change was merged to openstack-infra/config: Enable Tempest in Mistral devstack job https://review.openstack.org/92513 | 13:34 |
*** james_li has joined #openstack-infra | 13:34 | |
*** zns has joined #openstack-infra | 13:34 | |
*** david-lyle has quit IRC | 13:34 | |
*** dkehn__ is now known as dkehnx | 13:35 | |
anteaya | if is:reviewed had a self option, that would fit what I am looking for | 13:35 |
anteaya | is:reviewed:self | 13:36 |
*** lcostantino has quit IRC | 13:36 | |
*** maxbit has joined #openstack-infra | 13:36 | |
anteaya | alas I do not see it | 13:36 |
*** mriedem has quit IRC | 13:37 | |
*** dizquierdo_afk is now known as dizquierdo | 13:37 | |
*** nosnos has quit IRC | 13:38 | |
*** bknudson has quit IRC | 13:41 | |
anteaya | oh, this looks nice and cumbersome: reviewer:self label:Code-Review=-1,user=anteaya | 13:42 |
*** changbl has quit IRC | 13:42 | |
*** changbl has joined #openstack-infra | 13:43 | |
fungi | yeah, i think i used to query on changes where i had no vote or a vote of exactly 0 (which would catch new patchsets to changes on which i was still a reviewer) | 13:43 |
anteaya | so this gets me changesets I have reviewed in the past, with a current patchset I have not yet reviewed => reviewer:self label:Code-Review=0,user=anteaya | 13:44 |
anteaya | yup, just found that | 13:44 |
*** gokrokve has joined #openstack-infra | 13:44 | |
BobBall_Away | That would be a useful link to add to everyone's board if that was easy... | 13:44 |
anteaya | we can create dashboards | 13:44 |
fungi | BobBall_Away: i believe the custom dashboards are already in progress | 13:44 |
anteaya | fungi: is there a dashboard with that as an option? | 13:45 |
fungi | https://etherpad.openstack.org/p/gerrit-dashboards | 13:45 |
fungi | i think right now we only have the important-changes dashboard live | 13:46 |
*** chandan_kumar has joined #openstack-infra | 13:46 | |
fungi | https://review.openstack.org/#/projects/All-Projects,dashboards/important-changes:important-changes-dashboard | 13:46 |
*** doug-fish has joined #openstack-infra | 13:46 | |
openstackgerrit | A change was merged to openstack-infra/storyboard: Tasks can now be filtered by assignee https://review.openstack.org/91840 | 13:48 |
*** gokrokve has quit IRC | 13:48 | |
*** zul has joined #openstack-infra | 13:49 | |
anteaya | see this query label:Code-Review>=0,self returns patches I have already +1'd | 13:49 |
* clarkb really isnt awake yet but question over in -dev | 13:49 | |
anteaya | this query label:Code-Review=0,self returns patches I have not reviewed the latest patchset | 13:50 |
* anteaya goes to -dev | 13:50 | |
*** yamahata has quit IRC | 13:50 | |
*** james_li has quit IRC | 13:51 | |
*** yamahata has joined #openstack-infra | 13:51 | |
anteaya | the second query is what is useful for me | 13:51 |
openstackgerrit | A change was merged to stackforge/gertty: Add '?' as another way show help dialog https://review.openstack.org/92742 | 13:51 |
*** markwash has joined #openstack-infra | 13:52 | |
*** miqui_ is now known as miqui | 13:53 | |
*** weshay has quit IRC | 13:53 | |
*** changbl has quit IRC | 13:54 | |
*** maxbit has quit IRC | 13:54 | |
*** bknudson has joined #openstack-infra | 13:54 | |
*** maxbit has joined #openstack-infra | 13:55 | |
*** weshay has joined #openstack-infra | 13:55 | |
sdague | anteaya: I think you want | 13:55 |
openstackgerrit | A change was merged to openstack-infra/storyboard: Introducing the event timeline https://review.openstack.org/87959 | 13:55 |
sdague | NOT label:Code-Review>=0,self | 13:55 |
*** zhiyan_ is now known as zhiyan | 13:56 | |
Alex_Gaynor | clarkb: Should the 0 tests == failure thing be live at this point? | 13:56 |
anteaya | sdague: I will try that | 13:56 |
sdague | that will also filter out comments you've provided without a vote | 13:56 |
clarkb | Alex_Gaynor: no, my change is still in review to fix it I think | 13:57 |
sdague | in current patcheset | 13:57 |
anteaya | fungi: can you look at the gerrit db for account 8932, there is a key permissions error for that user | 13:57 |
clarkb | Alex_Gaynor: after that we need to build new images | 13:57 |
fungi | anteaya: yeah, was just catching up in -dev... checking into it | 13:57 |
Alex_Gaynor | clarkb: for some reason I thoguht it had landed, what I get for reviewing email first thing in the morning I guess | 13:57 |
anteaya | fungi: thanks | 13:57 |
*** salv-orlando has joined #openstack-infra | 13:57 | |
*** arnaud has joined #openstack-infra | 13:59 | |
clarkb | Alex_Gaynor: oh maybe it merged over night | 13:59 |
*** thomasem has joined #openstack-infra | 14:00 | |
Alex_Gaynor | clarkb: but it still needs the new image to take affect -- I wanted to make sure the fact that I hadn't seen the effects was normal | 14:00 |
*** james_li has joined #openstack-infra | 14:00 | |
*** otherwiseguy has joined #openstack-infra | 14:00 | |
clarkb | yup new images needed. I can try and kick those off when I am actually awake | 14:00 |
clarkb | though nodepool builds them right about now iirc | 14:00 |
anteaya | sdague: NOT label:Code-Review>=0,self gives me a patch I have -1'd | 14:01 |
jeblair | clarkb: i left some comments on your gertty changes | 14:01 |
fungi | clarkb: it merged a few minutes ago, so whatever nodepool images fail to update will need manual intervention | 14:01 |
*** lcostantino has joined #openstack-infra | 14:01 | |
Alex_Gaynor | No worries, that's a much lower priority for me then figuring out why no tests run. | 14:01 |
anteaya | which isn't exactly what I am looking for | 14:01 |
*** gokrokve has joined #openstack-infra | 14:01 | |
*** prad_ has joined #openstack-infra | 14:01 | |
openstackgerrit | Nikita Konovalov proposed a change to openstack-infra/storyboard-webclient: TimeLine events support https://review.openstack.org/88405 | 14:02 |
jeblair | clarkb: i think we want to sync closed changes that we have in the db; i was wondering if maybe you didn't notice that in all cases we only try to sync changes that have been updated since the last sync though | 14:02 |
*** zz_gondoi is now known as gondoi | 14:02 | |
*** terryw has joined #openstack-infra | 14:03 | |
jeblair | clarkb: that should keep the traffic down. of course, it might not be working quite right. | 14:03 |
*** otherwiseguy has quit IRC | 14:03 | |
anteaya | so far, is:watched status:open verified=1 reviewer:self label:Code-Review=0,self is giving me what I am looking for | 14:03 |
anteaya | changes I have already reviewed, on watched repos, which have a new patchest I need to review | 14:04 |
clarkb | jeblair: responded | 14:04 |
clarkb | I agree with the -1 but think we still want a bit more checking in that loop | 14:05 |
*** blamar has quit IRC | 14:05 | |
jeblair | clarkb: if what you describe is true then there is a bug and we should find that | 14:05 |
sdague | anteaya: sure >=-2 then :) | 14:05 |
jeblair | clarkb: because it's _only_ supposed to sync changes that have been updated | 14:05 |
jeblair | clarkb: that's not an always-increasing number | 14:06 |
jeblair | clarkb: it should tend toward 0 | 14:06 |
clarkb | ok, next time I run it I will have it log debug messages | 14:06 |
*** Hal_ has joined #openstack-infra | 14:06 | |
*** julim has quit IRC | 14:06 | |
clarkb | and I can update my change to address your comment until I have hard data on what is happening | 14:06 |
*** changbl has joined #openstack-infra | 14:06 | |
*** azneita has joined #openstack-infra | 14:07 | |
jeblair | clarkb: ok, thx. similarly, i don't think we should automatically delete changes from the local db immediately -- if we ever delete them, it should probably be something like changes that are closed and haven't been updated in 1 month or something. but i don't want to do that for a while yet. | 14:07 |
openstackgerrit | Verónica Musso proposed a change to openstack/requirements: Add django-angular as requirement https://review.openstack.org/92690 | 14:07 |
clarkb | jeblair: ok | 14:08 |
*** aysyd has quit IRC | 14:08 | |
*** etoews_ has joined #openstack-infra | 14:08 | |
anteaya | sdague: yes, NOT >=-2 yields the same results as =0 | 14:08 |
sdague | anteaya: NOT >=0,self works for me because I also typically hide reviews with negative feedback on them | 14:09 |
*** mriedem has joined #openstack-infra | 14:10 | |
* jeblair decamps | 14:10 | |
anteaya | sdague: negative feedback from any reviewer? | 14:10 |
*** blamar has joined #openstack-infra | 14:10 | |
*** etoews has quit IRC | 14:11 | |
sdague | anteaya: much of the time | 14:11 |
anteaya | cool | 14:11 |
anteaya | at a certain point it is the toothpaste lid on or off type conversation, everyone has a way they like best | 14:12 |
*** e0ne has joined #openstack-infra | 14:12 | |
*** jgrimm has joined #openstack-infra | 14:12 | |
therve | sdague, Hey, got five to talk about https://review.openstack.org/#/c/92592/ ? | 14:14 |
sdague | therve: sure | 14:15 |
therve | sdague, Can you develop on not using devstack and custom gate hook? | 14:15 |
therve | I already use a gate hook, I thought devstack was the way to go when you want db+rabbit+x services | 14:16 |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/publications: Updated projects list to match today https://review.openstack.org/92837 | 14:16 |
*** james_li has quit IRC | 14:16 | |
*** e0ne has quit IRC | 14:17 | |
*** e0ne has joined #openstack-infra | 14:18 | |
fungi | mordred: on 92837 it's worth keeping in mind that openstackclient is i guess not actually official. i've been torn on whether we should keep it marked as such on the slide | 14:18 |
fungi | though it balanced our horizon (which doesn't have a cli) rather well, which is why i had originally arranged them that way ;) | 14:18 |
fungi | s/our/out/ | 14:19 |
sdague | therve: there aren't hard and fast rules here, but the feature matrix was largely about "I want an openstack cloud that supports X", and I really don't think that heat_templates definition fits well into that. | 14:19 |
*** prad__ has joined #openstack-infra | 14:19 | |
therve | sdague, OK I understand. I was just trying to find a way to keep using devstack but make it lighter | 14:20 |
therve | s/devstack/devstack-gate I suppose | 14:20 |
*** e0ne has quit IRC | 14:20 | |
sdague | therve: the overhead of starting those other services isn't that much | 14:20 |
sdague | or are you seeing perf issues for some reason doing it in a general environment | 14:20 |
therve | Not it's really about setup | 14:21 |
therve | It's taking around 13 mins to run a build, I think it would shave about 5 | 14:21 |
*** prad_ has quit IRC | 14:22 | |
sdague | we could propose a change to make the ENABLED_SERVICES not additive but exclusive | 14:22 |
sdague | that would let you do the change at the job level | 14:22 |
therve | Correct | 14:22 |
*** dstanek is now known as dstanek_zzz | 14:23 | |
therve | I don't know if it's used a lot though | 14:23 |
*** aysyd has joined #openstack-infra | 14:23 | |
sdague | it's used some, but I actually think a lot of people think it's exclusive in the way they've set things up | 14:23 |
therve | 8 builders to fix | 14:23 |
openstackgerrit | A change was merged to openstack-infra/storyboard-webclient: TimeLine events support https://review.openstack.org/88405 | 14:23 |
therve | That would be okay for me, I just don't know the jobs using it to tell if it's diruptive or not | 14:25 |
therve | It looks hard to verify beforehand too :) | 14:25 |
openstackgerrit | A change was merged to openstack-infra/nodepool: Create snapshots when min-ready is >= 0 https://review.openstack.org/83975 | 14:26 |
*** kgriffs|afk is now known as kgriffs | 14:26 | |
*** zns has quit IRC | 14:27 | |
sdague | therve: well we probably would want to do ENABLED_SERVICES and ADDITIONAL_SERVICES | 14:27 |
sdague | I agree, that it's unclear what some of those things intend | 14:28 |
*** BobBall_Away is now known as BobBall | 14:28 | |
therve | That's one way too | 14:28 |
therve | So hum | 14:28 |
therve | 1) Add ADDITIONAL_SERVICES which does the same as ENABLED_SERVICES currently | 14:28 |
therve | 2) Change the builds to use that | 14:28 |
therve | 3) Change the semantic of ENABLED_SERVICES | 14:28 |
therve | Does that sound fine? | 14:29 |
*** azneita has quit IRC | 14:29 | |
sdague | yep | 14:29 |
therve | Alright let me try that then | 14:29 |
sdague | the heat templates are only going to syntax check on heat? | 14:30 |
sdague | I guess part of it is not really understanding what the job ends up intending to be over time | 14:30 |
*** vhoward has joined #openstack-infra | 14:31 | |
therve | It's not just syntax check it validates them | 14:31 |
sdague | gotcha. I'm surprised there isn't a way to do that without heat spun up | 14:32 |
openstackgerrit | A change was merged to openstack-infra/storyboard-webclient: Last location improvement https://review.openstack.org/92090 | 14:32 |
*** homeless has joined #openstack-infra | 14:33 | |
therve | Because it uses configuration, resources defined on the server side, etc. | 14:33 |
*** adalbas has quit IRC | 14:33 | |
*** dstanek_zzz is now known as dstanek | 14:33 | |
*** chandan_kumar has quit IRC | 14:34 | |
*** chandan_kumar has joined #openstack-infra | 14:34 | |
fungi | also, part of the argument i heard in favor of it is that this is an integration test, making sure that changes to the heat service don't cause it to stop being able to validate the templates, as well as making sure that changes to templates still validate properly | 14:34 |
therve | fungi, That's correct | 14:35 |
sdague | sure. | 14:35 |
*** terryw has quit IRC | 14:36 | |
*** otherwiseguy has joined #openstack-infra | 14:36 | |
fungi | though i agree that in a perfect world the validation mechanism would be extracted from heat and usable as a stand-alone module, it sounds like (at least for now) it's too intertwined with the running service to be a viable option | 14:36 |
*** e0ne has joined #openstack-infra | 14:37 | |
*** markmcclain has joined #openstack-infra | 14:37 | |
fungi | and would probably involve a lot of mocking and fake backends if "validation" means making sure that the template results in a certain number of systems spun up with the right configuration and interconnectivity | 14:38 |
*** thedodd has joined #openstack-infra | 14:38 | |
*** _nadya_ has joined #openstack-infra | 14:38 | |
sdague | but if you need to verify that, then you need all the services | 14:39 |
sdague | right? | 14:39 |
*** Hal_ has quit IRC | 14:40 | |
sdague | I guess that's where my questioning really is. If it's a syntax check, then it doesn't seem anything should be running. If it's a semantic check that includes handing off the properties from one resource to another then it seems like you need to be able to spin up those resources. | 14:40 |
*** mengxd has joined #openstack-infra | 14:41 | |
therve | It doesn't go as far as the last part | 14:41 |
therve | But it's more than a syntax check | 14:41 |
clarkb | so this came up the first time around | 14:42 |
anteaya | what is the openstack-ptl gerrit group for? https://review.openstack.org/#/admin/groups/132,members | 14:42 |
*** markmcclain has quit IRC | 14:42 | |
clarkb | and I specifically questioned the need for devstack because I knew it would take a long time | 14:42 |
clarkb | and requires a lot of resources | 14:42 |
clarkb | anteaya: git grep says nothing | 14:43 |
therve | I feel we talked about it already, and I gave the arguments | 14:43 |
clarkb | might be in all-projects though | 14:43 |
clarkb | right | 14:43 |
clarkb | therve: but this makes me requestion it if we are suddenly trying to make the thing we knew would suck not suck | 14:43 |
clarkb | and are poitning at d-g instead of heat | 14:43 |
anteaya | clarkb: k | 14:43 |
therve | clarkb, It doesn't suck | 14:44 |
therve | I'm trying to optimize it a bit, that's all | 14:44 |
*** adalbas has joined #openstack-infra | 14:44 | |
clarkb | anteaya: doesnt' look like an all projects thing. It might be related to something older | 14:45 |
fungi | anteaya: openstack-ptl was originally going to have voting rights on something... i think maybe it was intended to get included in the requirements-core group | 14:45 |
fungi | and was supposed to itself include all the individual -ptl groups for official projects | 14:45 |
clarkb | therve: sdague: I guess I am confused why a job explicitly requesting openstack via devstack wouldn't want that | 14:46 |
therve | To me openstack via devstack is a matrix of services | 14:46 |
anteaya | clarkb: k | 14:46 |
therve | You may want a subset of it | 14:46 |
clarkb | therve: sort of. devstack has always been opinionated | 14:47 |
anteaya | fungi: ah, which it doesn't but since it doesn't do anything as a group, no sense wasting energy to make it sync up with governance/programs.yaml | 14:47 |
therve | clarkb, And always configurable? | 14:47 |
fungi | anteaya: right, and it far predates programs.yaml | 14:47 |
clarkb | therve: not like it is today and I feel like that is a bug (we are going to talk about it at the summit) | 14:47 |
*** e0ne_ has joined #openstack-infra | 14:48 | |
clarkb | there is far too much variance today to sanely test the resulting matrix | 14:48 |
clarkb | we need to rein it in | 14:48 |
clarkb | and be properly opinionated | 14:48 |
*** gokrokve has quit IRC | 14:48 | |
therve | OK | 14:48 |
fungi | anteaya: yeah, i just confirmed from one of my earlier queries that it's not actually included in any of the official core groups anywhere, so we could probably just delete the group (well, empty it and hide it unless gerrit recently added a group delete feature) | 14:49 |
clarkb | (that is my opinion :) the summit session should hash out what others think of the situation) | 14:49 |
therve | I'm fine abandoning my patches and move on, I just want to save some time and resources here and there | 14:49 |
clarkb | therve: well I think we end up trading resources | 14:49 |
anteaya | fungi: no objection from to clearing it and hiding it | 14:49 |
*** zehicle_at_dell has joined #openstack-infra | 14:50 | |
anteaya | I haven't seen a group delete feature so far in my travels | 14:50 |
openstackgerrit | A change was merged to openstack-dev/hacking: Speed up hacking_has_correct_license https://review.openstack.org/90491 | 14:50 |
clarkb | therve: automated resources for human resources. Every time we add a new item to the list of things tested is another things that may break without explanation. If we reduce that number of variables humans spend less time debugging (I hope and if not we have problems elsewhere) | 14:50 |
fungi | anteaya: yeah, doesn't look like i have group deletion privs, so i assume it's still not implemented | 14:50 |
*** e0ne has quit IRC | 14:51 | |
*** andreykurilin_ has joined #openstack-infra | 14:51 | |
therve | clarkb, At the abstract level I agree with you. On the concrete problem of devstack and openstack, we want to support people using various sets of components | 14:51 |
fungi | in a similar vein, anybody know what the Salt Formulas group in gerrit was intended for? it's visible and self-owned but empty | 14:52 |
anteaya | yeah, I saw that but didn't click | 14:52 |
clarkb | yup so we will always haev to support some variance, but my position is we need to be explicit with that and not ad hoc | 14:52 |
anteaya | I have no idea | 14:52 |
*** gokrokve has joined #openstack-infra | 14:52 | |
clarkb | so far it has all be ad hoc | 14:52 |
clarkb | which has led to spaghetti | 14:52 |
*** annegentle_ has joined #openstack-infra | 14:52 | |
fungi | i've made salt formulas owned by administrators and hidden it | 14:53 |
therve | Fair enough. I think devstack has grown way outside of its original goals, and that's likely to be the source of the issues you're thinking about. | 14:53 |
clarkb | I don't know what Salt Formulas is for | 14:53 |
*** aysyd has quit IRC | 14:54 | |
openstackgerrit | A change was merged to openstack-dev/hacking: Speed up hacking_import_alphabetical https://review.openstack.org/90492 | 14:55 |
fungi | looks like we stopped using openstack-common-core and openstack-common-milestone at some point | 14:55 |
clarkb | therve: http://junodesignsummit.sched.org/event/fd84ec7ddc3252270fb73e8e9e09cfba if you will be at the summit | 14:55 |
clarkb | therve: there are a few other sessions that should touch on it too | 14:55 |
*** mengxd has quit IRC | 14:55 | |
*** mengxd has joined #openstack-infra | 14:55 | |
*** mengxd has quit IRC | 14:55 | |
sdague | clarkb: so here's an interesting thing - https://review.openstack.org/#/c/87234/ - if you look at that view, you don't see any negative votes | 14:55 |
anteaya | fungi clarkb so if we ever need the Salt Formulas group we can un-hide it | 14:55 |
*** mengxd has joined #openstack-infra | 14:56 | |
sdague | but if yuo look at that change in a list of changes, robert has a -1 on it | 14:56 |
therve | clarkb, I will, thanks for the pointer | 14:56 |
anteaya | fungi: you are doing internal gerrit queries, I am assuming, queries I can't replicate myself, yeah? | 14:56 |
sdague | which I assume is because he has a -1, however after he voted he was removed from the voting capable group | 14:56 |
*** maxbit has quit IRC | 14:56 | |
clarkb | sdague: huh | 14:56 |
clarkb | sdague: we have seen other weirdness like that with drafts | 14:57 |
clarkb | the list view leaks draft info but change view doesn't | 14:57 |
fungi | anteaya: well, you can git grep for those group names in the acls in openstack-infra/config | 14:57 |
*** smarcet has quit IRC | 14:57 | |
sdague | clarkb: fun :) | 14:57 |
fungi | anteaya: and it's possible group inclusion can now be mapped from the new rest api | 14:57 |
fungi | anteaya: though i've been doing db queries for that | 14:57 |
clarkb | sdague: I'm going to guess that list view code for determining max vote is different than code that iterates and displays in the change view | 14:58 |
anteaya | k, I will add rest api to my list of things to grok, right now I am digging into acls better | 14:58 |
anteaya | and thanks for the confirmation | 14:58 |
clarkb | sdague: that may be a worth an upstream bug /me looks for one that exists already | 14:58 |
anteaya | clarkb sdague the governance repo also has different acls on it than other projects | 14:59 |
anteaya | for instances registered users can't vote | 14:59 |
sdague | anteaya: yep | 14:59 |
clarkb | anteaya: yup thats why lifeless' -1 was removed when he was removed from the group | 14:59 |
*** smarcet has joined #openstack-infra | 15:00 | |
clarkb | I am not finding anything upstream | 15:00 |
anteaya | fungi had voted -1 workflow to get wip changes migrated to new 2.8 and then lost the -1 votes when he removed himself from the group | 15:01 |
anteaya | I think it was runAS | 15:01 |
anteaya | runAs | 15:01 |
fungi | clarkb: yeah, i've assumed this was intentional behavior in gerrit. for example, put yourself in project bootstrappers, approve a change for a random project which you wouldn't normally have access to, then remove yourself from project bootstrappers and your approval disappears from the change | 15:01 |
*** andreaf has quit IRC | 15:02 | |
fungi | anteaya: it was actually the workflow +1 votes. for workflow -1 i used impersonation in the ssh api to leave votes as the change owner | 15:02 |
sdague | yeh, I was more interested in the fact that the -1 is there enough to leak through on the list view | 15:02 |
sdague | so it wasn't actually removed | 15:03 |
clarkb | fungi: hmm good point. I think the UI should be consistent though | 15:03 |
sdague | even if it's now ignored | 15:03 |
clarkb | sdague: the comment won't be removed from the DB | 15:03 |
sdague | ok | 15:03 |
clarkb | it is the interpretation of the comment that matters | 15:03 |
clarkb | and it seems to have at least 2 ways of doing that | 15:03 |
anteaya | sdague: ah now I see what you are seeing, on the list view | 15:03 |
*** yfried has quit IRC | 15:03 | |
fungi | clarkb: yeah, the changes that i approved in that manner failed to merge since i didn't leave myself in project bootstrappers long enough. something to keep in mind for the future | 15:04 |
*** dims has quit IRC | 15:04 | |
clarkb | fungi: wow | 15:05 |
clarkb | thankfully cases where we need to do that are very few and far between | 15:05 |
clarkb | in fact I think I have only ever done it on projects I am core on | 15:05 |
clarkb | (d-g) | 15:05 |
*** dims has joined #openstack-infra | 15:05 | |
fungi | clarkb: well, i didn't submit them, just gave myself elevated privs to re-add missing approval votes | 15:06 |
clarkb | oh | 15:06 |
clarkb | I see becaus a submit is independent of votes | 15:06 |
fungi | so they started getting enqueued into the gate, but when it came time for them to merge they bounced out due to lack of approval | 15:06 |
clarkb | (ish, happens immediately so no problem removing yourself form the group) | 15:07 |
anteaya | where is this page published? http://git.openstack.org/cgit/openstack-infra/config/tree/doc/source/third_party.rst | 15:08 |
clarkb | anteaya: http://ci.openstack.org | 15:08 |
anteaya | I thought it was here: http://ci.openstack.org/running-your-own.html | 15:08 |
anteaya | but they don't match | 15:08 |
clarkb | anteaya: http://ci.openstack.org/third_party.html | 15:09 |
anteaya | wrong link | 15:09 |
anteaya | there it is, thanks | 15:09 |
*** julim has joined #openstack-infra | 15:09 | |
*** aysyd has joined #openstack-infra | 15:10 | |
*** e0ne_ has quit IRC | 15:10 | |
dkranz | fungi: I can't seem to figure out how to look at a tempest jobs in jenkins. I heard there was some problem associated with the recent log streaming change. Any clues? | 15:10 |
*** freyes has joined #openstack-infra | 15:11 | |
clarkb | dkranz: which log streaming change? | 15:11 |
dkranz | clarkb: Sorry, I meant streaming to the console. | 15:12 |
clarkb | dkranz: the tempest one? | 15:12 |
clarkb | dkranz: anyways if you click on a job in zuul status it takes you to the jenkins job | 15:12 |
dkranz | clarkb: Yes, the tempest gate jobs now show errors in line | 15:12 |
clarkb | you can view the console there | 15:12 |
dkranz | clarkb: ok, thanks | 15:13 |
clarkb | or click the link in gerrit when the jobs report back | 15:13 |
*** zehicle_at_dell has quit IRC | 15:14 | |
*** mengxd has quit IRC | 15:14 | |
*** mengxd has joined #openstack-infra | 15:15 | |
*** arnaud has quit IRC | 15:16 | |
*** vhoward has left #openstack-infra | 15:18 | |
*** azneita has joined #openstack-infra | 15:18 | |
*** WaltNik has quit IRC | 15:18 | |
anteaya | in all project access there is no section for refs/tags/* | 15:18 |
*** marcoemorais has joined #openstack-infra | 15:19 | |
anteaya | does refs/tags/* inherit anything from refs/* ? | 15:19 |
*** marcoemorais has quit IRC | 15:19 | |
anteaya | https://review.openstack.org/#/admin/projects/All-Projects,access | 15:19 |
anteaya | yes, I guess it would | 15:19 |
clarkb | anteaya: it does sort of. Technicaly it does but gerrit knows to treat tags as special | 15:19 |
clarkb | anteaya: so even if it says registered users can push to refs/* (or whatever it says) you need different permissions for refs/tags | 15:19 |
anteaya | I'm trying to see where the create line for refs/tags/* is necessary for some repos if indeed it is | 15:20 |
anteaya | clarkb: k | 15:20 |
clarkb | anteaya: it is necesssary because tags are special | 15:20 |
anteaya | it is? | 15:20 |
clarkb | anteaya: in individual project ACLs it is | 15:21 |
clarkb | anteaya: because we give project specific groups access to push tags | 15:21 |
anteaya | mordred said it isn't, but that fungi said it is for some | 15:21 |
clarkb | anteaya: do you haev an example of what mordred say isn't necessary? | 15:21 |
*** geertj has quit IRC | 15:21 | |
anteaya | he said the create line isn't necessary let me find the logs | 15:22 |
*** markmcclain has joined #openstack-infra | 15:22 | |
*** ociuhandu has quit IRC | 15:22 | |
*** marcoemorais has joined #openstack-infra | 15:22 | |
*** praneshp has joined #openstack-infra | 15:23 | |
anteaya | http://eavesdrop.openstack.org/irclogs/%23openstack-infra/%23openstack-infra.2014-05-02.log starting around timestamp 2014-05-02T21:16:50 | 15:24 |
*** matsuhas_ has quit IRC | 15:25 | |
*** matsuhashi has joined #openstack-infra | 15:25 | |
mriedem | mengxd: hey, this powervc driver license is not correct https://github.com/stackforge/powervc-driver/blob/master/nova-powervc/powervc/utils.py#L1-L9 | 15:25 |
*** zhiyan is now known as zhiyan_ | 15:26 | |
*** zns has joined #openstack-infra | 15:26 | |
dkranz | clarkb: So I found it. Didn't realize we were on jenkins07 now :). But you can't really get there from zuul. When I click on the link, I see the jobs but it then immediately jumps to the gerrit review page, but with the jenkins url showing in the status bar. Strange. | 15:26 |
*** moted has quit IRC | 15:26 | |
*** atiwari has joined #openstack-infra | 15:26 | |
anteaya | 2014-05-02T21:18:52 <anteaya> so acl files for 2.8 do not need a create line for refs/tags/* | 15:26 |
anteaya | 2014-05-02T21:19:00 <anteaya> okay thanks | 15:26 |
anteaya | 2014-05-02T21:19:07 <mordred> anteaya: that's correct | 15:26 |
clarkb | anteaya: ok I grok now. | 15:26 |
*** annegentle_ has quit IRC | 15:26 | |
clarkb | anteaya: the section is necessary, the specific create is not | 15:26 |
anteaya | clarkb: so what am I missing? | 15:26 |
anteaya | yes | 15:26 |
anteaya | it just needs the refs/tags/* header with pushSignedTag | 15:27 |
clarkb | dkranz: uh I don't know how that could happen | 15:27 |
clarkb | dkranz: the links on the zuul status page are to jenkins | 15:27 |
clarkb | dkranz: and our jenkins shouldn't redirect you | 15:27 |
anteaya | but I keep seeing the create line since it was necessary with 2.4 I guess | 15:27 |
clarkb | anteaya: yup | 15:27 |
anteaya | and I seem to be the only one commenting on them in patches with acl edits | 15:28 |
*** moted has joined #openstack-infra | 15:28 | |
anteaya | so I am doing a sanity check | 15:28 |
*** azneita has quit IRC | 15:28 | |
clarkb | anteaya: I think part of the issue is that people cargo cult and documentation probably needs an update | 15:28 |
clarkb | anteaya: we should udpate all of the existing acls at once along with the docs | 15:28 |
*** wenlock has joined #openstack-infra | 15:28 | |
*** geertj has joined #openstack-infra | 15:29 | |
anteaya | I think the docs may be updated, but not the other acls | 15:29 |
anteaya | let me see if I can figure out a patch | 15:29 |
*** jaypipes has joined #openstack-infra | 15:29 | |
clarkb | dkranz: I am not able to reproduce that behavior | 15:29 |
fungi | to clarify tags and create perms, mordred's original patch to switch to the signedtag permission was also going to delete all create perms anywhere in any acl. i pointed out that some project use create on refs/* to be able to add branches, so he agreed for the time being to not delete create everywhere (but i think he did at least test and confirm that you don't need create on refs/tags/* to be able | 15:29 |
fungi | to push a tag) | 15:29 |
dkranz | clarkb: I looked a little more. The region around each zuul entry on the page seems to connect to a set of jenkins links. But the actual blue underlined link is to gerrit. | 15:30 |
*** terryw has joined #openstack-infra | 15:30 | |
dkranz | clarkb: So it seems that if you click the link it both shows the jenkins links and navigates to gerrit at the same time :) | 15:31 |
clarkb | dkranz: oh you need to expand the block | 15:31 |
anteaya | fungi: your patch https://review.openstack.org/#/c/91797/ has a handy find and replace command in the commit message thank you | 15:31 |
Alex_Gaynor | clarkb, lifeless: So what's the next step in debugging the weird "testr runs no tests on py3" issue? | 15:31 |
clarkb | dkranz: just click on the block and it will drop open | 15:31 |
anteaya | I will work with that as a starting point and see if I can create a patch to remove the create line in refs/tags/* | 15:31 |
*** matsuhashi has quit IRC | 15:31 | |
dkranz | clarkb: Right, but there is zero visual indication that there is such a block. I get it now though. | 15:31 |
anteaya | then if we all test and agree it isn't required we can merged | 15:31 |
clarkb | dkranz: agreed | 15:32 |
clarkb | dkranz: but it is a tradeoff between way too much noise on that page and slightly bad UI | 15:32 |
clarkb | Alex_Gaynor: lifeless indidcated discover finds no tests successfully | 15:32 |
clarkb | Alex_Gaynor: you should figure out why discover would find no tests | 15:32 |
dkranz | clarkb: Not complaining. I just hadn't looked at zuul in a bit since it changed. | 15:33 |
*** otherwiseguy has quit IRC | 15:33 | |
sdague | dkranz: that's been like that for months :) | 15:33 |
*** changbl has quit IRC | 15:33 | |
fungi | anteaya: i think what i would probably do is to write a quick ini parser in python which normalizes the acls to what we want, with deterministic ordering, dropping unnecessary things (i was going to do something along those lines as a throwaway script but just haven't found time). that would allow us to then build a list of checksums and identify identical acls, so we could combine them via | 15:33 |
fungi | references in projects.yaml | 15:33 |
fungi | anteaya: alog with that i was going to collapse/replace the two current infra core groups we have into one | 15:34 |
*** chandan_kumar has quit IRC | 15:34 | |
fungi | and then after those steps, it should be possible to more easily spot divergences in acls which need further alignment, and might allow for even more consolidation | 15:34 |
anteaya | fungi: your way sounds better | 15:35 |
clarkb | Alex_Gaynor: actually I have py33 now and am curious I may take a quick look | 15:35 |
anteaya | let me know when you have something up | 15:35 |
*** marcoemorais has quit IRC | 15:35 | |
*** e0ne has joined #openstack-infra | 15:36 | |
Alex_Gaynor | https://www.irccloud.com/pastebin/xBPcrFQ5 | 15:37 |
Alex_Gaynor | clarkb: ^ not sure how to reconcile those two things | 15:38 |
Alex_Gaynor | the pdb sesssion is from inside of testrepository and is looking at the command that fails | 15:39 |
*** ramashri has joined #openstack-infra | 15:45 | |
Alex_Gaynor | https://www.irccloud.com/pastebin/IJJZ5iIm | 15:45 |
clarkb | Alex_Gaynor: huh so it is still failing on that all? | 15:47 |
clarkb | after fixing my pip.conf to make it python3 safe I almost have discover running | 15:47 |
Alex_Gaynor | clarkb: Heading to the office now, will be back in 30 or so | 15:48 |
*** changbl has joined #openstack-infra | 15:48 | |
*** lcheng_ has joined #openstack-infra | 15:49 | |
*** mrodden has joined #openstack-infra | 15:51 | |
*** etoews has joined #openstack-infra | 15:55 | |
*** atiwari has quit IRC | 15:55 | |
anteaya | some groups have -core, -ptl and a -milestone group | 15:57 |
anteaya | what are the conditions when a -milestone group should be created? | 15:57 |
clarkb | Alex_Gaynor: its a filtration problem | 15:57 |
clarkb | Alex_Gaynor: it will run functional and unit tests without the filter | 15:58 |
*** etoews_ has quit IRC | 15:58 | |
clarkb | now to figure out why that would matter | 15:58 |
*** marun_afk is now known as marun | 16:01 | |
*** zns has quit IRC | 16:01 | |
*** zns has joined #openstack-infra | 16:02 | |
clarkb | Alex_Gaynor: also you are using py34. not sure if that matters | 16:02 |
*** spy1 is now known as antonym | 16:02 | |
*** markmcclain has quit IRC | 16:02 | |
Alex_Gaynor | clarkb: it's the same symptoms. I'm assuming it's a Python 3 in general thing (but you know what they say about assumptions...) | 16:03 |
clarkb | Alex_Gaynor: so long story short I think discover is fine | 16:03 |
clarkb | because `testr run --parallel` in that venv works but `testr run --parallel tests.unit` doesn't | 16:04 |
*** pcrews has joined #openstack-infra | 16:05 | |
clarkb | Alex_Gaynor: and `testr run --parallel tests` runs one test | 16:06 |
*** gokrokve_ has joined #openstack-infra | 16:07 | |
*** markmc has quit IRC | 16:08 | |
*** wenlock has quit IRC | 16:09 | |
*** Ajaeger has joined #openstack-infra | 16:11 | |
*** gokrokve has quit IRC | 16:11 | |
anteaya | do stackforge projects need an abandon line in the refs/heads/* stanza in the acl? | 16:12 |
clarkb | anteaya: yes please | 16:12 |
anteaya | k | 16:14 |
*** Alexei_987 has quit IRC | 16:14 | |
*** atiwari has joined #openstack-infra | 16:15 | |
*** changbl has quit IRC | 16:16 | |
clarkb | Alex_Gaynor: I think the error yo usee in pdb is due to the variable nto being expanded properly? | 16:16 |
clarkb | yeah if I edit .testr.conf pdb runs successfully | 16:17 |
clarkb | wth is going on | 16:17 |
*** _nadya_ has quit IRC | 16:18 | |
*** lakshmiS has joined #openstack-infra | 16:20 | |
*** andreaf has joined #openstack-infra | 16:21 | |
openstackgerrit | Dirk Mueller proposed a change to openstack-dev/hacking: Set version of master tree to 0.9.0 https://review.openstack.org/87301 | 16:27 |
*** kgriffs is now known as kgriffs|afk | 16:28 | |
*** thingee_ is now known as thingee | 16:29 | |
*** changbl has joined #openstack-infra | 16:29 | |
*** derekh_ has quit IRC | 16:30 | |
*** dstanek is now known as dstanek_zzz | 16:31 | |
*** Longgeek has quit IRC | 16:32 | |
Ajaeger | Hi infra-team, the database-api project can get retired now - its content has been moved to the trove repository. What is needed to close it? | 16:33 |
*** UtahDave has joined #openstack-infra | 16:36 | |
anteaya | Ajaeger: so it was alive just under 4 months | 16:36 |
*** homeless has quit IRC | 16:36 | |
fungi | Ajaeger: add it to the infra meeting agenda so we can discuss moving it into the attic | 16:37 |
fungi | Ajaeger: https://wiki.openstack.org/wiki/Meetings/InfraTeamMeeting#Upcoming_project_renames | 16:37 |
fungi | we've already got a few there being relocated to the openstack-attic namespace | 16:38 |
clarkb | Alex_Gaynor: I see the bug | 16:39 |
*** homeless has joined #openstack-infra | 16:39 | |
clarkb | Alex_Gaynor: I will haev a link and a possible fix | 16:39 |
Ajaeger | fungi: Added - but to the wrong section. Will move ;) | 16:41 |
clarkb | Alex_Gaynor: https://bazaar.launchpad.net/~testrepository/testrepository/trunk/view/head:/testrepository/testcommand.py#L284 taht clsure consumes the filters iterable the first time include is called | 16:41 |
clarkb | Alex_Gaynor: subsequent calls iterate an empty iterable and noop | 16:41 |
clarkb | I think this must be a difference in map behavior python2 vs python3 | 16:41 |
clarkb | iirc map gives you a list in python2 but an iterable in python3 \o/ | 16:41 |
clarkb | filters = list(map(re.compile, self.test_filters)) is the fix I think | 16:42 |
clarkb | lifeless: ^ | 16:42 |
clarkb | I feel like I accomplished something this morning | 16:43 |
msabramo | yep, python3 map gives you an object rather than a list | 16:43 |
*** jpich has quit IRC | 16:44 | |
msabramo | ❯ python2.7 -c 'print(type(map(lambda x: x, [1])))' | 16:44 |
msabramo | <type 'list'> | 16:44 |
msabramo | ❯ python3.3 -c 'print(type(map(lambda x: x, [1])))' | 16:44 |
msabramo | <class 'map'> | 16:44 |
clarkb | ya | 16:45 |
*** marcoemorais has joined #openstack-infra | 16:45 | |
clarkb | list(somemapobject) seems to work fine | 16:45 |
clarkb | I'm guessing map isn't much more special than an iterable | 16:45 |
*** crc32 has joined #openstack-infra | 16:45 | |
clarkb | the type not the function | 16:46 |
*** bhuvan has joined #openstack-infra | 16:49 | |
*** davidlenwell_ is now known as davidlenwell | 16:49 | |
mkoderer | hi folks, QA will have a meet-up on sunday before the summit | 16:53 |
mkoderer | if somebody is interested https://plus.google.com/100773563660993493024/posts/P9YSgT8AVXh or ML | 16:53 |
openstackgerrit | A change was merged to openstack-infra/devstack-gate: Add heat-cfntools, heat-templates to PROJECTS https://review.openstack.org/92055 | 16:54 |
*** andreykurilin_ has quit IRC | 16:55 | |
*** yfried has joined #openstack-infra | 16:56 | |
*** gyee has joined #openstack-infra | 16:56 | |
anteaya | mkoderer: thanks, what time are you gathering? | 16:56 |
Ajaeger | clarkb: I took the liberty to include you explicitely in the translation discussion on the i18n mailing list - if I shouldn't do that in the future, please tell me | 16:56 |
anteaya | the joint board/tc meeting is 3-5 which I am planning on attending | 16:56 |
mkoderer | anteaya: not fixed yet.. I will try to reserve a table around 8pm I guess | 16:56 |
fungi | mkoderer: i'll be there in spirit, but more corporeally i'll probably be at the foundation staff/board dinner | 16:57 |
Ajaeger | clarkb: I welcome your feedback in that discussion ;) | 16:58 |
clarkb | Ajaeger: its ok. actually on that topic I dont really have an answer. I think we need to figure out if incomplete translations are helpful to users | 16:58 |
mkoderer | fungi: I see.. yep it's not easy to find a empty slot :) | 16:58 |
fungi | though maybe i can just drink with the board and then bail early to meet up with qa peeps | 16:58 |
*** melwitt has joined #openstack-infra | 16:58 | |
Ajaeger | clarkb: yep, let's see... | 16:58 |
clarkb | I dont properly speak a second language so I am not sure myself | 16:58 |
*** markmcclain has joined #openstack-infra | 16:58 | |
Ajaeger | clarkb: English is my second language, not sure whether I speak it properly ;) | 16:59 |
fungi | Ajaeger: english is my first (and effectively only) language and i'm not sure whether i speak it properly | 16:59 |
clarkb | its worth noting I dont think any project translates by default | 16:59 |
clarkb | so users have to be interested in the translations. horizon is special because the user is the end user not sysadmin | 17:00 |
*** e0ne has quit IRC | 17:00 | |
anteaya | mkoderer: kk thanks | 17:00 |
*** harlowja_away is now known as harlowja | 17:01 | |
anteaya | I try to have no plans around the planned things, but it is nice to be aware this is happening | 17:01 |
Alex_Gaynor | clarkb: ahhhhhhh. nice find! Are you/lifeless working on a patch, or should I? | 17:04 |
clarkb | I can do it, but I havent done it yet | 17:04 |
clarkb | its just that one line change | 17:04 |
clarkb | wrapping map() in list() | 17:05 |
clarkb | probably should add a test too | 17:05 |
Alex_Gaynor | clarkb: Sounds good -- I don't really know how to launchpad/bzr | 17:06 |
clarkb | lifeless will accept patch files | 17:06 |
Ajaeger | clarkb: yeah, I see clear value for Horizon translation but others like nova is a complete different story | 17:06 |
clarkb | Ajaeger yup | 17:06 |
*** Guest51066 has joined #openstack-infra | 17:07 | |
*** andreaf has quit IRC | 17:07 | |
*** ramashri has quit IRC | 17:08 | |
*** aconrad has joined #openstack-infra | 17:09 | |
*** arnaud has joined #openstack-infra | 17:10 | |
*** kgriffs|afk is now known as kgriffs | 17:11 | |
*** Guest51066 is now known as annegentle | 17:11 | |
arnaud | hi | 17:12 |
anteaya | hi arnaud | 17:13 |
arnaud | could I get core reviews for https://review.openstack.org/#/c/90461/ ? | 17:13 |
anteaya | that is the glance specs repo | 17:13 |
*** mestery_ has joined #openstack-infra | 17:14 | |
*** mestery has quit IRC | 17:14 | |
*** UtahDave has quit IRC | 17:15 | |
*** mestery_ is now known as mestery | 17:16 | |
*** terryw is now known as otherwiseguy | 17:16 | |
anteaya | I am going to get some sunshine | 17:16 |
*** UtahDave has joined #openstack-infra | 17:17 | |
*** amcrn has joined #openstack-infra | 17:21 | |
*** gokrokve_ has quit IRC | 17:21 | |
*** kgriffs is now known as kgriffs|afk | 17:21 | |
*** jamespage_ has joined #openstack-infra | 17:21 | |
*** gondoi is now known as zz_gondoi | 17:27 | |
*** dstanek_zzz is now known as dstanek | 17:29 | |
*** zul has quit IRC | 17:30 | |
bnemec | Anybody know why I can't vote on https://review.openstack.org/#/c/76580/ (or a bunch of other patches in that repo) | 17:32 |
Ajaeger | bnemec: Neither can I vote - not evven +1/-1 | 17:33 |
Ajaeger | I see "Submit TypeRULE_ERROR" | 17:33 |
Ajaeger | something is broken with the patch | 17:33 |
bnemec | Yeah, that would be my guess too. | 17:35 |
clarkb | draft | 17:35 |
bnemec | Would just like to be able to do something with those because they're cluttering up the tripleo open reviews. | 17:35 |
bnemec | Oh. | 17:35 |
clarkb | I bet there is a draft | 17:35 |
bnemec | Bah | 17:35 |
clarkb | so stop using drafts | 17:35 |
clarkb | next release of gerrit we can disable them | 17:37 |
bnemec | Okay, looks like I can still abandon it, so I might see if anyone would object to that. Those changes need to go away anyway. | 17:37 |
*** kgriffs|afk is now known as kgriffs | 17:37 | |
bnemec | clarkb: Thanks for the explanation | 17:37 |
*** Ryan_Lane has joined #openstack-infra | 17:37 | |
*** ominakov_ has joined #openstack-infra | 17:38 | |
*** rcarrillocruz has joined #openstack-infra | 17:40 | |
*** ominakov has quit IRC | 17:41 | |
*** rcarrill` has quit IRC | 17:42 | |
*** jamespage_ has quit IRC | 17:43 | |
*** ominakov_ has quit IRC | 17:45 | |
*** dizquierdo has quit IRC | 17:47 | |
fungi | clarkb: from last night's scrollback, you talked about cleaning out references to pbr's testr setup target... is that basically just making sure we get rid of references to it in tox configs of all projects (and possibly slave scripts/job configs where we've missed removing it too)? | 17:47 |
fungi | well, s/getting rid of/replacing it with test/ | 17:47 |
*** hogepodge has joined #openstack-infra | 17:48 | |
*** krotscheck has quit IRC | 17:49 | |
*** annegentle has quit IRC | 17:49 | |
* clarkb wears down the ssd in his laptop with `gertty -d` | 17:49 | |
fungi | ground and polished smooth | 17:49 |
*** krotscheck has joined #openstack-infra | 17:50 | |
clarkb | fungi: ya, projects that do `python setup.py testr` use the distutils hook in testrepository whihc lifeless doesn't like | 17:50 |
*** reed has joined #openstack-infra | 17:50 | |
clarkb | fungi: `python setup.py test` in pbr'd projects will run the hook in pbr which is preferable because we can release fixes for that and so on | 17:50 |
*** thedodd has quit IRC | 17:50 | |
openstackgerrit | Clark Boylan proposed a change to stackforge/gertty: Removed closed changes from unreviewed list. https://review.openstack.org/92747 | 17:50 |
clarkb | and now back to patching testr | 17:51 |
* clarkb learns him a bzr | 17:51 | |
Ajaeger | clarkb, fungi: Until recently jobs with negative reviews expired after a week - I haven't seen this for a few weeks now. Is that a concise change? | 17:52 |
dhellmann | hi, folks, I need a little help debugging an error with an oslo.i18n test job: http://logs.openstack.org/78/92678/2/check/check-oslotest-dsvm-oslo.i18n/159d829/console.html | 17:52 |
clarkb | Ajaeger: I think it is fallout from the gerrit upgrade | 17:52 |
clarkb | Ajaeger: and is a bug | 17:52 |
dhellmann | I think that just means the oslo.i18n repo wasn't checked out somewhere, but I'm not sure why that would be or what controls that. | 17:53 |
Ajaeger | clarkb: shall I file one? | 17:53 |
fungi | Ajaeger: do you have an example of one with negative reviews and no activity open for more than two weeks? | 17:53 |
fungi | or was it only a week? i don't remember | 17:53 |
*** SumitNaiksatam has joined #openstack-infra | 17:53 | |
Ajaeger | fungi: https://review.openstack.org/86263 - last change 22nd april | 17:54 |
*** thedodd has joined #openstack-infra | 17:54 | |
*** amcrn_ has joined #openstack-infra | 17:54 | |
Ajaeger | fungi: I think it was a week | 17:54 |
*** homeless has quit IRC | 17:54 | |
*** _nadya_ has joined #openstack-infra | 17:54 | |
Ajaeger | fungi: Just opened one of those emails, it contains "code review expired after 1 week of no activity after a negative review" | 17:54 |
fungi | regardless, yeah that's more than 2 weeks | 17:54 |
*** gokrokve has joined #openstack-infra | 17:54 | |
fungi | bug, sure | 17:55 |
*** mestery has quit IRC | 17:55 | |
Ajaeger | Ok, will file a bug report | 17:55 |
*** mestery has joined #openstack-infra | 17:55 | |
clarkb | dhellmann: we may need to add oslo.i8ln to the d-g PROJECTS var | 17:55 |
dhellmann | clarkb: ah, yeah, I'll bet that's it | 17:55 |
clarkb | dhellmann: doesn't look like setup workspace copied the repo out of the cache since it isn't in the PROJECTS list | 17:55 |
fungi | Ajaeger: clarkb: i see the (a?) bug already... | 17:55 |
dhellmann | clarkb: ok, I'll go review my checklist and then do that | 17:56 |
dhellmann | clarkb: thanks | 17:56 |
clarkb | dhellmann: np | 17:56 |
Ajaeger | fungi: so no need for a bug report, ok will stop ;) | 17:56 |
clarkb | fungi: that was fast | 17:56 |
clarkb | ninja debugging | 17:56 |
fungi | Ajaeger: clarkb: the cron job tries to run 'python /usr/local/bin/expire-old-reviews launchpadsync /home/gerrit2/.ssh/launchpadsync_rsa' and /home/gerrit2/.ssh/launchpadsync_rsa dne | 17:56 |
*** amcrn has quit IRC | 17:56 | |
fungi | probably never puppeted and so didn't end up on the new machine | 17:56 |
Ajaeger | Argh ;( | 17:57 |
fungi | checking now to confirm what we need to do to get it set up properly there | 17:57 |
Ajaeger | fungi: that was quick! | 17:57 |
*** mrodden has quit IRC | 17:57 | |
openstackgerrit | Doug Hellmann proposed a change to openstack-infra/devstack-gate: add oslo.i18n to project list https://review.openstack.org/92880 | 17:58 |
*** vponomaryov has quit IRC | 17:59 | |
openstackgerrit | Doug Hellmann proposed a change to openstack-infra/devstack-gate: add oslo.i18n to project list https://review.openstack.org/92880 | 17:59 |
*** Sukhdev has joined #openstack-infra | 17:59 | |
fungi | yup, we have a script_key_file variable we set the filename in, but never actually create that file, so i need to get it ported into hiera from the old server | 17:59 |
fungi | patch on the way | 18:00 |
sandywalsh | hey infra-gods ... our stacktach repo was missing a tox.ini ... so we can't do any reviews. Can we freshen up the repo from https://github.com/rackerlabs/stacktach ? | 18:01 |
clarkb | Alex_Gaynor: https://bugs.launchpad.net/testrepository/+bug/1317607 | 18:01 |
uvirtbot | Launchpad bug 1317607 in testrepository "testr test filters fail to apply under python3" [Undecided,New] | 18:01 |
clarkb | sandywalsh: just push a tox.ini | 18:01 |
Alex_Gaynor | clarkb: thanks so much | 18:01 |
sandywalsh | clarkb: to where? I thought it all had to go through the review process? | 18:01 |
clarkb | sandywalsh: yup via gerrit | 18:01 |
dhellmann | sandywalsh: if you submit a review with a tox.ini, it will be there when the job tries to use it | 18:01 |
fungi | sandywalsh: you review a change which adds tox.ini | 18:02 |
*** yfried has quit IRC | 18:02 | |
sandywalsh | ah, true ... lemme try that ... thanks | 18:02 |
dhellmann | clarkb: would appreciate your eyes on ^^ as well as the oslo-specs import (https://review.openstack.org/92614) when you have a few minutes | 18:02 |
*** UtahDave has quit IRC | 18:03 | |
clarkb | dhellmann: d-g change approved | 18:04 |
clarkb | can look at specs when I finsih this testr thing | 18:04 |
dhellmann | clarkb: thanks! | 18:05 |
*** homeless has joined #openstack-infra | 18:05 | |
*** james_li has joined #openstack-infra | 18:07 | |
*** liam__ has joined #openstack-infra | 18:07 | |
*** liam__ has quit IRC | 18:07 | |
*** davidlenwell has quit IRC | 18:07 | |
*** davidlenwell has joined #openstack-infra | 18:09 | |
*** mriedem has quit IRC | 18:09 | |
*** wenlock has joined #openstack-infra | 18:09 | |
*** Ng_ has joined #openstack-infra | 18:11 | |
*** Ng_ has quit IRC | 18:12 | |
*** mriedem has joined #openstack-infra | 18:14 | |
*** _nadya_ has quit IRC | 18:14 | |
*** zul has joined #openstack-infra | 18:14 | |
*** mwagner_ has joined #openstack-infra | 18:14 | |
*** markmcclain has quit IRC | 18:14 | |
*** bhuvan has quit IRC | 18:15 | |
clarkb | has anyone run testrepository unittests recently? | 18:16 |
clarkb | sdague: ^ | 18:16 |
*** rcarrillocruz has quit IRC | 18:17 | |
*** bhuvan has joined #openstack-infra | 18:17 | |
*** bhuvan has quit IRC | 18:17 | |
*** bhuvan has joined #openstack-infra | 18:17 | |
openstackgerrit | Jeremy Stanley proposed a change to openstack-infra/config: Puppet the key used for expiring old reviews https://review.openstack.org/92884 | 18:17 |
*** rcarrillocruz has joined #openstack-infra | 18:17 | |
clarkb | I know I fgigured this out before but I have created two virtualenvs one for python2.7 and one for python3.3 and running `make` in either results in AttributeError: 'module' object has no attribute 'tests' | 18:17 |
*** mrodden has joined #openstack-infra | 18:17 | |
anteaya | fungi: line 5 is missing a comma: https://review.openstack.org/#/c/92884/1/modules/gerrit/manifests/cron.pp | 18:20 |
*** morganfainberg_Z is now known as morganfainberg | 18:22 | |
fungi | anteaya: thanks. the change is premature anyway because i started digging in hiera and it looks like the keys are already in there just under other names | 18:22 |
anteaya | k | 18:24 |
clarkb | looks like my test woes were a dependency thing + one other thing I worked around >_> | 18:25 |
anteaya | so have you figured it out yet? | 18:25 |
clarkb | nope all test dependency issues ok good tests are running | 18:26 |
openstackgerrit | Jeremy Stanley proposed a change to openstack-infra/config: Puppet the key used for expiring old reviews https://review.openstack.org/92884 | 18:26 |
openstackgerrit | Jeremy Stanley proposed a change to openstack-infra/config: Puppet the key used for expiring old reviews https://review.openstack.org/92884 | 18:27 |
*** bhuvan_ has joined #openstack-infra | 18:27 | |
fungi | anteaya: fixed your comment (forgot to do it on the previous patch) | 18:27 |
*** darraghb has quit IRC | 18:27 | |
*** Ng has quit IRC | 18:27 | |
*** yfried has joined #openstack-infra | 18:28 | |
clarkb | Alex_Gaynor: now with a patch | 18:29 |
*** bhuvan has quit IRC | 18:29 | |
*** Ng has joined #openstack-infra | 18:30 | |
*** markmcclain has joined #openstack-infra | 18:31 | |
Alex_Gaynor | clarkb: awesome | 18:32 |
*** homeless has quit IRC | 18:33 | |
*** _nadya_ has joined #openstack-infra | 18:34 | |
anteaya | fungi: +1 | 18:35 |
anteaya | Ajaeger: https://review.openstack.org/#/c/92884/ | 18:35 |
openstackgerrit | Ben Nemec proposed a change to openstack-infra/config: Add dib-utils project https://review.openstack.org/90281 | 18:35 |
Ajaeger | anteaya: thanks! | 18:36 |
marun | clarkb: I think the neutron functional job should be made voting, but I'm not sure how to verify the failure rate. | 18:38 |
anteaya | np | 18:39 |
marun | clarkb: How do I ensure that failures are due to code rather than the job? | 18:39 |
clarkb | marun: you can use logstash to filter all failures against known bugs | 18:40 |
marun | clarkb: er, is there an easy way to do that? | 18:41 |
*** thedodd has quit IRC | 18:41 | |
clarkb | marun: I'm not aware of an easy way :) sdague may have ideas though | 18:42 |
clarkb | I think he spends more time than anyone doing analysis like that | 18:42 |
marun | sdague: ^ The neutron functional job seems stable to me but I'd like to be sure before proposing it become voting. | 18:42 |
marun | clarkb: ok, thanks :) | 18:42 |
marun | sdague: making it voting would impact devstack since it relies on it for setup. | 18:43 |
openstackgerrit | Doug Hellmann proposed a change to openstack/requirements: Add oslo.db and oslo.i18n to project list https://review.openstack.org/92890 | 18:45 |
*** otherwiseguy has quit IRC | 18:45 | |
clarkb | dhellmann: oslo-specs review should show up shortly once gertty syncs | 18:46 |
dhellmann | clarkb: thanks! (what's gertty?) | 18:46 |
fungi | dhellmann: console-based gerrit client built on top of its rest api | 18:47 |
dhellmann | fungi: is that something you guys have built? | 18:47 |
fungi | dhellmann: https://git.openstack.org/cgit/stackforge/gertty | 18:47 |
dhellmann | nice | 18:47 |
fungi | jeblair's written the bulk of it, though others have started adding changes | 18:47 |
clarkb | dhellmann: its mostly jeblair and its still pretty rough around the edges, but I find it works really well for sitting down and doing reviews all at once | 18:47 |
clarkb | but it is async and offline (good for airplanes) whihc means after I enter a review it takes a little while to catch up | 18:48 |
fungi | dhellmann: imap mail client like batch local/offline operations | 18:48 |
dhellmann | clever idea, I'll have to give that a try | 18:48 |
openstackgerrit | A change was merged to openstack-infra/config: Scale back on tripleo testing https://review.openstack.org/92808 | 18:49 |
fungi | clarkb: how well does it handle pushing review votes when there are new patchsets since the last time you sync'd? | 18:49 |
fungi | i haven't used it enough yet to find out | 18:49 |
clarkb | fungi: I haven't run into that | 18:49 |
clarkb | My gertty log is up to 31MB will have to restart it here without the debug logging | 18:50 |
dhellmann | I gave the link to markmcclain, since he's on airplanes more than he's on the ground I thought he'd be a good beta user :-) | 18:50 |
clarkb | dhellmann: I think jeblair is trying to not promise a whole lot | 18:50 |
dhellmann | clarkb: open source, right? :-) | 18:51 |
clarkb | indeed | 18:51 |
openstackgerrit | Anita Kuno proposed a change to stackforge/gertty: Expand the .gitignore file to ignore .egg files https://review.openstack.org/92891 | 18:51 |
anteaya | hey!! I can see stuff now | 18:53 |
*** jerryz has joined #openstack-infra | 18:53 | |
anteaya | woohoo | 18:53 |
*** arnaud has quit IRC | 18:55 | |
Ryan_Lane | has anyone checked to see if the search issues are gone in the wiki since the maintenance the other day? | 18:57 |
*** xdmeng has joined #openstack-infra | 18:57 | |
*** mengxd has quit IRC | 18:57 | |
fungi | Ryan_Lane: i just checked now, and at least the index seems to have been updated | 18:58 |
*** whoops has joined #openstack-infra | 18:58 | |
Ryan_Lane | cool | 18:58 |
fungi | things which i removed months ago have (in the past few days) ceased showing up in wiki search results | 18:58 |
anteaya | Ryan_Lane: well done | 18:58 |
Ryan_Lane | I had completely rebuilt the index | 18:58 |
anteaya | wow | 18:58 |
Ryan_Lane | let me know if anything fails | 18:58 |
*** zz_gondoi is now known as gondoi | 18:58 | |
fungi | will do, and thanks! | 18:58 |
Ryan_Lane | turns out you need to run maintenance scripts when you update the search plugin ;) | 18:59 |
fungi | heh | 18:59 |
Ryan_Lane | which I didn't do last time | 18:59 |
openstackgerrit | A change was merged to openstack-infra/config: Create glance-specs git repo https://review.openstack.org/90461 | 18:59 |
*** james_li has quit IRC | 19:00 | |
*** wenlock has quit IRC | 19:00 | |
openstackgerrit | Doug Hellmann proposed a change to openstack-infra/config: Create an oslo-specs repository https://review.openstack.org/92614 | 19:00 |
clarkb | ArxCruz: want to follow up https://review.openstack.org/#/c/92820/ with a change that fixes zeromq too? | 19:01 |
*** jgrimm has quit IRC | 19:01 | |
ArxCruz | clarkb: sure :) | 19:01 |
clarkb | thanks | 19:02 |
ArxCruz | np | 19:02 |
*** mrodden has quit IRC | 19:03 | |
*** james_li has joined #openstack-infra | 19:04 | |
*** openstackgerrit has quit IRC | 19:04 | |
*** openstackgerrit has joined #openstack-infra | 19:06 | |
*** amcrn_ has quit IRC | 19:07 | |
*** homeless has joined #openstack-infra | 19:07 | |
*** primeministerp has quit IRC | 19:09 | |
*** andreaf has joined #openstack-infra | 19:10 | |
*** andreaf has quit IRC | 19:10 | |
*** andreaf has joined #openstack-infra | 19:11 | |
*** james_li has quit IRC | 19:11 | |
*** Ng has quit IRC | 19:12 | |
*** arnaud has joined #openstack-infra | 19:17 | |
zaro | clarkb: i think that's what jeblair wanted in 88432, maybe should just wait for him to comment. | 19:17 |
clarkb | zaro: ok | 19:17 |
*** _nadya_ has quit IRC | 19:18 | |
clarkb | reed: can you add an etherpad to https://wiki.openstack.org/wiki/Summit/Juno/Etherpads#Infrastructure for your session? | 19:18 |
reed | clarkb, I sure can, thanks for the poke | 19:19 |
clarkb | np | 19:19 |
*** etoews_ has joined #openstack-infra | 19:19 | |
krtaylor | clarkb, for the 3rd party session, are you set? | 19:20 |
clarkb | krtaylor: I think so | 19:20 |
krtaylor | clarkb, I saw the etherpad for it, glad to see some of the topics | 19:20 |
clarkb | krtaylor: feel free to add stuff to the therpad | 19:21 |
krtaylor | alot of the stuff I was wanting to see discussed | 19:21 |
krtaylor | I'll go through my etherpad and cross reference | 19:21 |
*** arnaud has quit IRC | 19:21 | |
*** etoews has quit IRC | 19:23 | |
fungi | clarkb: zaro: do you have any insight into whether my jenkins publisher assumptions on https://review.openstack.org/92493 about ftp remove-prefix vs scp keep-hierarchy are correct, or whether i need to set up some test jobs to confirm? | 19:25 |
clarkb | looking | 19:26 |
clarkb | fungi: keep hierarchy will flatten if set to false iirc | 19:27 |
fungi | bascially we want to scp x/** (which contains x/y/z) to the site and get y/z there | 19:27 |
clarkb | fungi: so foo/bar/baz and foo/zort get copied as /baz and /zort | 19:27 |
fungi | other ideas as to how to do that with the scp publisher? | 19:27 |
clarkb | fungi: use the remove prefix as before | 19:27 |
fungi | i didn't see that as an option for the scp publisher | 19:28 |
clarkb | oh you are switching to scp | 19:28 |
*** Ng has joined #openstack-infra | 19:28 | |
clarkb | I missed that /me thinks more | 19:28 |
fungi | yeah, that was the suggestion was that we should do scp instead of ftp now | 19:28 |
clarkb | fungi: jeblair said no | 19:28 |
fungi | with scp we lose remove-prefix it seems | 19:28 |
clarkb | he wants to do it all at once rather than piecemeal | 19:28 |
fungi | gah | 19:29 |
fungi | then i need to recreate all the sites on the 8 jenkins masters again | 19:29 |
clarkb | because apparently the reason we have ci.o.o in a weird place is this was attempted piecemeal forever ago and never finished | 19:29 |
fungi | okay, will do | 19:29 |
clarkb | fungi: well its certainly worth talking to him more about | 19:29 |
clarkb | especially if the work is done. I will keep looking at how to make this work with scp | 19:29 |
fungi | well, i can redo it with ftp, just don't want the docs team waiting on me any longer than they already have been | 19:30 |
clarkb | oh right I remember. We have worked around this my copying/moving files | 19:30 |
sdague | marun: what's the question exactly? | 19:30 |
clarkb | if you have files at foo/bar/** but don't want foo/bar/** you mv foo/bar ./ | 19:30 |
fungi | if this isn't straightforward to solve with the scp publisher and we'd rather just add more ftp sites for now and switch them later, then i'll just redo these bits | 19:30 |
clarkb | then copy them | 19:30 |
clarkb | fungi: I prefer scp myself, but defer to jeblair since he was around the first time this was attempted | 19:31 |
fungi | sure, makes sense | 19:31 |
*** thedodd has joined #openstack-infra | 19:31 | |
*** wenlock has joined #openstack-infra | 19:32 | |
*** Ng_ has joined #openstack-infra | 19:32 | |
*** Ng has quit IRC | 19:32 | |
*** annegentle has joined #openstack-infra | 19:33 | |
*** Ng_ is now known as Ng | 19:33 | |
*** geertj has quit IRC | 19:35 | |
*** annegentle has quit IRC | 19:35 | |
clarkb | ya so the scp plugin really doesn't have a way to do it without that mv trick above | 19:36 |
clarkb | :/ | 19:36 |
*** annegentle has joined #openstack-infra | 19:36 | |
clarkb | its not just a jjb limitation | 19:36 |
*** annegentle has quit IRC | 19:36 | |
*** mrodden has joined #openstack-infra | 19:36 | |
*** annegentle has joined #openstack-infra | 19:36 | |
*** annegentle has quit IRC | 19:37 | |
marun | sdague: how do I know if it's time for the check-neutron-dsvm-functional job to become voting | 19:37 |
marun | sdague: (and gating) | 19:37 |
openstackgerrit | Joe Gordon proposed a change to openstack-infra/devstack-gate: Add more fixed ips https://review.openstack.org/92900 | 19:38 |
openstackgerrit | K Jonathan Harker proposed a change to openstack-infra/config: Move openstack-specific config out of ::jenkins https://review.openstack.org/89708 | 19:38 |
*** annegentle has joined #openstack-infra | 19:39 | |
*** geertj has joined #openstack-infra | 19:40 | |
*** wenlock has quit IRC | 19:40 | |
marun | sdague: I'd like to start refactoring the unit test suite into unit and functional test, but it won't make sense to merge anything until the functional job is gating. | 19:40 |
sdague | marun: the following query will give you one hit per run - http://logstash.openstack.org/#eyJzZWFyY2giOiJidWlsZF9uYW1lOmNoZWNrLW5ldXRyb24tZHN2bS1mdW5jdGlvbmFsIEFORCAobWVzc2FnZTpcIkZpbmlzaGVkOiBTVUNDRVNTXCIgT1IgbWVzc2FnZTpcIkZpbmlzaGVkOiBGQUlMVVJFXCIpIiwiZmllbGRzIjpbXSwib2Zmc2V0IjowLCJ0aW1lZnJhbWUiOiI2MDQ4MDAiLCJncmFwaG1vZGUiOiJjb3VudCIsInRpbWUiOnsidXNlcl9pbnRlcnZhbCI6MH0sInN0YW1wIjoxMzk5NTc4MDc4OTU3fQ== | 19:43 |
sdague | if you click on build_status -> score you can get the current pass / fail ratio, which looks like about 8% failure | 19:44 |
sdague | the real question is whether those failures are actually catching real bugs or are fail negatives | 19:44 |
lifeless | clarkb: nice find | 19:44 |
sdague | I typically go through and spot check | 19:44 |
*** mrodden1 has joined #openstack-infra | 19:45 | |
*** mrodden has quit IRC | 19:47 | |
openstackgerrit | Joe Gordon proposed a change to openstack-infra/config: Add neutron-large-ops-testing job https://review.openstack.org/92901 | 19:47 |
*** _nadya_ has joined #openstack-infra | 19:49 | |
*** krotscheck has quit IRC | 19:50 | |
*** krotscheck has joined #openstack-infra | 19:51 | |
openstackgerrit | Jeremy Stanley proposed a change to openstack-infra/config: Publish API/CLI/SDK site to developer.o.o https://review.openstack.org/92493 | 19:53 |
*** _nadya_ has quit IRC | 19:53 | |
marun | sdague: ok | 19:53 |
clarkb | lifeless once I figured out pdb isnt installed by virtualenv it was easy | 19:54 |
marun | sdague: is there a way to correlate failures between jobs? | 19:55 |
marun | sdague: i.e. filter out functional job failures that coincide with unittest failures? | 19:55 |
*** lakshmiS has quit IRC | 19:55 | |
*** otherwiseguy has joined #openstack-infra | 19:56 | |
*** rcarrill` has joined #openstack-infra | 19:57 | |
*** markmcclain has quit IRC | 19:58 | |
*** marun is now known as maru_afk | 19:58 | |
*** rcarrill` has left #openstack-infra | 19:58 | |
*** rcarrillocruz has quit IRC | 19:58 | |
*** thomasem has quit IRC | 19:58 | |
*** thomasem has joined #openstack-infra | 19:58 | |
*** thomasem has quit IRC | 19:58 | |
*** Sukhdev has quit IRC | 19:59 | |
*** thomasem has joined #openstack-infra | 19:59 | |
*** gondoi is now known as zz_gondoi | 20:00 | |
openstackgerrit | Doug Hellmann proposed a change to stackforge/gertty: Alternate colors for light-background terminals https://review.openstack.org/92904 | 20:01 |
*** markmcclain has joined #openstack-infra | 20:01 | |
*** markmcclain1 has joined #openstack-infra | 20:03 | |
*** zz_gondoi is now known as gondoi | 20:06 | |
*** markmcclain has quit IRC | 20:06 | |
*** whoops has quit IRC | 20:06 | |
*** dizquierdo has joined #openstack-infra | 20:07 | |
*** julim has quit IRC | 20:08 | |
*** grantbow has quit IRC | 20:09 | |
*** grantbow has joined #openstack-infra | 20:09 | |
fungi | that's ^ how you can tell people who spent more time on serial terminals vs workstations ;) | 20:10 |
sdague | maru_afk: not easily | 20:12 |
dhellmann | fungi: ? | 20:13 |
fungi | dhellmann: preference for dark backgrounds vs light backgrounds | 20:13 |
dhellmann | fungi: ah, I get eye strain staring at white on black | 20:13 |
fungi | xterm defaulted to black text on white background going back to the beforetimes | 20:14 |
dhellmann | fungi: but I have a weird hypersensitivity to green, too, so I used to turn the brightness all the way down on the crts | 20:14 |
fungi | dhellmann: oh, yeah, you probably liked the amber terminals better | 20:14 |
dhellmann | fungi: yep, 20 years ago I was a light on dark guy, not so much any more | 20:14 |
dhellmann | amber was the best | 20:14 |
fungi | those were definitely easier on the eyes | 20:14 |
dhellmann | I can read those green screens on settings where most people can't even tell they are on -- it's like a lame super power | 20:15 |
anteaya | I blowed up gertty: http://paste.openstack.org/show/79644/ | 20:15 |
anteaya | I selected a patch to open and gertty stopped | 20:16 |
*** geertj has quit IRC | 20:16 | |
*** arborism has joined #openstack-infra | 20:16 | |
anteaya | what I was looking for apparently didnt' exist | 20:16 |
fungi | good news everyone! we can *actually* push acls to gerrit which look like http://paste.openstack.org/show/79645/ (confirmed pushing through the ssh api on review-dev). it doesn't store them that way on disk, but means we can keep them more readable and editable (no stupid indents, hard tabs, parseable by configparser) | 20:17 |
anteaya | dhellmann: ha ha ha | 20:17 |
anteaya | sound like a reddit thread | 20:17 |
*** dstanek is now known as dstanek_zzz | 20:18 | |
*** derekh_ has joined #openstack-infra | 20:18 | |
anteaya | fungi: nice | 20:19 |
anteaya | fungi: though you have said we don't need [project] status = active anymore, correct? | 20:19 |
fungi | anteaya: right, this was just a raw acl i pulled from one of the test projects on review-dev | 20:19 |
fungi | ignore the contents, point was the formatting | 20:20 |
anteaya | ah | 20:20 |
anteaya | the formatting looks nice | 20:20 |
fungi | dropping indents and adding blank lines separating sections, like a typical ini file | 20:20 |
fungi | i understand why gerrit does it, because they're emulating .git/config defaults, but our devs are far more used to editing normal inifiles than gitconfig files | 20:21 |
openstackgerrit | A change was merged to openstack-dev/hacking: Update pointer to HACKING.rst in the readme https://review.openstack.org/92444 | 20:25 |
openstackgerrit | A change was merged to openstack-dev/hacking: Add link to readme at bottom of docs.openstack.org/developer/hacking/ https://review.openstack.org/92445 | 20:26 |
*** jgrimm has joined #openstack-infra | 20:26 | |
dims | krtaylor, getting 404 for urls posted by "IBM PowerKVM Testing" (ex: https://review.openstack.org/#/c/83207/) | 20:27 |
krtaylor | dims, thanks, I'll look into it | 20:28 |
krtaylor | ArxCruz, ^^^ | 20:28 |
*** Ajaeger has left #openstack-infra | 20:30 | |
*** arborism is now known as amcrn | 20:30 | |
*** etoews has joined #openstack-infra | 20:33 | |
*** dangers_away is now known as dangers | 20:34 | |
openstackgerrit | Ben Nemec proposed a change to openstack-infra/config: Remove tripleo cross-testing with oslotest https://review.openstack.org/92910 | 20:34 |
*** etoews_ has quit IRC | 20:34 | |
*** dstanek_zzz is now known as dstanek | 20:39 | |
clarkb | fungi: with that acl format does the resulting git commit in refs/meta/config use the format gerrit wants? | 20:41 |
clarkb | fungi: I ask because the way manage-projects knows when to update gerrit is with git diff | 20:41 |
fungi | oh... hrm | 20:41 |
fungi | checking | 20:41 |
fungi | clarkb: actually... it DOES seem to leave it in the format you push | 20:44 |
clarkb | great | 20:44 |
*** dkranz has quit IRC | 20:44 | |
fungi | now checking to see what happens if i modify it from the webui | 20:44 |
fungi | modifying it from the webui puts the indents back | 20:46 |
clarkb | fungi: thats probably not too terrible as webui edits would be overwritten by manage-projects anyways | 20:47 |
clarkb | so whitespace is a small thing in that case | 20:47 |
fungi | wonder if that's a concession we can live with (presumably we only push these from m-p normally, and if it reapplies the same acl reformatted then not too bad_ | 20:47 |
fungi | yeah, agreed | 20:47 |
asselin | Hi, I'm trying to create a nodepool image with eth0 and eth1. I update the prepare_node script to set it up. However, after the vm is booted from the image, the new file /etc/network/interfaces.d/eth1.cfg is either missing or empty. Am I missing something? | 20:47 |
*** lcostantino has quit IRC | 20:48 | |
*** dprince has quit IRC | 20:48 | |
fungi | asselin: is it possible that your cloud is doing some sort of file injection or overriding that via cloud-init? | 20:48 |
fungi | asselin: basically, you've confirmed that at boot the node gets something different than is on the filesystem of the template instance? | 20:49 |
asselin | fungi, not sure where that would be. My cloud is a locally installed openstack stable/icehouse via stack.sh.... | 20:49 |
*** dstanek is now known as dstanek_zzz | 20:49 | |
fungi | amusingly, i don't know enough about openstack itself to guess what could be going on at boot to affect that, other than the things i've seen our providers do to new instances | 20:50 |
asselin | fungi, yes, I'm stepping through the nodepool code and paused the code after the image is created. I can see the eth1 file there in the image-create-vm, but not in the manually booted vm using that new image. | 20:51 |
asselin | it's as if nova wipes out everything except eth0 on boot? | 20:53 |
fungi | asselin: my guess would be that the cloud-init utility is installed and doing something at boot to try to configure your networking. there are a few places cloud-init can look for configuration including in /etc, on a configdrive, user data injection, et cetera | 20:53 |
fungi | asselin: look for the cloud-init log in /var/log on the broken node | 20:53 |
fungi | if cloud-init is messing with things at boot time, i think it logs what it did | 20:53 |
asselin | fungi, thanks I will look there | 20:54 |
*** arnaud has joined #openstack-infra | 20:55 | |
*** thomasem has quit IRC | 20:59 | |
ArxCruz | dims: krtaylor I'm doing a recheck, I believe the problem is fixed now, please, let me know if you can't access the logs | 20:59 |
ArxCruz | I'm heading to home now | 20:59 |
ArxCruz | back soon | 20:59 |
*** thomasem has joined #openstack-infra | 21:00 | |
*** ArxCruz has quit IRC | 21:02 | |
morganfainberg | clarkb, for the apache-services tempest we need to wait for the next time zuul receives a HUP? or is this something I configured wrong? (not worried if it's just wait for next zuul config reload) | 21:03 |
morganfainberg | clarkb, i just want to make sure i didn't do anything wrong. re: https://review.openstack.org/#/c/91739/ | 21:03 |
clarkb | morganfainberg: looking | 21:03 |
*** ramashri has joined #openstack-infra | 21:03 | |
clarkb | morganfainberg: it says its there | 21:04 |
morganfainberg | hm. | 21:04 |
mordred | morning all | 21:05 |
mordred | did I miss anything fun? | 21:05 |
morganfainberg | clarkb, hm, not seeing it on the status page. | 21:05 |
clarkb | morganfainberg: but I agree I don't see it running | 21:05 |
mordred | clarkb, fungi: I made a presentation today that I _think_ should get its own branch - but I'd be open to feedback on that | 21:05 |
morganfainberg | clarkb, ok, let me take a closer look and i'll see if anything stands out | 21:06 |
clarkb | I am looking too, you have made me curious | 21:06 |
morganfainberg | clarkb, :) | 21:06 |
morganfainberg | oh | 21:06 |
morganfainberg | clarkb i think i see it | 21:06 |
clarkb | do tell | 21:06 |
morganfainberg | ^(!?stable/(havana|icehouse)).*$ | 21:06 |
morganfainberg | probably should be ^(?!stable/(havana|icehouse)).*$ | 21:07 |
anteaya | hi mordred | 21:07 |
morganfainberg | clarkb, !? vs ?! in the regex | 21:07 |
clarkb | morganfainberg: oh yup | 21:07 |
anteaya | mordred: how did your presentation go? | 21:07 |
morganfainberg | clarkb, doh! | 21:07 |
clarkb | if you propose that I can merge | 21:07 |
*** homeless has quit IRC | 21:07 | |
morganfainberg | clarkb, will do :) | 21:07 |
*** lcheng_ has quit IRC | 21:07 | |
clarkb | mordred: have it posted somewhere so we can look? | 21:07 |
clarkb | I suppose a description of the talk would work too if you have a summary on a conference page | 21:08 |
mordred | clarkb: I don't - it was an internal HP conference | 21:08 |
mordred | but I really like what I did with the slides | 21:08 |
mordred | clarkb: perhaps I should just propse a patch to the current overview talk and you guys can tell me if you think it's a new talk or a reworking of overview | 21:08 |
openstackgerrit | Morgan Fainberg proposed a change to openstack-infra/config: Correct filter for apache-services temptest https://review.openstack.org/92914 | 21:09 |
clarkb | mordred: ++ | 21:09 |
*** gondoi is now known as zz_gondoi | 21:09 | |
fungi | mordred: sounds great | 21:09 |
*** mwagner_ has quit IRC | 21:10 | |
*** thomasem has quit IRC | 21:11 | |
*** aysyd has quit IRC | 21:12 | |
*** andreykurilin_ has joined #openstack-infra | 21:12 | |
morganfainberg | clarkb, thanks! | 21:13 |
fungi | heading out to dinner, but will be back soon | 21:13 |
anteaya | enjoy dinner | 21:14 |
openstackgerrit | A change was merged to openstack-infra/config: Correct filter for apache-services temptest https://review.openstack.org/92914 | 21:14 |
*** oomichi has joined #openstack-infra | 21:16 | |
*** signed8bit has quit IRC | 21:16 | |
*** mbacchi has quit IRC | 21:18 | |
openstackgerrit | K Jonathan Harker proposed a change to openstack-infra/config: Move openstack-specific config out of ::jenkins https://review.openstack.org/89708 | 21:19 |
openstackgerrit | Ben Nemec proposed a change to openstack-infra/reviewstats: Add tripleo-specs to tripleo project https://review.openstack.org/92915 | 21:20 |
*** dstanek_zzz is now known as dstanek | 21:23 | |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/publications: Made a branch for OpenStack Process Overview https://review.openstack.org/92918 | 21:24 |
harlowja | qq, just checking, is it known that paste.openstack.org returns 'Internal Server Error' :-/ | 21:24 |
harlowja | for example, http://paste.openstack.org/show/79664/ | 21:24 |
clarkb | harlowja: yes, kill your cookies | 21:24 |
harlowja | kk | 21:24 |
harlowja | thx Clabbe | 21:24 |
harlowja | clarkb | 21:24 |
clarkb | I think when the DB changed the cookie stuff got lost or corrupted | 21:24 |
clarkb | thankfully killing them client side makes things happy | 21:25 |
jesusaurus | fwiw yesterday paste.o.o gave me an error when i tried to make a private paste, i unchecked private and then it worked fine | 21:25 |
anteaya | http://paste.openstack.org/show/NnF3nvOrjdeApyk1aIyO/ | 21:26 |
anteaya | private paste seems to work for me | 21:26 |
harlowja | clarkb ya, worked, just knocked off the paste.openstack.org cookie | 21:26 |
*** e0ne has joined #openstack-infra | 21:27 | |
clarkb | fungi: Alex_Gaynor FYI I am manually triggering nodepool image builds for nodes that need new images to get the update run unittests scropt | 21:27 |
mordred | clarkb, fungi: there you go ^^ sdague you too, since I stole some things from you | 21:28 |
mordred | (well, the change several lines up) | 21:28 |
clarkb | starting with py3k precise nodes as they hit the problem | 21:28 |
sdague | mordred: man, and didn't even give me credit in the commit? :) | 21:28 |
mordred | sdague: I put you on the title page ... | 21:28 |
sdague | oh, so you did. +1 | 21:29 |
clarkb | gertty checkout is git review -d on steroids | 21:29 |
morganfainberg | clarkb, i see an apache-services tempest on a keystoneclient change! woot! :) | 21:31 |
morganfainberg | clarkb, you use linux as a desktop? os x? | 21:31 |
morganfainberg | clarkb, i'm having issues with gertty doing odd things on os x | 21:31 |
clarkb | morganfainberg: linux | 21:32 |
morganfainberg | clarkb, ah ok, if i figure out the gertty bugs for os x i'll propose fixes / log bugs on it | 21:32 |
*** derekh_ has quit IRC | 21:32 | |
*** doug-fish has left #openstack-infra | 21:32 | |
clarkb | mordred: your jobs launched per day graph looks old. It doesn't say 15k | 21:32 |
clarkb | morganfainberg: good excuse to play with storyboard too | 21:33 |
clarkb | krotscheck: I filed a gertty bug today and storyboard is shiny | 21:33 |
morganfainberg | clarkb, that was my thought :) | 21:33 |
morganfainberg | i looked at storyboard... i ... can't wait for that to be ready. | 21:33 |
clarkb | mordred: so hpcloud doesn't have a precise image anymore | 21:35 |
clarkb | mordred: are we supposed to use "partner images" now? what does that mean? | 21:36 |
mordred | clarkb: I _think_ partner images are from canonical - but I can ask? | 21:36 |
mordred | clarkb: we should finish my nodepool changes so we can stop caring | 21:37 |
*** moted has quit IRC | 21:38 | |
clarkb | mordred: jesusaurus figured it out they were renamed to add (deprecated) to the nae | 21:39 |
clarkb | mordred: yes we should but our images are already more than a week old and I double nodepool dib will happen before summit or during summit | 21:39 |
clarkb | and I really don't like have 3 week old images | 21:39 |
mordred | clarkb: yah | 21:39 |
*** smarcet has quit IRC | 21:39 | |
clarkb | mordred: fungi: so we can use the deprecated images or the partner images | 21:39 |
clarkb | if we decide to use partner images we can also use trusty | 21:39 |
clarkb | but as a consumer of partner images we have no way of knowing who isrooting us | 21:40 |
*** rlandy has quit IRC | 21:40 | |
*** michchap has quit IRC | 21:40 | |
clarkb | at least before that was relatively clear | 21:40 |
clarkb | also we need to build new images today to fix a bug | 21:40 |
mordred | jesusaurus: any chance you're on internal chat at HP and can ask someone on the nova team who the "partner" is? | 21:41 |
jesusaurus | mordred: yeah, i can ask | 21:41 |
mordred | jesusaurus: thanks. I'm not properly set up for that ATM | 21:41 |
clarkb | fwiw I don't think using the deprecated image is too terrible since our image process updates the base image | 21:42 |
jesusaurus | clarkb: right, the image is identical to the one we were using yesterday, they just appended "(deprecated)" to the name | 21:42 |
clarkb | ya ok | 21:42 |
*** moted has joined #openstack-infra | 21:43 | |
clarkb | so worst case I update the name to say (deprecated) | 21:43 |
asselin | fungi, FYI, there wasn't anything in the log files. I managed to boot both eth0 and eth1 using nova boot --nic net-id=<> -nic net-id=<> command option. However doing this would require changed to nodepool. | 21:43 |
*** xdmeng has quit IRC | 21:44 | |
*** mengxd has joined #openstack-infra | 21:44 | |
asselin | fungi, so I'll look at setting up eth1 from within the jenkins job which should be simpler. just need to get sudo access.... | 21:44 |
*** lcostantino has joined #openstack-infra | 21:45 | |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/publications: Made a branch for OpenStack Process Overview https://review.openstack.org/92918 | 21:45 |
mordred | clarkb: that should get us to nodepool at least | 21:46 |
sdague | clarkb / mordred: how are you guys feeling about adding in the custom dashboard I wrote up. The wayward reviews section has come up in a couple of contexts this week | 21:47 |
mordred | sdague: I think it's a great idea | 21:48 |
*** masayukig has joined #openstack-infra | 21:48 | |
clarkb | I am not opposed but currently juggling the image builds | 21:49 |
anteaya | I think added your dashboard would be good, sdague | 21:50 |
sdague | ok, someone in project bootstrappers needs to do it | 21:50 |
mordred | sdague: do you have the finalized-ish dashboard finished? | 21:50 |
jesusaurus | mordred: the ubuntu partner images are coming directly from canonical | 21:51 |
*** andreaf_ has joined #openstack-infra | 21:51 | |
mordred | jesusaurus: awesome. that's great to know | 21:51 |
mordred | clarkb: ^^ | 21:51 |
jesusaurus | mordred: in order to become a partner there are documents that must be signed | 21:51 |
sdague | mordred: https://etherpad.openstack.org/p/gerrit-dashboards - yes, the "Version 2 now actually working" | 21:51 |
*** UtahDave has joined #openstack-infra | 21:54 | |
*** andreaf has quit IRC | 21:54 | |
*** mriedem has quit IRC | 21:56 | |
mordred | clarkb: what if I just give sdague PB on review.o.o and let him push that dashboard himself? I'm not sure I'm going to run the commands _better_ myself | 21:56 |
lifeless | peanut butter? | 21:57 |
mordred | lifeless: you are so good at the random drop-in | 21:57 |
lifeless | mordred: I know, right? | 21:58 |
*** terryw has joined #openstack-infra | 21:58 | |
*** otherwiseguy has quit IRC | 22:00 | |
*** dkranz has joined #openstack-infra | 22:02 | |
*** e0ne has quit IRC | 22:04 | |
*** e0ne has joined #openstack-infra | 22:05 | |
*** zul has quit IRC | 22:05 | |
mordred | clarkb: also - re: publications - I think in the animation when the keystone change fails we should freeze the animation for the other changes | 22:06 |
mordred | so that we can talk about the reason we're moving it is because the changes in front of it are still running | 22:06 |
*** markmcclain1 has quit IRC | 22:06 | |
mordred | and then, once we've reparented, we can continue the lines on the other changes too | 22:06 |
mordred | I'm saying that here because I have not figured out that code yet - and in case anyone ELSE here knows how it works and agrees with me ... | 22:07 |
* mordred looks around | 22:07 | |
*** dkranz has quit IRC | 22:09 | |
*** dkranz has joined #openstack-infra | 22:10 | |
*** pdmars has quit IRC | 22:11 | |
clarkb | mordred: that code is ugh :P | 22:11 |
clarkb | but yes I think I agree | 22:11 |
clarkb | as far as sdague perms goes thats keys to the kingdom... not that I don't trust sdague | 22:11 |
*** dkranz has quit IRC | 22:13 | |
*** marcoemorais has quit IRC | 22:13 | |
openstackgerrit | Clark Boylan proposed a change to openstack-infra/config: HPCloud Precise image has a new name. https://review.openstack.org/92924 | 22:14 |
clarkb | mordred: fungi ^ | 22:14 |
sdague | I'm happy *without* keys to the kingdom, just need someone with the perms to do the thing :) | 22:14 |
clarkb | sdague: have a link to the thing you want added? | 22:14 |
clarkb | sdague: pastebin or whatever | 22:15 |
sdague | https://etherpad.openstack.org/p/gerrit-dashboards - L16 - L28 | 22:15 |
clarkb | sdague: what is a good filename for that? review-inbox? | 22:16 |
*** marcoemorais has joined #openstack-infra | 22:16 | |
sdague | works for me | 22:17 |
* clarkb relearns how to do this :) | 22:17 | |
clarkb | sdague: at https://review.openstack.org/#/admin/projects/All-Projects,dashboards | 22:18 |
clarkb | do we want review-inbox to be in the same table as important-changes? | 22:19 |
clarkb | it will look like important-changes\nimportant-changes-dashboard\nreview-inbox-dashboard | 22:19 |
pleia2 | so, I am going to miss summit :( been sick and dr says "no no no" to travel next week | 22:20 |
sdague | one sec, qa meeting | 22:20 |
*** dizquierdo has quit IRC | 22:20 | |
pleia2 | "but it's important!" "no" | 22:20 |
*** kgriffs is now known as kgriffs|afk | 22:20 | |
gothicmindfood | pleia2: bummer. (x 1,000) | 22:20 |
pleia2 | considered lying, but then she sneakily scheduled another appointment for next week ;) | 22:21 |
clarkb | silly doctors | 22:22 |
pleia2 | silly humanity | 22:22 |
*** rfolco has quit IRC | 22:23 | |
*** dims has quit IRC | 22:23 | |
*** jgrimm has quit IRC | 22:24 | |
clarkb | anteaya: zaro do you have the gerrit upgrade etherpad handy? my notes on gerrit dashboards are in that etherpad | 22:25 |
* clarkb is much more careful on production machine | 22:27 | |
*** prad__ has left #openstack-infra | 22:27 | |
*** marcoemorais has quit IRC | 22:29 | |
*** arnaud has quit IRC | 22:30 | |
*** marcoemorais has joined #openstack-infra | 22:30 | |
*** bknudson has quit IRC | 22:31 | |
sdague | pleia2: bummer :( | 22:31 |
anteaya | clarkb: looking | 22:31 |
pleia2 | sdague: yeah :( | 22:32 |
clarkb | anteaya: thanks. though I may have figured it out (I am looking at bash history on review-dev) | 22:32 |
*** maru_afk is now known as marun | 22:32 | |
anteaya | https://etherpad.openstack.org/p/gerrit_upgrade_script | 22:32 |
anteaya | https://etherpad.openstack.org/p/remaining-gerrit-upgrade-changes | 22:33 |
Alex_Gaynor | clarkb: cool (re: nodepool) | 22:33 |
*** jhesketh has quit IRC | 22:33 | |
anteaya | pleia2: no no no no | 22:33 |
anteaya | pleia2: I need you there | 22:33 |
pleia2 | anteaya: I know, I am very sad! | 22:34 |
anteaya | who am I going to be a bad influence on | 22:34 |
anteaya | mordred: I have to travel to SF to see pleia2 before november | 22:34 |
anteaya | we have to like, work on stufff, yeah that's it | 22:34 |
anteaya | oh this is horrible news | 22:35 |
anteaya | both for the fact taht you won't be there | 22:35 |
*** mwagner_ has joined #openstack-infra | 22:35 | |
anteaya | and that something is going to keep you from coming | 22:35 |
*** e0ne has quit IRC | 22:35 | |
anteaya | blarrggggghhhhhhh | 22:35 |
pleia2 | yeah :\ | 22:35 |
anteaya | I'm so sad | 22:35 |
anteaya | I'm not dealing with this well at all | 22:35 |
*** markmcclain has joined #openstack-infra | 22:36 | |
pleia2 | aw :( | 22:36 |
* pleia2 hugs anteaya | 22:36 | |
anteaya | thanks | 22:37 |
anteaya | I needed that | 22:37 |
clarkb | sdague: I don't think this dashboard will work because the foreach=${project} won't do what you expect | 22:37 |
anteaya | well at least you will have cats | 22:37 |
anteaya | you need cats | 22:37 |
clarkb | sdague: it will restrict all queries to All-Projects | 22:37 |
morganfainberg | pleia2, boo for you not making it to the summit! | 22:39 |
*** terryw has quit IRC | 22:40 | |
*** arnaud has joined #openstack-infra | 22:42 | |
sdague | clarkb: so the value of it is actually when yuo call it on nova, for instance | 22:45 |
clarkb | sdague: actually I see you would have to use the dashboard from the subprojects instead | 22:45 |
clarkb | sdague: isn't it better to just consolidate for the user? | 22:45 |
clarkb | maybe I am overthinking this. I can push it as is and we can see how it works | 22:45 |
sdague | clarkb: https://review.openstack.org/#/admin/projects/openstack/nova,dashboards | 22:45 |
clarkb | right but as a reviewer I review things in like 20 projects | 22:46 |
clarkb | I don't want to open a different dashboard for each one | 22:46 |
clarkb | I am also probably an outlier | 22:46 |
sdague | clarkb: I actually have different dashboards for groups of projects | 22:46 |
sdague | because they require different mindset | 22:46 |
anteaya | morganfainberg: yeah, she said she is going to rest now | 22:48 |
clarkb | sdague: last question. Do you want a limit:50 on wayward changes? | 22:48 |
clarkb | sdague: they other two have a limit | 22:48 |
sdague | I actually didn't want one, at least to start | 22:48 |
clarkb | ok | 22:48 |
sdague | we can tweak it over time | 22:48 |
clarkb | pushing nowish | 22:48 |
sdague | coolio | 22:48 |
EmilienM | sdague: not sure it's the right place, but I have a 500 on paste.o.o | 22:51 |
clarkb | sdague: done | 22:52 |
clarkb | EmilienM: clear your paste cookie | 22:52 |
openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Stories can now be filtered by assignee_id https://review.openstack.org/91912 | 22:52 |
mattoliverau | Morning all | 22:52 |
clarkb | mattoliverau: ohai | 22:53 |
EmilienM | clarkb: indeed | 22:53 |
clarkb | mattoliverau: you are supposed to work with sdague to get devstack multinode testing working | 22:53 |
sdague | mikal hath decreed it | 22:53 |
clarkb | mikal was kind enough to volunteer you | 22:53 |
mattoliverau | clarkb: I just woke up to an IRC notification that Mikal was talking about me | 22:53 |
mattoliverau | he's good at that :P | 22:54 |
*** dstanek is now known as dstanek_zzz | 22:54 | |
mattoliverau | sdague: Well have to meetup in Atlanta and walk me through your thoughts on the matter :) | 22:54 |
bnemec | Here's another fun Jenkins loop: https://review.openstack.org/#/c/77924/ | 22:55 |
anteaya | morning mattoliverau | 22:55 |
clarkb | bnemec: unabandon it | 22:55 |
sdague | mattoliverau: yes, I was even #actioned about that in the nova meeting :) | 22:55 |
mattoliverau | morning anteaya | 22:55 |
clarkb | bnemec: and mark it WIP instead until we get the fix in | 22:55 |
clarkb | fungi: speaking of where are we on that? | 22:55 |
bnemec | clarkb: I can't mark it WIP. That's one of the ones I have no voting at all on. | 22:55 |
clarkb | bnemec: are you core? | 22:56 |
bnemec | (also, it needs to be abandoned anyway) | 22:56 |
openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard-webclient: Switched new story modal to use typeahead project completion https://review.openstack.org/92487 | 22:56 |
bnemec | clarkb: Yes | 22:56 |
clarkb | bnemec: core should be able to unabandon and WIP | 22:56 |
fungi | clarkb: where are we on... | 22:56 |
bnemec | I was just trying to be nice by asking the submitter to abandon rather than doing it forcefully. | 22:56 |
clarkb | bnemec: right but the abandonment is causing the loop | 22:56 |
* fungi checks scrollback | 22:56 | |
mattoliverau | So now I just need to wait for mikal to tell me himself :P He is already in the states, so our timezones dont actually mesh at the moment, but at worst case I'll run into him on Sat in Altanta. | 22:56 |
bnemec | clarkb: I abandoned it to stop the loop. It started after I commented. | 22:56 |
anteaya | bnemec: unabandon let tests stop, then abandon | 22:56 |
*** dkranz has joined #openstack-infra | 22:57 | |
clarkb | fungi I thought stopping the loops meant allowing zuul to give a vote | 22:57 |
clarkb | but it can't vote on abandoned changes so it loops | 22:57 |
bnemec | I have no idea what happened here. This is the weird draft change. | 22:58 |
clarkb | OOOHHHHHHH | 22:58 |
*** andreaf_ has quit IRC | 22:58 | |
* bnemec suddenly pictures a lightbulb :-) | 22:58 | |
sdague | draft change, burn it with FIRE! | 22:59 |
bnemec | +1000 | 22:59 |
clarkb | bnemec: you commented on patchset 2 so zuul testing patchset 2 | 22:59 |
clarkb | but it cant vote on patchset 2 because it isn't the latest commit | 22:59 |
fungi | asselin: nodepool already supports setting the network ids since that's necessary for clouds using neutron networks (such as the tripleo providers we're interacting with). see the networks list at http://git.openstack.org/cgit/openstack-infra/config/tree/modules/openstack_project/templates/nodepool/nodepool.yaml.erb#n426 | 22:59 |
bnemec | Why the heck did I comment on PS 2? | 22:59 |
clarkb | so publish the draft or go drinking. I think those are the two options here (I think fungi knows of a third workaround though and we should hear what he has to say) | 22:59 |
clarkb | bnemec: because you can't comment on PS3 | 23:00 |
clarkb | because its a draft | 23:00 |
clarkb | and drafts should die in a fire | 23:00 |
*** gokrokve has quit IRC | 23:00 | |
bnemec | I'm feeling less and less polite about this chain of commits all of a sudden. My abandon finger is feeling a bit itchy. | 23:00 |
clarkb | bnemec: that will only make the looping worse | 23:01 |
clarkb | so venture forth at your own risk | 23:01 |
bnemec | Ick. I suppose I could push a new patch set to every one of them and then -2. | 23:02 |
*** markmcclain has quit IRC | 23:02 | |
bnemec | But...soooo tedious. | 23:02 |
bnemec | Oh, wait, can I do that with the inline commit message editing? | 23:02 |
clarkb | bnemec: that may work | 23:02 |
clarkb | I haven't tested it | 23:02 |
* bnemec braces for another onslaught of Gerrit spam | 23:02 | |
clarkb | it may also tell you to go away because of that draft change | 23:02 |
clarkb | draft patchsets are evil | 23:03 |
*** mengxd has quit IRC | 23:03 | |
fungi | clarkb: the merge-failed loop is a new one on me... | 23:03 |
clarkb | fungi: what about getting the requires stuff in? | 23:04 |
bnemec | Ha! -2'd so hard. | 23:04 |
clarkb | it looked like yesterday you and jeblair were working on it? | 23:04 |
greghaynes | bnemec: success? | 23:04 |
greghaynes | Was about to try and ping the author if no | 23:04 |
bnemec | greghaynes: Yes: https://review.openstack.org/#/c/77924/ | 23:04 |
fungi | DRAFTS | 23:04 |
* fungi is still catching up on scrollback | 23:04 | |
* bnemec gleefully leaves to -2 all the other drafts | 23:05 | |
*** andreykurilin_ has quit IRC | 23:05 | |
fungi | workaround for drafts is that i twiddle bits in the database to publish it for you | 23:05 |
JayF | fungi: I was just bumped from the list for bounces again \o/ | 23:05 |
*** andreykurilin_ has joined #openstack-infra | 23:05 | |
clarkb | fungi: I was trying to avoid that. I think bnemec found a workaround that is not terrible | 23:05 |
fungi | JayF: that's awesome | 23:06 |
* JayF blames DMARC | 23:06 | |
fungi | clarkb: um, yeah the requires patch landed days ago and zuul got restarted | 23:06 |
fungi | so comments on abandoned changes shouldn't cause loops | 23:07 |
clarkb | fungi: I see. So this is a new bug specifically with drafts | 23:07 |
clarkb | is it possible to make mysql s/DRAFT/NEW/ in the database when rows are updated? | 23:07 |
fungi | instead the two new loops i've seen are comments on not-the-current patchset and comments on draft changes (which may actually be the same scenario) | 23:07 |
openstackgerrit | A change was merged to openstack-infra/devstack-gate: Add qpid config https://review.openstack.org/92820 | 23:07 |
openstackgerrit | A change was merged to openstack-infra/devstack-gate: add oslo.i18n to project list https://review.openstack.org/92880 | 23:08 |
clarkb | fungi: well I thought requires fixed both | 23:08 |
clarkb | er fixed the first | 23:08 |
fungi | clarkb: the change i want to propose, though i'm unsure how to write a zuul unit test for, is to have zuul require that the patchset being potentially triggered by the comment-added event is the current patchset | 23:08 |
*** arnaud has quit IRC | 23:09 | |
clarkb | fungi: or even if it just gracefully fails | 23:09 |
clarkb | couldnt vote? oh well | 23:09 |
fungi | clarkb: "open==false" and "status==new" are change-wide, not patchset-specific (at least for the queries i've tried) so we probably need the extra conditional | 23:09 |
clarkb | ya | 23:09 |
clarkb | gerrit query has --current-patchset | 23:10 |
*** jhesketh has joined #openstack-infra | 23:10 | |
clarkb | so we can find it easily enough (assuming when a change is a draft change you get the correct number back) | 23:10 |
fungi | right, i think the patchset number is also listed in the detail returned from querying the change, which zuul already does, so it has it in that data structure | 23:11 |
jhesketh | Morning | 23:11 |
*** Alexandra_ has joined #openstack-infra | 23:11 | |
fungi | the current patchset number for the change, that is | 23:11 |
fungi | morning jhesketh. saw your key signing question in scrollback, attempted to answer it in the ml thread (since i received several similar questions) | 23:12 |
jhesketh | fungi: ah cool, thanks | 23:13 |
fungi | clarkb: so what's your take on breaking the current loop... should zuul always ignore comment-added events when the comment patchset is not the current patchset, or should that be configurable (per pipeline like require open and such)? | 23:14 |
fungi | i don't see an obvious use case for making it configurable | 23:14 |
clarkb | fungi: I actually want to look at the zuul gerrit reporter. I think simplest thing is to just gracefully halt | 23:14 |
fungi | but i could be missing something (usually am) | 23:14 |
fungi | clarkb: well, we want zuul to be able to comment even if it can't vote. unless we're now revisiting that decision | 23:15 |
bnemec | Okay, apparently my workaround only worked for that one patch. :-( | 23:15 |
clarkb | fungi: it is able to comment if it can't vote | 23:15 |
*** lcostantino has quit IRC | 23:15 | |
clarkb | thats why it is problematic. It creates a ton of comments | 23:16 |
*** andreykurilin_ has quit IRC | 23:16 | |
clarkb | fungi: oh wait | 23:16 |
clarkb | is it completely requeuing it? | 23:16 |
fungi | clarkb: right, but maybe i'm misinterpreting your suggestion to "gracefully halt" | 23:16 |
fungi | yes, it's reacting to its own comment | 23:16 |
clarkb | damnit for some reason I thought it was looping a little tighter than that | 23:17 |
*** etoews_ has joined #openstack-infra | 23:17 | |
fungi | well, for merge failures it ends up being a very tight loop | 23:17 |
clarkb | ya | 23:17 |
*** markmcclain has joined #openstack-infra | 23:17 | |
clarkb | but I thoguth it ws looping in the reporter | 23:17 |
fungi | because it doesn't take it long to figure out and leave a comment | 23:17 |
*** andreykurilin_ has joined #openstack-infra | 23:18 | |
clarkb | may just need to hardcode it | 23:18 |
clarkb | and fwiw older patchsets cannot merge so there is little value in testing them | 23:18 |
*** james_li has joined #openstack-infra | 23:19 | |
clarkb | which is why we kick them out of pipelines | 23:19 |
*** etoews has quit IRC | 23:19 | |
clarkb | so I would be in favor of a zuul event check that said if not latest patchset: continue | 23:19 |
fungi | right, that's what i'm envisioning | 23:19 |
clarkb | fungi: then the test for that would use the add event mechanism on an older patchset | 23:21 |
clarkb | fungi: shouldn't be too terrible to construct. You add a change, add a second patchset to it. Let jobs flush. Then add a new event for patchset 1 and let things flush ensure old job count = current job count | 23:21 |
fungi | oh, though if the scheduler starts checking the current patchset value, i guess we'll need to start setting it on all fake changes | 23:21 |
clarkb | ya but that happens in one place iirc | 23:22 |
fungi | isDraft: true | 23:23 |
*** marun is now known as maru_afk | 23:24 | |
*** maru_afk has quit IRC | 23:25 | |
*** marun has joined #openstack-infra | 23:25 | |
clarkb | fungi: where is that? | 23:25 |
clarkb | and is it visible to everyone? | 23:25 |
clarkb | anyways I think I have a hack | 23:25 |
fungi | ssh -p 29418 review.openstack.org gerrit query --all-approvals --comments --commit-message --current-patch-set --dependencies --files --patch-sets --submit-records 77924 | 23:26 |
fungi | that's the api call zuul uses | 23:26 |
clarkb | fungi: are you running it as zuul? | 23:26 |
fungi | as me | 23:26 |
fungi | so i'm possibly seeing more | 23:26 |
clarkb | I would double check with zuul creds | 23:26 |
*** marun has quit IRC | 23:26 | |
*** marun has joined #openstack-infra | 23:27 | |
*** andreykurilin_ has quit IRC | 23:27 | |
*** jhesketh has quit IRC | 23:27 | |
fungi | as for the automagic setting draft to new in the table, probably not. at least in 2.4.x there were several tables which needed touching to un-draft a change | 23:28 |
fungi | maybe 2.8 is improved in that regard though | 23:28 |
*** mburned is now known as mburned_out | 23:28 | |
openstackgerrit | Khai Do proposed a change to openstack-infra/config: puppetize installation of gerrit third party plugins https://review.openstack.org/91193 | 23:29 |
*** UtahDave has quit IRC | 23:29 | |
lifeless | I thought draft was going away? | 23:29 |
clarkb | lifeless: when gerrit 2.9 happens | 23:30 |
fungi | lifeless: as soon as we can make it happen | 23:30 |
fungi | clarkb: so it looks like currentPatchSet.number will contain the latest patchset number | 23:32 |
fungi | sampling the event stream now to see where the comment-added patchset number ends up | 23:33 |
*** masayukig has quit IRC | 23:33 | |
clarkb | fungi: in zuul the Change class has self.is_current_patchset | 23:34 |
clarkb | so we can just check that presumably | 23:34 |
fungi | oh! perfect | 23:34 |
clarkb | and it looks like the test suite already handles it properly so now I am trying to add a test | 23:34 |
fungi | and yeah, comment-added events in the stream have patchSet.number if we end up needing it | 23:34 |
fungi | i do find it interesting that the gerrit webui won't show draft patchsets to my account but gerrit queries will show they were uploaded | 23:35 |
*** praneshp has quit IRC | 23:35 | |
fungi | just more fodder for "gerrit drafts are a failure" | 23:35 |
*** james_li has quit IRC | 23:36 | |
openstackgerrit | Khai Do proposed a change to openstack-infra/config: puppetize installation of gerrit third party plugins https://review.openstack.org/91193 | 23:37 |
*** morganfainberg is now known as morganfainberg_Z | 23:38 | |
*** jhesketh has joined #openstack-infra | 23:38 | |
*** dstanek_zzz is now known as dstanek | 23:39 | |
*** maxbit has joined #openstack-infra | 23:41 | |
*** mrodden1 has quit IRC | 23:42 | |
*** gokrokve has joined #openstack-infra | 23:43 | |
*** praneshp has joined #openstack-infra | 23:44 | |
clarkb | fungi: any chance you can lookup what a comment-added json blob from gerrit looks like? I htink I have everything but the approvals section | 23:45 |
*** arnaud has joined #openstack-infra | 23:45 | |
clarkb | fungi: need an event for the test | 23:45 |
fungi | oh, i had one. just a sec | 23:45 |
fungi | clarkb: http://paste.openstack.org/show/79683/\ | 23:47 |
*** thedodd has quit IRC | 23:47 | |
fungi | (trailing backslash at no extra charge) | 23:47 |
*** zns has quit IRC | 23:47 | |
clarkb | perfect thanks | 23:47 |
fungi | i really need a ~1cm free radius around my return key | 23:47 |
*** masayukig has joined #openstack-infra | 23:48 | |
clarkb | huh that doesn't match their docs | 23:48 |
fungi | because that's te one key backspace won't undo in irc ;) | 23:48 |
clarkb | which is lovely | 23:48 |
fungi | yeah, that was captured straight from review.openstack.org's stream | 23:48 |
*** morganfainberg_Z is now known as morganfainberg | 23:49 | |
fungi | ssh -p 29418 review.openstack.org gerrit stream-events | 23:49 |
*** pcrews has quit IRC | 23:49 | |
clarkb | yeah | 23:49 |
fungi | so either their docs are lagging behind or their code is | 23:49 |
*** dstanek is now known as dstanek_zzz | 23:49 | |
clarkb | I think the docs | 23:50 |
openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard-webclient: Textareas now autoresize their height. https://review.openstack.org/92939 | 23:50 |
krotscheck | clarkb: Finally got around to that thing you wanted. | 23:50 |
*** hogepodge has quit IRC | 23:51 | |
StevenK | fungi: If I miss Enter, I tend to hit Shift instead, which is handy. | 23:52 |
fungi | StevenK: my problem is a partial miss where i hit \ or ] or ' at almost the same time as return but just barely before | 23:54 |
*** markmcclain has quit IRC | 23:54 | |
clarkb | krotscheck: woot | 23:54 |
fungi | at least my new keyboard doesn't have backspace and return adjacent. that was downright terrible | 23:54 |
clarkb | fungi: so I can get it to pass my assertions but not a test suite level assertion | 23:54 |
fungi | hrm | 23:54 |
clarkb | fungi: I think I am going to push my code as is and people can hack it | 23:54 |
clarkb | but it fails | 23:54 |
clarkb | actually hold on | 23:55 |
clarkb | no that wasn't it | 23:56 |
*** atiwari has quit IRC | 23:56 | |
*** flaper87 is now known as flaper87|afk | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!