*** dims has joined #openstack-infra | 00:01 | |
*** atiwari has quit IRC | 00:09 | |
*** wenlock_ has quit IRC | 00:16 | |
*** asselin has quit IRC | 00:20 | |
*** hemna is now known as hemna_ | 00:21 | |
anteaya | the delting nodes went away | 00:24 |
---|---|---|
anteaya | they just all disappeared | 00:24 |
anteaya | who did something? | 00:24 |
anteaya | building and in use appear to be around where they were before | 00:25 |
anteaya | but the purple team all went home all of a sudden | 00:25 |
*** salv-orlando has quit IRC | 00:25 | |
*** salv-orlando has joined #openstack-infra | 00:26 | |
anteaya | deleting nodes | 00:27 |
*** medieval1 has quit IRC | 00:29 | |
*** medieval1 has joined #openstack-infra | 00:30 | |
*** sarob__ has quit IRC | 00:30 | |
*** sarob_ has joined #openstack-infra | 00:31 | |
anteaya | it was right at 0:00 utc | 00:31 |
anteaya | the disappearance of the deleting nodes | 00:31 |
*** harlowja has joined #openstack-infra | 00:31 | |
*** gyee has quit IRC | 00:34 | |
*** medieval1 has quit IRC | 00:34 | |
*** sarob_ has quit IRC | 00:35 | |
*** CaptTofu_ has quit IRC | 00:35 | |
*** CaptTofu_ has joined #openstack-infra | 00:35 | |
*** harlowja has quit IRC | 00:36 | |
*** CaptTofu_ has quit IRC | 00:39 | |
*** CaptTofu_ has joined #openstack-infra | 00:39 | |
*** harlowja has joined #openstack-infra | 00:40 | |
openstackgerrit | K Jonathan Harker proposed a change to openstack-infra/config: Fix nodepool instance hostnames https://review.openstack.org/98561 | 00:40 |
*** matjazp has joined #openstack-infra | 00:41 | |
jesusaurus | clarkb: we had the logic backwards in the fix_hostname script ^^ | 00:41 |
clarkb | fungi: mordred sdague: ok cluster is rebalanced I am stopping ES on 01 now | 00:41 |
clarkb | and calling it a day | 00:41 |
clarkb | jesusaurus: that looks wrong | 00:43 |
*** ArxCruz has quit IRC | 00:43 | |
clarkb | jesusaurus: you want -n | 00:43 |
clarkb | elasticsearch01 does not have an ES daemon running on it now | 00:45 |
clarkb | lets see what this looks like tomorrow | 00:45 |
*** mmaglana has quit IRC | 00:46 | |
*** matjazp has quit IRC | 00:46 | |
*** CaptTofu_ has quit IRC | 00:46 | |
*** mmaglana has joined #openstack-infra | 00:46 | |
jesusaurus | clarkb: sorry, im debugging some weird error in my nodepool setup | 00:47 |
openstackgerrit | K Jonathan Harker proposed a change to openstack-infra/config: Fix nodepool instance hostnames https://review.openstack.org/98561 | 00:51 |
*** mmaglana has quit IRC | 00:51 | |
openstackgerrit | Alexandre Viau proposed a change to openstack-infra/config: Added the Surveil project to gerritbot and stackforge config https://review.openstack.org/99746 | 00:52 |
*** CaptTofu_ has joined #openstack-infra | 00:55 | |
*** HenryG has quit IRC | 00:55 | |
*** marcoemorais has quit IRC | 00:55 | |
*** CaptTofu_ has quit IRC | 00:56 | |
*** CaptTofu_ has joined #openstack-infra | 00:57 | |
*** CaptTofu_ has quit IRC | 01:01 | |
*** harlowja has quit IRC | 01:06 | |
*** HenryG has joined #openstack-infra | 01:12 | |
*** Ryan_Lane1 has quit IRC | 01:12 | |
*** sarob_ has joined #openstack-infra | 01:13 | |
*** harlowja has joined #openstack-infra | 01:13 | |
*** mriedem has joined #openstack-infra | 01:14 | |
anteaya | the check queue just disappeared, we are down to 6 in check now | 01:18 |
anteaya | can't remember what it was but I had thought it was around 100 | 01:19 |
anteaya | I could be imagining things though | 01:19 |
*** timrc is now known as timrc-afk | 01:19 | |
*** dims has quit IRC | 01:21 | |
*** harlowja has quit IRC | 01:28 | |
*** timrc-afk is now known as timrc | 01:35 | |
*** zzelle has quit IRC | 01:37 | |
*** zns has joined #openstack-infra | 01:37 | |
*** zns_ has joined #openstack-infra | 01:40 | |
*** matjazp has joined #openstack-infra | 01:41 | |
*** zns has quit IRC | 01:42 | |
*** CaptTofu_ has joined #openstack-infra | 01:44 | |
*** CaptTofu_ has quit IRC | 01:44 | |
*** CaptTofu_ has joined #openstack-infra | 01:44 | |
*** matjazp has quit IRC | 01:46 | |
*** dims has joined #openstack-infra | 01:47 | |
*** jhesketh has quit IRC | 01:48 | |
*** basha has joined #openstack-infra | 01:49 | |
*** CaptTofu_ has quit IRC | 01:49 | |
*** mmaglana has joined #openstack-infra | 01:50 | |
*** dims has quit IRC | 01:52 | |
*** sarob_ has quit IRC | 01:54 | |
*** lcostantino has quit IRC | 01:54 | |
*** sarob_ has joined #openstack-infra | 01:54 | |
*** sarob_ has quit IRC | 01:59 | |
*** arnaud has quit IRC | 02:00 | |
*** mriedem has quit IRC | 02:04 | |
*** cody-somerville has joined #openstack-infra | 02:04 | |
*** harlowja_at_home has joined #openstack-infra | 02:09 | |
*** salv-orlando has quit IRC | 02:15 | |
*** harlowja has joined #openstack-infra | 02:15 | |
*** cody-somerville has quit IRC | 02:17 | |
*** zns_ has quit IRC | 02:21 | |
*** e0ne has quit IRC | 02:26 | |
*** medieval1 has joined #openstack-infra | 02:31 | |
*** medieval1 has joined #openstack-infra | 02:31 | |
*** jhesketh has joined #openstack-infra | 02:33 | |
*** chuckC has quit IRC | 02:35 | |
*** medieval1 has quit IRC | 02:37 | |
*** matjazp has joined #openstack-infra | 02:42 | |
*** nati_ueno has quit IRC | 02:46 | |
*** matjazp has quit IRC | 02:47 | |
*** plars has joined #openstack-infra | 02:47 | |
*** dims has joined #openstack-infra | 02:48 | |
*** dims has quit IRC | 02:53 | |
*** CaptTofu_ has joined #openstack-infra | 03:00 | |
*** slamont has quit IRC | 03:10 | |
*** mmitchell_ has quit IRC | 03:11 | |
*** slamont has joined #openstack-infra | 03:13 | |
*** zns has joined #openstack-infra | 03:15 | |
*** mmitchell_ has joined #openstack-infra | 03:17 | |
*** sweston has joined #openstack-infra | 03:18 | |
*** sweston has quit IRC | 03:23 | |
*** harlowja_at_home has quit IRC | 03:28 | |
*** CaptTofu_ has quit IRC | 03:32 | |
*** matjazp has joined #openstack-infra | 03:43 | |
*** matjazp has quit IRC | 03:47 | |
*** dims has joined #openstack-infra | 03:49 | |
*** rwsu has quit IRC | 03:49 | |
*** pcrews has quit IRC | 03:51 | |
*** harlowja_at_home has joined #openstack-infra | 03:53 | |
*** dims has quit IRC | 03:54 | |
*** harlowja is now known as harlowja_away | 03:58 | |
*** gnuoy has quit IRC | 04:00 | |
*** jamespage has quit IRC | 04:00 | |
*** gnuoy has joined #openstack-infra | 04:00 | |
*** jamespage has joined #openstack-infra | 04:00 | |
*** timrc is now known as timrc-afk | 04:11 | |
*** cody-somerville has joined #openstack-infra | 04:35 | |
*** cody-somerville has quit IRC | 04:41 | |
*** matjazp has joined #openstack-infra | 04:44 | |
*** dims has joined #openstack-infra | 04:46 | |
*** zns has quit IRC | 04:47 | |
*** matjazp has quit IRC | 04:48 | |
*** zns has joined #openstack-infra | 04:51 | |
*** dims has quit IRC | 04:51 | |
*** mmaglana has quit IRC | 04:51 | |
*** mmaglana has joined #openstack-infra | 04:52 | |
*** mmaglana has quit IRC | 04:57 | |
openstackgerrit | A change was merged to openstack/requirements: Adding ldappool module dependency as needed by keystone bug #1320997. https://review.openstack.org/95842 | 05:09 |
uvirtbot | Launchpad bug 1320997 in keystone "Common Ldap handler connection pooling" [Medium,In progress] https://launchpad.net/bugs/1320997 | 05:09 |
*** basha has quit IRC | 05:12 | |
*** harlowja_at_home has quit IRC | 05:16 | |
*** harlowja_at_home has joined #openstack-infra | 05:16 | |
*** harlowja_at_home has quit IRC | 05:17 | |
*** harlowja_at_home has joined #openstack-infra | 05:17 | |
*** wenlock_ has joined #openstack-infra | 05:17 | |
*** praneshp has joined #openstack-infra | 05:27 | |
*** wenlock_ has quit IRC | 05:28 | |
*** marcoemorais has joined #openstack-infra | 05:29 | |
*** marcoemorais has quit IRC | 05:29 | |
*** harlowja_at_home has quit IRC | 05:40 | |
*** zns has quit IRC | 05:43 | |
*** matjazp has joined #openstack-infra | 05:44 | |
*** matjazp has quit IRC | 05:49 | |
*** basha has joined #openstack-infra | 05:55 | |
*** basha has quit IRC | 06:00 | |
*** Longgeek has joined #openstack-infra | 06:06 | |
*** wenlock_ has joined #openstack-infra | 06:06 | |
*** alkari has quit IRC | 06:07 | |
*** Longgeek has quit IRC | 06:10 | |
*** Longgeek has joined #openstack-infra | 06:10 | |
*** praneshp has quit IRC | 06:15 | |
*** Longgeek has quit IRC | 06:15 | |
*** Longgeek has joined #openstack-infra | 06:15 | |
*** Longgeek has quit IRC | 06:19 | |
*** arnaud has joined #openstack-infra | 06:24 | |
*** Longgeek has joined #openstack-infra | 06:27 | |
*** wenlock_ has quit IRC | 06:30 | |
*** matjazp has joined #openstack-infra | 06:31 | |
*** dims has joined #openstack-infra | 06:49 | |
*** matjazp has quit IRC | 06:52 | |
*** dims has quit IRC | 06:54 | |
*** ihrachyshka has joined #openstack-infra | 06:56 | |
*** ihrachyshka has quit IRC | 06:57 | |
*** _nadya_ has joined #openstack-infra | 06:57 | |
*** arnaud has quit IRC | 06:59 | |
*** arnaud has joined #openstack-infra | 07:01 | |
*** Ryan_Lane has quit IRC | 07:09 | |
*** e0ne has joined #openstack-infra | 07:09 | |
*** e0ne has quit IRC | 07:10 | |
*** _nadya_ has quit IRC | 07:13 | |
*** arnaud has quit IRC | 07:14 | |
*** penguinRaider has joined #openstack-infra | 07:15 | |
*** zns has joined #openstack-infra | 07:18 | |
*** tchorizo is now known as tchaypo | 07:29 | |
*** fbo_away is now known as fbo | 07:34 | |
*** andreykurilin_ has joined #openstack-infra | 07:34 | |
*** rcarrill` has joined #openstack-infra | 07:53 | |
*** rcarrillocruz has quit IRC | 07:54 | |
*** zhiyan_ is now known as zhiyan | 08:05 | |
*** trinaths has joined #openstack-infra | 08:09 | |
*** saper has quit IRC | 08:23 | |
*** trinaths has quit IRC | 08:25 | |
*** CaptTofu_ has joined #openstack-infra | 08:28 | |
*** Longgeek has quit IRC | 08:31 | |
*** CaptTofu_ has quit IRC | 08:33 | |
*** Longgeek has joined #openstack-infra | 08:42 | |
*** willroberts has joined #openstack-infra | 08:45 | |
*** _nadya_ has joined #openstack-infra | 08:51 | |
*** _nadya_ has quit IRC | 09:06 | |
*** basha has joined #openstack-infra | 09:10 | |
*** andreykurilin_ has quit IRC | 09:10 | |
*** zhiyan is now known as zhiyan_ | 09:28 | |
*** _nadya_ has joined #openstack-infra | 09:38 | |
*** andreykurilin_ has joined #openstack-infra | 09:39 | |
*** salv-orlando has joined #openstack-infra | 09:39 | |
*** _nadya_ has quit IRC | 09:44 | |
*** dims has joined #openstack-infra | 09:53 | |
*** dims has quit IRC | 09:57 | |
*** sarob_ has joined #openstack-infra | 10:00 | |
*** sarob_ has quit IRC | 10:05 | |
*** freyes has joined #openstack-infra | 10:08 | |
*** afazekas has quit IRC | 10:11 | |
*** kmartin has quit IRC | 10:19 | |
openstackgerrit | Boris Pavlovic proposed a change to openstack-infra/config: Publish osprofiler on pypy and add check for requirments https://review.openstack.org/100052 | 10:48 |
*** salv-orlando has quit IRC | 10:49 | |
*** dims has joined #openstack-infra | 10:54 | |
*** dims has quit IRC | 10:58 | |
*** salv-orlando has joined #openstack-infra | 10:59 | |
*** sarob_ has joined #openstack-infra | 11:00 | |
*** sarob_ has quit IRC | 11:04 | |
*** CaptTofu_ has joined #openstack-infra | 11:31 | |
*** andreykurilin_ has quit IRC | 11:52 | |
*** andreykurilin_ has joined #openstack-infra | 11:53 | |
*** dims has joined #openstack-infra | 11:55 | |
*** salv-orlando has quit IRC | 11:59 | |
*** dims has quit IRC | 12:00 | |
*** sarob_ has joined #openstack-infra | 12:00 | |
*** mugsie has quit IRC | 12:03 | |
*** sarob_ has quit IRC | 12:05 | |
*** timrc-afk is now known as timrc | 12:46 | |
*** basha has quit IRC | 12:48 | |
*** dims has joined #openstack-infra | 12:52 | |
*** sarob_ has joined #openstack-infra | 13:00 | |
*** sarob_ has quit IRC | 13:04 | |
*** basha has joined #openstack-infra | 13:08 | |
openstackgerrit | Roger Luethi proposed a change to openstack-infra/config: Add manuals-jobs for training-guides https://review.openstack.org/100055 | 13:19 |
openstackgerrit | A change was merged to openstack-infra/devstack-gate: don't delete grenade logs https://review.openstack.org/99396 | 13:29 |
openstackgerrit | Roger Luethi proposed a change to openstack-infra/config: Add manuals-jobs for training-guides https://review.openstack.org/100056 | 13:29 |
*** sarob_ has joined #openstack-infra | 13:37 | |
*** penguinRaider has quit IRC | 13:39 | |
*** andreykurilin_ has quit IRC | 13:41 | |
*** sarob_ has quit IRC | 13:42 | |
*** penguinRaider has joined #openstack-infra | 13:52 | |
*** zzelle has joined #openstack-infra | 13:54 | |
*** basha has quit IRC | 13:54 | |
*** zns has quit IRC | 14:08 | |
*** salv-orlando has joined #openstack-infra | 14:08 | |
*** zns has joined #openstack-infra | 14:13 | |
*** dims has quit IRC | 14:20 | |
*** mriedem has joined #openstack-infra | 14:27 | |
*** freyes has quit IRC | 14:30 | |
*** andreykurilin_ has joined #openstack-infra | 14:31 | |
*** sarob_ has joined #openstack-infra | 14:38 | |
*** zns has quit IRC | 14:39 | |
*** dims has joined #openstack-infra | 14:39 | |
*** timrc is now known as timrc-afk | 14:42 | |
*** sarob_ has quit IRC | 14:43 | |
*** CaptTofu_ has quit IRC | 14:48 | |
*** CaptTofu_ has joined #openstack-infra | 14:48 | |
*** CaptTofu_ has quit IRC | 14:53 | |
*** sunrenjie6 has joined #openstack-infra | 14:59 | |
mordred | mattoliverau: I disagree with your comment on 98656 - the exim class looks like it protects against empty list.... | 15:06 |
*** nati_ueno has joined #openstack-infra | 15:11 | |
*** penguinRaider has quit IRC | 15:11 | |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/config: Run stackalytics in infra https://review.openstack.org/98656 | 15:12 |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/config: Align exim module parameter name with the tree https://review.openstack.org/100059 | 15:12 |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/config: Make the fallback sysadmins value the same https://review.openstack.org/100060 | 15:12 |
mordred | mattoliverau: but I did fix the thing you pointed out differently anyway - so thanks | 15:12 |
*** mattoliverau has quit IRC | 15:14 | |
*** pcrews has joined #openstack-infra | 15:15 | |
*** adalbas has joined #openstack-infra | 15:22 | |
*** saper has joined #openstack-infra | 15:22 | |
*** salv-orlando has quit IRC | 15:26 | |
fungi | mordred: i'm not really here but since you are, any ideas on our best course of action in light of https://mail.python.org/pipermail/distutils-sig/2014-June/024478.html ? is it sane/possible for us to blacklist setuptools versions in our requirements lists? should we consider that we can't know the state of mirrors managed by downstream users? does someone need to push the setuptools maintainer for a | 15:31 |
fungi | more downstream-considerate solution wrt version numbers? | 15:31 |
mordred | O M G | 15:31 |
fungi | dstufft: ^ (if you're around) | 15:31 |
fungi | this basically boils down to a case of "version numbers going backward" | 15:32 |
mordred | fungi: well, a) if they've removed things from pypi I think we shoudl remove them from our mirror to be sure | 15:32 |
*** andreykurilin_ has quit IRC | 15:32 | |
mordred | fungi: but we don't really have a mechanism to do any version manip of setuptools itself | 15:32 |
fungi | yeah, we can remove them from *our* mirror, but that only goes so far (though fwiw it at least solves our py3k unit testing problem for swiftclient et al) | 15:33 |
mordred | well, I'm not sure it's our job to fix the world of python | 15:33 |
mordred | if someone does a COMPLETELY IRRESPONSIBLE thing like that | 15:33 |
*** superdan is now known as dansmith | 15:33 | |
mordred | I mean, other than publically shaming them, there isn't much we can do | 15:33 |
fungi | re-releasing 3.8.1 as 4.2 or 5.0 or something would have made much more sense, in my opinion | 15:34 |
mordred | correct action on his part would be to release a 4.1 with the same contents as 3.8.1 | 15:34 |
mordred | yeah | 15:34 |
mordred | _then_ he could remove the other 4.x stuff safely | 15:34 |
mordred | fungi: well, I'm going to go blow away setuptools 4 stuff from our mirror | 15:35 |
fungi | thanks! | 15:35 |
mordred | of course, all of our current slaves and their slave image will still have 4.x | 15:36 |
mordred | so this is going to take a bit to cycle out | 15:36 |
fungi | i really don't comprehend the reason for rolling version numbers backward though. are we running into a global version number shortage and need to conserve them? | 15:36 |
mordred | no clue | 15:36 |
fungi | anyway, i'm short on free time to devote to public shaming, but figured i'd bring the situation to your attention | 15:38 |
mordred | kk. thanks | 15:38 |
*** dims has quit IRC | 15:46 | |
mordred | fungi: btw - the mirror on mirror26 doesn't work | 15:46 |
mordred | and looks like it never has in the history of the exitence of the node | 15:47 |
mordred | there are no packages in its cache or its mirror dir | 15:47 |
*** julim has quit IRC | 15:48 | |
mordred | why do we install python_requests from packages on our slaves? | 15:49 |
*** wenlock_ has joined #openstack-infra | 15:49 | |
mordred | same questino for python-lxml and python-magic and python-zmq | 15:50 |
mordred | I'm pretty sure that's all a waste of time | 15:50 |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/config: Add support for disk-image-builder in nodepool https://review.openstack.org/88479 | 15:53 |
*** andreykurilin_ has joined #openstack-infra | 15:56 | |
openstackgerrit | Chris Krelle proposed a change to openstack-infra/config: Move check-tripleo-ironic-undercloud-precise check queue https://review.openstack.org/100063 | 15:56 |
*** adalbas has quit IRC | 15:57 | |
NobodyCam | morning mordred :) | 15:58 |
NobodyCam | and fungi :) | 15:59 |
mordred | morning NobodyCam | 15:59 |
NobodyCam | hope that patch is correct :-p | 15:59 |
*** e0ne has joined #openstack-infra | 15:59 | |
NobodyCam | so who got patch 100000 ... /me goes to look | 16:00 |
mordred | NobodyCam: greghaynes | 16:00 |
NobodyCam | lol | 16:00 |
mordred | NobodyCam: you don't need the noops | 16:00 |
mordred | other than that, it looks good | 16:00 |
NobodyCam | :) nix the section or just the noop | 16:01 |
mordred | nix the section | 16:01 |
NobodyCam | :) | 16:01 |
openstackgerrit | Chris Krelle proposed a change to openstack-infra/config: Move check-tripleo-ironic-undercloud-precise check queue https://review.openstack.org/100063 | 16:03 |
NobodyCam | ty mordred :) | 16:04 |
*** andreykurilin_ has quit IRC | 16:08 | |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/config: Fix mirror build on py26 https://review.openstack.org/100064 | 16:12 |
*** dims has joined #openstack-infra | 16:13 | |
*** e0ne has quit IRC | 16:17 | |
mordred | also - I had an old file - so I have answers to why we install those python pacakges from above | 16:17 |
*** dims has quit IRC | 16:17 | |
*** e0ne has joined #openstack-infra | 16:17 | |
mordred | morganfainberg: ping | 16:22 |
mordred | clarkb, morganfainberg: any idea why we're installing mod_wsgi on our jenkins slaves? it seems like devstack should be installing that for the apache keystone tests and I can't think of any other reason to have it | 16:23 |
*** dims has joined #openstack-infra | 16:26 | |
*** yamahata has quit IRC | 16:27 | |
*** sunrenjie6 has quit IRC | 16:28 | |
*** sarob_ has joined #openstack-infra | 16:40 | |
*** e0ne has quit IRC | 16:40 | |
*** e0ne has joined #openstack-infra | 16:41 | |
*** sweston has joined #openstack-infra | 16:42 | |
*** arnaud has joined #openstack-infra | 16:42 | |
*** sunrenjie6 has joined #openstack-infra | 16:47 | |
*** wenlock_ has quit IRC | 16:47 | |
dstufft | fungi: mordred sigh | 16:47 |
dstufft | fungi: mordred I'll talk to jaraco | 16:47 |
fungi | mordred: on the mirror26 fix, did you confirm /usr/local/bin is in the shell path jenkins uses to run that? | 16:49 |
*** basha has joined #openstack-infra | 16:50 | |
dstufft | setuptools is getting a 5.0 w/ the contents of 3.8.1 | 16:50 |
*** nati_ueno has quit IRC | 16:50 | |
dstufft | mordred: fungi ^ | 16:50 |
fungi | dstufft: yay--thanks!!! | 16:51 |
dstufft | fungi: mordred FWIW the officially recommended mirroring client (bandersnatch) is perfectly capable of handling deleted files. | 16:53 |
dstufft | Not sure if devpi can | 16:53 |
*** sunrenjie6 has quit IRC | 16:53 | |
dstufft | techincally the mirroring PEP says you have to delete the files | 16:53 |
dstufft | but i suspect y'all aren't the only ones who don't have that implemented | 16:54 |
*** sunrenjie6 has joined #openstack-infra | 16:54 | |
dstufft | (Also Arch already has 4.0.1 in their archives, and I'm not sure a linux distro can handle going backwards other than with an epoch) | 16:54 |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/config: Move ansible things into a module https://review.openstack.org/97032 | 16:55 |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/config: Add playbook for cleaning workspaces https://review.openstack.org/96646 | 16:55 |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/config: Add mirror management playbooks https://review.openstack.org/100066 | 16:55 |
mordred | dstufft: yeah. so that's the thing | 16:55 |
mordred | it's not about the mirroring technology | 16:55 |
mordred | it's about the backwards versions | 16:55 |
mordred | because of people who may have installed something | 16:55 |
mordred | doesn't bother me that he deleted the files | 16:56 |
mordred | it bothers me that the "fix" is a lower version than the broken thing | 16:56 |
dstufft | yea | 16:56 |
dstufft | FWIW if I'm not around, his name is jaraco on Freenode and he hangs out in #pypa-dev. He's not always there but he's the setuptools guy | 16:56 |
mordred | fungi: I did not | 16:56 |
mordred | dstufft: awesome | 16:57 |
dstufft | he's a nice guy | 16:57 |
mordred | dstufft: I think I remember him being nice from pycon | 16:57 |
mordred | but I don't know him and I'd be slightly reluctant to give him release advice out of the clear blue - I don't want MORE people in the python world thinking I'm a jerk than already do | 16:58 |
*** sunrenjie6 has quit IRC | 16:58 | |
mordred | fungi: how would I verify that? just su - jenkins and then echo $PATH? or does jenkins override path? | 16:58 |
dstufft | mordred: yea understood :) Just saying in case there's ever something that is breaking stuff real bad and I'm not around (crazy thought right? I wouldn't be on the computer) | 16:59 |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/config: Remove old salt references from the puppet https://review.openstack.org/96362 | 17:00 |
mordred | dstufft: ah - awesome. appreciate that | 17:00 |
mordred | dstufft: also, why would you not be on the computer? | 17:00 |
dstufft | mordred: well sometimes the power goes out | 17:01 |
*** otter768 has joined #openstack-infra | 17:01 | |
mordred | dstufft: that sounds terrible | 17:01 |
dstufft | it is! | 17:01 |
dstufft | it was waaaay worse growing up though | 17:01 |
*** Longgeek has quit IRC | 17:01 | |
dstufft | I grew up like a super rural area, I lived half way up a mountain | 17:02 |
dstufft | we lost power for *days* when it went out | 17:02 |
dstufft | here it's like... an hour? | 17:02 |
mordred | so did fungi | 17:02 |
fungi | mordred: not sure--mostly just curious. i think maybe the jenkins webui mentions the path it adds to the environment for workers, but i'm not certain of that | 17:02 |
mordred | I wonder what it is about this channel that attracts mountain people... | 17:02 |
mordred | fungi: yes. | 17:03 |
fungi | mordred: dstufft: yeah, in the winter we could go without power for a week or two in storms, so we were used to keeping supplies, hauling water by hand (electric pumps aren't so helpful in an outage), et cetera | 17:03 |
mordred | fungi: https://jenkins.openstack.org/job/periodic-mirror-python26/60/injectedEnvVars/? | 17:03 |
fungi | mordred: lgtm! | 17:04 |
mordred | dstufft: dare I ask why redhat thinks it's the right thing for "pip install $foo" to install things in /usr/bin and not /usr/local/bin? | 17:05 |
mordred | fungi: so, as I make more ansible playbooks | 17:05 |
dstufft | fungi: yes we had the electric well pump too | 17:05 |
mordred | fungi: it's amusing me how close the syntax is to our jjb macros | 17:05 |
dstufft | mordred: because it's where Python default to doing it | 17:05 |
mordred | fungi: like, it's REALLY close | 17:05 |
*** Longgeek has joined #openstack-infra | 17:05 | |
dstufft | mordred: Debian adds a patch that makes pip go to /usr/local/bin | 17:05 |
fungi | mordred: convergent evolution | 17:06 |
mordred | dstufft: why does python think third-party things should default to /usr/bin/ when make install has, by default, installed into /usr/local for about 30 years? | 17:06 |
* mordred should maybe just give up on this one | 17:07 | |
mordred | fungi: https://review.openstack.org/#/c/100066/1/modules/openstack_project/files/ansible/run_mirror.yaml | 17:07 |
mordred | fungi: look at how similar that is to: | 17:07 |
*** paul-- has quit IRC | 17:07 | |
dstufft | mordred: Python doesn't think *third party* things, Python has no concept of Third party vs Linux distro stuff, it has a bin directory and it uses a prefix, the Linux Distros set the prefix to be /usr/ because Python is part of the OS | 17:07 |
mordred | fungi: https://review.openstack.org/#/c/100066/1/modules/openstack_project/files/ansible/run_mirror.yaml | 17:07 |
dstufft | so Python knows it's bin dir is /usr/bin/ | 17:08 |
fungi | neat | 17:08 |
dstufft | becuase that's what it's configured to use | 17:08 |
* fungi disappears to run more errands | 17:08 | |
mordred | dstufft: ah. gotcha | 17:08 |
*** dims has quit IRC | 17:08 | |
dstufft | Debian adds a patch that makes distutils default to /usr/local/ and add a flag to switch it to back to /usr/ which they use for their own packages | 17:08 |
mordred | dstufft: it makes total sense and I can see the logic - and it still is just super strange to me that anything similar to "make install" would put anything in /usr by default without adding arguments | 17:09 |
mordred | but that may just be from my many years of doing c things | 17:09 |
dstufft | mordred: well the thing is, your general C thing is it's own seperate thing, you're not normally installing a C thing *into* another C thing | 17:10 |
mordred | dstufft: yah | 17:10 |
dstufft | but Python will probably adopt something similar to Debian's solution at some point | 17:10 |
dstufft | I plan to write a PEP for it | 17:10 |
mordred | dstufft: well - I can TOTALLY see the install into /usr/lib/python2.7/site-packages | 17:10 |
dstufft | I just haven't yet because it's not that big of a deal | 17:10 |
mordred | like, that makes 100% sense to me for exactly that reason | 17:11 |
mordred | it's purely the script/bindir installation that's strange | 17:11 |
mordred | dstufft: I would be more than happy to help with that PEP - and also, yeah - not urgent :) | 17:12 |
mordred | fungi, jhesketh, zaro: so - with the large amount of similarity between the ansible playbooks and the jjb macros - I wonder if there is an opportunity to leverage anything directly | 17:12 |
mordred | fungi, jhesketh, zaro: like, both are descriptions of how to run tasks | 17:13 |
*** mattoliverau has joined #openstack-infra | 17:13 | |
*** otherwiseguy has joined #openstack-infra | 17:16 | |
*** paul-- has joined #openstack-infra | 17:18 | |
openstackgerrit | A change was merged to openstack-dev/hacking: Updated from global requirements https://review.openstack.org/100037 | 17:22 |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/config: Remove salt https://review.openstack.org/96361 | 17:28 |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/config: Remove old salt references from the puppet https://review.openstack.org/96362 | 17:28 |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/config: Notify in IRC when puppet run fails https://review.openstack.org/96519 | 17:30 |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/config: Use ansible instead of direct ssh calls https://review.openstack.org/87821 | 17:30 |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/config: Add mirror management playbooks https://review.openstack.org/100066 | 17:30 |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/config: Move ansible things into a module https://review.openstack.org/97032 | 17:30 |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/config: Remove salt https://review.openstack.org/96361 | 17:30 |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/config: Remove old salt references from the puppet https://review.openstack.org/96362 | 17:30 |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/config: Add playbook for cleaning workspaces https://review.openstack.org/96646 | 17:30 |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/config: Rearrange into using roles https://review.openstack.org/96636 | 17:30 |
mordred | sorry all - had to rebase against master to clear a merge conflict :( | 17:30 |
*** sarob__ has joined #openstack-infra | 17:33 | |
*** e0ne has quit IRC | 17:33 | |
*** sarob_ has quit IRC | 17:36 | |
*** sarob__ has quit IRC | 17:37 | |
*** otherwiseguy has quit IRC | 17:38 | |
*** otter768 has quit IRC | 17:39 | |
mordred | dstufft: there now seems to be a setuptools 5 - and it seems to break when I try to install it | 17:43 |
dstufft | lol | 17:43 |
dstufft | of course | 17:43 |
mordred | File "/tmp/user/0/pip_build_root/setuptools/setuptools/script template.py", line 2 | 17:43 |
mordred | __requires__ = %(spec)r | 17:43 |
mordred | ^ | 17:43 |
mordred | SyntaxError: invalid syntax | 17:43 |
mordred | dstufft: that was in a virtualenv fwiw | 17:43 |
*** ihrachyshka has joined #openstack-infra | 17:44 | |
*** CaptTofu_ has joined #openstack-infra | 17:47 | |
*** ihrachyshka has quit IRC | 17:51 | |
*** ihrachyshka has joined #openstack-infra | 17:51 | |
*** wenlock_ has joined #openstack-infra | 17:52 | |
*** _nadya_ has joined #openstack-infra | 17:52 | |
*** dims has joined #openstack-infra | 18:05 | |
*** arnaud has quit IRC | 18:05 | |
*** Longgeek has quit IRC | 18:08 | |
*** dims has quit IRC | 18:09 | |
*** wenlock_ has quit IRC | 18:10 | |
*** krtaylor has quit IRC | 18:19 | |
*** CaptTofu_ has quit IRC | 18:21 | |
*** CaptTofu_ has joined #openstack-infra | 18:22 | |
openstackgerrit | A change was merged to openstack-infra/nodepool: Check for stale PID lock when starting https://review.openstack.org/90052 | 18:23 |
*** CaptTofu_ has quit IRC | 18:26 | |
clarkb | mordred: I do not know why we are installing mod_wsgi | 18:30 |
fungi | mordred: was it setuptools we previously discussed as being developed primarily in python 3 on windows? | 18:30 |
* notmyname is alive | 18:34 | |
mordred | notmyname: that's excellent | 18:35 |
notmyname | mordred: terms and conditions may apply ;-) | 18:35 |
mordred | notmyname: :) | 18:35 |
*** alexpilotti has joined #openstack-infra | 18:38 | |
clarkb | mordred: univision is the best thing ever by the way. Seriously ABC we get colombia greece, uruguar costa rica, but no England Italy? | 18:40 |
mordred | clarkb: england italy is on espn | 18:40 |
mordred | clarkb: btw- mod_wsgi was added by me in commit b47dbcdef0e2e4b1b30b0eab3ebf6d5ba929ea31 | 18:41 |
mordred | clarkb: Date: Tue Oct 11 15:56:11 2011 -0700 | 18:41 |
notmyname | mordred: clarkb: what time? my son wants to watch that one | 18:41 |
mordred | clarkb: Rework all of the slaves for virtualenv. | 18:41 |
mordred | notmyname: 3pm | 18:41 |
notmyname | mordred: thanks | 18:41 |
clarkb | notmyname: it will also be on univision | 18:42 |
mordred | :) | 18:42 |
clarkb | notmyname: which is where I will watch it as I don't haev cable | 18:42 |
notmyname | heh. well he did do spanish-immersion kindergarten ;-) | 18:42 |
mordred | clarkb: best I can tell, the list of depends was based on what was in the apts files in devstack at the time | 18:42 |
*** sweston has quit IRC | 18:42 | |
clarkb | notmyname: the "GGGGGOOOOOOLLLLLLLLL" is so much better on univision too | 18:42 |
clarkb | mordred: oh so we can probably clean that up a bit | 18:43 |
mordred | clarkb: yah | 18:44 |
mordred | clarkb: I mean, most of the other things we install seem sane | 18:44 |
openstackgerrit | Monty Taylor proposed a change to openstack-infra/config: Remove mod_wsgi package https://review.openstack.org/100073 | 18:47 |
mordred | clarkb: there ya go ^^ | 18:47 |
mordred | btw - looking at commit b47dbcdef0e2e4b1b30b0eab3ebf6d5ba929ea31 is fun | 18:47 |
mordred | also, I'd forgotten just how far I'd gotten with apt repo automation | 18:49 |
*** mriedem has quit IRC | 18:54 | |
morganfainberg | mordred, out of curiosity ^ mod_wsgi stuff that affects which jenkins systems? | 18:55 |
*** basha has quit IRC | 18:55 | |
morganfainberg | mordred, i ask because if this would affect the tempest running systems it would break apache deployed keystone effort (i'll look more closely later on need to run today though). | 18:57 |
*** Ryan_Lane has joined #openstack-infra | 18:58 | |
morganfainberg | unless devstack handles installing it ... like i said i'll look into it later on | 19:00 |
*** Ryan_Lane has quit IRC | 19:02 | |
*** Ryan_Lane has joined #openstack-infra | 19:03 | |
*** _nadya_ has quit IRC | 19:04 | |
*** ihrachyshka has quit IRC | 19:05 | |
*** dims has joined #openstack-infra | 19:05 | |
*** adalbas has joined #openstack-infra | 19:06 | |
*** yfried_ has joined #openstack-infra | 19:08 | |
*** dims has quit IRC | 19:10 | |
*** Ryan_Lane has quit IRC | 19:11 | |
*** andreykurilin_ has joined #openstack-infra | 19:12 | |
mordred | morganfainberg: yeah - that's the thing ... if you devstack doesn't handle installing it, we should def fix that | 19:15 |
mordred | morganfainberg: ok- install_apache_wsgi installs it - but it's actually only listed in the apts file for horizon and not for keystone | 19:17 |
mordred | morganfainberg: so nothing shoudl break in the gate, but there is certainly a place where we're not being explicit | 19:17 |
*** sweston has joined #openstack-infra | 19:17 | |
*** arnaud has joined #openstack-infra | 19:18 | |
*** andreykurilin_ has quit IRC | 19:19 | |
*** andreykurilin_ has joined #openstack-infra | 19:19 | |
*** sarob_ has joined #openstack-infra | 19:36 | |
*** andreykurilin_ has quit IRC | 19:38 | |
*** e0ne has joined #openstack-infra | 19:38 | |
*** zzelle has quit IRC | 19:39 | |
*** sarob_ has quit IRC | 19:40 | |
*** andreykurilin_ has joined #openstack-infra | 19:41 | |
*** zzelle has joined #openstack-infra | 19:44 | |
*** andreykurilin_ has quit IRC | 19:46 | |
*** sweston has quit IRC | 19:48 | |
*** arnaud has quit IRC | 19:49 | |
*** arnaud has joined #openstack-infra | 19:51 | |
*** andreykurilin_ has joined #openstack-infra | 19:51 | |
*** sarob_ has joined #openstack-infra | 19:51 | |
*** sarob_ has quit IRC | 19:56 | |
*** andreykurilin_ has quit IRC | 19:56 | |
*** andreykurilin_ has joined #openstack-infra | 19:57 | |
mordred | clarkb: today's games have thus-far not been as good as yesterday's | 19:58 |
*** ihrachyshka has joined #openstack-infra | 20:00 | |
clarkb | mordred: ya | 20:01 |
clarkb | but spain netherlands was going to be a good one | 20:01 |
*** ihrachyshka has quit IRC | 20:01 | |
clarkb | germany portugal should be good too (thats monday?) | 20:01 |
mordred | yah. | 20:04 |
mordred | england italy might not be bad | 20:04 |
mordred | ivory coast japan is not going to be great | 20:05 |
clarkb | I am going to have to figure out seattle office streaming assuming no one else has sorted it out yet | 20:05 |
clarkb | jesusaurus: ^ | 20:05 |
dstufft | ~soccer~ | 20:07 |
*** arnaud has quit IRC | 20:12 | |
mordred | goooooooooooooooooooooooooooooooooooooooooooooool | 20:17 |
mordred | the game went from being boring to quite good | 20:18 |
greghaynes | wow crc | 20:18 |
*** lttrl has joined #openstack-infra | 20:21 | |
*** sarob_ has joined #openstack-infra | 20:24 | |
*** mriedem has joined #openstack-infra | 20:31 | |
*** Sukhdev has joined #openstack-infra | 20:35 | |
*** sarob_ has quit IRC | 20:36 | |
lifeless | gnaaaaar | 20:38 |
lifeless | now 3.3 is failing | 20:38 |
lifeless | 2014-06-14 18:41:56.622 | error: /home/jenkins/workspace/gate-pbr-python33/.tox/py33/lib/python3.3/site-packages/pbr_testpackage-0.0-py3.3.egg-info: File exists | 20:38 |
mordred | lifeless: btw... most annoying bug evar | 20:38 |
mordred | lifeless: it's next up on my list of things to smash my facehole against | 20:39 |
lifeless | mordred: py26 started working | 20:39 |
lifeless | mordred: py33 stopped | 20:39 |
lifeless | mordred: this makes me think its a isolation issue / race condition in the test suite | 20:40 |
mordred | lifeless: I would agree with atht | 20:40 |
lifeless | mordred: e.g. - note that its writing into the tox's own site packages | 20:40 |
lifeless | mordred: this is is in pbr.tests.test_commands.TestCommands.test_custom_build_py_command | 20:40 |
mordred | lifeless: yeah. I think that's a mistake | 20:40 |
lifeless | mordred: if two such testpackage installs run at the same time | 20:40 |
lifeless | mordred: what will happen... | 20:41 |
mordred | I think we shoudl not be installing pbr_testpackage into the tox venv | 20:41 |
mordred | lifeless: oh! hang on. I have an idea... | 20:43 |
lifeless | mordred: btw did you see my 'is it ok to cut a release' query ? | 20:45 |
openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: Use the current pbr for testpackage tests. https://review.openstack.org/94107 | 20:45 |
mordred | lifeless: I did not | 20:45 |
mordred | lifeless: ^^ there is an attempt | 20:45 |
lifeless | mordred: check scrollback, here ;) | 20:46 |
mordred | lifeless: I do not see it - you want to cut a pbr? | 20:46 |
lifeless | I was thinking about it yes. Inventory bad mmkay. | 20:47 |
lifeless | also, I want to know what your general policy on doing such things is | 20:47 |
lifeless | I will be interested if that attempt works | 20:48 |
lifeless | because its not failing on that code | 20:48 |
lifeless | mordred: ^ | 20:48 |
lifeless | mordred: that code doesn't install the test package | 20:48 |
*** markmcclain has joined #openstack-infra | 20:48 | |
mordred | oh. good point | 20:49 |
mordred | hrm | 20:49 |
mordred | lifeless: in general, the policy is "hey man, we should maybe release" ... or "holy crap, there's a disastrous bug, we need to release right now" | 20:49 |
lifeless | mordred: its very confusing | 20:50 |
lifeless | mordred: because line 128 - the one you changed - is whats failing | 20:50 |
lifeless | mordred: but thats meant to be installing *pbr* not pbr_testpackage | 20:50 |
mordred | lifeless: nope! I see it | 20:51 |
mordred | lifeless: wait. I may be lying | 20:51 |
lifeless | however, I have spotted a clear problem myself | 20:52 |
mordred | lifeless: yeah. so ... | 20:53 |
lifeless | pip isn't concurrency safe apparently | 20:53 |
lifeless | so this won't work for two reasons | 20:53 |
mordred | we're working off of pbr.__file__ | 20:53 |
lifeless | a) even if it was correctly installing pbr | 20:53 |
lifeless | it would race with other testr backends. | 20:53 |
lifeless | b) its not currently installing pbr for f*only knows reasons | 20:54 |
mordred | lifeless: what are we intending to install pbr _into_ ? | 20:56 |
lifeless | the venv | 20:56 |
mordred | the test suite doesn't make virtualenvs | 20:56 |
lifeless | I know | 20:56 |
lifeless | tox does | 20:56 |
lifeless | just about to push | 20:56 |
mordred | right. tox also installs pbr into that venv | 20:56 |
lifeless | mordred: implicitly ? | 20:56 |
mordred | in all cases | 20:57 |
mordred | it does it before every time you run it | 20:57 |
lifeless | oh,then this is a no-op | 20:57 |
lifeless | it was entirely unobvious that this happens | 20:57 |
* mordred just now groks the whole picture | 20:57 | |
mordred | you know - the test suite should potentially create virtualenvs and install things into them | 20:58 |
openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Allow examining parsing exceptions. https://review.openstack.org/80856 | 20:58 |
openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Teach pbr VersionInfo about debian versions. https://review.openstack.org/81074 | 20:58 |
lifeless | It could do one per thread yes | 20:58 |
openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Teach pbr about post versioned dev versions. https://review.openstack.org/80449 | 20:58 |
lifeless | future work | 20:58 |
openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Add a converter to version_tuples. https://review.openstack.org/80457 | 20:58 |
mordred | lifeless: yup | 20:58 |
openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Break out a common version object from VersionInfo https://review.openstack.org/94108 | 20:58 |
mordred | lifeless: sorry, I should have caught this weeks ago | 20:58 |
lifeless | np | 20:59 |
lifeless | let me just sign into gerrit again. sigh. | 20:59 |
mordred | lifeless: I'm still not 100% sure why the code was installing the testpackage instead of pbr itself - pip concurrency problems notwithsstanding. your abspath stuff _should_ have worked best I can tell | 20:59 |
lifeless | indeed | 20:59 |
lifeless | NFI | 20:59 |
lifeless | it did the right thing here AFAICT | 20:59 |
lifeless | now, let me see which things should land now | 21:00 |
lifeless | 80856 should | 21:00 |
*** adalbas has quit IRC | 21:00 | |
*** markmcclain has quit IRC | 21:01 | |
mordred | +A'd 80856 | 21:02 |
lifeless | mordred: I think there is enough consensus on the semver spec that we could land 80449 if we announce it to -infra and -dev; or we can wait and I'll tie it all up with a bow next week I hope | 21:03 |
lifeless | mordred: 95625 needs infra reviewers | 21:03 |
mordred | lifeless: I'm +2 on 80449 | 21:04 |
*** sarob_ has joined #openstack-infra | 21:05 | |
mordred | lifeless: maybe dhellmann or clarkb or jhesketh or SergeyLukjanov or fungi will feel like reviewing it sometime today :) | 21:07 |
*** sarob__ has joined #openstack-infra | 21:07 | |
dhellmann | mordred, lifeless : is 80449 tied to the spec https://review.openstack.org/96608 ? | 21:08 |
lifeless | dhellmann: yes | 21:09 |
lifeless | dhellmann: in the sense that the spec implies 80449 | 21:09 |
lifeless | dhellmann: 80449 is a very small subset of the specs work | 21:10 |
*** sarob_ has quit IRC | 21:10 | |
dhellmann | lifeless: ok, I'd like to get that spec approved before the code change then | 21:10 |
*** e0ne has quit IRC | 21:10 | |
lifeless | dhellmann: its waiting on you AFAICT | 21:10 |
mordred | dhellmann, lifeless the reason I think we need another digit, btw | 21:10 |
lifeless | dhellmann: I lie | 21:11 |
mordred | dhellmann, lifeless: is to be (waves hands) compatible with upstream semver | 21:11 |
lifeless | dhellmann: its waiting on me doing a rewrite. I will do monday. | 21:11 |
dhellmann | lifeless: maybe you can convince mordred to weigh in on that spec, too ;-) | 21:11 |
lifeless | mordred: upstream specifieds 3 and only 3 | 21:11 |
mordred | right | 21:11 |
mordred | except, they'll allow a suffix aftera - | 21:11 |
mordred | and they dont' really care what goes into the suffice | 21:11 |
lifeless | mordred: they care a lot | 21:11 |
*** sarob__ has quit IRC | 21:11 | |
mordred | ok. hang on - not my point right now, let's come back to that | 21:12 |
lifeless | mordred: they specify complex and bong sorting rules about the suffixes | 21:12 |
lifeless | ok | 21:12 |
mordred | what I'm saying is, 3 meaningful numbers is fairly important | 21:12 |
mordred | and having the third have an a in it is clearly a weird thing from that view point | 21:12 |
*** jamespage_ has joined #openstack-infra | 21:12 | |
lifeless | mordred: oh right, so I don't need to rework it. | 21:13 |
mordred | dhellmann: ^^ does that make sense to you? | 21:13 |
lifeless | Other than to note this point. | 21:13 |
dhellmann | that's fine, just document it | 21:13 |
lifeless | mordred: I agree | 21:13 |
dhellmann | yeah | 21:13 |
mordred | (I'll also write it in the spec stuff) | 21:13 |
mordred | you want lifeless to put it in the spec text? or me to put it in a comment? or both? | 21:13 |
dhellmann | in the spec text | 21:13 |
dhellmann | that way our grandchildren will have an artifact to refer to | 21:14 |
lifeless | I'm putting it in right now | 21:14 |
dhellmann | k | 21:14 |
lifeless | we don't have follow on feedback from josh about rpm | 21:14 |
mordred | kk | 21:14 |
lifeless | but I think we can fine tune that and update the the spec as we go | 21:14 |
*** dims has joined #openstack-infra | 21:15 | |
dhellmann | lifeless: I'll wait for a +1 from mordred on the spec and a couple from other oslo cores; the stuff for rpm can come in another spec (or an update to this one, I guess) | 21:15 |
dhellmann | it is steak cooking time, so I'll check back tomorrow for updates :-) | 21:16 |
mordred | dhellmann, lifeless: once we're finally solid with this, I think we should get aroudn to writing a pep too | 21:16 |
dhellmann | for the ppa to look at? | 21:16 |
mordred | dhellmann: ppa == ? (ppa means personal package archive in my brain) | 21:16 |
lifeless | mordred: sure, we can toss it at ncoghlan | 21:17 |
dhellmann | oh, pypa -- whatever the packaging team calls itself this year | 21:17 |
mordred | yah | 21:17 |
mordred | like, as a follow on pep to 440 - "semver as it relates to pep440" or something | 21:17 |
lifeless | mordred: so - can you review 96608 as a priority | 21:17 |
dhellmann | that makes sense | 21:17 |
dhellmann | the pep, that is | 21:17 |
lifeless | mordred: since thats now the blocking thing, and dhellmann can you shop it around the oslo cores you have in mind? | 21:18 |
lifeless | dhellmann: this is FWIW what blocks more of my test libraries moving to git. So its a deep dependency tree to improve a bunch of things. | 21:18 |
dhellmann | lifeless: maybe we should get pbr cores to look at this one? | 21:18 |
dhellmann | ok, that's good to know | 21:18 |
mordred | lifeless: yup. I'm going to review it right after I get back from the store | 21:19 |
dhellmann | ugh, there are 17 pbr core reviewers? wth | 21:19 |
mordred | lifeless: but I'm pretty sure it's good with me | 21:19 |
lifeless | dhellmann: welcome to inclusion. | 21:19 |
mordred | dhellmann: infra-core + oslo-core + lifeless I beleive | 21:19 |
dhellmann | yeah, that's what it looks like | 21:19 |
lifeless | mordred: I suspect i might describe the fine existing preversion detail a little wrong, I will check and possibly push a new rev up nowish | 21:19 |
dhellmann | who should we be looking to for feedback here? | 21:19 |
lifeless | dhellmann: ops and cd folk, its not about the code :) | 21:20 |
lifeless | dhellmann: packagers | 21:20 |
mordred | so - it needs to be the people who can hold both packaging AND CD in their heads simulatenously | 21:20 |
dhellmann | lifeless: feel free to add some reviewers, then. | 21:20 |
mordred | otherwise, there's too much "why don't you just ..." | 21:20 |
*** dims has quit IRC | 21:21 | |
mordred | I think dhellmann, lifeless, ttx, jeblair and clarkb are the ones who have up until now shown interest in diving in to the subject matter fully | 21:21 |
*** davidhadas has joined #openstack-infra | 21:21 | |
mordred | and dstufft | 21:22 |
mordred | and Alex_Gaynor | 21:22 |
mordred | I like having them aroudn :) | 21:22 |
dstufft | what'd I do now | 21:22 |
dhellmann | that's a good list, I added them | 21:22 |
lifeless | dstufft: know stuff about stuff | 21:22 |
dhellmann | dstufft: https://review.openstack.org/#/c/96608/4 | 21:22 |
dstufft | always a bad choice to know stuff about stuff | 21:22 |
dstufft | then people expect you to do stuff with the stuff you know about stuff | 21:23 |
dhellmann | truer words were never spoken | 21:23 |
* dhellmann knows this charcoal isn't going to light itself, and heads off to do stuff with fire | 21:23 | |
clarkb | now I really want to do another brisket but that will have to wait until next weekend | 21:23 |
Sukhdev | clarkb: Something changed recently which is causing all (most) of the third party CI's to fail | 21:24 |
dstufft | oh man CD versioning is so hard to do nicely | 21:24 |
dstufft | I'm trying to figure that out for Warehouse lately | 21:25 |
clarkb | Sukhdev: ok? I think you need to be more specific than that | 21:25 |
clarkb | Sukhdev: I doubt it was an infra thing we have been too busy this week to change things | 21:25 |
clarkb | (certainly could be though) | 21:25 |
Sukhdev | clarkb: let me gather some info and will provide - I noticed large number of failures and thought of letting you know | 21:26 |
mordred | dstufft: well then, definitely review the above! | 21:26 |
mordred | dstufft: because we're insane enough that we need to do CD versioning AND traditional released software versioning | 21:26 |
*** zns has joined #openstack-infra | 21:27 | |
lifeless | ok, clarified the post-version/pre-version some and pushed | 21:27 |
dstufft | probably I'd just encode the "breaking" information in whatever you use for changelog | 21:27 |
lifeless | dstufft: dhellmann: e.g. refres now, I think its on /6 now | 21:28 |
Sukhdev | clarkb: I pasted the failure here - please take a look http://paste.openstack.org/show/84057/ | 21:28 |
mordred | dstufft: that's an interesting idea ... | 21:28 |
lifeless | dstufft: that roughly what I propose but putting in changelog is problematic | 21:28 |
Sukhdev | clarkb: stack.sh is failing | 21:28 |
lifeless | dstufft: since we use git for changelog, and its not editable. | 21:29 |
mordred | lifeless: whyfor? | 21:29 |
clarkb | Sukhdev: I believe that is the setuptools bug. Remove setuptools version 4 | 21:29 |
mordred | but we could totally put a "BREAKING" or something in there | 21:29 |
*** sweston has joined #openstack-infra | 21:29 | |
clarkb | Sukhdev: and install latest 3.X version (I think 3.8) | 21:29 |
lifeless | dstufft: which means if you make a mistake you can't fix it. Where as if its metadata you can edit that without having to do history re-writes | 21:29 |
clarkb | also woo setuptools | 21:29 |
dstufft | mordred: like y'all use git commit message for your change log, so you could add a field (ala Signed-Off-By) that says like (Compatability-Statement: Breaking/Feature/Buffix) | 21:29 |
lifeless | mordred: ^ | 21:29 |
dstufft | lifeless: well I think using git commit messages for change log is a bad idea for that reason in general ;) | 21:29 |
dstufft | topfiles approach++ | 21:29 |
mordred | ugh | 21:29 |
lifeless | dstufft: I propose just putting it in setup.cfg | 21:29 |
Sukhdev | clarkb: can you please provide the link to the bug? | 21:30 |
mordred | topfiles is still too much repitition for me, but I can see how folks would prefer it | 21:30 |
lifeless | dstufft: if you attempt to merge stuff cross-releases it will conflict, and otherwise it will be identical, so should be fairly straightforward. | 21:30 |
fungi | Sukhdev: clarkb: bug 1326972 | 21:31 |
clarkb | Sukhdev: https://mail.python.org/pipermail/distutils-sig/2014-June/024478.html | 21:31 |
uvirtbot | Launchpad bug 1326972 in python-swiftclient "swiftclient fails to install under tox with Python3" [Undecided,New] https://launchpad.net/bugs/1326972 | 21:31 |
clarkb | lifeless: mordred dhellmann so initial feedback. I think we are making this far more complicated than it is today | 21:31 |
clarkb | the intent is good but the proposal seems to make it harder to get right | 21:31 |
lifeless | dstufft: my projects maintain separate changelogs yes, same reason as you :). | 21:31 |
dstufft | lifeless: yea, sounds impossible to mechanically enforce though, e.g. if you include it with your change log entries (git commit, topfile whatever) you can enforce that you include a statement about the compatability of every change | 21:31 |
clarkb | all of a sudden there are a zillion knobs to turn in order to get the proper versions | 21:31 |
Sukhdev | fungi, clarkb: Thanks | 21:31 |
lifeless | clarkb: we're releasing 6? projects/week within tripleo and doing this check every week. | 21:32 |
dstufft | whereas if you're just recording the last thing that did X, you're relying on humans to check to make sure that you did it | 21:32 |
lifeless | dstufft: including a statement doesn't mean you get the statement right. | 21:32 |
clarkb | fungi: we have a bug on our side? | 21:32 |
dstufft | lifeless: well sure, but that's an argument agaisnt git as a changelog source imo ;) | 21:32 |
lifeless | clarkb: are you able to help me see where we can simplify it ? | 21:32 |
clarkb | lifeless: I like the git log thing | 21:33 |
lifeless | clarkb: the knobs are opt-in. | 21:33 |
clarkb | lifeless: rather than setting a bunch of knobs in a config file. Enforce it through the log itself | 21:33 |
lifeless | clarkb: folk can just do what they do today. | 21:33 |
lifeless | clarkb: if you are willing to rebase trunk, sure. | 21:33 |
clarkb | lifeless: so start with a seed tag eg 1.0.0 | 21:33 |
dstufft | acutally | 21:33 |
clarkb | then all tag versions after that are generated based on the git log back to seed tag | 21:33 |
dstufft | I'm not sure you can really change it without breaking existing versions | 21:33 |
clarkb | it may be expensive to do that parsing of the graph but I really don't want to set knobs | 21:34 |
fungi | clarkb: the bug on our side which is referenced in the post about removing setuptools 4.x (indirectly by way of a link in the bitbucket bug) is for swiftclient installation breaking under py33 | 21:34 |
dstufft | if you claim this was a breaking change but it wasn't, then you can't go back and pretend it wasn't, because you have versions already that had the new version | 21:34 |
fungi | so not sure why this would affect devstack runs | 21:34 |
lifeless | clarkb: my concern isn't cost. | 21:34 |
clarkb | dstufft: I think that is ok | 21:34 |
clarkb | dstufft: the opposite wouldn't be | 21:34 |
mordred | clarkb: ++ | 21:35 |
lifeless | dstufft: releases are a boundary where that happens; if you haven't released you only have devN builds to deal with | 21:35 |
mordred | lifeless: but isn't it goign to be calculating next_Version differently? | 21:35 |
mordred | so it'll be either 1.2.0.0dev1 or 2.0.0.0dev1 depending on whether you've indicated breaking change | 21:35 |
lifeless | mordred: if it wasn't a breaking fix, just roll the setup.cfg change back. | 21:35 |
lifeless | mordred: right, dev versions. | 21:35 |
mordred | except that someone may have deployed 2.0.0.0dev1 | 21:36 |
lifeless | mordred: it wouldn't be a trivial thing to do because it will give CDers headaches. | 21:36 |
mordred | right. I guess I'm just saying, allowing for having made mistakes and rolling them back is not really a feature | 21:36 |
mordred | it shouldn't be done | 21:36 |
lifeless | so lets work through this | 21:36 |
mordred | there are two possilibiies | 21:36 |
mordred | either you land a change which broke things but you didn't mark as such | 21:37 |
lifeless | you make a mistake that makes a version higher than needed | 21:37 |
lifeless | you make a mistake that makes a version lower than needed | 21:37 |
mordred | or you land a change marked as breaking which wasnt' really | 21:37 |
clarkb | mordred: you deleted setuptools 4 from our mirror right? | 21:37 |
mordred | clarkb: yes | 21:37 |
clarkb | mordred: can I fix released on 1326972? | 21:37 |
mordred | clarkb: yah | 21:37 |
clarkb | mordred: fix released adn assigned to you | 21:37 |
mordred | lifeless: right. we're saying the same thing in our setup | 21:37 |
lifeless | if we say that case A is fixed by living with it | 21:37 |
mordred | lifeless: what I'm saying is that if you release a version higher than needed - tough | 21:37 |
mordred | yeah | 21:37 |
mordred | you live with it - the version is in the wild | 21:38 |
dstufft | Case A is what happened with setuptools today | 21:38 |
dstufft | ;) | 21:38 |
mordred | yup | 21:38 |
dstufft | sort of | 21:38 |
lifeless | case B can be solved by making a no-op commit that just claims the needed break. | 21:38 |
mordred | lifeless: yup | 21:38 |
mordred | which is the equiv of "oops, I shoulda bumped the vesrion before" | 21:38 |
lifeless | + deleting the bad version so folk not ready for the break are not broken. | 21:38 |
dstufft | if you put it in the gitlog, you can enforce it so that you require a compatability statement on every commit | 21:38 |
mordred | lifeless: no | 21:38 |
dstufft | either bugfix, feature, or breaking | 21:39 |
clarkb | dstufft: right thats sort of what I am thinking | 21:39 |
clarkb | dstufft: then you don't really need a config file | 21:39 |
clarkb | dstufft: you just need good logs | 21:39 |
mordred | I'm more on board with the git log the more we talk through it | 21:39 |
lifeless | mordred: no ? you force them to go from < 3.0.0 to < 2.4.6 or whatever ? | 21:39 |
mordred | lifeless: no, I mean you can't delete the version | 21:39 |
mordred | it's out there | 21:39 |
mordred | it exists | 21:39 |
dstufft | if all the changes are bugfixes, then you increment the third digit, if ther are any features, you increment the second digit, if any breaking you increment the first digit | 21:39 |
lifeless | sure, and you can't re-issue it, but removing it from mirrors can be helpful to users. Its a separate discussion to this. | 21:40 |
mordred | yes. separate discussion | 21:40 |
lifeless | dstufft: well, you're missing the 0 right shift, butyes. | 21:40 |
clarkb | lifeless: those increment between tags | 21:40 |
dstufft | and you get to mechanically require that every change has a statement | 21:40 |
clarkb | lifeless: so two separate things going on | 21:40 |
mordred | lifeless: I think he's saying that, when you calculate next version, you can examine the log and look for each of those characteristics | 21:40 |
clarkb | there is the tagging and there is the more verbose CD version generation. Both should work with the log system | 21:40 |
dstufft | so you know what kind of changes exist in any set of changes | 21:41 |
dstufft | if they are all bugfix or whatever | 21:41 |
lifeless | clarkb: mordred: no, I think you both just misunderstood me. | 21:41 |
mordred | lifeless: awesome | 21:41 |
lifeless | clarkb: mordred: semver versions beginning with 0 are different. | 21:41 |
lifeless | a breaking change to version 0.1.2 results in 0.2.0 | 21:41 |
lifeless | not in 1.0.0 | 21:41 |
mordred | lifeless: sure. I largely don't care about 0 versions and think we shoudl stop using them | 21:42 |
lifeless | semver rules will never force you to hit 1.0.0 automatically. | 21:42 |
clarkb | right just start with 1.0.0 everywhere | 21:42 |
dstufft | semver states if youre using it in production you shouldn't be using a leading zero | 21:42 |
mordred | but if we support them, then fine | 21:42 |
lifeless | dstufft: no, it claims there is no api compat guarantee. Slightly different. | 21:42 |
mordred | dstufft: I mostly agree with you on the tagging - except I don't actually want to add the word 'bugfix' into all 500 commits I make every day | 21:42 |
lifeless | right so I was going to say | 21:43 |
lifeless | there is a common case | 21:43 |
mordred | there is already a thread somewhere suggesting that we stop consuming or producing 0.x things | 21:43 |
lifeless | that shouldn't need an assertion | 21:43 |
mordred | lifeless: ++ | 21:43 |
lifeless | we can do 0 easily, so lets not rathole into a different debate. And folk use pbr for non-openstack, and they may want 0.x, and 0.x can be defined sanely. | 21:43 |
mordred | lifeless: yes | 21:44 |
dstufft | well the problem with that is just that it's easier to forget to include a statement saying it was breaking or whatever | 21:44 |
mordred | I'm fine with that | 21:44 |
dstufft | but if you'e OK with that, then ok | 21:44 |
mordred | dstufft: I think it's worth trying without it | 21:44 |
lifeless | dstufft: if you train folk to just say 'bugfix' they will do ONLY THAT. | 21:44 |
lifeless | dstufft: and you're screwed. | 21:44 |
dstufft | perhaps git-review or whatever could add a Bugfix thing automatically if one doesn't exist | 21:44 |
dstufft | then your reviewers will see it | 21:45 |
dstufft | and seeing something wrong is easier to realize it's wrong then seeing something that's missing | 21:45 |
mordred | I agree with the intent - I think it'll break with our folks | 21:45 |
lifeless | dstufft: I don't think thats the case. | 21:45 |
mordred | there's already too much blind operation - I think it'll just be extra word noise | 21:45 |
dstufft | ok | 21:45 |
lifeless | dstufft: operationally, we don't specify 'Impact: x,y,z' we say 'DocImpact; IFF there is docimpact | 21:45 |
mordred | but I do like the opportunity to do positive assertions and have that be helpful | 21:46 |
lifeless | and that works because folk that care about it can look for it. | 21:46 |
lifeless | oh | 21:46 |
mordred | also, now that we can edit commit messages in gerrit ... reviewers coudl totally add a "Breaking" tag | 21:46 |
lifeless | I know why I used setup.cfg. | 21:46 |
mordred | why? | 21:46 |
lifeless | Because its there when we've shipped an sdist | 21:47 |
lifeless | *thnks* | 21:47 |
dstufft | shouldn't an sdist already have a version baked into it | 21:47 |
lifeless | no, thats bogus. | 21:47 |
mordred | yes | 21:47 |
mordred | lifeless: it might have gotten you there though | 21:47 |
lifeless | dstufft: they do, but my head was saying no-rc impacted. | 21:47 |
dstufft | waht is version_info style | 21:48 |
mordred | dstufft: that's an object thing we've had aroudn openstack projects for since before pbr | 21:49 |
dstufft | oic | 21:49 |
mordred | ok. seriously. I just failed at going to the store | 21:50 |
mordred | I'll be back in a sec | 21:50 |
lifeless | mordred: dstufft: huh no - its the python version tuple thing itself. | 21:50 |
dstufft | why is there a fourth digit in the version again | 21:50 |
dstufft | (Sorry I'm failing to remember some of these things) | 21:51 |
lifeless | dstufft: because 1.2.3a4 is very much not semver comaptible. | 21:51 |
lifeless | MAJOR.MINOR.PATCH.(letsfiddlehere) | 21:51 |
*** sarob_ has joined #openstack-infra | 21:51 | |
dstufft | semver compatible in which way, syntax or semantics | 21:51 |
lifeless | syntax | 21:51 |
dstufft | ok | 21:51 |
dstufft | makes sense then | 21:52 |
dstufft | I generally don't care about syntax compatability w/ semver when I'm working on PEP440 stuff, but that makes sense | 21:52 |
lifeless | its not strictly compatible but its more compatible. | 21:55 |
*** sarob_ has quit IRC | 21:56 | |
dstufft | eh, maybe slightly so. But easy to convert in either case | 21:58 |
*** yfried_ has quit IRC | 22:01 | |
*** yfried_ has joined #openstack-infra | 22:01 | |
*** fbo is now known as fbo_away | 22:02 | |
*** zns has quit IRC | 22:03 | |
Sukhdev | fungi, clarkb: removal of setuptools and reinstalling version 3.8 did not help. my present version is setuptools 3.8 - I still get the same failures | 22:05 |
dstufft | lifeless: mordred clarkb other than the git log thing I think the semver thing looks pretty OK, the PEP 440 compat isn't actually compat with PEP 440 at the moment though. but making it be compat is just syntax changes so not sure if that needs to be nailed down exactly in a spec or not | 22:09 |
lifeless | dstufft: tell me whats wrong | 22:13 |
lifeless | clarkb: mordred: dhellmann: dstufft: new version pushed up with git log rules. | 22:14 |
dstufft | lifeless: x.y.z.dev4.gHASH isn't compatible, you can't have a .something after a .devN version, you probably want x.y.z.dev4~gHASH but PEP 440 isn't actually finalized yet so that *might* change, but I don't think it will, it's pretty close to be finalized I think | 22:15 |
*** dims has joined #openstack-infra | 22:17 | |
*** mriedem has quit IRC | 22:18 | |
*** sweston has quit IRC | 22:19 | |
persia | x.y.z.$(git describe) | 22:20 |
*** sweston has joined #openstack-infra | 22:20 | |
lifeless | dstufft: ~ has special meaning in debian version #'s | 22:21 |
*** dims has quit IRC | 22:21 | |
lifeless | dstufft: please tell me PEP 440 doesn't use it differently ? | 22:22 |
dstufft | it uses it to differentiate between the prublic version and the "local" version | 22:22 |
*** sweston has quit IRC | 22:22 | |
lifeless | whats the precedence rule there ? | 22:22 |
*** zns has joined #openstack-infra | 22:23 | |
lifeless | dstufft: in debian, '~' sorts *before* '' | 22:24 |
lifeless | dstufft: so 1.2.3 is > 1.2.3~ | 22:24 |
lifeless | dstufft: I don't see ~ in http://legacy.python.org/dev/peps/pep-0440/ other than in the ~= stuff | 22:26 |
lifeless | dstufft: <public version identifier>[-N[.N]+] | 22:27 |
lifeless | dstufft: is the defn for local | 22:27 |
lifeless | so - seems to be the desired separator | 22:28 |
dstufft | lifeless: 1.2.3 < 1.2.3~whatever I think, but they are considered API equivialant, it's used for denoting local patches, like maybe debian patches pip 1.5.4, so it could have pip 1.5.4~debian1 which is API equiv with 1.5.4 but has modifications. | 22:28 |
dstufft | lifeless: that version isn't up to date | 22:28 |
dstufft | we're working on another draft of it | 22:28 |
lifeless | dstufft: ok so please please please do not use ~ for this | 22:28 |
dstufft | we switched from - to ~ because there are projects on PyPI already using - | 22:28 |
lifeless | in debaian 1.2.3~ is entirely opposite to what you just wrote | 22:29 |
dstufft | and setuptools already uses - to denote a pre-release | 22:29 |
dstufft | there aren't a lot of choices for what we can use as a seperator | 22:29 |
lifeless | if debian has a 1.5.4~debian1, its a pre-release of 1.5.4 | 22:29 |
lifeless | ANYTHING ELSE IN THE WORLD | 22:29 |
lifeless | twin towers, airplane, up arrow. Something. | 22:29 |
dstufft | https://bitbucket.org/pypa/pypi-metadata-formats/issue/42/use-a-different-character-to-indicate | 22:30 |
dstufft | is the discussion around moving from - to ~ | 22:30 |
greghaynes | I propose tableflip emoticon | 22:30 |
dstufft | lifeless: I don't think it's going to be a big deal, ~ shouldn't be used anywhere that a debian version is going to get to it really, and if it is then it can be mechanically transformed for debian's sake | 22:32 |
lifeless | dstufft: commented there. | 22:33 |
*** otherwiseguy has joined #openstack-infra | 22:34 | |
dstufft | e.g. you're not going to be allowed to upload a ~ version to PyPI or anything, you can't use it as an "official" version anywhere on the official tooling | 22:34 |
lifeless | dstufft: this makes me nervous and uncomfortable. I may be overreacting of course. | 22:34 |
*** Sukhdev has quit IRC | 22:35 | |
lifeless | still, time for swimming with Cynthia, so - will talk more later | 22:38 |
lifeless | mordred: ^ for your entertainment | 22:38 |
*** Sukhdev has joined #openstack-infra | 22:38 | |
*** sarob_ has joined #openstack-infra | 22:45 | |
*** sarob__ has joined #openstack-infra | 22:47 | |
*** sarob___ has joined #openstack-infra | 22:49 | |
*** sarob_ has quit IRC | 22:50 | |
*** sarob_ has joined #openstack-infra | 22:51 | |
*** sarob__ has quit IRC | 22:51 | |
mordred | dstufft: it makes me similarly uncomfortable | 22:53 |
mordred | dstufft: not because of tooling | 22:53 |
*** sarob___ has quit IRC | 22:53 | |
mordred | but because ANYONE with a debian or ubuntu background is going to see that with their eyes and make very incorrect assumptions about meaning | 22:54 |
*** sarob_ has quit IRC | 22:55 | |
dstufft | mordred: suggest a better character ;) I think - is bad because it'll change the meaning, in a fairly significant way, about ~2% of the current versions on PyPI | 22:56 |
mordred | what about + ? | 22:56 |
dstufft | using ~ means we get 99.9% compatability with pkg_resources for how versions are sorted | 22:57 |
mordred | but you confuse all of the debian and ubuntu users | 22:57 |
dstufft | moment on + | 22:57 |
dstufft | need to see if folks are using that | 22:57 |
openstackgerrit | David Caro proposed a change to openstack-infra/jenkins-job-builder: Added parallelization options https://review.openstack.org/75514 | 22:59 |
dstufft | 30 versions in my local copy of PyPI using + in their version | 22:59 |
dstufft | *sees what for* | 22:59 |
mordred | dstufft: what ever happened to putting this stuff into md 2.0? | 22:59 |
dstufft | mordred: metadata 2.0? | 23:00 |
mordred | yeah | 23:00 |
mordred | I liked the idea of being able to put git sha there and not in the version itself | 23:00 |
dstufft | mordred: so techincally local version isn't exactly for git sha, though it could be. It's mostly for someone to denote an API compatible patch, so like if pip releases 1.5.6, but openstack takes that and patches it for themselves (maybe y'all want to fix a bug or something), they need to version that somehow, your choices are A) Keep the same version and be confused because "1.5.6" means different things in different contexts or B) | 23:02 |
dstufft | do something like 1.5.6.1 or something and hope pip never releases a 1.5.6.1 which is bad because well pip could release a 1.5.6.1 | 23:02 |
dstufft | so you'd do something like 1.5.6~openstack1 | 23:02 |
dstufft | which says it's API compatabile with 1.5.6, but it has some patches applied to it | 23:03 |
mordred | yeah. this is wandering directly into the world of the distros except without the distros | 23:03 |
mordred | because that's exactly the problem space they have to deal with constantly :) | 23:03 |
Sukhdev | fungi: ping | 23:03 |
mordred | this is the reason the debian release 1.5.6-1 and ubuntu release 1.5.6-0ubuntu1 | 23:03 |
dstufft | right now debian has 1.5.6-1 for pip, but their *python* metadata has 1.5.6 | 23:04 |
mordred | yes | 23:04 |
mordred | because 1 is a local debian patch version | 23:04 |
mordred | they're asserting that they're shipping you 1.5.6 | 23:04 |
dstufft | we want them to put that -1 in the python metadata | 23:04 |
mordred | they will not do that | 23:04 |
dstufft | they are shitheads then | 23:04 |
mordred | it would be incorrect | 23:04 |
mordred | they don't WANT to modify the code at all | 23:05 |
dstufft | because it's fucking annoying as fuck to debug a problem with their patches when pip --version is lying | 23:05 |
dstufft | they don't want to, but they do | 23:05 |
mordred | well, so there I agree - sorry - I think we're talking about different things potentially | 23:05 |
mordred | they're going to have -1 whether they ahve patches or not to the python code | 23:05 |
dstufft | if they don't modify the code, then they don't need to change the python version | 23:05 |
mordred | right. | 23:05 |
dstufft | the idea is that if you modify the code, then what you have is no longer 1.5.6 | 23:05 |
dstufft | it's 1.5.6 with some patches | 23:05 |
mordred | right. or you have redhat shipping the linux 2.4 kernel with half of 2.6 backported in | 23:06 |
dstufft | and the "local versions" primary purpose it to encode that this is 1.5.6 with some patches and specifically what version of the patches | 23:06 |
mordred | ok, so, if that's what it is, you're not goign to get that by getting them to put it in the tarball version | 23:06 |
mordred | you might could get them to patch pkg-info I suppose | 23:07 |
dstufft | the Python version string is used in many places, the tarball name is one of them | 23:07 |
dstufft | PKG-INFO is another | 23:07 |
mordred | so where does it live canonically? | 23:07 |
dstufft | in the setup.py generally for a sdist | 23:07 |
mordred | like, what would I need to do as a packager to set the local version suffix stuff? | 23:08 |
mordred | so you'd be asking them now to patch setup.py | 23:08 |
dstufft | yes | 23:08 |
mordred | in order to communicate that they'd patched something | 23:08 |
mordred | maintaining a serial number there is going to be hard if they're using dvcs to maintain packaging | 23:08 |
dstufft | why | 23:09 |
mordred | you and I both have copies of the packaging | 23:10 |
mordred | you add an overlay patch to the python and also patch setup.py to add a -1. I do the same thing | 23:10 |
mordred | you push your commit | 23:10 |
mordred | I try to push, get told I need to update | 23:10 |
mordred | so I do, and in the process of merging, git quite happily notes that we both made the same change and doesn't show me a conflict | 23:11 |
mordred | or ... you added 2 patches and I added 3 before we sync, in which case I get to merge conflict the serial number | 23:11 |
dstufft | doesn't sound like a problem to me, unless I somehow released a new copy of the package between when you updated and when you pushed | 23:12 |
mordred | it's not a PROBLEM - but it's a bit of a pita. if we ever start doign packaging out of the openstack systems, it'll fall apart completely | 23:13 |
dstufft | afaik debian doesn't update their local -N for each patch they apply, but for each release they make | 23:13 |
mordred | that's correct | 23:13 |
mordred | but I was talking about the... oh, you're thinking | 23:14 |
mordred | sorry | 23:14 |
Sukhdev | Folks, something have changed recently which is making python-swiftclient fail during stack.sh - please see the logs http://paste.openstack.org/show/84057/ | 23:14 |
dstufft | so they just have a single patch that they overlay which adjusts the setup.py, and they bump that version whenever they bump the debian/control version | 23:14 |
mordred | you're thining that that the debian -1 would be the thign taht would go in, not a tracked-with-each-patch patch count | 23:14 |
Sukhdev | I tried changing the seuptools to 3.8, that does not help either | 23:14 |
mordred | Sukhdev: those arent' really errors | 23:15 |
mordred | Sukhdev: those are things that should be suppressed and there is an upstream bug filed to do so | 23:15 |
dstufft | yea I don't care if they have 1 patch or a billion patches, it just needs to be some indicator that they've patched it, and ideally also some way to figure out what patches they've applied, but even that isn't strictly required | 23:15 |
mordred | Sukhdev: do you have errors further down? | 23:15 |
mordred | dstufft: ok. well, honestly, we've surpassed where I should be taking their side, because I think that how they manage this is wrong anyway | 23:16 |
dstufft | we don't add any semantics to the local version other than it denotes an API compatible release | 23:16 |
dstufft | so they can do whatever the want, even if it's just "add ~ubuntu to the end" | 23:16 |
mordred | for me, I would personally prefer it if you did not use ~ because ~ will confuse me | 23:16 |
mordred | massively | 23:16 |
Sukhdev | mordred: yes…let me capture those | 23:17 |
dstufft | so it becomes 1.0~ubuntu and leav eout the versioning info all together, because at least that tells me if someone does pip --version, and I get back a 1.0~ubuntu, that I can tell them to go tell me what dpkg says is installed | 23:17 |
dstufft | mordred: I think + will work OK | 23:17 |
mordred | lifeless: ^^ any issues you can see with + ? | 23:17 |
dstufft | it's slightly more versions than use ~, but slightly is like... 10 | 23:18 |
*** dims has joined #openstack-infra | 23:18 | |
dstufft | out of 234k | 23:18 |
Sukhdev | mordred: please see http://paste.openstack.org/show/84064/ | 23:18 |
dstufft | and some of those versions look like they are using it for this anyways | 23:19 |
persia | '+' is an RFC2396 reserved character, so needs URI escaping, if that matters. | 23:19 |
dstufft | oh right, that's why I didn't look at + before | 23:19 |
mordred | these are not supposed to be uploaded to pypi - is RRC2396 really important? | 23:19 |
persia | But I think '+' is widely used for that purpose anyway: urlescape isn't especially hard. | 23:19 |
mordred | persia: ++ | 23:19 |
dstufft | that's not a killer for this application or anything | 23:19 |
dstufft | we already use : in version numbers in places where it _can_ be uploaded to PyPI | 23:20 |
dstufft | it's just a nice to have | 23:20 |
persia | Semantically, to me, '+' clearly indicates "with additional stuff identified by:", but that might just be me. | 23:21 |
dstufft | it's not unreasable | 23:21 |
mordred | dstufft: while we're bothering you ... http://paste.openstack.org/show/84064/ seems to show something actually dying due to that pip bug you filed earlier | 23:21 |
mordred | dstufft: which is potentially unhappymaking | 23:21 |
dstufft | differnt error message | 23:22 |
dstufft | th epip bug was a about a syntaxerror | 23:22 |
dstufft | this is a missing file | 23:22 |
mordred | oh. so you're right | 23:23 |
*** dims has quit IRC | 23:23 | |
dstufft | there's a 3.8.1, not sure what it fixed | 23:23 |
dstufft | guess just that one bug which isn't this | 23:24 |
Sukhdev | mordred: did you look at the paste? | 23:24 |
mordred | Sukhdev: yes. that's what we're talking about | 23:24 |
dstufft | I'm not sure what's causing that error | 23:27 |
mordred | me either | 23:28 |
dstufft | also i'm going to go play wolfenstein: The New Order, my step daughter got it for me for father's day | 23:28 |
*** andreykurilin_ has quit IRC | 23:29 | |
mordred | dstufft: nice! | 23:29 |
Sukhdev | dstufft, mordred: I tried to follow the fix in this https://bugs.launchpad.net/python-swiftclient/+bug/1326972, but, that does not seem to help | 23:31 |
uvirtbot | Launchpad bug 1326972 in openstack-ci "swiftclient fails to install under tox with Python3" [High,Fix released] | 23:31 |
Sukhdev | dstufft, mordred: BTW, this problem has manifested only 2 hours ago and is failing all (most) Third party CI's | 23:33 |
Sukhdev | dstufft mordred: I see all tests pass until 12:28:54 PST, and every single test fails starting 1:18:01 PST - every single failure is because of this | 23:35 |
dstufft | wat | 23:35 |
dstufft | that doesn't make any sense | 23:35 |
dstufft | 3.8 has been out for like 2 weeks | 23:35 |
Sukhdev | dstufft: Perhaps something got checked into the master branch only few hours ago which is causing this issue | 23:36 |
dstufft | which master branch | 23:37 |
Sukhdev | dstufft: neutron/master - all the failing tests are on that branch | 23:37 |
mordred | I HATE PYTHON | 23:37 |
mordred | TypeError: can't concat bytes to str | 23:38 |
mordred | this ^^^ is the result of people being complete and utter crackheads. AAAAAAAAHHHHHHHHHHHHHH | 23:38 |
dstufft | well don't do that | 23:38 |
dstufft | concating bytes and str is a bad thing to do | 23:38 |
mordred | so, I call it like this: | 23:38 |
mordred | header = easy_install.get_script_header("", executable, is_wininst) | 23:38 |
mordred | that first arg winds up being script_text | 23:38 |
mordred | then the error happens here: | 23:39 |
mordred | first = (script_text+'\n').splitlines()[0] | 23:39 |
mordred | so. uhm. which is the bytes and which is the string? | 23:39 |
*** otherwiseguy has quit IRC | 23:40 | |
Sukhdev | BTW, I see the failure with setuptools 5.0.1 as well as 3.8. Would you recommend me trying out some other version? | 23:40 |
dstufft | script_text is the bytes | 23:40 |
dstufft | because "\n" is a str | 23:40 |
mordred | dstufft: but why is script_text bytes? I'm passing it "" | 23:41 |
dstufft | oh I see what you're saying | 23:41 |
dstufft | I misunderstood | 23:41 |
dstufft | are you sure that's the line that's doing it, and that nothing else has modified script_text | 23:42 |
mordred | dstufft: I mean, I'm about to dive deep in - but looking in to the source code, this is the most immediate path I'm seeing | 23:42 |
mordred | the line above starting with first = is the first line in the function | 23:42 |
*** otherwiseguy has joined #openstack-infra | 23:43 | |
mordred | and I'm calling it directly and not through other indirection | 23:43 |
mordred | but - that doesnt' mean anything :) | 23:43 |
dstufft | are you sure you're passing it "" and not b"", like did you manually type in "" or is it coming from somewhere else | 23:43 |
mordred | dstufft: header = easy_install.get_script_header("", executable, is_wininst) | 23:44 |
mordred | dstufft: it's hardcoded in the calling context | 23:44 |
dstufft | also you've worked on pbr long enough to know you should never expect something reasonable from packaging tools | 23:44 |
mordred | oh yeah | 23:44 |
mordred | no, I mean | 23:44 |
*** ryanpetrello has quit IRC | 23:44 | |
mordred | there's nothing surprising here | 23:44 |
dstufft | I'm not sure what's causing that error though ;/ | 23:44 |
dstufft | is this pbr | 23:44 |
mordred | it's an error I just got from Alex_Gaynor on python-swiftclient | 23:45 |
mordred | dstufft: it may or may not, actually, be pbr related | 23:45 |
dstufft | are you generating your own script wrappers? | 23:45 |
mordred | yes | 23:45 |
dstufft | well there's your problem, don' listen to that Alex_Gaynor guy | 23:46 |
dstufft | he finds too many errors | 23:46 |
mordred | I know. he's pretty crazy | 23:46 |
dstufft | mordred: you might wanna use distlib to generate your script wrappers, it's kinda lame but its also kind of less shitty than setuptools script wrappers | 23:46 |
dstufft | also why are you generating your own script wrappers | 23:46 |
mordred | because ... we don't actually want to... example is easier | 23:48 |
mordred | dstufft: http://paste.openstack.org/show/84065/ | 23:48 |
mordred | that's what our scripts look like | 23:48 |
dstufft | ok | 23:48 |
clarkb | iirc pkg_resources took seconds to spin up | 23:48 |
dstufft | so install from wheels | 23:48 |
dstufft | using pip | 23:48 |
dstufft | your script wrappers will look functionally equivilant to that | 23:49 |
mordred | we don't fully have that power | 23:49 |
dstufft | http://paste.openstack.org/show/84066/ is what that would look like pip via wheel | 23:50 |
dstufft | and I plan on making it d that pip via setuptools in the future too | 23:50 |
dstufft | I just need to figure out how to hack that in | 23:50 |
mordred | dstufft: well - I've got the code that does it - you're welcome to it :) | 23:50 |
mordred | dstufft: it's a surprisingly easy thing to do | 23:50 |
dstufft | yea I doubt it'll take long, I jsut have to actually do it | 23:51 |
mordred | dstufft: as soon as pip does that for non-setuptools installs, I can remove that from pbr | 23:51 |
mordred | I just can't count on wheel-based installs just yet | 23:51 |
*** sarob_ has joined #openstack-infra | 23:51 | |
clarkb | mordred: I don't know that you can ever | 23:51 |
dstufft | Not sure why, if you publish a wheel pip will default too it unless the person says "don't install from wheels" | 23:51 |
clarkb | mordred: we use enough of that lxml crap | 23:52 |
mordred | dstufft: many many many people do not install from pypi but instead from git | 23:52 |
mordred | dstufft: and I have to support them | 23:52 |
mordred | quite honestly, our tarballs and release artifacts are probably the least important thing we have | 23:52 |
mordred | for better or for worse | 23:52 |
dstufft | ok | 23:53 |
mordred | dstufft: alright. I have confirmed the Alex_Gaynor bug exists and isn't just him | 23:53 |
mordred | of course, it's making me think it's a bug in tox, because I could have SWORN when I wrote that patch for them that I used pip -e and not setup.py develop | 23:53 |
clarkb | mordred: you have to specify pip -e as the install command | 23:54 |
clarkb | mordred: its not hard coded iirc | 23:54 |
mordred | clarkb: install_command = pip install -U {opts} {packages} | 23:54 |
mordred | clarkb: that's "how do you install deps" | 23:54 |
mordred | clarkb: usedevelop = True triggers something different | 23:54 |
openstackgerrit | A change was merged to openstack-infra/elastic-recheck: Broaden 1326312 to match py26/py27 failures https://review.openstack.org/98929 | 23:55 |
mordred | dstufft: I mean, I _think_ I'm about to report a python 3.4 setuptools bug ... | 23:55 |
*** sarob_ has quit IRC | 23:56 | |
dstufft | fun | 23:58 |
dstufft | I hate installing directly from git :| | 23:58 |
dstufft | it screws everything up | 23:59 |
dstufft | it should be from git -> generates a one off artifact -> installs artifact | 23:59 |
dstufft | but instead we have setup.py install | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!