| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Cleanup pipeline requirements https://review.openstack.org/487618 | 00:00 |
|---|---|---|
| *** dingyichen has joined #openstack-infra | 00:06 | |
| *** jaypipes has quit IRC | 00:09 | |
| *** esberglu has joined #openstack-infra | 00:14 | |
| *** gmann has quit IRC | 00:15 | |
| *** gmann has joined #openstack-infra | 00:15 | |
| *** xarses has quit IRC | 00:18 | |
| *** jamesdenton has quit IRC | 00:19 | |
| *** jamesdenton has joined #openstack-infra | 00:21 | |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Remove ZUUL_CHANGES https://review.openstack.org/486245 | 00:21 |
| *** xarses has joined #openstack-infra | 00:21 | |
| *** xarses has quit IRC | 00:22 | |
| *** xarses has joined #openstack-infra | 00:22 | |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Remove ZUUL_BRANCH https://review.openstack.org/486246 | 00:24 |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Remove ZUUL_VOTING and add zuul.voting https://review.openstack.org/486247 | 00:24 |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Remove ZUUL_URL https://review.openstack.org/486249 | 00:24 |
| *** sree_ has joined #openstack-infra | 00:32 | |
| *** sree_ is now known as Guest41234 | 00:32 | |
| *** psachin has joined #openstack-infra | 00:36 | |
| *** Guest41234 has quit IRC | 00:37 | |
| *** bobh has joined #openstack-infra | 00:39 | |
| *** aeng has quit IRC | 00:40 | |
| *** rama_y_ has joined #openstack-infra | 00:40 | |
| *** rama_y has quit IRC | 00:40 | |
| *** rama_y_ has quit IRC | 00:43 | |
| *** rhallisey has quit IRC | 00:47 | |
| *** aeng has joined #openstack-infra | 00:58 | |
| *** gordc has quit IRC | 01:00 | |
| *** LindaWang has joined #openstack-infra | 01:01 | |
| *** cuongnv has joined #openstack-infra | 01:02 | |
| *** liujiong has joined #openstack-infra | 01:02 | |
| *** dmsimard has quit IRC | 01:03 | |
| *** Sukhdev has quit IRC | 01:06 | |
| *** jamielennox has quit IRC | 01:08 | |
| *** makowals has quit IRC | 01:08 | |
| ianw | fungi: https://review.openstack.org/#/c/473534 ... am i misreading? | 01:10 |
| *** jamielennox has joined #openstack-infra | 01:15 | |
| *** armax has joined #openstack-infra | 01:16 | |
| *** dmsimard has joined #openstack-infra | 01:17 | |
| *** aeng has quit IRC | 01:17 | |
| *** makowals has joined #openstack-infra | 01:18 | |
| *** harlowja has quit IRC | 01:19 | |
| *** jkilpatr has quit IRC | 01:20 | |
| *** aeng has joined #openstack-infra | 01:23 | |
| openstackgerrit | Merged openstack-infra/puppet-exim master: Add smtp_accept_max and smtp_accept_max_per_host https://review.openstack.org/487451 | 01:25 |
| openstackgerrit | Merged openstack-infra/system-config master: Raise smtp_accept_max for openstack_project::lists https://review.openstack.org/487452 | 01:29 |
| *** rossella__ has quit IRC | 01:30 | |
| *** yamamoto_ has quit IRC | 01:31 | |
| *** bobh has quit IRC | 01:31 | |
| *** rossella__ has joined #openstack-infra | 01:33 | |
| *** gongysh has joined #openstack-infra | 01:35 | |
| *** yamamoto has joined #openstack-infra | 01:35 | |
| *** makowals has quit IRC | 01:38 | |
| *** zhurong has joined #openstack-infra | 01:38 | |
| *** esberglu has quit IRC | 01:43 | |
| *** gongysh has quit IRC | 01:47 | |
| *** thorst has joined #openstack-infra | 01:49 | |
| *** thorst has quit IRC | 01:49 | |
| *** dhajare has joined #openstack-infra | 01:50 | |
| *** dhajare_ has joined #openstack-infra | 01:50 | |
| *** dhajare has quit IRC | 01:50 | |
| *** makowals has joined #openstack-infra | 01:51 | |
| fungi | ianw: i fully believe your comment, though am not in the headspace to trace back through the parent class to confirm the veracity of it just now | 02:00 |
| *** lrossetti has quit IRC | 02:03 | |
| *** Apoorva has quit IRC | 02:03 | |
| *** markvoelker has quit IRC | 02:03 | |
| openstackgerrit | YAMAMOTO Takashi proposed openstack-infra/project-config master: networking-midonet: Add centos-7 experimental jobs for stable/ocata https://review.openstack.org/487661 | 02:04 |
| *** markvoelker has joined #openstack-infra | 02:06 | |
| *** bobh has joined #openstack-infra | 02:17 | |
| *** jamielennox has quit IRC | 02:17 | |
| openstackgerrit | YAMAMOTO Takashi proposed openstack-infra/project-config master: networking-midonet: Add centos-7 experimental jobs for stable/ocata https://review.openstack.org/487661 | 02:19 |
| openstackgerrit | Matt Riedemann proposed openstack-infra/devstack-gate master: Run rabbitmqctl report before saving off rabbitmq logs https://review.openstack.org/487664 | 02:19 |
| *** bobh has quit IRC | 02:22 | |
| *** shu-mutou-AWAY is now known as shu-mutou | 02:22 | |
| *** jamielennox has joined #openstack-infra | 02:24 | |
| *** bobh has joined #openstack-infra | 02:24 | |
| *** yamahata has quit IRC | 02:30 | |
| *** esberglu has joined #openstack-infra | 02:38 | |
| *** baoli has quit IRC | 02:38 | |
| *** liujiong has quit IRC | 02:39 | |
| *** esberglu has quit IRC | 02:42 | |
| *** liujiong has joined #openstack-infra | 02:43 | |
| *** vhosakot has quit IRC | 02:43 | |
| *** sree_ has joined #openstack-infra | 02:47 | |
| *** sree_ is now known as Guest81593 | 02:47 | |
| *** Guest81593 has quit IRC | 02:51 | |
| *** rossella__ has quit IRC | 02:52 | |
| *** rossella__ has joined #openstack-infra | 02:56 | |
| * fungi sighs at the citynet abuse desk | 03:06 | |
| fungi | they must have somebody new handling it who doesn't realize that just because we have a server instance with an ip address matching an abuse complaint doesn't mean we had an instance at that address at the time the incident occurred | 03:07 |
| fungi | i just researched and responded to them on two abuse complaints they forwarded to us where we had no instances using the corresponding ip addresses at the times in question | 03:08 |
| clarkb | kinda like how rax dns blacklists work | 03:10 |
| fungi | yup | 03:10 |
| openstackgerrit | Matt Riedemann proposed openstack-infra/devstack-gate master: Run rabbitmqctl report before saving off rabbitmq logs https://review.openstack.org/487664 | 03:11 |
| fungi | unfortunately it takes a good amount of time to correlate our nodepool launcher and deleter debug logs to assemble sufficient evidence for debunking | 03:11 |
| fungi | because it's entirely possible that someone _might_ have submitted a change which portscanned somebody or attempted to deliver spam | 03:12 |
| fungi | so, you know, we have to make sure to check | 03:13 |
| *** zhurong has quit IRC | 03:13 | |
| *** bobh has quit IRC | 03:21 | |
| *** thorst has joined #openstack-infra | 03:22 | |
| *** vhosakot has joined #openstack-infra | 03:26 | |
| *** thorst has quit IRC | 03:30 | |
| *** harlowja has joined #openstack-infra | 03:31 | |
| openstackgerrit | sebastian marcet proposed openstack-infra/openstackid-resources master: External Calendar Sync https://review.openstack.org/487683 | 03:34 |
| *** psachin has quit IRC | 03:41 | |
| openstackgerrit | Tomasz Trębski proposed openstack-infra/project-config master: Re-enable gates for monasca-events-api https://review.openstack.org/487608 | 03:46 |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Remove extra GC debug info https://review.openstack.org/487622 | 03:48 |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Remove ZUUL_PIPELINE https://review.openstack.org/486250 | 03:50 |
| *** tuanluong has joined #openstack-infra | 03:51 | |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Remove ZUUL_PROJECT https://review.openstack.org/486251 | 03:56 |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Remove ZUUL_UUID https://review.openstack.org/486252 | 03:56 |
| openstackgerrit | Matt Riedemann proposed openstack-infra/devstack-gate master: Run rabbitmqctl report before saving off rabbitmq logs https://review.openstack.org/487664 | 03:56 |
| *** psachin has joined #openstack-infra | 03:58 | |
| *** vhosakot has quit IRC | 04:00 | |
| *** mriedem has quit IRC | 04:02 | |
| *** makowals has quit IRC | 04:04 | |
| *** nicolasbock has joined #openstack-infra | 04:07 | |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul feature/zuulv3: Case sensitive label matching https://review.openstack.org/469946 | 04:09 |
| jeblair | fungi: it may be worth writing a little script to automatically pull that out of logs (and of course, if we need to add anything to logs to assist, we can) | 04:11 |
| fungi | yeah, that would make sense | 04:12 |
| jeblair | i mean, it'd be better if *they* had that script, but hey. | 04:13 |
| fungi | there's a bit of correlation to do between uuids and ip addresses on different loglines | 04:13 |
| fungi | since we may want to check by uuid or by ip address plus timeframe | 04:14 |
| fungi | how much of this is likely to change with zuul v3... none at this point right? | 04:15 |
| jeblair | fungi: the log lines are a bit different in nodepool v3 | 04:15 |
| fungi | in that case i'll make a note to look into it once we have the new log format in production | 04:16 |
| jeblair | fungi: i did a thing in the zuul executor to make sure all of the log lines for a job automatically had the job in in them. we should do the same in nodepool for the node id | 04:16 |
| jeblair | fungi: then it'll be easy to get all the logs for a node. and the script can do a simple two step process: ip -> node; node -> start+end times | 04:16 |
| jeblair | like exigrep does with exim logs | 04:16 |
| fungi | yup | 04:17 |
| fungi | start+end times and nova uuid, since that's useful context for the provider to key on in their logs | 04:18 |
| *** makowals has joined #openstack-infra | 04:22 | |
| *** rama_y has joined #openstack-infra | 04:30 | |
| *** gongysh has joined #openstack-infra | 04:31 | |
| *** links has joined #openstack-infra | 04:33 | |
| *** zhurong has joined #openstack-infra | 04:38 | |
| *** gouthamr has quit IRC | 04:38 | |
| *** sree_ has joined #openstack-infra | 04:42 | |
| *** sree_ is now known as Guest24586 | 04:42 | |
| *** Guest24586 has quit IRC | 04:42 | |
| *** ykarel has joined #openstack-infra | 04:46 | |
| *** rama_y has quit IRC | 04:47 | |
| *** prateek has joined #openstack-infra | 04:52 | |
| *** harlowja has quit IRC | 04:52 | |
| openstackgerrit | Deepak Mourya proposed openstack-infra/os-loganalyze master: Stop ignoring H904 hacking rule in tox https://review.openstack.org/468761 | 05:00 |
| *** yamahata has joined #openstack-infra | 05:01 | |
| *** gongysh has quit IRC | 05:05 | |
| *** gongysh has joined #openstack-infra | 05:10 | |
| *** gongysh has quit IRC | 05:13 | |
| *** thorst has joined #openstack-infra | 05:26 | |
| *** sree_ has joined #openstack-infra | 05:28 | |
| *** sree_ is now known as Guest40093 | 05:28 | |
| *** armax has quit IRC | 05:30 | |
| *** armax has joined #openstack-infra | 05:31 | |
| *** armax has quit IRC | 05:31 | |
| *** armax has joined #openstack-infra | 05:32 | |
| *** gildub has quit IRC | 05:32 | |
| *** armax has quit IRC | 05:32 | |
| *** armax has joined #openstack-infra | 05:33 | |
| *** armax has quit IRC | 05:33 | |
| *** thorst has quit IRC | 05:33 | |
| *** gildub has joined #openstack-infra | 05:37 | |
| *** ccamacho has left #openstack-infra | 05:41 | |
| *** hongbin has joined #openstack-infra | 05:47 | |
| *** jascott1 has joined #openstack-infra | 05:48 | |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul feature/zuulv3: Case sensitive label matching https://review.openstack.org/469946 | 05:50 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul feature/zuulv3: Use correct label casing in tests https://review.openstack.org/487703 | 05:50 |
| *** rossella__ has quit IRC | 05:52 | |
| *** priteau has joined #openstack-infra | 05:55 | |
| *** rossella__ has joined #openstack-infra | 05:56 | |
| *** yuanying has joined #openstack-infra | 05:57 | |
| *** thorst has joined #openstack-infra | 06:01 | |
| yuanying | masayukig: around? | 06:05 |
| *** thorst has quit IRC | 06:05 | |
| *** Guest12964 has quit IRC | 06:05 | |
| *** ramishra has quit IRC | 06:06 | |
| *** ramishra has joined #openstack-infra | 06:08 | |
| *** Guest40093 has quit IRC | 06:09 | |
| openstackgerrit | Dirk Mueller proposed openstack-infra/project-config master: Disable running devstack against openSUSE on stable/ocata and older https://review.openstack.org/487709 | 06:12 |
| *** esberglu has joined #openstack-infra | 06:16 | |
| *** esberglu has quit IRC | 06:21 | |
| yuval | Hey all! Has anyone else experiencing "git review -s" failing because it can not download the commit-msg hook? | 06:22 |
| yuval | *is | 06:22 |
| *** sree_ has joined #openstack-infra | 06:31 | |
| *** sree_ is now known as Guest19469 | 06:31 | |
| *** zhurong has quit IRC | 06:33 | |
| *** kzaitsev_ws has joined #openstack-infra | 06:33 | |
| *** rama_y has joined #openstack-infra | 06:34 | |
| *** aeng has quit IRC | 06:38 | |
| openstackgerrit | Merged openstack-infra/project-config master: Disable swift in OSC py3 job https://review.openstack.org/487211 | 06:39 |
| *** cshastri has joined #openstack-infra | 06:40 | |
| openstackgerrit | Merged openstack-infra/project-config master: Change job type for 3nodes job to move to oooq runner https://review.openstack.org/485590 | 06:41 |
| openstackgerrit | Merged openstack-infra/project-config master: Disable running devstack against openSUSE on stable/ocata and older https://review.openstack.org/487709 | 06:42 |
| openstackgerrit | Merged openstack-infra/project-config master: Add experimental multinode gate for kuryr-k8s https://review.openstack.org/487343 | 06:42 |
| *** florianf has joined #openstack-infra | 06:45 | |
| openstackgerrit | YAMAMOTO Takashi proposed openstack-infra/project-config master: networking-midonet: Exclude v2 jobs from master https://review.openstack.org/486795 | 06:47 |
| *** florianf has quit IRC | 06:50 | |
| *** florianf has joined #openstack-infra | 06:51 | |
| *** priteau has quit IRC | 06:51 | |
| *** markus_z has joined #openstack-infra | 06:51 | |
| *** rossella__ has quit IRC | 06:52 | |
| *** andreas_s has joined #openstack-infra | 06:53 | |
| *** jtomasek_ has joined #openstack-infra | 06:54 | |
| *** rossella__ has joined #openstack-infra | 06:55 | |
| *** kzaitsev_ws has quit IRC | 06:56 | |
| *** flepied has quit IRC | 06:56 | |
| *** dingyichen has quit IRC | 06:57 | |
| *** coolsvap has joined #openstack-infra | 07:01 | |
| masayukig | yuanying: hi | 07:02 |
| yuanying | masayukig: Hi, I remember you took a photo at OpenStack Days Tokyo. Could you share it with me? | 07:03 |
| *** hongbin has quit IRC | 07:04 | |
| yuanying | As you know, my company needs a report which contains picture to decorate | 07:05 |
| *** dingyichen has joined #openstack-infra | 07:06 | |
| *** Hal has joined #openstack-infra | 07:06 | |
| *** Hal is now known as Guest41564 | 07:07 | |
| masayukig | yuanying: ok, sure, but why did you tell me on this channel? :-p | 07:07 |
| yuanying | hehe | 07:07 |
| masayukig | yuanying: ah, | 07:07 |
| *** makowals has quit IRC | 07:08 | |
| masayukig | yuanying: when was your talk? I actually don't have whole of the photos now because the sd-card is not mine but organizer's one.. | 07:09 |
| *** makowals has joined #openstack-infra | 07:09 | |
| openstackgerrit | Merged openstack-infra/project-config master: aodh: run hbase and mongodb tests only on newton https://review.openstack.org/487524 | 07:09 |
| yuanying | Maybe, Friday 14:45 | 07:10 |
| yuanying | masayukig: Is there any plan to share those photo in public? | 07:10 |
| openstackgerrit | Merged openstack-infra/project-config master: Add nova service to kuryr gate https://review.openstack.org/486525 | 07:11 |
| masayukig | yuanying: nice, probably I have that. | 07:11 |
| masayukig | yuanying: I don't have like that plan. They aren't mine. | 07:11 |
| masayukig | yuanying: The organaizer will make it public later, probably, | 07:12 |
| yuanying | masayukig: I got it | 07:12 |
| *** rcernin has joined #openstack-infra | 07:13 | |
| openstackgerrit | Merged openstack-infra/project-config master: Adding more openSUSE 42.3 variants to existing 42.2 jobs https://review.openstack.org/484499 | 07:14 |
| *** jtomasek_ has quit IRC | 07:15 | |
| openstackgerrit | Merged openstack-infra/project-config master: Propose patches to os-service-types from service-types-authority https://review.openstack.org/484407 | 07:15 |
| yuval | Hey all! Is anyone else experiencing "git review -s" failing because it can not download the commit-msg hook? | 07:16 |
| AJaeger | yuval: apparently not ;) which repo? | 07:19 |
| openstackgerrit | Merged openstack-infra/project-config master: karborclient: Publish Documentation https://review.openstack.org/487436 | 07:19 |
| openstackgerrit | Merged openstack-infra/project-config master: Publish python-senlinclient docs https://review.openstack.org/487257 | 07:19 |
| AJaeger | dtantsur, vsaienko, there are a few changes for ironic in project-config, I'd like your guidenance on, see https://review.openstack.org/#/q/owner:agarwalnisha1980%2540gmail.com+status:open+project:openstack-infra/project-config | 07:22 |
| AJaeger | dtantsur|afk, I see you're not around - and vsaienko neither ;( Ok, will continue to ignore them. | 07:23 |
| *** wolverineav has joined #openstack-infra | 07:23 | |
| yuval | AJaeger: rpm-packaging | 07:24 |
| *** HeOS has joined #openstack-infra | 07:25 | |
| AJaeger | yuval: works fine for me.. | 07:26 |
| yuval | AJaeger: thanks :\ | 07:26 |
| *** alexchadin has joined #openstack-infra | 07:26 | |
| AJaeger | yuval: but isn't git-review just adding gerrit as remote? Just copy & edit over from another repo | 07:27 |
| AJaeger | yuval: did you try git review -s --verbose to debug further? | 07:27 |
| *** namnh has joined #openstack-infra | 07:27 | |
| openstackgerrit | Merged openstack-infra/project-config master: Publish some zuul repos https://review.openstack.org/487203 | 07:28 |
| *** flepied has joined #openstack-infra | 07:28 | |
| yuval | AJaeger: nothing useful there | 07:29 |
| yuval | AJaeger: might be because it was cloned using https and not ssh | 07:30 |
| yuval | AJaeger: that was it | 07:31 |
| AJaeger | yuval: yeah, https explains it - you need to set up https access for that | 07:32 |
| *** jtomasek_ has joined #openstack-infra | 07:32 | |
| *** ccamacho has joined #openstack-infra | 07:33 | |
| *** shu-mutou has quit IRC | 07:38 | |
| *** shu-mutou has joined #openstack-infra | 07:38 | |
| *** [HeOS] has joined #openstack-infra | 07:41 | |
| *** HeOS has quit IRC | 07:41 | |
| *** wolverineav has quit IRC | 07:45 | |
| *** ralonsoh has joined #openstack-infra | 07:46 | |
| *** jtomasek has quit IRC | 07:46 | |
| *** jtomasek_ is now known as jtomasek | 07:48 | |
| *** egonzalez has joined #openstack-infra | 07:48 | |
| *** ralonsoh has quit IRC | 07:52 | |
| *** ralonsoh has joined #openstack-infra | 07:52 | |
| *** jaosorior has joined #openstack-infra | 07:52 | |
| *** hashar has joined #openstack-infra | 07:59 | |
| *** thorst has joined #openstack-infra | 08:02 | |
| *** gildub has quit IRC | 08:04 | |
| *** esberglu has joined #openstack-infra | 08:04 | |
| *** dizquierdo has joined #openstack-infra | 08:04 | |
| *** thorst has quit IRC | 08:06 | |
| *** esberglu has quit IRC | 08:08 | |
| *** markmcd has quit IRC | 08:10 | |
| *** e0ne has joined #openstack-infra | 08:11 | |
| *** markmcd has joined #openstack-infra | 08:13 | |
| *** jascott1 has quit IRC | 08:14 | |
| *** jascott1 has joined #openstack-infra | 08:15 | |
| *** lucas-afk is now known as lucasagomes | 08:18 | |
| *** jascott1 has quit IRC | 08:20 | |
| *** claudiub has joined #openstack-infra | 08:21 | |
| *** efoley has joined #openstack-infra | 08:28 | |
| mrmartin | morgen | 08:30 |
| mrmartin | AJaeger hi, do you know who can I find the url of the release job logs for this patch: https://review.openstack.org/#/c/487508/ ? | 08:31 |
| *** derekh has joined #openstack-infra | 08:31 | |
| *** electrofelix has joined #openstack-infra | 08:31 | |
| *** dpawlik has quit IRC | 08:32 | |
| *** danpawlik has joined #openstack-infra | 08:34 | |
| *** gildub has joined #openstack-infra | 08:36 | |
| rm_work | did review.openstack.org go down or is it just me <_< | 08:36 |
| *** gongysh has joined #openstack-infra | 08:36 | |
| mrmartin | rm_work: working well here | 08:38 |
| *** e0ne has quit IRC | 08:40 | |
| *** e0ne has joined #openstack-infra | 08:42 | |
| *** dtantsur|afk is now known as dtantsur | 08:44 | |
| dtantsur | hi AJaeger, I'll put them on my list, thanks! | 08:44 |
| rm_work | hmmm | 08:46 |
| rm_work | IRC works... | 08:46 |
| rm_work | other websites work... | 08:47 |
| rm_work | probably something with my VPN :/ | 08:47 |
| openstackgerrit | YAMAMOTO Takashi proposed openstack-infra/project-config master: networking-midonet: Enable centos-7 jobs for stable/ocata https://review.openstack.org/487763 | 08:49 |
| *** gildub has quit IRC | 08:51 | |
| *** dingyichen has quit IRC | 08:52 | |
| AJaeger | mrmartin: https://docs.openstack.org/infra/manual/developers.html#code-review explains how to find the URL | 08:53 |
| mrmartin | thanks! | 08:53 |
| *** e0ne has quit IRC | 08:54 | |
| *** e0ne has joined #openstack-infra | 08:54 | |
| rm_work | yep GD VPN stopped connecting to review.os.org <_< | 08:54 |
| *** priteau has joined #openstack-infra | 08:55 | |
| AJaeger | dtantsur: thanks! Note that I will wait with a +2 review these until I see you or vsaienko +1 these first... | 08:58 |
| dtantsur | AJaeger: sure, yeah. sorry for losing these from my radar | 08:58 |
| *** priteau has quit IRC | 08:59 | |
| *** priteau has joined #openstack-infra | 08:59 | |
| AJaeger | dtantsur: no worries - I was not sure whether this was a single effort or whether it was team driven... | 09:00 |
| *** yamahata has quit IRC | 09:01 | |
| openstackgerrit | Merged openstack-infra/project-config master: Re-enable gates for monasca-events-api https://review.openstack.org/487608 | 09:07 |
| *** yolanda has quit IRC | 09:11 | |
| openstackgerrit | Merged openstack-infra/project-config master: networking-midonet: Exclude v2 jobs from master https://review.openstack.org/486795 | 09:12 |
| *** yolanda has joined #openstack-infra | 09:12 | |
| openstackgerrit | Merged openstack-infra/project-config master: Enable neutron segment feature in OSC jobs https://review.openstack.org/486983 | 09:13 |
| openstackgerrit | Merged openstack-infra/project-config master: new-project: vmware-nsx-tempest-plugin https://review.openstack.org/484990 | 09:13 |
| *** sambetts|afk is now known as sambetts | 09:14 | |
| openstackgerrit | Merged openstack-infra/project-config master: Add barbican-tempest-plugin tests to Glance https://review.openstack.org/486781 | 09:16 |
| *** kjackal_ has joined #openstack-infra | 09:19 | |
| *** shu-mutou is now known as shu-mutou-AWAY | 09:20 | |
| openstackgerrit | Mike Fedosin proposed openstack-infra/project-config master: Glare - Zuul/Jenkins update https://review.openstack.org/486418 | 09:21 |
| *** wolverineav has joined #openstack-infra | 09:23 | |
| openstackgerrit | YAMAMOTO Takashi proposed openstack-infra/project-config master: networking-midonet: Add centos-7 experimental jobs for stable/ocata https://review.openstack.org/487661 | 09:27 |
| openstackgerrit | YAMAMOTO Takashi proposed openstack-infra/project-config master: networking-midonet: Enable centos-7 jobs for stable/ocata https://review.openstack.org/487763 | 09:27 |
| *** wolverineav has quit IRC | 09:27 | |
| *** e0ne has quit IRC | 09:32 | |
| kklimonda | with zuul, can I define a relation between checks, so some of them (like building binary packages) run before others? | 09:37 |
| *** e0ne has joined #openstack-infra | 09:37 | |
| AJaeger | kklimonda: why do you want this? | 09:39 |
| kklimonda | AJaeger: I want to build a set of binary packages, and then test them against a number of OS releases. | 09:40 |
| *** wolverineav has joined #openstack-infra | 09:42 | |
| AJaeger | kklimonda: See change 476989 on how this could be done, but this needs careful design. | 09:44 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack-infra/project-config master: Normalize projects.yaml https://review.openstack.org/487794 | 09:44 |
| AJaeger | kklimonda: sorry, no time for further discussion right now... | 09:44 |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Allow loading additional variables file for site config https://review.openstack.org/447734 | 09:50 |
| *** dtantsur is now known as dtantsur|bbl | 09:51 | |
| *** esberglu has joined #openstack-infra | 09:52 | |
| *** masber has quit IRC | 09:55 | |
| *** sdague has joined #openstack-infra | 09:55 | |
| *** martinkopec has joined #openstack-infra | 09:56 | |
| *** esberglu has quit IRC | 09:57 | |
| *** alexchadin has quit IRC | 09:57 | |
| *** cuongnv has quit IRC | 10:00 | |
| *** yamamoto has quit IRC | 10:00 | |
| *** makowals has quit IRC | 10:02 | |
| *** thorst has joined #openstack-infra | 10:03 | |
| *** makowals has joined #openstack-infra | 10:04 | |
| kklimonda | AJaeger: thanks, I'll take a look at how kolla tests are done in general, perhaps talk to the kolla folks too. | 10:06 |
| *** thorst has quit IRC | 10:07 | |
| *** alexchadin has joined #openstack-infra | 10:11 | |
| *** sshnaidm|afk is now known as sshnaidm | 10:13 | |
| *** dizquierdo has quit IRC | 10:16 | |
| *** katkapilatova has joined #openstack-infra | 10:23 | |
| *** thorst has joined #openstack-infra | 10:24 | |
| *** rlandy has joined #openstack-infra | 10:28 | |
| *** thorst has quit IRC | 10:28 | |
| *** yamamoto has joined #openstack-infra | 10:31 | |
| *** wfoster has quit IRC | 10:36 | |
| *** rook has quit IRC | 10:37 | |
| *** lucasagomes has quit IRC | 10:37 | |
| *** thorst has joined #openstack-infra | 10:47 | |
| openstackgerrit | Ronelle Landy proposed openstack-infra/tripleo-ci master: Add settings for OVB in RDO Cloud https://review.openstack.org/480950 | 10:47 |
| *** thorst has quit IRC | 10:51 | |
| *** gildub has joined #openstack-infra | 11:00 | |
| *** dizquierdo has joined #openstack-infra | 11:03 | |
| *** dizquierdo_ has joined #openstack-infra | 11:06 | |
| *** dizquierdo has quit IRC | 11:08 | |
| *** jkilpatr has joined #openstack-infra | 11:10 | |
| *** liujiong has quit IRC | 11:13 | |
| *** [HeOS] has quit IRC | 11:13 | |
| *** wfoster has joined #openstack-infra | 11:15 | |
| *** lucasagomes has joined #openstack-infra | 11:16 | |
| *** kazsh has quit IRC | 11:18 | |
| *** rook has joined #openstack-infra | 11:18 | |
| *** rook is now known as Guest40098 | 11:19 | |
| *** kazsh has joined #openstack-infra | 11:19 | |
| *** namnh has quit IRC | 11:20 | |
| *** alexchadin has quit IRC | 11:20 | |
| openstackgerrit | Gabriele Cerami proposed openstack-infra/tripleo-ci master: WIP: containers periodic test https://review.openstack.org/475747 | 11:21 |
| *** [HeOS] has joined #openstack-infra | 11:31 | |
| *** ldnunes has joined #openstack-infra | 11:37 | |
| *** esberglu has joined #openstack-infra | 11:40 | |
| *** kgiusti has quit IRC | 11:41 | |
| *** jamesden_ has joined #openstack-infra | 11:44 | |
| *** esberglu has quit IRC | 11:44 | |
| *** jamesdenton has quit IRC | 11:45 | |
| *** tuanluong has quit IRC | 11:47 | |
| *** apuimedo has quit IRC | 11:49 | |
| *** thorst has joined #openstack-infra | 11:54 | |
| *** baoli has joined #openstack-infra | 11:56 | |
| *** jokke_ has joined #openstack-infra | 11:58 | |
| *** kjackal_ has quit IRC | 12:00 | |
| *** Guest40098 is now known as rook | 12:01 | |
| *** apuimedo has joined #openstack-infra | 12:03 | |
| *** trown|outtypewww is now known as trown | 12:05 | |
| *** gildub has quit IRC | 12:06 | |
| *** kjackal_ has joined #openstack-infra | 12:10 | |
| *** _nick is now known as yankcrime | 12:11 | |
| *** jcoufal has joined #openstack-infra | 12:13 | |
| *** yamamoto has quit IRC | 12:14 | |
| *** sarlango has quit IRC | 12:21 | |
| *** dizquierdo_ has quit IRC | 12:24 | |
| *** gongysh has quit IRC | 12:24 | |
| *** psachin has quit IRC | 12:26 | |
| *** mriedem has joined #openstack-infra | 12:27 | |
| *** bobh has joined #openstack-infra | 12:28 | |
| *** jcoufal_ has joined #openstack-infra | 12:28 | |
| *** jcoufal has quit IRC | 12:31 | |
| *** gordc has joined #openstack-infra | 12:34 | |
| *** Guest19469 has quit IRC | 12:35 | |
| *** [HeOS] has quit IRC | 12:36 | |
| *** bobh has quit IRC | 12:37 | |
| *** dizquierdo_ has joined #openstack-infra | 12:37 | |
| *** lewo has quit IRC | 12:39 | |
| *** kgiusti has joined #openstack-infra | 12:39 | |
| openstackgerrit | Matt Riedemann proposed openstack-infra/devstack-gate master: Run rabbitmqctl report before saving off rabbitmq logs https://review.openstack.org/487664 | 12:41 |
| openstackgerrit | Matt Riedemann proposed openstack-infra/devstack-gate master: Fix existence check for $BASE/logs/rabbitmq/ in cleanup_host https://review.openstack.org/487829 | 12:41 |
| *** apuimedo has quit IRC | 12:42 | |
| *** apuimedo has joined #openstack-infra | 12:42 | |
| fungi | infra-root: heads up, i'm not around much today; between friends visiting and now some incident with the lines coming over the bridge i'm without broadband internet access for who knows how long but i'll try to check in a few times via my backup wireless modem | 12:45 |
| smcginnis | fungi: Your ISP is trying to tell you something. | 12:46 |
| fungi | apparently | 12:46 |
| fungi | same incident also knocked out power for the next island south of us | 12:47 |
| TheJulia | fun :( | 12:47 |
| fungi | chatter is could be days before they get it restored | 12:47 |
| fungi | i'll gladly take flaky wireless network access over days without power | 12:48 |
| *** askb has quit IRC | 12:50 | |
| *** sree has joined #openstack-infra | 12:50 | |
| openstackgerrit | Rob Cresswell proposed openstack-infra/project-config master: Update Horizon & D_O_A jobs https://review.openstack.org/487834 | 12:51 |
| *** links has quit IRC | 12:52 | |
| *** trown is now known as trown|brb | 12:55 | |
| *** sree has quit IRC | 12:55 | |
| openstackgerrit | Rob Cresswell proposed openstack-infra/project-config master: Update Horizon & D_O_A jobs https://review.openstack.org/487834 | 12:55 |
| AJaeger | odyssey4me: could you review https://review.openstack.org/#/c/486602/ , please? | 12:57 |
| odyssey4me | sure, looking | 12:57 |
| AJaeger | thanks | 12:57 |
| *** trown|brb is now known as trown | 13:00 | |
| *** bh526r has joined #openstack-infra | 13:02 | |
| *** gcb has quit IRC | 13:02 | |
| *** gcb has joined #openstack-infra | 13:04 | |
| *** rhallisey has joined #openstack-infra | 13:07 | |
| *** [HeOS] has joined #openstack-infra | 13:11 | |
| *** yamamoto has joined #openstack-infra | 13:14 | |
| *** dhajare_ has quit IRC | 13:15 | |
| *** LindaWang has quit IRC | 13:16 | |
| *** spzala has joined #openstack-infra | 13:16 | |
| *** Goneri has joined #openstack-infra | 13:19 | |
| *** yamamoto has quit IRC | 13:21 | |
| openstackgerrit | Andreas Jaeger proposed openstack-infra/infra-manual master: Describe Zuul v3 job naming https://review.openstack.org/487848 | 13:23 |
| *** esberglu has joined #openstack-infra | 13:23 | |
| AJaeger | jeblair, pabelanger, mordred, I'll abandon my Zuul v3 job naming spec now, here's current proposal ^ | 13:24 |
| *** esberglu has quit IRC | 13:24 | |
| *** esberglu has joined #openstack-infra | 13:24 | |
| *** alexchadin has joined #openstack-infra | 13:25 | |
| *** eharney has joined #openstack-infra | 13:28 | |
| *** LindaWang has joined #openstack-infra | 13:30 | |
| *** gouthamr has joined #openstack-infra | 13:31 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul feature/zuulv3: Collect logging information into ara callback https://review.openstack.org/487853 | 13:32 |
| *** alexchadin has quit IRC | 13:35 | |
| *** liujiong has joined #openstack-infra | 13:36 | |
| *** adarazs is now known as adarazs_brb | 13:37 | |
| *** bobh has joined #openstack-infra | 13:38 | |
| *** bobh has quit IRC | 13:43 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul feature/zuulv3: Collect logging information into ara callback https://review.openstack.org/487853 | 13:43 |
| openstackgerrit | Spyros Trigazis (strigazi) proposed openstack-infra/project-config master: [magnum] make legacy swarm -nv https://review.openstack.org/487858 | 13:47 |
| *** spzala has quit IRC | 13:49 | |
| *** jaypipes has joined #openstack-infra | 13:50 | |
| *** spzala has joined #openstack-infra | 13:50 | |
| *** spzala has quit IRC | 13:54 | |
| *** adarazs_brb is now known as adarazs | 13:55 | |
| *** jcoufal has joined #openstack-infra | 13:56 | |
| *** baoli has quit IRC | 13:57 | |
| *** jcoufal_ has quit IRC | 13:59 | |
| *** jcoufal_ has joined #openstack-infra | 14:00 | |
| *** baoli has joined #openstack-infra | 14:02 | |
| *** jcoufal__ has joined #openstack-infra | 14:02 | |
| *** jcoufal has quit IRC | 14:03 | |
| *** jcoufal_ has quit IRC | 14:05 | |
| *** prateek has quit IRC | 14:06 | |
| *** rwsu has quit IRC | 14:10 | |
| *** kjackal_ has quit IRC | 14:12 | |
| *** sree has joined #openstack-infra | 14:14 | |
| *** brucet has joined #openstack-infra | 14:15 | |
| *** jascott1 has joined #openstack-infra | 14:17 | |
| *** rbrndt has joined #openstack-infra | 14:18 | |
| *** sree has quit IRC | 14:18 | |
| *** bobh has joined #openstack-infra | 14:18 | |
| strigazi | AJaeger fungi can you have a look? ^^ | 14:20 |
| *** spzala has joined #openstack-infra | 14:21 | |
| *** jascott1 has quit IRC | 14:22 | |
| openstackgerrit | Marton Kiss proposed openstack-infra/groups master: Remove patchset #1805690 from drupal core https://review.openstack.org/487868 | 14:22 |
| *** spzala_ has joined #openstack-infra | 14:23 | |
| AJaeger | strigazi: it's always good if a commit message explains not only what you do but also why | 14:23 |
| *** jamesden_ has quit IRC | 14:23 | |
| strigazi | AJaeger ok | 14:24 |
| *** jamesdenton has joined #openstack-infra | 14:25 | |
| *** spzala has quit IRC | 14:25 | |
| *** funzo has quit IRC | 14:27 | |
| openstackgerrit | Gabriele Cerami proposed openstack-infra/tripleo-ci master: WIP: containers periodic test https://review.openstack.org/475747 | 14:27 |
| openstackgerrit | Spyros Trigazis (strigazi) proposed openstack-infra/project-config master: [magnum] make legacy swarm -nv https://review.openstack.org/487858 | 14:30 |
| *** marst has joined #openstack-infra | 14:33 | |
| openstackgerrit | Merged openstack-infra/groups master: Remove patchset #1805690 from drupal core https://review.openstack.org/487868 | 14:34 |
| openstackgerrit | Ronelle Landy proposed openstack-infra/tripleo-ci master: Add IPMI validation before undercloud deploy https://review.openstack.org/484462 | 14:34 |
| *** ykarel has quit IRC | 14:38 | |
| *** dtantsur|bbl is now known as dtantsur | 14:39 | |
| *** armax has joined #openstack-infra | 14:39 | |
| openstackgerrit | Bradley Jones proposed openstack-infra/project-config master: Add gate for testing microservice ansible deployment https://review.openstack.org/487875 | 14:39 |
| *** jamesdenton has quit IRC | 14:39 | |
| *** jamesdenton has joined #openstack-infra | 14:40 | |
| *** xarses_ has joined #openstack-infra | 14:41 | |
| *** hashar has quit IRC | 14:41 | |
| ttx | Hey infra-core, the release team needs some urgent review love on https://review.openstack.org/#/c/483274/ before we start mass-creating stable/pike branches | 14:41 |
| ttx | We pinged sdague and mtreinish already | 14:41 |
| sdague | AJaeger: https://review.openstack.org/#/c/487863/ - it's an auto generated xml file that crashes browsers to review it | 14:43 |
| sdague | is there any reason it's not auto approved? | 14:43 |
| dhellmann | sdague : I have Plans(tm) to change the way we generate sitemaps during queens so we don't need to review them at all | 14:43 |
| *** andreww has joined #openstack-infra | 14:44 | |
| *** andreww has quit IRC | 14:45 | |
| *** jcoufal has joined #openstack-infra | 14:45 | |
| *** xarses_ has quit IRC | 14:46 | |
| fungi | ttx: dhellmann: looking now | 14:46 |
| *** andreww has joined #openstack-infra | 14:47 | |
| *** jcoufal__ has quit IRC | 14:48 | |
| fungi | lgtm | 14:48 |
| *** cshastri has quit IRC | 14:48 | |
| fungi | should probably get periodic stable/pike jobs added soon as well | 14:48 |
| *** sree has joined #openstack-infra | 14:49 | |
| sdague | dhellmann: well regardless, it would be good to get that out there so that all the links aren't 404s | 14:52 |
| sdague | which they currently are | 14:52 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: [DNM] larger LVM testing https://review.openstack.org/486864 | 14:52 |
| dhellmann | sdague : oh, sure, I just meant that it would address the issue of auto-approving that you mentioned | 14:52 |
| AJaeger | sdague: we updated the sitemap a week ago, so this is only a "minor" update, not everything is broken - only a lot is moving around right now... | 14:53 |
| *** Swami has joined #openstack-infra | 14:53 | |
| *** jcoufal_ has joined #openstack-infra | 14:54 | |
| sdague | AJaeger: ok, it would be good to be updating this more frequently then | 14:56 |
| sdague | because a week of 404s from google ends up really mudying things up | 14:56 |
| *** jcoufal has quit IRC | 14:56 | |
| AJaeger | sdague: we had done this in the past only once with every release. | 14:59 |
| AJaeger | But yeah, right now we need to do it more often... | 14:59 |
| sdague | AJaeger: sure, but right now we're sending a lot of people looking for answers into a black hole :) | 14:59 |
| AJaeger | sdague: dhellmann has an idea for a superior solution (update with each publish)... | 14:59 |
| sdague | https://docs.openstack.org/nova/latest/cells.html ... very not good | 14:59 |
| sdague | sure, superior is fine for the future. :) | 15:00 |
| sdague | but this is about the now. Mostly I'm just not understanding why https://review.openstack.org/#/c/487863/ is not +Aed already | 15:00 |
| *** brucet has quit IRC | 15:02 | |
| *** rcernin has quit IRC | 15:03 | |
| *** links has joined #openstack-infra | 15:04 | |
| *** baoli has quit IRC | 15:06 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack-infra/tripleo-ci master: TLS-everywhere: Explicitly set overcloud_domain_name https://review.openstack.org/487899 | 15:06 |
| openstackgerrit | Rob Cresswell proposed openstack-infra/project-config master: Update Horizon & D_O_A jobs https://review.openstack.org/487834 | 15:06 |
| *** links has quit IRC | 15:07 | |
| *** annegentle has joined #openstack-infra | 15:07 | |
| *** LindaWang has quit IRC | 15:07 | |
| *** baoli has joined #openstack-infra | 15:09 | |
| *** jamesdenton has quit IRC | 15:13 | |
| *** dmsimard is now known as dmsimard|afk | 15:14 | |
| *** jamesdenton has joined #openstack-infra | 15:15 | |
| *** waynr has quit IRC | 15:15 | |
| *** annegentle has quit IRC | 15:16 | |
| *** rama_y has quit IRC | 15:16 | |
| *** annegentle has joined #openstack-infra | 15:17 | |
| *** jcoufal has joined #openstack-infra | 15:18 | |
| *** [HeOS] has quit IRC | 15:19 | |
| *** wolverineav has quit IRC | 15:19 | |
| *** jamesden_ has joined #openstack-infra | 15:20 | |
| *** jamesdenton has quit IRC | 15:20 | |
| *** [HeOS] has joined #openstack-infra | 15:20 | |
| *** annegentle has quit IRC | 15:21 | |
| *** jcoufal_ has quit IRC | 15:21 | |
| *** sree has quit IRC | 15:23 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/project-config master: Add gtest-org/gtest project to zuulv3.o.o https://review.openstack.org/487905 | 15:26 |
| pabelanger | jeblair: mordred: I believe ^ is the first step to adding github project into zuulv3 | 15:26 |
| *** camunoz has joined #openstack-infra | 15:26 | |
| pabelanger | I am not sure if the github integration is setup on gtest-org however | 15:27 |
| pabelanger | not sure where I would check that | 15:27 |
| *** wolverineav has joined #openstack-infra | 15:27 | |
| *** mat128 has joined #openstack-infra | 15:29 | |
| *** andreas_s has quit IRC | 15:29 | |
| *** skelso has joined #openstack-infra | 15:29 | |
| *** katkapilatova has left #openstack-infra | 15:30 | |
| *** annegentle has joined #openstack-infra | 15:30 | |
| *** jcoufal_ has joined #openstack-infra | 15:31 | |
| *** martinkopec has quit IRC | 15:32 | |
| *** psachin has joined #openstack-infra | 15:32 | |
| mrmartin | fungi: hi, as puppetboard.o.o is not working, where can I see the logs of the last puppet run for a host? | 15:33 |
| *** camunoz has quit IRC | 15:33 | |
| *** jcoufal has quit IRC | 15:33 | |
| mordred | pabelanger: I can do that real quick | 15:33 |
| *** wolverineav has quit IRC | 15:34 | |
| *** baoli has quit IRC | 15:34 | |
| *** baoli has joined #openstack-infra | 15:35 | |
| *** gyee has joined #openstack-infra | 15:35 | |
| *** claudiub has quit IRC | 15:37 | |
| mordred | pabelanger: "Alright, OpenStack Zuul was installed on the @gtest-org account." - I went ahead and just added it to the whole org | 15:37 |
| pabelanger | mordred: great | 15:37 |
| clarkb | I'm not sure if everyone saw, but yesterday I got zuul working with gerrit 2.13 on review-dev. It did require the use of tobiash's case sensitivity change. Also confirmed that the gerrit events will emit vote values even if already set to that value. This means recheck on a verified +1 will result in gating | 15:37 |
| fungi | mrmartin: puppetboard got deprecated a couple years ago when we ceased being able to update it for modern puppet, and then we switched to ansible for a bunch of the higher-level parts... the hope is that we can use ara for that though for the moment the only place we publicly expose ansible/puppet events is via mqtt from firehose.openstack.org (and the ansible events there might still be broken until | 15:37 |
| fungi | https://review.openstack.org/485275 gets approved) | 15:37 |
| mordred | pabelanger: we should probably add a doc somewhere on this - I can make a patch - basic process is to go to https://github.com/apps/openstack-zuul then click some buttons | 15:37 |
| *** rossella__ has quit IRC | 15:38 | |
| *** annegentle has quit IRC | 15:38 | |
| *** Douhet has quit IRC | 15:39 | |
| pabelanger | mordred: Ah, I see. Cool | 15:39 |
| *** Douhet has joined #openstack-infra | 15:40 | |
| *** rossella__ has joined #openstack-infra | 15:41 | |
| mrmartin | fungi: will be great to remove the entire puppetboard.o.o instance / domain. | 15:42 |
| mrmartin | will / would be | 15:42 |
| fungi | mrmartin: i agree, i think we had agreed to do that a while back but nobody has tackled it yet | 15:43 |
| pabelanger | fungi: mrmartin: https://review.openstack.org/#/c/449167/ | 15:43 |
| pabelanger | should rebase to get out of merge conflict | 15:43 |
| fungi | oh, excellent | 15:43 |
| fungi | thanks pabelanger | 15:43 |
| pabelanger | let me clean it up quickly | 15:44 |
| *** sambetts is now known as sambetts|afk | 15:45 | |
| *** e0ne has quit IRC | 15:47 | |
| *** camunoz has joined #openstack-infra | 15:48 | |
| *** hongbin has joined #openstack-infra | 15:48 | |
| *** spzala_ has quit IRC | 15:49 | |
| *** liujiong has quit IRC | 15:49 | |
| *** baoli has quit IRC | 15:49 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/system-config master: Remove puppetdb / puppetboard server https://review.openstack.org/449167 | 15:51 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: [DNM] larger LVM testing https://review.openstack.org/486864 | 15:51 |
| *** Swami has quit IRC | 15:54 | |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Fix race in test_periodic_override https://review.openstack.org/487917 | 15:54 |
| *** efoley has quit IRC | 15:56 | |
| *** baoli has joined #openstack-infra | 15:57 | |
| *** rama_y has joined #openstack-infra | 16:00 | |
| *** egonzalez has quit IRC | 16:02 | |
| openstackgerrit | Daniel Mellado proposed openstack-infra/project-config master: Enable Octavia Variant https://review.openstack.org/487928 | 16:08 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul-jobs master: WIP: Simplify run tox task https://review.openstack.org/487551 | 16:08 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Don't request empty nodesets https://review.openstack.org/487243 | 16:10 |
| *** spzala has joined #openstack-infra | 16:11 | |
| clarkb | fungi: sdague https://review.openstack.org/#/c/486676/ is a d-g change to address an error we sometimes see in rackspace. ianw has already +2'd | 16:13 |
| sdague | bam! | 16:14 |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Fix race in test_periodic_override https://review.openstack.org/487917 | 16:14 |
| clarkb | sdague: tyty | 16:14 |
| *** spzala has quit IRC | 16:15 | |
| pabelanger | mordred: care to review: https://review.openstack.org/#/c/487905/ re: gtest-org patch | 16:16 |
| clarkb | pabelanger: not sure if it affects you are not but I've already got a zuul.yaml in there and have used it as a trusted project on my gerrit 2.13 test setup. | 16:18 |
| clarkb | pabelanger: it is configured to run check and gate noop jobs. I think you can delete that config or replace it at this point though as I got review-dev and zuulv3 working yesterday | 16:18 |
| pabelanger | clarkb: okay, I can use another repo if needed too | 16:18 |
| mordred | pabelanger: yah - let's use a different repo so we don't step on clarkb | 16:19 |
| pabelanger | ++ | 16:19 |
| mordred | pabelanger: in fact ... one sec | 16:19 |
| clarkb | sorry I picked gtest bceause I already had it cloned and was using it for other testing when I upgraded gerrit to 2.13 | 16:19 |
| pabelanger | clarkb: np! We can update | 16:20 |
| mordred | pabelanger: https://github.com/gtest-org/ansible how about we use that, since the main thing we want to initial test is the shade-ansible test anyway | 16:20 |
| mordred | pabelanger: that way we can write non-throwaway content but not bother anybody | 16:20 |
| pabelanger | mordred: Ah, I considered doing that :D | 16:20 |
| mordred | pabelanger: :) | 16:20 |
| *** ramishra has quit IRC | 16:21 | |
| *** funzo has joined #openstack-infra | 16:21 | |
| *** funzo has quit IRC | 16:21 | |
| *** funzo has joined #openstack-infra | 16:21 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/project-config master: Add gtest-org/ansible project to zuulv3.o.o https://review.openstack.org/487905 | 16:21 |
| *** mat128 has quit IRC | 16:24 | |
| openstackgerrit | Daniel Mellado proposed openstack-infra/project-config master: Enable Octavia Variant https://review.openstack.org/487928 | 16:24 |
| *** eumel8 has joined #openstack-infra | 16:25 | |
| openstackgerrit | Frank Kloeker proposed openstack-infra/system-config master: Installation of i18n-checksite.openstack.org https://review.openstack.org/487936 | 16:25 |
| eumel8 | don't know if this right | 16:26 |
| *** ccamacho has left #openstack-infra | 16:27 | |
| *** ralonsoh has quit IRC | 16:28 | |
| *** spzala has joined #openstack-infra | 16:29 | |
| *** psachin has quit IRC | 16:32 | |
| *** spzala has quit IRC | 16:33 | |
| ianychoi | eumel8, then openstack-infra/puppet-translation_checksite is not needed if the review ^ works? | 16:33 |
| eumel8 | yes, it's for the cloud museum | 16:34 |
| fungi | i'm sure we have a fine spot in the display case for that | 16:37 |
| eumel8 | I've added some reviewers yet. Maybe Andy has a better idea to implement that | 16:39 |
| *** vhosakot has joined #openstack-infra | 16:43 | |
| *** jcoufal has joined #openstack-infra | 16:46 | |
| *** jcoufal_ has quit IRC | 16:49 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/system-config master: Document Zuul v3 GitHub integration https://review.openstack.org/487941 | 16:54 |
| openstackgerrit | Monty Taylor proposed openstack-infra/system-config master: Fix a few docs table of contents references https://review.openstack.org/487942 | 16:54 |
| mordred | pabelanger: ^^ there's the missing docs on the setup | 16:56 |
| *** Apoorva has joined #openstack-infra | 16:59 | |
| *** baoli has quit IRC | 16:59 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/openstack-zuul-jobs master: Switch to use tox_chdir for tox-py35-on-zuul job https://review.openstack.org/487948 | 17:00 |
| *** bh526r has quit IRC | 17:00 | |
| pabelanger | mordred: great | 17:01 |
| *** hyakuhei has quit IRC | 17:02 | |
| *** hyakuhei has joined #openstack-infra | 17:02 | |
| *** hyakuhei has quit IRC | 17:02 | |
| *** hyakuhei has joined #openstack-infra | 17:02 | |
| *** spzala has joined #openstack-infra | 17:02 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/openstack-zuul-jobs master: WIP: Switch to use tox_chdir for tox-py35-on-zuul job https://review.openstack.org/487948 | 17:02 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul-jobs master: WIP: Simplify run tox task https://review.openstack.org/487551 | 17:02 |
| openstackgerrit | Merged openstack-infra/devstack-gate master: Set up stable/pike https://review.openstack.org/483274 | 17:03 |
| *** derekh has quit IRC | 17:03 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/project-config master: Start storing results with the SQL reporter https://review.openstack.org/487950 | 17:03 |
| openstackgerrit | Frank Kloeker proposed openstack-infra/system-config master: Installation of i18n-checksite.openstack.org https://review.openstack.org/487936 | 17:03 |
| *** skelso has quit IRC | 17:04 | |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Case sensitive label matching https://review.openstack.org/469946 | 17:05 |
| openstackgerrit | Ken Giusti proposed openstack-infra/project-config master: Temporarily disable voting on non-rabbit oslo.messaging jobs https://review.openstack.org/487951 | 17:05 |
| *** baoli has joined #openstack-infra | 17:06 | |
| *** spzala has quit IRC | 17:06 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul-jobs master: WIP: Simplify run tox task https://review.openstack.org/487551 | 17:07 |
| openstackgerrit | Merged openstack-infra/project-config master: Add gtest-org/ansible project to zuulv3.o.o https://review.openstack.org/487905 | 17:07 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul-jobs master: WIP: Simplify run tox task https://review.openstack.org/487551 | 17:09 |
| *** harlowja has joined #openstack-infra | 17:09 | |
| *** baoli has quit IRC | 17:10 | |
| *** baoli has joined #openstack-infra | 17:11 | |
| jeblair | mordred: nice docs! | 17:12 |
| *** spzala has joined #openstack-infra | 17:13 | |
| *** xarses_ has joined #openstack-infra | 17:15 | |
| mordred | jeblair: thanks! I'm making another followup patch to that ... | 17:16 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul-jobs master: WIP: Simplify run tox task https://review.openstack.org/487551 | 17:16 |
| *** rcernin has joined #openstack-infra | 17:16 | |
| *** spzala has quit IRC | 17:17 | |
| *** skelso has joined #openstack-infra | 17:17 | |
| *** xarses has quit IRC | 17:18 | |
| *** jcoufal_ has joined #openstack-infra | 17:18 | |
| mnaser | im getting a bunch of job timeouts for puppet-openstack-integration for puppet modules throughout the day today | 17:19 |
| mnaser | is there a provider that is seeing slowness or are we onto an issue? | 17:19 |
| *** mat128 has joined #openstack-infra | 17:20 | |
| clarkb | mnaser: I'm not aware of any region/provider specific slowness out of the ordinary | 17:21 |
| clarkb | we do try to track generic timeouts though with e-r | 17:21 |
| *** jcoufal has quit IRC | 17:21 | |
| clarkb | (so there is a query you can click on on the e-r status page to see them and can be used to see if a region is particularly bad) | 17:22 |
| mnaser | for example just today i had these two - http://logs.openstack.org/27/487927/1/check/gate-puppet-openstack-integration-4-scenario002-tempest-centos-7/47712fb/console.html and http://logs.openstack.org/17/487617/2/check/gate-puppet-openstack-integration-4-scenario001-tempest-centos-7/574e3ec/ | 17:22 |
| mnaser | seem to be mostly puppet-openstack jobs so i wonder if there is something there | 17:23 |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Use correct label casing in tests https://review.openstack.org/487703 | 17:23 |
| *** dtantsur is now known as dtantsur|afk | 17:24 | |
| openstackgerrit | James E. Blair proposed openstack-infra/project-config master: Capitalize gerrit labels in zuulv3 config https://review.openstack.org/487955 | 17:26 |
| *** Douhet has quit IRC | 17:26 | |
| *** Douhet has joined #openstack-infra | 17:26 | |
| *** Apoorva_ has joined #openstack-infra | 17:26 | |
| *** spzala has joined #openstack-infra | 17:26 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/project-config master: Start storing results with the SQL reporter https://review.openstack.org/487950 | 17:27 |
| *** mat128 has quit IRC | 17:29 | |
| *** Apoorva has quit IRC | 17:29 | |
| *** camunoz has quit IRC | 17:29 | |
| *** jamesden_ has quit IRC | 17:29 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/openstack-zuul-jobs master: WIP: Setup tox_chdir for tox-py35-on-zuul job https://review.openstack.org/487948 | 17:31 |
| *** jamesdenton has joined #openstack-infra | 17:31 | |
| *** lucasagomes is now known as lucas-afk | 17:31 | |
| *** jcoufal has joined #openstack-infra | 17:31 | |
| *** jascott1 has joined #openstack-infra | 17:32 | |
| *** mat128 has joined #openstack-infra | 17:34 | |
| *** jcoufal_ has quit IRC | 17:34 | |
| *** skelso has quit IRC | 17:34 | |
| *** rbrndt has quit IRC | 17:36 | |
| *** skelso has joined #openstack-infra | 17:37 | |
| *** SumitNaiksatam has joined #openstack-infra | 17:38 | |
| *** Apoorva_ has quit IRC | 17:39 | |
| *** yamahata has joined #openstack-infra | 17:40 | |
| AJaeger | mordred, jeblair, pabelanger, could you put the job naming change on your review queue, please? https://review.openstack.org/487848 | 17:40 |
| jeblair | AJaeger: wow, infra-manual has changed a lot. there are a lot more than 3 guides. | 17:41 |
| *** ijw has joined #openstack-infra | 17:41 | |
| *** Apoorva has joined #openstack-infra | 17:41 | |
| *** camunoz has joined #openstack-infra | 17:42 | |
| fungi | we might could stand to reorganize/split the infra-manual yes | 17:42 |
| *** sshnaidm is now known as sshnaidm|off | 17:42 | |
| *** notmyname has quit IRC | 17:43 | |
| *** electrofelix has quit IRC | 17:43 | |
| fungi | it grew some "howto" type procedural docs in addition to the role-specific references | 17:43 |
| jeblair | i'd suggest combine. at least, the thing i was going for was that there would be 3 guides, targeted to audience: developer, reviewer, driver. | 17:43 |
| jeblair | i mean, if folks have another idea of how to organize it, i won't stand in the way. i only ask that we *have* an idea, and stick with it as much as possible. :) | 17:44 |
| fungi | so to take an early example, which audience is project creation most suited to? developer i guess? | 17:44 |
| jeblair | so i'd suggest moving the creators guide into drivers, sandbox into developers, and test environment into drivers | 17:44 |
| jeblair | fungi: driver | 17:44 |
| *** notmyname has joined #openstack-infra | 17:44 | |
| dhellmann | is there some way to see the logs of a doc gate/check job instead of the built docs? | 17:44 |
| fungi | oh, right driver | 17:44 |
| jeblair | dhellmann: go up one dir | 17:44 |
| dhellmann | thanks | 17:44 |
| AJaeger | dhellmann: replace docs-draft with logs in the URL as well | 17:45 |
| fungi | dhellmann: s/docs-draft/logs/ in the url | 17:45 |
| jeblair | fungi: 'driver' was the word intended to convey "someone who helps run the project". of course, we stopped using that word for some reason | 17:45 |
| jeblair | dhellmann: oh, yeah, sorry don't listen to me | 17:45 |
| dhellmann | bah, sphinx doesn't show the names of static files it is copying | 17:45 |
| AJaeger | dhellmann: but the ansible log does | 17:46 |
| dhellmann | does it? | 17:46 |
| jeblair | i might have been thinking of a, erm, "different" system. :) | 17:46 |
| fungi | we didn't so much intentionally stop using the term "driver" as it ended up being synonymous with release managers from a gerrit perspective | 17:46 |
| openstackgerrit | Merged openstack-infra/project-config master: Capitalize gerrit labels in zuulv3 config https://review.openstack.org/487955 | 17:46 |
| AJaeger | dhellmann: which change you're looking at? | 17:46 |
| dhellmann | http://logs.openstack.org/32/487932/2/check/gate-nova-docs-ubuntu-xenial/5b3e784/_zuul_ansible/ansible_log.txt | 17:46 |
| dhellmann | I'm trying to figure out if I've put that .htaccess file in the right place | 17:46 |
| AJaeger | dhellmann: ah, only for the post job... | 17:47 |
| fungi | we had some fooproject-driver and fooproject-release groups in gerrit, and ended up converting the former to the latter for consistency | 17:47 |
| AJaeger | dhellmann: check "2017-07-27 17:33:11,826" | 17:47 |
| AJaeger | dhellmann: and I don't see .htaccess ;( | 17:47 |
| dhellmann | ok | 17:48 |
| dhellmann | there are dot files, so that's not the problem | 17:48 |
| dhellmann | I must not have set up the file in the build properly, I'll see what happens locally | 17:48 |
| dhellmann | thanks, AJaeger | 17:48 |
| AJaeger | dhellmann: is static configured in the conf.py? | 17:48 |
| dhellmann | AJaeger : yes | 17:49 |
| jeblair | fungi: yeah. if there's a better word, i'm all for it. it's a good word if you think about it, but it doesn't immediately call to mind what we're trying to convey. | 17:49 |
| *** spzala has quit IRC | 17:50 | |
| fungi | i doubt we made that consolidation with any thoughts of connotation, but rather merely statistics | 17:50 |
| fungi | at least i don't remember much beyond "there are more -release groups in gerrit now" | 17:51 |
| fungi | easy enough to rename groups in gerrit these days. sed -i the acls and script a mass group rename via the api if that's something we want | 17:52 |
| *** mat128 has quit IRC | 17:53 | |
| *** trown is now known as trown|lunch | 17:53 | |
| jeblair | fungi: oh i meant for the docs :) like, if there's a better name for "Project Driver's Guide" i'm all for it | 17:55 |
| *** ldnunes has quit IRC | 17:56 | |
| *** SumitNaiksatam has quit IRC | 17:56 | |
| *** SumitNaiksatam has joined #openstack-infra | 17:56 | |
| *** ldnunes has joined #openstack-infra | 17:57 | |
| AJaeger | the project driver's guide as one large page - or should we split it into sub pages? | 17:57 |
| openstackgerrit | Lin Yang proposed openstack-infra/project-config master: Mark all jobs for python-valenceclient to voting https://review.openstack.org/487602 | 17:57 |
| fungi | jeblair: right, and i was talking about if we already have a better term in the docs and want some consistency with our internal implementation details | 17:57 |
| fungi | flip side of the same coin | 17:57 |
| jeblair | gotcha | 17:57 |
| openstackgerrit | Monty Taylor proposed openstack-infra/system-config master: Split out and expand zuulv3 docs https://review.openstack.org/487962 | 17:59 |
| mordred | jeblair: ^^ there's another followup for sysadmin docs | 18:00 |
| jeblair | mordred: nice | 18:04 |
| openstackgerrit | Andreas Jaeger proposed openstack-infra/infra-manual master: Describe Zuul v3 job naming https://review.openstack.org/487848 | 18:04 |
| AJaeger | jeblair: addressed most of your comments but did not merge it yet - so that diff works ^ | 18:05 |
| dhellmann | ok, I have the .htaccess file copying into place now | 18:05 |
| clarkb | mordred: I've approved that change but left a comment on an item we may awnt to update as we are updating all the things (it comes from the older docs so wasn't going to ding this change for it) | 18:06 |
| dhellmann | fungi, jeblair : I'm trying to address sdague and mriedem's concerns about old urls not working by designing a way for projects to put redirects in their doc trees | 18:06 |
| dhellmann | I have the .htaccess files in place, but it doesn't seem to be redirecting the way I expected | 18:06 |
| dhellmann | https://review.openstack.org/#/c/487932/3/doc/source/_extra/.htaccess is the file | 18:06 |
| openstackgerrit | Andreas Jaeger proposed openstack-infra/infra-manual master: Describe Zuul v3 job naming https://review.openstack.org/487848 | 18:07 |
| AJaeger | jeblair: now merged into the drivers guide ^ | 18:07 |
| dhellmann | the logs show it copying: http://logs.openstack.org/32/487932/3/check/gate-nova-docs-ubuntu-xenial/769977f/_zuul_ansible/ansible_log.txt | 18:07 |
| clarkb | do we have to enable thinsg on the server to allow them to work as expected? (re htaccess) | 18:07 |
| dhellmann | but when I try to hit http://docs-draft.openstack.org/32/487932/3/check/gate-nova-docs-ubuntu-xenial/769977f/doc/build/html/redirect-test.html I get a 404 instead of 301 | 18:07 |
| dhellmann | does the server on docs-draft support redirects? | 18:07 |
| dhellmann | and do we in general support having .htaccess files anywhere other than the root of the web server? | 18:07 |
| clarkb | dhellmann: I don't think we generally allow it anywhere | 18:08 |
| clarkb | looks like allowoverride is the necessary directive? | 18:08 |
| dhellmann | was that set (or not set) because we don't want to allow it for some reason, or because it hasn't come up or wasn't useful before? | 18:09 |
| dhellmann | maybe this approach is a bad idea? | 18:09 |
| clarkb | I think its generally off by default for performance reasons | 18:10 |
| clarkb | (there is some overhead to processing htaccess rules | 18:10 |
| dhellmann | that makes sense | 18:10 |
| * AJaeger calls it a day and waves good bye | 18:10 | |
| dhellmann | AJaeger : o/ | 18:11 |
| sdague | clarkb: the thing you'll find documented is also the performance hit on the fstat of the .htaccess file | 18:11 |
| sdague | because they are dynamically checked and loaded | 18:11 |
| sdague | but, that being said, the overhead is probably not a huge deal | 18:12 |
| clarkb | dhellmann: https://git.openstack.org/cgit/openstack-infra/system-config/tree/modules/openstack_project/templates/static-http-and-https.vhost.erb that is the vhost def | 18:12 |
| clarkb | allowoverride is set to none so that explains it | 18:12 |
| dhellmann | clarkb : cool, thanks | 18:12 |
| dhellmann | so then the question becomes, is it ok to turn that on? | 18:12 |
| dhellmann | I should probably write this plan down in more detail so people can consider their answers | 18:12 |
| clarkb | I think it could potentially be abused to redirect you offhost if someone got a malicious change in | 18:13 |
| sdague | clarkb: it would be governed by normal code review | 18:14 |
| clarkb | sdague: thats true, though the draft site wouldn't be, but I think we care much less on the draft site | 18:14 |
| dhellmann | yeah | 18:14 |
| clarkb | but thats the only concern I can come up with | 18:14 |
| sdague | it would probably be a good todo to add some kind of rule checks on .htaccess files for basic sanity at some point as well, but we could move that in after this is in place. I'd rather unstick us now. | 18:16 |
| dhellmann | yep | 18:16 |
| *** mat128 has joined #openstack-infra | 18:16 | |
| *** [HeOS] has quit IRC | 18:21 | |
| openstackgerrit | Lin Yang proposed openstack-infra/project-config master: Add python and client libray for Rack Scale Design https://review.openstack.org/487601 | 18:24 |
| jeblair | clarkb, sdague, dhellmann: maybe use allowoverridelist and specify exactly the directives (eg "Redirect RedirectMatch") that we want to support ? | 18:25 |
| dhellmann | clarkb : I could use your feedback on http://lists.openstack.org/pipermail/openstack-dev/2017-July/120248.html (is it enough detail, does it make sense, etc.) | 18:25 |
| dhellmann | jeblair : sure | 18:25 |
| dhellmann | jeblair : ^^ ML thread :-) | 18:25 |
| dhellmann | if there's a way to prevent off-site redirects we could use that directive, too | 18:26 |
| dhellmann | I don't know if such a thing exists | 18:27 |
| openstackgerrit | Lin Yang proposed openstack-infra/project-config master: Mark all jobs for python-valenceclient to voting https://review.openstack.org/487602 | 18:28 |
| *** florianf has quit IRC | 18:28 | |
| clarkb | dhellmann: digging more docs.o.o and docs-draft use two different vhost templates | 18:28 |
| dhellmann | I don't think we care too much about the draft site | 18:28 |
| clarkb | dhellmann: the one I linked is for docs-draft https://git.openstack.org/cgit/openstack-infra/system-config/tree/modules/openstack_project/templates/docs.vhost.erb is docs.o.o | 18:28 |
| dhellmann | I mean, it would be nice to be able to test the redirects, I guess | 18:29 |
| dhellmann | so maybe we do | 18:29 |
| clarkb | ya I think we should enable in both places | 18:29 |
| *** annegentle has joined #openstack-infra | 18:29 | |
| dhellmann | yeah, that makes sense now that I think it through | 18:29 |
| * dhellmann shouldn't make kneejerk decisions | 18:29 | |
| dhellmann | ok, I've updated my personal notes about that, I can do them both in 1 patch | 18:30 |
| jeblair | dhellmann: re offsite redirs: i don't either. i think it's okay to set guidelines and generally trust folks to review well. my suggestion was mostly because htaccess is *immensely* powerful, and i don't want us to end up in a situation where we accidentally open up a vulnerability, or end up using features we don't know about. | 18:30 |
| dhellmann | jeblair : yeah, that totally makes sense. I was trying to combine your suggestion with clarkb's concern to see if we could address it | 18:31 |
| jeblair | *nod* | 18:31 |
| dhellmann | but I generally agree that a review policy is good, and if we can do something automated later that would be good, too | 18:31 |
| clarkb | I think you want allowoverride fileinfo \n allowoverridelist redirect redirectmatch | 18:34 |
| *** dizquierdo_ has quit IRC | 18:34 | |
| clarkb | in the docs.o.o vhost then in draft you want allowoverride none \n allowoverridelist redirect redirectmatch? | 18:34 |
| openstackgerrit | Lin Yang proposed openstack-infra/project-config master: Add python and client libray for Rack Scale Design https://review.openstack.org/487601 | 18:34 |
| clarkb | but ya not seeing a way to further restrict redirect directives | 18:35 |
| *** ijw_ has joined #openstack-infra | 18:36 | |
| *** rbrndt has joined #openstack-infra | 18:37 | |
| dhellmann | thanks clarkb, I'll make a note of those | 18:37 |
| dhellmann | so, next question, how hard is it for me to see a recent list of 404s? :-) | 18:37 |
| clarkb | shouldn't be too hard for an infra root to grep them out of the apache access log | 18:38 |
| clarkb | let me go do that now | 18:39 |
| dhellmann | clarkb : if you could do 301 and 404 at the same time that would be great | 18:39 |
| *** ijw has quit IRC | 18:40 | |
| *** ijw_ has quit IRC | 18:41 | |
| clarkb | dhellmann: operation, url, count a good set of fields? | 18:41 |
| fungi | dhellmann: catching up on scrollback (i'm only intermittently around today) but we may need to permit certain .htaccess directives for those subtrees in the apache vhost config? i haven't looked... what behavior are you seeing? | 18:41 |
| clarkb | dhellmann: you don't need agent string or ip addrs or timestamp right? | 18:41 |
| fungi | oh, clarkb already said something similar | 18:42 |
| dhellmann | clarkb : timestamp might be useful, but if you're limiting to a range (say the last few days or week? I don't know what's easy for you to access) that could be left out | 18:42 |
| fungi | we may want to avoid allowing overrides on docs-draft due to the pre-merge nature of what's published there, so as to discourage abuse | 18:42 |
| dhellmann | fungi : yep, clarkb proposed a specific change for me to make, which I will do after I've looked at what those directives mean so I know what I'm proposing :-) | 18:42 |
| dhellmann | yeah, I went back and forth on the docs-draft thing | 18:43 |
| fungi | and again, clarkb said this | 18:43 |
| dhellmann | it would be useful to be able to test the redirects, but it's not that big of a deal | 18:43 |
| *** hashar has joined #openstack-infra | 18:43 | |
| * fungi is overjoyed at his own apparent redundancy in discussions of this sorty | 18:43 | |
| dhellmann | heh | 18:43 |
| dhellmann | that's the sign of a good team, for sure | 18:44 |
| *** skelso has quit IRC | 18:44 | |
| fungi | the conversation appears to have gone much farther, and i agree with the assertions of others. i'm going back outside now ;) | 18:44 |
| dhellmann | fungi : enjoy! | 18:44 |
| fungi | thanks! | 18:44 |
| openstackgerrit | Merged openstack-infra/system-config master: Document Zuul v3 GitHub integration https://review.openstack.org/487941 | 18:44 |
| openstackgerrit | Monty Taylor proposed openstack-infra/puppet-zuul master: Add PyMySQL python library for SQL Reporter support https://review.openstack.org/487974 | 18:44 |
| openstackgerrit | Merged openstack-infra/system-config master: Fix a few docs table of contents references https://review.openstack.org/487942 | 18:46 |
| openstackgerrit | Merged openstack-infra/system-config master: Split out and expand zuulv3 docs https://review.openstack.org/487962 | 18:46 |
| *** skelso has joined #openstack-infra | 18:47 | |
| *** trown|lunch is now known as trown | 18:48 | |
| *** armax has quit IRC | 18:49 | |
| openstackgerrit | Lin Yang proposed openstack-infra/project-config master: Add python and client libray for Rack Scale Design https://review.openstack.org/487601 | 18:50 |
| *** rossella__ has quit IRC | 18:53 | |
| clarkb | dhellmann: there are 2913 404s from today's log do you want ot top 100 or something? | 18:53 |
| clarkb | I guess I can use gist to get a full list | 18:53 |
| clarkb | s/get/share/ | 18:53 |
| dhellmann | wowo | 18:53 |
| dhellmann | yeah, maybe a top 100 | 18:53 |
| *** rossella__ has joined #openstack-infra | 18:54 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/puppet-zuul master: Add PyMySQL python library for SQL Reporter support https://review.openstack.org/487974 | 18:55 |
| clarkb | dhellmann: http://paste.openstack.org/show/616773/ that is 404s | 18:55 |
| *** camunoz has quit IRC | 18:55 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/system-config master: Enable SQL support for zuul v3 scheduler https://review.openstack.org/487975 | 18:55 |
| *** camunoz has joined #openstack-infra | 18:56 | |
| dhellmann | ew, lots of json and css in there | 18:56 |
| dhellmann | in fact almost all of that is json and css | 18:56 |
| dhellmann | clarkb : can you filter on html files, please? | 18:57 |
| dhellmann | or urls ending in / I guess | 18:57 |
| *** ijw has joined #openstack-infra | 18:57 | |
| clarkb | dhellmann: http://paste.openstack.org/show/616774/ is 301s, ya let me update | 18:57 |
| dhellmann | ty, I appreciate the effort | 18:57 |
| clarkb | dhellmann: http://paste.openstack.org/show/616775/ and http://paste.openstack.org/show/616776/ first line shows if it is 404s or 301s | 19:00 |
| openstackgerrit | Merged openstack-infra/devstack-gate master: Sync and partprobe after mkpart on ephemeral disk https://review.openstack.org/486676 | 19:00 |
| dhellmann | clarkb : fantastic, thank you | 19:00 |
| *** ijw has quit IRC | 19:01 | |
| *** dmsimard|afk is now known as dmsimard | 19:04 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack-dev/hacking master: Updated from global requirements https://review.openstack.org/440029 | 19:07 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack-dev/pbr master: Updated from global requirements https://review.openstack.org/487981 | 19:07 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack-infra/shade master: Updated from global requirements https://review.openstack.org/485943 | 19:07 |
| *** SumitNaiksatam has quit IRC | 19:07 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/diskimage-builder master: Updated from global requirements https://review.openstack.org/487989 | 19:08 |
| *** Apoorva_ has joined #openstack-infra | 19:09 | |
| *** Apoorva has quit IRC | 19:12 | |
| *** xyang1 has joined #openstack-infra | 19:12 | |
| *** rossella__ has quit IRC | 19:16 | |
| *** flepied has quit IRC | 19:17 | |
| *** Apoorva_ has quit IRC | 19:19 | |
| *** rossella__ has joined #openstack-infra | 19:19 | |
| *** Apoorva has joined #openstack-infra | 19:19 | |
| *** eharney_ has joined #openstack-infra | 19:24 | |
| *** eharney has quit IRC | 19:25 | |
| *** eharney_ is now known as eharney | 19:25 | |
| *** jamesdenton has quit IRC | 19:26 | |
| *** jamesdenton has joined #openstack-infra | 19:26 | |
| *** eharney has quit IRC | 19:30 | |
| pabelanger | clarkb: fungi: do you know why pip install -U /opt/zuul would _not_ install github3.py using github.com URL in http://git.openstack.org/cgit/openstack-infra/zuul/tree/requirements.txt?h=feature/zuulv3#n5 ? | 19:30 |
| pabelanger | clarkb: fungi: it instead grabs it from pypi | 19:30 |
| clarkb | pabelanger: maybe -U is deciding a version on pypi is neewer and should be updated too? though that would be a pip bug I think | 19:32 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul feature/zuulv3: Use mypy to do static type checking https://review.openstack.org/488161 | 19:34 |
| pabelanger | clarkb: by using -r /opt/zuul/requirements.txt -U /opt/zuul it works as expected | 19:34 |
| pabelanger | mordred: Oh, I think we need github settings on ze01.o.o too | 19:34 |
| pabelanger | mordred: let me manually apply to see | 19:35 |
| clarkb | pabelanger: in that case it is possibly a pbr bug | 19:35 |
| mordred | pabelanger: do we? weird ... I thought all th eapi interactions were in the driver in the scheduler | 19:35 |
| clarkb | pabelanger: since pbr is what reads in the requirements file | 19:35 |
| mordred | pabelanger: unless it's trying to clone via ssh and there's a key missing? | 19:36 |
| *** skelso has quit IRC | 19:36 | |
| pabelanger | mordred: ya, think so: http://paste.openstack.org/show/616782/ | 19:38 |
| clarkb | code looks the same | 19:38 |
| pabelanger | mordred: maybe just needs ssh key, not apt credentials | 19:38 |
| pabelanger | clarkb: k | 19:38 |
| clarkb | code looks same was meant for #zuul | 19:38 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack-infra/shade master: Updated from global requirements https://review.openstack.org/485943 | 19:43 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul feature/zuulv3: Update docs on github connection settings https://review.openstack.org/488165 | 19:44 |
| openstackgerrit | Monty Taylor proposed openstack-infra/system-config master: Update docs with correct information about github apps https://review.openstack.org/488167 | 19:46 |
| * fungi sees ping about pip installing git urls, notices it seems to have been subsequently answered in #zuul, disappears again | 19:47 | |
| mordred | pabelanger: "Host key verification failed." | 19:48 |
| *** nicolasbock has quit IRC | 19:48 | |
| pabelanger | mordred: ya, working on fix: https://etherpad.openstack.org/p/zuulv3-github current issues | 19:49 |
| mordred | pabelanger: cool | 19:49 |
| *** [HeOS] has joined #openstack-infra | 19:49 | |
| mordred | pabelanger: are you working on puppet for the known_hosts? | 19:51 |
| *** e0ne has joined #openstack-infra | 19:51 | |
| pabelanger | mordred: not yet | 19:53 |
| pabelanger | mordred: was the SSH key for openstack-zuul added to github? | 19:53 |
| pabelanger | Permission denied (publickey). | 19:54 |
| pabelanger | checking github settings | 19:54 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-client-config master: Updated from global requirements https://review.openstack.org/488084 | 19:54 |
| openstackgerrit | Doug Hellmann proposed openstack-infra/system-config master: allow redirects in .htaccess files on the static web servers https://review.openstack.org/488172 | 19:57 |
| openstackgerrit | Doug Hellmann proposed openstack-infra/system-config master: allow redirects in .htaccess files on the static web servers https://review.openstack.org/488172 | 20:00 |
| mordred | pabelanger: much easier fix I think | 20:00 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack-infra/shade master: Updated from global requirements https://review.openstack.org/485943 | 20:01 |
| mordred | pabelanger: we should remove "git_ssh_key" from the config for that | 20:01 |
| mordred | if we do - it'll clone over https | 20:01 |
| openstackgerrit | Monty Taylor proposed openstack-infra/system-config master: Remove ssh key from github connection and add to executor https://review.openstack.org/488178 | 20:07 |
| mordred | pabelanger: ^^ | 20:08 |
| mordred | jeblair: ^^ was there a reason we were doing ssh vs. https there? and I'm correct about executors needing connection info right? | 20:09 |
| pabelanger | mordred: sure, I can test quickly | 20:11 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-client-config master: Updated from global requirements https://review.openstack.org/488084 | 20:12 |
| *** eharney has joined #openstack-infra | 20:13 | |
| pabelanger | mordred: yup! | 20:13 |
| pabelanger | 2017-07-27 20:13:05,135 DEBUG zuul.Repo: Cloning from https://github.com/gtest-org/ansible to /var/lib/zuul/executor-git/github.com/gtest-org/ansible | 20:13 |
| *** skelso has joined #openstack-infra | 20:13 | |
| clarkb | you'd only need ssh if pushing right? though https can be pushed too now with github but its clunky like gerrit | 20:15 |
| pabelanger | think so, and we wouldn't to that on zuulv3.o.o | 20:16 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul feature/zuulv3: Stop double-logging the build id https://review.openstack.org/488183 | 20:17 |
| openstackgerrit | Merged openstack-infra/zuul master: Fix passing labels to Gerrit when they are not defined in All-Projects https://review.openstack.org/424806 | 20:17 |
| *** e0ne has quit IRC | 20:17 | |
| mnaser | if i abandon a change, can it be taken over by someone else later? | 20:18 |
| mnaser | there's a proposed spec that's been sitting in my queue and its not something that i'm working on actively, whats the best way to 'gracefully' leave it open | 20:18 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack-infra/shade master: Updated from global requirements https://review.openstack.org/485943 | 20:19 |
| clarkb | mnaser: yes abandoned changes can be restored later by the change owner or any project core | 20:19 |
| *** jtomasek has quit IRC | 20:19 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/project-config master: Add github connection to check pipeline https://review.openstack.org/488186 | 20:20 |
| jeblair | mordred: looking | 20:21 |
| *** xyang1 has quit IRC | 20:21 | |
| clarkb | pabelanger: review on ^ | 20:21 |
| *** jkilpatr has quit IRC | 20:21 | |
| jeblair | mordred: 178 wfm +3 | 20:22 |
| pabelanger | clarkb: ya, my syntax is wrong also | 20:22 |
| pabelanger | clarkb: looking at docs now | 20:22 |
| mnaser | i wonder what caused a huge spike of test nodes in the past few minutes :x | 20:22 |
| *** Goneri has quit IRC | 20:22 | |
| jeblair | pabelanger: why didn't zuul report the error? | 20:23 |
| mnaser | looks like it jumped from ~750-1000 to ~1750 almost instantly | 20:23 |
| pabelanger | jeblair: I am not sure | 20:23 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul feature/zuulv3: Stop double-logging the build id https://review.openstack.org/488183 | 20:23 |
| clarkb | mnaser: looks like global requirements updates | 20:23 |
| mnaser | oh fun times | 20:23 |
| *** makowals has quit IRC | 20:24 | |
| mordred | jeblair: mind quick +As on https://review.openstack.org/#/c/488167 and https://review.openstack.org/#/c/487975 which are in the stack with 178? | 20:25 |
| mordred | oh - and https://review.openstack.org/#/c/487974/ | 20:25 |
| mordred | the rabbit hole goes deep today | 20:26 |
| *** makowals has joined #openstack-infra | 20:26 | |
| jeblair | pabelanger: oh, i think i understand. we don't include pipelines in any kind of dynamic reconfiguration, even the one that we do on trusted projects then throw away. i think we can change that. | 20:26 |
| openstackgerrit | Paul Belanger proposed openstack-infra/project-config master: Add github connection to check pipeline https://review.openstack.org/488186 | 20:26 |
| *** mat128 has quit IRC | 20:27 | |
| pabelanger | jeblair: Ya, it would be nice to have the feedback | 20:27 |
| pabelanger | jeblair: clarkb: ^ think that is the most basic trigger we could have | 20:27 |
| *** mat128 has joined #openstack-infra | 20:27 | |
| *** jrist has quit IRC | 20:28 | |
| *** mat128 has quit IRC | 20:29 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-client-config master: Updated from global requirements https://review.openstack.org/488084 | 20:30 |
| *** eharney has quit IRC | 20:30 | |
| *** jcoufal has quit IRC | 20:31 | |
| jeblair | pabelanger: +2 but with a suggested revision | 20:32 |
| *** ijw_ has joined #openstack-infra | 20:32 | |
| *** kgiusti has quit IRC | 20:33 | |
| pabelanger | jeblair: sure! | 20:33 |
| *** ijw_ has quit IRC | 20:33 | |
| *** ijw has joined #openstack-infra | 20:33 | |
| clarkb | dhellmann: commented on https://review.openstack.org/#/c/488172/2 | 20:33 |
| dhellmann | clarkb : so just leave the AllowOverride lines alone and add the new line? | 20:34 |
| *** ijw has quit IRC | 20:35 | |
| pabelanger | jeblair: I'm unsure if status-url is needed, should I leave that empty for now? | 20:35 |
| dhellmann | clarkb : do I need to modify the docs.vhost file too? | 20:35 |
| openstackgerrit | Paul Belanger proposed openstack-infra/project-config master: Add github connection to check pipeline https://review.openstack.org/488186 | 20:36 |
| clarkb | dhellmann: yes to allowoverride left alone and yes to modify docs vhost too | 20:36 |
| dhellmann | k | 20:36 |
| openstackgerrit | Doug Hellmann proposed openstack-infra/system-config master: allow redirects in .htaccess files on the static web servers https://review.openstack.org/488172 | 20:36 |
| dhellmann | clarkb : ^^ | 20:36 |
| *** jtomasek has joined #openstack-infra | 20:36 | |
| dhellmann | I had the impression from the apache docs that I needed AllowOverrides FileInfo in order for the AllowOverridesList directive to work, but maybe I misunderstood | 20:38 |
| clarkb | dhellmann: I dont think it is but maybr I misunderstood :) | 20:40 |
| *** ijw has joined #openstack-infra | 20:40 | |
| dhellmann | clarkb : I guess we'll see :-) | 20:40 |
| *** jkilpatr has joined #openstack-infra | 20:40 | |
| dhellmann | I'll place my bet on you understanding better | 20:40 |
| *** xyang1 has joined #openstack-infra | 20:41 | |
| jeblair | pabelanger: yes, leave success and failure just the way you wrote them | 20:41 |
| pabelanger | jeblair: great | 20:41 |
| clarkb | dhellmann: fungi probably knows | 20:42 |
| dhellmann | clarkb : maybe we can pull him away from those sausages for a few minutes | 20:43 |
| openstackgerrit | Monty Taylor proposed openstack-infra/project-config master: Start storing results with the SQL reporter https://review.openstack.org/487950 | 20:44 |
| mordred | pabelanger, jeblair: ok ^^ maybe third times the charm today (pipeline definitions are not normally high-merge-conflict bait) | 20:45 |
| jeblair | clarkb, dhellmann: my understanding was that we can use none with list (so i agree with clark and how the patch is currently written) | 20:47 |
| jeblair | clarkb, dhellmann: does anyone know why fileinfo is there? | 20:47 |
| dhellmann | cool, works for me | 20:47 |
| dhellmann | I do not | 20:47 |
| openstackgerrit | Merged openstack-infra/puppet-zuul master: Add PyMySQL python library for SQL Reporter support https://review.openstack.org/487974 | 20:47 |
| openstackgerrit | Merged openstack-infra/system-config master: Enable SQL support for zuul v3 scheduler https://review.openstack.org/487975 | 20:47 |
| openstackgerrit | Merged openstack-infra/system-config master: Update docs with correct information about github apps https://review.openstack.org/488167 | 20:47 |
| openstackgerrit | Merged openstack-infra/system-config master: Remove ssh key from github connection and add to executor https://review.openstack.org/488178 | 20:47 |
| jeblair | dhellmann: oh, that's for docs.o.o isn't it? | 20:48 |
| dhellmann | jeblair : it is. Maybe just because we have a .htaccess file in the root dir? | 20:49 |
| *** jtomasek has quit IRC | 20:49 | |
| jeblair | dhellmann: i'm guessing, yeah, it was added to "make .htaccess" work. fileinfo includes redirect and redirectmatch, so that's actually a noop change for docs.o.o. | 20:49 |
| dhellmann | oh, so the list directive doesn't limit the other directive? | 20:50 |
| dhellmann | it's additive? | 20:50 |
| *** rlandy has quit IRC | 20:50 | |
| jeblair | if that's the only htaccess file we have now, and those are the only directives in it, now might be a good time to further restrict it. | 20:50 |
| dhellmann | sure, let's do that | 20:50 |
| *** trown is now known as trown|outtypewww | 20:51 | |
| dhellmann | I was just checking our htaccess, and those are the only directives I see | 20:51 |
| jeblair | dhellmann: yes, my understanding is it's a union. | 20:51 |
| jeblair | though, to be fair, i don't see a specific config example to clarify that :) (the only examples i see are from different sets) | 20:52 |
| openstackgerrit | Doug Hellmann proposed openstack-infra/system-config master: allow redirects in .htaccess files on the static web servers https://review.openstack.org/488172 | 20:52 |
| dhellmann | how's that one? ^^ | 20:52 |
| *** priteau has quit IRC | 20:53 | |
| dhellmann | jeblair , clarkb : I have to drop offline soon. I'll check for more comments on that patch (or here) first thing in the morning. Thanks for your help! | 20:54 |
| *** yland has joined #openstack-infra | 20:54 | |
| *** jrist has joined #openstack-infra | 20:55 | |
| pabelanger | clarkb: jeblair: mind a +3 on https://review.openstack.org/488186 ? | 21:07 |
| *** rhallisey has quit IRC | 21:10 | |
| mordred | and https://review.openstack.org/#/c/487950 | 21:10 |
| fungi | clarkb: dhellmann: sorry to disappoint, but the best i can offer is to pull up the apache config docs and perform a dramatic reading | 21:12 |
| *** hashar has quit IRC | 21:12 | |
| *** yamamoto_ has joined #openstack-infra | 21:13 | |
| *** yland has quit IRC | 21:14 | |
| fungi | what apache know-how i have is mostly hard-won from trial and error followed by attempting to interpret the documentation based on observed behaviors | 21:15 |
| *** yland has joined #openstack-infra | 21:15 | |
| *** ldnunes has quit IRC | 21:15 | |
| *** yland is now known as Guest85514 | 21:15 | |
| *** Goneri has joined #openstack-infra | 21:18 | |
| *** baoli has quit IRC | 21:18 | |
| *** yamamoto_ has quit IRC | 21:20 | |
| *** thorst has quit IRC | 21:25 | |
| *** thorst has joined #openstack-infra | 21:26 | |
| *** thorst_ has joined #openstack-infra | 21:27 | |
| clarkb | jeblair: I do not know why fileinfo is there | 21:28 |
| *** andreww has quit IRC | 21:28 | |
| openstackgerrit | Merged openstack-infra/project-config master: Add github connection to check pipeline https://review.openstack.org/488186 | 21:29 |
| clarkb | I am getting dinner going so it is rwady tonight then can look at apache stuff more | 21:29 |
| openstackgerrit | Merged openstack-infra/project-config master: Start storing results with the SQL reporter https://review.openstack.org/487950 | 21:30 |
| *** thorst has quit IRC | 21:30 | |
| *** Douhet has quit IRC | 21:30 | |
| *** rbrndt has quit IRC | 21:31 | |
| *** esberglu has quit IRC | 21:31 | |
| jeblair | clarkb, fungi, dhellmann: i left a comment on that change. i think it's good with that caveat. i did perform a find through all of afs/o.o/docs for htaccess files, and the root and infra/pub are the only ones. | 21:32 |
| *** thorst_ has quit IRC | 21:32 | |
| *** Guest85514 is now known as yland | 21:33 | |
| pabelanger | jeblair: mordred: looks like an issue with mysql config change for zuulv3: http://paste.openstack.org/show/616791/ | 21:34 |
| *** Goneri has quit IRC | 21:34 | |
| *** gongysh has joined #openstack-infra | 21:36 | |
| *** gongysh has quit IRC | 21:36 | |
| mordred | jeblair: is the zuul running with the zuul.conf changes making sure the mysql connection is present? | 21:37 |
| *** e0ne has joined #openstack-infra | 21:37 | |
| jeblair | pabelanger: and scheduler was reconfigured or restarted after the mysql connection was added to config? | 21:37 |
| mordred | pabelanger: gha - you | 21:37 |
| openstackgerrit | Matthew Treinish proposed openstack-infra/project-config master: Add support for post-processing stestr runs to run_tox.sh https://review.openstack.org/488212 | 21:37 |
| mordred | yah. that | 21:37 |
| mtreinish | clarkb, fungi: ^^^ there's no rush on that, it's just a future proofing step | 21:38 |
| mordred | jeblair: the scheduler does the config validation right, not the executor? | 21:38 |
| *** rbrndt has joined #openstack-infra | 21:38 | |
| jeblair | mordred: correct | 21:39 |
| mordred | jeblair: cool. I just had a thought of "do we need to list mysql connection in theexecutor config so that it knows ... but then realized not" | 21:39 |
| *** Douhet has joined #openstack-infra | 21:40 | |
| *** jamesdenton has quit IRC | 21:40 | |
| jeblair | mtreinish, pabelanger, mordred: we were actually just talking about needing to soft-freeze the jenkins scripts in prep for the zuulv3 transition. so we should decide whether we want that in now, or later. we actually have already done most of the tox stuff, so if we want that in now, we'll need to go update it. but it's not hard. | 21:40 |
| *** jamesdenton has joined #openstack-infra | 21:42 | |
| mtreinish | jeblair: well I've just been doing a bunch of stestr work the past week to try and get it in a better place to switch things over to it | 21:42 |
| mordred | maybe mtreinish would find porting that patch to v3 fun? | 21:42 |
| mtreinish | I was hoping to have something running with it in the gate by the ptg | 21:42 |
| mtreinish | mordred: it's just ansible right | 21:42 |
| mordred | mtreinish: yup | 21:42 |
| mtreinish | personally I prefer bash, but it shouldn't be too hard to do in ansible | 21:42 |
| mordred | mtreinish: pabelanger is just finishing up the main tox role - we can ping you when he's done | 21:42 |
| *** Apoorva has quit IRC | 21:43 | |
| *** Apoorva has joined #openstack-infra | 21:44 | |
| mtreinish | mordred: heh, the patch is just if -d .testrepository use 'testr last', if -d .stestr use 'stestr last' | 21:44 |
| jeblair | mtreinish: cool, i think it's fine to get in now. note that as we get closer to the ptg, the freeze on that area will need to get harder (so if you do need to make changes, you may need to update both simultaneously) | 21:44 |
| jeblair | mtreinish: but that's so simple, i'm guessing that won't be much of a burden :) | 21:44 |
| *** esberglu has joined #openstack-infra | 21:45 | |
| mordred | yah - we mostly want to make sure we don't, you know, undo work you've done when we do the cutover | 21:45 |
| mordred | since I'm pretty sure that would be unpleasant | 21:45 |
| *** aeng has joined #openstack-infra | 21:45 | |
| *** thorst has joined #openstack-infra | 21:45 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul feature/zuulv3: Collect logging information into ara callback https://review.openstack.org/487853 | 21:48 |
| *** gordc has quit IRC | 21:48 | |
| pabelanger | jeblair: mordred: yes, scheduled was reconfigured | 21:49 |
| *** esberglu has quit IRC | 21:49 | |
| *** thorst has quit IRC | 21:50 | |
| pabelanger | mtreinish: ya, won't be hard to add that into zuul-jobs. can help tomorrow | 21:50 |
| clarkb | dhellmann: jeblair oh I meant to keep the existing fileinfo allow as is for backward compat | 21:50 |
| clarkb | but maybe forcetype to the list is a better solution to that problem | 21:50 |
| mordred | pabelanger: reconfigured but not restarted? | 21:50 |
| pabelanger | mordred: right | 21:50 |
| *** esberglu has joined #openstack-infra | 21:51 | |
| mordred | pabelanger: k. so we might need a full restart for this one | 21:51 |
| mordred | jeblair: ^^ | 21:52 |
| pabelanger | ack | 21:52 |
| jeblair | clarkb: yeah, dhellmann and i had a conversation about that. his research indicated that /.htaccess didn't need anything other than those two. i then found out after he left that *we* have htaccess files that use forcetype, but i'm still okay with the change to see if we need it. (ours is just copypasta) | 21:52 |
| *** jascott1 has quit IRC | 21:53 | |
| *** jascott1 has joined #openstack-infra | 21:53 | |
| clarkb | jeblair: ah so we likely don't even need it for publications? | 21:53 |
| jeblair | mordred, pabelanger: well, if either of you want to look into that, that would be great (my list is growing faster than shrinking at the moment). but i guess if you just want to restart it, you can do that and tell me you're "collecting more data". :) | 21:53 |
| *** armax has joined #openstack-infra | 21:53 | |
| jeblair | clarkb: right. eg: ./infra/publications/puppet-overview/help/.htaccess | 21:53 |
| pabelanger | jeblair: sure, let me restart and collect more data | 21:54 |
| clarkb | jeblair: I can go ahead and approve it as is and we can see I guess. everyone ready for that? I think dhellmann has popped out but I don't think he needs to be around for this since we don't quite have htaccess files yet | 21:54 |
| jeblair | clarkb: wfm | 21:54 |
| clarkb | done | 21:54 |
| *** jascott1 has quit IRC | 21:55 | |
| *** jascott1 has joined #openstack-infra | 21:55 | |
| pabelanger | jeblair: mordred: restarted zuulv3.o.o, looks better | 21:58 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul feature/zuulv3: Collect logging information into ara callback https://review.openstack.org/487853 | 22:00 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul feature/zuulv3: Remove callback_whitelist setting https://review.openstack.org/488214 | 22:00 |
| mordred | pabelanger: woot! | 22:00 |
| mordred | pabelanger: I can verify that there are tables in the db | 22:02 |
| pabelanger | mordred: nice | 22:02 |
| mordred | mysql> select * from alembic_version \G | 22:02 |
| mordred | *************************** 1. row *************************** | 22:02 |
| mordred | version_num: f86c9871ee67 | 22:02 |
| mordred | so now we just need a build to, you know, do a thing - I just pushed up two new patch revisions so we should have it soon enough | 22:03 |
| openstackgerrit | Paul Belanger proposed openstack-infra/project-config master: WIP: testing https://review.openstack.org/488215 | 22:03 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Ensure ref-updated jobs run with their ref https://review.openstack.org/488216 | 22:03 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Ensure ref-updated jobs run with their ref https://review.openstack.org/488216 | 22:04 |
| *** yamamoto has joined #openstack-infra | 22:04 | |
| pabelanger | mordred: woot | 22:05 |
| pabelanger | 2017-07-27 22:04:00,044 DEBUG zuul.ProjectParser: Applying template gtest-org/ansible to pipeline check | 22:05 |
| openstackgerrit | Merged openstack-infra/system-config master: allow redirects in .htaccess files on the static web servers https://review.openstack.org/488172 | 22:05 |
| pabelanger | mordred: must still have something not configured properly, not seeing events from github | 22:06 |
| pabelanger | wonder if we need to update logging.conf | 22:07 |
| *** lbragstad has quit IRC | 22:08 | |
| *** xarses has joined #openstack-infra | 22:08 | |
| *** e0ne has quit IRC | 22:09 | |
| openstackgerrit | Merged openstack-infra/shade master: Updated from global requirements https://review.openstack.org/485943 | 22:10 |
| *** gouthamr_ has joined #openstack-infra | 22:10 | |
| *** gouthamr has quit IRC | 22:10 | |
| *** thorst has joined #openstack-infra | 22:13 | |
| *** thorst has quit IRC | 22:14 | |
| openstackgerrit | Clint 'SpamapS' Byrum proposed openstack-infra/zuul feature/zuulv3: Monitor job root and kill over limit jobs https://review.openstack.org/485902 | 22:15 |
| pabelanger | mordred: how can I tell if openstack-zuul is listening on gtest-org/ansible? | 22:15 |
| clarkb | pabelanger: for github? I am not sure you can since its an async ping from github to zuul | 22:16 |
| *** armax has quit IRC | 22:17 | |
| pabelanger | clarkb: ya, trying to figure out if the event stream is setup | 22:17 |
| clarkb | well there is no event stream | 22:17 |
| clarkb | aiui what happens is when github wants to send you an event it does an http request against your server | 22:17 |
| pabelanger | oh | 22:18 |
| *** armax has joined #openstack-infra | 22:18 | |
| pabelanger | do we need to open firewall? | 22:18 |
| clarkb | that is a possibility | 22:18 |
| pabelanger | hmm | 22:18 |
| clarkb | pabelanger: did you configure github to do the callback? | 22:18 |
| pabelanger | reading docs now | 22:18 |
| clarkb | you also need to make sure github knows where to make the request | 22:18 |
| pabelanger | clarkb: no? I mean, we added the github app 'openstack-zuul' | 22:18 |
| jeblair | still need more i think | 22:19 |
| pabelanger | ya | 22:19 |
| pabelanger | I think we need to open ports | 22:19 |
| pabelanger | for github webhook | 22:19 |
| jeblair | pabelanger: zuulv3 already has port 80 open | 22:19 |
| pabelanger | k | 22:20 |
| jeblair | pabelanger: https://docs.openstack.org/infra/zuul/feature/zuulv3/admin/drivers/github.html#github | 22:20 |
| pabelanger | jeblair: yes, reading that now | 22:20 |
| pabelanger | http://zuulv3.openstack.org/connection/github/payload | 22:20 |
| pabelanger | adding that to webhook now | 22:21 |
| jeblair | i have no idea why this is required if you install an app :| | 22:21 |
| pabelanger | not sure too | 22:21 |
| jeblair | SpamapS: ^ is that still accurate? | 22:21 |
| clarkb | isn't a github app just a registration of a system user type thing? | 22:22 |
| clarkb | I guess its a little more than that but you'd still have to configure it to tell it where to talk to | 22:23 |
| pabelanger | 2017-07-27 22:23:08,278 DEBUG zuul.GithubWebhookListener: Github Webhook Received. | 22:23 |
| pabelanger | cool | 22:23 |
| mordred | pabelanger: wait- no | 22:23 |
| pabelanger | okay | 22:23 |
| pabelanger | disabling | 22:23 |
| mordred | we should absolutely not need to configure a webhook on an individual repo | 22:23 |
| pabelanger | mordred: this was under gtest-org/settings/hooks | 22:24 |
| mordred | right. | 22:24 |
| mordred | the app was already added to the org | 22:24 |
| pabelanger | does the app have our webhook settings? | 22:24 |
| mordred | webhook is how you configure things that are not apps | 22:24 |
| pabelanger | k | 22:25 |
| pabelanger | I am unsure how we get the events from github currently | 22:25 |
| mordred | pabelanger: https://github.com/organizations/openstack-infra/settings/apps/openstack-zuul | 22:25 |
| mordred | has https://zuulv3.openstack.org/connection/github/payload configured as webhook URL | 22:25 |
| pabelanger | Oh | 22:25 |
| pabelanger | ya | 22:25 |
| pabelanger | we don't have https | 22:26 |
| clarkb | do you have to apply the app to the repo? | 22:26 |
| clarkb | ah https vs http | 22:26 |
| *** rcernin has quit IRC | 22:26 | |
| mordred | ah - gotit | 22:26 |
| mordred | I fixed | 22:26 |
| pabelanger | ack | 22:26 |
| mordred | yay! | 22:26 |
| mordred | so - in any case - that page: https://github.com/organizations/openstack-infra/settings/apps/openstack-zuul is where the app is configured | 22:26 |
| mordred | (I also added to docs today - but it's all new and whatnot, so making sure we all know where the things are is important) | 22:27 |
| pabelanger | mordred: is there a test web hook button? | 22:27 |
| clarkb | re http, there is a webhook secret | 22:28 |
| pabelanger | wonder if User authorization callback URL should also be http | 22:28 |
| *** skelso has quit IRC | 22:28 | |
| clarkb | are we worried about that being disclosed? it could be used by something other than github to spoof github | 22:28 |
| *** bobh has quit IRC | 22:28 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul feature/zuulv3: Update SQL reporter to store results https://review.openstack.org/488221 | 22:28 |
| pabelanger | I don't think we have a secret today, do we? | 22:28 |
| clarkb | pabelanger: that config page has something *'d out, but that could jus be a default | 22:28 |
| *** iyamahat has joined #openstack-infra | 22:29 | |
| clarkb | we may also not validate it in zuul yet | 22:29 |
| mordred | we do have a secret | 22:29 |
| mordred | and I'm not sure about it being exposed - we may want to consider adding https just to make sure | 22:29 |
| *** rbrndt has quit IRC | 22:29 | |
| clarkb | mordred: reading the docs what it would allow someone else to do is pretend to be github and submit jobs. But that only matters if we are validating the secret in zuul too | 22:30 |
| clarkb | (not sure if we validate) | 22:30 |
| pabelanger | Oh | 22:30 |
| pabelanger | Under advance | 22:30 |
| pabelanger | I see some logs | 22:30 |
| pabelanger | https://github.com/organizations/openstack-infra/settings/apps/openstack-zuul/advanced | 22:30 |
| pabelanger | OH SNAP | 22:31 |
| pabelanger | http://zuulv3.openstack.org/ | 22:31 |
| mordred | pabelanger: woot | 22:32 |
| pabelanger | I clicked redeliver button | 22:32 |
| pabelanger | and re-sent the event | 22:32 |
| jeblair | clarkb: https://review.openstack.org/473674 suggests we're doing something with webook token secrets | 22:32 |
| *** ihrachys has quit IRC | 22:33 | |
| jeblair | pabelanger: i don't see anything about zuul having started | 22:33 |
| *** ihrachys has joined #openstack-infra | 22:33 | |
| clarkb | jeblair: it sure does and that looks liek what I would expect based on reading github docs | 22:33 |
| pabelanger | jeblair: same, not sure why that is. Looking at logs currently | 22:34 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul feature/zuulv3: Update SQL reporter to store results https://review.openstack.org/488221 | 22:34 |
| jeblair | yeah, i think we should start httpsing | 22:34 |
| *** makowals has quit IRC | 22:34 | |
| mordred | jeblair: ++ | 22:34 |
| pabelanger | agree | 22:34 |
| *** rbrndt has joined #openstack-infra | 22:34 | |
| mordred | BUT - I'm going to EOD for today ... exciting stuff today errbody | 22:35 |
| jeblair | yep | 22:35 |
| jeblair | and i think we can proceed with this for now and just change our secret when we https) | 22:35 |
| *** rbrndt has quit IRC | 22:35 | |
| pabelanger | Ya, very exciting | 22:35 |
| pabelanger | jeblair: seems like a good idea | 22:35 |
| *** gouthamr_ has quit IRC | 22:37 | |
| jeblair | clarkb, pabelanger: oh this doc update from mordred clarifies things: https://review.openstack.org/488165 | 22:37 |
| jeblair | (and makes me wonder whether the app approach may be okay over http -- i dunno) | 22:38 |
| *** iyamahat_ has joined #openstack-infra | 22:38 | |
| *** andreww has joined #openstack-infra | 22:38 | |
| *** rama_y_ has joined #openstack-infra | 22:38 | |
| *** openstack has joined #openstack-infra | 22:43 | |
| *** sflanigan has joined #openstack-infra | 22:43 | |
| *** sflanigan has joined #openstack-infra | 22:43 | |
| *** jlvillal has joined #openstack-infra | 22:44 | |
| *** med_ has quit IRC | 22:44 | |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Update docs on github connection settings https://review.openstack.org/488165 | 22:44 |
| *** med_ has joined #openstack-infra | 22:44 | |
| *** baoli has joined #openstack-infra | 22:44 | |
| *** stevebaker has quit IRC | 22:44 | |
| *** dangers_` has joined #openstack-infra | 22:44 | |
| *** med_ is now known as Guest13936 | 22:45 | |
| *** stevebaker has joined #openstack-infra | 22:45 | |
| *** ggillies_ has quit IRC | 22:45 | |
| *** ggillies_ has joined #openstack-infra | 22:45 | |
| *** sflanigan has quit IRC | 22:45 | |
| *** sflanigan has joined #openstack-infra | 22:45 | |
| *** sflanigan has joined #openstack-infra | 22:45 | |
| *** dangers_away has quit IRC | 22:45 | |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Stop double-logging the build id https://review.openstack.org/488183 | 22:45 |
| *** kiltzman has quit IRC | 22:45 | |
| *** oomichi has quit IRC | 22:45 | |
| *** numans has quit IRC | 22:45 | |
| *** samP has quit IRC | 22:45 | |
| *** flepied has joined #openstack-infra | 22:45 | |
| pabelanger | mordred: Is it possible that app_key should be a filename, that holds the key? | 22:45 |
| jeblair | pabelanger: hrm, it sure looks like it has the right access. i wonder if there's a bug with the app id/key stuff. | 22:46 |
| *** mriedem is now known as mriedem_afk | 22:46 | |
| jeblair | pabelanger: using the dev version of github3? | 22:46 |
| *** ihrachys has joined #openstack-infra | 22:46 | |
| *** kiltzman has joined #openstack-infra | 22:46 | |
| pabelanger | jeblair: I think this is the issue: http://git.openstack.org/cgit/openstack-infra/zuul/tree/zuul/driver/github/githubconnection.py?h=feature/zuulv3#n409 | 22:46 |
| pabelanger | jeblair: yes, installed from github | 22:47 |
| *** lbragstad has joined #openstack-infra | 22:47 | |
| pabelanger | https://github.com/BonnyCI/hoist/blob/59975a64ea077ec01a6fbb69847e29011b51443c/inventory/group_vars/all#L35 | 22:47 |
| jeblair | pabelanger: do we have a "Failed to open" line in our logs? | 22:47 |
| *** oomichi has joined #openstack-infra | 22:47 | |
| pabelanger | jeblair: surprisingly no | 22:48 |
| pabelanger | bonncyci is using a file it seems | 22:48 |
| *** pleia2 has joined #openstack-infra | 22:48 | |
| *** jascott1 has quit IRC | 22:48 | |
| mordred | the code in zuul has an app_key or app_key_file | 22:48 |
| mordred | but maybe the thing I put into the app_key is not the right data ... | 22:48 |
| *** numans has joined #openstack-infra | 22:48 | |
| *** jascott1 has joined #openstack-infra | 22:48 | |
| pabelanger | I can test quickly if using a file for app_key works | 22:49 |
| mordred | well - we can also just generate a new app_key real quick so we're sure we've got the right data ... | 22:49 |
| *** jrist has quit IRC | 22:49 | |
| pabelanger | sure, that works | 22:49 |
| jeblair | mordred: no there's no app_key_file option | 22:49 |
| jeblair | mordred: app_key *is* the file | 22:49 |
| *** baoli has quit IRC | 22:49 | |
| mordred | jeblair: oh - really? ok. I totally misread that then | 22:50 |
| jeblair | mordred: i think we should make the code be like what's in your brain | 22:50 |
| *** bradm has joined #openstack-infra | 22:50 | |
| mordred | well - lemme make a new secret real quick so that we're sure what we've got is the rightthing ... | 22:50 |
| mordred | it's possible what I put there is just wrong and the data makes no sense to not be in a file | 22:51 |
| *** jascott1 has quit IRC | 22:51 | |
| jeblair | pabelanger: and yes, we're missing a bunch of github logs | 22:51 |
| *** jascott1 has joined #openstack-infra | 22:51 | |
| *** xinliang has quit IRC | 22:51 | |
| clarkb | why wouldn't appkey go in the zuul.conf for the github connection? | 22:51 |
| pabelanger | jeblair: possible we don't have correct logging.conf settings now? | 22:52 |
| mordred | yes. I have DEFINITELY not put the right data in | 22:52 |
| jeblair | pabelanger: the right solution is to change the logging names in the github driver. | 22:52 |
| clarkb | is it some massive base64 string? | 22:52 |
| pabelanger | jeblair: ack | 22:52 |
| jeblair | pabelanger: you could fix it with logging.conf, but let's not. let's fix the code. it should match gerrit. | 22:52 |
| pabelanger | ++ | 22:52 |
| jeblair | gotta run | 22:52 |
| mordred | clarkb: yes! it's a pem-encoded rsa key | 22:52 |
| mordred | the thing I had in there before was the oauth secret | 22:53 |
| pabelanger | ah, that explains why it is a file | 22:53 |
| jeblair | ++ | 22:53 |
| *** gouthamr has joined #openstack-infra | 22:53 | |
| *** annegentle has quit IRC | 22:53 | |
| clarkb | mordred: ah | 22:53 |
| mordred | yup. I'm going to put it in hiera now | 22:53 |
| jeblair | so we may not need to change anything about the config syntax, just fix logging. | 22:54 |
| pabelanger | progress is being made! Exciting | 22:54 |
| mordred | ok. I put the content in zuul_github_app_key in heira | 22:55 |
| mordred | obviously we'll need to update puppet-zuul and site.pp and write the file somewhere | 22:55 |
| pabelanger | k, I can do that tomorrow morning | 22:55 |
| clarkb | EmilienM: just as a heads up I'm seeing much smaller tripleo job log dirs now (under 100MB). I am still seeing a ton of redundant and unnecesasry /etc data still being copied though. Can we get those cleaned up and then call it good? (then work on moving to whitelist of files over time?) | 22:55 |
| pabelanger | mordred: did you manually write it to disk on zuulv3.o.o in the mean time? | 22:56 |
| mordred | cool. I also removed the app_key setting from private hiera - we can add the filename to public hiera when we update site.pp | 22:56 |
| mordred | pabelanger: I did not | 22:56 |
| pabelanger | ack | 22:56 |
| *** jascott1 has quit IRC | 22:58 | |
| *** jascott1 has joined #openstack-infra | 22:59 | |
| *** Apoorva_ has joined #openstack-infra | 22:59 | |
| *** xyang1 has quit IRC | 23:00 | |
| *** yland has quit IRC | 23:00 | |
| *** jascott1_ has joined #openstack-infra | 23:01 | |
| *** jascott1 has quit IRC | 23:01 | |
| *** yland has joined #openstack-infra | 23:01 | |
| SpamapS | jeblair: reading it now | 23:01 |
| *** yland is now known as Guest22487 | 23:01 | |
| yamamoto | if zuul "jobs" section has multiple matching entries for a job and they have different "branch" specified, which one will be used? | 23:02 |
| *** Apoorva has quit IRC | 23:02 | |
| yamamoto | the last one? | 23:02 |
| *** jascott1_ has quit IRC | 23:02 | |
| clarkb | yamamoto: yes last match wins | 23:02 |
| yamamoto | thanks | 23:02 |
| *** Apoorva_ has quit IRC | 23:02 | |
| *** jascott1 has joined #openstack-infra | 23:02 | |
| *** hongbin has quit IRC | 23:03 | |
| *** Apoorva has joined #openstack-infra | 23:03 | |
| *** lrossetti has joined #openstack-infra | 23:04 | |
| *** xinliang has joined #openstack-infra | 23:04 | |
| *** xinliang has quit IRC | 23:04 | |
| *** xinliang has joined #openstack-infra | 23:04 | |
| *** Douhet has quit IRC | 23:04 | |
| SpamapS | jeblair: ah yeah, that is entirely accurate AFAIK. | 23:05 |
| SpamapS | also something to consider.. if you don't https, perhaps worse than people spoofing github is people spoofing zuul and thus convincing other projects that they can merge evil code. | 23:06 |
| *** jascott1 has quit IRC | 23:07 | |
| *** Douhet has joined #openstack-infra | 23:07 | |
| *** samP has joined #openstack-infra | 23:07 | |
| *** Guest22487 has quit IRC | 23:11 | |
| *** lbragstad has quit IRC | 23:12 | |
| clarkb | SpamapS: the connection back to github is via https though | 23:14 |
| clarkb | SpamapS: its only the webhook that fires over http aiui | 23:15 |
| *** thorst has joined #openstack-infra | 23:15 | |
| SpamapS | same problem. | 23:16 |
| clarkb | how? | 23:16 |
| SpamapS | If somebody MITM's zuul, github will be pushing events to them. | 23:16 |
| SpamapS | and then they can do whatever they want with those events | 23:16 |
| clarkb | yes but those events aren't useful in the way you described | 23:17 |
| SpamapS | even not even talk to our zuul at all | 23:17 |
| clarkb | you'd have to mitm github to convince zuul to merge things | 23:17 |
| clarkb | there are two channels of communication. First is github -> zuul for webhooks that trigger jobs. | 23:17 |
| clarkb | the second is zuul -> github to post results/merge stuff | 23:17 |
| *** Douhet has quit IRC | 23:17 | |
| clarkb | only the first is potentially compromised in this setup | 23:17 |
| SpamapS | Right, so what I can do with that is first create a PR with evil code.. | 23:18 |
| SpamapS | then wait for an event for GOOD code | 23:18 |
| SpamapS | manipulate that event to test and merge my EVIL code | 23:18 |
| *** Douhet has joined #openstack-infra | 23:18 | |
| SpamapS | Now, this is all plainly visible in git history | 23:18 |
| SpamapS | so it's not an earth shattering vulnerability | 23:19 |
| SpamapS | but it's still going to merge the evil PR | 23:19 |
| SpamapS | because my MITM said "hey they approved PR#37337 | 23:19 |
| *** ijw has quit IRC | 23:19 | |
| clarkb | when code is fetched I thought the pr path was used | 23:19 |
| fungi | is there any metadata we can double-check? like with gerrit we get an event which could _potentially_ trigger a job, then zuul queries gerrit for details like approvals before proceeding | 23:19 |
| clarkb | so you couldn't spoof that | 23:20 |
| SpamapS | clarkb: not sure I follow. | 23:20 |
| SpamapS | fungi: entirely possible we do that too | 23:20 |
| *** thorst has quit IRC | 23:21 | |
| *** sdague has quit IRC | 23:21 | |
| clarkb | SpamapS: I may be assuming too muh about the data integrity of the github api | 23:21 |
| clarkb | SpamapS: but you get PRs and sha1s right? if those don't line up I'd expect something to go derp? | 23:21 |
| clarkb | or are you saying you'd just write a completely bogus "foo is approved" event? | 23:21 |
| SpamapS | clarkb: If they both came from the event though.. MITM'd event can make them match. | 23:22 |
| clarkb | so you wouldn't even need to wait for anything | 23:22 |
| fungi | it's not like spoofing gerrit events, if it were even plausible to do so, would have much actual impact on zuul v2 right now i don't think | 23:22 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Ensure ref-updated jobs run with their ref https://review.openstack.org/488216 | 23:22 |
| clarkb | but ya thats why I pointed out earlier that it doesn't matter right now because zuul isn't merging anything | 23:22 |
| SpamapS | clarkb: I'm reading the github driver now to see if it works the way I think | 23:22 |
| SpamapS | Entirely out of curiosity. | 23:22 |
| SpamapS | I think it's a no-brainer to HTTP that webhook. | 23:22 |
| clarkb | *HTTPS and definitely | 23:23 |
| clarkb | I was assessing the impact of not doing so immediately | 23:23 |
| clarkb | which I think is fairly minimal from a problem perspective. People can push bad copde and we test it | 23:23 |
| clarkb | or people send bogus events and we test bad code | 23:23 |
| clarkb | (in both cases the risk of DOS and running bad code exists whether or not we http or https. The difference is whether or not it is ever recorded in github) | 23:24 |
| openstackgerrit | YAMAMOTO Takashi proposed openstack-infra/project-config master: networking-midonet: Remove v2-full-legacy experimental job https://review.openstack.org/488229 | 23:24 |
| *** jrist has joined #openstack-infra | 23:24 | |
| clarkb | I suppose we could also be used to spam comments on pull requests which would be unfortunate | 23:25 |
| fungi | lbyl should fix that, right? | 23:25 |
| SpamapS | HTTPS yes, derp | 23:26 |
| clarkb | fungi: lbyl? | 23:26 |
| fungi | look before you leap | 23:26 |
| SpamapS | clarkb: from what I see, the event dictates the PR# and details. Other things are fetched from the API, but ultimateyl, they're fetched from that PR. | 23:26 |
| fungi | query to determine the veracity of the event | 23:27 |
| clarkb | fungi: right we do that with gerrit to check mergeability status but not sure if github does | 23:27 |
| SpamapS | pull_request_review is the event that usually triggers an approval | 23:27 |
| clarkb | SpamapS: so I think ^ is what it comes down to? if github driver checks PR for proper approvals before merging then that isn't a problem | 23:27 |
| fungi | do the pr details indicate what repo they're proposed against? | 23:27 |
| clarkb | fungi: yes they are indexed per repo so they have to | 23:28 |
| clarkb | gerrit uses global change number but github uses PR specific number | 23:28 |
| clarkb | er project specific PR numbers | 23:28 |
| SpamapS | I don't see that event handler doing any checks | 23:28 |
| *** Guest22487 has joined #openstack-infra | 23:28 | |
| SpamapS | https://github.com/openstack-infra/zuul/blob/feature/zuulv3/zuul/driver/github/githubconnection.py#L210-L225 | 23:29 |
| SpamapS | body is the submitted event body | 23:29 |
| clarkb | SpamapS: right so we'd test it and say +2 that worked, but before submitting (at least in with gerrit) zuul checks if the change meets the criteria | 23:30 |
| clarkb | if github driver did the same thing I think you'd avoid that particular problem | 23:30 |
| SpamapS | oh wow | 23:30 |
| SpamapS | so you can just say "mike approved PR#EVIL" | 23:30 |
| SpamapS | is that secret used to sign the details? | 23:31 |
| SpamapS | that would be nice | 23:31 |
| clarkb | SpamapS: right but if zuul then hit github (via https) to check the PR details then just saying mike approved foo would not be sufficient | 23:31 |
| SpamapS | I think it is actually used to sign the details. | 23:31 |
| SpamapS | sha1 tho | 23:32 |
| clarkb | SpamapS: yes the secret is used to sign the details (it hashes them and you both derive the same hash to check validity) | 23:32 |
| clarkb | SpamapS: there is a method to get the pull request reviews from github at least | 23:33 |
| SpamapS | Definitely | 23:33 |
| clarkb | I don't yet see if it is being checked as the source of truth rather than the PR content | 23:33 |
| SpamapS | I'm sure we get a direct ID for the review that we can just query. | 23:33 |
| SpamapS | But... | 23:33 |
| SpamapS | Not sure this matters if the secret signs. | 23:33 |
| SpamapS | MITM can't sign w/o the secret. | 23:33 |
| clarkb | canMerge just returns True :( | 23:33 |
| SpamapS | clarkb: u can haz merge! | 23:34 |
| SpamapS | always | 23:34 |
| SpamapS | :-/ | 23:34 |
| clarkb | but canMerge is where you'd implement that sort of checking | 23:34 |
| clarkb | to be extra cautious | 23:34 |
| SpamapS | so if the MITM can't create their own fictitious event from a real GIthub one, I don't think we have to worry | 23:35 |
| SpamapS | except maybe replay attacks | 23:35 |
| *** jaypipes has quit IRC | 23:35 | |
| clarkb | oh that was the concern secret is optional and we weren't sure if we had a secret but mordred said we did | 23:35 |
| clarkb | so maybe the thing we should be sure to document is "USE A SECRET" | 23:35 |
| *** dingyichen has joined #openstack-infra | 23:35 | |
| SpamapS | Yeah I'm surprised it is optional :-/ | 23:35 |
| clarkb | and also implement canMerge based on change.reviews | 23:35 |
| SpamapS | def _validate_signature(self, request): | 23:35 |
| SpamapS | secret = self.connection.connection_config.get('webhook_token', None) | 23:35 |
| SpamapS | if secret is None: | 23:36 |
| SpamapS | return True | 23:36 |
| clarkb | ya | 23:36 |
| SpamapS | maybe a warning. :) | 23:36 |
| clarkb | or just make it required | 23:36 |
| SpamapS | I like the idea of 'sploding without one. There's zero reason not to have one. | 23:36 |
| clarkb | github may not require it but zuul should | 23:36 |
| clarkb | ++ | 23:36 |
| openstackgerrit | YAMAMOTO Takashi proposed openstack-infra/project-config master: networking-midonet: Fix branches for v2 jobs https://review.openstack.org/488231 | 23:36 |
| * SpamapS makes patch | 23:36 | |
| SpamapS | Github's take: https://developer.github.com/webhooks/securing/ | 23:38 |
| SpamapS | so non-chalant | 23:38 |
| clarkb | at least they recommend a constant time string equality comparison | 23:38 |
| openstackgerrit | YAMAMOTO Takashi proposed openstack-infra/project-config master: networking-midonet: Fix branches for v2 jobs https://review.openstack.org/488231 | 23:39 |
| clarkb | I don't know that zuul's implementation does that | 23:39 |
| *** Apoorva_ has joined #openstack-infra | 23:40 | |
| SpamapS | I think it was just left optional so tests didn't have to set one. | 23:41 |
| clarkb | streql is an apache2 licensed implementation that will do constant time str comparisons. Or we can easily write our own that does not short circuit or do fancy prefix magic on comparison | 23:41 |
| clarkb | basically iterate over each character and check regardless of any already known state | 23:42 |
| *** Apoorva has quit IRC | 23:43 | |
| SpamapS | hm | 23:44 |
| SpamapS | clarkb: seems like we should add a story for that one. :) | 23:45 |
| SpamapS | yeah so making it required breaks the tests.. need to start submitting with a signature | 23:45 |
| SpamapS | but not too hard to go ahead and do that since we already have an implementation | 23:46 |
| *** thorst has joined #openstack-infra | 23:46 | |
| clarkb | SpamapS: do you want me to work on a patch to do constant time comparison? | 23:47 |
| SpamapS | clarkb: almost done and you'll need to stack on me. | 23:49 |
| clarkb | ok | 23:49 |
| SpamapS | clarkb: (almost done making it required, not constant time) | 23:49 |
| *** baoli has joined #openstack-infra | 23:50 | |
| *** thorst has quit IRC | 23:55 | |
| *** thorst has joined #openstack-infra | 23:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!