Thursday, 2018-08-23

fungii don't suppose we have a way to pass -vvv to those ssh commands and capture stdout/stderr from them?00:01
fungiwe could also try splatting the public keys it's using out to the log and comparing them to what's generated/installed00:01
openstackgerritDuc Truong proposed openstack-infra/irc-meetings master: Change Senlin meeting time  https://review.openstack.org/59393900:02
mordredianw: neat00:03
*** gouthamr has joined #openstack-infra00:03
ianwfungi: should i put a zuul hold on and see?00:04
openstackgerritTony Breeds proposed openstack-infra/irc-meetings master: Update FC SIG Meeting  https://review.openstack.org/59537700:04
mordredianw: might be the mos expedient way00:04
*** longkb has joined #openstack-infra00:05
dtruongtonyb: i added the link to dev ML announcement about the senlin meeting time change to the commit message for https://review.openstack.org/59393900:06
dtruongis that enough to get the time change approved?00:06
tonybdtruong: Yup I was just about to approve it00:06
tonybdtruong: Thanks00:06
ianw openstack | git.openstack.org/openstack-infra/system-config | system-config-run-base |     .*     |   1   | ianw: sysconfig00:06
dtruongthank you!00:06
ianwlet's see then00:06
tonybdtruong: done.  Thank you for handling the hard parts :)00:07
mordredianw: \o/00:08
mordredianw: btw - I'm going to be in your *general* timezone for a while00:09
mordredianw: although I'll be on vacation for most of it00:09
*** felipemonteiro has joined #openstack-infra00:09
mordredby general, I mean I'll be in Vietnam - so while not the same, certainly closer than usual00:10
ianwheh, cool but still not quite part of the exclusive south of the equator club :)00:13
*** gyee has quit IRC00:13
openstackgerritMerged openstack-infra/irc-meetings master: Change Senlin meeting time  https://review.openstack.org/59393900:15
openstackgerritMerged openstack-infra/irc-meetings master: Update FC SIG Meeting  https://review.openstack.org/59537700:15
ianwok i think 199.204.45.118 must be bridge and 99.204.45.192 it's friend00:15
mordredianw: I'm almost never that cool :)00:16
ianwoh we're ipv600:18
*** mriedem has joined #openstack-infra00:19
*** dingyichen has joined #openstack-infra00:20
mordredheck yes. mnaser gives us the good ipv6's00:21
*** mnencia has quit IRC00:22
mordredianw: id we only copy in the known hosts for the v4 address?00:22
mnaser:)00:22
ianwmordred: well, looking at 199.204.45.192, /home/zuul/.ssh/authorized_keys only has zuul-worker in there00:23
ianwzuul@199.204.45.118 (bridge) i don't see how it can log in00:23
*** mnencia has joined #openstack-infra00:23
*** mmedvede_ has joined #openstack-infra00:24
*** mmedvede has quit IRC00:24
*** mmedvede_ is now known as mmedvede00:24
*** jamesdenton has joined #openstack-infra00:26
mordredianw: did we run the multinode base job on these?00:26
ianwmordred: i think so http://logs.openstack.org/52/595252/5/check/system-config-run-base/80ca23f/ara-report/00:28
mordredianw: oh - https://review.openstack.org/#/c/595252/5/playbooks/zuul/run-base-pre.yaml00:29
mordredso that's got the known_hosts and ssh key00:29
mordredianw: https://review.openstack.org/#/c/595252/5/.zuul.yaml - that playbook isn't called from the job00:29
mordredianw: I think we're missing a pre-run: playbooks/zuul/run-base-pre.yaml00:30
*** jamesmcarthur has joined #openstack-infra00:31
ianwahh, yes starting to agree.  i can try with that00:32
openstackgerritIan Wienand proposed openstack-infra/system-config master: WIP: Add system-config-run-base job  https://review.openstack.org/59525200:33
ianwok, added pre book, removed old nodes and fresh hold on for ^00:34
ianwSSH Error: data could not be sent to remote host \"158.69.93.177\" ... hrm somthing still not happy00:39
ianwit is running base.yaml on (in-test) bridge.o.o so i think that's one step better00:40
ianw158.69.93.172 is bridge now, 158.69.93.177 xenial00:42
*** jamesmcarthur has quit IRC00:44
ianwthe xenial node has no .ssh/known_hosts ... i think that's a clue00:44
ianwrun-base-pre.yaml hasn't run against the xenial node00:45
*** felipemonteiro has quit IRC00:46
ianw- hosts: bridge.openstack.org ... i think that wants to be "all"?00:48
openstackgerritIan Wienand proposed openstack-infra/system-config master: WIP: Add system-config-run-base job  https://review.openstack.org/59525200:49
*** agopi has joined #openstack-infra00:54
mordredianw: yeah. I think so00:56
ianwyay, it worked!  http://logs.openstack.org/52/595252/7/check/system-config-run-base/8a38616/ara-report/00:59
ianwgot into the testinfra stage, anyway00:59
mordredwoot!01:00
mordredthat's superexciting01:00
*** gcb_ has quit IRC01:00
ianwok have to read a bit on testinfra now to see what it's trying to do01:01
fungiianw: sorry, stepped away for a bit (pretty late here). i agree holding the nodes makes more sense than trying to get the job to do it just to get past this hurdle01:05
*** markvoelker has joined #openstack-infra01:06
fungiand looks like you did and figured it out01:06
*** harlowja has quit IRC01:06
fungiright on!01:06
ianwfungi: heh, np.  hurdle passed and it looks like the nodes are all chatty01:06
ianwlooks like we'll have another Prime Minister by the end of the day01:09
fungihow many is that for this week?01:09
fungithough in seriousness, i'm jealous01:09
*** masayukig has joined #openstack-infra01:27
*** noama has quit IRC01:36
*** markvoelker has quit IRC01:40
*** mriedem has quit IRC01:48
*** larainema has quit IRC01:54
*** hongbin has joined #openstack-infra01:57
openstackgerritIan Wienand proposed openstack-infra/system-config master: WIP: Add system-config-run-base job  https://review.openstack.org/59525202:00
*** jamesmcarthur has joined #openstack-infra02:01
*** ddurst- is now known as ddurst02:04
ianwtestinfra/test_base.py::test_exim_is_installed[ansible://bridge.openstack.org] PASSED [ 50%]02:15
ianwtestinfra/test_base.py::test_exim_is_installed[ansible://xenial] PASSED  [100%]02:15
ianwthat's pretty cool02:15
*** jamesmcarthur has quit IRC02:19
*** diablo_rojo has quit IRC02:20
*** bdodd_ has joined #openstack-infra02:23
*** dave-mccowan has quit IRC02:27
*** dansmith has joined #openstack-infra02:28
*** mandre has joined #openstack-infra02:28
*** shoogz has quit IRC02:29
*** hemna_ has quit IRC02:29
*** srwilkers has quit IRC02:29
*** mnasiadka has quit IRC02:29
*** viks_ has quit IRC02:29
*** bdodd has quit IRC02:29
*** yonglihe has quit IRC02:29
*** hughsaunders has quit IRC02:29
*** rpioso|afk has quit IRC02:29
*** mandre_off has quit IRC02:29
*** htimsnad has quit IRC02:29
*** katyafervent_awa has quit IRC02:29
*** darvon has quit IRC02:29
*** shoogz- has joined #openstack-infra02:30
*** hughsaunders has joined #openstack-infra02:30
corvusianw: doh!  thanks!  that's some teamwork :)02:34
*** felipemonteiro has joined #openstack-infra02:35
*** antonym has joined #openstack-infra02:37
*** hemna_ has joined #openstack-infra02:37
*** diablo_rojo has joined #openstack-infra02:37
*** markvoelker has joined #openstack-infra02:37
*** shoogz- is now known as shoogz02:38
*** psachin has joined #openstack-infra02:46
*** masayukig has quit IRC03:09
*** markvoelker has quit IRC03:11
*** masayukig has joined #openstack-infra03:11
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool master: Implement an Amazon EC2 driver  https://review.openstack.org/53555803:21
*** hongbin_ has joined #openstack-infra03:21
*** hongbin has quit IRC03:24
*** nicolasbock has quit IRC03:44
*** felipemonteiro has quit IRC03:45
*** udesale has joined #openstack-infra03:47
*** larainema has joined #openstack-infra04:00
*** markvoelker has joined #openstack-infra04:08
AJaegerconfig-core, https://review.openstack.org/#/c/592292/ is job removal after retirement and https://review.openstack.org/#/c/595004/3 is python3-first change that is ready - could you review both, please?04:09
*** ykarel has joined #openstack-infra04:14
AJaegerthanks, ianw !04:14
AJaegerconfig-core, and one more, please: https://review.openstack.org/595327 - to fix translation jobs04:15
*** felipemonteiro has joined #openstack-infra04:15
tonybianw: 589007 (04:20
tonybSupport puppet5 for bionic) merged and I did a recheck on https://review.openstack.org/#/c/588441/04:20
tonybwhich failed :(04:20
openstackgerritMerged openstack-infra/project-config master: remove job settings for PowerVMStackers repositories  https://review.openstack.org/59500404:22
tonybI *think* it's because in https://review.openstack.org/#/c/589007/3/install_puppet.sh@222 you don't assign a puppetpkg and then when we get to https://review.openstack.org/#/c/589007/3/install_puppet.sh@258 it isn't installed resulting in http://logs.openstack.org/41/588441/1/check/build-wheel-mirror-ubuntu-bionic/b3fd7ef/job-output.txt.gz#_2018-08-22_23_42_46_45388004:22
tonybianw: does that seem right'ish?04:22
openstackgerritIan Wienand proposed openstack-infra/system-config master: Don't create "admin" group  https://review.openstack.org/59545404:31
ianwtonyb: ummm04:32
*** viks_ has joined #openstack-infra04:35
ianwtonyb: yeah, ok i agree, what a mess04:36
ianwhttp://logs.openstack.org/41/588441/1/check/build-wheel-mirror-ubuntu-trusty/ddc9a4c/job-output.txt.gz#_2018-08-22_23_39_42_51560904:36
ianwso on trusty it pre-installs then, re-installs.04:36
tonybianw: Oh04:37
ianwwant to just propose an update?  i have one more round on the ansible based roles, just updating the variables per mordred's request, and i think they're done anyway04:37
tonybianw: I assume it's just puppet not puppet5 ?04:37
ianwi think so, i can't understand why i didn't find this when i ran it locally04:38
* tonyb wil spin up a bionic vm to check04:39
ianwi'm just dockering it now ...04:39
ianw(is that a verb?)04:39
tonyb;P04:40
tonybSure04:40
*** markvoelker has quit IRC04:41
tonybLOL it seems I built a bad VM I booted it and now it's doing '/usr/bin/python3 /usr/bin/unattended-upgrade' :(04:43
ianwahh, ok no the one from puppetlabs is called puppet-agent04:43
ianwoh i see what's going on04:44
tonybokay, I'll verify that and propose an update04:44
*** ramishra has joined #openstack-infra04:44
ianwok, great, yeah "puppetpkg=puppet-agent" WFM04:44
ianwbut if you can fully verify, because soon after that it stops in my container as no /bin/systemctl and so gets confused and tries the initrd path04:45
ianwinit.d i mean04:45
ianwsorry, maybe i didn't loop back and test it properly after we made the change to puppetlabs04:46
openstackgerritIan Wienand proposed openstack-infra/system-config master: Don't create "admin" group  https://review.openstack.org/59545404:48
tonybianw: Looks good ot me: http://paste.openstack.org/show/728653/04:52
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool master: Implement an OpenShift resource provider  https://review.openstack.org/57066704:52
ianwcool, yep that got hte puppetlabs versoin04:53
openstackgerritTony Breeds proposed openstack-infra/system-config master: Install the puppetlabs puppet package  https://review.openstack.org/59545605:00
tonybianw: ^^05:00
openstackgerritIan Wienand proposed openstack-infra/system-config master: Generate roles documentation  https://review.openstack.org/59347805:02
openstackgerritIan Wienand proposed openstack-infra/system-config master: playbooks/roles/exim: remove "true" filter plugin  https://review.openstack.org/59399805:02
openstackgerritIan Wienand proposed openstack-infra/system-config master: roles: Add README.rst and lint  https://review.openstack.org/59480005:02
openstackgerritIan Wienand proposed openstack-infra/system-config master: Move exim role to top-level  https://review.openstack.org/59075305:02
openstackgerritIan Wienand proposed openstack-infra/system-config master: Add kerberos-client role  https://review.openstack.org/59348605:02
openstackgerritIan Wienand proposed openstack-infra/system-config master: Add openafs-client role  https://review.openstack.org/59348705:02
openstackgerritIan Wienand proposed openstack-infra/openstack-zuul-jobs master: Test OpenAFS client install  https://review.openstack.org/58933505:03
openstackgerritJarek Lukow proposed openstack-infra/zuul master: Add missing parentheses to title invocation  https://review.openstack.org/59536105:09
*** ccamacho has quit IRC05:11
*** ccamacho has joined #openstack-infra05:12
*** holser_ has joined #openstack-infra05:13
*** felipemonteiro has quit IRC05:17
*** ykarel_ has joined #openstack-infra05:17
*** ccamacho has quit IRC05:19
*** hongbin_ has quit IRC05:19
*** ykarel has quit IRC05:21
*** dmellado has joined #openstack-infra05:27
*** noama has joined #openstack-infra05:32
*** markvoelker has joined #openstack-infra05:38
openstackgerritMerged openstack-infra/system-config master: Install the puppetlabs puppet package  https://review.openstack.org/59545605:39
*** holser_ has quit IRC05:40
*** janki has joined #openstack-infra05:40
*** dpawlik has joined #openstack-infra06:06
*** ccamacho has joined #openstack-infra06:07
*** dpawlik has quit IRC06:10
*** markvoelker has quit IRC06:12
*** dpawlik has joined #openstack-infra06:13
*** jchhatbar has joined #openstack-infra06:31
*** janki has quit IRC06:31
*** pcaruana has joined #openstack-infra06:33
*** hashar has joined #openstack-infra06:44
*** zhangfei has joined #openstack-infra06:46
*** ramishra has quit IRC06:49
*** AJaeger has quit IRC06:58
*** apetrich has joined #openstack-infra06:58
*** rcernin has quit IRC06:59
*** ykarel_ is now known as ykarel|away07:02
*** AJaeger has joined #openstack-infra07:04
*** ginopc has joined #openstack-infra07:05
*** ykarel|away has quit IRC07:07
*** ramishra has joined #openstack-infra07:07
*** jtomasek has joined #openstack-infra07:08
*** jtomasek has quit IRC07:08
*** markvoelker has joined #openstack-infra07:09
*** jtomasek has joined #openstack-infra07:09
*** florianf has joined #openstack-infra07:13
*** e0ne has joined #openstack-infra07:13
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: WIP web: rewrite interface in react  https://review.openstack.org/59160407:15
*** shardy_afk is now known as shardy07:18
tonybianw: That fixed the bionic job but the centos one still fails, I *think* in install_modules.sh). I'll lok at it tomorrow.07:21
*** jchhatba_ has joined #openstack-infra07:24
*** jchhatbar has quit IRC07:25
*** jpich has joined #openstack-infra07:29
*** tosky has joined #openstack-infra07:34
*** longkb has quit IRC07:36
*** jpena|off is now known as jpena07:36
*** ykarel|away has joined #openstack-infra07:36
*** ykarel|away is now known as ykarel07:36
*** longkb has joined #openstack-infra07:36
*** annp has quit IRC07:37
*** diablo_rojo has quit IRC07:38
*** alexchadin has joined #openstack-infra07:38
*** electrofelix has joined #openstack-infra07:40
*** markvoelker has quit IRC07:42
openstackgerritlei zhang proposed openstack-infra/system-config master: Disable the badge from openstackdocstheme 1.23  https://review.openstack.org/59551907:43
*** jchhatba_ has quit IRC07:46
*** jchhatba_ has joined #openstack-infra07:48
*** jchhatba_ has quit IRC07:50
*** jchhatba_ has joined #openstack-infra07:50
openstackgerritlei zhang proposed openstack-infra/grafyaml master: Disable the badge from openstackdocstheme 1.23  https://review.openstack.org/59552207:55
*** alexchadin has quit IRC07:55
openstackgerritlei zhang proposed openstack-infra/storyboard master: Disable the badge from openstackdocstheme 1.23  https://review.openstack.org/59552407:59
*** alexchadin has joined #openstack-infra08:01
*** owalsh has quit IRC08:03
*** dbecker_ has joined #openstack-infra08:07
*** dbecker has quit IRC08:07
*** jaosorior has quit IRC08:10
*** dtantsur|afk is now known as dtantsur08:33
*** markvoelker has joined #openstack-infra08:39
*** ykarel is now known as ykarel|lunch08:40
*** owalsh has joined #openstack-infra08:48
*** owalsh_ has joined #openstack-infra08:50
*** owalsh has quit IRC08:53
*** owalsh has joined #openstack-infra08:55
*** gcb_ has joined #openstack-infra08:55
*** owalsh_ has quit IRC08:56
openstackgerritNguyen Hai proposed openstack-infra/project-config master: remove job settings for mistral repositories  https://review.openstack.org/59326409:02
*** jaosorior has joined #openstack-infra09:08
*** ykarel|lunch is now known as ykarel09:10
*** dingyichen has quit IRC09:11
*** markvoelker has quit IRC09:13
*** gcb_ has quit IRC09:13
*** jchhatba_ has quit IRC09:14
*** jchhatba_ has joined #openstack-infra09:14
*** gcb_ has joined #openstack-infra09:19
*** sambetts_ has joined #openstack-infra09:23
AJaegerconfig-core, https://review.openstack.org/#/c/593264/ is ready for merge (python3-first)09:26
*** holser_ has joined #openstack-infra09:34
*** jchhatbar has joined #openstack-infra09:36
*** jchhatba_ has quit IRC09:39
*** ssbarnea has joined #openstack-infra09:49
*** jaosorior has quit IRC09:54
*** jchhatbar has quit IRC09:58
openstackgerritSlawek Kaplonski proposed openstack-infra/project-config master: Add openstack-python36 job to Neutron Grafana dashboard  https://review.openstack.org/59557310:04
*** spiffxp has quit IRC10:09
*** markvoelker has joined #openstack-infra10:10
*** vipul has quit IRC10:10
*** chason has quit IRC10:39
*** chason has joined #openstack-infra10:40
*** alexchadin has quit IRC10:41
*** alexchadin has joined #openstack-infra10:41
*** alexchadin has quit IRC10:42
*** markvoelker has quit IRC10:43
*** dave-mccowan has joined #openstack-infra10:45
*** jchhatbar has joined #openstack-infra10:46
*** jpena is now known as jpena|lunch11:03
*** dbecker_ has quit IRC11:10
*** dbecker has joined #openstack-infra11:13
*** alexchadin has joined #openstack-infra11:13
*** holser_ has quit IRC11:15
*** alexchadin has quit IRC11:18
*** nicolasbock has joined #openstack-infra11:22
openstackgerritMerged openstack/diskimage-builder master: Add netcat to redhat-common map-packages  https://review.openstack.org/58860111:26
*** udesale has quit IRC11:31
*** mriedem has joined #openstack-infra11:33
openstackgerritIan Wienand proposed openstack-infra/system-config master: roles: Add README.rst and lint  https://review.openstack.org/59480011:35
openstackgerritIan Wienand proposed openstack-infra/system-config master: Move exim role to top-level  https://review.openstack.org/59075311:35
openstackgerritIan Wienand proposed openstack-infra/system-config master: Add kerberos-client role  https://review.openstack.org/59348611:35
openstackgerritIan Wienand proposed openstack-infra/system-config master: Add openafs-client role  https://review.openstack.org/59348711:35
*** rh-jelabarre has joined #openstack-infra11:35
*** zhangfei has quit IRC11:38
*** markvoelker has joined #openstack-infra11:40
*** longkb has quit IRC11:42
openstackgerritMerged openstack-infra/system-config master: Generate roles documentation  https://review.openstack.org/59347811:44
openstackgerritMerged openstack-infra/system-config master: playbooks/roles/exim: remove "true" filter plugin  https://review.openstack.org/59399811:44
*** jaosorior has joined #openstack-infra11:54
*** moguimar has joined #openstack-infra12:01
*** alexchadin has joined #openstack-infra12:02
*** jcoufal has joined #openstack-infra12:03
*** alexchadin has quit IRC12:07
*** boden has joined #openstack-infra12:09
*** jpena|lunch is now known as jpena12:09
*** alexchadin has joined #openstack-infra12:09
*** markvoelker has quit IRC12:14
*** trown|outtypewww is now known as trown12:15
*** pcaruana has quit IRC12:16
*** pcaruana has joined #openstack-infra12:16
*** ansmith has quit IRC12:20
openstackgerritDavid Shrewsbury proposed openstack-infra/system-config master: Add timezone role  https://review.openstack.org/59454212:23
Shrewsianw: corvus: ^^ fix for ianw's comment about ignoring errors. turns out the problem was with the cron service name12:23
Shrewsianw: thx for making me think about that some more12:24
*** rosmaita has joined #openstack-infra12:27
*** holser_ has joined #openstack-infra12:28
*** rlandy has joined #openstack-infra12:31
*** rh-jelabarre has quit IRC12:32
openstackgerritDoug Hellmann proposed openstack-infra/project-config master: remove job settings for monasca repositories  https://review.openstack.org/59574412:32
*** dims_ is now known as dims12:37
*** kgiusti has joined #openstack-infra12:39
*** ssbarnea|ruck has quit IRC12:44
*** tpsilva has joined #openstack-infra12:45
*** ykarel has quit IRC12:51
*** ykarel has joined #openstack-infra12:51
*** udesale has joined #openstack-infra12:54
*** mdrabe has joined #openstack-infra12:59
*** dhill_ has quit IRC13:01
*** jaosorior has quit IRC13:09
*** lennyb has quit IRC13:10
openstackgerritSlawek Kaplonski proposed openstack-infra/project-config master: Neutron failure rate - include TIMED_OUT jobs on graphs  https://review.openstack.org/59576313:14
openstackgerritNguyen Hai proposed openstack-infra/project-config master: remove job settings for octavia repositories  https://review.openstack.org/59578313:23
*** rh-jelabarre has joined #openstack-infra13:34
*** felipemonteiro has joined #openstack-infra13:35
*** alexchadin has quit IRC13:39
*** psachin has quit IRC13:40
*** dhill_ has joined #openstack-infra13:44
*** felipemonteiro has quit IRC13:46
*** eharney has joined #openstack-infra13:48
*** viks_ has quit IRC13:49
*** jchhatbar has quit IRC13:55
*** ianychoi has quit IRC13:59
*** ianychoi has joined #openstack-infra14:00
*** dpawlik has quit IRC14:05
*** r-daneel has joined #openstack-infra14:07
*** dhill_ has quit IRC14:08
*** dhill_ has joined #openstack-infra14:21
*** pbourke has quit IRC14:24
*** pbourke has joined #openstack-infra14:26
*** ccamacho has quit IRC14:35
*** r-daneel has quit IRC14:37
*** Bhujay has joined #openstack-infra14:39
AJaegerconfig-core, could you review https://review.openstack.org/595327 to fix translations reporting and https://review.openstack.org/592292 to retire rst2bash completely, please?14:41
*** Swami has joined #openstack-infra14:50
*** hongbin has joined #openstack-infra14:53
hongbinhi infra team, a question, tempest jobs that we defined were triggered on master and stable/queens branch, but not triggered at stable/rocky branch, for example: https://review.openstack.org/#/c/595218/14:56
hongbinany hint to debug this issue?14:57
openstackgerritNicolas Hicher proposed openstack-infra/puppet-openstackci master: Add AFS mirror support  https://review.openstack.org/52937614:57
*** rpittau has quit IRC14:57
*** jamesmcarthur has joined #openstack-infra14:57
hongbinmaster: https://review.openstack.org/#/c/595203/14:58
hongbinstable/rocky: https://review.openstack.org/#/c/595218/14:58
hongbinstable/queens: https://review.openstack.org/#/c/595215/14:59
Shrewshrm, i've seen the infra-puppet-apply-4-centos-7 job for system-config fail twice now with: "rm: cannot remove ‘/tmp/tmp.bRgWBTZoQT/remote_tmp’: Permission denied"14:59
Shrewsseems random, so maybe a race14:59
hongbinThe jobs zun-tempest-* were triggered in master and stable/queens, but not triggered in stable/rocky15:00
*** hamzy has quit IRC15:10
*** dhill_ has quit IRC15:11
*** dhill_ has joined #openstack-infra15:13
*** eernst has joined #openstack-infra15:16
*** moguimar has quit IRC15:18
*** dklyle has quit IRC15:20
openstackgerritMatt Riedemann proposed openstack-infra/elastic-recheck master: Add query for cold migration revert ssh bug 1788403  https://review.openstack.org/59581815:22
openstackbug 1788403 in OpenStack Compute (nova) "test_server_connectivity_cold_migration_revert randomly fails ssh check" [Medium,Confirmed] https://launchpad.net/bugs/178840315:22
openstackgerritJames E. Blair proposed openstack-infra/zuul-jobs master: Add write-inventory role  https://review.openstack.org/59537815:27
openstackgerritJames E. Blair proposed openstack-infra/system-config master: Allow bridge playbook to run under zuul  https://review.openstack.org/59536315:29
openstackgerritJames E. Blair proposed openstack-infra/system-config master: WIP: Add system-config-run-base job  https://review.openstack.org/59525215:29
*** njohnston has joined #openstack-infra15:31
*** ykarel is now known as ykarel|away15:32
njohnstonHi!  I have a request to add something to elastic-recheck, how can I figure out who is core on it so I know who to add to the review?  https://review.openstack.org/59372215:32
corvushongbin: it doesn't look like the change to add the jobs to stable/rocky has merged yet15:34
*** hamzy has joined #openstack-infra15:35
*** Bhujay has quit IRC15:35
corvusAJaeger, dhellmann: did we discuss whether to move pipeline membership out of project-config?15:36
*** pcaruana has quit IRC15:36
hongbincorvus: you mean this change:  https://review.openstack.org/#/c/595396/ ?15:36
openstackgerritNicolas Hicher proposed openstack-infra/puppet-openstackci master: Add AFS mirror support  https://review.openstack.org/52937615:37
corvushongbin: i mean 59521815:37
*** dklyle has joined #openstack-infra15:37
AJaegercorvus: pipeline membership?15:38
AJaegerwhat do you mean with that15:38
corvusAJaeger: er, sorry, i meant shared change queue membership.  eg "queue: integrated"15:38
corvushongbin: oh, you're asking about jobs like zun-tempest-docker-sql.  sorry, missed that.15:39
AJaegercorvus: I don't remember any discussion. dhellmann, do you?15:39
Shrewsnjohnston: you shouldn't need to add specific core folks. cores should already be subscribed to the notifications for the project15:41
corvushongbin: there's no stable/rocky branch of devstack yet, so the job can't run.  as soon as it's branched, it will start working on the rocky branches of the zun repo.15:41
hongbincorvus: i see, thanks15:42
openstackgerritMerged openstack-infra/elastic-recheck master: Add query for cold migration revert ssh bug 1788403  https://review.openstack.org/59581815:44
openstackbug 1788403 in OpenStack Compute (nova) "test_server_connectivity_cold_migration_revert randomly fails ssh check" [Medium,Confirmed] https://launchpad.net/bugs/178840315:44
hongbincorvus: would look forward to the devstack change soon because there are no tempest coverage for all projects right now15:45
hongbini knew many projects have back-ported several patches to stable/rocky and the missing of coverage might be series15:48
AJaegerhongbin: having you here: are you going to go through the fuxi python3-first changes? Ignore those by Filipo, they are all conflicts to what dhellmann did earlier...15:48
AJaegerhongbin: devstack is a deliverable of QA team, best reach out to them15:48
hongbinAJaeger: i don't have +2 privilege on the fuxi repo, you might want to ping the kuryr-core for that15:49
AJaegerhongbin: ok15:49
hongbinAJaeger: ack for the devstack remark15:49
openstackgerritMerged openstack/os-testr master: Fix load command in pdb/no-discover path  https://review.openstack.org/53436515:50
*** sthussey has joined #openstack-infra15:50
*** e0ne has quit IRC15:51
*** dhill_ has quit IRC15:51
*** ykarel|away has quit IRC15:51
*** ssbarnea|ruck has joined #openstack-infra15:58
*** gyee has joined #openstack-infra15:59
*** sileht has left #openstack-infra16:02
*** diablo_rojo has joined #openstack-infra16:03
*** mriedem is now known as mriedem_sudsy16:04
*** ginopc has quit IRC16:08
*** icey has quit IRC16:09
*** icey has joined #openstack-infra16:10
*** dhill_ has joined #openstack-infra16:11
*** harlowja has joined #openstack-infra16:17
*** Bhujay has joined #openstack-infra16:19
*** jpena is now known as jpena|off16:25
corvusShrews, pabelanger: now this is interesting -- i pushed up a new patchset with all the hosts added to the job.  i expected testinfra to fail on some of them, but not on xenial, since it passed earlier.  but it failed on all hosts: http://logs.openstack.org/52/595252/9/check/system-config-run-base/2bbcf99/job-output.txt.gz#_2018-08-23_15_44_30_76016016:25
*** mriedem_sudsy is now known as mriedem16:26
corvusoh, it's saying all those hosts are 'unreachable'16:26
corvushrm.  well, i held the nodes, so i'll go poke at it16:26
*** SamYaple has joined #openstack-infra16:28
corvusit's super convenient that these nodes now have my user and key installed on them :)16:29
*** jamesmcarthur has quit IRC16:31
*** jamesmcarthur has joined #openstack-infra16:32
*** jpich has quit IRC16:32
corvusianw, pabelanger, Shrews: okay, i understand why it's not working -- the ~root/.ssh/authorized_keys file was correctly updated to only allow logins from bridge and puppetmaster.  what i don't understand is why that worked in the previous run.16:34
*** udesale has quit IRC16:40
dhellmannAJaeger, corvus : I asked how pipeline membership worked and IIRC you said zuul picks the first one it finds. I interpreted that as meaning it was ok to move it. Let me know if I'm wrong. We may have to move some settings back if that's the case.16:40
*** harlowja has quit IRC16:40
dhellmannAJaeger , corvus : I'm going to be offline starting about ~now until Monday, fwiw16:41
corvusdhellmann, AJaeger: from a social pov, we may want to have them in project-config, since adding and removing a project from a shared change queue is an action with cross-project effects.16:41
dhellmannok, that does make sense16:42
corvusdhellmann: project-config is first in line, so we can just add them back there and then clean up in-repo stragglers at leisure16:43
dhellmannhow many of the different settings are actually cross-team and how many are just setting up a pipeline of their own?16:43
corvusdhellmann: i don't know but i agree that's a good question16:44
dhellmannI feel like I saw at least some that were just linking a set of repos all owned by the same team16:44
dhellmannand then of course there's the integrated gate16:44
toskyuhm, infra people, sahara job definitions were migrated to repositories, but I noticed one strange thing16:44
toskyif you check those 4 commits (master and 3 backports), the gate jobs for rocky are way less than the other branches: https://review.openstack.org/#/q/4ac73ea6ecb001e7973a563a04b25ab914f79f2116:44
corvusdhellmann: maybe we only care about "integrated" (and if there are any like it)16:44
dhellmanncorvus : that would certainly leave a smaller set of projects to manage16:44
corvustosky: there's no rocky devstack branch, so there are no rocky devstack jobs16:45
toskyoh16:45
toskynow that I think about it, I may already have asked about this in the previous cycle16:45
* dhellmann has to leave to catch his flight16:45
corvustosky: i think we've agreed that we need to re-examine the branching order in the release process.  i imagine we'll talk about it at the ptg16:46
corvusdhellmann: bon voyage!16:46
toskycorvus: I totally agree that this specific point should be revisited, otherwise we have this free backporting season :)16:48
*** Swami has quit IRC16:49
*** davidlenwell has joined #openstack-infra16:50
openstackgerritsebastian marcet proposed openstack-infra/openstackid master: Updated PDO Config to Support SSL connections  https://review.openstack.org/59583216:52
*** ramishra has quit IRC16:52
toskycorvus: uhm, regarding the changes above: the same happened with the stable/pike branch16:59
AJaegercorvus: I think we did not remove them from project-config - I think dhellmann just copied and duplicated.... I'll double check when reviewing17:01
AJaegercorvus: just checked, the "queue: " lines are not deleted from project-config.17:02
AJaegercorvus: if we have those now duplicated - should we ask to remove them in-repo again?17:03
corvusAJaeger: let's decide if we want to do that only for cross-team shared queues, or all.  then yes.  :)17:04
corvustosky: i'll look at the pike change17:04
corvustosky: what job specifically should i look for?17:04
toskyit was approved by accident before the queens change, but this accident showed the issue17:05
toskycorvus: uh, no, sorry, sorry17:06
toskyI see the jobs now, I was sure they were not there17:06
toskyapologize17:06
corvustosky: np, easy fix :)17:06
*** shardy has quit IRC17:06
AJaegercorvus: having queue lines in a central place will avoid nasty surprises if somebody changes them...17:07
AJaegerasking for integrated gate to stay in project-config is a good policy IMHO.17:07
corvusAJaeger: yeah, i think we should do that for integrated.  i'm on the fence about others.17:08
*** Bhujay has quit IRC17:08
AJaegercorvus: same for me. Anybody else here to weight in?17:09
*** njohnston has left #openstack-infra17:13
*** sambetts_ is now known as sambetts|afk17:15
*** hashar is now known as hasharAway17:22
openstackgerritsebastian marcet proposed openstack-infra/puppet-openstackid master: Added configuration for MYSQL SSL connection  https://review.openstack.org/59583917:22
*** jrist has quit IRC17:26
*** holser_ has quit IRC17:28
*** mriedem is now known as mriedem_away17:36
*** holser_ has joined #openstack-infra17:36
*** jrist has joined #openstack-infra17:41
*** dtantsur is now known as dtantsur|afk17:46
openstackgerritWei Tie proposed openstack-dev/pbr master: Support subdirectory in the url  https://review.openstack.org/59006617:47
*** electrofelix has quit IRC17:48
openstackgerritAlexander Chadin proposed openstack-infra/project-config master: Add publish-to-pypi job to watcher-tempest-plugin  https://review.openstack.org/59584617:51
AJaegerchandankumar: are you around? Please setup pypi for the tempest-plugin change17:52
*** holser_ has quit IRC17:53
*** florianf has quit IRC17:53
*** sshnaidm is now known as sshnaidm|off17:54
*** tosky has quit IRC17:54
openstackgerritsebastian marcet proposed openstack-infra/openstackid master: Updated PDO Config to Support SSL connections  https://review.openstack.org/59583217:56
*** raissa has joined #openstack-infra17:57
smcginnisThis job appears to be stuck? http://zuul.openstack.org/stream.html?uuid=c85701f4f8ec47ba95243dfdc0ef5c09&logfile=console.log17:58
*** trown is now known as trown|lunch17:59
pabelangerlooks to be18:06
pabelangerbut unsure why18:06
pabelangerchecking zuul logs on executor now18:06
openstackgerritJames E. Blair proposed openstack-infra/system-config master: WIP: Add system-config-run-base job  https://review.openstack.org/59525218:07
radezhey folks, I've just realized that when networking-ansible was created https://review.openstack.org/#/c/565370/ the storyboard config for it were created as https://storyboard.openstack.org/#!/project/openstack/network-ansible18:11
*** sweston has quit IRC18:11
pabelangersmcginnis: logs say ansible is running on the remote node18:11
pabelangerbut not sure what it is doing18:11
*** sweston has joined #openstack-infra18:11
radezis there a way I can get the storyboard configs updated to match the project name? networking-ansible instead of network-ansible?18:11
smcginnispabelanger: Huh, OK. I hope whatever it is finished soon before it gets popped.18:12
pabelangersmcginnis: stash.sh seems to be still running18:12
radezoh nevermind is it correct, I think I had it listed somewhere incorrectly.18:14
*** mriedem_away is now known as mriedem18:17
*** jamesmcarthur has quit IRC18:19
Shrewscorvus: where is /home/zuul/inventory.yaml coming from for --ansible-inventory?18:19
openstackgerritsebastian marcet proposed openstack-infra/puppet-openstackid master: Added configuration for MYSQL SSL connection  https://review.openstack.org/59583918:21
*** r-daneel has joined #openstack-infra18:24
*** noama has quit IRC18:27
*** e0ne has joined #openstack-infra18:28
*** jcoufal_ has joined #openstack-infra18:30
*** jcoufal has quit IRC18:32
*** r-daneel_ has joined #openstack-infra18:38
*** hemna_ has quit IRC18:39
AJaegerconfig-core, for rocky release, we need https://review.openstack.org/#/c/595846/1 - could you review, please?18:39
*** r-daneel has quit IRC18:40
*** r-daneel_ is now known as r-daneel18:40
*** gcb_ has quit IRC18:41
*** apetrich has quit IRC18:42
AJaegerpabelanger, corvus ^18:43
*** efried is now known as efried_afk18:43
corvusShrews: doh, i forgot to change that.  i moved it to /etc/ansible/hosts/inventory.yaml so that we would pick up the host_vars files18:43
Shrewscorvus: and yet it ran? that log has me all confused18:44
corvusShrews: i'll look at the log18:44
openstackgerritJames E. Blair proposed openstack-infra/system-config master: WIP: Add system-config-run-base job  https://review.openstack.org/59525218:44
corvusShrews: it looks like testinfra "skipped"18:45
corvusShrews: apparently providing an invalid inventory file causes it to succeed.  "neat"18:45
Shrewscorvus: http://logs.openstack.org/52/595252/10/check/system-config-run-base/44dfc77/job-output.txt.gz#_2018-08-23_18_27_31_68699518:45
Shrewsresult ok18:46
Shrewsnice18:46
corvushere's the skip: http://logs.openstack.org/52/595252/10/check/system-config-run-base/44dfc77/job-output.txt.gz#_2018-08-23_18_28_25_60649218:46
*** e0ne has quit IRC18:46
Shrewsoh, this is all interleaved18:47
corvusShrews: the task you linked to is a little misleading, i think it's an include_role, so this "ok" at http://logs.openstack.org/52/595252/10/check/system-config-run-base/44dfc77/job-output.txt.gz#_2018-08-23_18_27_31_756166 basically means "i included the role".  then the role itself follows and that's the interesting bit18:47
corvuseither way, the result is the same.  "ok"  :)18:48
Shrewscorvus: ah i see.18:49
corvusoh neat, that one ran in an all-ipv6 env18:50
Shrewscorvus: we could pass that inventory in as an extra var to tox role, i think18:52
*** pcaruana has joined #openstack-infra18:52
Shrewscorvus: oh, maybe not18:52
Shrewsnm18:52
openstackgerritMerged openstack-infra/project-config master: Add publish-to-pypi job to watcher-tempest-plugin  https://review.openstack.org/59584618:53
fungiradez: if you want to rename the openstack/network-ansible repo to openstack/networking-ansible we have a process for that. just list it at https://wiki.openstack.org/wiki/Meetings/InfraTeamMeeting#Upcoming_Project_Renames and submit a corresponding project-config change and we'll (eventually) schedule a maintenance to change it over18:54
corvusShrews: i updated the path in ps11 and placed an autohold.  i expect testinfra to fail on some nodes and succeed on others.  i'll use the held node to iterate on a working test there.18:55
radezfungi: thx for the reply, it was my mistake, it was infact named networking-ansible from the beginning18:55
corvusooh its running now: http://zuul.openstack.org/stream.html?uuid=239fb4e087ba4220be57b49b946c3895&logfile=console.log18:55
pabelangerShrews: I think you could export ANSIBLE_INVENTORY=foo, and ansible-playbook does the right thing, if you didn't pass it via CLI18:56
corvuspabelanger: this is for testinfra18:56
pabelangerah18:56
Shrewscorvus: i don't think testinfra will run anywhere but on bridge18:56
corvusit's not an immedate problem -- the command line will work for now, but we might want to do what Shrews is suggesting if we want to support it elsewhere18:57
corvusShrews: yeah, my only concern at the moment is that it work from the pseudo-bridge created in that test18:57
fungiradez: oh, cool no worries then!18:58
AJaegerconfig-core, could you review https://review.openstack.org/595327 to fix translations reporting and https://review.openstack.org/592292 to retire rst2bash completely, please?18:58
*** trown|lunch is now known as trown19:01
Shrewscorvus: success! except for the distro specific pkg issues19:01
corvusShrews: yes -- though, trusty looks like it may have failed to ssh?19:02
corvusand there was another post failure... we'll have to look into that too, probably on the executor, since i didn't see anything in the logs19:04
corvus(the ssh key removal failed, but that's supposed to fail gracefully and not cause a post-failure)19:04
pabelangerah, does infra playbooks remove the per job ssh key?19:06
corvuspabelanger: yes post-ssh in the zuul base job does.19:08
corvusi can't tell at the moment whether we should expect it to still work at the end of the job.19:08
*** pcaruana has quit IRC19:09
*** jrist has quit IRC19:10
corvusi can't ssh into the held host, so there may still be something wrong19:11
corvusi guess i should recheck it and hold an ssh session open during the run19:12
pabelangerI see in logs we are restarting sshd on nodes, maybe something to do with that19:12
pabelanger+1 to keep ssh session open19:13
pabelangerbut, exciting nonetheless19:13
openstackgerritNicolas Hicher proposed openstack-infra/puppet-openstackci master: Add AFS mirror support  https://review.openstack.org/52937619:14
*** gcb_ has joined #openstack-infra19:18
corvusit does take it a while to put together the nodeset19:20
Shrewscould reduce it for now19:20
*** apetrich has joined #openstack-infra19:21
corvusShrews: it worked more reliably with only one node -- i think there may be races around ssh cached connections, etc.19:21
corvusso i think we're at the point where we want them all19:21
corvusit's running now, and i have 2 root shells open to pseudo-bridge at 158.69.87.79 .  i'll grab lunch now and poke at it when i get back.19:22
*** jrist has joined #openstack-infra19:23
edmondswgmann can you switch your -W to a +W on https://review.openstack.org/#/c/591563/ now that swift has branched?19:24
*** eharney has quit IRC19:25
smcginnisWould it be a significant amount of work to have different "integrated" queues in gate for different branches?19:36
smcginnisJust seems odd to have a stable/rocky patch keep getting restarted by issues with master patches ahead of it in the queue.19:36
AJaegersmcginnis: we have master only projects in the integrated queue AFAIK as well...19:40
*** mdrabe has quit IRC19:41
smcginnisI see a mix of master, stable/rocky, stable/queens, all at least shown as being in a row in the same queue. Maybe it's a display thing.19:43
*** lewo has joined #openstack-infra19:43
pabelangersmcginnis: one reason to keep them shared, is if a project is branchless, it will apply to all branches19:45
AJaegersmcginnis: I mean: We have projects like tempest with no stable branches. So, if tempest merges, you want it test with stable/rocky, master etc.19:45
AJaegersmcginnis: like pabelanger says19:45
*** jamesmcarthur has joined #openstack-infra19:45
corvusthe real reason is upgrade testing19:45
AJaegercorvus: good point19:46
corvusor, i guess, the "main" reason :)19:46
smcginnisAh, makes sense in those cases.19:47
openstackgerritNicolas Hicher proposed openstack-infra/puppet-openstackci master: Add AFS mirror support  https://review.openstack.org/52937619:49
openstackgerritKendall Nelson proposed openstack-infra/storyboard-webclient master: Show Email Addresses when Searching  https://review.openstack.org/58971319:51
*** jcoufal_ has quit IRC20:01
*** holser_ has joined #openstack-infra20:05
*** panda has quit IRC20:05
corvushrm, ssh works fine on those hosts, and testinfra worked as expected, and the job reported 'failure' as expected rather than 'post_failure'20:09
corvusbut this time it wasn't ipv6 only, it was mixed v4/v620:09
corvusso i think we need to catch a run on limestone20:10
*** eernst has quit IRC20:10
*** eernst has joined #openstack-infra20:12
*** jcoufal has joined #openstack-infra20:13
*** eernst has quit IRC20:14
*** eernst has joined #openstack-infra20:14
corvusi wonder if the lack of an ipv4 address causes a syntax error in the sshd config file20:20
openstackgerritJames E. Blair proposed openstack-infra/system-config master: WIP: Add system-config-run-base job  https://review.openstack.org/59525220:29
corvuslet's assume that's the case ^20:29
*** kgiusti has left #openstack-infra20:29
openstackgerritMatthew Treinish proposed openstack-infra/subunit2sql master: Fix pandas rolling calls in run_time graph  https://review.openstack.org/59588520:30
*** holser_ has quit IRC20:47
*** hamzy has quit IRC20:48
jmorgan1 /msg clarkb hey20:50
Shrewscorvus: looks like that did it?20:54
Shrewscentos is the only failure20:54
Shrewsand remove-build-sshkey seemed to work without errors20:55
openstackgerritMatthew Treinish proposed openstack-infra/subunit2sql master: Clean up run_time graph style  https://review.openstack.org/59588920:55
*** jmorgan1 has quit IRC20:55
Shrewsoh, but those were rax20:55
*** jmorgan1 has joined #openstack-infra20:55
corvusShrews: that was on rax which has ipv4, so we probably won't know if the ipv6 issue is fixed until it hits limestone again... ya20:55
corvusShrews: but i think i'll assume that was the issue for now, take those held nodes, make a working testinfra test, and push up a final version of the patch for actual merging20:56
Shrews++20:57
*** jcoufal has quit IRC20:59
*** jamesmcarthur has quit IRC21:00
*** rosmaita has quit IRC21:00
*** trown is now known as trown|outtypewww21:03
fungijmorgan1: clarkb is out for the week. need anything infrastructure related? we've got a whole team in here21:05
*** rh-jelabarre has quit IRC21:09
*** david-lyle has joined #openstack-infra21:15
ianwinfra-root : could i ask for some eyes on openafs & kerberos roles in -> https://review.openstack.org/#/c/593487 https://review.openstack.org/#/c/593486 .  last discussion with tonyb still having some issues with wheel build jobs, and i'd like us to spend time debugging the ansible rather than installing puppet in jobs21:15
*** jmorgan1 has quit IRC21:17
*** eernst has quit IRC21:17
*** eernst_ has joined #openstack-infra21:17
corvusianw: sure thing; i'll look right after i finish up the base-run job21:17
*** dklyle has quit IRC21:17
openstackgerritJames E. Blair proposed openstack-infra/system-config master: Add system-config-run-base job  https://review.openstack.org/59525221:22
openstackgerritJames E. Blair proposed openstack-infra/system-config master: Don't create "admin" group  https://review.openstack.org/59545421:22
*** owalsh_ has joined #openstack-infra21:22
*** owalsh has quit IRC21:25
*** dpawlik has joined #openstack-infra21:26
*** owalsh_ has quit IRC21:26
*** owalsh has joined #openstack-infra21:27
*** dpawlik has quit IRC21:30
corvusShrews, ianw: can you review https://review.openstack.org/595378  ?  (cc SpamapS, odyssey4me -- that's the write inventory role)21:31
*** panda has joined #openstack-infra21:34
openstackgerritJames E. Blair proposed openstack-infra/system-config master: Add iptables role  https://review.openstack.org/59397321:40
openstackgerritJames E. Blair proposed openstack-infra/system-config master: Transfer iptables rules to ansible  https://review.openstack.org/59434021:40
openstackgerritJames E. Blair proposed openstack-infra/system-config master: iptables: factor out snmp rules  https://review.openstack.org/59443721:40
openstackgerritJames E. Blair proposed openstack-infra/system-config master: iptables: add a README  https://review.openstack.org/59443821:40
*** dpawlik has joined #openstack-infra21:40
corvusrebased on the new run-base test ^21:40
*** mriedem is now known as mriedem_afk21:43
*** dpawlik has quit IRC21:45
*** rcernin has joined #openstack-infra21:46
openstackgerritMerged openstack-infra/system-config master: roles: Add README.rst and lint  https://review.openstack.org/59480021:56
tonybianw: Thanks.21:58
corvustestinfra has an 'iptables' object but no 'ip6tables' object.21:58
*** eernst_ has quit IRC22:03
*** hrubi has joined #openstack-infra22:06
*** jamesmcarthur has joined #openstack-infra22:07
openstackgerritJames E. Blair proposed openstack-infra/system-config master: iptables: factor out snmp rules  https://review.openstack.org/59443722:07
openstackgerritJames E. Blair proposed openstack-infra/system-config master: iptables: add a README  https://review.openstack.org/59443822:07
openstackgerritJames E. Blair proposed openstack-infra/system-config master: Add a testinfra test for iptables  https://review.openstack.org/59590022:07
*** eernst has joined #openstack-infra22:07
*** jamesmcarthur has quit IRC22:08
*** jamesmcarthur has joined #openstack-infra22:08
*** r-daneel_ has joined #openstack-infra22:08
*** r-daneel has quit IRC22:10
*** r-daneel_ is now known as r-daneel22:10
*** boden has quit IRC22:15
pabelangerlooks like we could write a patch to iptables module to use iptable6 command too, or atleast allow the command to be updated.22:16
pabelangerip6tables*22:18
*** owalsh has quit IRC22:18
*** owalsh has joined #openstack-infra22:22
*** dhill_ has quit IRC22:32
*** jamesmcarthur has quit IRC22:33
*** eernst has quit IRC22:33
corvusianw, SpamapS: i agree that in general role variables should be prefixed.  but do we really want to extend that to roles which are just wrappers around modules?  take a look at the expected usage in https://review.openstack.org/#/c/595252/13/playbooks/zuul/run-base.yaml and let me know if you still want me to change it.22:36
SpamapScorvus: yeah, that's why I left it at +1. I'm not really sure it's something to be dogmatic about.22:37
corvus(and i'm happy to go with "lets just always do it".  it's not hard to change that patch.  i'm mostly asking because it felt right to have "exim_aliases" for the exim role, and it felt right not to have "write_inventory_dest" for the write-inventory role, so i sort of wanted to check that and see why)22:38
openstackgerritJames E. Blair proposed openstack-infra/zuul-jobs master: Add write-inventory role  https://review.openstack.org/59590522:39
corvusSpamapS, ianw: https://review.openstack.org/595905 and https://review.openstack.org/595378 are alternates implementing both22:41
*** ssbarnea|ruck has quit IRC22:41
corvus2018-08-23 22:12:17.891183 | ubuntu-xenial | *** Missing role documentation: playbooks/roles/iptables/README.rst22:42
corvusthat's awesome!  i didn't know that had been implemented :)22:43
openstackgerritJames E. Blair proposed openstack-infra/system-config master: Add iptables role  https://review.openstack.org/59397322:44
openstackgerritJames E. Blair proposed openstack-infra/system-config master: Transfer iptables rules to ansible  https://review.openstack.org/59434022:44
openstackgerritJames E. Blair proposed openstack-infra/system-config master: iptables: factor out snmp rules  https://review.openstack.org/59443722:44
openstackgerritJames E. Blair proposed openstack-infra/system-config master: Add a testinfra test for iptables  https://review.openstack.org/59590022:44
corvusthose should all pass now.  i think the only thing up in the air is the write-inventory role.  let's get them all merged tomorrow22:46
*** jmorgan1 has joined #openstack-infra22:49
*** threestrands has joined #openstack-infra22:53
*** tpsilva has quit IRC22:54
*** raissa has quit IRC22:56
*** jamesmcarthur has joined #openstack-infra22:59
*** hamzy has joined #openstack-infra23:18
*** rlandy is now known as rlandy|brb23:24
*** jamesmcarthur has quit IRC23:24
ianwcorvus: yeah i put in a little script for the README.rst, but now thinking on it probably works better as an option to zuul-sphinx23:31
*** dingyichen has joined #openstack-infra23:42
*** felipemonteiro has joined #openstack-infra23:48

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!