openstackgerrit | Jeremy Stanley proposed openstack/project-config master: Revert "Introduce job for granular GitHub mirroring" https://review.opendev.org/718839 | 00:14 |
---|---|---|
*** gary_perkins has quit IRC | 00:24 | |
*** gary_perkins has joined #openstack-infra | 00:24 | |
openstackgerrit | Merged openstack/project-config master: Revert "Introduce job for granular GitHub mirroring" https://review.opendev.org/718839 | 00:32 |
*** ysandeep|out is now known as ysandeep | 00:34 | |
*** zxiiro has quit IRC | 00:56 | |
*** gyee has quit IRC | 01:09 | |
*** eharney has quit IRC | 01:12 | |
*** yamamoto has joined #openstack-infra | 01:32 | |
*** Goneri has quit IRC | 01:47 | |
*** lbragstad_ has joined #openstack-infra | 01:59 | |
*** lbragstad has quit IRC | 02:02 | |
*** __ministry has joined #openstack-infra | 02:02 | |
*** apetrich has quit IRC | 02:09 | |
*** rh-jelabarre has quit IRC | 02:19 | |
*** yamamoto has quit IRC | 02:21 | |
*** yamamoto_ has joined #openstack-infra | 02:21 | |
*** yamamoto_ has quit IRC | 02:23 | |
*** yamamoto has joined #openstack-infra | 02:58 | |
*** ociuhandu has joined #openstack-infra | 03:04 | |
*** ociuhandu has quit IRC | 03:09 | |
prometheanfire | hmmm | 03:19 |
prometheanfire | TASK [lxc_hosts : Ensure networking includes interfaces.d] | 03:19 |
prometheanfire | networkd still not a thing? | 03:19 |
* prometheanfire blames cloudnull | 03:21 | |
*** ysandeep is now known as ysandeep|off | 03:28 | |
openstackgerrit | Mohammed Naser proposed openstack/project-config master: Add infra-prod-update-system-config to deploy https://review.opendev.org/718877 | 03:31 |
prometheanfire | huh | 03:35 |
prometheanfire | /bin/sh: 1: /usr/bin/apt-listchanges: not found | 03:35 |
*** ramishra has joined #openstack-infra | 03:38 | |
*** ramishra has quit IRC | 03:38 | |
*** ramishra has joined #openstack-infra | 03:39 | |
prometheanfire | well..., gues I know what I'm doing https://bugs.launchpad.net/openstack-ansible/+bug/1839535 | 03:40 |
openstack | Launchpad bug 1839535 in openstack-ansible "debian9 container image is missing apt-listchanges package, but has the apt.conf.d/20listchanges config file, causing failure." [Undecided,New] - Assigned to Dmitriy Rabotyagov (noonedeadpunk) | 03:40 |
prometheanfire | debian 10 too | 03:40 |
fungi | the apt-listchanges is priority standard, so may not be on a minimal image | 03:41 |
fungi | erm the apt-listchanges package is priority standard | 03:42 |
*** yamamoto has quit IRC | 03:42 | |
*** HenryG has joined #openstack-infra | 03:44 | |
*** rcernin has joined #openstack-infra | 03:46 | |
*** yamamoto has joined #openstack-infra | 03:51 | |
*** yamamoto has quit IRC | 04:14 | |
*** cdearborn has quit IRC | 04:17 | |
*** yamamoto has joined #openstack-infra | 04:18 | |
*** evrardjp has quit IRC | 04:37 | |
*** evrardjp has joined #openstack-infra | 04:37 | |
prometheanfire | hmm meant that for openstack-ansible | 04:53 |
prometheanfire | https://review.opendev.org/718882 | 04:53 |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-pip: export ensure_pip_virtualenv_command https://review.opendev.org/718224 | 04:53 |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: fetch-zuul-cloner: use ensure-pip https://review.opendev.org/717882 | 04:53 |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: fetch-subunit-output test: use ensure-pip https://review.opendev.org/718225 | 04:53 |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-tox: use ensure-pip role https://review.opendev.org/717663 | 04:53 |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: Update Fedora to 31 https://review.opendev.org/717657 | 04:53 |
*** rcernin has quit IRC | 05:03 | |
*** armax has quit IRC | 05:23 | |
*** armax has joined #openstack-infra | 05:34 | |
*** lmiccini has joined #openstack-infra | 05:40 | |
*** armax has quit IRC | 06:02 | |
*** dpawlik has joined #openstack-infra | 06:20 | |
*** ociuhandu has joined #openstack-infra | 06:35 | |
*** yamamoto has quit IRC | 06:37 | |
*** ociuhandu has quit IRC | 06:40 | |
*** yamamoto has joined #openstack-infra | 06:44 | |
*** kota_ has quit IRC | 06:48 | |
*** kota_ has joined #openstack-infra | 06:49 | |
*** yamamoto has quit IRC | 06:58 | |
*** yamamoto has joined #openstack-infra | 06:59 | |
*** jcapitao has joined #openstack-infra | 06:59 | |
*** slaweq has joined #openstack-infra | 07:00 | |
*** ociuhandu has joined #openstack-infra | 07:04 | |
*** jlvillal has quit IRC | 07:08 | |
*** jlvillal has joined #openstack-infra | 07:08 | |
*** ociuhandu has quit IRC | 07:09 | |
*** pgaxatte has joined #openstack-infra | 07:14 | |
*** ociuhandu has joined #openstack-infra | 07:14 | |
*** ociuhandu has quit IRC | 07:15 | |
*** yamamoto has quit IRC | 07:15 | |
*** dklyle has quit IRC | 07:16 | |
*** ociuhandu has joined #openstack-infra | 07:16 | |
*** yamamoto has joined #openstack-infra | 07:17 | |
*** ociuhandu has quit IRC | 07:19 | |
*** ociuhandu has joined #openstack-infra | 07:19 | |
*** tosky has joined #openstack-infra | 07:32 | |
*** ricolin has joined #openstack-infra | 07:34 | |
*** rpittau|afk is now known as rpittau | 07:36 | |
*** Tengu has quit IRC | 07:39 | |
*** Tengu has joined #openstack-infra | 07:41 | |
*** slaweq has quit IRC | 07:51 | |
*** hashar has joined #openstack-infra | 07:52 | |
*** ramishra has quit IRC | 08:04 | |
*** dchen has quit IRC | 08:11 | |
*** roman_g has quit IRC | 08:18 | |
*** ociuhandu has quit IRC | 08:21 | |
*** pkopec has joined #openstack-infra | 08:22 | |
*** ociuhandu has joined #openstack-infra | 08:23 | |
*** tkajinam has quit IRC | 08:25 | |
*** ociuhandu has quit IRC | 08:28 | |
*** xek has joined #openstack-infra | 08:32 | |
*** jtomasek has joined #openstack-infra | 08:37 | |
*** jtomasek has quit IRC | 08:38 | |
openstackgerrit | Bernard Cafarelli proposed openstack/project-config master: Update Grafana dashboards for stable Neutron releases https://review.opendev.org/718676 | 08:51 |
*** gfidente|afk is now known as gfidente | 09:09 | |
*** jtomasek has joined #openstack-infra | 09:23 | |
*** ociuhandu has joined #openstack-infra | 09:32 | |
*** ociuhandu has quit IRC | 09:36 | |
noonedeadpunk | AJaeger: yeah, I was aware about other places to clean, just thought we can postpone these fixes a bit and they shouldn't be breaking things | 09:36 |
AJaeger | noonedeadpunk: yeah, those can wait - ther equired-projects not | 09:38 |
*** yamamoto has quit IRC | 10:01 | |
*** yamamoto has joined #openstack-infra | 10:01 | |
*** yamamoto has quit IRC | 10:02 | |
*** ociuhandu has joined #openstack-infra | 10:04 | |
*** persia_ is now known as persia | 10:07 | |
*** yamamoto has joined #openstack-infra | 10:13 | |
*** rpittau is now known as rpittau|bbl | 10:19 | |
*** yamamoto has quit IRC | 10:26 | |
*** pgaxatte has quit IRC | 10:32 | |
*** pgaxatte has joined #openstack-infra | 10:39 | |
*** yamamoto has joined #openstack-infra | 10:52 | |
*** yamamoto has quit IRC | 10:53 | |
*** jcapitao is now known as jcapitao_lunch | 10:58 | |
*** pkopec_ has joined #openstack-infra | 11:19 | |
*** pkopec has quit IRC | 11:22 | |
*** yamamoto has joined #openstack-infra | 11:34 | |
*** pkopec_ has quit IRC | 11:45 | |
*** pkopec_ has joined #openstack-infra | 11:46 | |
*** ociuhandu has quit IRC | 11:50 | |
*** ociuhandu has joined #openstack-infra | 11:51 | |
*** ociuhandu has quit IRC | 11:56 | |
*** rpittau|bbl is now known as rpittau | 11:58 | |
*** yamamoto has quit IRC | 11:59 | |
*** yamamoto has joined #openstack-infra | 12:12 | |
*** jcapitao_lunch is now known as jcapitao | 12:18 | |
openstackgerrit | Thierry Carrez proposed openstack/project-config master: [check-approval] Use committer instead of owner https://review.opendev.org/718994 | 12:36 |
*** pkopec_ has quit IRC | 13:01 | |
*** pkopec_ has joined #openstack-infra | 13:02 | |
*** ociuhandu has joined #openstack-infra | 13:09 | |
*** zigo has quit IRC | 13:16 | |
*** prometheanfire has quit IRC | 13:16 | |
*** cdearborn has joined #openstack-infra | 13:23 | |
*** yamamoto has quit IRC | 13:38 | |
*** psachin has joined #openstack-infra | 13:45 | |
*** dklyle has joined #openstack-infra | 13:55 | |
*** rh-jelabarre has joined #openstack-infra | 13:57 | |
*** yamamoto has joined #openstack-infra | 14:00 | |
*** zigo has joined #openstack-infra | 14:03 | |
*** slaweq has joined #openstack-infra | 14:18 | |
*** yamamoto has quit IRC | 14:23 | |
*** psachin has quit IRC | 14:24 | |
*** yamamoto has joined #openstack-infra | 14:27 | |
*** slaweq has quit IRC | 14:27 | |
*** ociuhandu has quit IRC | 14:28 | |
*** ociuhandu has joined #openstack-infra | 14:28 | |
*** slaweq has joined #openstack-infra | 14:29 | |
*** ociuhandu has quit IRC | 14:33 | |
*** slaweq has quit IRC | 14:33 | |
*** ociuhandu has joined #openstack-infra | 14:34 | |
openstackgerrit | Sean McGinnis proposed openstack/openstack-zuul-jobs master: Add Python3 project templates for Victoria release https://review.opendev.org/719031 | 14:38 |
*** ociuhandu has quit IRC | 14:38 | |
*** bdodd has quit IRC | 14:42 | |
*** bdodd has joined #openstack-infra | 14:43 | |
*** yamamoto has quit IRC | 14:44 | |
*** pgaxatte has quit IRC | 14:46 | |
*** yamamoto has joined #openstack-infra | 14:46 | |
openstackgerrit | Sean McGinnis proposed openstack/openstack-zuul-jobs master: Add Python3 project templates for Victoria release https://review.opendev.org/719031 | 14:51 |
*** yamamoto has quit IRC | 14:51 | |
AJaeger | smcginnis: the TC page you reference mentions py37 but your change omits it | 14:53 |
AJaeger | smcginnis: I should have read next paragraph - all fine. | 14:53 |
smcginnis | AJaeger: Note the text below that says it is only for integration tests. | 14:53 |
smcginnis | ;) | 14:53 |
*** rpittau is now known as rpittau|afk | 14:57 | |
AJaeger | config-core, please review 719031 ^ | 15:01 |
openstackgerrit | Merged openstack/openstack-zuul-jobs master: Add Python3 project templates for Victoria release https://review.opendev.org/719031 | 15:13 |
*** ociuhandu has joined #openstack-infra | 15:24 | |
*** lmiccini has quit IRC | 15:27 | |
*** yamamoto has joined #openstack-infra | 15:29 | |
*** gyee has joined #openstack-infra | 15:31 | |
*** ociuhandu has quit IRC | 15:35 | |
*** ociuhandu has joined #openstack-infra | 15:35 | |
*** yamamoto has quit IRC | 15:36 | |
*** Goneri has joined #openstack-infra | 15:40 | |
*** ociuhandu has quit IRC | 15:40 | |
openstackgerrit | Mohammed Naser proposed openstack/project-config master: Drop dependencies from manage-projects https://review.opendev.org/718877 | 15:46 |
*** jcapitao has quit IRC | 16:00 | |
*** armax has joined #openstack-infra | 16:01 | |
-openstackstatus- NOTICE: review.opendev.org is being restarted for scheduled maintenance; see http://lists.opendev.org/pipermail/service-announce/2020-April/000003.html | 16:05 | |
openstackgerrit | Merged openstack/project-config master: Drop dependencies from manage-projects https://review.opendev.org/718877 | 16:06 |
*** slaweq has joined #openstack-infra | 16:12 | |
*** artom has quit IRC | 16:17 | |
openstackgerrit | Mohammed Naser proposed openstack/project-config master: Revert "Revert "Introduce job for granular GitHub mirroring"" https://review.opendev.org/719047 | 16:24 |
*** ociuhandu has joined #openstack-infra | 16:29 | |
*** evrardjp has quit IRC | 16:37 | |
*** evrardjp has joined #openstack-infra | 16:37 | |
*** slaweq has quit IRC | 16:40 | |
*** prometheanfire has joined #openstack-infra | 16:48 | |
*** dpawlik has quit IRC | 16:53 | |
openstackgerrit | Mohammed Naser proposed openstack/project-config master: Revert "Revert "Introduce job for granular GitHub mirroring"" https://review.opendev.org/719047 | 16:57 |
*** __ministry has quit IRC | 16:59 | |
-openstackstatus- NOTICE: etherpad.openstack.org will be offline for about 30 minutes while it is migrated to a new server with a new hostname; see http://lists.opendev.org/pipermail/service-announce/2020-April/000003.html | 17:02 | |
openstackgerrit | Andreas Jaeger proposed zuul/zuul-jobs master: Fix check_jobs_documented linter https://review.opendev.org/719054 | 17:09 |
*** hashar has quit IRC | 17:20 | |
*** diablo_rojo has joined #openstack-infra | 17:45 | |
*** marcosilva has joined #openstack-infra | 17:48 | |
*** ociuhandu has quit IRC | 17:52 | |
*** admcleod has quit IRC | 17:52 | |
-openstackstatus- NOTICE: The etherpad migration is still in progress; revised estimated time of completion 18:30 UTC | 17:52 | |
*** admcleod has joined #openstack-infra | 17:53 | |
*** marcosilva has quit IRC | 17:56 | |
*** melwitt has quit IRC | 17:59 | |
*** mugsie has quit IRC | 17:59 | |
*** EmilienM has quit IRC | 17:59 | |
*** cmurphy has quit IRC | 17:59 | |
*** hwoarang has quit IRC | 17:59 | |
*** cyberpear has quit IRC | 17:59 | |
*** ricolin has quit IRC | 18:03 | |
*** melwitt has joined #openstack-infra | 18:03 | |
*** mugsie has joined #openstack-infra | 18:03 | |
*** cmurphy has joined #openstack-infra | 18:03 | |
*** EmilienM has joined #openstack-infra | 18:03 | |
*** hwoarang has joined #openstack-infra | 18:03 | |
*** cyberpear has joined #openstack-infra | 18:03 | |
*** jtomasek has quit IRC | 18:06 | |
*** EmilienM has quit IRC | 18:12 | |
*** EmilienM has joined #openstack-infra | 18:13 | |
*** jtomasek has joined #openstack-infra | 18:23 | |
*** slaweq has joined #openstack-infra | 18:30 | |
*** jamesmcarthur has joined #openstack-infra | 18:54 | |
*** jamesmcarthur has quit IRC | 19:30 | |
*** jamesmcarthur has joined #openstack-infra | 19:35 | |
smcginnis | Per http://lists.openstack.org/pipermail/openstack-discuss/2020-April/014055.html - could I request assistance in deleting the openstack/cinder driverfixes/mitaka and driverfixes/newton branches? | 19:38 |
*** jamesmcarthur has quit IRC | 19:40 | |
fungi | smcginnis: happy to help, just a moment | 19:45 |
*** markmcclain has quit IRC | 19:45 | |
*** jamesmcarthur has joined #openstack-infra | 19:45 | |
*** markmcclain has joined #openstack-infra | 19:46 | |
fungi | #status log deleted openstack/cinder branch driverfixes/mitaka formerly at a77f17e3778377a0d7aee9bf412554551a6b8435 | 19:47 |
openstackstatus | fungi: finished logging | 19:48 |
fungi | smcginnis: "branch openstack/cinder,refs/heads/driverfixes/newton has open changes" | 19:48 |
fungi | please abandon those and i'll be happy to try again | 19:48 |
smcginnis | fungi: On it! | 19:48 |
smcginnis | fungi: OK, abandoned on WIP patch that was still out there. | 19:50 |
fungi | #status log deleted openstack/cinder branch driverfixes/newton formerly at b9f6cd23ed7c806487d5df065b19741aecd36438 | 19:50 |
openstackstatus | fungi: finished logging | 19:50 |
smcginnis | fungi: Thanks! | 19:50 |
fungi | smcginnis: done, i'll reply on the ml | 19:50 |
smcginnis | Excellent | 19:50 |
fungi | and sent | 19:51 |
smcginnis | Always nice to wrap up pending items before the holiday. I had that one pending way too long. | 19:52 |
*** artom has joined #openstack-infra | 19:55 | |
*** nhicher has quit IRC | 20:02 | |
*** nhicher has joined #openstack-infra | 20:02 | |
-openstackstatus- NOTICE: Due to a database migration error, etherpad.opendev.org is offline until further notice. | 20:09 | |
*** aedc_ has joined #openstack-infra | 20:18 | |
*** aedc has quit IRC | 20:20 | |
*** aedc_ has quit IRC | 20:28 | |
*** sshnaidm|off has quit IRC | 20:46 | |
*** pkopec_ has quit IRC | 20:48 | |
*** jamesmcarthur_ has joined #openstack-infra | 20:57 | |
*** jamesmca_ has joined #openstack-infra | 20:58 | |
melwitt | can anyone sanity check us whether this is recommended way to handle required-projects on stable branch? https://review.opendev.org/719105 | 20:59 |
clarkb | melwitt: I think you only need the override checkout if you intend to test train placement with queens nova or whatever. Basically if hte branches aren't already aligned | 20:59 |
*** jamesmcarthur has quit IRC | 21:00 | |
clarkb | melwitt: bceause zuul should use the same branch for that dep as the branch for the change in question. The exception to that is if the branch does not exist it will fall back to master | 21:00 |
melwitt | clarkb: ok, what we're seeing is that on stable/train, it's checking out placement from master | 21:00 |
melwitt | if we don't do this | 21:00 |
melwitt | oh, hm | 21:00 |
melwitt | placement has a stable/train branch so... | 21:01 |
gmann | clarkb: and i think that is same for other functional job in nova which has placement as required_project | 21:01 |
clarkb | the branch selection should always be based on the triggering event | 21:01 |
gmann | melwitt: clarkb - https://zuul.opendev.org/t/openstack/build/b460a8c59ad64e57b871aa3c00638b01/log/job-output.txt#283 | 21:01 |
clarkb | are these jobs running in periodic maybe? since that doesn't have chagne event data | 21:01 |
*** ociuhandu has joined #openstack-infra | 21:01 | |
*** jamesmcarthur_ has quit IRC | 21:02 | |
melwitt | no these are plain functional test jobs. now, I'm not sure why we need required-projects on our func test jobs, I was going to guess because we use test fixtures from placement? | 21:02 |
fungi | or because you want to install placement from source instead of releases on pypi? | 21:02 |
melwitt | this is the example change where it failed https://review.opendev.org/718934 | 21:03 |
clarkb | melwitt: what required-projects will do is ensure /home/zuul/src/review.opendev.org/openstack/placement is in place next to /home/zuul/src/review.opendev.org/openstack/nova | 21:03 |
clarkb | and they should both be checked out to the branch that triggered the event | 21:03 |
clarkb | melwitt: ya I think because that chagne was to train placement would be checked out to train too and you can remove the override checkout directive | 21:03 |
gmann | and that is how other job with required_project does- checkout the stable branch version of required_project repo | 21:04 |
melwitt | sorry, I'm confused. that change (without override-checkout) is checking out placement from master | 21:04 |
clarkb | melwitt: in this job https://zuul.opendev.org/t/openstack/build/40f44994e05f4466b7576c0e22d0b13a ? | 21:05 |
gmann | https://zuul.opendev.org/t/openstack/build/b460a8c59ad64e57b871aa3c00638b01/log/job-output.txt#782 | 21:05 |
gmann | clarkb: ^^ | 21:05 |
melwitt | clarkb: I was looking at this one https://zuul.opendev.org/t/openstack/build/b460a8c59ad64e57b871aa3c00638b01 | 21:05 |
clarkb | https://zuul.opendev.org/t/openstack/build/40f44994e05f4466b7576c0e22d0b13a/log/job-output.txt#184 says its set to checkout train | 21:05 |
*** ociuhandu has quit IRC | 21:06 | |
clarkb | https://zuul.opendev.org/t/openstack/build/b460a8c59ad64e57b871aa3c00638b01/log/job-output.txt#196 same thing for that job so we need to work from there and figure out what is grabbing master I guess | 21:06 |
melwitt | the -py36 failure is legit. I need to update my patch for that one | 21:06 |
gmann | clarkb: melwitt ohh here is issue - https://github.com/openstack/nova/blob/master/tox.ini#L73 | 21:07 |
melwitt | clarkb: yeah that's what gmann was saying earlier in -nova, he said it's not using the placement that was already cloned from train | 21:07 |
clarkb | https://zuul.opendev.org/t/openstack/build/b460a8c59ad64e57b871aa3c00638b01/log/job-output.txt#562 yes that | 21:07 |
gmann | https://github.com/openstack/nova/blob/stable/train/tox.ini#L87 | 21:07 |
melwitt | oh, good spot | 21:07 |
clarkb | its never using the zuul version | 21:07 |
gmann | in stable train aslo tox use master as dep | 21:07 |
clarkb | that needs to be udpated to use the zuul version if you want to avoid doing unnecessary clones and to test with depends on | 21:08 |
melwitt | gmann: do you know how to tell it to use the zuul version? I don't | 21:09 |
clarkb | I think what you can do is have it check and env var and default to the opendev url | 21:09 |
gmann | i think we can rely on required-projects or just add placement in test-requirements.txt | 21:10 |
clarkb | then in your job set the env var to be /home/zuul/src/review.opendev.org/openstack/placement | 21:10 |
melwitt | gmann: yeah, I wish I knew why it's being done this way. mriedem did it so I'm sure there was a good reason | 21:10 |
clarkb | https://github.com/openstack/nova/blob/master/tox.ini#L29 the constraints file is selected in a similar way to what I describe | 21:10 |
melwitt | ah ok | 21:11 |
clarkb | melwitt: and in the tox jobs should be something that sets that constraints env var to use openstack/requiremetns from zuul | 21:11 |
clarkb | I think you can directly adopt that system | 21:11 |
fungi | also this may predate publication of services to pypi, so just having placement be a normal package requirement when running locally on your dev environment may suffice these days? | 21:13 |
*** gfidente has quit IRC | 21:13 | |
clarkb | unless you want to use depends on | 21:13 |
fungi | how would you depends-on in your local dev environment? | 21:13 |
clarkb | it wouldn't but it doesn't with constraints either | 21:14 |
clarkb | you'd probably do a tox deps install only, then install version of placement you want, then run tox tests only | 21:14 |
fungi | right, it would just go by the supported placement versions declared in requirements.txt if running locally | 21:14 |
fungi | and in zuul, tox-siblings would make sure the required-projects are installed from source, yeah? | 21:15 |
fungi | (using the checkout zuul has provided) | 21:16 |
clarkb | yup thats a good point I always forget about siblings | 21:16 |
clarkb | so ya listing it as a normal dep is probably simplest here | 21:16 |
fungi | but it's friday evening after a long day/week so entirely possible i shouldn't be engineering complex solutions at this stage | 21:16 |
gmann | ohk it is only required for functional tests so putting in requirement file is not good. i thought it is or both functional and unit deps | 21:17 |
fungi | test-requirements though? | 21:17 |
melwitt | yeah the code comment from mriedem says we don't want it for unit tests, only func tests | 21:17 |
clarkb | or just list it in tox.ini and siblings should do the correct thing | 21:17 |
fungi | yeah, in the deps var | 21:17 |
gmann | test-requirements also should not as unit test end up require it | 21:17 |
clarkb | the issue here is you are saying "install master placement" but if you say install placement version range from train it should work | 21:18 |
gmann | yeah deps var as it is currently but with u-c | 21:18 |
fungi | i actually think our historical test-requirements.txt model is terribly inflexible anyway. for my personal projects i just put tox-environment-specific requirements in the deps for each individual testenv | 21:19 |
melwitt | clarkb, gmann: ok, so it sounds like we need to update the deps in tox.ini to use the zuul version, that way we don't have to hard code each stable branch's line with literally stable/<release>? | 21:20 |
clarkb | melwitt: and you don't even need to use the zuul version explicitly if you just list placement as a dep and tox-siblings is in use | 21:21 |
clarkb | let me check the job log to see if it was in use there | 21:21 |
melwitt | oh. sorry, I know almost nothing about this until today | 21:21 |
melwitt | so the dep "git+https://opendev.org/openstack/placement#egg=openstack-placement" is not what you mean by listing placement as a dep | 21:23 |
gmann | env:PLACEMENT_VERSION: /home/zuul/src/review.opendev.org/openstack/placement} | 21:24 |
clarkb | correct because that literally means do a git clone and install what you get | 21:24 |
gmann | this way ? | 21:24 |
clarkb | gmann: also we don't need that because of tox siblings which I think are enabled by default | 21:24 |
gmann | ohk great | 21:24 |
clarkb | all you should need to do is add placement>x,<y | 21:24 |
clarkb | to ensure it installs the train version range on train | 21:25 |
clarkb | then the tox siblings handling will look to see if it needs to install tox from zuul for you | 21:25 |
melwitt | hm, that means we'd need different stable-only patches for each branch | 21:25 |
gmann | clarkb: do we still bed version cap things there ?or just deps placement'' and it will pick form zuul which will be stable branch checkout | 21:26 |
clarkb | gmann: you need it for the local run | 21:26 |
gmann | yeah what melwitt mentioned, we should avid that | 21:26 |
clarkb | since tox can be run outside of a zuul context | 21:26 |
melwitt | so maybe gmann earlier suggestion would be better so we just have the same thing we don't have to do a bunch of different things | 21:26 |
clarkb | fwiw its not different than curating requirements.txt | 21:26 |
clarkb | you are just doing it in tox.ini to avoid installing it all the time | 21:26 |
gmann | ohk for local run I think we reply on env they run and install proper version | 21:27 |
gmann | yeah | 21:27 |
gmann | s/reply/rely | 21:28 |
*** xek has quit IRC | 21:43 | |
*** diablo_rojo has quit IRC | 21:54 | |
*** ociuhandu has joined #openstack-infra | 22:13 | |
*** jamesdenton has joined #openstack-infra | 22:15 | |
*** jamesden_ has quit IRC | 22:16 | |
-openstackstatus- NOTICE: Maintenance on etherpad.opendev.org is complete and the service is available again | 22:25 | |
*** ociuhandu has quit IRC | 22:29 | |
*** ociuhandu has joined #openstack-infra | 22:30 | |
*** ociuhandu has quit IRC | 22:35 | |
*** smarcet has joined #openstack-infra | 22:53 | |
*** hashar has joined #openstack-infra | 22:58 | |
*** jamesden_ has joined #openstack-infra | 23:00 | |
*** jamesdenton has quit IRC | 23:04 | |
*** hashar has quit IRC | 23:13 | |
*** smarcet has left #openstack-infra | 23:18 | |
*** jamesmca_ has quit IRC | 23:19 | |
*** jamesmcarthur has joined #openstack-infra | 23:20 | |
*** tosky has quit IRC | 23:20 | |
*** rcernin has joined #openstack-infra | 23:20 | |
*** jamesmcarthur has quit IRC | 23:25 | |
*** jamesmcarthur has joined #openstack-infra | 23:33 | |
*** yamamoto has joined #openstack-infra | 23:36 | |
*** yamamoto has quit IRC | 23:40 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!