*** artom has quit IRC | 00:02 | |
*** artom has joined #openstack-infra | 00:02 | |
openstackgerrit | Ian Wienand proposed openstack/project-config master: Switch nodepool builders to opendev.org mirror https://review.opendev.org/690757 | 00:03 |
---|---|---|
*** dychen has quit IRC | 00:12 | |
*** artom has quit IRC | 00:13 | |
*** dchen has joined #openstack-infra | 00:15 | |
*** hongbin has quit IRC | 00:15 | |
openstackgerrit | Merged openstack/project-config master: Switch nodepool builders to opendev.org mirror https://review.opendev.org/690757 | 00:20 |
*** rfolco|rover has joined #openstack-infra | 00:20 | |
*** tetsuro has joined #openstack-infra | 00:22 | |
*** rfolco|rover has quit IRC | 00:25 | |
*** ysandeep|away is now known as ysandeep | 00:28 | |
*** hongbin has joined #openstack-infra | 00:28 | |
*** pkopec has quit IRC | 00:49 | |
*** pkopec has joined #openstack-infra | 00:54 | |
*** Goneri has quit IRC | 01:11 | |
*** jamesdenton has joined #openstack-infra | 01:17 | |
*** jamesdenton has quit IRC | 01:22 | |
*** jamesdenton has joined #openstack-infra | 01:24 | |
*** amoralej|off has quit IRC | 01:48 | |
*** jpena|off has quit IRC | 01:52 | |
*** pkopec has quit IRC | 01:54 | |
*** pkopec has joined #openstack-infra | 01:56 | |
openstackgerrit | Ian Wienand proposed openstack/project-config master: Remove citycloud kna1/lon1/sto2 clouds https://review.opendev.org/727902 | 01:56 |
*** pkopec has quit IRC | 02:01 | |
*** ricolin has quit IRC | 02:08 | |
*** hongbin_ has joined #openstack-infra | 02:25 | |
*** hongbin has quit IRC | 02:28 | |
*** gyee has quit IRC | 02:38 | |
*** ramishra has joined #openstack-infra | 02:44 | |
*** xinranwang has joined #openstack-infra | 03:00 | |
*** tetsuro has quit IRC | 03:02 | |
*** psachin has joined #openstack-infra | 03:23 | |
openstackgerrit | Oleksandr Kozachenko proposed zuul/zuul-jobs master: Patch CoreDNS corefile https://review.opendev.org/727868 | 03:23 |
*** hongbin_ has quit IRC | 03:29 | |
*** tetsuro has joined #openstack-infra | 03:36 | |
*** tetsuro has quit IRC | 03:44 | |
*** ociuhandu has joined #openstack-infra | 03:50 | |
*** tetsuro has joined #openstack-infra | 03:51 | |
*** tetsuro has quit IRC | 03:52 | |
*** mmethot_ has joined #openstack-infra | 03:54 | |
*** ociuhandu has quit IRC | 03:55 | |
*** mmethot has quit IRC | 03:56 | |
*** zxiiro has quit IRC | 03:57 | |
*** ykarel|away is now known as ykarel | 03:58 | |
openstackgerrit | Ian Wienand proposed openstack/project-config master: Switch RAX IAD mirror to opendev.org version https://review.opendev.org/727917 | 03:58 |
*** tetsuro has joined #openstack-infra | 04:02 | |
*** evrardjp has quit IRC | 04:36 | |
*** evrardjp has joined #openstack-infra | 04:36 | |
*** bdodd has quit IRC | 04:43 | |
*** bdodd has joined #openstack-infra | 04:46 | |
*** KeithMnemonic has quit IRC | 05:14 | |
openstackgerrit | Merged openstack/hacking master: Enable flake8 3.8.* https://review.opendev.org/727134 | 05:29 |
*** udesale has joined #openstack-infra | 05:30 | |
openstackgerrit | Oleksandr Kozachenko proposed zuul/zuul-jobs master: Add container and pod log in the test for ensure-kubernetes role https://review.opendev.org/727929 | 05:43 |
*** lmiccini has joined #openstack-infra | 06:04 | |
*** dpawlik has joined #openstack-infra | 06:06 | |
*** ociuhandu has joined #openstack-infra | 06:34 | |
*** xek_ has joined #openstack-infra | 06:37 | |
*** xek has quit IRC | 06:40 | |
*** ociuhandu has quit IRC | 06:50 | |
*** ralonsoh has joined #openstack-infra | 06:55 | |
openstackgerrit | Oleksandr Kozachenko proposed zuul/zuul-jobs master: Patch CoreDNS corefile https://review.opendev.org/727868 | 06:55 |
openstackgerrit | Oleksandr Kozachenko proposed zuul/zuul-jobs master: Add container and pod log in the test for ensure-kubernetes role https://review.opendev.org/727929 | 06:55 |
*** xinranwang has quit IRC | 07:00 | |
*** dciabrin has quit IRC | 07:04 | |
*** dciabrin has joined #openstack-infra | 07:04 | |
*** slaweq has joined #openstack-infra | 07:08 | |
*** jcapitao has joined #openstack-infra | 07:10 | |
*** ociuhandu has joined #openstack-infra | 07:17 | |
*** pgaxatte has joined #openstack-infra | 07:28 | |
*** tosky has joined #openstack-infra | 07:31 | |
*** dtantsur|afk is now known as dtantsur | 07:32 | |
*** rpittau|afk is now known as rpittau | 07:33 | |
openstackgerrit | Andreas Jaeger proposed openstack/project-config master: Remove citycloud kna1/lon1/sto2 clouds https://review.opendev.org/727902 | 07:34 |
openstackgerrit | Andreas Jaeger proposed openstack/project-config master: Remove Citycloud from grafana https://review.opendev.org/727956 | 07:35 |
openstackgerrit | Andreas Jaeger proposed openstack/project-config master: Stop translation stable branches on projects without Dashboard https://review.opendev.org/723217 | 07:47 |
*** ricolin has joined #openstack-infra | 07:52 | |
*** ccamacho has joined #openstack-infra | 07:55 | |
*** jpena has joined #openstack-infra | 07:57 | |
*** ociuhandu has quit IRC | 08:00 | |
*** ociuhandu has joined #openstack-infra | 08:00 | |
*** ykarel is now known as ykarel|lunch | 08:11 | |
dtantsur | AJaeger: hi! just to check with you: is this a valid change? https://review.opendev.org/#/c/727961/ | 08:14 |
*** jaicaa has quit IRC | 08:14 | |
*** ysandeep is now known as ysandeep|lunch | 08:14 | |
*** jaicaa has joined #openstack-infra | 08:17 | |
*** xek__ has joined #openstack-infra | 08:19 | |
*** ccamacho has quit IRC | 08:20 | |
*** xek_ has quit IRC | 08:22 | |
*** matt_kosut has quit IRC | 08:28 | |
*** pkopec has joined #openstack-infra | 08:29 | |
*** ccamacho has joined #openstack-infra | 08:34 | |
AJaeger | dtantsur: yes! We don't need those anymore and update also the manual for this, see https://review.opendev.org/#/c/723601/ | 08:34 |
*** gfidente has joined #openstack-infra | 08:38 | |
*** dpawlik has quit IRC | 08:40 | |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul-jobs master: yamlint: EOF newlines and comments indent https://review.opendev.org/725516 | 08:42 |
*** dpawlik has joined #openstack-infra | 08:45 | |
dtantsur | okay, thanks! | 08:55 |
openstackgerrit | Akihiro Motoki proposed openstack/openstack-zuul-jobs master: Use new npm jobs in nodejs[468]-jobs templates https://review.opendev.org/727976 | 08:56 |
AJaeger | amotoki: so, all working fine? Great, thanks for testing ^ | 08:56 |
amotoki | AJaeger: it will be tested via https://review.opendev.org/726712 (which I just proposed) | 08:57 |
AJaeger | amotoki: want to WIP 727976 so long? | 08:58 |
amotoki | AJaeger: I don | 08:59 |
amotoki | AJaeger: i don't think so. we can just wait npm job results. | 08:59 |
*** ysandeep|lunch is now known as ysandeep | 09:03 | |
AJaeger | ok | 09:03 |
*** sshnaidm|afk is now known as sshnaidm | 09:11 | |
amotoki | AJaeger: Looking at the zuul status, horizon test commit succeeded for both npm jobs. | 09:12 |
AJaeger | \o/ | 09:22 |
openstackgerrit | Merged zuul/zuul-jobs master: yamlint: EOF newlines and comments indent https://review.opendev.org/725516 | 09:27 |
*** ykarel|lunch is now known as ykarel | 09:31 | |
*** matt_kosut has joined #openstack-infra | 09:37 | |
*** ykarel is now known as ykarel|mtg | 10:02 | |
*** rpittau is now known as rpittau|bbl | 10:18 | |
*** tetsuro has quit IRC | 10:29 | |
*** viks____ has joined #openstack-infra | 10:31 | |
*** derekh has joined #openstack-infra | 10:43 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-tox-output: use tox_extra_args https://review.opendev.org/728023 | 10:50 |
*** jcapitao is now known as jcapitao_lunch | 11:04 | |
*** ociuhandu has quit IRC | 11:11 | |
*** ociuhandu has joined #openstack-infra | 11:11 | |
*** ociuhandu has quit IRC | 11:15 | |
*** ociuhandu has joined #openstack-infra | 11:17 | |
*** ykarel|mtg is now known as ykarel | 11:18 | |
*** lpetrut has joined #openstack-infra | 11:25 | |
*** ociuhandu has quit IRC | 11:26 | |
*** ociuhandu has joined #openstack-infra | 11:27 | |
*** ociuhandu has quit IRC | 11:27 | |
*** ociuhandu has joined #openstack-infra | 11:27 | |
*** happyhemant has joined #openstack-infra | 11:33 | |
*** ociuhandu has quit IRC | 11:38 | |
*** ociuhandu has joined #openstack-infra | 11:40 | |
*** dklyle has quit IRC | 11:43 | |
*** udesale has quit IRC | 11:44 | |
*** ociuhandu has quit IRC | 11:49 | |
*** lseki has quit IRC | 11:51 | |
*** rlandy has joined #openstack-infra | 11:53 | |
*** udesale has joined #openstack-infra | 11:58 | |
*** tkajinam has quit IRC | 12:01 | |
openstackgerrit | Merged zuul/zuul-jobs master: Combine javascript deployment and deployment-tarball jobs https://review.opendev.org/727370 | 12:02 |
openstackgerrit | Tristan Cacqueray proposed zuul/zuul-jobs master: fetch-sphinx-tarball: introduce zuul_use_fetch_output https://review.opendev.org/681870 | 12:03 |
*** udesale_ has joined #openstack-infra | 12:04 | |
*** jpena is now known as jpena|lunch | 12:07 | |
*** rpittau|bbl is now known as rpittau | 12:15 | |
*** jcapitao_lunch is now known as jcapitao | 12:17 | |
*** rfolco|rover has joined #openstack-infra | 12:20 | |
*** rh-jelabarre has joined #openstack-infra | 12:22 | |
*** Goneri has joined #openstack-infra | 12:28 | |
*** derekh has quit IRC | 12:34 | |
*** lpetrut has quit IRC | 12:36 | |
*** ociuhandu has joined #openstack-infra | 12:36 | |
*** lseki has joined #openstack-infra | 12:41 | |
*** lpetrut has joined #openstack-infra | 12:48 | |
*** ykarel is now known as ykarel|afk | 12:54 | |
*** lbragstad_ has joined #openstack-infra | 12:58 | |
*** lbragstad_ has quit IRC | 12:59 | |
*** lbragstad_ has joined #openstack-infra | 12:59 | |
*** lbragstad has quit IRC | 13:01 | |
*** jpena|lunch is now known as jpena | 13:05 | |
*** derekh has joined #openstack-infra | 13:12 | |
*** psachin has quit IRC | 13:25 | |
*** zxiiro has joined #openstack-infra | 13:31 | |
*** artom has joined #openstack-infra | 13:37 | |
*** KeithMnemonic has joined #openstack-infra | 13:43 | |
*** lpetrut has quit IRC | 13:46 | |
slaweq | hi openstack-infra | 13:56 |
slaweq | I have a question about patch https://review.opendev.org/#/c/720956/ in networking-odl | 13:56 |
slaweq | is there way to "force" merge it without pass the gate? We have 2 patches, https://review.opendev.org/#/c/720956/ and also https://review.opendev.org/#/c/724656/ which blocks each other in the gate | 13:57 |
slaweq | one is fixing unit tests and second functional tests | 13:57 |
slaweq | we could "squash" them into one patch to unblock the gate but https://review.opendev.org/#/c/724656/ is also needed to be backported | 13:57 |
*** xek__ has quit IRC | 14:01 | |
*** xek__ has joined #openstack-infra | 14:02 | |
*** lajoskatona has joined #openstack-infra | 14:05 | |
*** ykarel|afk is now known as ykarel | 14:07 | |
*** lbragstad_ is now known as lbragstad | 14:08 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-tox-output: use tox_extra_args https://review.opendev.org/728023 | 14:15 |
clarkb | slaweq: 724656 passes. would it passif it was 720956's parent? | 14:21 |
clarkb | it seems that 720956 is simply changing how mock is used and not necessarily fixing tests? | 14:22 |
*** dklyle has joined #openstack-infra | 14:26 | |
slaweq | clarkb: it wouldn't | 14:27 |
slaweq | it pass only because it is on top of 720956 | 14:28 |
slaweq | lajoskatona: can You confirm that I'm correct with ^^ ? | 14:28 |
lajoskatona | Hi | 14:32 |
lajoskatona | clarkb: yes as in neutron mock was changed to unittest.mock unittests started to fail, and the 720956 "fixed" those failures with removing the dependency on mock | 14:34 |
clarkb | but that is a different repo with its own tests? | 14:36 |
lajoskatona | clarkb: 724656 was fixing an error which broke some functional tests | 14:36 |
lajoskatona | clarkb: yes it's a neutron stadium project | 14:36 |
lajoskatona | clarkb: so independent but living together with neutron | 14:36 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-tox-output: use tox_extra_args https://review.opendev.org/728023 | 14:37 |
clarkb | but the unittests of one repo shouldnt impact another? | 14:37 |
lajoskatona | clarkb: the unit tests of networking-odl (and other stadiums as well as I know) do import from neutron..... | 14:37 |
clarkb | but do they import neutrons unittests? | 14:38 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-tox-output: use tox_extra_args https://review.opendev.org/728023 | 14:38 |
clarkb | if so that seems like a bug itself (for the reason we see here, no one is wroting unittests as a public interface) | 14:38 |
slaweq | clarkb: they import neutron.tests.base | 14:38 |
lajoskatona | yes, here's an example failure: https://ee99908f7d10957a7584-93d3d7ef673b2093cfe933863d70bd19.ssl.cf5.rackcdn.com/724656/6/gate/openstack-tox-py37/897dd42/testr_results.html | 14:40 |
lajoskatona | the traceback is not clear (for me at least) but originates the problem from neutron.tests.base | 14:40 |
clarkb | ok then I guess my last question is, do we prefer to force merge the mock change or the other change (really which presents the least risk, I expect the mock change is the least risk) | 14:40 |
lajoskatona | clarkb: yeah, I would say the same | 14:41 |
slaweq | clarkb: I think that force merge of mock fix would be good | 14:41 |
slaweq | as the other patch already proved to be fine on top of mock fix | 14:41 |
clarkb | ok can you review that mock change so that it has the appropriate code review values then I can force a submit via +2 verified | 14:42 |
lajoskatona | clarkb: sure | 14:42 |
slaweq | clarkb: sure, doing :) | 14:43 |
clarkb | lajoskatona: did you want to +2 it too? | 14:48 |
lajoskatona | clarkb: just a sec, I found one "from mock import patch" line | 14:49 |
lajoskatona | as I checked with grep | 14:49 |
*** beagles_pto is now known as beagles | 14:51 | |
lajoskatona | sorry it seems last time I overlooked this one...... :-( | 14:51 |
slaweq | lajoskatona: that could be also changed in follow up later, without "force", but thx for checking it once again | 14:53 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-tox-output: use tox_extra_args https://review.opendev.org/728023 | 14:54 |
clarkb | once we've confirmed the unittests are still happy on the latest patchset let me know and I'll get it submitted in gerrit | 14:54 |
*** evrardjp has quit IRC | 14:55 | |
*** fresta has quit IRC | 14:56 | |
*** evrardjp has joined #openstack-infra | 14:56 | |
lajoskatona | slaweq, clarkb: thanks, and sorry for using your time | 14:57 |
slaweq | clarkb: thx a lot | 14:58 |
openstackgerrit | Merged zuul/zuul-jobs master: tox siblings installed packages: Add PEP 440 direct reference format https://review.opendev.org/727475 | 15:00 |
*** pgaxatte has quit IRC | 15:01 | |
*** gyee has joined #openstack-infra | 15:04 | |
*** slaweq has quit IRC | 15:06 | |
*** fresta has joined #openstack-infra | 15:09 | |
*** fresta has quit IRC | 15:11 | |
*** slaweq has joined #openstack-infra | 15:11 | |
*** ykarel is now known as ykarel|away | 15:12 | |
*** fresta has joined #openstack-infra | 15:12 | |
*** bdodd has quit IRC | 15:22 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-tox-output: use tox_extra_args https://review.opendev.org/728023 | 15:23 |
*** bdodd has joined #openstack-infra | 15:25 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: tox: use tox_extra_args, add tox_config_file https://review.opendev.org/728023 | 15:30 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: tox: use tox_extra_args, add tox_config_file https://review.opendev.org/728023 | 15:31 |
*** ysandeep is now known as ysandeep|sleep | 15:31 | |
*** ociuhandu has quit IRC | 15:34 | |
*** ociuhandu has joined #openstack-infra | 15:35 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: tox: use tox_extra_args, add tox_config_file https://review.opendev.org/728023 | 15:39 |
*** ociuhandu has quit IRC | 15:42 | |
*** jcapitao is now known as jcapitao_afk | 15:44 | |
*** ociuhandu has joined #openstack-infra | 15:46 | |
*** fresta has quit IRC | 15:52 | |
*** fresta has joined #openstack-infra | 15:53 | |
*** __ministry1 has joined #openstack-infra | 15:58 | |
*** __ministry1 has quit IRC | 16:00 | |
*** rpittau is now known as rpittau|afk | 16:01 | |
openstackgerrit | Merged zuul/zuul-jobs master: Policy rule for ownership between remote and executor https://review.opendev.org/724855 | 16:04 |
*** sshnaidm is now known as sshnaidm|afk | 16:21 | |
*** happyhemant has quit IRC | 16:22 | |
*** dpawlik has quit IRC | 16:27 | |
*** udesale has quit IRC | 16:28 | |
*** udesale_ has quit IRC | 16:28 | |
*** evrardjp has quit IRC | 16:33 | |
slaweq | clarkb: UT in https://review.opendev.org/#/c/720956/4 are green and it now have 2x +2 | 16:33 |
*** evrardjp has joined #openstack-infra | 16:33 | |
openstackgerrit | Clark Boylan proposed openstack/openstack-zuul-jobs master: Put sphinx-build pdf logs in a separate file https://review.opendev.org/728135 | 16:39 |
*** rlandy is now known as rlandy|biab | 16:40 | |
clarkb | AJaeger: ^ how does that look? I thinkwe can also do a depends-on change from ironic if you want to test it further (not a bad idea) | 16:40 |
clarkb | slaweq: thanks I'll submit it now | 16:40 |
AJaeger | clarkb: clever! Can you add test job in some repo for testing? Don't use ironic, that's broken right now ;( | 16:41 |
AJaeger | clarkb: do we need the -vv for tox? | 16:42 |
clarkb | AJaeger: its the default in the tox role | 16:42 |
AJaeger | ah, ok, then leave it in | 16:42 |
clarkb | AJaeger: I think -vv is what tells you the package versions that are installed so we should keep it | 16:42 |
clarkb | slaweq: lajoskatona all done | 16:43 |
clarkb | AJaeger: do you have a suggestion for a repo to try with a depends on? or maybe you can push that? | 16:43 |
AJaeger | clarkb: on it | 16:44 |
*** dtantsur is now known as dtantsur|afk | 16:44 | |
AJaeger | https://review.opendev.org/728135 | 16:45 |
clarkb | AJaeger: thats the same change as the one I pushed | 16:46 |
*** jcapitao_afk is now known as jcapitao | 16:49 | |
*** ociuhandu has quit IRC | 16:52 | |
*** jcapitao has quit IRC | 16:53 | |
*** ociuhandu has joined #openstack-infra | 16:53 | |
*** ociuhandu has quit IRC | 16:53 | |
*** ociuhandu has joined #openstack-infra | 16:54 | |
AJaeger | argh ;( | 16:54 |
AJaeger | https://review.opendev.org/#/c/728136/ | 16:55 |
AJaeger | better? | 16:55 |
clarkb | yup that looks good | 16:55 |
AJaeger | great! | 16:57 |
*** derekh has quit IRC | 16:58 | |
AJaeger | fungi, want to review that one as well, please? ^ | 17:00 |
*** lmiccini has quit IRC | 17:06 | |
*** ociuhandu has quit IRC | 17:06 | |
*** ociuhandu has joined #openstack-infra | 17:08 | |
openstackgerrit | Tristan Cacqueray proposed zuul/zuul-jobs master: Simplify zuul-output usage and remove merge-output-to-logs https://review.opendev.org/728151 | 17:11 |
*** jpena is now known as jpena|off | 17:13 | |
openstackgerrit | James E. Blair proposed zuul/zuul-jobs master: Move artifactory test job https://review.opendev.org/728152 | 17:13 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Add a tox module https://review.opendev.org/728154 | 17:14 |
*** panda is now known as panda|out | 17:15 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Add a tox module https://review.opendev.org/728154 | 17:16 |
*** pkopec has quit IRC | 17:18 | |
openstackgerrit | Merged zuul/zuul-jobs master: fetch-sphinx-tarball: introduce zuul_use_fetch_output https://review.opendev.org/681870 | 17:19 |
*** gfidente is now known as gfidente|afk | 17:20 | |
openstackgerrit | Merged zuul/zuul-jobs master: Add upload-artifactory role https://review.opendev.org/725678 | 17:26 |
*** ociuhandu has quit IRC | 17:27 | |
*** yolanda has quit IRC | 17:28 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Add a tox module https://review.opendev.org/728154 | 17:28 |
*** ociuhandu has joined #openstack-infra | 17:28 | |
*** ociuhandu has quit IRC | 17:33 | |
openstackgerrit | Merged zuul/zuul-jobs master: Move artifactory test job https://review.opendev.org/728152 | 18:05 |
lajoskatona | clarkb: thanks | 18:08 |
lajoskatona | slaweq: thanks | 18:08 |
*** lajoskatona has left #openstack-infra | 18:08 | |
*** hashar has joined #openstack-infra | 18:11 | |
*** ralonsoh has quit IRC | 18:21 | |
*** rlandy|biab is now known as rlandy | 18:30 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: tox: update lint regex to not require column https://review.opendev.org/725030 | 18:31 |
*** dpawlik has joined #openstack-infra | 18:51 | |
*** hashar has quit IRC | 19:22 | |
*** hashar has joined #openstack-infra | 19:23 | |
*** dpawlik has quit IRC | 19:46 | |
*** slaweq has quit IRC | 19:51 | |
*** slaweq has joined #openstack-infra | 19:59 | |
*** ociuhandu has joined #openstack-infra | 20:06 | |
*** ociuhandu has quit IRC | 20:13 | |
clarkb | AJaeger: https://zuul.opendev.org/t/openstack/build/acdf11e0c518405fab7ae45df392f28b/logs looks good to me | 20:20 |
clarkb | AJaeger: we got the logs in a separate file and the job-output is cleaner | 20:20 |
AJaeger | clarkb: agreed | 20:21 |
clarkb | fungi: ^ if you have a moment https://review.opendev.org/#/c/728135/1 is tested by https://review.opendev.org/#/c/728136/ and looks good | 20:21 |
AJaeger | now to get it merged ;) | 20:21 |
clarkb | fungi: if we can land that change I'll go and restart the logstash machinery | 20:21 |
*** ccamacho has quit IRC | 20:23 | |
clarkb | fungi: thanks! | 20:25 |
fungi | yw! | 20:26 |
openstackgerrit | Merged openstack/openstack-zuul-jobs master: Put sphinx-build pdf logs in a separate file https://review.opendev.org/728135 | 20:33 |
*** stevebaker has quit IRC | 20:33 | |
*** stevebaker has joined #openstack-infra | 20:34 | |
*** hashar has quit IRC | 20:49 | |
*** Goneri has quit IRC | 21:04 | |
*** matt_kosut has quit IRC | 21:28 | |
*** lbragstad has quit IRC | 21:35 | |
clarkb | melwitt: can you set latex_engine in your local project sphinx conf.py? | 21:54 |
melwitt | clarkb: yes, that's what I had proposed in my patch and that worked | 21:55 |
melwitt | but they wanted to default it (but not force it) in the docs theme. and I'm not sure that's possible given the observed behavior, but I don't know hardly anything about sphinx | 21:57 |
clarkb | ya I know little of it either. but was looking at a separate sphinx pdf latex thing earlier today | 21:58 |
*** slaweq has quit IRC | 22:02 | |
melwitt | I see. afaict when the sphinx process starts, it'll pick up settings in conf.py in the dir it's pointed at else it will use the default, then by the time it gets to the extensions, latex_engine already has a value | 22:06 |
melwitt | I don't see a way to intervene in that, if you want to only set something if it's not been set via conf.py (which is what was desired in the fix) | 22:07 |
melwitt | (where "you" == sphinx extension) | 22:10 |
*** slaweq has joined #openstack-infra | 22:19 | |
clarkb | interesting I was asking AJaeger about that because when I was debugging my thing I assumed pdflatex was used since conf.py didn't override the default | 22:20 |
clarkb | but AJaeger said the theme overrides it | 22:21 |
melwitt | the theme used to override it until version 2.1.0 when the override was removed | 22:21 |
melwitt | but that broke nova docs jobs and probably other docs jobs, so they did a patch to try to set it if not set https://review.opendev.org/#/c/727992/1/openstackdocstheme/ext.py and released 2.1.1 and blacklisted 2.1.0 | 22:23 |
melwitt | but I found that xelatex is still not being used which implies that pdflatex is defaulted by sphinx before the extension code is reached | 22:23 |
clarkb | got it | 22:24 |
*** slaweq has quit IRC | 22:24 | |
melwitt | and I don't see a way to do what is wanted, set it only if not set. a unilateral override would work, that was what it did prior to 2.1.0. but the goal was they were trying to allow projects to set latex_engine in their conf.py if they wanted to and not have the theme wipe it out | 22:27 |
melwitt | if you see 'pdflatex' you can't tell if that was defaulted or if the project conf.py chose it | 22:28 |
melwitt | (afaict, don't know much about sphinx) | 22:29 |
*** slaweq has joined #openstack-infra | 22:29 | |
*** slaweq has quit IRC | 22:33 | |
*** mattw4 has joined #openstack-infra | 22:35 | |
*** tkajinam has joined #openstack-infra | 22:58 | |
*** ociuhandu has joined #openstack-infra | 23:02 | |
*** mattw4 has quit IRC | 23:03 | |
*** tosky has quit IRC | 23:05 | |
*** ociuhandu has quit IRC | 23:07 | |
*** matt_kosut has joined #openstack-infra | 23:29 | |
*** jamesmcarthur has joined #openstack-infra | 23:29 | |
*** matt_kosut has quit IRC | 23:34 | |
*** jamesmcarthur has quit IRC | 23:39 | |
*** jamesmcarthur has joined #openstack-infra | 23:44 | |
*** jamesmcarthur has quit IRC | 23:46 | |
openstackgerrit | Ian Wienand proposed openstack/project-config master: Switch vexxhost mirrors to opendev.org https://review.opendev.org/728310 | 23:50 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!