Wednesday, 2020-06-17

*** gyee has quit IRC00:01
fungii don't expect ensure-pip to influence the virtualenv provided by ensure-virtualenv at all, unless we use the pip provided by ensure-pip in ensure-virtualenv to install virtualenv from pypi00:02
ianwfungi : is that true on ubuntu using packages though, where the two may not be abstracted?00:06
ianw(virtualenv abstracted from the system pip)00:06
ianwbecause i guess, either by design or bug, they're not00:06
fungican you elaborate?00:07
ianwwell what we're seeing is that the packaged virtualenv on xenial can not create a virtualenv with the packaged pip on xenial in the opendev.org mirror environment right?00:08
fungithe ubuntu packaging provides basically two copies of pip: one executable/importable normally for use from the system context, and one bundled as a wheel for virtualenv and venv to bootstrap new environments with00:08
*** artom has quit IRC00:08
fungiit provides the former from the python-pip package and the latter from the python-pip-whl package00:08
ianwsure, but both of them are built from the same source package00:09
fungicorrect00:09
fungibut they can be installed independently00:09
fungithe python-virtualenv package uses and depends on the python-pip-whl package, not the python-pip package00:09
ianwok, sure, but ... i don't think that really helps does it.  you're saying install python-pip-whl v9 with "ensure-virtualenv" maybe?00:10
clarkbya the confusion here is fungi is saying the wheels are not a system package or it was implied earlier anyway00:10
fungiso our ensure-pip role installs python-pip, our ensure-virtualenv role installs (by way of dependency) the python-pip-whl package00:10
clarkbreality is they are both system packages with the same underlying problem00:10
fungiupgrading the pip provided by the ensure-pip role doesn't upgrade the pip wheel being used by virtualenv00:10
clarkbwhat ianw and I meant by system pip is "whatever it is that virtualenv uses to isntall pkg_resources comes from the distro"00:11
ianwfungi: ahh, but i think it does.  it pulls in the python-pip-whl package00:11
* fungi double-checks00:11
fungioh, yep00:11
fungihttps://packages.ubuntu.com/xenial/python-pip says it also depends on python-pip-whl00:12
fungiwith a versioned dependency00:12
fungii expect that's to make ensure-pip happy00:12
fungisince https://packages.ubuntu.com/xenial/all/python-pip/filelist says that python-pip directly provides the pip package modules00:12
fungiso yes, you'll indirectly get a newer python-pip-whl when upgrading python-pip, due to versioned dependencies in python-pip for python-pip-whl00:13
ianwok, i think we're in furious agreement :)00:14
fungithough installing python-pip just to upgrade the version of python-pip-whl for python-virtualenv seems unnecessary, you could just upgrade python-pip-whl and that wouldn't leave you with a pip executable in the path00:15
fungiand also wouldn't conflict with a separate install of pip from pypi or something00:15
fungipython-virtualenv also has a versioned dep on python-pip-whl, but it's >= so allows you to upgrade without being lock-step00:16
ianwif xenial were current i'd probably agree on some sort of workaround like that; but i feel like the most likely case of things right now is that having the pip binary as well probably isn't that bad00:16
clarkbya having working pip is good too00:18
clarkbthis same issue exists in both places00:19
clarkband we want it working in both places00:19
fungiyeah, if it's only on xenial then i find it hard to care too much about correctness at this stage00:20
openstackgerritIan Wienand proposed zuul/zuul-jobs master: ensure-virtualenv: call ensure-pip for Xenial  https://review.opendev.org/73606700:23
ianwfungi / clarkb: ^ i think that is it, in summary00:23
*** stevebaker has joined #openstack-infra00:31
*** armax has quit IRC00:33
fungiit's got a lot of build failures00:33
*** yamamoto has quit IRC00:35
*** yamamoto has joined #openstack-infra00:35
ianw- typo i think00:38
openstackgerritIan Wienand proposed zuul/zuul-jobs master: ensure-virtualenv: call ensure-pip for Xenial  https://review.opendev.org/73606700:38
openstackgerritIan Wienand proposed zuul/zuul-jobs master: ensure-pip: remove Xenial venv workaround  https://review.opendev.org/73606800:38
ianwoh, centos-7 is unhappy00:41
ianwi think we need to enable epel around the install00:42
*** tetsuro has joined #openstack-infra00:42
openstackgerritIan Wienand proposed zuul/zuul-jobs master: ensure-virtualenv: call ensure-pip for Xenial  https://review.opendev.org/73606700:53
openstackgerritIan Wienand proposed zuul/zuul-jobs master: ensure-pip: remove Xenial venv workaround  https://review.opendev.org/73606800:53
openstackgerritIan Wienand proposed zuul/zuul-jobs master: ensure-pip: install from EPEL for Python 2  https://review.opendev.org/73607000:53
ianwclarkb/fungi: ^ sigh, i think that needs to stack under it.  i think testing missed the python2 path on centos7 :/00:53
fungiaha00:54
*** Goneri has joined #openstack-infra00:54
ianwdon't we love dealing with centos7 and xenial issues :)00:54
fungii can think of things i love slightly more00:55
*** matt_kosut has joined #openstack-infra01:32
*** matt_kosut has quit IRC01:37
*** stevebaker has quit IRC01:38
openstackgerritIan Wienand proposed zuul/zuul-jobs master: Remove the -plain job variants  https://review.opendev.org/73577401:48
*** Goneri has quit IRC01:48
*** armax has joined #openstack-infra01:52
*** rosmaita has joined #openstack-infra02:01
*** ricolin has joined #openstack-infra02:01
*** Lucas_Gray has quit IRC02:12
*** lbragstad has quit IRC02:31
*** apetrich has quit IRC02:42
*** psachin has joined #openstack-infra02:48
*** rcernin has quit IRC02:49
*** stevebaker has joined #openstack-infra02:51
*** rcernin has joined #openstack-infra02:54
*** rcernin has quit IRC03:08
*** eharney has quit IRC03:30
*** psachin has quit IRC03:31
*** psachin has joined #openstack-infra03:32
*** armax has quit IRC03:40
*** rcernin has joined #openstack-infra03:45
*** rcernin has quit IRC03:45
*** rcernin has joined #openstack-infra03:50
*** eharney has joined #openstack-infra03:52
*** ysandeep|away is now known as ysandeep03:55
*** ykarel|away is now known as ykarel04:08
*** yamamoto has quit IRC04:19
*** markvoelker has joined #openstack-infra04:27
*** evrardjp has quit IRC04:33
*** markvoelker has quit IRC04:33
*** evrardjp has joined #openstack-infra04:33
*** yamamoto has joined #openstack-infra04:35
openstackgerritMerged zuul/zuul-jobs master: Remove the -plain job variants  https://review.opendev.org/73577404:48
openstackgerritMerged zuul/zuul-jobs master: ensure-pip: install from EPEL for Python 2  https://review.opendev.org/73607004:53
openstackgerritMerged zuul/zuul-jobs master: ensure-virtualenv: call ensure-pip for Xenial  https://review.opendev.org/73606704:53
*** diablo_rojo has quit IRC04:53
*** factor__ has joined #openstack-infra05:19
*** icarusfactor has quit IRC05:22
*** threestrands has joined #openstack-infra05:27
*** threestrands has quit IRC05:33
*** udesale has joined #openstack-infra05:33
*** matt_kosut has joined #openstack-infra05:34
*** matt_kosut has quit IRC05:38
*** lmiccini has joined #openstack-infra05:40
openstackgerritAndreas Jaeger proposed openstack/openstack-zuul-jobs master: Ensure pip and tox are installed for announce-release  https://review.opendev.org/73604305:52
AJaegerianw: I think that's better, can you confirm, please? ^05:54
openstackgerritIan Wienand proposed openstack/project-config master: Ensure pip is installed for propose-update-constraints  https://review.opendev.org/73603205:56
openstackgerritIan Wienand proposed openstack/project-config master: Ensure pip is installed for propose-update-constraints  https://review.opendev.org/73603206:03
*** matt_kosut has joined #openstack-infra06:05
ianwAJaeger: thanks, yep 736043 seems to call out to a shell script so we don't have to keep digging and switch install to venv etc, leave it be06:06
openstackgerritMerged openstack/openstack-zuul-jobs master: Ensure pip and tox are installed for announce-release  https://review.opendev.org/73604306:18
openstackgerritMerged openstack/project-config master: Turn -plain nodes down to min-ready 0  https://review.opendev.org/73577706:32
openstackgerritMerged zuul/zuul-jobs master: ensure-pip: remove Xenial venv workaround  https://review.opendev.org/73606806:37
openstackgerritMerged openstack/project-config master: Replace build-sphinx-docs jobs  https://review.opendev.org/73601606:39
openstackgerritMerged openstack/openstack-zuul-jobs master: Update echo for pdf-docs to match recent change  https://review.opendev.org/73581906:41
openstackgerritMerged openstack/openstack-zuul-jobs master: Only run build-openstack-sphinx-docs on stable branches  https://review.opendev.org/73593706:41
openstackgerritDmitriy Rabotyagov (noonedeadpunk) proposed openstack/project-config master: Add vexxhost/ansible-role-frrouting  https://review.opendev.org/73611506:55
*** rpittau|afk is now known as rpittau06:56
*** slaweq has joined #openstack-infra07:00
*** jcapitao has joined #openstack-infra07:01
*** amoralej|off is now known as amoralej07:07
*** apetrich has joined #openstack-infra07:11
*** ccamacho has joined #openstack-infra07:12
*** psachin has quit IRC07:15
*** psachin has joined #openstack-infra07:17
*** pkopec has joined #openstack-infra07:23
*** dklyle has quit IRC07:25
*** tosky has joined #openstack-infra07:36
*** nightmare_unreal has joined #openstack-infra07:41
*** alejandrosg has quit IRC07:45
*** alejandrosg has joined #openstack-infra07:46
*** rcernin has quit IRC07:47
openstackgerritMerged openstack/project-config master: Ensure pip is installed for propose-update-constraints  https://review.opendev.org/73603207:53
*** jpena|off is now known as jpena07:55
*** ralonsoh has joined #openstack-infra07:57
*** pkopec has quit IRC07:58
*** pkopec has joined #openstack-infra08:02
*** ykarel is now known as ykarel|lunch08:13
*** ramishra has quit IRC08:17
*** gfidente|afk is now known as gfidente08:18
*** Lucas_Gray has joined #openstack-infra08:24
*** rakhmerov has joined #openstack-infra08:35
*** Lucas_Gray has quit IRC08:35
*** Lucas_Gray has joined #openstack-infra08:36
rakhmerovAJaeger: hi, you recently landed a patch in Mistral after the "uwsgi" issue was somehow fixed in devstach. You said you were waiting for https://review.opendev.org/#/c/735494/ but I see it's still not merged08:40
rakhmerovnow we're trying to land something into stable/queens (bindep.txt) and facing the same issue08:40
rakhmerovhttps://review.opendev.org/#/c/736129/08:41
rakhmerovcan you give any hints on how to fix it in queens?08:41
AJaegerrakhmerov: https://review.opendev.org/735523 fixed it - best discuss further in #openstack-qa08:42
AJaegerrakhmerov: AFAIK stable branches are still in progress08:43
rakhmerovok08:43
rakhmerovthanks08:43
*** priteau has joined #openstack-infra08:50
*** ociuhandu has quit IRC08:51
*** tkajinam has quit IRC08:57
*** ykarel|lunch is now known as ykarel09:03
*** apetrich has quit IRC09:17
*** apetrich has joined #openstack-infra09:26
*** ysandeep is now known as ysandeep|afk09:26
openstackgerritDmitriy Rabotyagov (noonedeadpunk) proposed openstack/project-config master: Add openstack-ansible-os_adjutant repo  https://review.opendev.org/73614209:30
openstackgerritDmitriy Rabotyagov (noonedeadpunk) proposed openstack/project-config master: Add openstack-ansible-os_adjutant repo  https://review.opendev.org/73614209:35
*** ramishra has joined #openstack-infra09:37
openstackgerritDmitriy Rabotyagov (noonedeadpunk) proposed openstack/project-config master: Add os_adjutant zuul project  https://review.opendev.org/73614509:40
*** gnuoy has quit IRC09:54
*** ysandeep|afk is now known as ysandeep09:54
*** yamamoto has quit IRC10:01
*** yamamoto has joined #openstack-infra10:02
*** yamamoto has quit IRC10:02
openstackgerritDmitriy Rabotyagov (noonedeadpunk) proposed openstack/project-config master: Add openstack-ansible-os_adjutant repo  https://review.opendev.org/73614210:05
*** jcapitao is now known as jcapitao_lunch10:15
*** derekh has joined #openstack-infra10:17
*** rpittau is now known as rpittau|bbl10:18
noonedeadpunkAJaeger: can you help us a bit? We've faced with zuul error here https://review.opendev.org/723597 but really don't see what's wrong with patch... Can you take a brief look at it?10:24
noonedeadpunkdisregard10:25
noonedeadpunkI found it10:25
noonedeadpunkby the way - there should be a hold for https://review.opendev.org/#/c/689629/ ?10:28
noonedeadpunkbut I guess we have bunch of not ready roles for focal (in terms of non-core ones)10:31
*** psachin has quit IRC10:31
*** yamamoto has joined #openstack-infra10:38
*** yamamoto has quit IRC10:39
*** yamamoto has joined #openstack-infra10:40
fricklernoonedeadpunk: yes, there's a held node, if you tell me your SSH key I can give you access10:41
noonedeadpunkfrickler: sure https://launchpad.net/~noonedeadpunk/+sshkeys10:42
noonedeadpunk(regarding focal - message was posted int wrong channel, sorry)10:43
fricklernoonedeadpunk: root@104.239.168.12610:45
noonedeadpunkthanks, it works10:45
frickleriurygregory: infra-root: another ansible 2.9 failure: https://zuul.opendev.org/t/openstack/build/6195f1eada7c413495d515800aff1b7810:47
iurygregoryfrickler, this one we have a fix10:48
iurygregoryhttps://review.opendev.org/#/c/736124/10:48
*** Lucas_Gray has quit IRC10:49
frickleriurygregory: ah, great, thx10:49
iurygregorynp we are also backporting already to unblock stable/ussuri in ironic10:49
*** yamamoto has quit IRC10:50
*** yamamoto has joined #openstack-infra11:00
*** derekh has quit IRC11:00
*** derekh has joined #openstack-infra11:00
*** psachin has joined #openstack-infra11:03
*** ociuhandu has joined #openstack-infra11:12
*** artom has joined #openstack-infra11:20
*** jpena is now known as jpena|lunch11:30
*** sshnaidm_ has joined #openstack-infra11:32
*** sshnaidm has quit IRC11:33
*** sshnaidm_ is now known as sshnaidm11:35
*** rfolco|rover has joined #openstack-infra11:36
*** tetsuro_ has joined #openstack-infra11:42
*** tetsuro has quit IRC11:46
*** tetsuro_ has quit IRC11:51
*** tosky has quit IRC11:56
*** tetsuro has joined #openstack-infra11:57
openstackgerritSlawek Kaplonski proposed openstack/project-config master: [Grafana] Update label of neutron-functional-with-uwsgi job  https://review.opendev.org/73616811:58
*** psachin has quit IRC11:58
*** tosky has joined #openstack-infra11:59
*** psachin has joined #openstack-infra11:59
*** Lucas_Gray has joined #openstack-infra12:02
dtantsurhey folks, the test-release-openstack job seems broken: https://zuul.opendev.org/t/openstack/build/d9ebbf199220436a9076600d6f9ce874/log/job-output.txt#44512:02
dtantsuriurygregory: I think stable/train needs this patch too12:03
iurygregorydtantsur, yeah12:03
dtantsur"msg": "Missing sudo password"12:04
dtantsurthis is what breaks test-release-openstack, apparently?12:04
*** rpittau|bbl is now known as rpittau12:06
noonedeadpunkok, so we see pretty weird behaviour in centos ci image... which partially caused with this.. http://paste.openstack.org/show/794879/12:08
noonedeadpunkAnd we don't see such behaviour in real centos images...12:08
noonedeadpunkmaybe anyone can give some hint where to look for the thing?12:08
*** amoralej is now known as amoralej|lunch12:09
AJaegerdtantsur: see my comment on https://review.opendev.org/#/c/73600112:10
AJaegerdtantsur: thanks for reporting12:10
*** jcapitao_lunch is now known as jcapitao12:10
dtantsurah, cool, thanks for the link12:10
AJaegermordred: that might be easier to test than the post job ^12:11
openstackgerritMerged zuul/zuul-jobs master: Record artifact checksums and signatures to stdout  https://review.opendev.org/73592912:15
*** Lucas_Gray has quit IRC12:16
*** hashar has joined #openstack-infra12:18
noonedeadpunkoh, /openstack is a separate mount point12:18
*** Lucas_Gray has joined #openstack-infra12:19
noonedeadpunk`/dev/xvde1 on /openstack type ext4 (rw,noatime,seclabel,nobarrier,data=writeback)`12:19
noonedeadpunkI believe it's not we who do such preparation12:20
AJaegernoonedeadpunk: I'm not aware that we do anything like this in our images12:21
noonedeadpunkhttp://paste.openstack.org/show/794885/12:22
noonedeadpunkI'm pretty sure we can't "fake" that with ansible....12:22
noonedeadpunkhowever... we can pickup drive and format it... (and use afterwards)12:23
noonedeadpunkBut I thought that ususally vms have signle drive?12:23
*** Wryhder has joined #openstack-infra12:23
*** Lucas_Gray has quit IRC12:24
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: Revert "Make sure wheel is installed for python releases"  https://review.opendev.org/73618312:25
elodhi, it seems oslo.messaging uses tox before running ensure-tox (openstack-tox-py27 @ rocky, queens): https://zuul.opendev.org/t/openstack/build/cfcd1bebf5614f2db96f221b5369ab4c/log/job-output.txt#408-41112:25
elodany suggestion how to solve it?12:26
noonedeadpunkAJaeger: yeah, I've found that it's not always the cse, thanks12:27
*** Wryhder has quit IRC12:28
*** Lucas_Gray has joined #openstack-infra12:32
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: Avoid become on build-python-release  https://review.opendev.org/73618512:32
*** eolivare has joined #openstack-infra12:33
*** jpena|lunch is now known as jpena12:37
*** lbragstad has joined #openstack-infra12:39
*** Tengu has quit IRC12:39
*** Tengu has joined #openstack-infra12:40
funginoonedeadpunk: per the disk bullet at https://docs.opendev.org/opendev/infra-manual/latest/testing.html "There is at least 80GB of disk available. This disk may not all be exposed in a single filesystem partition and so not all mounted at /. Any additional disk can be partitioned, formatted and mounted by the root user..."12:43
noonedeadpunkYeah, I guess we didn't noticed that previously as really have preparation step, which just work in weird way for centos812:44
noonedeadpunk(ie it's mounted with wrong options or smth)12:44
fungiyou're mostly gong to see that on rackspace nodes, because there we get something like 20gb rootfs and 100gb ephemeral disk12:45
fungimaybe ovh too, i really can't recall12:45
*** slaweq_ has joined #openstack-infra12:48
*** slaweq has quit IRC12:48
*** mtreinish has joined #openstack-infra12:50
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: WIP: Avoid become on build-python-release  https://review.opendev.org/73618512:51
fungibut we don't partition/format the additional volume at boot, we leave it up to jobs to do that, for example: https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/roles/configure-swap/tasks/ephemeral.yaml12:52
funginoonedeadpunk: ^12:53
noonedeadpunkfungi: yeah, I already found that we also do partitioning, thanks)12:53
fungiokay, cool. let us know if you need help digging into anything there12:55
*** slaweq_ is now known as slaweq13:03
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: WIP: Avoid become on build-python-release  https://review.opendev.org/73618513:06
*** amoralej|lunch is now known as amoralej13:07
openstackgerritMerged zuul/zuul-jobs master: Revert "Make sure wheel is installed for python releases"  https://review.opendev.org/73618313:10
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: WIP: Avoid become on build-python-release  https://review.opendev.org/73618513:12
*** tetsuro has quit IRC13:15
*** udesale_ has joined #openstack-infra13:26
*** udesale has quit IRC13:28
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: WIP: Avoid become on build-python-release  https://review.opendev.org/73618513:35
*** rpittau is now known as rpittau|brb13:39
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: WIP: Avoid become on build-python-release  https://review.opendev.org/73618513:40
*** priteau has quit IRC13:40
*** ricolin has quit IRC13:40
*** rlandy is now known as rlandy|mtg13:41
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: WIP: Avoid become on build-python-release  https://review.opendev.org/73618513:44
*** kberger_ has joined #openstack-infra13:45
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: WIP: Avoid become on build-python-release  https://review.opendev.org/73618513:45
*** kberger_ has quit IRC13:46
*** kberger_ has joined #openstack-infra13:46
*** KeithMnemonic has quit IRC13:49
*** rpittau|brb is now known as rpittau13:53
*** lpetrut has joined #openstack-infra13:56
*** priteau has joined #openstack-infra13:56
*** yamamoto has quit IRC14:06
*** ysandeep is now known as ysandeep|brb14:07
openstackgerritAndreas Jaeger proposed openstack/project-config master: Fix missing repos for zuul tenant  https://review.opendev.org/73622614:08
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: WIP: Avoid become on build-python-release  https://review.opendev.org/73618514:09
AJaegermnaser: as PTL, please also review https://review.opendev.org/73614214:12
noonedeadpunkAJaeger: oh, and how to import existing stuff to the new repo? with upstream?14:12
openstackgerritGhanshyam Mann proposed openstack/openstack-zuul-jobs master: Revert "Work around uwsgi breakage"  https://review.opendev.org/73623014:12
mnasernoonedeadpunk: yeah you have to upload it somewhere like github and then we import it into gerrit14:12
noonedeadpunkas I have content for https://review.opendev.org/#/c/736142/14:12
mnasernoonedeadpunk: so throw it on github and update upstream (just make sure no zuul config anywhere in it)14:13
noonedeadpunkhttps://github.com/elastx/openstack-ansible-os_adjutant14:13
*** gshippey_ has joined #openstack-infra14:13
mnasernoonedeadpunk: yeah in that case it's best to update the upstream :)14:13
AJaegernoonedeadpunk: all documented in the Creator's guide, see https://docs.opendev.org/opendev/infra-manual/latest/creators.html14:14
mnaserhttps://docs.opendev.org/opendev/infra-manual/latest/creators.html#add-the-project-to-the-master-projects-list #314:14
noonedeadpunkmnaser: I'm just not sure - wouldn't it mean that it would sync back to upstream all new patches?14:15
mnasernoonedeadpunk: nope -- just a one time import14:15
mnaserso essentially forking it into opendev14:15
noonedeadpunkah, ok. that's why I didn't add at first place14:15
mnasernoonedeadpunk: the only concern is that repo has a zuul.d folder. i think it _may_ contain valid config but we may disallow that, we may ask to remove that first.  AJaeger might know more :X14:15
mnaseri remember we have a "dont import if there's zuul config" rule14:16
noonedeadpunkI'm pretty sure zuul.d is not alid there...14:16
noonedeadpunk*valid14:16
mnaseryeah maybe we'll have to do a PR then14:17
noonedeadpunklet me set -W then...14:17
openstackgerritDmitriy Rabotyagov (noonedeadpunk) proposed openstack/project-config master: Add openstack-ansible-os_adjutant repo  https://review.opendev.org/73614214:18
noonedeadpunkbtw, will it clone branches as well?14:19
noonedeadpunk(I guess yes)14:19
AJaegermnaser: yes, we have a check that will -1 if t here's a zuul.d folder. noonedeadpunk, remove it and then recheck. Also, it clones *all* branches. If you don't want them, delete - or create a fork without them and import that one...14:22
openstackgerritMerged openstack/project-config master: Add vexxhost/ansible-role-frrouting  https://review.opendev.org/73611514:23
mnaserAJaeger: i think that might be good for us to document in there14:23
mnaserit seems to just be tribal info not in the infra-manual14:23
noonedeadpunkMaybe it's easier just to push content afterwards?14:23
mnasernoonedeadpunk: if we push content afterwards, then it will squash and lose all history14:24
noonedeadpunklike trough gerrit14:24
AJaegermnaser: want to sent a patch for opendev/infra-manual?14:24
noonedeadpunkfolks don't care about it14:24
mnaseryou'd have to make a ton of gerrit reviews :p14:24
mnaseri can throw something up quickly14:24
mnaserif they dont care about history, you can squash locally and push it all in 1 patch after.  it's your choice14:24
noonedeadpunkLike I had a chat with them and they don't mind if we just drop all history14:24
openstackgerritMerged openstack/project-config master: Add noop-jobs for neutron-fwaas and neutron-fwaas-dashboard projects  https://review.opendev.org/73580714:25
funginoonedeadpunk: mnaser: AJaeger: we import all branches *and* tags too14:29
fungiso if there are tags you don't want you should also delete those14:30
fungiand you don't have to use github, it's just an example. i scp a local git repo to a webserver and point at the url. anything which can be publicly cloned from will work fine for the import process14:30
AJaegerfungi: let's document in 73623814:32
*** yamamoto has joined #openstack-infra14:34
*** yamamoto has quit IRC14:34
*** yamamoto has joined #openstack-infra14:34
*** psachin has quit IRC14:34
openstackgerritDmitriy Rabotyagov (noonedeadpunk) proposed openstack/project-config master: Add openstack-ansible-os_adjutant repo  https://review.opendev.org/73614214:36
*** rlandy|mtg is now known as rlandy14:39
*** yamamoto has quit IRC14:41
*** dabukalam is now known as danny14:43
*** danny is now known as dabukalam14:43
*** dklyle has joined #openstack-infra14:44
clarkbelod: did you manage to get that tracked down?14:49
AJaegerfungi, could you put the infra-manual change 736238 on your review queue, please?14:49
clarkbelod: that looks like a bug either in the job where test-setup runs before ensure-tox or if that is necessary, a bug in the test setup assuming tox is there14:49
clarkbelod: I don't know enough yet to say which thing should be fixed but my hunch is we should run test-setup after ensure-tox14:50
fungiAJaeger: sure14:51
fungithanks for the heads up14:51
AJaegerelod, btw. that test-setup.sh is completely redundant and could be removed.14:52
elodclarkb: there's no bug in the job i think, but oslo-messaging have 'tox -e bindep' in their tools/test-setup.sh14:53
elodAJaeger: hmmm. is it unnecessary in stable/rocky, too?14:53
AJaegerelod: everywhere...14:53
fungii guess it's there to remind devs if they're missing packages?14:53
AJaegerelod: https://review.opendev.org/73624814:53
AJaegerfungi: it basically calls bindep...14:54
elodAJaeger: good to know14:54
fungiyeah, i mean, the alternative is to say "run `tox -e bindep`" in the readme14:55
elodAJaeger: that looks good then! Thanks! I was trying to figure out where to put ensure-tox or how to move bindep check, but then your fix is the simplest :)14:55
AJaegerelod: still, we could change the order ...14:55
*** lmiccini has quit IRC14:56
clarkbAJaeger: elod the ordering there could probably be changed14:56
clarkbsince as much setup before test-setup as is safe is likely a good thing14:56
clarkbhowever tox inherits from unittests and that is what sets the order14:56
clarkbchanging that would be difficult/weird14:56
clarkbso we may have to live with the ordering14:57
AJaegermnaser: https://review.opendev.org/#/c/736142 is fine, I'll +2 once the PTL (you ;) has reviewed.14:57
*** Goneri has joined #openstack-infra14:57
mnaserAJaeger: +214:58
clarkbI'm beginning to wonder if we shouldn't put an etherpad together with some rough explanation of various classes of issue and related fixes14:58
clarkbthough I've just sat down and not sure how prevalent problems continue to be14:58
AJaegermnaser: +3 ;)14:58
AJaegerclarkb: if we create an etherpad, there won't be many - if not,...14:59
clarkbwe have the ansible 2.9 issues, the pip change issues, and the large cleanup for grenade and devstack related to uwsgi and disabling jobs14:59
clarkblooks like the devstack and grenade cleanup is starting with https://review.opendev.org/#/c/736230/1 so we must be looking better there15:00
fungiand there's an outstanding fix needed to install wheel before building python packages, which is the last known remaining blocker to get openstack releases going again15:01
fungiin progress at https://review.opendev.org/73590515:02
clarkbfungi: wasn't that change reverted?15:03
clarkbAJaeger: mnaser: why is it important that there is no zuul config in the imported project? simply because it is unlikely to work and we want to avoid having first commit be "cleanup zuul config" ?15:03
fungiclarkb: https://review.opendev.org/736185 sorry15:03
mnaserclarkb: if i remember right, a while back someone managed to import a bad zuul config that caused issues in zuul (because it wasn't gated)15:04
*** ysandeep|brb is now known as ysandeep15:04
fungiclarkb: and yes, the original was reverted because it didn't work, and worse broke the job for folks who did still have wheel preinstalled15:04
mnaseri think maybe times were different and zuul's ability to deal with broken configs wasn't so strong.  i briefly remember it15:04
fungimnaser: zuul can still get pretty confused if we install additional configuration which defines some of the same jobs and other objects whose names it assumes should be globally unique15:05
clarkbya I guess my concern with the documentation is that its not strictly true. But for guidance to people importing projects it is probably the best advice anyway15:06
fungifor example if we import a new repository which includes jobs with the same names as ones relied on by lots of our projects, that could get disruptive easily i think15:06
clarkbbetter to build up zuul config with it being properly tested than import and hope it works15:06
openstackgerritMerged openstack/openstack-zuul-jobs master: Revert "Work around uwsgi breakage"  https://review.opendev.org/73623015:08
fungiwe might be able to pre-test imports if we separated the creation and import steps15:08
fungithough that would probably still be really complicated to pull off15:09
AJaegerclarkb: we have a test in project-config that gives a -1 if zuul files get imported. We added this to protect us from really bad configs, we wanted them to come in via gerrit review15:09
fungilike start with an empty project, then have it propose a squashed change of each branch tip, and only import if they all passed their jobs or something15:10
clarkbAJaeger: cool. I did approve the change already fwiw. Just awnted to make sure i understood the guidance there15:10
AJaegerclarkb: thx15:11
openstackgerritMerged openstack/project-config master: Add openstack-ansible-os_adjutant repo  https://review.opendev.org/73614215:12
*** Lucas_Gray has quit IRC15:12
clarkbnoonedeadpunk: did you get your held node afterall?15:13
clarkbseems like there was discussion of rax disk partitioning, I assume that is related?15:13
fungiyes, possible he's done with the held node now15:17
*** sshnaidm is now known as sshnaidm|bbl15:17
funginoonedeadpunk: do let us know once you finish studying that node so we can release it back into the wild15:17
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: WIP: Avoid become on build-python-release  https://review.opendev.org/73618515:19
ttxquick question regarding jeepyb -- how often is the manage_projects command run?15:20
clarkbttx: when we land changes to projects.yaml iirc15:21
clarkbttx: I'm not sure if it is part of periodic updates still /me checks15:21
ttxand then it updates all repos? Or just the changed one?15:21
noonedeadpunkfungi: I will finish today, sorry, got some urgent thing to finish...15:22
ttxclarkb: Trying to see how much I need to create github repositories for the mirroring work15:22
clarkbttx: it will apply to all repos. Also just confirmed it doesn't seem to be periodic but runs when a few other things change like our inventory and gitea roles and so on15:22
AJaegerso, does ttx need to do manual work for https://review.opendev.org/#/c/736145/ ?15:22
AJaegerOr could we just merge that?15:22
clarkbttx: but the major change that should drive it is updates to the projects.yaml input to the command15:23
openstackgerritAndreas Jaeger proposed openstack/project-config master: Add os_adjutant zuul project  https://review.opendev.org/73614515:23
funginoonedeadpunk: no worries, take all the time you need15:23
ttxok15:23
noonedeadpunkclarkb: yeah, I got it, thanks :)15:23
clarkbAJaeger: ttx that change is a zuul config update? shouldn't be related to manage projects at all?15:23
AJaegerclarkb: it adds the github mirroring template for a repo that was just created a few minutes ago15:24
clarkbhttps://review.opendev.org/#/c/736142/5/gerrit/projects.yaml right that is the file that will cause manage projects to run15:24
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Update guideline docs for os specific tasks  https://review.opendev.org/73160615:24
clarkbif you look at zuul status now you can see manage projects has completed successfully15:24
clarkbfor that change15:24
AJaegerclarkb: so, I wonder whether ttx as github admin needs to do anything or whether we can merge 736145 now and it will mirror fine15:24
* ttx checks if the corresponding git repo was created on github15:25
fungithe mirror job will just report failures until the repo is created15:25
fungibut should be okay to add it15:25
ttxAJaeger: yeah, that's what I was trying to check. I assumed I had to create things on the github side15:26
ttxbut now I see no reason why manage_projects would not do it15:27
AJaegerttx, I wanted to double check whether I needed to wait on you doing it ;)15:27
ttx(just realized it was still running as it overwrote my customized description)15:27
AJaegerttx, I'm not sure whether we have documented adding the openstack template and who's job that is - we might have merged some repos without adding it. Could you double check, please?15:29
ttxon it15:30
AJaegerthanks!15:30
ttxclarkb: so the manage_projects ran for that change, apparently: https://zuul.openstack.org/build/e74357ee0afc46ebb2df854cb0a80a67/log/manage-projects.yaml.log#10015:32
fungithe main reason i could see for not doing it in manage-projects is we're trying to move more of that to zuul jobs, and it would be possible for a zuul job provided with the correct secret to call the gh api to create a repository15:33
ttxbut then I can't find the corresponding git repo on github side15:33
ttxcould be that it's invisible until pushed to, checking15:33
ttxhhm, no15:34
fungioh, i thought we had stopped creating github repos with manage-projects and you were talking about reenabling it15:34
ttxwhich is consistent with recent repos I had to create.15:34
ttxfungi: but it does overwrite descriptions I set, so it's certainly running15:34
ttxmaybe it just silently fails to create new repos15:35
fungiahh, okay, so i guess we haven't yet managed to rip the github interactions out of our tools like we had discussed15:35
clarkbya itmay be failing to createbut succeding on updates15:35
clarkbwe can disable it entirely with a config flag iirc15:36
fungiright, i was thinking we had already disabled it, but i suppose not15:36
ttxfungi: also it still closes pull requests, which is good as it makes my corresponding work to do that less urgent :)15:36
*** hashar has quit IRC15:38
openstackgerritMerged zuul/zuul-jobs master: Update guideline docs for os specific tasks  https://review.opendev.org/73160615:40
ttxclarkb: yes, has-github15:41
ttxlooking into that15:42
ttxmeh that should have done it https://opendev.org/opendev/system-config/src/branch/master/playbooks/roles/gerrit/templates/projects.ini.j215:44
fungiwe can presumably manually rerun m-p for that one repo with --verbose and see if it produces any obvious errors or doesn't log actions we think it should be taking15:48
ttxfungi: looking at the code it should definitely not run any of that repo creation, which is consistent with what we observe15:49
ttxso maybe I just dreamed that it overwrites my descriptions15:50
*** udesale_ has quit IRC15:53
ttxthough it certainly still closes pull requests...  and I'm not sure why it would15:53
fungihas-pull-requests might be evaluated separately?15:57
ttxthe PR-closer evaluates use-github first and shortcircuits the rest15:58
*** gyee has joined #openstack-infra15:58
ttxhttps://opendev.org/opendev/jeepyb/src/branch/master/jeepyb/cmd/close_pull_requests.py#L10715:59
fungihuh, there goes my theory then15:59
ttxyes and it was still closing PRs very recently. Maybe that job is still running off some other code15:59
* ttx is down the rabbit hole16:00
ttxnot sure where close_pull_requests is actually run from16:01
fungithe gerrit container on review.o.o has jeepyb==0.0.1.dev469  # git sha ab498db16:02
ttxnot much showing in http://codesearch.openstack.org/?q=close_pull&i=nope&files=&repos=16:02
ttxoh well, I'll continue that exploration tomorrow16:04
fungithe setup.cfg for jeepyb says close-pull-requests is an executable wrapper for the jeepyb.cmd.close_pull_requests:main entrypoint16:04
ttxfungi: any idea which job actually calls that?16:05
fungia cronjob installed by puppet: https://opendev.org/opendev/puppet-github/src/branch/master/manifests/init.pp#L88-L9716:06
ttxit still closed PRs two days ago16:06
ttxhah - vs _16:06
fungiyeah, the console script uses -16:06
fungibut - is not viable in a module name16:07
*** armax has joined #openstack-infra16:08
ttxhmm so maybe this one does not see use-github=false. I'll dog from there tomorrow, thanks for the pointer16:09
ttxdig*16:09
fungion review.o.o, `sudo crontab -l -u github` tells me that we do indeed still have this:16:10
fungi*/5 * * * * sleep $((RANDOM\%60+90)) && /usr/local/bin/close-pull-requests16:10
fungimordred: ^ i expect that's something we missed in the containerification of the gerrit server?16:10
fungi(either missed containerizing or missed cleaning up)16:11
fungiit's entirely possible that's working off a stale copy of project data now16:11
*** dtantsur is now known as dtantsur|afk16:12
ttxyeah that would explain it. The idea would be to have an openstack periodic zuul job that would create the missing repos and close pull requests... like once a day16:12
ttxbut not driven by projects.yaml, openstack-specific16:13
mordredfungi: whoops16:15
*** rpittau is now known as rpittau|afk16:17
fungii can easily comment that out and it won't get recreated since we no longer apply the puppet-github module (or indeed any puppet) on that server, but the question remains are there users relying on that and, if so, is that a reason to prioritize a replacement solution (such as the zuul job ttx mentions)16:19
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: Make build-python-release use python3  https://review.opendev.org/73618516:19
clarkbfungi: ttx mordred we get emails for  github PRs and the rate is low16:23
ttxfungi: I think it's fine to remove now. I will quickly add PR-closing to my current github-update script and run it manually until I find time to turn it into a job16:23
clarkbbut openstack likely should have some plan for dealing with those16:23
fungiclarkb: yes, and more than half are accidental git push from openstack contributors who happen to have forked from the gh mirror for $reasons and forgot which workflow they should use16:25
fungiwe see maybe one or two legitimate pr attemps a month for openstack repos, if that16:25
ttxyeah, maybe we should turn those into first-contact entry points.16:27
ttx(the legitimate ones)16:27
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: POC: test build-python-release using python  https://review.opendev.org/73629316:29
*** ykarel is now known as ykarel|away16:33
*** ysandeep is now known as ysandeep|away16:36
*** ociuhandu_ has joined #openstack-infra16:38
*** ociuhandu has quit IRC16:42
fungii agree. treat them similarly to the welcome new contributor reviews16:42
*** ociuhandu_ has quit IRC16:43
fungialso have a better story around accepting their patches and having an established contributor do a `gti am` manually if they'll add signed-off-by in the commit message16:43
fungier, `git am`16:43
*** ociuhandu has joined #openstack-infra16:47
*** ociuhandu has quit IRC16:51
*** amoralej is now known as amoralej|off16:55
openstackgerritMonty Taylor proposed zuul/zuul-jobs master: Ensure wheel exists for build-release-python  https://review.opendev.org/73618516:56
EmilienMAJaeger, mnaser : thank you for all the help with paunch removal16:59
mnaserEmilienM: you're welcome.  hope you've been well :)17:00
EmilienMmnaser: everything is good :-)17:00
*** derekh has quit IRC17:01
*** lpetrut has quit IRC17:02
*** jpena is now known as jpena|off17:06
*** jcapitao has quit IRC17:11
*** kberger_ has quit IRC17:20
*** nightmare_unreal has quit IRC17:24
*** KeithMnemonic has joined #openstack-infra17:25
*** KeithMnemonic has quit IRC17:27
*** KeithMnemonic has joined #openstack-infra17:37
*** KeithMnemonic has quit IRC17:43
smcginnisHey kind infra folks - I did a test release to see if our issues are cleared up, and while things look better than they were, we did hit a failure on announce-release.17:58
smcginnishttps://zuul.opendev.org/t/openstack/build/52cec40de6df4532822aa151f1ca2e4e17:58
fungichecking into that, thanks smcginnis17:58
smcginnisLooks like tox and/or virtualenv are missing, but that *should* have been fixed by https://review.opendev.org/#/c/736043/2/playbooks/release/pre.yaml17:58
smcginnisThe log shows both prior to attempting to send the announcement.17:59
fungiyeah, seems like we need ensure-tox in the pre phase for announce-release18:00
fungiit looks like it tries to use tox to build a virtualenv, so the "Failed to build virtualenv" message is slightly misleading18:00
smcginnisfungi: Do you mean this pre phase: https://review.opendev.org/#/c/736043/2/playbooks/release/pre.yaml18:01
smcginnisOr is there a pre-pre phase?18:01
fungioh, i wonder if it's just needing to use the variable which tells it where tox is installed18:02
*** __ministry1 has joined #openstack-infra18:02
*** __ministry1 has quit IRC18:02
smcginnisWe may need to refactor some things then.18:03
fungior symlink something into $PATH18:03
smcginnisThe playbook calls the tools/announce.sh script in the releases repo.18:03
smcginnisWhich internally calls tox.18:03
fungiclarkb: ^ how have we been handling that in other jobs? do you happen to know?18:03
smcginnisSo yeah, I think we need it added to $PATH18:03
fungii know we discussed symlinks as an option18:03
smcginnisLooking at the script, if it sees it is already in a $VIRTUAL_ENV it won't try to call it.18:04
smcginnisAh, but it does that to have our release-notes cmd installed.18:06
mordredfungi: we set an ansible fact18:06
mordredso other ansible things can reference it18:06
fungimordred: but if you have a shell script referencing it instead, what's our preference for solving that?18:06
mordredI think what we probably want to do is have the playbook that's calling teh release script add the variable to the path for the shell command18:06
smcginnisKinda looks like that's what we need to do.18:06
mordredfungi: we do not have a solution for that - because _complicated_ interactions between non-root use and path setting and shells and ansible18:07
fungiright, i know we had discussed a number of possible options (appending to $PATH, symlinking into somewhere like /usr/local/bin) just couldn't remember if we decided one was better than another18:08
mordredfungi: yeah - unfortiunately we run in to 2 issues18:08
mordredone is that we run these installs as not-root, so we can't put in /usr/local/bin/ scripts18:08
mordredwe _could_ write to ~/.profile or something - but it seems that's not getting read when ansible runs shell commands18:08
openstackgerritMerged openstack/project-config master: Normalize projects.yaml  https://review.opendev.org/73578218:08
mordredso that didn't work out18:09
fungioh, we're installing tox as a non-root user?18:09
mordredyeah18:09
fungigot it18:09
mordredwe do as many of the installs as we can as non-root18:09
mordredso that the jobs also work for people running them in containres that dont' have root18:09
mordredjust to make it extra complex18:09
mordredso what we do is set an ansible fact to cacheable and put in the virtualenv path to the executable18:09
mordred(iirc)18:09
fungiso we're creating the venvs in user-specific locations on the filesystem, not somewhere generally accessible to all users (though if the job only uses one user, i guess that's fine)18:09
mordredthen since it's cacheable it gets picked up in later playbooks18:10
mordredfungi: that's right18:10
fungidefault ~/.profile probably includes ~/bin in $PATH if it exists18:10
mordredI think we may have tried and determined we can't count on that18:10
mordredand/or I think ansible overwrites PATH in the ssh command18:10
fungiyeah, that tends to vary by distro18:10
mordredfungi: tox_executable is the ansible variable containing the path to the tox executable18:11
fungithe .profile addition of ~/bin varies by distro i mean18:11
fungidoes adding tox_executable to $PATH work, or do we need to add basedir(tox_executable) instead?18:11
mordredbasedir18:12
mordredit'll be like tox_venv/bin/tox18:12
mordredfungi: ensure_pip_virtualenv_command is a variable containing the virtualenv command in case that's helpful18:12
fungithat could get tricky, because there are likely to be additional executables in there we don't want to shadow system executables, so i guess we append it18:12
fungirather than prepend18:13
smcginnisIf there's an environment variable our release script can check, we could do that.18:13
fungioh, sure, i mean there's a bunch of ways to tackle it if we alter the script18:14
fungii was just trying to work out what a good solution might be without altering the script18:14
smcginnisIt does seem like an issue that we could hit in other places, but if path of least resistance is to workaround it on our end, we can do that.18:14
smcginnisOr we add these back in the base images. ;)18:15
mordredsmcginnis: :)18:15
fungii guess the reason the script is calling tox is to get the project itself and its runtime deps installed into the venv where it's going to generate the announcement?18:16
smcginnisYep. Looks like there are a couple of local cmds it needs to use to extract and send the announcement details.18:17
mordredfungi: you know ...18:19
mordredmaybe what we should do is add a flag to ensure-tox like "tox_install_globally" or something18:20
fungimordred: so for your suggestion, we'd add a path parameter to https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/playbooks/release/announce.yaml and use a j2 subtitution to pass tox_executable through some filter to get the dirname?18:20
mordredthat people can set in contexts where they know they're running ensure-tox in a having-root crcumstance18:20
fungier, i mean for your earlier suggestion18:20
mordredfungi: and then this job could just set the variable and have the tox in question symlinked to /usr/local/bin18:20
mordredfungi: re: earlier suggestion - yes18:21
fungii guess path manipulation is a common parameter of the command module18:21
mordredcorvus: ^^ scrollback here - what do you think about adding a variable like "tox_install_globally" - or even "ensure_global" that would cause ensure-tox (or ensure roles in general) to add a symlink into /usr/local/bin - not have that run by default, because of the rootless container issue18:22
mordredbut for users who want their jobs to install stuff in places where scripts can use them without having to pass ansible variables to paths of shell comamnds18:22
mordredand who can assert that it's ok for the ensure roles to do that - maybe it's useful?18:23
fungihttps://docs.ansible.com/ansible/latest/modules/command_module.html doesn't advertise path manipulation, or even environment manipulation, options18:23
fungido we need shell instead?18:23
mordredfungi: it's not a command parameter18:23
mordredit's a top-level task param18:23
mordredone sec ...18:23
fungiaha, okay18:23
fungiyeah, i guess i shouldn't have assumed only things run by the command module care about envvars18:23
fungiand even the path envvar in particular18:24
mordredfungi: https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/multi-node-bridge/tasks/common.yaml#L12618:24
corvusmordred: oh wow.  i ack your ping and will start reading scrollback.18:25
fungithanks mordred18:25
openstackgerritMonty Taylor proposed zuul/zuul-jobs master: Add option to install tox into a path location  https://review.opendev.org/73633018:28
mordredcorvus: ^^ something like that handwave handwave18:28
mordredand then fungi could just add tox_ensure_global: true to this release job and the script should just work18:29
corvusmordred: i like it18:29
*** hashar has joined #openstack-infra18:29
corvusand reading all that scrollback helped18:29
mordredcorvus: do you think we should try to mkae it a more global flag, like just ensure_global18:29
mordredor per-ensure role?18:29
corvusmordred: i'm still kind-of digging my "do both" idea from earlier, what do you think?18:30
corvustox_ensure_global defaults to ensure_global defaults to false18:30
corvusthough honestly... maybe that's overengineering18:30
corvusis a job going to have more than one user of ensure_global?18:30
fungianybody know off the top of their heads what the ansible filter equivalent is for os.path.basedir()?18:31
mordredcorvus: yeah - I like the do both idea ... but also maybe yeah, maybe it's too much for this18:32
mordredcorvus: like, perhaps we should start with tox_ensure_global and see how many more we grow18:32
corvusfungi: what's basedir?  do you mean basename?18:33
mordredor - eek, I keep talking myself around in circles18:33
fungier, yep sorry18:33
fungidirname18:33
corvusthat's 'basename' https://docs.ansible.com/ansible/latest/user_guide/playbooks_filters.html18:33
openstackgerritMonty Taylor proposed zuul/zuul-jobs master: Add option to install tox into a path location  https://review.opendev.org/73633018:33
corvusfungi: dirname too18:33
mordredfungi: I think you can probably just depends-on that ^^18:33
*** eolivare has quit IRC18:33
mordred(as soon as we decide what the variable name should be)18:33
fungicorvus: thanks. i would help if i didn't constantly get the function name for that wrong ;)18:34
mordredfungi: I get the name of that function wrong all the time18:34
corvusmordred: i think the test is whether a user would ever want different values for different roles18:34
fungimordred: cool, i'll abandon the path manipulation attempt in that case18:34
corvusmordred: i can easily see that for the python version thing.  i'm drawing a blank on a use-case for that for installing global symlinks.18:34
mordredcorvus: same18:35
mordredlike - if you're ok installing global symlinks - I imagine you'd want to do it for all the things18:35
corvusya18:35
mordredcorvus: so how about "ensure_global_symlinks"18:36
mordredor should we make it zuul_ensure_global_symlinks18:36
corvus++18:36
corvusoh um.18:36
corvusno zuul i think.18:36
mordredkk18:36
openstackgerritMonty Taylor proposed zuul/zuul-jobs master: Add option to install tox into a path location  https://review.opendev.org/73633018:37
openstackgerritJeremy Stanley proposed openstack/openstack-zuul-jobs master: Symlink tox into the exec path for release jobs  https://review.opendev.org/73633418:40
fungimordred: ^18:40
fungifirst user!18:40
*** gfidente is now known as gfidente|afk18:40
fungismcginnis: ^18:40
mordredfungi: \o/18:44
*** jamesmcarthur has joined #openstack-infra18:47
mordredfungi: do we need to do a simlar thing with ensure-virtualenv? or is that just installing the package?18:47
fungimordred: i don't think the script is directly calling virtualenv/venv18:50
fungiit just gives a somewhat misleading error message because it's using tox to create a virtualenv18:51
fungiso when the script can't find/run tox it says that it "failed to create the virtualenv"18:51
openstackgerritMonty Taylor proposed zuul/zuul-jobs master: Add option to install tox into a path location  https://review.opendev.org/73633018:52
mordredfungi: awesome18:54
mordredfungi: you might need a recheck - I forgot a become:18:54
*** jamesmcarthur has quit IRC18:54
openstackgerritMonty Taylor proposed zuul/zuul-jobs master: Add option to install tox into a path location  https://review.opendev.org/73633018:55
*** jamesmcarthur has joined #openstack-infra18:55
fungimordred: yep, just making sure the dust settles first18:56
* mordred throws a handful of dust at fungi18:57
fungii have plenty already, thanks. the contractors started replacing my hvac system bright and early this morning18:58
fungii didn't realize these things cost as much as a new mid-size automobile18:58
*** jamesmcarthur_ has joined #openstack-infra18:59
*** jamesmcarthur has quit IRC19:01
*** rlandy is now known as rlandy|brb19:01
mordredfungi: they are oe of the least fun things to replace19:07
mordredyou don't even get a new toy to play with when they're done19:08
*** sshnaidm|bbl is now known as sshnaidm19:09
fungiwell, we get a couple of fancy new multi-zone touchscreen thermostats19:14
fungi(in theory at least, i mean i saw them included on the quote anyway)19:15
fungialso new ductwork i could crawl around inside if i lost a few lbs19:16
*** ralonsoh has quit IRC19:22
*** rlandy|brb is now known as rlandy19:26
smcginnisHah19:32
smcginnisThanks fungi and mordred.19:32
openstackgerritMonty Taylor proposed zuul/zuul-jobs master: Add option to install tox into a path location  https://review.opendev.org/73633019:40
fungiturns out the image changes have broken our ability to test that role, however ;)19:40
*** jamesmcarthur_ has quit IRC19:45
*** jamesmcarthur has joined #openstack-infra19:46
openstackgerritJames E. Blair proposed zuul/zuul-jobs master: Ensure wheel exists for build-release-python  https://review.opendev.org/73618519:46
AJaegerelod: oslo.messaging is more complex, hope I got it now. fungi, could you review the change, please? https://review.opendev.org/736248 problem is that for amqp1 testing, it needs to install qdrouterd with needs another repo to be added for Ubuntu...19:47
openstackgerritMonty Taylor proposed zuul/zuul-jobs master: Add option to install tox into a path location  https://review.opendev.org/73633019:47
*** ociuhandu has joined #openstack-infra19:52
*** eolivare_ has joined #openstack-infra19:55
*** eolivare_ has quit IRC19:58
openstackgerritTristan Cacqueray proposed zuul/zuul-jobs master: Add ensure pre-run policy to ansible-lint  https://review.opendev.org/73636720:01
*** rlandy_ has joined #openstack-infra20:09
*** mnencia_ has joined #openstack-infra20:11
openstackgerritTristan Cacqueray proposed zuul/zuul-jobs master: phoronix-test-suite: extract ensure- role from run playbook  https://review.opendev.org/73636820:11
*** ktsuyuzaki has joined #openstack-infra20:11
*** Lucas_Gray has joined #openstack-infra20:11
*** ktsuyuzaki is now known as kota__20:12
*** tobberydberg_ has joined #openstack-infra20:12
*** tosky_ has joined #openstack-infra20:12
*** tosky has quit IRC20:13
*** tosky_ is now known as tosky20:13
*** irclogbot_3 has quit IRC20:14
*** JasonF has joined #openstack-infra20:14
*** Wasaac_ has joined #openstack-infra20:14
*** gyee has quit IRC20:17
*** tobberydberg has quit IRC20:18
*** rlandy has quit IRC20:18
*** zxiiro has quit IRC20:18
*** masayukig has quit IRC20:18
*** mnencia has quit IRC20:18
*** mgoddard has quit IRC20:18
*** amorin has quit IRC20:18
*** JayF has quit IRC20:18
*** kota_ has quit IRC20:18
*** Wasaac has quit IRC20:18
*** bradm has quit IRC20:18
*** mnencia_ is now known as mnencia20:18
*** rlandy__ has joined #openstack-infra20:18
*** Wasaac_ is now known as Wasaac20:19
*** rlandy_ has quit IRC20:19
*** amorin has joined #openstack-infra20:20
*** irclogbot_3 has joined #openstack-infra20:20
*** mgoddard has joined #openstack-infra20:21
*** masayukig has joined #openstack-infra20:24
*** zxiiro has joined #openstack-infra20:25
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add linting rule to enforce no-same-owner policy  https://review.opendev.org/72764220:27
*** gyee has joined #openstack-infra20:31
*** jamesmcarthur has quit IRC20:31
*** jamesmcarthur has joined #openstack-infra20:32
*** lxkong has quit IRC20:35
*** srwilkers has quit IRC20:35
*** jamesmcarthur has quit IRC20:37
*** howell has quit IRC20:37
*** rpioso has quit IRC20:38
*** davecore has quit IRC20:38
*** cjohnston has quit IRC20:38
*** rlandy__ is now known as rlandy20:39
*** csatari has quit IRC20:39
*** cjohnston has joined #openstack-infra20:40
*** knikolla has quit IRC20:40
*** davecore has joined #openstack-infra20:40
openstackgerritMonty Taylor proposed zuul/zuul-jobs master: Add option to install tox into a path location  https://review.opendev.org/73633020:42
*** knikolla has joined #openstack-infra20:42
*** tonyb[m] has quit IRC20:43
*** cjohnston has quit IRC20:46
*** ociuhandu has quit IRC20:48
*** PrinzElvis has quit IRC20:49
*** priteau has quit IRC20:49
*** davecore has quit IRC20:51
*** knikolla has quit IRC20:52
*** PrinzElvis has joined #openstack-infra20:52
*** PrinzElvis has quit IRC20:57
*** diablo_rojo_phon has joined #openstack-infra20:59
*** jamesmcarthur has joined #openstack-infra21:04
*** JasonF is now known as JayF21:06
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add linting rule to enforce no-same-owner policy  https://review.opendev.org/72764221:07
*** lxkong has joined #openstack-infra21:09
*** rfolco|rover has quit IRC21:12
*** noonedeadpunk has quit IRC21:12
*** jamesmcarthur has quit IRC21:13
openstackgerritAhmad Mahmoudi proposed zuul/zuul-jobs master: (fix) Changed pip to pip3  https://review.opendev.org/73637921:16
*** lxkong has quit IRC21:16
*** ociuhandu has joined #openstack-infra21:19
openstackgerritTristan Cacqueray proposed zuul/zuul-jobs master: Add ensure pre-run policy to ansible-lint  https://review.opendev.org/73636721:19
*** xek has quit IRC21:20
*** ociuhandu has quit IRC21:24
openstackgerritMonty Taylor proposed zuul/zuul-jobs master: Add option to install tox into a path location  https://review.opendev.org/73633021:31
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Fix ansible-lint rules tests  https://review.opendev.org/73638721:34
*** davecore has joined #openstack-infra21:34
*** lxkong has joined #openstack-infra21:34
*** srwilkers has joined #openstack-infra21:34
*** howell has joined #openstack-infra21:35
*** PrinzElvis has joined #openstack-infra21:35
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add linting rule to enforce no-same-owner policy  https://review.opendev.org/72764221:35
*** rpioso has joined #openstack-infra21:37
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Fix ansible-lint rules tests  https://review.opendev.org/73638721:37
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add linting rule to enforce no-same-owner policy  https://review.opendev.org/72764221:37
*** tonyb[m] has joined #openstack-infra21:38
*** csatari has joined #openstack-infra21:38
*** knikolla has joined #openstack-infra21:40
*** slaweq has quit IRC21:41
*** cjohnston has joined #openstack-infra21:41
*** gshippey_ has quit IRC21:42
*** jamesmcarthur has joined #openstack-infra21:50
*** hashar has quit IRC21:52
*** jamesmcarthur has quit IRC21:54
*** tosky has quit IRC21:56
*** tosky has joined #openstack-infra21:56
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Fix ansible-lint rules tests  https://review.opendev.org/73638721:58
*** rlandy is now known as rlandy|bbl21:59
openstackgerritMonty Taylor proposed zuul/zuul-jobs master: Ensure wheel exists for build-release-python  https://review.opendev.org/73618521:59
*** matt_kosut has quit IRC22:04
*** matt_kosut has joined #openstack-infra22:05
openstackgerritMerged zuul/zuul-jobs master: Add option to install tox into a path location  https://review.opendev.org/73633022:05
*** matt_kosut has quit IRC22:09
mordredsmcginnis: ^^22:11
mordredclarkb: ^^ if you have a sec, https://review.opendev.org/#/c/736334 could use a +A22:12
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Fix ansible-lint rules tests  https://review.opendev.org/73638722:13
clarkbmordred: done22:13
mordred\o/22:15
* mordred is happy that there has been a success for the day22:16
openstackgerritMerged openstack/openstack-zuul-jobs master: Symlink tox into the exec path for release jobs  https://review.opendev.org/73633422:24
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add linting rule to enforce no-same-owner policy  https://review.opendev.org/72764222:29
*** _erlon_ has joined #openstack-infra22:33
*** rcernin has joined #openstack-infra22:42
smcginnisAwesome, new release test on its way.22:44
*** bradm has joined #openstack-infra22:44
fungismcginnis: i expect you're still likely to hit trouble until 736185 merges22:45
smcginnisfungi: Yeah, just saw your comment in the release channel.22:45
smcginnisI thought that one had gone through too. I'll hold off a bit.22:45
fungiit had gone through once, had to be reverted because it broke other users outside opendev, and was reworked in a much safer way22:46
smcginnisThat might explain it.22:47
smcginnisOne job left.22:47
openstackgerritMerged zuul/zuul-jobs master: Ensure wheel exists for build-release-python  https://review.opendev.org/73618522:48
smcginnisAnd then there were none.22:49
smcginnisfungi: Do I need to wait for any background processes to run before everything is in place for a test release?22:49
clarkbsmcginnis: not if the changes you need are to zuul jobs, those should update basically as soon as they merge22:50
smcginnisPerfect. Release test on its way then.22:50
fungiyay!22:51
*** seongsoocho has joined #openstack-infra22:51
*** gyee has quit IRC22:52
*** tkajinam has joined #openstack-infra22:54
*** Lucas_Gray has quit IRC23:07
*** tosky has quit IRC23:09
*** Lucas_Gray has joined #openstack-infra23:22

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!