*** zxiiro has quit IRC | 00:04 | |
*** hashar has quit IRC | 00:05 | |
*** jamesmcarthur has quit IRC | 00:16 | |
*** jamesmcarthur has joined #openstack-infra | 00:17 | |
*** snapiri has quit IRC | 00:18 | |
*** snapiri has joined #openstack-infra | 00:18 | |
*** fdegir5 has joined #openstack-infra | 00:19 | |
*** jaicaa has quit IRC | 00:19 | |
*** fdegir has quit IRC | 00:19 | |
*** jaicaa has joined #openstack-infra | 00:19 | |
*** abhishekk has quit IRC | 00:20 | |
*** jamesmcarthur has quit IRC | 00:20 | |
*** jamesmcarthur has joined #openstack-infra | 00:20 | |
*** tosky has quit IRC | 00:23 | |
*** rm_work has quit IRC | 00:37 | |
*** logan- has quit IRC | 00:38 | |
*** logan- has joined #openstack-infra | 00:40 | |
*** dychen has joined #openstack-infra | 00:44 | |
*** yamamoto_ has joined #openstack-infra | 00:45 | |
*** yamamoto has quit IRC | 00:46 | |
*** dchen has quit IRC | 00:47 | |
*** tbachman has quit IRC | 00:49 | |
*** tbachman has joined #openstack-infra | 00:49 | |
*** dviroel has quit IRC | 00:52 | |
*** zxiiro has joined #openstack-infra | 01:08 | |
*** ttx has quit IRC | 01:11 | |
*** Adri2000 has quit IRC | 01:11 | |
*** larsks has quit IRC | 01:11 | |
*** ttx has joined #openstack-infra | 01:12 | |
*** Adri2000 has joined #openstack-infra | 01:12 | |
*** larsks has joined #openstack-infra | 01:12 | |
*** jistr has quit IRC | 01:13 | |
*** jistr has joined #openstack-infra | 01:13 | |
*** cyberpear has quit IRC | 01:13 | |
*** mnaser has quit IRC | 01:13 | |
*** thedac has quit IRC | 01:13 | |
*** JanZerebecki[m] has quit IRC | 01:14 | |
*** reed has quit IRC | 01:14 | |
*** wolsen has quit IRC | 01:14 | |
*** mordred has quit IRC | 01:15 | |
*** thedac has joined #openstack-infra | 01:15 | |
*** mnaser has joined #openstack-infra | 01:16 | |
*** cyberpear has joined #openstack-infra | 01:16 | |
*** Wasaac has quit IRC | 01:22 | |
*** gyee has quit IRC | 01:22 | |
*** Wasaac has joined #openstack-infra | 01:23 | |
*** rm_work has joined #openstack-infra | 01:25 | |
*** rm_work has quit IRC | 01:25 | |
*** mordred has joined #openstack-infra | 01:44 | |
*** JanZerebecki[m] has joined #openstack-infra | 01:45 | |
*** wolsen has joined #openstack-infra | 01:46 | |
*** dklyle has quit IRC | 01:51 | |
*** rm_work has joined #openstack-infra | 02:01 | |
*** JanZerebecki[m] has quit IRC | 02:03 | |
*** wolsen has quit IRC | 02:04 | |
*** mordred has quit IRC | 02:04 | |
openstackgerrit | Merged openstack/project-config master: Add official-openstack-repo-jobs for openstack/glance-tempest-plugin https://review.opendev.org/c/openstack/project-config/+/771954 | 02:15 |
---|---|---|
*** yamamoto_ has quit IRC | 02:15 | |
*** yamamoto has joined #openstack-infra | 02:16 | |
*** sshnaidm|ruck is now known as sshnaidm|off | 02:25 | |
*** lxkong has quit IRC | 02:38 | |
*** lxkong has joined #openstack-infra | 02:39 | |
*** JanZerebecki[m] has joined #openstack-infra | 02:42 | |
*** wolsen has joined #openstack-infra | 02:48 | |
*** mordred has joined #openstack-infra | 02:48 | |
*** zzzeek has quit IRC | 03:01 | |
*** zzzeek has joined #openstack-infra | 03:02 | |
*** rcernin has quit IRC | 03:27 | |
*** nicolasbock_ has joined #openstack-infra | 03:30 | |
*** Wasaac_ has joined #openstack-infra | 03:31 | |
*** dpawlik1 has joined #openstack-infra | 03:32 | |
*** ianw_ has joined #openstack-infra | 03:32 | |
*** tobiash_ has joined #openstack-infra | 03:33 | |
*** akahat has joined #openstack-infra | 03:33 | |
*** Wasaac has quit IRC | 03:38 | |
*** zbr has quit IRC | 03:38 | |
*** nicolasbock has quit IRC | 03:38 | |
*** dpawlik has quit IRC | 03:38 | |
*** arxcruz has quit IRC | 03:38 | |
*** jpena|off has quit IRC | 03:38 | |
*** akahat|rover has quit IRC | 03:38 | |
*** ianw has quit IRC | 03:38 | |
*** beagles has quit IRC | 03:38 | |
*** jlvillal has quit IRC | 03:38 | |
*** tobiash has quit IRC | 03:38 | |
*** ianw_ is now known as ianw | 03:38 | |
*** Wasaac_ is now known as Wasaac | 03:38 | |
*** nicolasbock_ is now known as nicolasbock | 03:38 | |
*** jpena|off has joined #openstack-infra | 03:39 | |
*** mordred has quit IRC | 03:40 | |
*** rcernin has joined #openstack-infra | 03:41 | |
*** psachin has joined #openstack-infra | 03:42 | |
*** gouthamr has quit IRC | 03:43 | |
*** zbr has joined #openstack-infra | 03:43 | |
*** arxcruz has joined #openstack-infra | 03:43 | |
*** beagles has joined #openstack-infra | 03:43 | |
*** jlvillal has joined #openstack-infra | 03:43 | |
*** mordred has joined #openstack-infra | 03:44 | |
*** abhishekk has joined #openstack-infra | 03:58 | |
*** zxiiro has quit IRC | 04:04 | |
*** ykarel has joined #openstack-infra | 04:04 | |
*** ricolin_ has joined #openstack-infra | 04:18 | |
*** jamesmcarthur has quit IRC | 04:22 | |
*** jamesmcarthur has joined #openstack-infra | 04:24 | |
*** ykarel_ has joined #openstack-infra | 04:28 | |
*** ykarel has quit IRC | 04:30 | |
*** ykarel_ is now known as ykarel | 04:42 | |
*** Ajohn has joined #openstack-infra | 04:43 | |
*** ricolin_ has quit IRC | 05:03 | |
*** vishalmanchanda has joined #openstack-infra | 05:03 | |
*** Ajohn has quit IRC | 05:22 | |
*** calbers_ has joined #openstack-infra | 05:45 | |
*** calbers has quit IRC | 05:46 | |
*** calbers_ is now known as calbers | 05:46 | |
*** ykarel_ has joined #openstack-infra | 05:50 | |
*** ykarel has quit IRC | 05:53 | |
*** aarents has quit IRC | 05:57 | |
*** ianw has quit IRC | 05:59 | |
*** ykarel_ is now known as ykarel | 05:59 | |
*** ianw has joined #openstack-infra | 06:01 | |
*** lbragstad has quit IRC | 06:11 | |
*** dchen has joined #openstack-infra | 06:15 | |
*** lbragstad has joined #openstack-infra | 06:16 | |
*** jamesmcarthur has quit IRC | 06:26 | |
openstackgerrit | Merged openstack/project-config master: Preparation for tempest-horizon retirement https://review.opendev.org/c/openstack/project-config/+/772373 | 06:33 |
openstackgerrit | Merged openstack/project-config master: Add key editHashtags to normalize_acl script https://review.opendev.org/c/openstack/project-config/+/772484 | 06:41 |
openstackgerrit | Merged openstack/project-config master: Update neutron grafana dashboard https://review.opendev.org/c/openstack/project-config/+/772643 | 06:41 |
openstackgerrit | Merged openstack/project-config master: Remove Karbor projects from infra https://review.opendev.org/c/openstack/project-config/+/767057 | 06:41 |
openstackgerrit | Merged openstack/project-config master: Add rbd-iscsi-client to cinder project https://review.opendev.org/c/openstack/project-config/+/772596 | 06:44 |
*** dchen has quit IRC | 06:53 | |
*** lbragstad has quit IRC | 07:14 | |
*** lbragstad has joined #openstack-infra | 07:14 | |
*** dpawlik1 is now known as dpawlik | 07:16 | |
*** jcapitao has joined #openstack-infra | 07:16 | |
*** gouthamr has joined #openstack-infra | 07:22 | |
*** openstackgerrit has quit IRC | 07:23 | |
*** xek__ has joined #openstack-infra | 07:25 | |
*** dchen has joined #openstack-infra | 07:29 | |
*** lpetrut has joined #openstack-infra | 07:30 | |
*** eolivare has joined #openstack-infra | 07:30 | |
*** ralonsoh has joined #openstack-infra | 07:39 | |
*** ysandeep|away is now known as ysandeep | 07:45 | |
*** hashar has joined #openstack-infra | 07:56 | |
*** slaweq has joined #openstack-infra | 07:57 | |
*** dchen has quit IRC | 07:58 | |
*** amoralej|off is now known as amoralej | 08:04 | |
*** slaweq has quit IRC | 08:10 | |
*** slaweq has joined #openstack-infra | 08:14 | |
*** sboyron has joined #openstack-infra | 08:21 | |
*** benj_ has quit IRC | 08:22 | |
*** jamesmcarthur has joined #openstack-infra | 08:27 | |
*** jamesmcarthur has quit IRC | 08:31 | |
*** sboyron has quit IRC | 08:34 | |
*** tosky has joined #openstack-infra | 08:41 | |
*** nightmare_unreal has joined #openstack-infra | 08:45 | |
*** juslintek has joined #openstack-infra | 08:48 | |
*** sboyron has joined #openstack-infra | 08:48 | |
juslintek | Hi, is elastic IP the only single way to host multiple instances on a single IP? | 08:49 |
juslintek | For example I am renting AMD Ryzen 3600 6 cores (12 threads) with 64GB RAM and 2x512GB NVE SSD at hetzner and I have single IP. I want to host my clients projects there and do not want to puchase additional public IPs. As well planning on implementing stateless functions and so on. What is the best approach here? | 08:51 |
juslintek | Forgot to mention that kubernetes are going to be implemented as well in the future. | 08:52 |
*** rpittau|afk is now known as rpittau | 08:52 | |
*** jpena|off is now known as jpena | 08:57 | |
*** zzzeek has quit IRC | 09:01 | |
*** rcernin has quit IRC | 09:02 | |
*** yamamoto has quit IRC | 09:02 | |
*** zzzeek has joined #openstack-infra | 09:03 | |
*** lucasagomes has joined #openstack-infra | 09:07 | |
*** gfidente has joined #openstack-infra | 09:09 | |
*** rcernin has joined #openstack-infra | 09:21 | |
*** derekh has joined #openstack-infra | 09:35 | |
*** slaweq has quit IRC | 09:35 | |
*** yamamoto has joined #openstack-infra | 09:38 | |
*** slaweq has joined #openstack-infra | 09:43 | |
*** psachin has quit IRC | 09:46 | |
zbr | who can help tagging a new bindep release? | 09:47 |
*** yamamoto has quit IRC | 09:48 | |
*** ociuhandu has joined #openstack-infra | 10:06 | |
*** lxkong has quit IRC | 10:15 | |
*** lxkong has joined #openstack-infra | 10:16 | |
*** yamamoto has joined #openstack-infra | 10:19 | |
*** rcernin has quit IRC | 10:23 | |
*** zzzeek has quit IRC | 10:30 | |
*** zzzeek has joined #openstack-infra | 10:32 | |
*** aarents has joined #openstack-infra | 10:50 | |
*** zzzeek has quit IRC | 10:54 | |
*** zzzeek has joined #openstack-infra | 10:55 | |
*** sboyron has quit IRC | 10:56 | |
*** sboyron has joined #openstack-infra | 10:58 | |
*** benj_ has joined #openstack-infra | 11:00 | |
*** juslintek has quit IRC | 11:01 | |
*** sshnaidm|off has quit IRC | 11:09 | |
*** sshnaidm|off has joined #openstack-infra | 11:10 | |
*** jcapitao is now known as jcapitao_lunch | 11:19 | |
*** rcernin has joined #openstack-infra | 11:33 | |
*** nightmare_unreal has quit IRC | 11:48 | |
*** dviroel has joined #openstack-infra | 11:54 | |
*** ociuhandu has quit IRC | 12:22 | |
*** ociuhandu has joined #openstack-infra | 12:23 | |
*** ociuhandu has quit IRC | 12:27 | |
*** ociuhandu has joined #openstack-infra | 12:30 | |
*** rcernin has quit IRC | 12:32 | |
*** jpena is now known as jpena|lunch | 12:33 | |
*** ociuhandu has quit IRC | 12:35 | |
*** ociuhandu has joined #openstack-infra | 12:44 | |
*** ociuhandu has quit IRC | 12:49 | |
*** yamamoto has quit IRC | 12:53 | |
*** stephenfin has quit IRC | 12:54 | |
*** jcapitao_lunch is now known as jcapitao | 13:00 | |
*** JanZerebecki[m] has quit IRC | 13:00 | |
*** rm_work has quit IRC | 13:00 | |
*** jamesdenton has quit IRC | 13:00 | |
*** thedac has quit IRC | 13:00 | |
*** cyberpear has quit IRC | 13:00 | |
*** mnaser has quit IRC | 13:00 | |
*** dychen has quit IRC | 13:00 | |
*** jrosser has quit IRC | 13:00 | |
*** Jeffrey4l has quit IRC | 13:00 | |
*** JanZerebecki[m] has joined #openstack-infra | 13:01 | |
*** rm_work has joined #openstack-infra | 13:01 | |
*** jamesdenton has joined #openstack-infra | 13:01 | |
*** cyberpear has joined #openstack-infra | 13:01 | |
*** mnaser has joined #openstack-infra | 13:01 | |
*** thedac has joined #openstack-infra | 13:01 | |
*** dychen has joined #openstack-infra | 13:01 | |
*** jrosser has joined #openstack-infra | 13:01 | |
*** Jeffrey4l has joined #openstack-infra | 13:01 | |
*** ociuhandu has joined #openstack-infra | 13:01 | |
*** benj_ has quit IRC | 13:02 | |
*** walshh_ has quit IRC | 13:02 | |
*** wolsen has quit IRC | 13:02 | |
*** zigo has quit IRC | 13:03 | |
*** sorrison has quit IRC | 13:03 | |
*** JanZerebecki[m] has quit IRC | 13:03 | |
*** mordred has quit IRC | 13:03 | |
*** wolsen has joined #openstack-infra | 13:03 | |
*** zigo has joined #openstack-infra | 13:03 | |
*** sorrison has joined #openstack-infra | 13:03 | |
*** benj_ has joined #openstack-infra | 13:04 | |
*** walshh_ has joined #openstack-infra | 13:04 | |
*** cyberpear has quit IRC | 13:04 | |
*** wolsen has quit IRC | 13:04 | |
*** benj_ has quit IRC | 13:05 | |
*** benj_ has joined #openstack-infra | 13:06 | |
*** cyberpear has joined #openstack-infra | 13:06 | |
*** ociuhandu has quit IRC | 13:08 | |
*** ociuhandu has joined #openstack-infra | 13:08 | |
*** ociuhandu has quit IRC | 13:08 | |
*** ociuhandu has joined #openstack-infra | 13:09 | |
*** ociuhandu has quit IRC | 13:14 | |
*** yamamoto has joined #openstack-infra | 13:21 | |
*** yamamoto has quit IRC | 13:26 | |
*** zzzeek has quit IRC | 13:29 | |
*** jpena|lunch is now known as jpena | 13:30 | |
*** zzzeek has joined #openstack-infra | 13:31 | |
*** mordred has joined #openstack-infra | 13:31 | |
*** ociuhandu has joined #openstack-infra | 13:33 | |
*** yamamoto has joined #openstack-infra | 13:37 | |
*** ociuhandu has quit IRC | 13:38 | |
*** amoralej is now known as amoralej|lunch | 13:42 | |
*** sboyron has quit IRC | 13:44 | |
*** mordred has quit IRC | 13:48 | |
*** sboyron has joined #openstack-infra | 13:49 | |
*** ociuhandu has joined #openstack-infra | 13:52 | |
*** zzzeek has quit IRC | 13:52 | |
*** zzzeek has joined #openstack-infra | 13:56 | |
*** ociuhandu has quit IRC | 13:58 | |
*** ociuhandu has joined #openstack-infra | 13:58 | |
*** dychen has quit IRC | 13:59 | |
*** ysandeep is now known as ysandeep|afk | 14:00 | |
*** zzzeek has quit IRC | 14:02 | |
*** zzzeek has joined #openstack-infra | 14:03 | |
*** JanZerebecki[m] has joined #openstack-infra | 14:15 | |
*** stephenfin has joined #openstack-infra | 14:22 | |
*** hashar is now known as hasharAway | 14:24 | |
*** sshnaidm|off has quit IRC | 14:27 | |
*** sshnaidm|off has joined #openstack-infra | 14:27 | |
zbr | over 15s to get first response for auto-complete,... https://sbarnea.com/ss/Screen-Shot-2021-01-29-14-43-13.05.png | 14:44 |
zbr | it was hard to convince people to do reviews, now is harder to even assign reviwers :( | 14:44 |
*** akahat is now known as akahat|rover | 14:45 | |
*** amoralej|lunch is now known as amoralej | 14:48 | |
*** mordred has joined #openstack-infra | 14:51 | |
*** wolsen has joined #openstack-infra | 14:51 | |
fungi | i wanted to get the release notes written up for bindep next since those have been missed in recent reviews as well, so that whatever summary needs to be written for the release announcement can just be committed to the repo since it's already set up for that, but got sidetracked trying to figure out the best way to rework ssh key addition in the git-review unit tests so we can get that release out | 14:56 |
*** yamamoto has quit IRC | 14:57 | |
fungi | i've been trying to switch git-review testing to upload the client public key via the ssh cli, using the "gerrit code review" built-in superuser, but passing a username with spaces in it from python to an ssh command it turning out to be tricky | 14:57 |
fungi | i've tried every combination of escaping and quoting i can think of, but the shell still seems to tokenize the username on space separators and tries to make it into additional parameters | 14:58 |
melwitt | could anyone please remind me what is it that is needed in jeepyb to enable gerrit-launchpad integration again for updating bugs? | 14:59 |
zbr | fungi: i made a hackish release to tox-bindep to overcome lack of release, see https://github.com/tox-dev/tox-bindep/pull/6/files#diff-1738777692dba217b1150daa067ab8b9ec264cc8478e97beba280015273cec80R19 | 15:00 |
*** jamesmcarthur has joined #openstack-infra | 15:01 | |
zbr | it works and is future proof :D | 15:01 |
fungi | melwitt: the existing update-bug script in jeepyb wants to perform local mysql lookups on the gerrit server, and gerrit now uses a git-based database backend instead | 15:01 |
*** ociuhandu has quit IRC | 15:01 | |
fungi | melwitt: most likely paths forward are to adjust the script to use the gerrit rest api instead (and add credentials to make that possible), or write a nodeless zuul job which performs the same tasks so we can drop that part of jeepyb | 15:02 |
*** ociuhandu has joined #openstack-infra | 15:02 | |
melwitt | fungi: a-ha, ok thanks. I was wondering if there was anything I could do to help with that | 15:03 |
fungi | melwitt: one of those two things, probably... i think the challenge is we're going to need to give it elevated privileges if we still want it to be able to get the openid url for the change committer so it can be mapped to a launchpad account for bug reassignment | 15:06 |
fungi | there is a rest api call which can get that data, but it needs special perms for the requesting user | 15:06 |
melwitt | hm ok. that's unfortunate | 15:08 |
*** ociuhandu has quit IRC | 15:08 | |
*** ykarel has quit IRC | 15:11 | |
*** ociuhandu has joined #openstack-infra | 15:11 | |
fungi | zbr: if you have suggestions on how to keep a username with spaces from getting tokenized when plumbed through subprocess.Popen() and can mention them on https://review.opendev.org/772589 i'd be thrilled, otherwise we'll probably need to commit them in git | 15:11 |
fungi | no matter what i've tried, it still seems to want to interpret Code as the hostname | 15:12 |
*** ykarel has joined #openstack-infra | 15:12 | |
*** ociuhandu has quit IRC | 15:16 | |
fungi | zbr: i also reordered that stack so the missing git-review release notes can be merged first. i'll switch gears to writing the missing bindep release notes | 15:17 |
*** ociuhandu has joined #openstack-infra | 15:20 | |
melwitt | fungi: do you suppose querying NoteDb could be another option for getting user external ids? https://gerrit-review.googlesource.com/Documentation/config-accounts.html | 15:21 |
*** ociuhandu has quit IRC | 15:21 | |
*** ociuhandu has joined #openstack-infra | 15:22 | |
*** __ministry1 has joined #openstack-infra | 15:24 | |
*** __ministry1 has quit IRC | 15:25 | |
zbr | fungi: i do remeber that using shell=True/False has some side-effects on how args are processes (spliting or not) | 15:25 |
*** __ministry1 has joined #openstack-infra | 15:26 | |
*** __ministry1 has quit IRC | 15:26 | |
*** rpittau is now known as rpittau|afk | 15:27 | |
zbr | i may have missed few things around sshkey, but why we do need to generate a key instead of re-using current user key only injecting it? | 15:30 |
zbr | i guess too many broken combinations, old gerrit not supporting modern keys, modern systems not support old keys. | 15:33 |
fungi | melwitt: relying on internal implementation details of gerrit's notedb backend could put us back in the exact same situation relying on implementation details of its rdbms backend did, neither was considered a stable api by gerrit upstream | 15:37 |
melwitt | fungi: ack | 15:39 |
fungi | zbr: well, the user doesn't necessarily have a an available key the test could use (in the case of local testing it might be on a removeable fob or likely requires a passphrase to decrypt) so the test would need to make one anyway in that case, but that's not where the problem lies. we still have to get some public key into gerrit somehow for the uploads in the test to use, and the problem is gerrit | 15:39 |
fungi | changed how it's storing those | 15:39 |
fungi | melwitt: ^ another prime example of where that decision is biting us, actually | 15:39 |
melwitt | I see | 15:40 |
fungi | git-review integration tests start a local gerrit and the bootstrapping process was previously adding the user directly to the database backend, but the last gerrit release where you could insert public ssh keys that way was 2.11, ages ago, so our git-review testing is stuck relying on very old gerrit versions which actually aren't even installable from upstream any longer due to relying on libraries | 15:41 |
fungi | which have disappeared from maven | 15:41 |
melwitt | :( | 15:42 |
fungi | so i'm trying to work out how to at least switch the ssh key addition to using a stable api instead of db injection | 15:42 |
zbr | that should be the right way towards getting out of this situation | 15:42 |
*** dklyle has joined #openstack-infra | 15:47 | |
clarkb | fungi: to be fair those decisions were made well before gerrit had apis to do any of these interactions | 16:06 |
clarkb | then they added apis and removed all the backends :) | 16:06 |
fungi | clarkb: yep, absolutely true, i expect if they'd had a stable api when we were writing these things we'd have chosen it | 16:08 |
*** sshnaidm|off has quit IRC | 16:09 | |
fungi | doesn't really change the result though, we've got things implemented against internal details which have changed, and we can hopefully minimize future pain by switching to a public api | 16:09 |
*** ykarel has quit IRC | 16:14 | |
zbr | fungi: i think the issue with your command is the newline, not the quoting. https://zuul.opendev.org/t/openstack/build/abc418081c714387b3964b1dedfa9db3 | 16:14 |
*** sshnaidm|off has joined #openstack-infra | 16:14 | |
*** lpetrut has quit IRC | 16:15 | |
zbr | missing a chomp | 16:15 |
fungi | ooh, thanks i'll test a strip on the pubkey | 16:15 |
*** __ministry1 has joined #openstack-infra | 16:35 | |
*** jamesmcarthur has quit IRC | 16:42 | |
*** hasharAway is now known as hashar | 16:48 | |
*** tobiash_ is now known as tobiash | 16:57 | |
*** lucasagomes has quit IRC | 16:57 | |
*** jamesmcarthur has joined #openstack-infra | 17:08 | |
*** jamesmcarthur has quit IRC | 17:10 | |
*** jamesmcarthur has joined #openstack-infra | 17:11 | |
*** jamesmcarthur has quit IRC | 17:17 | |
*** jamesmcarthur has joined #openstack-infra | 17:18 | |
fungi | zbr: stripping the pubkey was a good call, i'm including that, but it doesn't stop the shell from trying to tokenize the spaced substrings of the ssh username, so i'm still fiddling with different approaches there | 17:20 |
clarkb | fungi: is there something I can look at to be helpful? | 17:20 |
*** amoralej is now known as amoralej|off | 17:21 | |
fungi | clarkb: https://review.opendev.org/772589 is where i'm hacking on it | 17:21 |
*** __ministry1 has quit IRC | 17:22 | |
fungi | current approach is to push the pubkey via the cli after gerrit is booted, using the magic "Gerrit Code Review" built-in superuser account | 17:22 |
fungi | need to call it via suexec since that account can't do anything which gets attributed to a real user account, but basically hoping this will let us bootstrap an initial ssh pubkey for a user on versions of gerrit which no longer track those in the relational db | 17:23 |
fungi | alternative would be to use the rest api to post the pubkey, since the account does have an http password at that point (unless we update to a new enough version that passwords get hashed, or that external ids move into notedb as well) | 17:24 |
clarkb | fungi: is utils.run_cmd() doing a join on that set of *args? | 17:25 |
clarkb | if so adding more quotes should help? | 17:26 |
clarkb | or maybe push a list all the way down to subprocess (which is probably the more pythonic method) | 17:26 |
fungi | it's passing the args list directly to subprocess.Popen() | 17:26 |
fungi | fwiw i've tried '"Gerrit Code Review"' and 'Gerrit\ Code\ Review' and various combinations of escaped quotes and so on | 17:27 |
fungi | possible i need to force it to use a shell? | 17:27 |
fungi | we don't have that option plumbed but i can add it | 17:28 |
clarkb | I wouldn't think so as the command should work without a shell | 17:29 |
clarkb | for the quoting workaroudn you would need a shell though | 17:29 |
clarkb | but the way this is written it should pass each of those list items as a different argv and be correct | 17:29 |
clarkb | the python docs even make a note of that: "while arguments that need quoting or backslash escaping when used in the shell (such as filenames containing spaces or the echo command shown above) are single list elements." | 17:31 |
clarkb | fungi: is it possible that ssh itself is splitting on space there becuase space is an invalid unix username char? | 17:31 |
*** vishalmanchanda has quit IRC | 17:32 | |
clarkb | fungi: just as a sanity check I wrote a small bash script that echos its $0 - $4 and then wrote a function that is called with *args passed to Popen() and writes the stdout back again just to be sure we're clumping the argv as expected and yes seems to | 17:36 |
clarkb | that makes me suspect that maybe ssh is doing the argv parsing in a way we don't expect | 17:37 |
fungi | except when i run that command from an actual shell it does work with the account name | 17:37 |
fungi | spaces and all | 17:37 |
fungi | so something about the chain of how we're invoking it seems more likely to be at fault | 17:38 |
clarkb | hrm | 17:38 |
clarkb | fungi: maybe remove the ' '.join(args) from the exception so we can see the actual list passed to Popen | 17:38 |
fungi | i have to do -l "Gerrit Code Review" 127.0.0.1 or "Gerrit Code Review"@127.0.0.1 in the shell of course | 17:38 |
clarkb | the ' '.join(args) is lossy in this context | 17:39 |
fungi | yeah, good call, will work on an upload with that. it's obviously not the cause, but it does make it harder to confirm what's going on is what we think is going on | 17:39 |
clarkb | ya | 17:39 |
clarkb | note there are two cases of that in run_cmd so get both :) | 17:40 |
fungi | d'oh, missed one of them, thanks ;) | 17:41 |
fungi | okay, got both this tie | 17:42 |
fungi | time | 17:42 |
*** ociuhandu has quit IRC | 17:48 | |
*** ociuhandu has joined #openstack-infra | 17:48 | |
*** ociuhandu has quit IRC | 17:53 | |
*** Ajohn has joined #openstack-infra | 17:54 | |
*** jpena is now known as jpena|off | 17:57 | |
*** derekh has quit IRC | 18:00 | |
*** ociuhandu has joined #openstack-infra | 18:06 | |
*** gyee has joined #openstack-infra | 18:08 | |
*** jamesmcarthur has quit IRC | 18:10 | |
*** ociuhandu has quit IRC | 18:12 | |
*** Ajohn has quit IRC | 18:16 | |
clarkb | fungi: '-l', 'Gerrit Code Review', '127.0.0.1', <- the relevant bit of the args | 18:18 |
clarkb | that looks correct | 18:18 |
clarkb | fungi: maybe something about your shell is making it work when run manually | 18:19 |
clarkb | and ssh behaves differently if not interactive? | 18:19 |
*** ralonsoh has quit IRC | 18:19 | |
*** ociuhandu has joined #openstack-infra | 18:19 | |
*** ociuhandu has quit IRC | 18:20 | |
*** ociuhandu has joined #openstack-infra | 18:20 | |
fungi | i still suspect it's an artifact of subprocess.Popen() invoking the executable directly instead of using a shell | 18:21 |
fungi | heading down that rabbit hole next | 18:21 |
fungi | shells do their own tokenization | 18:22 |
clarkb | right but shells do effectively the same tokenization | 18:22 |
clarkb | -l and 'Gerrit Code Review' end up in their own argv entries when ssh is called | 18:22 |
clarkb | and that shouldn't change between ssh with or without a shell | 18:22 |
fungi | yeah, in theory, agreed | 18:23 |
*** jcapitao has quit IRC | 18:23 | |
fungi | will try adding shell=True to the Popen() and seeing if it's also that way in practice | 18:23 |
*** ociuhandu has quit IRC | 18:25 | |
fungi | disappointing if so, but that will at least give us something to go on | 18:25 |
clarkb | ++ | 18:25 |
*** jamesmcarthur has joined #openstack-infra | 18:40 | |
*** eolivare has quit IRC | 18:41 | |
*** jamesmcarthur has quit IRC | 18:45 | |
*** hashar is now known as hasharDinner | 18:54 | |
*** sboyron has quit IRC | 18:55 | |
*** ociuhandu has joined #openstack-infra | 18:59 | |
*** jamesmcarthur has joined #openstack-infra | 19:02 | |
*** ociuhandu has quit IRC | 19:03 | |
*** jamesmcarthur has quit IRC | 19:12 | |
*** bnemec has quit IRC | 19:22 | |
*** jamesmcarthur has joined #openstack-infra | 19:27 | |
*** bnemec has joined #openstack-infra | 19:30 | |
*** jamesmcarthur has quit IRC | 19:31 | |
*** jamesmcarthur has joined #openstack-infra | 19:33 | |
fungi | struggling on how to plumb in shell=True when also passing **kwargs, but have temporarily just added a copy of the underlying function with shell=True and called that instead as a test | 19:39 |
*** jamesmcarthur has quit IRC | 19:39 | |
fungi | i guess the right way to handle it is to set kwargs['shell'] = true before handing off kwargs? | 19:40 |
clarkb | yup | 19:55 |
clarkb | just add it to kwargs manually | 19:55 |
*** rcernin has joined #openstack-infra | 20:09 | |
*** tbachman has quit IRC | 20:13 | |
*** tbachman has joined #openstack-infra | 20:14 | |
fungi | i think i may be getting somewhere wrapping the username in shlex.quote() | 20:18 |
fungi | so many other seemingly unrelated errors though it's hard to be sure | 20:18 |
fungi | this is in combination with setting shell=True for that particular invocation | 20:19 |
*** auristor has quit IRC | 20:20 | |
*** auristor has joined #openstack-infra | 20:22 | |
*** rcernin has quit IRC | 20:44 | |
*** slaweq has quit IRC | 20:59 | |
fungi | new tactic... stick the username in an ssh config host block | 21:09 |
*** rcernin has joined #openstack-infra | 21:10 | |
*** rcernin has quit IRC | 21:15 | |
*** dwilde has joined #openstack-infra | 21:27 | |
*** rcernin has joined #openstack-infra | 21:27 | |
*** hasharDinner is now known as hashar | 21:50 | |
*** ociuhandu has joined #openstack-infra | 22:09 | |
*** yamamoto has joined #openstack-infra | 22:11 | |
*** xek__ has quit IRC | 22:12 | |
*** ociuhandu has quit IRC | 22:15 | |
clarkb | fungi: seems that worked but now fatal: user "test_user" not found | 22:17 |
*** yamamoto has quit IRC | 22:21 | |
fungi | yeah, i wonder if there's something incomplete about how it was added with gsql earlier | 22:23 |
fungi | maybe i'll update it to add the user via the cli once gerrit's up too, not just its key | 22:24 |
*** yamamoto has joined #openstack-infra | 22:25 | |
fungi | if we do password generation in addition to that, we can also upgrade it past gerrit 2.13 at that point, i think | 22:25 |
fungi | but that might be tricky if the password string is hardcoded into rest api tests | 22:26 |
clarkb | fungi: I think you can set a value if privileged? | 22:29 |
clarkb | whihc would allow you to keep using a constsant | 22:29 |
fungi | oh, yeah maybe so in that case | 22:29 |
*** d34dh0r53 has quit IRC | 22:31 | |
*** armax has quit IRC | 22:43 | |
*** rcernin has quit IRC | 22:47 | |
*** rcernin has joined #openstack-infra | 23:04 | |
*** hashar has quit IRC | 23:13 | |
*** rcernin has quit IRC | 23:19 | |
tbachman | I just had a weird infra issue. | 23:19 |
tbachman | It looks like the gate somehow picked up an old version of neutron stable/train | 23:19 |
tbachman | The merge job for our group-based-policy stable/train patch failed. In looking over the failure (see https://b22f38c2e6d0d5fcacd8-75456213d5f2cff92fed567c22cafaae.ssl.cf1.rackcdn.com/772723/4/gate/openstack-tox-py27/cf68165/testr_results.html), it shows an exception that is missing the code that was merged here; https://review.opendev.org/c/openstack/neutron/+/771599/2/neutron/db/l3_db.py#554 | 23:21 |
tbachman | I rechecked it - just curious if it happens again | 23:21 |
clarkb | tbachman: looks like your unittest job was for a x/group-based-policy stable/train change. How is it pulling in neutron? | 23:25 |
tbachman | clarkb: we’re a consumer of neutron. | 23:25 |
clarkb | tbachman: that behavior is likely going to come down to how your job is installed neutron | 23:25 |
fungi | yeah, but how does the job install neutron | 23:25 |
clarkb | right | 23:25 |
* tbachman goes to get link | 23:25 | |
tbachman | clarkb: note that it passed the verify | 23:25 |
tbachman | just a sec... | 23:25 |
fungi | like from pypi or a remote git ref or using the local checkout zuul provides or...? | 23:26 |
tbachman | clarkb: fungi: https://opendev.org/x/group-based-policy/src/branch/stable/train/test-requirements.txt#L9 | 23:26 |
clarkb | ya thats just going to install whatever is latest on pypi | 23:26 |
tbachman | so, would you expect it to always pass or always fail? | 23:27 |
tbachman | b/c it passed the verify the day before | 23:27 |
fungi | whatever's latest on pypi which is supported by your python interpreter (assuming new enough pip to use python_requires metadata) and potentially filtered by a constraints file if you're applying one | 23:27 |
clarkb | tbachman: I mean that will depend on whether or not the neutron code you're pulling works (and a bunch of other factors) | 23:27 |
clarkb | tbachman: it might be worthwhile to look at both the check and gate log and see what pip reports it installed for neutron | 23:28 |
tbachman | clarkb: ack | 23:28 |
* tbachman goes digging | 23:28 | |
fungi | a link to the build result would help, since we can see the exact command which is being used to install neutron | 23:28 |
clarkb | neutron==15.3.1 <- i what your gate example above installed according to tox | 23:29 |
clarkb | fungi: https://b22f38c2e6d0d5fcacd8-75456213d5f2cff92fed567c22cafaae.ssl.cf1.rackcdn.com/772723/4/gate/openstack-tox-py27/cf68165/job-output.txt | 23:29 |
fungi | oh, i see you linked one, checking it now | 23:29 |
tbachman | https://7f1d3bc811eac15dd3d0-a12e67e84744b622e6a13b507a2faa27.ssl.cf1.rackcdn.com/772723/4/gate/openstack-tox-py36/b77aa77/job-output.txt | 23:31 |
tbachman | It also shows 15.3.1 | 23:31 |
clarkb | note that one of those jobs is python2.7 and the othe ris 3.6 | 23:31 |
clarkb | which may also be related if it is a python 2 or 3 compatibility issue | 23:32 |
tbachman | Yeah - I’m finding the pass for 3.6 | 23:32 |
tbachman | ah | 23:32 |
tbachman | so, the pass in py36 was neutron==15.3.0, | 23:32 |
tbachman | hmmm | 23:32 |
tbachman | dang | 23:32 |
fungi | yeah, 15.3.1 seems to be the newest release of neutron for train | 23:32 |
tbachman | so I’m just guessing here that 15.3.0 doesn’t have the patch that broke us, 15.3.1 does, and 15.3.2 hasn’t been made yet (and would have the patch that fixes it again) | 23:33 |
fungi | looks like that change merged after 15.3.1 | 23:33 |
tbachman | fungi: thanks! | 23:34 |
fungi | since `git tag --contains 1b8f449` returns nothing for me | 23:34 |
tbachman | I guess I have to wait for 15.3.2 then | 23:34 |
tbachman | or change how we pull in neutron | 23:34 |
fungi | so, yeah, you could push up a release request for neutron stable/train and get the neutron release liaison to ack it | 23:35 |
tbachman | (until they publish 15.3.2 to pip) | 23:35 |
fungi | that would probably not happen until monday at the earliest though | 23:35 |
tbachman | k | 23:35 |
tbachman | I guess I’d assumed that publishing to pip was part of the merge gates | 23:36 |
fungi | but making a release request in openstack is at least just a matter of running a quick script in openstack/releases and proposing the resulting diff as a change | 23:36 |
clarkb | openstack only publishes releases to pypi, not every change | 23:36 |
tbachman | clarkb: thx! | 23:36 |
tbachman | k | 23:36 |
* tbachman goes to google how to create a release request | 23:37 | |
tbachman | clarkb: fungi: thanks for your help | 23:37 |
tbachman | ! | 23:37 |
tbachman | (and quick response) | 23:37 |
fungi | tbachman: https://releases.openstack.org/reference/using.html#requesting-a-release | 23:37 |
* fungi is a meat-based search engine | 23:38 | |
tbachman | lol | 23:38 |
tbachman | fungi: I was doing the same! | 23:38 |
tbachman | (found the same link) | 23:38 |
fungi | i would ignore the part where it says "The stable maintenance team, PTL, or release liaison for a project may request a release..." | 23:39 |
fungi | they really only need to +1 it | 23:39 |
fungi | anyone technically can "request" it | 23:39 |
tbachman | k | 23:39 |
fungi | the release team even has a special job which runs every time someone leaves a comment to check whether it was from a valid liaison and flags it for them | 23:40 |
fungi | so they can tell at a glance whether the request has been okayed | 23:40 |
tbachman | k | 23:40 |
* tbachman runs off to eat | 23:40 | |
tbachman | Thanks again! | 23:41 |
* fungi has pushed release requests plenty of times and then gone to beg for a liaison +1 in hopes that would be faster than asking them to find time to push up the request | 23:41 | |
*** zzzeek has quit IRC | 23:48 | |
*** zzzeek has joined #openstack-infra | 23:50 | |
*** cloudnull has quit IRC | 23:52 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!