*** odyssey4me is now known as Guest945 | 01:22 | |
*** rlandy|bbl is now known as rlandy | 01:49 | |
*** odyssey4me is now known as Guest955 | 01:53 | |
*** ykarel|away is now known as ykarel | 04:31 | |
*** chandankumar is now known as chkumar|rover | 05:21 | |
*** iurygregory_ is now known as iurygregory | 06:38 | |
*** rpittau|afk is now known as rpittau | 07:31 | |
*** dmellado_ is now known as dmellado | 07:41 | |
opendevreview | Vishal Manchanda proposed openstack/project-config master: Retire django-openstack-auth https://review.opendev.org/c/openstack/project-config/+/800459 | 08:07 |
---|---|---|
*** bhagyashris_ is now known as bhagyashris|ruck | 08:24 | |
*** ykarel is now known as ykarel|lunch | 09:06 | |
*** odyssey4me is now known as Guest1011 | 09:20 | |
opendevreview | Matthias Runge proposed openstack/project-config master: Enable deleting left-overs of panko deprecation https://review.opendev.org/c/openstack/project-config/+/800241 | 09:56 |
*** odyssey4me is now known as Guest1025 | 10:06 | |
*** ykarel|lunch is now known as ykarel | 11:11 | |
opendevreview | Tristan Cacqueray proposed openstack/project-config master: gerritbot: add matrix configuration https://review.opendev.org/c/openstack/project-config/+/801063 | 13:52 |
opendevreview | Takashi Kajinami proposed openstack/project-config master: tripleo-common-tempest-plugin - Step 2: End project Gating https://review.opendev.org/c/openstack/project-config/+/800154 | 13:59 |
opendevreview | Takashi Kajinami proposed openstack/project-config master: tripleo-common-tempest-plugin - Step 4: Remove Project https://review.opendev.org/c/openstack/project-config/+/800157 | 13:59 |
*** rpittau is now known as rpittau|afk | 14:08 | |
*** ykarel is now known as ykarel|away | 14:46 | |
opendevreview | Tristan Cacqueray proposed openstack/project-config master: gerritbot: add matrix configuration https://review.opendev.org/c/openstack/project-config/+/801063 | 14:59 |
opendevreview | Tristan Cacqueray proposed openstack/project-config master: gerritbot: add matrix configuration https://review.opendev.org/c/openstack/project-config/+/801063 | 15:22 |
opendevreview | Tristan Cacqueray proposed openstack/project-config master: gerritbot: add matrix configuration https://review.opendev.org/c/openstack/project-config/+/801063 | 15:33 |
opendevreview | Merged openstack/devstack-gate master: Moving IRC network reference to OFTC https://review.opendev.org/c/openstack/devstack-gate/+/800134 | 15:43 |
opendevreview | Vishal Manchanda proposed openstack/project-config master: Retire django-openstack-auth https://review.opendev.org/c/openstack/project-config/+/800459 | 16:43 |
opendevreview | Vishal Manchanda proposed openstack/project-config master: Retire django-openstack-auth https://review.opendev.org/c/openstack/project-config/+/800532 | 16:43 |
melwitt | I think I'm noticing that the launchpad bug update that used to change "Fix Committed" to "Fix Released" after a release was done for the branch isn't happening anymore. it looks like it should be this https://opendev.org/opendev/jeepyb/src/branch/master/jeepyb/cmd/update_bug.py#L187-L188 | 22:33 |
melwitt | does anyone have any idea how/why that might not be working right anymore? | 22:34 |
clarkb | melwitt: not off the top of my head. Though do we use proposed/* branches anymore? | 22:41 |
clarkb | s/anymore/anywhere/ | 22:41 |
melwitt | I am not familiar with the proposed/* thing, sorry | 22:41 |
melwitt | that is why this part doesn't work anymore probably? | 22:41 |
clarkb | ya I think that was handling a very specific branch setup. I suspect that https://opendev.org/opendev/jeepyb/src/branch/master/jeepyb/cmd/update_bug.py#L180-L182 maybe the problem | 22:42 |
melwitt | if not, I'm not yet sure what we need to look for to signal a release happened | 22:42 |
melwitt | I _think_ that part works because I have seen bugs go to Fix Released on master branch fixes | 22:43 |
melwitt | what I find doesn't work is when a stable branch fix that is Fix Committed (merged but not released) becomes released (the openstack/releases patch merges), it does not change to "Fix Released" anymore and it used to | 22:43 |
clarkb | ah | 22:44 |
clarkb | then it is probably because that code doesn't handle stable/* branches only proposed/ and master | 22:44 |
clarkb | I'm trying to remember what proposed/ was/is for and drawing a blank | 22:46 |
clarkb | I double checked the delay-release flag and only some charms and a couple of x/ repos seem to set it | 22:48 |
melwitt | ok, thanks clarkb I'll do some digging based on those tidbits | 22:55 |
melwitt | yeah delay-release flag is ok because the logic is "if (not p.is_delay_release(args.project)" which is true for everything, so that part is working fine | 22:57 |
melwitt | it's this proposed/* business that needs an update. just have to find to what | 22:57 |
clarkb | I think you want it to also process on stable/* branches | 22:58 |
clarkb | but there is no stable/* condition | 22:58 |
melwitt | I think this proposed thing had to do with releases | 22:59 |
melwitt | maybe releases used to get merged to a proposed/ branch or something | 22:59 |
melwitt | because we don't want to set Fix Released on a stable/branch bug fix until the release happens, not at patch merge time | 23:00 |
melwitt | oh but this is checking if it's Fix Committed | 23:01 |
clarkb | the gerrit events only fire when patches merge though | 23:01 |
clarkb | if you want to wait until the release is tagged on the stable branch then you might need to use a different tool for that (somethin triggered by the release team's jobs/tools maybe) | 23:01 |
melwitt | yeah ... so that's why I keep thinking this was watching some kind of release patch process that used to be | 23:02 |
melwitt | I'll go back through my email and see what it used to look like, I can't remember if the "This issue was fixed in the openstack/nova N release." was co-located with the Fix Committed => Fix Released change or not | 23:03 |
clarkb | If it wasn't and you don't want ot change that then running some sort of updating as part of the release tooling makes sense | 23:06 |
clarkb | separately I think we're tryingto push more of that into zuul if we can then we don't need to rely on image updates on the gerrit side to make these changes too | 23:06 |
melwitt | yeah, I'm just not sure whether changing that string to "stable/" would cause things to get marked as Fix Released too early, I was thinking it would but I'm also tired so maybe I'm way off | 23:07 |
melwitt | ack | 23:07 |
clarkb | melwitt: it would switch it at change merge time if the bug was already marked fix released | 23:08 |
melwitt | yeah.. it's weird because the first go round, it would mark the bug as Fix Committed for say, stable/train. so I can't imagine what patch-merged event would happen again related to the same bug | 23:10 |
melwitt | i.e. I am yet to understand how this used to work | 23:11 |
melwitt | because whatever this was saw a patch-merged event and was able to find the bug already in fix committed state and then change it to fix released | 23:11 |
clarkb | maybe there was some end of release dummy commit that set all the bug numbers on it that got merged once upon a time | 23:12 |
melwitt | yeah, I'm wondering that | 23:13 |
melwitt | interesting https://review.opendev.org/q/branch:%255Eproposed.* | 23:13 |
melwitt | I'll look more at it later, curiosity | 23:14 |
melwitt | have to run for now. thanks for the ideas o/ | 23:15 |
clarkb | gl! | 23:18 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!