| *** ykarel|away is now known as ykarel | 04:29 | |
| *** jpodivin_ is now known as jpodivin | 06:43 | |
| *** ykarel is now known as ykarel|lunch | 09:39 | |
| *** jpena|off is now known as jpena | 10:10 | |
| *** rlandy is now known as rlandy|ruck | 10:32 | |
| *** ykarel|lunch is now known as ykarel | 10:54 | |
| opendevreview | Merged openstack/project-config master: kolla-cli: end gating for retirement https://review.opendev.org/c/openstack/project-config/+/814580 | 11:03 |
|---|---|---|
| *** jcapitao is now known as jcapitao_lunch | 11:18 | |
| opendevreview | daniel.pawlik proposed openstack/ci-log-processing master: DNM Initial project commit https://review.opendev.org/c/openstack/ci-log-processing/+/815604 | 11:25 |
| *** jpena is now known as jpena|lunch | 12:27 | |
| *** ykarel is now known as ykarel|afk | 12:33 | |
| *** jcapitao_lunch is now known as jcapitao | 12:38 | |
| *** jpena|lunch is now known as jpena | 13:26 | |
| opendevreview | daniel.pawlik proposed openstack/ci-log-processing master: DNM Initial project commit https://review.opendev.org/c/openstack/ci-log-processing/+/815604 | 14:09 |
| *** ykarel|afk is now known as ykarel | 14:29 | |
| *** ykarel is now known as ykarel|away | 14:42 | |
| opendevreview | Clark Boylan proposed openstack/pbr master: Add a PEP517 interface https://review.opendev.org/c/openstack/pbr/+/797898 | 15:29 |
| clarkb | stephenfin: ^ tahnks for the review. That also adds some docs as I realized we needed those when adding the release note | 15:30 |
| clarkb | fungi: ^ you may be interested in that as well | 15:30 |
| *** sshnaidm_ is now known as sshnaidm | 15:49 | |
| efried | Hey folks, I've got a colleague who's looking for some general support with zuul. What would be the best place/mechanism for him to engage? | 15:55 |
| efried | (To be clear: he's not in the OpenStack world.) | 15:55 |
| fungi | efried: the #zuul:matrix.org channel on matrix, or the zuul-discuss@lists.zuul-ci.org mailing list | 16:03 |
| fungi | efried: you could also send them to https://zuul-ci.org/start | 16:03 |
| fungi | efried: er, sorry, it's the #zuul:opendev.org matrix channel | 16:04 |
| fungi | efried: https://zuul-ci.org/community.html | 16:05 |
| efried | Thanks Jeremy! | 16:13 |
| fungi | yw | 16:13 |
| opendevreview | daniel.pawlik proposed openstack/ci-log-processing master: DNM Initial project commit https://review.opendev.org/c/openstack/ci-log-processing/+/815604 | 16:28 |
| fungi | dpawlik: it passed! | 16:43 |
| dpawlik | fungi: yeah, one more commit to push with test and should be ready to review | 16:44 |
| dpawlik | fungi: there is a PS made by tristanC that is using "Dependency injection" and I'm very curious wdyt about such approach: https://review.opendev.org/c/openstack/ci-log-processing/+/815969 | 16:45 |
| fungi | note that unless you start out with noop jobs in the first change and add your real jobs in the later changes, you're not going to be able to merge those except by squashing into a single commit, since zuul will refuse otherwise | 16:45 |
| dpawlik | fungi: yup, I know :) | 16:46 |
| fungi | i don't understand the dependency injection change, probably because it lacks any real commit message to provide context about what it's trying to accomplish | 16:47 |
| dpawlik | fungi: there is also another approach to use it with "classic" way by using mock, magic mock etc | 16:47 |
| dpawlik | fungi: can be, let me rebase it | 16:48 |
| fungi | it's a large enough change that if i just stare at it without some idea of what the goal is, i don't have enough background to guess if it's doing so effectively | 16:48 |
| fungi | to be clear, i'm not much of a classical software developer, more like a sysadmin who sometimes scripts things, so even mock-based testing is a bit for me to wrap my head around | 16:49 |
| fungi | i can attempt to review such things, but only when they come with clear explanations | 16:49 |
| clarkb | I think there should be two major considerations when building out this tooling (informed by the existing unmaintained version). 1) This software needs to be maintainable. Things like starting as a tool that gets deployed by config management instead of config management role/module that deploys a tool should help with that. 2) It should be something that openstack developers | 16:56 |
| clarkb | in particular are comfortable contributing to. They are the primary users and as such will be the primary pool of potential contributors | 16:56 |
| clarkb | given ^ my opinion is that you are better of sticking to openstack norms for building this out. | 16:57 |
| fungi | yeah, if i were to try to evaluate two potential implementations, my questions would be 1. which implementation is easier to read and understand? 2. which will be simpler to debug when there are errors? 3. which requires more effort to extend with future test additions? | 16:59 |
| opendevreview | daniel.pawlik proposed openstack/ci-log-processing master: DNM demonstrate dependency injection testing technique https://review.opendev.org/c/openstack/ci-log-processing/+/815969 | 17:03 |
| dpawlik | imho test will be very helpful to avoid adding breaking changes. If I understand correctly, this tool needs to be working correctly all the time...Otherwise, developers may have issue to find where is a bug when opensearch will not have logs... | 17:05 |
| dpawlik | I like tristanC approach, but I'm not familiar with such tests. Tomorrow I will propose new test base on mock - more common for python world | 17:07 |
| dpawlik | patchset seems to be large, I will split it to few small | 17:07 |
| *** jpena is now known as jpena|off | 17:32 | |
| *** ianw_pto is now known as ianw | 19:00 | |
| mwhahaha | is zuul status page erroring for anyone else or just me? | 19:37 |
| fungi | mwhahaha: it's being restarted should return momentarily | 19:38 |
| mwhahaha | k | 19:38 |
| rlandy|ruck | fungi: hi - will our jobs be automatically queued again or should we recheck them? | 19:50 |
| rlandy|ruck | ie: those in gate | 19:50 |
| fungi | rlandy|ruck: they will be reenqueued | 19:50 |
| rlandy|ruck | great - thanks | 19:50 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!