opendevreview | Merged openstack/project-config master: Add "Review-Priority" label to horizon project https://review.opendev.org/c/openstack/project-config/+/821934 | 00:13 |
---|---|---|
*** rlandy|ruck is now known as rlandy|out | 00:32 | |
*** fressi_ is now known as fressi | 04:00 | |
*** ykarel__ is now known as ykarel | 05:39 | |
*** amoralej|off is now known as amoralej | 08:02 | |
*** jpena|off is now known as jpena | 08:35 | |
*** rlandy_ is now known as rlandy|ruck | 11:14 | |
*** dviroel_ is now known as dviroel | 11:19 | |
*** jcapitao is now known as jcapitao_lunch | 12:11 | |
opendevreview | Merged openstack/pbr master: Use context blocks for open() calls in packaging https://review.opendev.org/c/openstack/pbr/+/818622 | 13:03 |
*** jcapitao_lunch is now known as jcapitao | 13:18 | |
*** amoralej is now known as amoralej|lunch | 13:40 | |
*** amoralej|lunch is now known as amoralej | 14:19 | |
noonedeadpunk | can I ask for hold on linters check for https://review.opendev.org/c/openstack/openstack-ansible/+/795690 ? Or just force-merge it? :D | 14:57 |
fungi | noonedeadpunk: can you clarify why holding a node for a build failure would be equivalent to bypassing testing? | 15:01 |
frickler | noonedeadpunk: if you don't actually care about the job, you could also just remove it from your zuul config | 15:01 |
frickler | fungi: I'm assuming the idea is mainly just to finish off that old branch | 15:02 |
noonedeadpunk | well, I believe it's failing because branches got dropped | 15:02 |
noonedeadpunk | for osa roles | 15:02 |
noonedeadpunk | well, yeah, but that's kind of the only one that makes any sense and any patches after this one won't be allowed anyway | 15:03 |
fungi | yes, you can remove failing jobs from that branch, or relpace all the jobs on that branch with a noop | 15:03 |
noonedeadpunk | well, if we're to vote on this patch again, it better to be meaningfull :D | 15:05 |
noonedeadpunk | and the issue not with check but likely with zuul getting wrong repo | 15:05 |
fungi | right now zuul.d/project.yaml on that branch includes a bunch of templates, looks like you could remove all of then except publish-openstack-docs-pti | 15:06 |
noonedeadpunk | so it has different statement https://opendev.org/openstack/ansible-hardening/src/tag/ocata-eol/tasks/main.yml#L55 comparing to error raised https://zuul.opendev.org/t/openstack/build/7846dee1ba83453ba16b700e44d1830e/log/job-output.txt#2207 while checkout seems to be done correctly | 15:06 |
fungi | noonedeadpunk: probably some other project it's pulling in used to have a stable/ocata branch but no longer does due to getting eol'd | 15:07 |
noonedeadpunk | yeah, sounds highly likely... | 15:07 |
noonedeadpunk | well, okay, we can drop tests then.... | 15:08 |
noonedeadpunk | I just wanted to finish this faster, and don't get another round of votes :) | 15:08 |
noonedeadpunk | oh, that's helpful actually | 15:09 |
*** dviroel is now known as dviroel|lunch | 15:09 | |
fungi | noonedeadpunk: i've pushed a test at 822500 to see if it will solve the issue, and if so you could rebase onto that which should preserve all the votes except the approval | 15:09 |
noonedeadpunk | ecept it should be probably done for stable/ocata not master? | 15:09 |
fungi | huh, i thought i checked out stable/ocata | 15:10 |
fungi | just a sec, i'll abandon that one | 15:10 |
fungi | noonedeadpunk: okay, sorry about that, 822501 now | 15:14 |
*** akahat|ruck is now known as akahat|dinner | 15:18 | |
*** akahat|dinner is now known as akahat|ruck | 15:45 | |
*** dviroel|lunch is now known as dviroel | 16:07 | |
*** sshnaidm is now known as sshnaidm|afk | 17:34 | |
*** jpena is now known as jpena|off | 17:44 | |
*** jcapitao is now known as jcapitao_off | 18:00 | |
*** amoralej is now known as amoralej|off | 18:02 | |
*** gmann is now known as gmann_afk | 19:51 | |
*** dviroel is now known as dviroel|afk | 19:53 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!