| *** dviroel|afk is now known as dviroel | 00:07 | |
| *** rlandy is now known as rlandy|out | 01:42 | |
| *** ysandeep|out is now known as ysandeep | 02:09 | |
| *** vishalmanchanda_ is now known as vishalmanchanda | 06:12 | |
| *** masayukig_ is now known as masayukig | 06:12 | |
| *** philroche_ is now known as philroche | 06:12 | |
| *** rpioso_ is now known as rpioso | 06:12 | |
| *** carloss_ is now known as carloss | 06:12 | |
| *** arne_wiebalck_ is now known as arne_wiebalck | 06:19 | |
| opendevreview | Ian Wienand proposed openstack/openstack-zuul-jobs master: [dnm] testing grafana https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/847128 | 06:58 |
|---|---|---|
| opendevreview | Ian Wienand proposed openstack/project-config master: [dnm] testing grafana https://review.opendev.org/c/openstack/project-config/+/847129 | 07:00 |
| *** ysandeep is now known as ysandeep|afk | 07:02 | |
| opendevreview | Ian Wienand proposed openstack/openstack-zuul-jobs master: [dnm] testing grafana https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/847128 | 07:16 |
| *** jpena|off is now known as jpena | 07:18 | |
| opendevreview | Ian Wienand proposed openstack/openstack-zuul-jobs master: [dnm] testing grafana https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/847128 | 07:35 |
| opendevreview | Ian Wienand proposed openstack/openstack-zuul-jobs master: [dnm] testing grafana https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/847128 | 07:52 |
| opendevreview | Ian Wienand proposed openstack/openstack-zuul-jobs master: [dnm] testing grafana https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/847128 | 08:22 |
| opendevreview | Artem Goncharov proposed openstack/project-config master: Add hashicorp-vault-plugin-secrets project https://review.opendev.org/c/openstack/project-config/+/847135 | 08:48 |
| opendevreview | Artem Goncharov proposed openstack/project-config master: Add hashicorp-vault-plugin-secrets project https://review.opendev.org/c/openstack/project-config/+/847135 | 09:05 |
| *** ysandeep|afk is now known as ysandeep | 09:09 | |
| opendevreview | Ian Wienand proposed openstack/openstack-zuul-jobs master: [dnm] testing grafana https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/847128 | 10:16 |
| *** rlandy__ is now known as rlandy | 10:34 | |
| opendevreview | Ian Wienand proposed openstack/openstack-zuul-jobs master: [dnm] testing grafana https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/847128 | 11:02 |
| *** sshnaidm_ is now known as sshnaidm | 11:05 | |
| opendevreview | Ian Wienand proposed openstack/openstack-zuul-jobs master: [dnm] testing grafana https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/847128 | 11:20 |
| *** dviroel__ is now known as dviroel | 11:28 | |
| *** ysandeep is now known as ysandeep|afk | 12:23 | |
| *** ysandeep|afk is now known as ysandeep | 13:22 | |
| *** dasm|off is now known as dasm | 13:47 | |
| *** dviroel is now known as dviroel|lunch | 14:59 | |
| *** ysandeep is now known as ysandeep|out | 15:00 | |
| opendevreview | Ade Lee proposed openstack/openstack-zuul-jobs master: Add nslookup_target to fips jobs https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/847193 | 16:12 |
| sean-k-mooney | clarkb: fungi: for what its worth i have recently had to use github and pull requests | 16:28 |
| sean-k-mooney | and it was painful | 16:28 |
| sean-k-mooney | the code review process | 16:28 |
| sean-k-mooney | and inablity to do depends on | 16:28 |
| sean-k-mooney | was such a regresion vs gerrirt and zuul | 16:29 |
| sean-k-mooney | i know not everyone will agree with that but even if we allowed some project to use a github based workflow i would stongly push for offical project in the governac repo to no support github or gitea based prs | 16:30 |
| sean-k-mooney | so just wanted to say im supproted of the opinions you have expressed on the external project thread | 16:30 |
| sean-k-mooney | if this is an external project using openinfra for testing via zuul | 16:31 |
| sean-k-mooney | thatne prs shoudl work fine | 16:31 |
| sean-k-mooney | since zuul supprot that | 16:31 |
| *** dviroel|lunch is now known as dviroel | 16:31 | |
| clarkb | zuul supports that but we just can't not at the current level of staffing | 16:31 |
| clarkb | we tried for a while and spun our wheels a bunch and it was a waste of effort :/ | 16:31 |
| sean-k-mooney | but if its an openstack or openinfra hosted project i agree that gerrit is a commonality we shoudl preserve | 16:31 |
| sean-k-mooney | ack | 16:32 |
| clarkb | but ya I too tend to prefer the gerrit code review workflow, but wanted to avoid getting into that too much as it is highly subjective | 16:32 |
| sean-k-mooney | well i dont say this often enough but thansk for coninuting to maintian the infra ye have built that we so hevialy rely on | 16:34 |
| clarkb | you're welcome. It is apprciated :) | 16:35 |
| clarkb | out of curiousity did you notice we upgraded zuul a couple of days ago? We joked that it seemed no one noticed in our meeting yesterday | 16:35 |
| clarkb | er not zuul. | 16:35 |
| clarkb | Gerrit | 16:35 |
| sean-k-mooney | gerrit no didnt notice | 16:36 |
| sean-k-mooney | any nice feature i should know about | 16:36 |
| clarkb | nothing major. There are a few small UI tweaks. Some I'm not completely sold on like word highlighting in the diff view if you hover over a word with your mouse pointer | 16:36 |
| sean-k-mooney | ah i saw that but didnt notice it was new | 16:37 |
| clarkb | I think they made some performance improvements through the addition of new caches | 16:37 |
| clarkb | so you may notice things are a little quicker? | 16:37 |
| sean-k-mooney | i assume it was just part of the normal syntax highlihgt | 16:37 |
| *** jpena is now known as jpena|off | 16:37 | |
| sean-k-mooney | i havent done much code review htis week but ill let you know | 16:38 |
| sean-k-mooney | it generally felt pretty ok before | 16:38 |
| sean-k-mooney | so if its faster that also nice | 16:38 |
| fungi | i suspect the intention is that when you hover over a function call, you'll see all other calls and possibly the definition also highlighted if within the same file | 16:38 |
| fungi | er, well, within the same diff/context anyway | 16:38 |
| sean-k-mooney | yep | 16:39 |
| sean-k-mooney | but since we have only a few lines of context | 16:39 |
| sean-k-mooney | and our files are massive | 16:39 |
| fungi | though i too am not sure how useful of a feature it is | 16:39 |
| sean-k-mooney | im not sure how useful that will be | 16:39 |
| sean-k-mooney | any change there is a way to disable the unresovvle comments feature yet | 16:39 |
| fungi | maybe it's very useful for those sorts of java projects which use a separate file for every single function | 16:39 |
| sean-k-mooney | we really need to split up the nova libvirt driver its been on our todo list for years | 16:40 |
| clarkb | no they haven't made changes to the unresolvable comments stuff | 16:40 |
| fungi | sean-k-mooney: i haven't seen any progress on that yet, and honestly doubt there will be unless someone with similar concerns rolls up their sleeves and proposes a working patch | 16:40 |
| sean-k-mooney | its currently sitting at 12187 lines | 16:41 |
| sean-k-mooney | and the unit test file is double that | 16:41 |
| fungi | yikes, that's a pretty large file | 16:41 |
| sean-k-mooney | emacs warns me when opening it | 16:41 |
| sean-k-mooney | it totally breaks git blame on github/gitia | 16:42 |
| sean-k-mooney | which si proably fair to be honest | 16:42 |
| sean-k-mooney | but ya i guess unless i or other get annowed enough to go fix it it probaly wont be fixed | 16:43 |
| sean-k-mooney | it irratates me but not enough to fix it | 16:43 |
| fungi | sean-k-mooney: one alternative solution i was brainstorming was a cli option in git-review to mark all open comments resolved when uploading (obviously you'd probably not pass it when pushing something like a rebase, so doesn't make as much sense as a config option) | 16:49 |
| fungi | that would at least save you needing to go through and mark all comments "done" or whatever | 16:50 |
| sean-k-mooney | or a zuul jobs ot mark all open commnents as resolve after its merged | 16:51 |
| sean-k-mooney | ^ is what i was orginially thinking | 16:51 |
| sean-k-mooney | since zuul can do line level comments | 16:51 |
| fungi | i'm not as keen on doing something project-wide, but a change uploader asserting that their updated revision addresses all open comments seems like a reasonable compromise while still maintaining the spirit of the feature at least | 16:53 |
| sean-k-mooney | maybe i currntly just to a comment review pass and code review pass | 16:54 |
| sean-k-mooney | anyway i got a tooth removed and the anestic is wearing off so calling it a day and going to lie down for a bit | 16:54 |
| sean-k-mooney | o/ | 16:54 |
| fungi | good luck! | 16:59 |
| *** dviroel is now known as dviroel|afk | 19:48 | |
| *** timburke_ is now known as timburke | 20:39 | |
| *** dviroel|afk is now known as dviroel | 20:43 | |
| *** dviroel is now known as dviroel|afk | 21:22 | |
| *** rlandy is now known as rlandy|bbl | 22:30 | |
| *** dasm is now known as dasm|off | 23:03 | |
| opendevreview | Samuel Walladge proposed openstack/project-config master: Add Cinder IBM Storwize charm https://review.opendev.org/c/openstack/project-config/+/846899 | 23:07 |
| opendevreview | Samuel Walladge proposed openstack/project-config master: Add Cinder Dell EMC PowerStore charm https://review.opendev.org/c/openstack/project-config/+/846888 | 23:13 |
| opendevreview | Ian Wienand proposed openstack/openstack-zuul-jobs master: [dnm] testing grafana https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/847128 | 23:25 |
| opendevreview | Ian Wienand proposed openstack/openstack-zuul-jobs master: [dnm] testing grafana https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/847128 | 23:31 |
| opendevreview | Ian Wienand proposed openstack/openstack-zuul-jobs master: [dnm] testing grafana https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/847128 | 23:35 |
| opendevreview | Merged openstack/project-config master: Add Cinder IBM Storwize charm https://review.opendev.org/c/openstack/project-config/+/846899 | 23:39 |
| opendevreview | Ian Wienand proposed openstack/openstack-zuul-jobs master: [dnm] testing grafana https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/847128 | 23:39 |
| opendevreview | Ian Wienand proposed openstack/openstack-zuul-jobs master: [dnm] testing grafana https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/847128 | 23:51 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!