| *** yadnesh|away is now known as yadnesh | 04:20 | |
| *** yadnesh is now known as yadnesh|afk | 07:30 | |
| *** yadnesh|afk is now known as yadnesh | 08:02 | |
| *** jpena|off is now known as jpena | 08:42 | |
| opendevreview | dpawlik proposed openstack/ci-log-processing master: DNM Add Opensearch dashboards backup script https://review.opendev.org/c/openstack/ci-log-processing/+/860811 | 09:41 |
|---|---|---|
| *** soniya29 is now known as soniya29|afk | 09:57 | |
| opendevreview | Hervé Beraud proposed openstack/reviewday master: Remove python-dev from bindep https://review.opendev.org/c/openstack/reviewday/+/863848 | 10:06 |
| *** dviroel|out is now known as dviroel | 10:16 | |
| opendevreview | dpawlik proposed openstack/ci-log-processing master: DNM Add Opensearch dashboards backup script https://review.opendev.org/c/openstack/ci-log-processing/+/860811 | 10:20 |
| *** diablo_rojo_phone is now known as Guest702 | 10:39 | |
| ade_lee_ | fungi, clarkb hey guys, I was going to check to see how to set up a fips enabled ubuntu job | 10:40 |
| ade_lee_ | fungi, clarkb ie. how to use the subscription info we have | 10:41 |
| fungi | ade_lee_: i put some basics in the commit message of https://review.opendev.org/861457 though we'll need that reviewed first and merged of course | 12:13 |
| ade_lee_ | fungi, ah - ok - that makes sense. Does that patch need to be merged first, or can I use it as a depends-on for a test fips patch? | 12:17 |
| fungi | ade_lee_: it'll need merging first. changes to trusted config projects can't be used speculatively, since that would create some pretty significant security issues | 12:20 |
| fungi | thankfully, zuul outright disallows it | 12:21 |
| ade_lee_ | fungi, ack -- so who do we need to add/poke as reviewers? | 12:22 |
| fungi | yes, i expect it got overlooked in the midst of ptg activity | 12:22 |
| *** yadnesh is now known as yadnesh|afk | 12:32 | |
| *** yadnesh|afk is now known as yadnesh|away | 13:09 | |
| *** dasm|off is now known as dasm | 14:11 | |
| opendevreview | Dmitriy Rabotyagov proposed openstack/project-config master: Add another role for Zookeeper installation https://review.opendev.org/c/openstack/project-config/+/863158 | 14:22 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/project-config master: Add os_skyline repo to CI https://review.opendev.org/c/openstack/project-config/+/863167 | 14:23 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/project-config master: Add repository for Skyline installation by OpenStack-Ansible https://review.opendev.org/c/openstack/project-config/+/863165 | 14:23 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/project-config master: Add os_skyline repo to CI https://review.opendev.org/c/openstack/project-config/+/863167 | 14:23 |
| jm1 | dtantsur: hello to Düsseldorf :D could you please review this micro patch when you get time? https://review.opendev.org/c/openstack/bifrost/+/863816 | 14:26 |
| *** dviroel is now known as dviroel|lunch | 15:08 | |
| *** sfinucan is now known as stephenfin | 16:10 | |
| *** dviroel|lunch is now known as dviroel | 16:35 | |
| dtantsur | jm1: on it! | 16:36 |
| dtantsur | lgtm, thank you! | 16:41 |
| JayF | tm1: 🛬 | 16:46 |
| JayF | jm1: 🛬 | 16:46 |
| * frickler always needs to google such emojis in order to understand them. and google in this case is an alias for duckduckgo | 17:12 | |
| JayF | landing-airplane :D | 17:20 |
| *** jpena is now known as jpena|off | 17:37 | |
| jm1 | dtantsur, JayF: niiiiice, thank you :D | 18:41 |
| *** dviroel is now known as dviroel|afk | 19:40 | |
| JayF | Have we considered giving Toggle-Wip-State permissions to *-core teams generally? | 20:21 |
| JayF | I'm curious if it was considered and rejected, or just with WIP being a newerish feature nobody has even thought about it yet | 20:21 |
| JayF | cc: johnsom | 20:21 |
| fungi | probably the latter. i think the permission may have been added more recently than the flag too | 20:24 |
| JayF | Is there a process to follow to get this stuff going? | 20:24 |
| JayF | Like, I think it makes sense. Just a mailing list thread? Or something heavier? | 20:24 |
| johnsom | Yeah, it would be super helpful as I have had a few patches get stuck with that turned on. | 20:25 |
| johnsom | All I could do is try to track down the author to remove it | 20:25 |
| fungi | i'd just propose an acl change for one or more of ironic's repos and see how it goes, but there's precedent since we already have acls allowing core review teams to set workflow -1 in order to convey similar (they just can't un-set someone else's -1, but that's more a shortcoming of trying to signal it with review labels i think) | 20:26 |
| JayF | I'll do one for ironic | 20:26 |
| JayF | johnsom: you wanna do one for Designate :D | 20:26 |
| johnsom | Yep | 20:27 |
| fungi | you'll need to add it to the allowed keywords list in our gerrit acl linting script if it's not an option we've got in use yet | 20:30 |
| fungi | but you can do that in the same change that updates the acl | 20:30 |
| JayF | right now I'm taking a 101 class in gerrit ACL setup | 20:30 |
| johnsom | Yeah, I haven't had to mess with these in years | 20:31 |
| fungi | the documentation link at the top of the page for review.o.o should get you to the acls info pretty quickly, but let me know if you need a more diretc link | 20:35 |
| opendevreview | Jay Faulkner proposed openstack/project-config master: Allow Ironic cores to toggle WIP state https://review.opendev.org/c/openstack/project-config/+/863931 | 20:42 |
| fungi | JayF: johnsom: in positive news, you're not pioneers. looks like kayobe, kolla and tripleo are already setting that | 20:44 |
| johnsom | Yeah, I see that | 20:44 |
| fungi | so it's already an allowed keyword in our acl linter | 20:45 |
| JayF | Yeah; and trying to "fix" the linter is how I learned I was using the wrong spelling/caps lol | 20:45 |
| fungi | bwahahaha | 20:45 |
| fungi | but yes, inconsistencies like that are one of the reasons we added that linting script | 20:46 |
| JayF | AFAICT the correct spelling of that shows up nowhere in docs | 20:46 |
| JayF | and it doesn't even match the spelling I got back from the ssh server when I tried to use `git review -W` to flip it | 20:46 |
| fungi | if you mean capitalization, i think gerrit may be case-insensitive in those configs, but we enforce specific capitalization and ordering rules so that it's easier to compare them | 20:48 |
| fungi | and to deduplicate them, where it makes sense | 20:49 |
| opendevreview | Michael Johnson proposed openstack/project-config master: Allow Designate cores to toggle WIP state https://review.opendev.org/c/openstack/project-config/+/863932 | 20:50 |
| JayF | ah, okay that's good to know then, although the error was - separated (Toggle-Wip-State was in the error returned vs toggleWipState in the config) | 20:50 |
| fungi | oh, well those may be a difference in cli options for the api vs config options. i have no expectation those would even be remotely similar | 20:51 |
| johnsom | Yeah, those docs are rough, I was going down the expand the war file path and found it | 20:51 |
| JayF | yeah, it just is what it is | 20:51 |
| JayF | typical "everything is documented if you can find it" OSS stuff, that everyone suffers from (including us lol) | 20:52 |
| fungi | unfortunately i'm in a parking lot right now on a netbook which crashes when i try to bring up a graphical browser, so i'll have to look through those when i'm back at the house | 20:52 |
| fungi | look through the docs i mean | 20:52 |
| JayF | There's no rush whatsoever :D | 20:52 |
| fungi | well, i can review the changes quite easily since we already have prior examples anyway | 20:53 |
| JayF | part of the no-rush is I want any other ironic core at all to say "sure, good idea" before I push the button | 20:53 |
| opendevreview | Michael Johnson proposed openstack/project-config master: Allow Octavia cores to toggle WIP state https://review.opendev.org/c/openstack/project-config/+/863934 | 20:55 |
| clarkb | ya I'm fairly certain the toggle is newer than the flag. When we first updated to 3.2 we encouraged people to continue using the -1 workflow vote because you could toggle it | 21:08 |
| clarkb | JayF: johnsom left acouple of thoughts around whether or not this should apply to the stable maint groups too and if so we need to be more explicit about that. if not we can drop redundant config | 21:11 |
| JayF | it's one of those things where like, yeah, we probably should just so it aligns | 21:13 |
| JayF | but I think the "it's stuck in WIP" is not a problem we'd see as much on stable branches | 21:13 |
| JayF | I'll update it real quick tho | 21:13 |
| opendevreview | Jay Faulkner proposed openstack/project-config master: Allow Ironic cores to toggle WIP state https://review.opendev.org/c/openstack/project-config/+/863931 | 21:15 |
| opendevreview | Michael Johnson proposed openstack/project-config master: Allow Designate cores to toggle WIP state https://review.opendev.org/c/openstack/project-config/+/863932 | 21:18 |
| clarkb | oh there is an octavia and a designate change. I only commented on the octavia one so far | 21:19 |
| clarkb | johnsom: ^ but if you get a chance can you check my comments there? | 21:19 |
| johnsom | Yeah, fixing the designate one now for the current comment. | 21:20 |
| opendevreview | Michael Johnson proposed openstack/project-config master: Allow Designate cores to toggle WIP state https://review.opendev.org/c/openstack/project-config/+/863932 | 21:20 |
| johnsom | Ah, yeah, you are probably right that it is duplicate. I will change that | 21:22 |
| opendevreview | Michael Johnson proposed openstack/project-config master: Allow Octavia cores to toggle WIP state https://review.opendev.org/c/openstack/project-config/+/863934 | 21:24 |
| opendevreview | Michael Johnson proposed openstack/project-config master: Allow Designate cores to toggle WIP state https://review.opendev.org/c/openstack/project-config/+/863932 | 21:24 |
| johnsom | Ok, straightened out all of the comments. | 21:25 |
| *** dasm is now known as dasm|off | 22:27 | |
| *** cloudnull6 is now known as cloudnull | 22:38 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!