| opendevreview | Ian Wienand proposed openstack/project-config master: tools/normalize_acl.py: Add some human readable output https://review.opendev.org/c/openstack/project-config/+/880898 | 06:53 |
|---|---|---|
| vvr-plv | hello, I am working on implementation of third party CI and have a question of filtering events from the project using a "magic" word (ntnic-verify for example). We are very limited in the number of setups (only one for now), so we would like to trigger only on the specified events. I am talking about this review https://review.opendev.org/c/openstack/neutron/+/869510/3 for example and other dependent. Also I would like to implement queue for | 08:29 |
| vvr-plv | our/community requests with specified "magic" word. Is it okay solution? Can I continue with it? | 08:29 |
| fungi | vvr-plv: you'll want to check with the neutron team to see if that's fine with them. we (the admins of the code review system) don't really care either way | 12:43 |
| *** ministry is now known as __ministry | 13:05 | |
| *** haleyb_ is now known as haleyb | 15:14 | |
| opendevreview | Elod Illes proposed openstack/project-config master: Prevent recreate EOL'd branch https://review.opendev.org/c/openstack/project-config/+/881731 | 15:18 |
| opendevreview | Elod Illes proposed openstack/project-config master: Prevent recreate EOL'd branch https://review.opendev.org/c/openstack/project-config/+/881731 | 15:22 |
| elodilles | hi, i see that you are talking about gerrit upgrade. is it about to happen soon, or am i able to run the eol'd branch delete script before the upgrade happens? | 19:06 |
| fungi | elodilles: not any time soon, no. we'd publish an announcement well in advance | 19:07 |
| fungi | we're able to test new gerrit releases with our ci jobs, because they mimic our deployment automation but onto test nodes | 19:08 |
| fungi | including upgrading and downgrading processes | 19:08 |
| fungi | doing that gives us confidence that an actual production upgrade will work the way we expect | 19:08 |
| elodilles | oh, i see, thanks, i haven't read the whole discussion just saw that there was gerrit upgrade mentioned :) | 19:08 |
| fungi | we're talking about gerrit 3.8.0 which doesn't actually exist yet (we're currently running the latest release) | 19:09 |
| elodilles | :-o | 19:09 |
| fungi | clarkb's been testing prerelease builds of it in advance | 19:10 |
| elodilles | nice | 19:10 |
| fungi | but anyway, yes feel free to delete branches at your convenience | 19:10 |
| elodilles | cool, then i'll start the script now | 19:11 |
| elodilles | i think only cinder's recreated stable/ussuri branch needs to be deleted anyway, but the script will tell | 19:13 |
| elodilles | yepp, that was the only one: | 19:19 |
| elodilles | Branch stable/ussuri successfully deleted from openstack/cinderlib! | 19:19 |
| elodilles | that was all | 19:19 |
| fungi | cool. and it seems you also found the bug that caused it to get recreated? | 19:21 |
| elodilles | yes | 19:21 |
| elodilles | when the post job was running it calls the make_branch.sh script which does not check if the branch doesn't exist because it was EOL'd already | 19:23 |
| elodilles | thus recreates the branch, from the original branching point, described in the deliverable's yaml file | 19:23 |
| elodilles | this probably happened in the past and that's why we had some weird stable branches for very old series | 19:24 |
| elodilles | i think with that simple check, whether the *-eol tag exists, we can avoid this in the future | 19:26 |
| elodilles | this was not a common case before, as release patches usually don't play with EOL'd deliverables. it was triggered this time with a reno link adding patch, that i proposed to fix old releases' links... | 19:29 |
| clarkb | ya I'm just taking advantage of the excellent tooling we have to start getting prepared. I thin kwe would wait for at least 3.8.0 and maybe even 3.8.1 before upgrading. | 19:48 |
| elodilles | cool :) google says we have some time, as 3.8.0 is not sooner then May 15: https://www.gerritcodereview.com/2023-03-31-gerrit-3.8-release-plan.html (and this is not even 3.8.1) | 19:53 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!