| *** ministry is now known as __ministry | 08:23 | |
| opendevreview | daniel.pawlik proposed openstack/ci-log-processing master: Remove build dirs with missing files; add more debug logs https://review.opendev.org/c/openstack/ci-log-processing/+/882270 | 12:43 |
|---|---|---|
| *** ministry is now known as __ministry | 15:02 | |
| *** ralonsoh is now known as ralonsoh_afk | 16:56 | |
| JayF | clarkb: you happy with https://review.opendev.org/c/openstack/pbr/+/884789 now? Just making sure there's no action I need to take further. | 18:34 |
| clarkb | JayF: I think the two functions hvae different return signatures which is why I did that lambda thing before | 18:36 |
| JayF | lets see, all_suffixes() returns a list of strings | 18:37 |
| clarkb | ya and get_suffixes returns a list of tuples and we want the first element of each tuple | 18:37 |
| JayF | get_suffixes returns a list of tuples | 18:38 |
| JayF | clarkb: https://gist.github.com/jayofdoom/03996dd68f8fc74b980565b58051685f | 18:39 |
| JayF | clarkb: it's not as memory efficient, but it makes it more clear what's happening | 18:40 |
| clarkb | ya I don't think a lambda is necessary I was just trying to be succint in code review | 18:40 |
| JayF | ack; patch update coming in minutes | 18:41 |
| clarkb | JayF: oh also is ImportError correct? | 18:41 |
| clarkb | I get ModuleNotFoundError | 18:41 |
| JayF | # NOTE(JayF): ModuleNotFoundError only exists in Python 3.6+, not in 2.7 | 18:41 |
| JayF | ModuleNotFoundError is a subclass of ImportError | 18:42 |
| JayF | added in 3.6 | 18:42 |
| clarkb | ah | 18:42 |
| opendevreview | Jay Faulkner proposed openstack/pbr master: Replace imp with importlib.machinery https://review.opendev.org/c/openstack/pbr/+/884789 | 18:45 |
| opendevreview | Jay Faulkner proposed openstack/pbr master: Replace imp with importlib.machinery https://review.opendev.org/c/openstack/pbr/+/884789 | 18:46 |
| *** dviroel_ is now known as dviroel | 20:49 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!