-opendevstatus- NOTICE: Gerrit will be unavailable for a short time starting at 15:30 UTC as it is upgraded to the 3.8 release. https://lists.opendev.org/archives/list/service-announce@lists.opendev.org/thread/XT26HFG2FOZL3UHZVLXCCANDZ3TJZM7Q/ | 14:06 | |
*** blarnath is now known as d34dh0r53 | 14:38 | |
-opendevstatus- NOTICE: The Gerrit upgrade is complete, however we have Zuul offline in parallel for a schema migration, so any events occurring during this time will be lost (requiring a recheck or similar to trigger jobs once it returns to service); we'll update again once this is complete. | 16:34 | |
-opendevstatus- NOTICE: Zuul is fully back in service now, but any events occurring prior to 17:05 UTC may need a recheck to trigger jobs. | 17:12 | |
eandersson | Edit mode seems broken now after the upgrade. | 18:55 |
---|---|---|
clarkb | eandersson: can you be more specific. I can test editing but how is it broken? | 18:55 |
eandersson | I was trying to edit a commit message using the browser, but nothing is showing up. | 18:56 |
tonyb | I see the same issue | 18:57 |
clarkb | ok I think I have reproduced that on a random change I have open. Basically you can enter edit mode but when you try to open the file you don't get the editor for the file | 18:57 |
eandersson | Yep exactly | 18:57 |
clarkb | thank you for the report and confirming you see the same behavior I've got. I don't think this is revert worth (because you can still push code), but it is something we can followup on and try to fix | 18:58 |
clarkb | I don't see any errors in the error log | 18:58 |
eandersson | I see multiple | 18:58 |
clarkb | eandersson: in the browser? sorry I meant on the server side | 18:59 |
* clarkb looks at the browser | 18:59 | |
eandersson | Ah yea sorry! in the browser :D | 18:59 |
eandersson | But def not critical. I just made my minor change in git instead | 19:00 |
clarkb | yup thank you for reporting. Its definitely somethign we want to have working and will investigate. I just want to amke clear to everyone that I don't think this means we need to initiate a revert | 19:00 |
clarkb | I see two errors in the web console now | 19:00 |
clarkb | I'll work on collecting data into our upgrade etherpad then probably turn that into an email to upstream | 19:01 |
clarkb | eandersson: ok tonyb got it workign and said he accidentally closed the window and when he tried again it worked. This made me think maybe it is bad caching and I did a hard refresh (ctrl + shift + r in firefox) and now it works for me on that change | 19:17 |
clarkb | eandersson: gerrit itself does versioned js and your browser will notice you've got the wrong versions but the codemirror-editor is a plugin and they must not do that there | 19:17 |
tonyb | eandersson: FWIW https://review.opendev.org/c/openstack/requirements/+/900435/8..9 is an edit I made in the web UI editor. | 19:24 |
tonyb | eandersson: It's funcational, after a full/hard refresh, but it still isn't quite "right". | 19:24 |
clarkb | tonyb: what isn't "right" about it? | 19:25 |
tonyb | I wasn't able to edit the way I'd expect, instead I needed to use Ctrl-F and replace to make the change. | 19:26 |
tonyb | clarkb: I want to do a little more playing to try and solidify the issue | 19:26 |
clarkb | tonyb: fwiw my edit here: https://review.opendev.org/c/opendev/system-config/+/900379/1..2/useful_utf8_chars was fine with normal keyboard entry | 19:27 |
clarkb | tonyb: maybe you haven't sufficiently cleared your cache? | 19:28 |
tonyb | Could be. | 19:28 |
tonyb | I'm reasonably confident that it's a cache/client side issue | 19:29 |
clarkb | I'll start drafting an email to the gerrit list to see if this is at least expected from them | 19:29 |
clarkb | https://etherpad.opendev.org/p/tvAyWLRV07MNayX3Bbc3 is my draft | 19:40 |
tonyb | clarkb: LGTM | 19:44 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!