| opendevreview | Ghanshyam proposed openstack/project-config master: End gate and update acl for retiring openstack-chef projects https://review.opendev.org/c/openstack/project-config/+/909134 | 05:03 |
|---|---|---|
| opendevreview | Merged openstack/project-config master: Retire puppet-qdr: End Project Gating https://review.opendev.org/c/openstack/project-config/+/907951 | 12:28 |
| opendevreview | Merged openstack/project-config master: unmaintained: gerritbot notification for Networking https://review.opendev.org/c/openstack/project-config/+/908606 | 12:28 |
| *** tobias-urdin7 is now known as tobias-urdin | 14:07 | |
| *** tobias-urdin0 is now known as tobias-urdin | 14:20 | |
| opendevreview | Merged openstack/project-config master: End gate and update acl for retiring openstack-chef projects https://review.opendev.org/c/openstack/project-config/+/909134 | 19:12 |
| JayF | Curious about this: https://review.opendev.org/c/openstack/ironic/+/909263 -- it doesn't appear to be recognizing the Author/Commiter despite that email address being in CID's gerrit profile (I validated it over video) | 20:03 |
| JayF | cid_: ^ | 20:03 |
| fungi | JayF: can you restate the problem? what does "recognizing" mean? | 20:04 |
| JayF | Owner: is cid, and has metadata from his account | 20:04 |
| JayF | Author/Commiter is *not* recognized as his user with metdata from the account | 20:05 |
| JayF | despite the fact both emails are in the place | 20:05 |
| fungi | could he have two accounts? | 20:05 |
| fungi | if he tried changing his address in ubuntuone sso, that creates a new openid, and logging into gerrit with that creates a new account | 20:10 |
| clarkb | https://review.opendev.org/c/openstack/ironic/+/909263/1//COMMIT_MSG#2 it may just be due to the commit message content | 20:11 |
| clarkb | more recent versions of gerrit hvae clamped down on the ability to see accounts by secondary email addrs | 20:12 |
| fungi | oh, you think it's displaying the "personal" name supplied with that address? | 20:12 |
| clarkb | I suspect that if the committer and auther were set in git to the other email address it would all line up and otherwise we may have to go reread the changelogs for the changes to additional email addr visibility | 20:13 |
| clarkb | yes | 20:13 |
| fungi | okay, so not actually reflecting an actual account name in that case | 20:13 |
| clarkb | changes I push seem to exihbit the same behavior | 20:30 |
| clarkb | because my git config sets my gmail account and my gerrit account has my other one | 20:31 |
| clarkb | oh interesting if I am logged in I see the author and commit mapped to my account | 20:31 |
| clarkb | so ya pretty sure this is a visibility to secondary email addrs thing | 20:31 |
| clarkb | https://review.opendev.org/c/zuul/zuul/+/909131 for example | 20:32 |
| clarkb | I bet you all see the gmail addr listed for committer and author like I do when logged out, but in my logged in browser I see my regular account | 20:32 |
| fungi | yes, though the displayed name is the same for both in your case, obviously | 20:34 |
| clarkb | yup only the email differs in my case | 20:35 |
| JayF | This is 100% what I was confused about | 20:45 |
| JayF | I'm still unsure if it's a bug, oversight, intended or whatever, but my only real reason for mentioning it was to let you know if it should work and isn't and/or to make sure that (other than pushing changes with different email on account/git config ... not a huge deal IMO) there wasn't anything wrong/weird going on | 20:46 |
| clarkb | I think it is an unfortunate consequence of gerrit clamping down on secondary account lookups | 20:47 |
| JayF | Yeah, it makes sense | 20:48 |
| JayF | because I bet you could e.g. push a bunch of changes to sandbox with different emails | 20:48 |
| JayF | and extract information on who uses what secondary emails | 20:48 |
| JayF | and also makes me feel slightly vindicated that based on the tense of your statement that it might have used to work the way I expected (and/or shows up correctly for my own changes when logged in) | 20:48 |
| clarkb | yes, this was due to a relatively recent change. maybe our 3.7 upgrade? I can go find the release notes | 20:49 |
| JayF | not a big deal | 20:49 |
| JayF | Thanks for enlightening me :D | 20:49 |
| * JayF afk o/ | 20:49 | |
| clarkb | https://gerrit-review.googlesource.com/c/gerrit/+/358954 is the change and 3.8 was the release that did it | 20:50 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!