| *** dtantsur_ is now known as dtantsur | 00:08 | |
| dansmith | so, I noticed gerrit and git-review have a "WIP" status natively | 17:02 |
|---|---|---|
| dansmith | I know we were discouraged from using "draft" but can/should we use WIP? | 17:02 |
| clarkb | dansmith: you can. I still prefer the workflow -1 because the built in workflow can't be reset by anyone but you or an admin | 17:12 |
| dansmith | it's just nice to be able to do that from git-review | 17:12 |
| dansmith | any other restrictions you know of? like draft were not searchable or something | 17:12 |
| clarkb | no WIP changes are fully public and searchable. They just get extra annotation and I think you can search and exclude them | 17:13 |
| clarkb | they also cannot merge | 17:13 |
| dansmith | they'll run tests though I assume? | 17:13 |
| clarkb | thats probably the biggest issue, people using the built in wip for something that they don't want to merge yet but do want to merge later in an unchanged state | 17:13 |
| clarkb | yes tests will still run | 17:13 |
| dansmith | ack | 17:13 |
| clarkb | you shouldn't use that flag when you just want something to not merge for a period of time because it is hard for people to undo the state and make it mergeable later. Use it when you know the thing cannot merge bceause its broken or whatever | 17:14 |
| dansmith | ack | 17:15 |
| fungi | it's possible to set acls allowing core review teams to set/unset wip on someone else's patch for that project (a few teams have done this) | 17:42 |
| fungi | it's also possible to make it so anyone can win/unwip anyone else's change, if that's what a project wants | 17:42 |
| gmann | frickler: did you get chance to force merge this? https://review.opendev.org/c/openstack/tripleo-ci/+/910059 | 18:16 |
| frickler | gmann: not yet, got distracted by other issues this morning, hopefully tomorrow | 18:17 |
| gmann | frickler: k, thanks | 18:17 |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline momentarily for a restart in order to apply a patch update | 18:36 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!