| opendevreview | Takashi Kajinami proposed openstack/openstack-zuul-jobs master: Skip unit/functional tests on pre-commit config update https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/933197 | 01:07 |
|---|---|---|
| cardoe | So question wrt to what we can do with Zuul. In Helm, the Chart.yaml needs a version in it. The OSH (OpenStack Helm) project wants to bump the version every time something lands for a specific chart. Many Helm based projects I've seen use git tags to determine the version but can I have the CI push the tag or a commit bumping the version as part of the build? | 02:12 |
| cardoe | https://github.com/cardoe/openstack-helm/commit/6629425c88be6f29aa761426bb96fbc193854f07 is what I do today to build the chart versions based on tags. | 02:14 |
| cardoe | Trying to come up with some upstreamable suggestion. | 02:14 |
| fungi | cardoe: the openstack release team has release automation which pushes git tags in response to commits merging, so it's possible in theory yes | 02:25 |
| fungi | basically there's a job which runs when a change merges which uses stored gerrit account credentials and openpgp key to sign and push a tag to gerrit | 02:26 |
| cardoe | That would potentially work. I’ll look at what the release team has. | 02:55 |
| fungi | proposing a change to increase a version in Chart.yaml every time a change merges would be a little weird, since you'd need to avoid having any change that only increases the version number pushing a new change to increase it again. but also you'd have to make sure you approved those changes in the right order relative to the changes which triggered them... basically embedding | 03:01 |
| fungi | versioning per-commit in files that are being committed is not a workflow that seems compatible with code review and non-serialized/distributed development | 03:01 |
| fungi | tags, on the other hand, don't alter files in the repository so are a more out-of-band way of versioning repositories | 03:03 |
| cardoe | So for me I haven’t been using a tag but instead a label on a patch set. If it’s labeled then once that lands the next tag is generated. When a tag is made I build the chart at the tagged version. | 03:21 |
| fungi | cardoe: by "a label on a patch set" you mean in the gerrit sense of the term "label"? https://review.opendev.org/Documentation/intro-project-owner.html#labels | 03:46 |
| fungi | so a reviewer basically votes "this change should increase the version"? | 03:47 |
| cardoe | Yeah that would be analogous. It’s been on GitHub. | 12:24 |
| *** haleyb|out is now known as haleyb | 13:53 | |
| opendevreview | Felipe Reyes proposed openstack/openstack-zuul-jobs master: Increase openstack-tox-snap-with-sudo job timeout https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/934821 | 18:02 |
| opendevreview | James E. Blair proposed openstack/project-config master: Fix openstack developer docs promote job https://review.opendev.org/c/openstack/project-config/+/934832 | 19:58 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!