| *** tosky_ is now known as tosky | 15:40 | |
| opendevreview | Ghanshyam proposed openstack/project-config master: Move test-release-openstack job to Noble https://review.opendev.org/c/openstack/project-config/+/937053 | 18:40 |
|---|---|---|
| *** elodilles is now known as elodilles_pto | 19:54 | |
| gmann | clarkb: fungi frickler can you check this (Move test-release-openstack job to Noble) https://review.opendev.org/c/openstack/project-config/+/937053 | 21:32 |
| clarkb | gmann: is your plan to make release-openstack-python branch aware too? One weird thing about doing that is release-openstack-python runs in a tag not branch context | 22:39 |
| clarkb | though usually zuul will get that right today I think it is still worth calling out | 22:39 |
| clarkb | fungi: ^ fyi you may have thoughts on that | 22:39 |
| fungi | is that the same comment i left on the change? | 22:39 |
| clarkb | oh yup | 22:39 |
| clarkb | also we really need to fix gertty :P | 22:39 |
| fungi | cool, just double-checking i hadn't forgotten to push the button. i do that sometimes | 22:40 |
| clarkb | no the issue is the lack of the visual cue saying there is a comment here bceause it is the old style top level comment | 22:40 |
| clarkb | also I don't know when gerrit is removing support for that. I don't think it is in 3.10 but may be worth checking | 22:40 |
| fungi | ah, i'm using the experimental patch that does new-style comments but i think it can only create them for inline commentary | 22:40 |
| clarkb | fungi: I think there is a special meta file you leave the "inline" comment to for the top level one | 22:41 |
| clarkb | gmann: the other concern I have is that the way you've done branch matching with positive matches for stable branches and negative match for master and beyond means that anything not matching an existing stable branch in that list will be "promoted" to noble | 22:42 |
| clarkb | the alternative would be to positive match for master and beyond too and then you stop running this job on branches taht don't match which may be preferable as taht may be more explicit and make peopel aware something is wrong? | 22:43 |
| fungi | i think it's the same pattern we've used elsewhere so that we don't have to keep adding branches to all those expressions in jobs every time we make a new release branch | 22:43 |
| clarkb | fungi: ya but the nyou have to rewrite them every four branches | 22:44 |
| clarkb | we could just positive match four in advance | 22:44 |
| clarkb | and only edit if we get off schedule but maybe we're more likely to forget to do that | 22:44 |
| clarkb | but we can also adjust that later | 22:45 |
| clarkb | (I don't like mixing and matching these types of branch matchers as they have created confusion in the past) | 22:45 |
| fungi | true, even if it's engineered not to need to add new branches for noble, noble will eventually be supplanted by something else that we then add noble-specific branches for | 22:45 |
| opendevreview | Merged openstack/project-config master: Move test-release-openstack job to Noble https://review.opendev.org/c/openstack/project-config/+/937053 | 22:56 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!