| *** elodilles is now known as elodilles_pto | 08:23 | |
| opendevreview | Stephen Finucane proposed openstack/pbr master: Update setup.cfg example in Usage document https://review.opendev.org/c/openstack/pbr/+/938586 | 12:32 |
|---|---|---|
| opendevreview | Merged openstack/pbr master: Update setup.cfg example in Usage document https://review.opendev.org/c/openstack/pbr/+/938586 | 14:33 |
| opendevreview | Jeremy Stanley proposed openstack/pbr master: Simplify PBR dependency on SetupTools https://review.opendev.org/c/openstack/pbr/+/940310 | 15:13 |
| opendevreview | Jeremy Stanley proposed openstack/pbr master: docs: Drop SetupTools from pyproject.toml example https://review.opendev.org/c/openstack/pbr/+/940311 | 15:13 |
| clarkb | fungi: one thought on ^ is we require newer setuptools for proper pyproject.toml integration in the current pyproject.toml example but the requirements.txt accepts any setuptools | 15:14 |
| clarkb | in practice I suspect this won't be an issue because tools like build default to using isolated enviornments that are built on demand so latest valid setuptools should be used | 15:15 |
| clarkb | but wanted to call that out in case there is extra concern around that | 15:15 |
| fungi | right, that was my thinking | 15:15 |
| fungi | pyproject-build will create a throwaway environment when building a package, and install latest pbr and setuptools into it anyway | 15:16 |
| clarkb | yup and thats the main context that pyproject.toml is relevant in | 15:16 |
| fungi | technically even specifying a minimum pbr there shouldn't be necessary, but it helps serve as a bit of a reminder | 15:16 |
| clarkb | I'll leave a note on the change and indicate that this is unlikely to be a problem | 15:16 |
| fungi | and runtime use of pbr doesn't need newer pbr versions generally, the features people are using for that are there even in ancient pbr | 15:17 |
| clarkb | ++ | 15:19 |
| clarkb | fungi: re the pbr version in pyproject.toml I actually would like to keep that for one major reason: this is the only reliable way to control the version of pbr used to build a package. For the last decade or more people have tried to do this through varying methods with not much success. Having an example showing it is possible here is a good way to get people clued into | 15:21 |
| clarkb | "this is the right way to do it" | 15:21 |
| fungi | yeah, i mean they can also use it to control the setuptools version, but i don't want to give the impression that it's necessary to list setuptools there | 15:22 |
| fungi | hopefully it's obvious that if people want to pin specific setuptools versions for build purposes, they can | 15:22 |
| fungi | i've pushed a revision of 940258 to drop setuptools in pyproject.toml just to show it's working | 15:28 |
| opendevreview | Jeremy Stanley proposed openstack/pbr master: Simplify PBR dependency on SetupTools https://review.opendev.org/c/openstack/pbr/+/940310 | 16:50 |
| opendevreview | Jeremy Stanley proposed openstack/pbr master: docs: Drop SetupTools from pyproject.toml example https://review.opendev.org/c/openstack/pbr/+/940311 | 16:50 |
| *** priteau is now known as Guest7267 | 17:04 | |
| *** priteau2 is now known as priteau | 17:04 | |
| opendevreview | Jeremy Stanley proposed openstack/pbr master: docs: Drop SetupTools from pyproject.toml example https://review.opendev.org/c/openstack/pbr/+/940311 | 17:35 |
| opendevreview | Stephen Finucane proposed openstack/pbr master: docs: Drop SetupTools from pyproject.toml example https://review.opendev.org/c/openstack/pbr/+/940311 | 17:36 |
| opendevreview | Merged openstack/pbr master: Simplify PBR dependency on SetupTools https://review.opendev.org/c/openstack/pbr/+/940310 | 20:09 |
| opendevreview | Merged openstack/pbr master: docs: Drop SetupTools from pyproject.toml example https://review.opendev.org/c/openstack/pbr/+/940311 | 20:09 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!