| *** ralonsoh_ is now known as ralonsoh | 12:36 | |
| dansmith | remind me - there just has to be *something* (i.e. a job) in the gate queue for zuul to merge on +2+W right? | 13:42 |
|---|---|---|
| fungi | yes, though it can be the noop job (typically applied in-project with the noop-jobs template in your .zuul.yaml file or whatever) | 13:47 |
| fungi | dansmith: ^ | 13:48 |
| fungi | which, as the name implies, just does nothing very quickly and then returns success | 13:48 |
| dansmith | okay I didn't see a noop job int he zuul jobs interface | 13:48 |
| fungi | it's a (the only?) implicit built-in job, it has no actual definition | 13:48 |
| dansmith | ah, okay | 13:48 |
| fungi | dansmith: https://codesearch.opendev.org/?q=noop-jobs | 13:49 |
| fungi | should turn up some references and numerous exampls | 13:49 |
| dansmith | so "noop" is in the .zuul template, but I need "noop-jobs" ? | 13:49 |
| fungi | the noop-jobs template just applies the noop job in check and gate pipelines, definition for it can be found here: https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/zuul.d/project-templates.yaml#L18-L31 | 13:50 |
| fungi | most projects apply noop-jobs as a template for convenience, rather than explicitly adding noop to multiple pipelines directly | 13:51 |
| dansmith | this is the default it gave me: https://opendev.org/openstack/nova-contrib/src/branch/master/.zuul.yaml | 13:51 |
| dansmith | is that not the same as the template? | 13:51 |
| fungi | yeah, that should work exactly the same | 13:51 |
| fungi | also fine | 13:51 |
| dansmith | okay but +W and no gate action: https://review.opendev.org/c/openstack/nova-contrib/+/951684/1 | 13:52 |
| fungi | might that have been proposed before the noop jobs were added to .zuul.yaml? | 13:53 |
| fungi | if so, there was never a verified +1 from zuul on it, a recheck will solve that | 13:53 |
| dansmith | they're in the tree for that commit | 13:53 |
| fungi | mmm | 13:53 |
| dansmith | and git-review worked because it was pre-setup for me, and that's the same commit as the .zuul | 13:55 |
| dansmith | yeah that setup commit is the parent of mine | 13:55 |
| fungi | yeah, strangely the child change in that series did get a verified +1 | 13:55 |
| dansmith | well, I added actual tests, so I figured that was why | 13:56 |
| dansmith | I could just squash those, but was trying to keep the sync commit to be exactly and only what is currently in nova (i.e. there are no tests there) | 13:56 |
| fungi | shouldn't be necessary, looking still | 13:57 |
| fungi | oh, i wonder if we have an unexpected catch-22 with the initial commit state | 13:58 |
| fungi | the manage-projects deployment script pushes that commit directly to gerrit rather than as a change for review... | 13:59 |
| fungi | though, no, zuul should still have received the branch update event and known to re-read the repo for any job configuration | 13:59 |
| fungi | at this point https://zuul.opendev.org/t/openstack/project/opendev.org/openstack/nova-contrib does indicate zuul expects to run the noop jobs on changes for it | 14:02 |
| fungi | so a recheck will likely "just work" | 14:02 |
| fungi | but i'm wondering what sort of race got it into that initial state wher zuul didn't run anything on the change | 14:02 |
| dansmith | I see jobs | 14:02 |
| dansmith | maybe my fault for pushing to the repo minutes after it was created | 14:03 |
| fungi | it's possible there's a brief opportunity for a race if a change gets pushed after the project is created but before zuul has completed its own reconfig | 14:04 |
| fungi | which usually taks on the order of minutes | 14:04 |
| dansmith | ah crap, I rechecked the wrong one | 14:05 |
| dansmith | heh, I rechecked the one with actual tests | 14:05 |
| dansmith | I don't see jobs for that one | 14:05 |
| dansmith | there we go | 14:06 |
| dansmith | merged | 14:06 |
| dansmith | thanks, sorry for the noise, I guess I should have tried rechecking my noop jobs first :) | 14:06 |
| fungi | no worries, i'll see if i can think of a way to confirm my theory as to what happened initially | 14:09 |
| fungi | dansmith: https://review.opendev.org/c/openstack/project-config/+/951570 deployed main.yaml to zuul in https://zuul.opendev.org/t/openstack/build/59be142897814009a0226cb621feb4a5 around 17:20 yesterday at which time a smart reconfig was triggered, but https://review.opendev.org/c/openstack/nova-contrib/+/951684 was uploaded about a minute earlier before zuul became aware of | 15:00 |
| fungi | the project | 15:00 |
| fungi | so that explains it | 15:00 |
| dansmith | ack, thanks for the RCA | 15:01 |
| * dansmith blows smoke from his guns and re-holsters | 15:01 | |
| opendevreview | Clark Boylan proposed openstack/project-config master: Disable Nodepool's rax iad region https://review.opendev.org/c/openstack/project-config/+/951794 | 17:19 |
| opendevreview | Merged openstack/project-config master: Disable Nodepool's rax iad region https://review.opendev.org/c/openstack/project-config/+/951794 | 17:42 |
| opendevreview | Merged openstack/project-config master: Remove redundant editHashtags config https://review.opendev.org/c/openstack/project-config/+/951603 | 20:54 |
| opendevreview | Merged openstack/project-config master: Remove editHashtags config https://review.opendev.org/c/openstack/project-config/+/951604 | 20:57 |
| opendevreview | Merged openstack/project-config master: Disallow editHashtags in acl configs https://review.opendev.org/c/openstack/project-config/+/951715 | 20:58 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!