| *** ykarel_ is now known as ykarel | 07:08 | |
| rosmaita | a new contributor just pointed out that when you leave a top-level gerrit comment (i.e., the comment when you hit the "reply" button and can vote), the comment defaults to "Resolved" ... whereas the inline comments default to not having Resolved checked | 14:56 |
|---|---|---|
| rosmaita | as a result, he has been ignoring the top level comments because they're already resolved, whereas they often say things like "good start on the code, but you need to include unit tests" | 14:56 |
| rosmaita | is there a way to change this so that the top level comment does not default to Resolved? | 14:56 |
| rosmaita | or is there a good reason why we would not want to do this? | 14:56 |
| fungi | i'm not sure. i mostly use gertty which even sets inline comments to resolved since that's more how prior versions of gerrit worked before they introduced the "turns" concept | 15:05 |
| clarkb | I don't think we acn change it without patching gerrit | 15:48 |
| clarkb | I think the idea is inline comments are almost always something you need to change whereas its more ambigious for top level stuff so people should be explicit there? | 15:48 |
| clarkb | if it were configurable I would expect that to be in your user preferences but I don't see it there | 15:49 |
| clarkb | though I did just discover there is a preference for automatically adding your signed off by to commits that get edited in the online editor | 15:49 |
| clarkb | gouthamr: ^ fyi since there were questions about that in the past | 15:50 |
| gouthamr | oh that’d be neat | 15:54 |
| clarkb | that is a per user opt in but could be useful if individuals are regularly using the web ui to edit changes | 16:00 |
| rosmaita | fungi: clarkb: thanks for the info (i was in meetings and then got into other stuff and only just now remembered to look here) | 23:35 |
| JayF | oooh I would <3 the auto DCO when using the web editor | 23:39 |
| fungi | JayF: good news! it's just a checkbox away in your user prefs | 23:40 |
| tonyb | oh really! I didn't know that either. | 23:41 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!