| mnasiadka | Another related thing that was asked by a Kolla contributor - is that why you can merge a change with unresolved comments - IIRC there’s an option to have that in submit requirements - https://issues.gerritcodereview.com/issues/317351858 | 07:13 |
|---|---|---|
| mnasiadka | I don’t know if I’m going to pursue adding that to submit requirements - probably if there are more questions like that | 07:14 |
| fungi | i certainly don't pay attention to whether comments are marked as resolved or unresolved, i actually look to see whether they've been answered or fixed by some further edit in a later revision before approving | 14:19 |
| fungi | gerrit has a lot of features that end up on by default but i don't assume everyone uses or relies on all the features that are enabled | 14:20 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!