| *** bauzas7 is now known as bauzas | 01:54 | |
| opendevreview | Dr. Jens Harbott proposed openstack/project-config master: Drop x/neutron-interconnection from zuul https://review.opendev.org/c/openstack/project-config/+/994392 | 05:42 |
|---|---|---|
| *** vhari_ is now known as vhari | 10:28 | |
| opendevreview | Merged openstack/project-config master: Drop x/neutron-interconnection from zuul https://review.opendev.org/c/openstack/project-config/+/994392 | 10:51 |
| opendevreview | Merged openstack/openstack-zuul-jobs master: Drop unneeded ansible-version pins https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/994173 | 13:25 |
| *** ykarel_ is now known as ykarel | 13:26 | |
| opendevreview | Dr. Jens Harbott proposed openstack/openstack-zuul-jobs master: Drop openstack-python3-train-jobs-neutron template https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/994188 | 13:39 |
| opendevreview | Merged openstack/openstack-zuul-jobs master: Add openstack-tox-py315 job https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/992771 | 13:55 |
| opendevreview | Merged openstack/openstack-zuul-jobs master: Add openstack-python3-next-jobs template https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/993337 | 14:15 |
| stephenfin | clarkb: fungi: Are either of you aware of any automated tooling for messing with .zuul.yaml files? | 15:26 |
| stephenfin | I'm trying to automate the addition of that new openstack-python3-next-jobs template to all Oslo/SDK deliverables, but it seems ruamel won't roundtrip exactly if formatting isn't consistent (i.e. we indent list items in one place but not another) | 15:26 |
| stephenfin | My plan is just add a style-only commit beforehand that makes that formatting consistent, but I'm wondering if there's a better way that isn't using sed/awk :D | 15:27 |
| fungi | stephenfin: pyyaml or ruaml-yaml is probably your best bet | 15:30 |
| clarkb | there is a tool in zuul/zuul-jobs that populates jobs for various platforms | 15:30 |
| clarkb | that is probably a good reference and I think it uses ruamel | 15:30 |
| fungi | yeah, i expect tha choice was mainly to preserve inline comments | 15:30 |
| clarkb | tools/update-test-platforms.py | 15:30 |
| * stephenfin looks | 15:41 | |
| stephenfin | Okay, that aligns with what I was doing, only most/all of these repos are not running yamllint so that's why we see the indentation changes | 15:46 |
| stephenfin | ...which suggests my idea of fixing those in a precursor commit probably makes sense so | 15:46 |
| fungi | i have a recipe for a pyyaml writer subclass/override so that it emits formatting compatible with yamllint, if you need something like that | 15:47 |
| fungi | though pyyaml won't preserve comments, so you may not want to go that route | 15:47 |
| stephenfin | we probably need to keep comments so I think ruamel is my answer | 15:50 |
| fungi | the main issue i run into with pyyaml writer vs pylint is that they disagree on how much to indent array elements | 15:52 |
| fungi | maybe ruaml has something to make that easier | 15:53 |
| clarkb | I think there is an open bug against ruamel for the indentation issues | 15:57 |
| clarkb | I don't think the answer there is to break the indentation globally | 15:57 |
| clarkb | I'm noticing more and more people are pushing changes that mix up formatting changes with modifying the code for semantic reasons | 15:59 |
| clarkb | It is now to the point where the burden is high enough that I feel I needt o styart -1'ing all of these changes | 15:59 |
| clarkb | I don't think it is appropriate for people to apply their personal formatting rules on existing code bases | 15:59 |
| clarkb | if you want to start things with your tools thats fine I'll follow along. But I really don't think it is appropriate that I have to constantly ask people to stop making these changes | 16:00 |
| fungi | i think a lot of people have their editor/ide set up to auto-reformat any file they touch | 16:02 |
| fungi | which is an antisocial configuration for participating in an open source project's code review workflow | 16:03 |
| opendevreview | Merged openstack/project-config master: sunbeam: retire all single charm repositories https://review.opendev.org/c/openstack/project-config/+/903666 | 16:23 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!