| opendevreview | Stephen Finucane proposed openstack/project-config master: Add nova-approvers to openstack/nova ACL https://review.opendev.org/c/openstack/project-config/+/1003848 | 16:49 |
|---|---|---|
| stephenfin | fungi: I'm treading somewhat warily in light of yesterday's...fun, but can you remind me who's ack we need for https://review.opendev.org/c/openstack/project-config/+/1003838/1 to merge. Ironic is a DPL model. JayF and TheJulia are +1, but do I need dtantsur (as TaCT sig liason) or cardoe (as TC liason) to +1 now? | 16:55 |
| stephenfin | *whose | 16:55 |
| stephenfin | whoms? | 16:55 |
| stephenfin | whose | 16:56 |
| stephenfin | also, I don't understand the failure on https://review.opendev.org/c/openstack/project-config/+/1003840. It seems to be saying I should replace `ironic-approvers` with `ironic-approvers-core` but that's not correct | 16:57 |
| fungi | stephenfin: tact sig liaison, yes | 17:03 |
| JayF | I think we need to add -approvers / -reviewers to the lint | 17:04 |
| JayF | as a passing value for "yes they actually have a core group" | 17:04 |
| JayF | I think CI is saying "ironic has no core group;" | 17:05 |
| stephenfin | fungi: ty | 17:05 |
| stephenfin | JayF: Ah, good call | 17:05 |
| fungi | yes, i'm digging up the reference, just a sec | 17:05 |
| fungi | stephenfin: https://opendev.org/openstack/project-config/src/branch/master/tools/normalize_acl.py#L291-L302 | 17:05 |
| opendevreview | Stephen Finucane proposed openstack/project-config master: Remove references to ironic-core https://review.opendev.org/c/openstack/project-config/+/1003840 | 17:17 |
| opendevreview | Stephen Finucane proposed openstack/project-config master: Add approvers to the "special" groups https://review.opendev.org/c/openstack/project-config/+/1005094 | 17:17 |
| fungi | stephenfin: id in doubt, you can `tox -e gerrit` locally to check your change too | 17:19 |
| fungi | er, if in doubt | 17:19 |
| stephenfin | I realized that about 5 minutes ago :) | 17:19 |
| fungi | yeah, i always forget until after the first zuul -1 as well ;) | 17:20 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!