*** michchap_ has joined #openstack-ironic | 00:01 | |
*** michchap has quit IRC | 00:03 | |
openstackgerrit | A change was merged to openstack/ironic: Rename parameters https://review.openstack.org/56894 | 00:05 |
---|---|---|
Haomeng | devananda: see your comments about my shell unittest patch | 00:14 |
Haomeng | devananda: for the try/except handling, these code are removed by another patch already, so I will rebase, and just add updated_at and created_at fields, will not touch other code | 00:15 |
*** datajerk has quit IRC | 00:33 | |
*** hemna_ is now known as hemnafk | 00:43 | |
Haomeng | devananda: and for this bug - https://bugs.launchpad.net/ironic/+bug/1253426 , can you help to add comments about the recreating steps, I want to debug in deep | 00:51 |
Haomeng | devananda: thank you, good evening:) | 00:51 |
* NobodyCam wanders afk | 00:53 | |
*** michchap_ has quit IRC | 00:56 | |
*** michchap has joined #openstack-ironic | 00:59 | |
openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: ipmitool SHOULD accept empty username/password https://review.openstack.org/54886 | 00:59 |
openstackgerrit | Haomeng,Wang proposed a change to openstack/python-ironicclient: Enable created_at/updated_at for port-show/chassis-show https://review.openstack.org/53991 | 01:18 |
*** rongze has joined #openstack-ironic | 01:23 | |
*** rongze has quit IRC | 01:27 | |
*** nosnos has joined #openstack-ironic | 01:40 | |
*** arata has joined #openstack-ironic | 01:40 | |
*** nosnos has quit IRC | 01:40 | |
*** nosnos has joined #openstack-ironic | 01:41 | |
*** rongze has joined #openstack-ironic | 02:03 | |
*** sjing has joined #openstack-ironic | 02:36 | |
*** arata has quit IRC | 03:22 | |
openstackgerrit | A change was merged to openstack/ironic: Fix node lock in PXE driver https://review.openstack.org/55565 | 03:45 |
openstackgerrit | A change was merged to openstack/ironic: Fix integer division compatibility in middleware https://review.openstack.org/56613 | 03:47 |
*** arata has joined #openstack-ironic | 04:18 | |
*** rameshg87 has joined #openstack-ironic | 04:51 | |
*** rongze has quit IRC | 04:53 | |
*** mnbv has joined #openstack-ironic | 04:53 | |
rameshg87 | Hi | 04:54 |
rameshg87 | i had a question regarding ironic deployement | 04:54 |
*** arata has quit IRC | 05:00 | |
*** matsuhashi has joined #openstack-ironic | 05:06 | |
*** matsuhashi has quit IRC | 05:16 | |
*** matsuhashi has joined #openstack-ironic | 05:23 | |
Haomeng | rameshg87: welcome | 05:23 |
*** rongze has joined #openstack-ironic | 05:24 | |
*** rongze has quit IRC | 05:33 | |
openstackgerrit | Haomeng,Wang proposed a change to openstack/python-ironicclient: Enable created_at/updated_at for port-show/chassis-show https://review.openstack.org/57829 | 05:34 |
*** michchap has quit IRC | 05:40 | |
*** michchap has joined #openstack-ironic | 05:40 | |
*** prekarat has joined #openstack-ironic | 05:49 | |
*** prekarat has quit IRC | 05:50 | |
*** prekarat1 has joined #openstack-ironic | 05:50 | |
openstackgerrit | Jenkins proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/57832 | 06:00 |
rameshg87 | Hello Haomeng | 06:00 |
rameshg87 | i am sorry, i was out for a while | 06:01 |
Haomeng | rameshg87: np | 06:02 |
rameshg87 | i had a question regarding deployment | 06:02 |
rameshg87 | currently, in ironic, is there a way in to trigger a deploy request for pxe driver from api ? | 06:03 |
rameshg87 | i see there is an api hook for node/<node-id>/state/provision | 06:03 |
rameshg87 | but that seems to be not implemented yet | 06:04 |
Haomeng | rameshg87: good question, I have same concern, and I checked our Ironic code, the deploy functions is called from hypervisor ironic driver from nova side | 06:04 |
Haomeng | rameshg87: that is state I think | 06:04 |
Haomeng | rameshg87: if we have the api, should be deploy api | 06:04 |
rameshg87 | oh ok. | 06:05 |
rameshg87 | i also see this in controllers/v1/node.py | 06:05 |
rameshg87 | def put(self, node_id, target): """Set the provision state of the machine.""" #TODO(lucasagomes): Test if target is a valid state and if it's able # to transition to the target state from the current one # TODO(lucasagomes): rpcapi.start_provision_state_change() raise NotImplementedError() | 06:05 |
rameshg87 | some TODOs, i thought this was supposed to be for the deployment as well .. | 06:06 |
Haomeng | rameshg87: I think my understanding is correct, and you can double check with Ironic core team members | 06:06 |
Haomeng | rameshg87: and you can look the Ironic nova driver code to see how it is launched | 06:06 |
rameshg87 | okay. | 06:06 |
*** arata has joined #openstack-ironic | 06:06 | |
rameshg87 | but if my understanding is correct, that is still under construction, right ? | 06:06 |
Haomeng | rameshg87: I dont think so, looks like our Ironic will not have such public API to depoly pxe node | 06:07 |
*** arata has quit IRC | 06:07 | |
Haomeng | rameshg87: you can double check with our core members, maybe I am wrong understanding | 06:08 |
Haomeng | rameshg87: or just send to mail list | 06:08 |
rameshg87 | okay | 06:08 |
rameshg87 | is there a mailing list ? | 06:08 |
rameshg87 | i didn't see that anywhere :-) | 06:09 |
Haomeng | rameshg87: let me find out | 06:09 |
Haomeng | rameshg87: http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev | 06:10 |
Haomeng | rameshg87: you can subscribe | 06:10 |
rameshg87 | sure, i will do that .. | 06:10 |
rameshg87 | thanks | 06:10 |
Haomeng | rameshg87: or just send mail to the list with title "[openstack-dev] [Ironic] SUBJECT/TOPIC..." | 06:11 |
Haomeng | rameshg87: welcome:) | 06:11 |
openstackgerrit | Haomeng,Wang proposed a change to openstack/python-ironicclient: Enable created_at/updated_at for port-show/chassis-show https://review.openstack.org/57829 | 06:12 |
Haomeng | rameshg87: Ramesh, suggest you use gmail to subscribe the maillist | 06:13 |
Haomeng | rameshg87: or other BIG mailbox, because the openstack maillist has a lot of mail each day | 06:14 |
Haomeng | rameshg87: :) | 06:14 |
*** michchap has quit IRC | 06:19 | |
*** michchap has joined #openstack-ironic | 06:26 | |
*** rongze has joined #openstack-ironic | 06:37 | |
*** matsuhashi has quit IRC | 06:44 | |
*** matsuhas_ has joined #openstack-ironic | 06:49 | |
*** matsuhas_ has quit IRC | 06:56 | |
*** romcheg has joined #openstack-ironic | 07:02 | |
*** matsuhashi has joined #openstack-ironic | 07:03 | |
*** sjing has quit IRC | 07:05 | |
*** sjing has joined #openstack-ironic | 07:07 | |
*** urulama has joined #openstack-ironic | 07:22 | |
GheRivero | morning Ironic | 07:38 |
*** ndipanov_gone is now known as ndipanov | 07:50 | |
*** romcheg has quit IRC | 08:02 | |
*** tatyana has joined #openstack-ironic | 08:04 | |
openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Replace uuidutils.generate_uuid() with str(uuid.uuid4()) https://review.openstack.org/57854 | 08:07 |
*** arata has joined #openstack-ironic | 08:14 | |
*** urulama_ has joined #openstack-ironic | 08:15 | |
*** urulama has quit IRC | 08:17 | |
*** romcheg has joined #openstack-ironic | 08:21 | |
rameshg87 | Haomeng: thanks :-) | 08:23 |
rameshg87 | i will do that .. | 08:24 |
*** romcheg1 has joined #openstack-ironic | 08:26 | |
*** romcheg has quit IRC | 08:28 | |
*** nosnos_ has joined #openstack-ironic | 08:31 | |
*** ndipanov has quit IRC | 08:31 | |
*** nosnos has quit IRC | 08:35 | |
*** tatyana has quit IRC | 08:36 | |
*** tatyana has joined #openstack-ironic | 08:36 | |
*** sjing has quit IRC | 08:37 | |
*** ndipanov has joined #openstack-ironic | 08:46 | |
*** jistr has joined #openstack-ironic | 09:00 | |
*** nosnos_ has quit IRC | 09:04 | |
openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Replace uuidutils.generate_uuid() with str(uuid.uuid4()) https://review.openstack.org/57854 | 09:05 |
*** nosnos has joined #openstack-ironic | 09:05 | |
GheRivero | Haomeng: a couple of issues with the 57854 patch | 09:08 |
GheRivero | forgot one generate_uuid at ironic/db/api.py | 09:09 |
GheRivero | the openstack/common/* files are synced from oslo-incubator using the oslo-incubator/update.sh utility, so no need to edit or remove them | 09:10 |
Haomeng | GheRivero: yes, let me check ,thank you | 09:14 |
*** derekh has joined #openstack-ironic | 09:15 | |
Haomeng | GheRivero: I run "git rm", looks like that is not we expected "D ironic/openstack/common/context.py" | 09:15 |
Haomeng | GheRivero: how can we recover the "D" flag? "D ironic/openstack/common/context.py" should not be in our change list I think | 09:15 |
Haomeng | Haomeng: generate_uuid at ironic/db/api.py, it is in coments, let me change it also? | 09:17 |
Haomeng | GheRivero: I think so:) | 09:17 |
GheRivero | didn't know is was on comments. just did a quick grep, but will help anyway | 09:18 |
GheRivero | about the D flag. No idea. check that in your local git. maybe it was removed accidentally | 09:19 |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Fix port address unique constraint for sqlite https://review.openstack.org/57722 | 09:19 |
Haomeng | GheRivero: np, let me change at the same time | 09:19 |
Haomeng | GheRivero: help me, now in new patch, there is such change - "D ironic/openstack/common/context.py" | 09:20 |
Haomeng | GheRivero: I think that is done by my wrong operation - "git rm ironic/openstack/common/context.py" | 09:20 |
GheRivero | :) | 09:21 |
Haomeng | GheRivero: how can I restore it? I am not sure | 09:21 |
Haomeng | GheRivero: :) | 09:21 |
Haomeng | GheRivero: I dont want to delete it from our source, just remove from my patch | 09:21 |
Haomeng | GheRivero: help me:) | 09:21 |
Haomeng | GheRivero: should I recreate git workspace, and recommit with old changid? | 09:22 |
GheRivero | git git checkout HEAD~1 -- ironic/openstack/common/context.py | 09:22 |
Haomeng | GheRivero: got, thank you | 09:22 |
*** lucasagomes has joined #openstack-ironic | 09:23 | |
openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Replace uuidutils.generate_uuid() with str(uuid.uuid4()) https://review.openstack.org/57854 | 09:23 |
Haomeng | GheRivero: working, cool | 09:23 |
openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: ipmitool SHOULD accept empty username/password https://review.openstack.org/54886 | 09:28 |
*** matsuhashi has quit IRC | 09:29 | |
*** matsuhashi has joined #openstack-ironic | 09:30 | |
*** ndipanov has quit IRC | 09:38 | |
openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Replace uuidutils.generate_uuid() with str(uuid.uuid4()) https://review.openstack.org/57854 | 09:41 |
*** martyntaylor has joined #openstack-ironic | 09:41 | |
*** rameshg87 has quit IRC | 09:48 | |
*** arata has quit IRC | 09:48 | |
*** ndipanov has joined #openstack-ironic | 09:50 | |
openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Replace uuidutils.generate_uuid() with str(uuid.uuid4()) https://review.openstack.org/57854 | 10:29 |
*** romcheg1 is now known as romcheg | 10:30 | |
*** prekarat1 has quit IRC | 10:35 | |
*** urulama has joined #openstack-ironic | 10:36 | |
*** urulama_ has quit IRC | 10:39 | |
romcheg | Morning all | 10:44 |
GheRivero | morning | 10:45 |
max_lobur_afk | g'morning | 10:47 |
romcheg | I'm planning to mark the new ironic jobs as non-voting ones. | 10:53 |
romcheg | The problem is that The patch to tempest that introduces API tests for Ironic cannot be tested until Ironic is enabled in devstack gates | 10:54 |
romcheg | But I think adding ironic jobs to tempest as voting may cause certain problems | 10:55 |
romcheg | What do you guys think? | 10:58 |
romcheg | lucasagomes: Are there any ongoing patches that might change API and eventually break tempest tests? | 10:59 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: API ports update for WSME 0.5b6 compliance https://review.openstack.org/56682 | 10:59 |
lucasagomes | romcheg, my idea is not to break anything that exist today | 11:00 |
lucasagomes | just add more tests | 11:00 |
lucasagomes | and remove complexity, but things that are current working should remain working | 11:00 |
romcheg | Good news :) | 11:00 |
*** urulama has quit IRC | 11:01 | |
lucasagomes | romcheg, ur using the client to interact with the API? | 11:02 |
*** mnbv has quit IRC | 11:08 | |
romcheg | lucasagomes: nope | 11:09 |
romcheg | in tempest there are several tools to interract with the API directly | 11:09 |
lucasagomes | ahh cause currently we have an attribute on Ports and Nodes that will be remove | 11:09 |
lucasagomes | currently we have node_id = <uuid> on Ports for example | 11:09 |
lucasagomes | I will rename it to node_uuid = <uuid> | 11:09 |
lucasagomes | to be more consistent | 11:10 |
lucasagomes | so it might affect u | 11:10 |
*** urulama has joined #openstack-ironic | 11:13 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Rework patch validation on Ports https://review.openstack.org/56984 | 11:17 |
*** tatyana has joined #openstack-ironic | 11:17 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Rework patch validation on Ports https://review.openstack.org/56984 | 11:20 |
*** max_lobur_afk has quit IRC | 11:30 | |
*** max_lobur has joined #openstack-ironic | 11:33 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Reworks Node validations https://review.openstack.org/57495 | 11:37 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Reworks Node validations https://review.openstack.org/57495 | 11:38 |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Fix port address unique constraint for sqlite https://review.openstack.org/57722 | 11:40 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Reworks Chassis validations https://review.openstack.org/57686 | 11:49 |
Haomeng | morning all:) | 12:01 |
*** matsuhashi has quit IRC | 12:09 | |
*** matsuhashi has joined #openstack-ironic | 12:10 | |
*** matsuhashi has quit IRC | 12:15 | |
*** dmojoryder has left #openstack-ironic | 12:17 | |
*** michchap has quit IRC | 12:23 | |
*** michchap has joined #openstack-ironic | 12:23 | |
*** lucasagomes is now known as lucas-hungry | 12:29 | |
*** michchap has quit IRC | 12:45 | |
*** michchap has joined #openstack-ironic | 12:46 | |
*** jbjohnso has joined #openstack-ironic | 13:11 | |
*** jdob has joined #openstack-ironic | 13:33 | |
*** lucas-hungry is now known as lucasagomes | 13:34 | |
*** ndipanov has quit IRC | 13:37 | |
*** nosnos has quit IRC | 13:38 | |
*** michchap has quit IRC | 13:58 | |
*** michchap has joined #openstack-ironic | 14:01 | |
max_lobur | Hi everyone! does anybody familiar with pecan application config and so on? I've posted a bug https://bugs.launchpad.net/ironic/+bug/1254002 but not sure if I correctly described a solution | 14:07 |
max_lobur | please take a look | 14:07 |
*** michchap has quit IRC | 14:14 | |
*** michchap has joined #openstack-ironic | 14:14 | |
*** prekarat has joined #openstack-ironic | 14:16 | |
*** linggao has joined #openstack-ironic | 14:25 | |
*** ndipanov has joined #openstack-ironic | 14:26 | |
*** jdob has quit IRC | 14:31 | |
*** jdob has joined #openstack-ironic | 14:31 | |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Don't allow set reservation at update node https://review.openstack.org/55549 | 14:48 |
*** martyntaylor has quit IRC | 14:52 | |
*** jdob has quit IRC | 14:52 | |
*** jdob has joined #openstack-ironic | 14:52 | |
*** russellb is now known as rustlebee | 14:59 | |
NobodyCam | good morning Ironic | 15:02 |
*** ndipanov is now known as nick_long | 15:03 | |
*** lucasagomes has quit IRC | 15:06 | |
*** urulama has quit IRC | 15:15 | |
*** urulama has joined #openstack-ironic | 15:20 | |
*** lucasagomes has joined #openstack-ironic | 15:21 | |
GheRivero | morning all | 15:27 |
NobodyCam | Good Morning GheRivero | 15:27 |
GheRivero | hey NobodyCam, I was just reading all the irc logs about the dnsmasq conversation you have with dkehn and devananda | 15:28 |
NobodyCam | ya its not dnsmasq. we will need neutron's dhcp | 15:28 |
GheRivero | yeah, the only thing needed will be a way to tell neutron the new dhcp options when a tftp/conductor dies | 15:29 |
GheRivero | ig i got that right | 15:29 |
NobodyCam | :) ya | 15:29 |
GheRivero | s/ig/if/ | 15:29 |
lucasagomes | morning GheRivero NobodyCam | 15:30 |
GheRivero | lovely :)and more easy | 15:30 |
GheRivero | morning lucasagomes | 15:30 |
NobodyCam | morning lucasagomes | 15:30 |
NobodyCam | :) | 15:30 |
NobodyCam | oh sounds like the coffee is almost ready | 15:30 |
*** urulama has quit IRC | 15:33 | |
*** urulama has joined #openstack-ironic | 15:40 | |
*** rongze has quit IRC | 15:45 | |
*** romcheg has quit IRC | 15:47 | |
*** prekarat has left #openstack-ironic | 15:50 | |
*** prekarat has joined #openstack-ironic | 15:50 | |
*** urulama has quit IRC | 15:50 | |
*** urulama has joined #openstack-ironic | 15:51 | |
*** urulama has quit IRC | 15:59 | |
*** urulama has joined #openstack-ironic | 16:00 | |
*** rongze has joined #openstack-ironic | 16:04 | |
*** datajerk has joined #openstack-ironic | 16:09 | |
*** urulama has quit IRC | 16:10 | |
*** urulama has joined #openstack-ironic | 16:10 | |
NobodyCam | lucasagomes: you see https://bugs.launchpad.net/python-ironicclient/+bug/1253798 | 16:13 |
* lucasagomes clicks | 16:13 | |
lucasagomes | I see, it might be a question of adding 'chassis_id' to the list of attr to be displayed | 16:15 |
*** urulama has quit IRC | 16:15 | |
lucasagomes | I'm have patches upstream that will rename chassis_id to chassis_uuid on the API objects | 16:15 |
lucasagomes | so hmm ahh forget my last sentence, I can fix that bug before | 16:16 |
lucasagomes | might be quick | 16:16 |
NobodyCam | heheh | 16:16 |
*** romcheg has joined #openstack-ironic | 16:18 | |
*** urulama has joined #openstack-ironic | 16:19 | |
*** urulama has quit IRC | 16:29 | |
*** urulama has joined #openstack-ironic | 16:29 | |
max_lobur | Everyone have a nice weekend | 16:31 |
NobodyCam | you too max_lobur :) | 16:31 |
*** rongze_ has joined #openstack-ironic | 16:32 | |
*** rongze has quit IRC | 16:32 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/python-ironicclient: Include 'chassis_id' on node-show https://review.openstack.org/57970 | 16:33 |
*** max_lobur has quit IRC | 16:33 | |
lucasagomes | NobodyCam, ^ | 16:33 |
NobodyCam | oh .. :) /me looks | 16:33 |
NobodyCam | :) | 16:34 |
lucasagomes | I alpha sorted that list, to make it easy to ready | 16:36 |
lucasagomes | should put it on the commit message tho | 16:36 |
lucasagomes | lemme change it | 16:36 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/python-ironicclient: Include 'chassis_id' on node-show https://review.openstack.org/57970 | 16:37 |
*** urulama has quit IRC | 16:39 | |
*** urulama has joined #openstack-ironic | 16:39 | |
NobodyCam | gah Filter ComputeCapabilitiesFilter returned 0 hosts :-p | 16:45 |
*** urulama has quit IRC | 16:49 | |
*** urulama_ has joined #openstack-ironic | 16:49 | |
devananda | morning, all | 16:52 |
GheRivero | morning | 16:53 |
lucasagomes | devananda, morning | 16:53 |
NobodyCam | Good morning devananda | 16:53 |
*** urulama_ has quit IRC | 16:54 | |
NobodyCam | bbt ... brb | 16:59 |
*** urulama has joined #openstack-ironic | 16:59 | |
*** dkehn has quit IRC | 16:59 | |
*** derekh has quit IRC | 17:00 | |
*** dkehn has joined #openstack-ironic | 17:00 | |
devananda | NobodyCam: ah. probably extra_specs is not set right? | 17:02 |
NobodyCam | devananda: http://paste.openstack.org/show/1BQhCePUb89GZiZuXvFf/ | 17:07 |
*** urulama has quit IRC | 17:08 | |
*** urulama has joined #openstack-ironic | 17:09 | |
NobodyCam | quick post bubbie breakfast walkies | 17:10 |
*** arata has joined #openstack-ironic | 17:17 | |
*** arata has left #openstack-ironic | 17:17 | |
*** urulama has quit IRC | 17:18 | |
*** urulama has joined #openstack-ironic | 17:19 | |
*** urulama has quit IRC | 17:24 | |
*** jistr has quit IRC | 17:27 | |
NobodyCam | walkies done | 17:28 |
*** urulama has joined #openstack-ironic | 17:28 | |
*** nick_long has quit IRC | 17:32 | |
*** urulama has quit IRC | 17:38 | |
*** urulama_ has joined #openstack-ironic | 17:38 | |
*** urulama_ has quit IRC | 17:48 | |
*** urulama has joined #openstack-ironic | 17:48 | |
*** tatyana has quit IRC | 17:49 | |
*** hemnafk is now known as hemna_ | 17:51 | |
*** urulama has quit IRC | 17:54 | |
*** rongze has joined #openstack-ironic | 17:57 | |
*** urulama has joined #openstack-ironic | 17:58 | |
*** rongze_ has quit IRC | 18:01 | |
devananda | NobodyCam: nova flavor-show baremetal | 18:06 |
*** romcheg has quit IRC | 18:07 | |
*** urulama has quit IRC | 18:08 | |
*** urulama_ has joined #openstack-ironic | 18:08 | |
devananda | lucasagomes: is 56682 still WIP ? | 18:12 |
lucasagomes | devananda, nop i think I finished it today | 18:12 |
devananda | :) | 18:13 |
lucasagomes | I totally removed the node_id/chassis_id attrs | 18:13 |
lucasagomes | from the API | 18:13 |
lucasagomes | I create it dynamically when node_uuid/chassis_uuid is created | 18:13 |
lucasagomes | is populated* | 18:13 |
lucasagomes | which seems more elegant (and don't appear on the documentation :D) | 18:13 |
devananda | nice | 18:13 |
openstackgerrit | A change was merged to openstack/python-ironicclient: Enable created_at/updated_at for port-show/chassis-show https://review.openstack.org/53991 | 18:14 |
openstackgerrit | A change was merged to openstack/python-ironicclient: Include 'chassis_id' on node-show https://review.openstack.org/57970 | 18:16 |
*** urulama has joined #openstack-ironic | 18:18 | |
*** urulama_ has quit IRC | 18:18 | |
*** urulama has quit IRC | 18:22 | |
devananda | lucasagomes: looks like 57026 needs rebase | 18:24 |
lucasagomes | devananda, ah ohh | 18:24 |
lucasagomes | lemme rebase it | 18:24 |
lucasagomes | and thanks for the explanation on the migration scripts | 18:25 |
lucasagomes | so we never touch it | 18:25 |
*** urulama has joined #openstack-ironic | 18:27 | |
devananda | yea. changing history like that leads to divergent user databases | 18:28 |
devananda | imagine user A who already ran 006. and user B who didn't | 18:28 |
lucasagomes | gotcha yea I kinda thought about it | 18:28 |
devananda | now they have different DB states | 18:28 |
lucasagomes | but as it only affected tests (sqlite) | 18:28 |
lucasagomes | and we recreate the db all the time for tests | 18:28 |
devananda | well, maybe you do | 18:29 |
lucasagomes | I thought it would _might_ be alright | 18:29 |
lucasagomes | as I commented | 18:29 |
openstackgerrit | A change was merged to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/57832 | 18:29 |
devananda | yes. if we assume no one ever uses sqlite outside of testing,a nd they always do a full recreate, then sure | 18:29 |
devananda | (i think those are flawed assumptions, FWIW) | 18:29 |
devananda | even so, it's a bad precedent to set | 18:29 |
devananda | especiallywhen it's not necessary -- a new migration could easily correct this | 18:29 |
devananda | ok, i need to get ready. lunch plans. i'll be semi-around for next 45 min, then gone, then back a few hours later | 18:30 |
lucasagomes | cool, yea gotcha | 18:30 |
lucasagomes | thanks :) | 18:31 |
devananda | wil ltry to review your WSME patch today | 18:31 |
openstackgerrit | A change was merged to openstack/ironic: ipmitool SHOULD accept empty username/password https://review.openstack.org/54886 | 18:31 |
devananda | and fix my oslo.db patch ... <grumble> | 18:31 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Import HasLength object https://review.openstack.org/57026 | 18:31 |
lucasagomes | rebased | 18:31 |
devananda | k, i'll approve once jenkins +'s | 18:34 |
*** romcheg has joined #openstack-ironic | 18:35 | |
*** urulama_ has joined #openstack-ironic | 18:37 | |
*** urulama has quit IRC | 18:38 | |
lucasagomes | alright! I'm done for the day | 18:39 |
lucasagomes | devananda, have a good night/weekend :) | 18:39 |
NobodyCam | night lucas ... have a good weekend | 18:42 |
*** rongze has quit IRC | 18:42 | |
lucasagomes | night NobodyCam :) enjoy the weekend! | 18:42 |
lucasagomes | ttyl | 18:43 |
*** lucasagomes has quit IRC | 18:43 | |
openstackgerrit | A change was merged to openstack/ironic: Import HasLength object https://review.openstack.org/57026 | 18:50 |
*** urulama_ has quit IRC | 18:50 | |
NobodyCam | brb | 18:54 |
devananda | bbiafh | 18:56 |
*** tatyana has joined #openstack-ironic | 18:59 | |
*** tatyana has quit IRC | 19:04 | |
devananda | well, i'm back :) | 19:20 |
NobodyCam | ??? | 19:21 |
NobodyCam | welcome back | 19:21 |
*** jdob has quit IRC | 19:28 | |
*** jdob has joined #openstack-ironic | 19:32 | |
devananda | hm, i see several abandoned patches taht were actually valuable | 19:38 |
devananda | where there were -1's and the author didn't update | 19:38 |
devananda | i'm going to fix them | 19:38 |
*** rongze has joined #openstack-ironic | 19:43 | |
*** rongze has quit IRC | 19:48 | |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Add tftp_server to pxe config options https://review.openstack.org/58016 | 19:52 |
devananda | ok, just one :) | 20:14 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Implement sync_power_state periodic task https://review.openstack.org/56530 | 20:15 |
*** urulama has joined #openstack-ironic | 20:25 | |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Sync common.db.sqlalchemy changes from olso https://review.openstack.org/56516 | 20:26 |
*** romcheg has left #openstack-ironic | 20:35 | |
*** urulama has quit IRC | 20:35 | |
*** urulama has joined #openstack-ironic | 20:36 | |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Sync common.db.sqlalchemy changes from olso https://review.openstack.org/56516 | 20:36 |
*** urulama has quit IRC | 20:45 | |
*** urulama has joined #openstack-ironic | 20:45 | |
NobodyCam | brb | 20:49 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Sync common.db.sqlalchemy changes from olso https://review.openstack.org/56516 | 20:50 |
*** urulama has quit IRC | 20:50 | |
devananda | think i got it right this time :) | 20:50 |
*** urulama has joined #openstack-ironic | 20:55 | |
*** urulama has quit IRC | 21:04 | |
devananda | yarrrgh | 21:05 |
*** urulama has joined #openstack-ironic | 21:05 | |
NobodyCam | LOL | 21:05 |
devananda | ImportError: No module named lockfile | 21:05 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Sync common.db.sqlalchemy changes from olso https://review.openstack.org/56516 | 21:07 |
devananda | right. now we have an interesting error | 21:13 |
devananda | mikal: you ported some of the oslo lock utils that affected the pgsql tests recently | 21:14 |
*** linggao has quit IRC | 21:14 | |
devananda | mikal: i looked at that work, and saw some changes in oslo since then, and pulled those into my patch syncing the db.sqla.migrate stuff from oslo | 21:14 |
devananda | mikal: and now, here's a new error. wondering if you've seen it before: http://logs.openstack.org/16/56516/9/check/gate-ironic-python27/4d9b449/console.html | 21:14 |
*** urulama has quit IRC | 21:15 | |
*** urulama has joined #openstack-ironic | 21:15 | |
mikal | devananda: oh, the lock directory stuff changed in lockutils | 21:22 |
mikal | I think you need to set an env var to somewhere jenkins can write to | 21:23 |
devananda | oh. so the lockutils changes require infra/config changes? | 21:23 |
mikal | I thought the default was reasonable | 21:23 |
mikal | I might be wrong | 21:23 |
mikal | Bearing in mind I've been awake for ten minutes | 21:24 |
mikal | Hmmm, I'm lying | 21:24 |
*** urulama has quit IRC | 21:24 | |
mikal | lock_path is only set wiht an env var if you call set_defaults() | 21:25 |
*** urulama has joined #openstack-ironic | 21:25 | |
mikal | No sorry, my first reading was right | 21:26 |
mikal | The default value for lock path is default=os.environ.get("OSLO_LOCK_PATH") | 21:26 |
mikal | devananda: https://review.openstack.org/#/c/53391/7/openstack/common/lockutils.py | 21:28 |
mikal | devananda: so previously you had to specify a value (no default), but now that value can be in an env var | 21:29 |
mikal | Are you setting lock_path? | 21:29 |
*** urulama has quit IRC | 21:29 | |
devananda | i haven't added it recently | 21:30 |
devananda | so probably not | 21:30 |
*** jistr has joined #openstack-ironic | 21:33 | |
devananda | mikal: looks like OLSO_LOCK_PATH -> IRONIC_LOCK_PATH was successful | 21:34 |
devananda | http://git.openstack.org/cgit/openstack/ironic/tree/ironic/openstack/common/lockutils.py#n46 | 21:34 |
mikal | Oh yeah, update.py rewrites it | 21:34 |
*** urulama has joined #openstack-ironic | 21:34 | |
devananda | yea | 21:36 |
devananda | mikal: I dont see any "export *_LOCK_PATH" in infra/config yet | 21:39 |
devananda | for any project | 21:39 |
*** urulama_ has joined #openstack-ironic | 21:44 | |
*** urulama has quit IRC | 21:45 | |
mikal | devananda: huh | 21:45 |
mikal | devananda: does the ironic code set lock_path anywhere? | 21:45 |
*** rainya has joined #openstack-ironic | 21:48 | |
devananda | mikal: looks like it does not | 21:53 |
*** urulama has joined #openstack-ironic | 21:54 | |
*** urulama_ has quit IRC | 21:54 | |
mikal | devananda: hmmm, nova uses the default in most places too | 21:55 |
devananda | hmm | 21:55 |
*** urulama has quit IRC | 21:59 | |
*** urulama has joined #openstack-ironic | 22:04 | |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Sync common.db.sqlalchemy changes from olso https://review.openstack.org/56516 | 22:07 |
devananda | testing a port of the old fixtures.TempDir ^ | 22:09 |
*** jistr has quit IRC | 22:10 | |
*** urulama has quit IRC | 22:13 | |
*** urulama has joined #openstack-ironic | 22:14 | |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Sync common.db.sqlalchemy changes from olso https://review.openstack.org/56516 | 22:14 |
*** jdob has quit IRC | 22:18 | |
*** urulama has quit IRC | 22:23 | |
*** urulama has joined #openstack-ironic | 22:24 | |
devananda | and matching fix proposed to oslo. with that, i need to run! have a good weekend all! | 22:26 |
*** urulama has quit IRC | 22:33 | |
*** urulama has joined #openstack-ironic | 22:34 | |
*** urulama has quit IRC | 22:38 | |
*** urulama has joined #openstack-ironic | 22:43 | |
*** urulama has quit IRC | 22:53 | |
*** urulama_ has joined #openstack-ironic | 22:53 | |
*** urulama has joined #openstack-ironic | 23:03 | |
*** urulama_ has quit IRC | 23:03 | |
*** urulama has quit IRC | 23:08 | |
*** urulama has joined #openstack-ironic | 23:12 | |
*** urulama_ has joined #openstack-ironic | 23:22 | |
*** urulama has quit IRC | 23:23 | |
*** urulama_ has quit IRC | 23:32 | |
*** urulama has joined #openstack-ironic | 23:32 | |
*** urulama has quit IRC | 23:37 | |
openstackgerrit | Haomeng,Wang proposed a change to openstack/python-ironicclient: Enable created_at/updated_at for port-show/chassis-show https://review.openstack.org/57829 | 23:42 |
*** urulama has joined #openstack-ironic | 23:42 | |
NobodyCam | humm | 23:47 |
openstackgerrit | Haomeng,Wang proposed a change to openstack/python-ironicclient: Enable created_at/updated_at for port-show/chassis-show https://review.openstack.org/57829 | 23:52 |
*** urulama_ has joined #openstack-ironic | 23:52 | |
*** urulama has quit IRC | 23:52 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!