*** rongze has quit IRC | 00:03 | |
*** jcooley_ has joined #openstack-ironic | 00:48 | |
*** jcooley_ has quit IRC | 00:50 | |
*** jcooley_ has joined #openstack-ironic | 00:52 | |
*** jcooley_ has quit IRC | 01:08 | |
*** docaedo has quit IRC | 01:08 | |
*** jcooley_ has joined #openstack-ironic | 01:11 | |
*** nosnos has joined #openstack-ironic | 01:48 | |
*** nosnos has quit IRC | 01:48 | |
*** nosnos has joined #openstack-ironic | 01:49 | |
*** jcooley_ has quit IRC | 01:55 | |
*** jcooley_ has joined #openstack-ironic | 02:03 | |
*** docaedo has joined #openstack-ironic | 02:14 | |
*** rongze has joined #openstack-ironic | 02:26 | |
*** jcooley_ has quit IRC | 02:56 | |
*** jcooley_ has joined #openstack-ironic | 03:04 | |
*** mwagner_lap has quit IRC | 03:27 | |
*** mwagner_lap has joined #openstack-ironic | 04:09 | |
*** nosnos_ has joined #openstack-ironic | 04:28 | |
*** nosnos has quit IRC | 04:31 | |
*** rongze has quit IRC | 04:54 | |
*** datajerk has joined #openstack-ironic | 04:58 | |
*** prekarat has joined #openstack-ironic | 05:00 | |
*** Haomeng has joined #openstack-ironic | 05:16 | |
*** rongze has joined #openstack-ironic | 05:37 | |
*** rongze has quit IRC | 05:42 | |
*** nosnos_ has quit IRC | 05:57 | |
*** nosnos has joined #openstack-ironic | 05:58 | |
openstackgerrit | Jenkins proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/59627 | 06:00 |
---|---|---|
*** rongze has joined #openstack-ironic | 06:39 | |
*** arata has joined #openstack-ironic | 06:44 | |
*** rongze has quit IRC | 06:45 | |
*** rongze has joined #openstack-ironic | 06:59 | |
*** nosnos has quit IRC | 07:01 | |
*** nosnos has joined #openstack-ironic | 07:01 | |
*** jcooley_ has quit IRC | 07:18 | |
*** mdurnosvistov has joined #openstack-ironic | 07:27 | |
*** jcooley_ has joined #openstack-ironic | 07:29 | |
*** jcooley_ has quit IRC | 07:41 | |
*** jcooley_ has joined #openstack-ironic | 07:42 | |
*** jcooley_ has quit IRC | 07:46 | |
*** nick_long has joined #openstack-ironic | 08:06 | |
*** viktors has joined #openstack-ironic | 08:08 | |
*** nick_long is now known as ndipanov | 08:09 | |
*** ndipanov has quit IRC | 08:09 | |
*** hughsaunders has quit IRC | 08:09 | |
*** olukanina has joined #openstack-ironic | 08:17 | |
*** mdurnosvistov has quit IRC | 08:18 | |
*** olukanina has quit IRC | 08:23 | |
*** hughsaunders has joined #openstack-ironic | 08:25 | |
*** jimjiang_ has joined #openstack-ironic | 08:31 | |
*** diaron has joined #openstack-ironic | 08:32 | |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Strip '/' from api_url string for PXE driver https://review.openstack.org/60205 | 08:33 |
openstackgerrit | Fengqian.gao proposed a change to stackforge/pyghmi: Add BMC bridge request extension https://review.openstack.org/60768 | 08:34 |
*** ivanoww has joined #openstack-ironic | 08:44 | |
*** ivanoww has quit IRC | 08:45 | |
*** ifarkas has joined #openstack-ironic | 08:51 | |
*** jistr has joined #openstack-ironic | 09:03 | |
*** vkozhukalov has joined #openstack-ironic | 09:14 | |
*** derekh has joined #openstack-ironic | 09:25 | |
*** tatyana has joined #openstack-ironic | 09:25 | |
*** lucasagomes has joined #openstack-ironic | 09:25 | |
*** hughsaunders has quit IRC | 09:28 | |
*** ndipanov has joined #openstack-ironic | 09:30 | |
*** hughsaunders has joined #openstack-ironic | 09:32 | |
*** hughsaunders has quit IRC | 09:52 | |
*** linuxmonk has joined #openstack-ironic | 10:00 | |
*** hughsaunders has joined #openstack-ironic | 10:02 | |
*** max_lobur_afk is now known as max_lobur | 10:02 | |
*** nosnos has quit IRC | 10:07 | |
*** nosnos has joined #openstack-ironic | 10:07 | |
*** slepoj has joined #openstack-ironic | 10:07 | |
*** slepoj has quit IRC | 10:08 | |
*** gadddd has joined #openstack-ironic | 10:11 | |
*** gadddd has quit IRC | 10:15 | |
*** titanic has joined #openstack-ironic | 10:18 | |
*** viktors has quit IRC | 10:22 | |
*** titanic has quit IRC | 10:41 | |
*** yfujioka has joined #openstack-ironic | 10:43 | |
*** viktors has joined #openstack-ironic | 10:59 | |
*** rongze has quit IRC | 11:17 | |
*** arata has left #openstack-ironic | 11:19 | |
*** rongze has joined #openstack-ironic | 11:26 | |
*** mdurnosvistov has joined #openstack-ironic | 11:35 | |
*** urulama has joined #openstack-ironic | 11:40 | |
*** linuxmonk has quit IRC | 11:41 | |
*** rongze has quit IRC | 11:58 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Port StringType class from WSME trunk https://review.openstack.org/60798 | 12:00 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Add PatchType class https://review.openstack.org/60194 | 12:09 |
*** yfujioka has quit IRC | 12:13 | |
*** lucasagomes is now known as lucas-hungry | 12:34 | |
*** rongze has joined #openstack-ironic | 12:40 | |
*** max_lobur is now known as max_lobur_afk | 12:52 | |
*** chillroom has joined #openstack-ironic | 12:59 | |
*** chillroom has joined #openstack-ironic | 13:00 | |
*** urulama has quit IRC | 13:09 | |
*** chillroom has quit IRC | 13:10 | |
*** mwagner_lap has quit IRC | 13:11 | |
*** nosnos has quit IRC | 13:13 | |
*** ekarlso- has quit IRC | 13:23 | |
*** ekarlso has joined #openstack-ironic | 13:23 | |
*** rongze has quit IRC | 13:25 | |
*** lucas-hungry is now known as lucasagomes | 13:31 | |
*** rongze has joined #openstack-ironic | 13:41 | |
*** peropavlina has joined #openstack-ironic | 13:41 | |
*** jdob has joined #openstack-ironic | 13:46 | |
*** rloo has joined #openstack-ironic | 13:47 | |
*** max_lobur_afk is now known as max_lobur | 14:06 | |
*** matty_dubs|gone is now known as matty_dubs | 14:21 | |
*** prekarat has quit IRC | 14:22 | |
*** prekarat has joined #openstack-ironic | 14:25 | |
NobodyCam | good morning Ironic | 14:54 |
dkehn | NobodyCam: morning | 14:57 |
NobodyCam | morning dkehn :) have a good weekend? | 14:58 |
dkehn | NobodyCam: yes, very cold here, so hunkered down | 14:59 |
NobodyCam | ya.. I'll bet... cold here. gota be in the 40's :_p | 15:00 |
dkehn | NobodyCam: whats normal in the winter | 15:00 |
NobodyCam | about that.. I'd say it just a bit below normal here | 15:01 |
max_lobur | morning Ironic :) | 15:01 |
*** shadower has quit IRC | 15:01 | |
NobodyCam | mornig max_lobur :) | 15:02 |
dkehn | NobodyCam: way below normal here, even the ski slopes are too cold, but the snow up there is good | 15:02 |
*** rongze has quit IRC | 15:02 | |
NobodyCam | :) hehhe snow is too cold | 15:03 |
*** rongze has joined #openstack-ironic | 15:03 | |
dkehn | snow isn't bad , but clear no clouds the temp just drops, re-thinking heading south for the winter, soon | 15:04 |
NobodyCam | :) thats what I did | 15:04 |
*** jdob has quit IRC | 15:05 | |
dkehn | Usually doesn't get this cold , here but it does flood like it did either, I think the climate is changing | 15:06 |
NobodyCam | gore was right :-p | 15:06 |
NobodyCam | oh wait that would mean it would be warmer now :-p | 15:07 |
dkehn | so if there are no more review issues I'm going to get on the generate_sample again | 15:07 |
dkehn | so you might hear from me today | 15:07 |
*** shadower has joined #openstack-ironic | 15:07 | |
NobodyCam | :) | 15:07 |
dkehn | I'm thinking its something I'm not doing right, because when it parses the .pyc (note you must compile it 1st) it doesn't see my cftStr, where woould be a good place(wiki) to document, so I don't have to relearn this again | 15:09 |
dkehn | note that anyone else would do this | 15:09 |
NobodyCam | dkehn: prob jst a a section to https://wiki.openstack.org/wiki/Ironic | 15:14 |
dkehn | NobodyCam: ok, great | 15:14 |
NobodyCam | brb | 15:17 |
*** rustlebee is now known as russellb | 15:17 | |
*** jdob has joined #openstack-ironic | 15:22 | |
*** rongze has quit IRC | 15:30 | |
*** rongze has joined #openstack-ironic | 15:30 | |
*** ifarkas has quit IRC | 15:50 | |
*** mdurnosvistov has quit IRC | 15:56 | |
*** vkozhukalov has quit IRC | 16:20 | |
NobodyCam | brb again :-p | 16:32 |
*** romcheg has joined #openstack-ironic | 16:33 | |
NobodyCam | romcheg: fyi Just ate the last if the chocolate lastnght :) | 16:38 |
NobodyCam | it was very yummy... Thank you :) | 16:39 |
romcheg | Morning NobodyCam :) | 16:39 |
NobodyCam | :) | 16:39 |
romcheg | My pleasure | 16:39 |
*** gurkafa has joined #openstack-ironic | 16:40 | |
*** gurkafa has quit IRC | 16:40 | |
romcheg | NobodyCam: Was it pepper, salt of cherry? | 16:41 |
NobodyCam | salt :) | 16:41 |
NobodyCam | went great with night time coffee | 16:41 |
romcheg | Since this Lviv Chocolatier opened in Kharkiv, I go there every week to get more different chocolate | 16:43 |
romcheg | NobodyCam: If you go to Pycon in Lviv, I will show you the original factory :) | 16:44 |
NobodyCam | :) very cool... | 16:44 |
NobodyCam | I don't think I'll make pycon. :( | 16:44 |
NobodyCam | how are things over there? still have the unrest? nothing on our news anymore | 16:45 |
romcheg | NobodyCam: Yesterday in Kyiv http://cs14109.vk.me/c540101/v540101434/17320/0P97YhucC0A.jpg | 16:46 |
*** rongze has quit IRC | 16:46 | |
NobodyCam | omg wow | 16:47 |
*** prekarat has quit IRC | 16:48 | |
NobodyCam | there most be 1000's of people there if not 10's of 1000's | 16:48 |
*** prekarat has joined #openstack-ironic | 16:48 | |
romcheg | NobodyCam: More than 1.5 millions | 16:49 |
romcheg | People from all the Ukraine go to Kyiv to take an action | 16:49 |
devananda | morning, all | 16:51 |
romcheg | Morning devananda | 16:51 |
NobodyCam | good morning devananda | 16:51 |
NobodyCam | romcheg: wow | 16:51 |
*** hemna has joined #openstack-ironic | 16:51 | |
*** matty_dubs is now known as matty_dubs|lunch | 16:54 | |
lucasagomes | morning all | 16:56 |
lucasagomes | devananda, ping... should we normalize the mac address on the API side? | 16:56 |
lucasagomes | or at lease make the address column in the db case insensitive | 16:57 |
*** jcooley_ has joined #openstack-ironic | 16:57 | |
devananda | lucasagomes: morning | 16:57 |
devananda | lucasagomes: we should not rely on the db case-sensitivity. | 16:57 |
lucasagomes | Haomeng, raised that in one of my patches (actually 2 of them) | 16:58 |
devananda | mysql defaults to case-insensitive, but can be changed. IIRC< pgsql defaults to sensitive. | 16:58 |
lucasagomes | right | 16:58 |
lucasagomes | I thought there would be something on sqlalchmey that would take care of diff backends | 16:58 |
openstackgerrit | A change was merged to openstack/python-ironicclient: Replace chassis_id with chassis_uuid on Nodes https://review.openstack.org/58314 | 16:59 |
devananda | lucasagomes: i'm not aware of any setting that automatically munges the case of all inputs | 17:01 |
lucasagomes | devananda, right | 17:02 |
lucasagomes | so I think we can validate (correct format and colon-separated) and normalize it to all lower or upper (pref is lower) case in the API | 17:04 |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Check connectivity in SSH driver 'validate' method https://review.openstack.org/60876 | 17:05 |
devananda | lucasagomes: ++ | 17:06 |
*** ifarkas has joined #openstack-ironic | 17:10 | |
lucasagomes | cool will do it :) | 17:12 |
NobodyCam | fyi: https://review.openstack.org/#/c/60879/ | 17:13 |
lucasagomes | NobodyCam, ha! gogo ironic :) | 17:14 |
NobodyCam | :- | 17:15 |
NobodyCam | bbt... brb | 17:16 |
*** rongze has joined #openstack-ironic | 17:17 | |
*** rongze has quit IRC | 17:28 | |
dkehn | anteaya: are you the resident generate_sample.sh person here, I see your name https://github.com/openstack/ironic/blob/master/tools/conf/generate_sample.sh | 17:34 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: API: Validate and normalize address https://review.openstack.org/60890 | 17:43 |
NobodyCam | post bbt walkies... brb | 17:49 |
anteaya | dkehn: I did the latest commit on that file, yes | 17:52 |
anteaya | dkehn: that came from oslo and I needed to adjut the path so it would work for ironic conf generation | 17:52 |
dkehn | anteaya: ok, are you familiar with its workings I've got changes into the pxe.py, adding a config parameter, but it doesn't seem to generate the sample, and I wondering what I'm missing | 17:53 |
*** rongze has joined #openstack-ironic | 17:54 | |
*** jcooley_ has quit IRC | 17:54 | |
dkehn | anteaya: so the assumption is that you add or chnage the cfg.StrOPt, in this case and run the generate_sample.sh from the root, is there more to it than that? | 17:54 |
anteaya | dkehn: do you have a url to a patch? | 17:59 |
devananda | dkehn: are you inside the venv when calling generate_sample.sh? | 17:59 |
dkehn | devananda: no I'm not | 18:00 |
dkehn | devananda: is that a requirement | 18:00 |
anteaya | and yeah, that is basically what I did, ensure the script can find an imput file and specifiy the output path | 18:00 |
devananda | dkehn: afaik, yes | 18:00 |
devananda | dkehn: generate-sample.sh needs to import all the modules, so they need to be in your path, which is part of what being in the venv does | 18:01 |
dkehn | ok, guys maybe thats it, was assuming becuase tox now workins without venv this would too | 18:01 |
devananda | anteaya: also, you may be interested in https://review.openstack.org/#/c/60639/ | 18:01 |
devananda | anteaya: i think this solves our perpetualy-out-of-date-sample-config problem | 18:01 |
*** jistr has quit IRC | 18:02 | |
* anteaya clicks | 18:02 | |
devananda | NobodyCam: ^ | 18:03 |
* NobodyCam looks | 18:03 | |
dkehn | yepper that was it, thx , keep forgetting that one | 18:03 |
devananda | dkehn: :) | 18:03 |
*** derekh has quit IRC | 18:05 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: API: Validate and normalize address https://review.openstack.org/60890 | 18:12 |
openstackgerrit | A change was merged to openstack/ironic: Add tools/conf/check_uptodate to tox.ini https://review.openstack.org/60639 | 18:14 |
NobodyCam | devananda: ^^^ | 18:17 |
devananda | :) | 18:19 |
*** vkozhukalov has joined #openstack-ironic | 18:20 | |
*** ifarkas has quit IRC | 18:21 | |
*** lucasagomes is now known as lucas-afk | 18:22 | |
lucas-afk | be back for the meeting :) | 18:22 |
*** jcooley_ has joined #openstack-ironic | 18:22 | |
*** max_lobur is now known as max_lobur_afk | 18:23 | |
*** rongze has quit IRC | 18:37 | |
*** matty_dubs|lunch is now known as matty_dubs | 18:38 | |
openstackgerrit | dekehn proposed a change to openstack/ironic: PXE boot information that is necessary for Neutron https://review.openstack.org/60904 | 18:41 |
NobodyCam | dkehn: w00t!!! | 18:41 |
*** tatyana has quit IRC | 18:42 | |
devananda | hrm. something odd | 18:43 |
devananda | dkehn: why do you have a new file, ironic.sample.conf? | 18:43 |
dkehn | devananda: my bad will delete | 18:44 |
* NobodyCam wanders off to refil coffee and what not b4 meeting | 18:46 | |
openstackgerrit | dekehn proposed a change to openstack/ironic: PXE boot information that is necessary for Neutron https://review.openstack.org/60904 | 18:47 |
dkehn | devananda: mo better | 18:47 |
devananda | ya :) | 18:47 |
* devananda needs to polish up the consistent hashing patches and add the takeover-node stuff | 18:48 | |
NobodyCam | w00t RE: James Slagle comment on https://review.openstack.org/#/c/60879 :) | 18:53 |
*** lucas-afk is now known as lucasagomes | 18:55 | |
* NobodyCam heads over to setup chairs and coffee for the meeting :-P | 18:58 | |
*** romcheg1 has joined #openstack-ironic | 18:59 | |
*** romcheg1 has quit IRC | 18:59 | |
*** romcheg1 has joined #openstack-ironic | 19:01 | |
NobodyCam | meeting time | 19:11 |
*** jcooley_ has quit IRC | 19:11 | |
*** mdurnosvistov has joined #openstack-ironic | 19:14 | |
*** jcooley_ has joined #openstack-ironic | 19:17 | |
devananda | vkozhukalov: hi! this https://blueprints.launchpad.net/nova/+spec/libvirt-empty-vm-boot-pxe looks a bit odd to me -- it has a target milestone and series, but is not accepted yet and has no approver set. | 19:19 |
devananda | vkozhukalov: have you talked with nova ptl about it? | 19:19 |
vkozhukalov | devananda, I was not sure about this feature (actually I still isn't). So I just tried to ask them in #openstack-nova but no one was interested. I just decided to concentrate on making workin functional testing scheme for ironic. Actually I think that this initiative https://etherpad.openstack.org/p/tripleo-test-cluster is much more interesting. | 19:24 |
vkozhukalov | devananda, I mean it is much more interesting than making nova able to boot nodes via PXE | 19:26 |
vkozhukalov | devananda, at least at this moment | 19:27 |
devananda | yea, tripleo-test-cluster is very interesting indeed, but won't cover ironic directly for a while | 19:27 |
*** romcheg1 has quit IRC | 19:38 | |
*** romcheg1 has joined #openstack-ironic | 19:38 | |
lifeless | making Nova be able to have PXE bootin VM's won't help infra for many many months | 19:39 |
lifeless | because to use it infra needs it deployed by the clouds infra test on. | 19:40 |
*** jcooley_ has quit IRC | 19:40 | |
vkozhukalov | Yes, it nova PXE feature could not help with testing. Actually we decided to start from launching VM manually inside jenkins slave VM which is used to run tests. | 19:44 |
*** epim has joined #openstack-ironic | 20:01 | |
*** yuriyz has joined #openstack-ironic | 20:02 | |
*** yuriyz has left #openstack-ironic | 20:02 | |
*** yuriyz has joined #openstack-ironic | 20:02 | |
lucasagomes | rloo, so I don't see any problem in proposing a change, but if you ask before for opinions first you might get things right quicker | 20:02 |
lucasagomes | I don't I can't think about a methodology for it | 20:02 |
*** yuriyz has quit IRC | 20:02 | |
*** kui has joined #openstack-ironic | 20:02 | |
rloo | lucasagomes. yeah. i have been mulling over how to get the reviews 'life span' shorter, and reduce the number of patches. | 20:03 |
lucasagomes | imo, if you believe ur way is good just propose it and wait for reviews. If there's some doubts might worth asking on IRC for opnions | 20:03 |
lucasagomes | rloo, yea :( | 20:03 |
devananda | rloo: part of patch lifespan is we have still a fairly small review team, who are also the most active developers, and so bandwidth of -core folks isn't that high yet | 20:03 |
rloo | it just seems a shame to dot your is and cross your ts, only to get to the 'end' when the solution isn't _quite right_. I mean, it is good to catch it, would be better to catch these sooner. | 20:03 |
rloo | but then, there are a lot of moving parts. | 20:04 |
NobodyCam | ahh so we have a meeting following us again | 20:04 |
devananda | rloo: this happens in other projects too, and from what i've seen, generally speaking, the larger the change, the more it helps to have a clearly thought-out and presented blueprint before hand | 20:04 |
lucasagomes | rloo, I hear ya, but I think it's part of the process | 20:04 |
*** rongze has joined #openstack-ironic | 20:04 | |
lucasagomes | so now we have a meeting after the ironic one? | 20:05 |
devananda | rloo: but even then, because code is a much clearer communication tool for engineers than verbage, i've also seen code for an approved blueprint get rejected | 20:05 |
lucasagomes | we need to be strict with the time again :) | 20:05 |
devananda | rloo: because the fokls who approved the BP and the folks who wrote it were thinking of different things (or didn't think it through all the way) | 20:05 |
rloo | well, I suppose there isn't one solution to address this. | 20:07 |
rloo | we just need more deva's. | 20:08 |
lucasagomes | hehe +1 | 20:08 |
devananda | aaaaaah! I can already barely handle one of me! | 20:08 |
rloo | a 24/7 deva :-) | 20:08 |
lucasagomes | btw, it's late here and I'm pretty hungry | 20:08 |
devananda | lucasagomes: have a good night :) | 20:08 |
lucasagomes | so have a good night everyone! see yall tomorrow | 20:08 |
NobodyCam | lucasagomes: enjoy dinner... and thank you | 20:09 |
rloo | night lucasagomes! | 20:09 |
lucasagomes | devananda, rloo NobodyCam, thanks! see u | 20:09 |
*** lucasagomes has quit IRC | 20:09 | |
rloo | so devananda, do you have a few minutes to discuss https://blueprints.launchpad.net/ironic/+spec/breaking-resource-locks | 20:10 |
devananda | rloo: sure thing | 20:10 |
NobodyCam | rloo: I feel it good form to discuss anything major like work on BP's in channel first | 20:10 |
rloo | NobodyCam: yes, that's what I think I'll do. Right now. :-) | 20:11 |
NobodyCam | just reading back | 20:11 |
NobodyCam | heheheh | 20:11 |
rloo | I haven't worked on a bp before. | 20:11 |
rloo | Can anyone enter information into this thing? | 20:11 |
NobodyCam | anyone can comment on them | 20:11 |
rloo | ok, i tried to change 'Assignee' to myself but wasn't sure how. | 20:12 |
devananda | rloo: the assigned person or the PTL can edit them | 20:12 |
rloo | Is it in the 'whiteboard' section that people put their comments? | 20:12 |
NobodyCam | put a review with that bp tagged | 20:12 |
devananda | rloo: i think only the PTL can change certain fields, target to a release, etc. | 20:12 |
rloo | ok. | 20:12 |
rloo | are you serious? you have to write code first? | 20:12 |
NobodyCam | devananda: will Mr Jenkins also do that? | 20:12 |
devananda | rloo: but anyone should be able to edit the whiteboard | 20:12 |
devananda | rloo: no. | 20:13 |
devananda | rloo: if you write code that relates to the bp, put "blueprint your-bp-name" in the commit message on a line by itself | 20:13 |
devananda | rloo: jenkins will add a comment to the whitebaord linking to that patch set | 20:13 |
rloo | so I don't really care if I don't have my name down as assignee. but I would care, if because my name wasn't there, and I was working on it, someone else decided to work on it too. That wouldn't be good. | 20:13 |
NobodyCam | rloo: no but somehting like the wip review that is just a commit message saying your working on this | 20:14 |
rloo | My real question though, is trying to understand the scope of this BP. | 20:14 |
devananda | rloo: right. so anyone can write any code. and you can tag any BP in your commit msg | 20:14 |
devananda | rloo: the purpose of assigning the BP to a single person is to assign responsibility for tracking completion of the feature | 20:14 |
rloo | but I don't want to write any code, until i understand the scope and have some sort of OK that the approach is what people are expecting. | 20:14 |
devananda | rloo: so that as as we approach a milestone or releae, I know who to nag :) | 20:14 |
rloo | ah, I thought the BP assignee was the person resp for implementing. | 20:14 |
devananda | rloo: it usually is | 20:15 |
rloo | So how do you make sure people aren't working on things that other people are working on? | 20:15 |
devananda | eg, sometimes a team might implement a BP, and so its assigned to the team lead | 20:15 |
devananda | rloo: we talk to each other | 20:15 |
devananda | that's all | 20:15 |
rloo | but talking on IRC isn't that effect in a global world. | 20:15 |
rloo | effective i mean. | 20:15 |
devananda | code is a form of talking | 20:15 |
devananda | too | 20:15 |
NobodyCam | rloo: the BP's whiteboard can do some of that | 20:16 |
devananda | look at the review board. look at the BP's whiteboard. subscribe to it. you'll get an email if someone else comments or posts related code | 20:16 |
rloo | right, but maybe i'm old fashioned. i don't want to code until I understand what I'm going to code. | 20:16 |
devananda | rloo: that's not old fashioned. that's good :) | 20:16 |
NobodyCam | rloo: click the edit icon on the BP | 20:17 |
rloo | ok. that's fine about the assignee part then. I'll just add comments to the BP. | 20:17 |
NobodyCam | under whiteboard | 20:17 |
NobodyCam | :) | 20:17 |
devananda | so one thing that I've done somewhat backwards as the PTL, which may be causing some confusion, is that I created BPs as a way to communicate what I think should be done | 20:17 |
devananda | whereas for most projects, fokls who want to implement a specific feature propose a BP | 20:17 |
NobodyCam | devananda: that has worked very well for our team | 20:17 |
devananda | then naturally, there's already someone who knows what they want to write | 20:17 |
rloo | ok, but you're assuming someone knows what they want to write in that case. | 20:18 |
devananda | sort of | 20:18 |
rloo | in my case, I'm not sure. | 20:18 |
rloo | eg, for this blueprint. there are a bunch of ideas. | 20:18 |
devananda | in the case at hand, I know there's a need for this feature. I'm hoping someone else will see a solution and write it :) | 20:18 |
NobodyCam | rloo: it he worst case it spawns converstions just like this one | 20:18 |
NobodyCam | which imo is Good | 20:19 |
devananda | rloo: would it be easier to think of if this were a bug instead of a BP? | 20:19 |
rloo | one is 'there should be a way for an admin to manually break a lock when necessary'. that's what Yuriy's change does (or will do). | 20:19 |
rloo | no, bug or BP is fine. There are already ideas mentioned in this thing -- so I feel that to work on it, I should understand the background, etc, and see if thoughts have changed since the time of writing. | 20:20 |
rloo | eg, this bp mentions 'time when lock was taken', ... Is that what we want? | 20:21 |
NobodyCam | brb | 20:22 |
rloo | and devananda, in some previous discussion (last month), you had mentioned that you were thinking of something like "it's basically some way to trigger "UPDATE nodes SET instance_uuid=NULL, *_state=NULL, WHERE ...", with a few safeguards around it" | 20:23 |
devananda | humm | 20:24 |
* devananda gets more coffee and ruminates | 20:26 | |
kui | devananda, NobodyCam: I want to make contribution and focus on ironic project, is there some suggestion about the first step/task? | 20:28 |
*** vkozhukalov has quit IRC | 20:28 | |
devananda | kui: hi! we're happy to point you to getting-started resources. do you have a specific contribution you'd like to make? | 20:29 |
devananda | rloo: i think we can't have lock-breaking change the instance_uuid | 20:30 |
rloo | devananda: yes. | 20:30 |
devananda | rloo: it has to change the reservation. i'm not sure yet if it should clear target_*_state, or if the conductor which takes over should try to complete said state transitions | 20:30 |
devananda | rloo: this is where it gets tricky | 20:30 |
rloo | devananda: I almost wonder whether it is premature to work on this. | 20:30 |
kui | devannanda: maybe start from simple one to get familiar with the project. | 20:31 |
devananda | rloo: it does feel premature, yes | 20:31 |
devananda | rloo: the original bug -- let me find it -- is pretty essential, though | 20:31 |
devananda | rloo: https://bugs.launchpad.net/ironic/+bug/1250348 | 20:31 |
rloo | devananda: yes, that's the one yuriy is working on though. | 20:32 |
rloo | devananda: i think that may be enough for now, until we have more experience with conductors dying. | 20:32 |
rloo | devananda: otoh, if we feel like we want some sort of timestamp for the reservation, and that modifies the db, we may want to put that in before icehouse. | 20:33 |
rloo | devananda: maybe you can help out kui first, and we can discuss afterwards. | 20:33 |
kui | rloo: thank you | 20:34 |
*** jcooley_ has joined #openstack-ironic | 20:34 | |
devananda | kui: have you gotten a development environment for ironic up and running yet? | 20:35 |
devananda | rloo: it would be easy to add a timestamp to the reservation data | 20:36 |
devananda | rloo: though i'm hesitant to add a db column taht we aren't going to use right away, just on principle | 20:36 |
kui | devananda: not yet, I just know the steps of devtest.sh in tripleo, and get known about the diskimage-builder. | 20:36 |
devananda | ahh ok | 20:36 |
NobodyCam | was making a bagel ... hi kui | 20:37 |
devananda | kui: https://wiki.openstack.org/wiki/Ironic#Using_Disk_Image_Builder may help you then | 20:37 |
kui | NobodyCam: Good afternoon, NobodayCam | 20:37 |
devananda | kui: that wiki section has instructions for making tripleo build an environment with ironic in the undercloud node | 20:37 |
devananda | kui: so you can then test the code there | 20:37 |
NobodyCam | we tested that this weekend so I pretty sure its still vaild | 20:38 |
devananda | NobodyCam: I'm removing the python-ironicclient from taht wiki, now that it's landed in incubator/scripts/install-tools, ya? | 20:38 |
NobodyCam | ya :) | 20:38 |
kui | devannanda: great, I will follow this wiki page. | 20:39 |
devananda | kui: also a venv for unit tests can be created by: http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html | 20:39 |
kui | devananda: I spend some time to study the di-b, skuicloud.wordpress.com, the latest blog record the procedure of generating ramdisk. | 20:40 |
devananda | kui: with those two things, you can write and test code. then I'd suggest looking at the bug list for things you want to do, or at the review board and commenting on reviews to get to see what's under development | 20:40 |
kui | devananda: I am familiar with the venv, since I have committed 30+ patches in Havana. I come here to dive into Ironic dedicately. | 20:41 |
rloo | devananda: there are still a few more months til icehouse, so we can punt on the timestamp thing til later. and if on principle, you don't want to put it in, that's fine with me. | 20:42 |
devananda | rloo: i think timestamp on reservation /might/ be useful. but until we have a clear use for it, i think adding it is premature | 20:43 |
devananda | kui: awesome | 20:43 |
NobodyCam | devananda: is there a use case for reservations expirering? | 20:44 |
devananda | NobodyCam: down the road? maybe. do we need that for Icehouse? I dont see why | 20:44 |
NobodyCam | :) | 20:44 |
rloo | devananda: ok, so as far as the blueprint goes (and https://etherpad.openstack.org/p/IcehouseIronicNextSteps - "API to break a task_manager lock"), that is addressed by https://bugs.launchpad.net/ironic/+bug/1250348 (for now, til perhaps icehouse) | 20:45 |
kui | devananda: Do we have a plan to make Ironic graduating from incubation during Icehouse ? | 20:46 |
*** jcooley_ has quit IRC | 20:46 | |
devananda | rloo: with the discussion we had with yuriyz today, I think that his work addresses the immediate need, yes | 20:46 |
devananda | kui: yes! | 20:46 |
*** jcooley_ has joined #openstack-ironic | 20:47 | |
rloo | devananda: ok, I've updated https://etherpad.openstack.org/p/IcehouseIronicNextSteps to reflect that (specifically, link to the review) | 20:48 |
devananda | rloo: great, thanks much! | 20:48 |
kui | devananda: Great, I can contribute my help to approach the target, more or less :) | 20:48 |
devananda | kui: in general, we are aiming at basic functionality by I-2 milestone (Jan 22) | 20:49 |
devananda | kui: if we can deliver that, I will go to TC and propose that we gradaute this cycle | 20:49 |
kui | devananda: OK, I will catch up, time is tight. | 20:50 |
*** jcooley_ has quit IRC | 20:54 | |
*** jcooley_ has joined #openstack-ironic | 20:55 | |
*** romcheg1 has quit IRC | 20:55 | |
NobodyCam | devananda: just thought of something | 20:56 |
NobodyCam | we are adding dhcp options to PXE driver | 20:56 |
devananda | ya? | 20:57 |
NobodyCam | but all of ironic's drivers will need a dhcp_options_for_instance as that is called from nova/compute/manager.py: dhcp_options = self.driver.dhcp_options_for_instance(instance)???? | 20:57 |
devananda | NobodyCam: no | 20:57 |
*** jcooley_ has quit IRC | 20:57 | |
devananda | NobodyCam: that is a flaw in the implementation in Nova. I commented on it, but someone removed my comment | 20:58 |
devananda | NobodyCam: nova shouldn't care about the dhcp_opts_for_instance in the ironic driver | 20:58 |
devananda | because not all deploy drivers will use dhcp/pxe | 20:58 |
kui | devananda: I "watched" last two weekly meeting silently, every attendee take charge one aspect of Ironic, I am willing to work with all of you together and get more task assigned. | 20:58 |
devananda | it actually shouldn't even be there in nova-baremetal either | 20:58 |
NobodyCam | kui: awesome :) | 20:59 |
kui | devananda: I'm going back to sleep, Have a good day! | 20:59 |
NobodyCam | have a good night kui :) | 20:59 |
kui | NobodyCam: Have a good day ! | 20:59 |
NobodyCam | and Thank you :) | 21:00 |
devananda | kui: rather than assign some task to you, i prefer if you find work you want to do and then do it (maybe check with us to see that no one else is already doing it, too) | 21:00 |
devananda | kui: good night! | 21:00 |
kui | devananda: Yes, I agree, I just want to align with the Ironic directory, from the perspective of PTL. | 21:01 |
devananda | kui: :) | 21:01 |
kui | devananda: It is 5:00 AM here :) | 21:01 |
devananda | heh. sleep well ) | 21:01 |
kui | devananda, NobodyCam: Thank you all, Bye | 21:01 |
NobodyCam | devananda: should I look at refactoring https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1033 | 21:03 |
devananda | NobodyCam: ooh. gah. right. | 21:04 |
devananda | NobodyCam: someone moved it /that/ far up the stack. i thought it was just in the driver | 21:04 |
NobodyCam | ya that what I had thought | 21:04 |
NobodyCam | until I looked | 21:05 |
devananda | nova/nova/virt$ git grep 'def dhcp_options_for_instance' | 21:05 |
devananda | baremetal/driver.py: def dhcp_options_for_instance(self, instance): | 21:05 |
devananda | driver.py: def dhcp_options_for_instance(self, instance): | 21:05 |
devananda | it's not used by any other driver | 21:05 |
devananda | I would say, don't implement that method in the ironic driver at all | 21:06 |
devananda | the parent definition just calls "pass" | 21:06 |
devananda | https://github.com/openstack/nova/blob/master/nova/virt/driver.py#L908 | 21:06 |
NobodyCam | ok :) | 21:06 |
devananda | nov-ironic driver doesn't need that | 21:07 |
NobodyCam | was looking at the log and saw it was getting called.. and not by the driver | 21:08 |
NobodyCam | brb | 21:14 |
*** mdurnosvistov has quit IRC | 21:34 | |
*** openstackgerrit has quit IRC | 21:37 | |
*** openstackgerrit has joined #openstack-ironic | 21:37 | |
*** rongze has quit IRC | 21:52 | |
*** openstackgerrit has quit IRC | 21:57 | |
*** openstackgerrit has joined #openstack-ironic | 21:57 | |
*** jdob has quit IRC | 22:00 | |
*** mdurnosvistov has joined #openstack-ironic | 22:14 | |
*** kui has quit IRC | 22:18 | |
*** rongze has joined #openstack-ironic | 22:18 | |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Fix auto-generated REST API formatting https://review.openstack.org/60954 | 22:25 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Fix auto-generated REST API formatting https://review.openstack.org/60954 | 22:26 |
devananda | woot! formatting is good now! | 22:33 |
devananda | http://docs-draft.openstack.org/54/60954/2/check/gate-ironic-docs/f67944b/doc/build/html/webapi/v1.html | 22:33 |
* NobodyCam looks | 22:33 | |
devananda | compared to docs.openstack.org/developer/ironic/webapi/v1.html | 22:33 |
devananda | http://docs.openstack.org/developer/ironic/webapi/v1.html | 22:33 |
NobodyCam | devananda: where is The ‘rest-controller’ directive of this resource seems to be crashing sphinxcontrib-pecanwsme with “CRITICAL ironic [-] list index out of range” errors. comming from | 22:35 |
NobodyCam | its in both | 22:35 |
devananda | yea, i know | 22:35 |
devananda | I've sent an email to dhellman about that | 22:35 |
devananda | i think it's a bug in the sphinx extension he wrote | 22:35 |
NobodyCam | ahh | 22:36 |
NobodyCam | :) | 22:36 |
devananda | i am not familiar enough with sphinx to debug it in any reasonable amount of time :( | 22:36 |
NobodyCam | but looks great | 22:36 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Developer doc index page points to correct API docs https://review.openstack.org/60960 | 22:39 |
NobodyCam | we'll need to keep an eye on doc strings as things like *_id: UUID of a * get updated | 22:39 |
devananda | yea. I think lucas has some patches that correct some of that nomenclature | 22:39 |
NobodyCam | ya | 22:39 |
devananda | we should do a cleanup of it | 22:39 |
devananda | especially since it's quite public in our API docs now :) | 22:40 |
devananda | brb | 22:40 |
NobodyCam | k | 22:40 |
*** matty_dubs is now known as matty_dubs|gone | 22:45 | |
devananda | abck | 22:47 |
devananda | back | 22:47 |
NobodyCam | bw | 22:47 |
NobodyCam | wb | 22:47 |
*** rongze has quit IRC | 22:51 | |
*** epim has quit IRC | 22:54 | |
*** epim has joined #openstack-ironic | 22:54 | |
*** mdurnosvistov has quit IRC | 23:11 | |
NobodyCam | devananda: question | 23:13 |
NobodyCam | look into starting on some of the tests for the nova driver | 23:14 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Add prepare, cleanup, takeover methods to deploy https://review.openstack.org/58894 | 23:14 |
NobodyCam | are going to be testing things like adding a node. or should all of the ironic "work" be mocked? | 23:14 |
NobodyCam | there really is no nova db to do any testing | 23:15 |
*** epim has quit IRC | 23:15 | |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Add prepare, cleanup, takeover methods to deploy https://review.openstack.org/58894 | 23:17 |
devananda | NobodyCam: i dont quite understand your question | 23:17 |
devananda | NobodyCam: also, i need to get food. bbiaf or call me? | 23:17 |
NobodyCam | call while you get food | 23:17 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Add config option for # of conductor replicas https://review.openstack.org/59794 | 23:20 |
*** rongze has joined #openstack-ironic | 23:51 | |
NobodyCam | devananda: when you get back. I can not change tags on bugs :-p | 23:53 |
devananda | NobodyCam: back | 23:54 |
NobodyCam | lol | 23:54 |
devananda | NobodyCam: join the bug team? | 23:54 |
NobodyCam | https://bugs.launchpad.net/ironic/+bug/1259346 | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!