*** jcooley_ has quit IRC | 00:02 | |
kui | leaving . Have a good day! everyone | 00:02 |
---|---|---|
*** jcooley_ has joined #openstack-ironic | 00:02 | |
*** lexx has quit IRC | 00:03 | |
*** jcooley_ has quit IRC | 00:07 | |
*** epim has quit IRC | 00:07 | |
NobodyCam | have a good night kui and thank you | 00:10 |
*** epim has joined #openstack-ironic | 00:12 | |
*** jcooley_ has joined #openstack-ironic | 00:13 | |
*** jcooley_ has quit IRC | 00:13 | |
*** jcooley_ has joined #openstack-ironic | 00:13 | |
openstackgerrit | dekehn proposed a change to openstack/ironic: Method to generate PXE options for Neutron ports https://review.openstack.org/60904 | 00:14 |
*** jcooley_ has quit IRC | 00:18 | |
devananda | NobodyCam: now that I know how to push a release of ironic client, i'm goign to bump its version to 0.1.0. seem reasonable? think I should wait for any particular patches? | 00:30 |
*** kui has quit IRC | 00:34 | |
NobodyCam | hmmm | 00:35 |
NobodyCam | not in the client | 00:37 |
*** hemna has quit IRC | 00:37 | |
NobodyCam | devananda: there will be a client side to https://review.openstack.org/#/c/61160 | 00:41 |
NobodyCam | Add trigger to start provisioning the node | 00:41 |
devananda | hm? | 00:41 |
devananda | ahh yes | 00:42 |
NobodyCam | but we can do another release. why do you want ot push a new version | 00:42 |
devananda | ok. let's wait for that + the matching client | 00:42 |
NobodyCam | :) | 00:42 |
devananda | then i'll do a 0.1.0 | 00:42 |
NobodyCam | ya that seems like a good time to do that | 00:43 |
NobodyCam | brb quick walkies time | 00:43 |
lifeless | https://review.openstack.org/#/c/60982/ needs another +2 | 00:45 |
lifeless | fixes the sphinx thing | 00:45 |
*** epim has quit IRC | 00:46 | |
NobodyCam | lifeless: the multi line doc string thing? | 00:53 |
openstackgerrit | A change was merged to openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/60982 | 00:53 |
lifeless | no, gate was broken for a bunch o fprojects | 00:56 |
lifeless | sphinx release fubared it all | 00:56 |
NobodyCam | ahh :) | 00:57 |
*** hemna has joined #openstack-ironic | 00:59 | |
*** anniec has quit IRC | 01:03 | |
*** hemna is now known as hemnafk | 01:05 | |
*** rloo has quit IRC | 01:24 | |
*** nosnos has joined #openstack-ironic | 01:29 | |
*** dguitarbite has joined #openstack-ironic | 01:44 | |
*** michchap_ has quit IRC | 01:46 | |
*** michchap has joined #openstack-ironic | 01:47 | |
*** kui has joined #openstack-ironic | 01:58 | |
*** rongze has joined #openstack-ironic | 02:01 | |
*** jcooley_ has joined #openstack-ironic | 02:04 | |
*** rongze has quit IRC | 02:31 | |
*** kushi_ has joined #openstack-ironic | 02:43 | |
*** jcooley_ has quit IRC | 02:43 | |
*** kui has quit IRC | 02:45 | |
*** rongze has joined #openstack-ironic | 02:46 | |
*** kushi_ has quit IRC | 02:48 | |
*** prekarat has joined #openstack-ironic | 03:14 | |
*** prekarat has quit IRC | 04:02 | |
*** hemna_ has joined #openstack-ironic | 04:24 | |
*** hemnafk has quit IRC | 04:24 | |
*** hemna_ has quit IRC | 04:24 | |
*** hemna_ has joined #openstack-ironic | 04:24 | |
*** dguitarbite has quit IRC | 04:27 | |
*** anniec has joined #openstack-ironic | 04:28 | |
*** anniec_ has joined #openstack-ironic | 04:35 | |
*** anniec has quit IRC | 04:35 | |
*** anniec_ is now known as anniec | 04:35 | |
*** rongze has quit IRC | 04:50 | |
*** prekarat has joined #openstack-ironic | 05:12 | |
*** prekarat1 has joined #openstack-ironic | 05:13 | |
*** prekarat has quit IRC | 05:16 | |
*** rongze has joined #openstack-ironic | 05:20 | |
*** nosnos_ has joined #openstack-ironic | 05:31 | |
*** jcooley_ has joined #openstack-ironic | 05:33 | |
*** nosnos has quit IRC | 05:34 | |
*** rongze has quit IRC | 05:35 | |
*** anniec has quit IRC | 05:36 | |
*** devananda has quit IRC | 05:57 | |
*** davidlenwell_ has joined #openstack-ironic | 05:57 | |
*** devananda has joined #openstack-ironic | 05:57 | |
*** Ghe_HPDiscover has quit IRC | 05:57 | |
*** davidlenwell has quit IRC | 05:58 | |
*** NobodyCam has quit IRC | 05:58 | |
openstackgerrit | Jenkins proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/59627 | 06:00 |
*** rongze has joined #openstack-ironic | 06:03 | |
*** nosnos_ has quit IRC | 06:04 | |
*** nosnos has joined #openstack-ironic | 06:05 | |
*** rongze has quit IRC | 06:07 | |
*** vkozhukalov has quit IRC | 06:09 | |
*** NobodyCam has joined #openstack-ironic | 06:14 | |
*** rongze has joined #openstack-ironic | 06:15 | |
*** vetalll has joined #openstack-ironic | 06:16 | |
*** Ghe_HPDiscover has joined #openstack-ironic | 06:35 | |
*** jcooley_ has quit IRC | 06:39 | |
*** yfujioka has joined #openstack-ironic | 06:59 | |
*** mdurnosvistov has joined #openstack-ironic | 07:02 | |
*** lifeless has quit IRC | 07:05 | |
*** mdurnosvistov has quit IRC | 07:06 | |
*** jcooley_ has joined #openstack-ironic | 07:09 | |
*** ifarkas has joined #openstack-ironic | 07:13 | |
*** jcooley_ has quit IRC | 07:15 | |
*** vetalll has quit IRC | 07:20 | |
*** vetalll has joined #openstack-ironic | 07:23 | |
*** vetalll has quit IRC | 07:27 | |
*** urulama has joined #openstack-ironic | 07:31 | |
*** lexx has joined #openstack-ironic | 07:32 | |
*** vkozhukalov has joined #openstack-ironic | 07:57 | |
*** jcooley_ has joined #openstack-ironic | 08:05 | |
*** jcooley_ has quit IRC | 08:09 | |
*** lexx has quit IRC | 08:15 | |
*** rongze has quit IRC | 08:46 | |
*** rongze has joined #openstack-ironic | 08:47 | |
*** jistr has joined #openstack-ironic | 08:57 | |
*** jcooley_ has joined #openstack-ironic | 09:00 | |
*** romcheg has joined #openstack-ironic | 09:04 | |
*** jcooley_ has quit IRC | 09:04 | |
*** lucasagomes has joined #openstack-ironic | 09:14 | |
*** max_lobur_afk is now known as max_lobur | 09:21 | |
*** derekh has joined #openstack-ironic | 09:23 | |
*** tatyana has joined #openstack-ironic | 09:28 | |
*** mdurnosvistov has joined #openstack-ironic | 09:30 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/ironic: Updated from global requirements https://review.openstack.org/61354 | 09:33 |
*** nosnos_ has joined #openstack-ironic | 09:36 | |
*** nosnos has quit IRC | 09:40 | |
*** lifeless has joined #openstack-ironic | 09:43 | |
*** dguitarbite has joined #openstack-ironic | 10:12 | |
openstackgerrit | Alexandra Fomina proposed a change to openstack/python-ironicclient: Import exceptions functionality from Oslo https://review.openstack.org/60528 | 10:14 |
openstackgerrit | Alexandra Fomina proposed a change to openstack/python-ironicclient: Import exceptions functionality from Oslo https://review.openstack.org/60528 | 10:16 |
*** prekarat1 has quit IRC | 10:18 | |
*** homegrown has joined #openstack-ironic | 10:20 | |
*** nosnos_ has quit IRC | 10:57 | |
*** nosnos has joined #openstack-ironic | 10:57 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/python-ironicclient: Rename nodes/<uuid>/state to nodes/<uuid>/states https://review.openstack.org/60558 | 10:58 |
*** anniec has joined #openstack-ironic | 11:03 | |
*** ifarkas has quit IRC | 11:03 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/python-ironicclient: Add set_provision_state to the client libs https://review.openstack.org/61379 | 11:16 |
*** rongze has quit IRC | 11:21 | |
*** jcooley_ has joined #openstack-ironic | 11:43 | |
*** anniec_ has joined #openstack-ironic | 11:43 | |
*** rongze has joined #openstack-ironic | 11:44 | |
*** anniec has quit IRC | 11:45 | |
*** anniec_ is now known as anniec | 11:45 | |
*** jcooley_ has quit IRC | 11:47 | |
*** ifarkas has joined #openstack-ironic | 11:53 | |
lucasagomes | lifeless, https://review.openstack.org/#/c/60972/ will fix the problem with the docs http://logs.openstack.org/98/60798/1/gate/gate-ironic-docs/9353b3a/console.html (caused by sphinx >=1.2) | 12:04 |
lucasagomes | lifeless, when you get some free time take a look at the patch and if that lgty: +2/A | 12:06 |
lucasagomes | lifeless, thanks :) | 12:06 |
*** lucasagomes is now known as lucas-hungry | 12:06 | |
*** yfujioka has quit IRC | 12:12 | |
openstackgerrit | A change was merged to openstack/ironic: Updated from global requirements https://review.openstack.org/60972 | 12:19 |
devananda | Haomeng: are you still working on bug 1244541 ? | 12:21 |
Haomeng | Morning devananda, let me check | 12:22 |
Haomeng | devananda: sorry, I missed this bug for some time | 12:23 |
Haomeng | devananda: will go ahead to port your change, and commit the path this night | 12:23 |
devananda | Haomeng: it may not be a simple port-my-old-code. also, it's OK to unassign if you are busy with other things | 12:25 |
devananda | Haomeng: just trying to keep the bug list accurate | 12:25 |
Haomeng | devananda: let me try to fix, and will ask you if I have questions | 12:27 |
Haomeng | devananda: yes, we have a lot of defect in the list | 12:27 |
Haomeng | devananda: yes, these days, I am focusing on some code review to get more understanding about our Ironic code | 12:32 |
Haomeng | devananda: so will take back to fix defect if required | 12:33 |
devananda | Haomeng: both good things to do :) | 12:34 |
devananda | romcheg: ping | 12:34 |
Haomeng | devananda: ok, I will do | 12:34 |
romcheg | Morning devananda | 12:34 |
devananda | g'morning | 12:34 |
Haomeng | devananda: for 1244541, I think we have to fix this both ironic api and ironic driver, an exception when overwriting the instance_uuid in ironic api, and implement a EAFP approach in nova ironic driver, right? | 12:42 |
devananda | Ghe_HPDiscover: I imagine you're busy at discover -- just a quick question. are you going to be able to work on bugs assigned to you over next few months (such as 1236536) or should they be unassigned? | 12:43 |
devananda | Haomeng: that's correct. ironic/db/api needs a new method specifically for set/unset instance_uuid, which will raise an exception instead of overwriting it | 12:45 |
Haomeng | devananda: ok, thank you | 12:45 |
devananda | Haomeng: then some changes eg. in the api to handle that exception | 12:46 |
devananda | Haomeng: welcome. thanks for taking a look at it! | 12:46 |
Haomeng | devananda: yes | 12:46 |
Haomeng | devananda: I like fix defect, that is challenge for me, can get more deep understand by fixing these bugs | 12:47 |
Haomeng | Haomeng: any time | 12:47 |
devananda | lucas-hungry: hi! what do you think of https://bugs.launchpad.net/ironic/+bug/1238117 today? still a bug, or did it get fixed amidst the last 2 months of work? | 12:48 |
devananda | Haomeng: think you'll be able to fix that by end of january? if so, i'll target it to i2 milestone | 12:50 |
Haomeng | devananda: that is ok, I will take this as high prority and ask you core team members for any issue | 12:51 |
Haomeng | devananda: I think that is enough time | 12:51 |
*** urulama has quit IRC | 12:53 | |
ekarlso | /win 38 | 12:58 |
*** vkozhukalov has quit IRC | 13:00 | |
*** urulama has joined #openstack-ironic | 13:13 | |
devananda | NobodyCam: hi! just sent you some pull requests for tripleo ironic element | 13:28 |
*** max_lobur is now known as max_lobur_afk | 13:30 | |
*** jcooley_ has joined #openstack-ironic | 13:30 | |
*** sandeepr has joined #openstack-ironic | 13:31 | |
*** jdob has joined #openstack-ironic | 13:35 | |
*** jcooley_ has quit IRC | 13:35 | |
*** prekarat has joined #openstack-ironic | 13:38 | |
devananda | NobodyCam: also i think your undercloud-vm-ironic.yaml file needs to have | 13:39 |
devananda | 216 compute_driver: ironic.driver.IronicDriver | 13:39 |
devananda | (or at least mine did) | 13:39 |
devananda | NobodyCam: and once I do that, I get teh following trace in nova-compute.log | 13:42 |
devananda | http://paste.openstack.org/show/54824/ | 13:43 |
*** rloo has joined #openstack-ironic | 13:47 | |
* devananda goes afk again | 13:47 | |
*** lucas-hungry is now known as lucasagomes | 14:01 | |
lucasagomes | devananda, morning, I don't think the API is fixing that, I we still need to add some sanity check on that area, def fixed by end of jan | 14:06 |
*** nosnos has quit IRC | 14:06 | |
*** dguitarbite has quit IRC | 14:11 | |
openstackgerrit | A change was merged to openstack/ironic: Port StringType class from WSME trunk https://review.openstack.org/60798 | 14:16 |
Haomeng | Ironic, nice day, I really want to go to bed, so tired:) | 14:18 |
*** michchap has quit IRC | 14:24 | |
*** linggao has joined #openstack-ironic | 14:24 | |
*** jcooley_ has joined #openstack-ironic | 14:25 | |
*** jcooley_ has quit IRC | 14:29 | |
*** matty_dubs|gone is now known as matty_dubs | 14:33 | |
lucasagomes | Haomeng, g'night! | 14:38 |
Haomeng | lucasagomes: nice day, Lucas:) | 14:39 |
lucasagomes | :) | 14:39 |
*** prekarat has quit IRC | 14:42 | |
*** max_lobur_afk is now known as max_lobur | 14:45 | |
*** viktors has joined #openstack-ironic | 14:51 | |
*** jdob has quit IRC | 15:00 | |
*** jdob has joined #openstack-ironic | 15:06 | |
*** vkozhukalov has joined #openstack-ironic | 15:07 | |
*** jcooley_ has joined #openstack-ironic | 15:18 | |
*** jcooley_ has quit IRC | 15:23 | |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Check connectivity in SSH driver 'validate' method https://review.openstack.org/60876 | 15:35 |
NobodyCam | good morning Ironic | 15:42 |
NobodyCam | devananda: what are you doinf up at 5 am? | 15:47 |
*** ndipanov has quit IRC | 15:48 | |
lucasagomes | NobodyCam, morning | 15:49 |
NobodyCam | morning lucasagomes :) | 15:51 |
NobodyCam | sorry for the last start this morning | 15:51 |
NobodyCam | how are you doinf today | 15:51 |
lucasagomes | not too bad, urself? | 15:52 |
NobodyCam | lol geeting a slow start this morning :-p | 15:53 |
*** ifarkas has quit IRC | 15:54 | |
*** urulama has quit IRC | 15:54 | |
lucasagomes | NobodyCam, heh yeah, you need ur first cup of joe :) | 15:55 |
NobodyCam | :) working on it ...lol | 15:56 |
lucasagomes | :D | 15:56 |
*** anniec has quit IRC | 15:57 | |
NobodyCam | brb getting the coffee :) | 16:03 |
lucasagomes | :) enjoy | 16:07 |
lucasagomes | devananda, ping | 16:11 |
*** hemna has joined #openstack-ironic | 16:13 | |
*** jcooley_ has joined #openstack-ironic | 16:15 | |
NobodyCam | ahh coffee | 16:15 |
*** jcooley_ has quit IRC | 16:20 | |
devananda | lucasagomes: pong | 16:24 |
NobodyCam | mornig devananda | 16:24 |
lucasagomes | devananda, thinking about ur review at 60194 re sanitize paths | 16:25 |
devananda | NobodyCam: g'morning! i see you already merged my pull reqs. hehe, thanks! | 16:25 |
lucasagomes | as they are hardcoded (won't change) do we really need an sanitize method? | 16:25 |
* devananda updates the wiki accordingly | 16:26 | |
devananda | lucasagomes: nope | 16:26 |
lucasagomes | devananda, right :) | 16:26 |
devananda | lucasagomes: that was my first thought. then i assumed you had put it there in case someone subclassed it and didn't follow the right pattern. but that's what unit tests are for, IMO. | 16:27 |
devananda | i think it's worth a check somewhere. but not in object's runtime path :) | 16:27 |
lucasagomes | cool yea | 16:27 |
lucasagomes | also because we don't instantiate that class ourself, it's done by wsme | 16:27 |
lucasagomes | so sanitizing on the constructor will have the same effect as sanitizing at the validate() method... the sanitize() will be called the same no of times | 16:28 |
lucasagomes | which is, everytime a request comes in | 16:28 |
devananda | right | 16:29 |
devananda | which seems very inefficient | 16:29 |
lucasagomes | yup | 16:29 |
lucasagomes | wsme instantiate that class and pass the object as a parameter to the validate() method | 16:29 |
lucasagomes | anyway I will update the patch | 16:30 |
lucasagomes | thanks for the reviews | 16:30 |
NobodyCam | :) | 16:30 |
NobodyCam | devananda: Was that error just after startup with no nodes registered to ironic? | 16:31 |
devananda | NobodyCam: no. I've registered a node in ironic. it happens any time i restart nova-compute | 16:31 |
devananda | lucasagomes: welcome! | 16:32 |
NobodyCam | ok | 16:32 |
*** hemna has quit IRC | 16:33 | |
devananda | lucasagomes: also, when you get a chance, you may want to skim https://review.openstack.org/#/c/59454/2/reference/incubation-integration-requirements for a baseline of what our requirements are | 16:33 |
*** jcooley_ has joined #openstack-ironic | 16:33 | |
devananda | lucasagomes: this came up at the TC meeting yesterday. I think it's something all our -core members should be at least aware of | 16:34 |
openstackgerrit | Artem Rozumenko proposed a change to openstack/ironic: ironic/common/exception.py wrap_exception method is never used https://review.openstack.org/61474 | 16:34 |
lucasagomes | devananda, right, will take a look at it. Thanks | 16:34 |
devananda | lucasagomes: re bug 1238117, and in general about our power/provision state strings, what do you think of copying ironic.common.states into the client lib? | 16:36 |
*** hemna has joined #openstack-ironic | 16:37 | |
lucasagomes | devananda, all the states or just the ones we are going to use? | 16:39 |
devananda | lucasagomes: why not all? | 16:39 |
lucasagomes | for example "initializing" idk if that makes sense to exist on the client | 16:39 |
lucasagomes | probably won't be used at all | 16:40 |
lucasagomes | I like the idea of having the states on the client | 16:40 |
lucasagomes | and if copying the whole thing makes it easier to syncup later, I think it's a fair trade-off | 16:40 |
devananda | lucasagomes: when I added rebooting to the client, it took some wrangling, because there is not a strict mapping of the states ENUM there | 16:40 |
devananda | ideally, i think we should have the states defined in only one place | 16:41 |
devananda | but the client can't do "from ironic import states" | 16:41 |
devananda | and we also need the states in the nova driver | 16:41 |
lucasagomes | devananda, yea, I hear you... I when i was thinking about triggering the "unprovisioning" I was tihnking about which state to use on the client | 16:41 |
devananda | yea, exactly... | 16:42 |
devananda | so syncing the file to the client seems the simplest approach. at least we can ensure that they stay in sync | 16:42 |
lucasagomes | devananda, fair I think it's a good idea | 16:42 |
devananda | cool | 16:42 |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Check connectivity in SSH driver 'validate' method https://review.openstack.org/60876 | 16:42 |
lucasagomes | devananda, another q about the client that I saw today when was codying the provision thing | 16:43 |
lucasagomes | should the client itself be awere about which state is valid before sending the request to the API? | 16:43 |
lucasagomes | e.g | 16:43 |
lucasagomes | for states/power we accept power on, power off and rebooting | 16:43 |
lucasagomes | but the library doesnt actually check if the state passed to it is one of those | 16:44 |
lucasagomes | it takes the state and submit to the api and the API would return 400 (badrequest) in case that's a invalid state | 16:44 |
lucasagomes | do you think we should capture it before in the library and return a BadRequest before doing the request to the API? | 16:45 |
lucasagomes | https://github.com/openstack/python-ironicclient/blob/master/ironicclient/v1/node.py#L86-L87 | 16:46 |
devananda | lucasagomes: nope. our client (both CLI and library) are, AFAIK, basically examples. Folks may (and will) write their own client libs (esp. in other languages) | 16:46 |
lucasagomes | note; the CLI does check it, but if you're using the libs it doesnt: https://github.com/openstack/python-ironicclient/blob/master/ironicclient/v1/node_shell.py#L149 | 16:47 |
lucasagomes | right | 16:47 |
devananda | well. so that doesn't make sense :) | 16:47 |
lucasagomes | also having the error returned from the API would be more informative (that's why I was confused) | 16:47 |
devananda | yea | 16:47 |
lucasagomes | yea so there's that incosistence there | 16:48 |
*** max_lobur has quit IRC | 16:48 | |
devananda | neither should check it, and we should handle the API error. or the lib should check it and STILL handle the API error. because there could be version difference that changes the string or some such | 16:48 |
lucasagomes | +1 | 16:48 |
lucasagomes | I can file a bug about it later on | 16:49 |
devananda | great | 16:49 |
devananda | oh, re: bugs, we (meaning, mostly, me) need to stay on top of bug triage and targeting bugs to milestones now | 16:49 |
lucasagomes | i see, yea I should give you a hand on that too, the new bugs I open/or I'm working on I try to set the milestone | 16:50 |
NobodyCam | lucasagomes: question on the deploy trigger stuff, are you also planning a destroy / undeploy in the client too? | 16:50 |
*** rongze_ has joined #openstack-ironic | 16:51 | |
devananda | any bug assigned to someone should be updated by that person :) | 16:51 |
lucasagomes | but I haven't gone trough the list of bugs to verify the rest | 16:51 |
lucasagomes | ahh | 16:51 |
lucasagomes | gotcha | 16:51 |
lucasagomes | NobodyCam, yup | 16:51 |
NobodyCam | :) sweet | 16:52 |
lucasagomes | NobodyCam, it's architeted in a way that makes it easy to extend to add more functions | 16:52 |
*** rongze__ has joined #openstack-ironic | 16:52 | |
*** rongze has quit IRC | 16:52 | |
devananda | the rest (all the unassigned bugs) probably shouldn't have a milestone set | 16:53 |
lucasagomes | but I don't have anything in place that actually do/trigger any undeploy | 16:53 |
devananda | like, if no one is saying "i'm going to fix this" then why would we tell the community "we'll have it fixed by this $date" ... | 16:53 |
lucasagomes | makes sense | 16:54 |
devananda | lucasagomes: i'm planning a 0.1.0 client release once the deploy/undeploy API is written & added to the client. sound good? | 16:55 |
lucasagomes | but at least I should go trough the list and verify some of the bugs to see whether they r valid or not | 16:55 |
openstackgerrit | James E. Blair proposed a change to openstack/ironic: Add -U to pip install command in tox.ini https://review.openstack.org/61488 | 16:55 |
devananda | lucasagomes: ++ | 16:55 |
devananda | we have a lot of open bugs, many of which I suspect are stale. I closed a couple last night that weren't applicable any more | 16:55 |
lucasagomes | devananda, sounds good, the deploy/undeploy, has some dependencies and when they get merged I think that's a good time to make a release | 16:55 |
lucasagomes | devananda, yea, I'm haven't been paying much attention for the new bugs, I should I will try to look at them more often | 16:56 |
*** rongze_ has quit IRC | 16:56 | |
lucasagomes | shame on me | 16:56 |
*** max_lobur has joined #openstack-ironic | 16:58 | |
*** yuriyz has quit IRC | 17:05 | |
*** rloo has quit IRC | 17:06 | |
devananda | lucasagomes: i haven't been doing triage as often as I should -- so I'm getting on top of it now, but there's a bit of a backlog | 17:06 |
*** rloo has joined #openstack-ironic | 17:06 | |
lucasagomes | I see, yea I can imagine | 17:06 |
devananda | for now, most of the bug filing is still being done by us, so it should be easy for us to stay on top of -- if we just all follow the policy when we file 'em | 17:07 |
devananda | once we get real users filing bugs, well, we'll see .... Nova's taken what I find to be a bit of a heavy approach, but then, they have a very high volume and needed to | 17:07 |
*** ifarkas has joined #openstack-ironic | 17:09 | |
*** rongze__ has quit IRC | 17:11 | |
lucasagomes | yea, I believe we are going to need some approach to deal with that once ironic we have ironic ready to replace nova baremetal, but yea let's not complicate things for now | 17:13 |
*** matty_dubs is now known as matty_dubs|lunch | 17:16 | |
openstackgerrit | James E. Blair proposed a change to openstack/python-ironicclient: Have tox install via setup.py develop https://review.openstack.org/61506 | 17:17 |
*** rongze has joined #openstack-ironic | 17:17 | |
*** tatyana has quit IRC | 17:17 | |
NobodyCam | bbt...brb | 17:23 |
*** digambar has joined #openstack-ironic | 17:25 | |
digambar | I have cloned all the code of ironic | 17:27 |
digambar | need to test it | 17:27 |
digambar | how can I do it | 17:27 |
digambar | ? | 17:27 |
NobodyCam | digambar: have you seen our wiki | 17:28 |
digambar | yes | 17:28 |
digambar | I am following those steps | 17:29 |
digambar | once done get back to you | 17:29 |
NobodyCam | ok :) | 17:29 |
digambar | Thanks | 17:29 |
*** blamar has joined #openstack-ironic | 17:30 | |
openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Clean up duplicated change-building code in objects https://review.openstack.org/61143 | 17:33 |
lucasagomes | digambar, http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html | 17:33 |
lucasagomes | ah u following it already :) | 17:34 |
*** digambar has quit IRC | 17:34 | |
*** digambar has joined #openstack-ironic | 17:39 | |
digambar | hi | 17:39 |
digambar | After following setup steps for ironic | 17:39 |
digambar | when I run | 17:39 |
digambar | create virtualenv | 17:40 |
digambar | got error | 17:40 |
digambar | No command 'create' found, did you mean: Command 'mcreate' from package 'lustre-utils' (universe) create: command not found | 17:40 |
digambar | I get above error | 17:40 |
NobodyCam | digambar: which are you doing local, devstack or DIB? | 17:41 |
digambar | ubuntu os | 17:41 |
digambar | this error is getting while installing ironic | 17:41 |
digambar | devstack is local | 17:42 |
NobodyCam | digambar: https://wiki.openstack.org/wiki/Ironic | 17:42 |
NobodyCam | I was reffering to the three ways we have up on hte wiki | 17:42 |
NobodyCam | so you are doing the devstack version? | 17:42 |
devananda | digambar: you create teh virtualenv by running " tox -evenv -- echo 'done' | 17:43 |
devananda | woops, bad paste | 17:43 |
devananda | digambar: you create teh virtualenv by running: tox -evenv -- echo 'done' | 17:43 |
digambar | okk | 17:43 |
digambar | tox -evenv -- echo 'done' | 17:54 |
digambar | python setup.py build_sphnix | 17:54 |
digambar | getting error | 17:54 |
digambar | error: invalid command 'build_sphinx' | 17:55 |
NobodyCam | digambar: did you source the venv? source .tox/venv/bin/activate | 17:55 |
digambar | yes | 17:55 |
digambar | (venv)root@openstack-cloud:~/ironic# python setup.py build_sphinx | 17:55 |
digambar | usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...] or: setup.py --help [cmd1 cmd2 ...] or: setup.py --help-commands or: setup.py cmd --help error: invalid command 'build_sphinx' | 17:56 |
digambar | above error it throws | 17:56 |
*** derekh has quit IRC | 17:57 | |
NobodyCam | are you setting up ironic or building he docs? | 17:58 |
digambar | setting up th eironic | 18:00 |
digambar | ironic** | 18:00 |
digambar | let me try it out with devstack | 18:01 |
digambar | I think that is easy way | 18:01 |
NobodyCam | digambar: you seem to be following the build the docs walk thru | 18:01 |
*** lexx has joined #openstack-ironic | 18:02 | |
digambar | ok | 18:03 |
digambar | how to install the ironic ? | 18:03 |
digambar | that's the doc it is, right? | 18:03 |
NobodyCam | https://wiki.openstack.org/wiki/Ironic#Try_it_on_Devstack | 18:03 |
NobodyCam | i use this one. https://wiki.openstack.org/wiki/Ironic#Using_Disk_Image_Builder | 18:03 |
*** matty_dubs|lunch is now known as matty_dubs | 18:03 | |
devananda | digambar: for what purpose are you trying to install ironic? | 18:04 |
digambar | I want to contribe to ironic ? | 18:04 |
NobodyCam | ya the two link I pasted will setup ironic | 18:04 |
digambar | okk | 18:04 |
NobodyCam | The one on the top of the page is for building the docs | 18:05 |
digambar | yep | 18:05 |
digambar | Thanks man | 18:06 |
NobodyCam | sure :) | 18:06 |
digambar | I'll setup up with devstack | 18:06 |
digambar | :) | 18:06 |
*** hemna has quit IRC | 18:08 | |
*** max_lobur is now known as max_lobur_afk | 18:09 | |
*** jistr has quit IRC | 18:13 | |
NobodyCam | brb quick walkies | 18:13 |
*** mdurnosvistov has quit IRC | 18:24 | |
*** digambar has quit IRC | 18:26 | |
*** datajerk has joined #openstack-ironic | 18:28 | |
openstackgerrit | A change was merged to openstack/ironic: Add -U to pip install command in tox.ini https://review.openstack.org/61488 | 18:28 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Add JsonPatchType class https://review.openstack.org/60194 | 18:33 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Rework patch validation on Ports https://review.openstack.org/56984 | 18:33 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Reworks Node validations https://review.openstack.org/57495 | 18:33 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Reworks Chassis validations https://review.openstack.org/57686 | 18:33 |
*** blamar has quit IRC | 18:41 | |
*** blamar has joined #openstack-ironic | 18:41 | |
*** lexx has quit IRC | 18:45 | |
*** anniec has joined #openstack-ironic | 18:50 | |
*** vetalll has joined #openstack-ironic | 18:55 | |
*** jdob has quit IRC | 19:03 | |
*** jdob has joined #openstack-ironic | 19:03 | |
lucasagomes | right I'm done for today have a good night everyone | 19:10 |
devananda | g'night! | 19:11 |
*** lucasagomes has quit IRC | 19:11 | |
NobodyCam | gah he's quicl | 19:12 |
NobodyCam | quick even | 19:12 |
*** rongze has quit IRC | 19:13 | |
*** rongze has joined #openstack-ironic | 19:15 | |
NobodyCam | devananda: with the computer driver it's set here | 19:21 |
NobodyCam | https://github.com/openstack/tripleo-heat-templates/blob/master/undercloud-vm-source.yaml#L20 | 19:21 |
NobodyCam | i'll update the walk thru | 19:22 |
*** rongze has quit IRC | 19:22 | |
devananda | NobodyCam: yea. i think when you are make'ing the ironic undercloud yaml, that should be replaced with ironic.driver.IronicDriver | 19:22 |
NobodyCam | yep | 19:23 |
*** mdurnosvistov has joined #openstack-ironic | 19:26 | |
openstackgerrit | dekehn proposed a change to openstack/ironic: Method to generate PXE options for Neutron ports https://review.openstack.org/60904 | 19:29 |
*** lexx has joined #openstack-ironic | 19:30 | |
*** ifarkas has quit IRC | 19:33 | |
*** openstackgerrit has quit IRC | 19:34 | |
*** openstackgerrit has joined #openstack-ironic | 19:34 | |
NobodyCam | brb | 19:41 |
devananda | dkehn: reviewed ^ just now. | 20:06 |
devananda | dkehn: any thoughts / progress on the actual "send this info to neutron" code? anything blocking that work that i can help unblock? | 20:07 |
*** jistr has joined #openstack-ironic | 20:08 | |
*** jistr has quit IRC | 20:08 | |
*** jistr_ has joined #openstack-ironic | 20:09 | |
*** jistr_ has quit IRC | 20:09 | |
*** jistr has joined #openstack-ironic | 20:10 | |
*** jistr has quit IRC | 20:11 | |
*** jistr has joined #openstack-ironic | 20:11 | |
*** romcheg has left #openstack-ironic | 20:25 | |
*** romcheg has joined #openstack-ironic | 20:25 | |
*** romcheg1 has joined #openstack-ironic | 20:28 | |
*** vkozhukalov has quit IRC | 20:29 | |
*** romcheg has quit IRC | 20:30 | |
NobodyCam | brb again | 20:34 |
NobodyCam | :-p | 20:34 |
*** romcheg has joined #openstack-ironic | 20:38 | |
*** tatyana has joined #openstack-ironic | 20:39 | |
*** romcheg1 has quit IRC | 20:40 | |
*** tatyana has quit IRC | 20:42 | |
romcheg | devananda, vetalll: if you want to discuss the bug, I'm available for that. | 20:48 |
devananda | romcheg: which bug? I have been triaging a lot today :p | 20:48 |
romcheg | Oh :) | 20:48 |
romcheg | This one: https://bugs.launchpad.net/ironic/+bug/1251880 | 20:48 |
*** kui has joined #openstack-ironic | 20:49 | |
*** lexx has quit IRC | 20:51 | |
* devananda looks | 20:53 | |
devananda | ah! | 20:53 |
*** lucasagomes has joined #openstack-ironic | 20:54 | |
lucasagomes | devananda, ping | 20:54 |
devananda | lucasagomes: pong | 20:55 |
lucasagomes | devananda, I comment on the 60194 re staticmethod | 20:55 |
romcheg | devananda: Does it make sense to add that example to the description | 20:55 |
lucasagomes | maybe that's not the best way to do it, so I want to discuss it here | 20:55 |
*** anniec has quit IRC | 20:55 | |
devananda | romcheg: i have no problem with /v1.json or /v1.xml | 20:58 |
devananda | romcheg: without any auth | 20:58 |
devananda | romcheg: well, the root controller works. but the resource controllers don't | 20:59 |
devananda | $ curl -H "Content-type: application/json" http://192.0.2.2:6385/v1.json/nodes/ | 20:59 |
*** jistr has quit IRC | 20:59 | |
devananda | {"error_message": "{\"debuginfo\": null, \"faultcode\": \"Client\", \"faultstring\": \"Expected an uuid or int but received v1.json.\"}"} | 20:59 |
devananda | lucasagomes: thinking ... | 20:59 |
romcheg | I think it should not work this way | 21:00 |
romcheg | Just compare http://192.0.2.2:6385/v1.json/nodes/ and http://192.0.2.2:6385/v1.json/nodes/ | 21:00 |
romcheg | Argh! | 21:00 |
romcheg | Just compare http://192.0.2.2:6385/v1.json/nodes/ and http://192.0.2.2:6385/v1.json/nodes/ | 21:00 |
devananda | lucasagomes: i understand the need for an inherited class to access teh base classes internal_attr | 21:00 |
romcheg | WTF | 21:00 |
romcheg | Just compare http://192.0.2.2:6385/v1.json and http://192.0.2.2:6385/v1 | 21:01 |
devananda | lucasagomes: but how is this different from mandatory_attr, except that the baseclass defines this as an empty list today? | 21:01 |
lucasagomes | devananda, no difference | 21:01 |
devananda | romcheg: there is no difference | 21:01 |
lucasagomes | I mean | 21:01 |
lucasagomes | the base class does have any mandatory attributes by default | 21:02 |
romcheg | devananda: Both do not require authentication, do they? | 21:02 |
devananda | romcheg: correct | 21:02 |
lucasagomes | maybe both should be staticmethod for consistence, or I should think in another way to access the attributes from the base class | 21:02 |
romcheg | Then the bug appears to be fixed | 21:03 |
romcheg | By some brave but unknown hero :) | 21:03 |
devananda | romcheg: however. there may be something odd in my env, but i dont know how ... | 21:03 |
romcheg | I'm checking the sources | 21:03 |
devananda | romcheg: i am able to curl v1/nodes/{UUID} without passing any auth token in headers | 21:03 |
romcheg | Ah, you have noauth in your settings file | 21:04 |
devananda | NobodyCam: do you have an environment spun up? | 21:04 |
devananda | romcheg: ahh. that may be | 21:04 |
devananda | lucasagomes: i think both being staticmethod is fine | 21:04 |
romcheg | After changing that to keystone, you will notice the difference | 21:04 |
NobodyCam | ??? not atm was rebuilding my env | 21:04 |
lucasagomes | devananda, right, I will update the patches | 21:05 |
lucasagomes | cheers :) | 21:05 |
devananda | lucasagomes: i pulled the following patch (that fixes up the port class) and changed it to staticmethod in both base and port modules, didn't have any problems | 21:05 |
devananda | lucasagomes: cheers! I'll +2 it for realz this time :) | 21:05 |
lucasagomes | devananda, yea there's np, they get overwritten | 21:05 |
devananda | NobodyCam: nvm - think i figured it out | 21:05 |
lucasagomes | devananda, hehe np, if you spot another thing don't hesitate in -1 or question it | 21:05 |
* lucasagomes learns a lot from the reviews | 21:06 | |
devananda | romcheg: wait, where are you seeing noauth in a setting file? | 21:06 |
romcheg | If you are able to access /v1/nodes without submitting an auth token, than means you have noauth | 21:07 |
romcheg | Which is default | 21:07 |
devananda | ahhh got it | 21:08 |
romcheg | # Method to use for auth: noauth or keystone. (string value) | 21:08 |
romcheg | #auth_strategy=noauth | 21:08 |
devananda | bingo | 21:08 |
devananda | NobodyCam: your template needs to include "auth_strategy=keystone" | 21:08 |
devananda | actually | 21:08 |
devananda | we just need to change the default | 21:09 |
devananda | NobodyCam: nvm again -- i'm just going to patch it | 21:09 |
devananda | no auth is not a sane default | 21:09 |
NobodyCam | lol sure | 21:09 |
NobodyCam | nova-ironic adds all the auth info to nova conf for ironic | 21:09 |
romcheg | We do not have keystone options in the sample config file | 21:09 |
NobodyCam | there was a line on the agenda for that | 21:10 |
romcheg | I think I know how to fix that | 21:10 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Change default API auth to keystone-based https://review.openstack.org/61568 | 21:11 |
devananda | romcheg: ^ | 21:11 |
devananda | :) | 21:11 |
*** epim has joined #openstack-ironic | 21:11 | |
romcheg | I definitely have problems with reviews. | 21:11 |
romcheg | Shame on me | 21:11 |
romcheg | Do other projects use keystone as the default value for that? | 21:12 |
devananda | romcheg: ok, NOW i see the problem you're talking about in the bug | 21:12 |
romcheg | In nova they use noauth: https://github.com/openstack/nova/blob/master/etc/nova/nova.conf.sample#L325 | 21:13 |
*** anniec has joined #openstack-ironic | 21:14 | |
devananda | lifeless: i suspect i know your opinion on using auth_strategy=noauth as the default. Mine is that it is not a #sanedefault | 21:14 |
romcheg | In neutron they use keystone | 21:16 |
devananda | here's another oddity | 21:17 |
devananda | changing header to -H "Content-type: text/xml" does not change response type | 21:17 |
romcheg | devananda: you should specify Accept | 21:19 |
romcheg | Content-type defines the format of the request but does not specifies the expected responce | 21:19 |
romcheg | response | 21:19 |
romcheg | Damn word, I will never remember how to write it :) | 21:19 |
devananda | hmm | 21:20 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Add JsonPatchType class https://review.openstack.org/60194 | 21:20 |
devananda | ah. duh, of course | 21:20 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Rework patch validation on Ports https://review.openstack.org/56984 | 21:20 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Reworks Node validations https://review.openstack.org/57495 | 21:20 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Reworks Chassis validations https://review.openstack.org/57686 | 21:21 |
devananda | romcheg: right. and that works :) | 21:21 |
devananda | romcheg: curl -H "Accept: text/xml" ... | 21:21 |
devananda | romcheg: also taht works without auth. so only the URI suffix is getting blocked | 21:22 |
*** epim has quit IRC | 21:25 | |
*** lucasagomes is now known as lucas-dinner | 21:29 | |
*** epim has joined #openstack-ironic | 21:32 | |
*** anniec has quit IRC | 21:33 | |
*** jcooley_ has quit IRC | 21:34 | |
lifeless | devananda: I agree :) | 21:35 |
*** epim has quit IRC | 21:36 | |
openstackgerrit | Artem Rozumenko proposed a change to openstack/ironic: removed wrap_exception method from ironic/common/exception.py https://review.openstack.org/61474 | 21:36 |
*** jcooley_ has joined #openstack-ironic | 21:39 | |
*** anniec has joined #openstack-ironic | 21:42 | |
*** lexx has joined #openstack-ironic | 21:48 | |
NobodyCam | devananda: do we need to poke any one about this review? https://review.openstack.org/#/c/60638 | 21:49 |
devananda | maybe. lemme see | 21:51 |
*** vetalll has quit IRC | 21:51 | |
devananda | I've added a few requirements-core to the review. and we can poke when it becomes more pressing | 21:54 |
devananda | I'll tag it with a bp to raise the review ranking | 21:54 |
NobodyCam | :) | 21:54 |
devananda | well, nvm. i'm not sure that works across projects | 21:55 |
devananda | the bp is in nova.... | 21:55 |
*** kushi_ has joined #openstack-ironic | 21:57 | |
*** kui has quit IRC | 21:58 | |
SpamapS | hm | 21:58 |
SpamapS | will Ironic have something to mark a baremetal node as "don't deploy new things to this" ? | 21:59 |
SpamapS | Oh and hey, y'all should write some Heat resource plugins. | 21:59 |
*** anniec has quit IRC | 22:00 | |
devananda | heya SpamapS | 22:01 |
devananda | we don't currently have that. it sounds like a bug (want to file it?) | 22:01 |
devananda | 'cause we totally should expose that in our API | 22:01 |
SpamapS | devananda: yes.. unless you have a better answer for "how do I prevent new things from going onto hardware right after I delete the instance deployed on it?" | 22:02 |
devananda | SpamapS: as far as heat resource plugins, I'm not up on that, but NobodyCam has been working on adding Ironic to tripleo / dib / etc. Perhaps he has something? | 22:02 |
devananda | SpamapS: well, as it is today, *you* dont do that. Ironic will not allow new requests on that node until it is finished doing what ever teardown it needed to | 22:03 |
SpamapS | NobodyCam: we haven't talked about Heat plugins.. but it would make a lot of sense to be able to express inventory as a heat stack. :) | 22:03 |
*** jdob has quit IRC | 22:03 | |
devananda | SpamapS: in what situation would you want to explicitly delete an instance and then stop any activity on the node that instance was previously on? that seems like conflating two things to me | 22:03 |
lifeless | SpamapS: maybe | 22:03 |
devananda | but IMBMS | 22:03 |
SpamapS | devananda: So I'm responding to a laundry list of DC OPS / TechOps situations from almost a year ago.. and the "how do I replace a hard drive that requires power off / power on" story is tricky without that. | 22:04 |
lifeless | SpamapS: but you can't deploy to a thing you can't match hardware descriptions against :) | 22:04 |
*** linggao has quit IRC | 22:04 | |
NobodyCam | SpamapS: ya | 22:04 |
devananda | SpamapS: the "put this node into maintenance mode" thing is _totaly_ something we need to expose | 22:05 |
lifeless | SpamapS: I know the list of which you speak, and mmm the use cases are good but it was shoehorned into specific products on a marketing basis. | 22:05 |
devananda | SpamapS: the relationship between "delete an instance" and "put that node into maintenance" doesn't seem like something Ironic cares about, but we should give you enough info to do it | 22:05 |
SpamapS | lifeless: Right, I've been asked to resurrect it for a deep dive w/ some HP peeps next week. | 22:05 |
lifeless | putting a node into maintenance seems like 'evacuate this hypervisor' to me. | 22:05 |
devananda | lifeless: yep | 22:06 |
devananda | similar | 22:06 |
lifeless | SpamapS: face to face or virt? May I hang with? | 22:06 |
SpamapS | It is evacuate yes. | 22:06 |
SpamapS | lifeless: in person in Sunnyvale. Would be happy to G+ you in :) | 22:06 |
lifeless | so, if you have evacuate with say kvm and no live migrate, how should heat handle that... is how we should frame it, I think. | 22:06 |
SpamapS | lifeless: In this case, I want to delete the instance. | 22:07 |
devananda | SpamapS: sounds like something I should be pulled into as well. and sunnyvale isn't that far for me .... | 22:07 |
SpamapS | lifeless: I don't want that IP to be up anymore. Heat has already let go of the machine. | 22:07 |
lifeless | to whit, you want to a) stop scheduling more work to the hypervisor, b) signal out somewhere that the instances on it are about to be deleted, c) wait for a timeout, d) delete. | 22:07 |
SpamapS | devananda: The more the merrier! and I would feel quite a bit better about things if I had an ironic expert there with me. | 22:07 |
lifeless | SpamapS: How did Heat know to let go ? | 22:07 |
SpamapS | lifeless: so the box is already down logically. Disk is dead. | 22:08 |
devananda | SpamapS: pls send me the details (assuming someone hasn't already ... i'm a bit behind on corp mail right now) | 22:08 |
SpamapS | no raid, or raid double-degraded.. disk problems.. box is not serving traffic | 22:08 |
lifeless | SpamapS: then heat will have deleted the instance already, nothing to see here | 22:08 |
lifeless | SpamapS: 'I need to delete the instance' only applies if heat doesn't yet know there is a problem | 22:08 |
SpamapS | lifeless: right, and then ironic starts trying to put new things on it... wasting new things' time. | 22:08 |
lifeless | SpamapS: so thats a different scenario now - I agree they relate | 22:09 |
lifeless | but 'I have a box that can't be deployed to and it shouldn't make everything super slow' | 22:09 |
lifeless | vs 'I have a box that I want to take out usage which currently has a workload on it' | 22:09 |
SpamapS | the progression is that between box down and delete instance I want to make the hardware unavailable. | 22:10 |
NobodyCam | sorry guy I have to step away for just a bit... be back | 22:10 |
lifeless | SpamapS: why? | 22:10 |
SpamapS | lifeless: because if it gets reclaimed, how do I then un-claim it? | 22:10 |
SpamapS | I can't delete an in-use baremetal node. | 22:11 |
devananda | SpamapS: a) sure you can | 22:11 |
SpamapS | Assuming here, that Ironic also has a similar requirement. | 22:11 |
lifeless | SpamapS: so this is why I'm challenging you to make these really crystal clear scenarios | 22:11 |
lifeless | SpamapS: because if the box is *down*, it won't get anything new on it. | 22:11 |
lifeless | SpamapS: because it will fail to deploy. | 22:11 |
SpamapS | it will get tried | 22:11 |
lifeless | SpamapS: which is the 'I have a box that can't be deployed to and it shouldn't make everything super | 22:11 |
lifeless | slow' | 22:11 |
lifeless | scenario that happens independently | 22:11 |
lifeless | so we have to solve that | 22:12 |
devananda | lifeless: i think the technical solution to both scenarios is identical | 22:12 |
lifeless | but why does heat care that Ironic will try a bad box ? -> Because it makes things slow. So we need to fix *that* | 22:12 |
lifeless | devananda: could be! | 22:12 |
devananda | lifeless: though i agree they are different scenarios | 22:12 |
SpamapS | seems relatively simple and I'm surprised you are trying to flush things out with something that is pretty obvious to me: boxes will be taken out of the pool of available hardware. | 22:12 |
lifeless | SpamapS: I'm trying to avoid layer confusion | 22:12 |
* devananda likes layer cakes | 22:13 | |
SpamapS | Heat, btw, does not care that ironic will try a bad box. | 22:13 |
SpamapS | I just mentioned Heat because it came to mind. | 22:13 |
lifeless | SpamapS: hey, we were going to do face time about service enablement | 22:13 |
devananda | so, here is the technical side of solving this | 22:13 |
SpamapS | So ignore Heat. Heat will not care. :) | 22:13 |
SpamapS | lifeless: we should yes | 22:13 |
devananda | mark the node as in maintenance mode first -- this should work whether the physical hardware is functioning or not | 22:14 |
devananda | it won't kill any existing workload, but it should stop ironic from putting new workload on it AND remove its availablility from nova-scheduler (at the next periodic-task cycle) | 22:14 |
devananda | then delete the instance -- this should also work whether or not the physical hardware is functioning, though i'm not sure it will, today | 22:15 |
lifeless | devananda: seems like we should be able to tell the scheduler immediately | 22:15 |
lifeless | devananda: if you cannot, please file a bug? | 22:15 |
devananda | lifeless: AFAIK, nova-scheduler only processes updates to the list of compute hosts once a minute | 22:15 |
lifeless | devananda: we're fixing that :) | 22:15 |
devananda | ooh! great | 22:16 |
devananda | then nvm :) | 22:16 |
lifeless | point is that I think there may not be an 'unregister' call today | 22:16 |
lifeless | so we need to add that | 22:16 |
devananda | right | 22:16 |
devananda | in both the baremetal and ironic drivers in nova | 22:16 |
lifeless | for which a bug would be useful | 22:16 |
devananda | SpamapS: did you file a bug for ^^ in ironic? | 22:17 |
SpamapS | no because I am still wrapping head around what is actually needed :) | 22:17 |
SpamapS | and as you all know, my head is rather thick and inflexible ;) | 22:17 |
lifeless | :) | 22:17 |
* devananda files it, then takes a break | 22:17 | |
lifeless | so, I think at the ironic layer maintenance + instance deletion being decoupled is super useful | 22:17 |
lifeless | but | 22:17 |
lifeless | I want to point out that the folk running the overcloud | 22:18 |
lifeless | and the folk provisioning the hardware may be separate | 22:18 |
lifeless | and not share creds | 22:18 |
lifeless | so this is why I'm talking layer confusion. | 22:18 |
lifeless | Long term I think we want to be able to say 'node X is in trouble, it is to be removed' and have that propogate gracefully out to $whereever | 22:18 |
lifeless | heat, chef, Fred in the corner with a laptop - I don't care | 22:18 |
lifeless | to let them gracefully [assuming it's not a hard failure] get their instance off the node | 22:19 |
lifeless | And secondly I think we have to make sure we don't bake in an assumption like 'the Heat that deploys the overcloud will be able to do admin operations on Ironic'. | 22:19 |
lifeless | Note that I am not arguing that such ops team separation is *good*, I am just arguing that it *is*. | 22:20 |
lifeless | SpamapS: so - throw me a meeting invite for the deep dive | 22:21 |
lifeless | SpamapS: and g+ now? | 22:21 |
*** anniec has joined #openstack-ironic | 22:21 | |
SpamapS | lifeless: G+ in a minute, just captured neutron/nova in a race that takes a few minutes to resolve hoping to get more data into a bug | 22:22 |
lifeless | ok | 22:22 |
devananda | lifeless: I agree on the unassailable fact that there *will* be privilege separation at that layer, whether or not we agree with it | 22:23 |
devananda | also, here's the bug: https://bugs.launchpad.net/ironic/+bug/1260099 | 22:23 |
lifeless | cool, thanks! | 22:25 |
lifeless | devananda: you say 'should not adversely affect management of...' | 22:25 |
lifeless | devananda: I'd like to propose adding 'or operation' before 'of' :) | 22:25 |
lifeless | e.g. it shouldn't power the node off :) | 22:26 |
devananda | lifeless: ++ | 22:26 |
lifeless | I'll edit the description | 22:26 |
* devananda did | 22:26 | |
*** kushi_ has quit IRC | 22:26 | |
*** kushi_ has joined #openstack-ironic | 22:27 | |
lifeless | heh, inflight - cool | 22:27 |
SpamapS | oh hmmmm | 22:28 |
SpamapS | no agents for compute node | 22:28 |
*** matty_dubs is now known as matty_dubs|gone | 22:29 | |
devananda | lifeless: https://bugs.launchpad.net/nova/+bug/1260102 | 22:31 |
*** michchap has joined #openstack-ironic | 22:31 | |
devananda | lifeless: i need to run. please edit that if you are so inclined :) | 22:31 |
lifeless | devananda: I will triage it for you | 22:31 |
lifeless | devananda: tsk! | 22:31 |
lifeless | devananda: and ciao! | 22:32 |
* devananda steps out for a while | 22:32 | |
openstackgerrit | dekehn proposed a change to openstack/ironic: Method to generate PXE options for Neutron ports https://review.openstack.org/60904 | 22:35 |
*** anniec has quit IRC | 22:45 | |
*** anniec has joined #openstack-ironic | 22:47 | |
*** mdurnosvistov has quit IRC | 22:48 | |
*** kushi_ has quit IRC | 22:51 | |
*** kushi_ has joined #openstack-ironic | 22:52 | |
*** romcheg has quit IRC | 22:54 | |
*** datajerk has quit IRC | 22:55 | |
*** anniec has quit IRC | 23:01 | |
*** kushi_ has quit IRC | 23:05 | |
*** kushi__ has joined #openstack-ironic | 23:05 | |
*** anniec has joined #openstack-ironic | 23:07 | |
*** anniec has quit IRC | 23:10 | |
*** lucas-dinner has quit IRC | 23:33 | |
*** openstackgerrit has quit IRC | 23:35 | |
*** openstackgerrit has joined #openstack-ironic | 23:36 | |
*** blamar has quit IRC | 23:39 | |
*** anniec has joined #openstack-ironic | 23:40 | |
*** kushi__ has quit IRC | 23:43 | |
*** openstackgerrit has quit IRC | 23:56 | |
*** openstackgerrit has joined #openstack-ironic | 23:56 | |
*** blamar has joined #openstack-ironic | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!