| *** jcooley_ has quit IRC | 00:02 | |
| *** jcooley_ has joined #openstack-ironic | 00:06 | |
| *** jcooley_ has quit IRC | 00:08 | |
| * devananda steps out for a few | 00:10 | |
| NobodyCam | :) | 00:10 |
|---|---|---|
| *** jcooley_ has joined #openstack-ironic | 00:10 | |
| NobodyCam | ls /work | 00:10 |
| NobodyCam | doh | 00:11 |
| *** michchap has quit IRC | 00:42 | |
| *** michchap has joined #openstack-ironic | 00:42 | |
| * NobodyCam wanders afk | 00:44 | |
| *** jcooley_ has quit IRC | 00:50 | |
| *** jcooley_ has joined #openstack-ironic | 00:53 | |
| *** nosnos has joined #openstack-ironic | 00:54 | |
| *** kushi_ has quit IRC | 01:00 | |
| *** nosnos has quit IRC | 01:06 | |
| *** nosnos has joined #openstack-ironic | 01:06 | |
| *** epim has quit IRC | 01:47 | |
| *** kui has joined #openstack-ironic | 01:48 | |
| *** jcooley_ has quit IRC | 02:08 | |
| *** kui has quit IRC | 02:38 | |
| *** vkozhukalov has joined #openstack-ironic | 02:48 | |
| *** jimjiang has quit IRC | 02:51 | |
| *** jimjiang has joined #openstack-ironic | 02:52 | |
| *** jimjiang has quit IRC | 02:57 | |
| *** jimjiang has joined #openstack-ironic | 02:58 | |
| *** rloo_ has quit IRC | 03:11 | |
| *** rloo has joined #openstack-ironic | 03:12 | |
| *** rloo has quit IRC | 03:19 | |
| *** rongze has joined #openstack-ironic | 03:40 | |
| *** jimjiang has quit IRC | 03:55 | |
| *** jimjiang has joined #openstack-ironic | 03:56 | |
| *** itooon has joined #openstack-ironic | 04:14 | |
| *** jimjiang has quit IRC | 04:25 | |
| *** jimjiang has joined #openstack-ironic | 04:26 | |
| *** rongze has quit IRC | 04:33 | |
| *** rongze has joined #openstack-ironic | 04:55 | |
| *** rongze_ has joined #openstack-ironic | 04:59 | |
| *** rongze has quit IRC | 05:00 | |
| *** rongze_ has quit IRC | 05:04 | |
| *** prekarat has joined #openstack-ironic | 05:44 | |
| openstackgerrit | Jenkins proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/61920 | 06:00 |
| *** itooon_ has joined #openstack-ironic | 06:00 | |
| *** itooon has quit IRC | 06:02 | |
| *** itooon_ is now known as itooon | 06:02 | |
| *** hstimer has quit IRC | 06:07 | |
| *** hstimer has joined #openstack-ironic | 06:09 | |
| *** rongze has joined #openstack-ironic | 06:15 | |
| *** harlowja is now known as harlowja_away | 06:43 | |
| *** vkozhukalov has quit IRC | 06:51 | |
| *** michchap has quit IRC | 07:02 | |
| *** michchap has joined #openstack-ironic | 07:03 | |
| *** jcooley_ has joined #openstack-ironic | 07:03 | |
| *** jcooley_ has quit IRC | 07:07 | |
| *** jcooley_ has joined #openstack-ironic | 07:09 | |
| *** jcooley_ has quit IRC | 07:14 | |
| *** urulama has joined #openstack-ironic | 07:33 | |
| *** jimjiang has quit IRC | 07:47 | |
| *** jimjiang has joined #openstack-ironic | 07:48 | |
| openstackgerrit | Fengqian.gao proposed a change to stackforge/pyghmi: Add BMC bridge request extension https://review.openstack.org/60768 | 07:51 |
| *** YuikoTakada has joined #openstack-ironic | 07:55 | |
| *** YuikoTakada_ has joined #openstack-ironic | 07:58 | |
| *** YuikoTakada has quit IRC | 08:00 | |
| *** YuikoTakada_ has quit IRC | 08:02 | |
| *** YuikoTakada has joined #openstack-ironic | 08:02 | |
| *** vkozhukalov has joined #openstack-ironic | 08:26 | |
| *** jimjiang has quit IRC | 08:39 | |
| *** jimjiang has joined #openstack-ironic | 08:40 | |
| *** ifarkas has joined #openstack-ironic | 08:40 | |
| *** urulama has quit IRC | 08:47 | |
| *** urulama has joined #openstack-ironic | 08:54 | |
| *** jistr has joined #openstack-ironic | 09:00 | |
| *** ndipanov_gone is now known as ndipanov | 09:01 | |
| *** prekarat has quit IRC | 09:01 | |
| *** marty- has joined #openstack-ironic | 09:02 | |
| *** prekarat has joined #openstack-ironic | 09:04 | |
| *** YuikoTakada has quit IRC | 09:04 | |
| *** hstimer has quit IRC | 09:06 | |
| *** nosnos has quit IRC | 09:07 | |
| *** marty- has quit IRC | 09:07 | |
| *** nosnos has joined #openstack-ironic | 09:07 | |
| *** derekh has joined #openstack-ironic | 09:07 | |
| *** lucasagomes has joined #openstack-ironic | 09:31 | |
| *** vkozhukalov has quit IRC | 09:35 | |
| *** martyntaylor has joined #openstack-ironic | 09:44 | |
| *** martyntaylor1 has joined #openstack-ironic | 09:47 | |
| *** martyntaylor has quit IRC | 09:48 | |
| *** vkozhukalov has joined #openstack-ironic | 09:50 | |
| *** max_lobur_afk is now known as max_lobur | 10:00 | |
| *** agordeev has joined #openstack-ironic | 10:10 | |
| *** itooon has quit IRC | 10:17 | |
| *** itooon has joined #openstack-ironic | 10:20 | |
| *** jcooley_ has joined #openstack-ironic | 10:33 | |
| *** jcooley_ has quit IRC | 10:38 | |
| *** vkozhukalov has quit IRC | 10:40 | |
| *** jcooley_ has joined #openstack-ironic | 10:43 | |
| *** jcooley_ has quit IRC | 10:48 | |
| *** jcooley_ has joined #openstack-ironic | 10:48 | |
| *** martyntaylor1 has quit IRC | 10:50 | |
| GheRivero | morning all | 10:51 |
| *** vkozhukalov has joined #openstack-ironic | 10:52 | |
| *** jcooley_ has quit IRC | 10:52 | |
| *** jcooley_ has joined #openstack-ironic | 10:53 | |
| *** jcooley_ has quit IRC | 10:58 | |
| *** jcooley_ has joined #openstack-ironic | 10:58 | |
| *** jcooley_ has quit IRC | 11:03 | |
| *** itooon has quit IRC | 11:03 | |
| *** jcooley_ has joined #openstack-ironic | 11:04 | |
| lucasagomes | GheRivero, good morning | 11:06 |
| *** jcooley_ has quit IRC | 11:08 | |
| *** jcooley_ has joined #openstack-ironic | 11:14 | |
| *** jimjiang has quit IRC | 11:17 | |
| *** jimjiang has joined #openstack-ironic | 11:18 | |
| *** jcooley_ has quit IRC | 11:19 | |
| *** jcooley_ has joined #openstack-ironic | 11:19 | |
| *** rongze has quit IRC | 11:19 | |
| *** jcooley_ has quit IRC | 11:23 | |
| *** jcooley_ has joined #openstack-ironic | 11:24 | |
| *** jimjiang has quit IRC | 11:25 | |
| openstackgerrit | Ghe Rivero proposed a change to openstack/python-ironicclient: Update openstack-common.conf modules https://review.openstack.org/62606 | 11:25 |
| *** jimjiang has joined #openstack-ironic | 11:26 | |
| Haomeng | GheRivero: morning | 11:28 |
| Haomeng | lucasagomes: morning:) | 11:28 |
| lucasagomes | Haomeng, morning | 11:29 |
| *** jcooley_ has quit IRC | 11:29 | |
| Haomeng | lucasagomes: ) | 11:29 |
| *** jcooley_ has joined #openstack-ironic | 11:30 | |
| Haomeng | lucasagomes: I have a concern about our node creating API | 11:30 |
| lucasagomes | Haomeng, yea? | 11:30 |
| *** jimjiang has quit IRC | 11:31 | |
| Haomeng | lucasagomes: looks like for current code behavior, there is no any Mandatory fields to be filled when creating | 11:31 |
| lucasagomes | Haomeng, there's a patch upstream for it | 11:31 |
| Haomeng | lucasagomes: how do you think if this is as design, or we will add the validation | 11:31 |
| lucasagomes | Haomeng, https://review.openstack.org/#/c/57495/ | 11:32 |
| Haomeng | lucasagomes: ok, let me check | 11:32 |
| lucasagomes | Haomeng, so we use WSME to check for mandatory fields for us | 11:32 |
| lucasagomes | e.g driver = wsme.wsattr(wtypes.text, mandatory=True) | 11:32 |
| lucasagomes | :) | 11:32 |
| Haomeng | lucasagomes: this is great:) | 11:32 |
| Haomeng | lucasagomes: so I am out:) | 11:32 |
| lucasagomes | that patch was approaved a day before yesterday, but I had to rebase and fix the merge errors | 11:32 |
| lucasagomes | so needs to be reviewed | 11:33 |
| Haomeng | lucasagomes: no rush | 11:33 |
| Haomeng | lucasagomes: just run our node creation, found such issue | 11:33 |
| lucasagomes | :) | 11:33 |
| *** jcooley_ has quit IRC | 11:34 | |
| Haomeng | lucasagomes: one more question about - https://review.openstack.org/#/c/61160/ | 11:34 |
| Haomeng | lucasagomes: if you have time:) | 11:35 |
| * lucasagomes needs to fix that patch hehe | 11:35 | |
| lucasagomes | Haomeng, sure | 11:35 |
| *** jcooley_ has joined #openstack-ironic | 11:35 | |
| Haomeng | lucasagomes: is this patch is working for to depoly bm with API call - /nodes/<uuid>/states/provision ? | 11:35 |
| Haomeng | lucasagomes: I understand we can call /nodes/<uuid>/states/provision to depoly a bm node with pxe, right? | 11:36 |
| Haomeng | lucasagomes: I see our code will call "pecan.request.rpcapi.do_node_deploy" | 11:37 |
| lucasagomes | Haomeng, yes, the ironic driver on nova will use that URI to trigger the deployment of the node | 11:37 |
| Haomeng | lucasagomes: if this is case, how do you think if we need one more Ironic CLI to call this API for user to launch depolyment with Ironic CLI? | 11:37 |
| lucasagomes | not only with PXE, it's generic | 11:37 |
| Haomeng | lucasagomes: yes | 11:37 |
| Haomeng | lucasagomes: for all node driver Ironic support | 11:38 |
| lucasagomes | Haomeng, so, as we want ironic to use nova as endpoint it won't be exposed in our CLI | 11:38 |
| lucasagomes | it will be in our client libraries | 11:38 |
| Haomeng | lucasagomes: ok | 11:38 |
| Haomeng | lucasagomes: so for now, our Ironic is launched by Nova Ironic driver only | 11:38 |
| Haomeng | lucasagomes: can not be integrated with other non-nova systems | 11:38 |
| lucasagomes | that's something that can be discussed, but my understand is that it's available on the lib only (ofc people can extend the cli using the lib if they wish to expose it) | 11:39 |
| Haomeng | lucasagomes: yes, for our first version, we will not cover more CLI, that is right way:) | 11:39 |
| lucasagomes | Haomeng, we still use the most of other openstack services as we can | 11:39 |
| lucasagomes | nova, glance, neutron etc | 11:39 |
| *** jcooley_ has quit IRC | 11:39 | |
| Haomeng | lucasagomes: yes | 11:40 |
| lucasagomes | s/we still/we will/ | 11:40 |
| Haomeng | lucasagomes: :) | 11:40 |
| Haomeng | lucasagomes: got it thank you:) | 11:40 |
| Haomeng | lucasagomes: nice day:) | 11:40 |
| lucasagomes | Haomeng, you welcome :) | 11:40 |
| Haomeng | lucasagomes: :) | 11:40 |
| *** jcooley_ has joined #openstack-ironic | 11:40 | |
| *** jimjiang has joined #openstack-ironic | 11:42 | |
| *** rongze has joined #openstack-ironic | 11:44 | |
| *** jcooley_ has quit IRC | 11:45 | |
| *** rongze_ has joined #openstack-ironic | 11:45 | |
| *** jcooley_ has joined #openstack-ironic | 11:46 | |
| *** rongze has quit IRC | 11:49 | |
| *** itooon has joined #openstack-ironic | 11:50 | |
| *** jcooley_ has quit IRC | 11:50 | |
| *** jcooley_ has joined #openstack-ironic | 11:51 | |
| *** jimjiang has quit IRC | 11:51 | |
| *** jimjiang has joined #openstack-ironic | 11:53 | |
| *** jcooley_ has quit IRC | 11:55 | |
| *** jcooley_ has joined #openstack-ironic | 11:56 | |
| *** jimjiang has quit IRC | 11:57 | |
| *** jimjiang has joined #openstack-ironic | 11:58 | |
| *** jcooley_ has quit IRC | 12:01 | |
| *** jcooley_ has joined #openstack-ironic | 12:01 | |
| *** jimjiang has quit IRC | 12:03 | |
| *** rongze_ has quit IRC | 12:03 | |
| *** jimjiang has joined #openstack-ironic | 12:04 | |
| *** lucasagomes is now known as lucas-hungry | 12:05 | |
| *** jcooley_ has quit IRC | 12:05 | |
| *** jimjiang has quit IRC | 12:11 | |
| *** jcooley_ has joined #openstack-ironic | 12:11 | |
| *** jimjiang has joined #openstack-ironic | 12:12 | |
| *** jcooley_ has quit IRC | 12:15 | |
| *** jcooley_ has joined #openstack-ironic | 12:16 | |
| *** jcooley_ has quit IRC | 12:21 | |
| *** jcooley_ has joined #openstack-ironic | 12:21 | |
| *** martyntaylor has joined #openstack-ironic | 12:22 | |
| *** jcooley_ has quit IRC | 12:25 | |
| *** jcooley_ has joined #openstack-ironic | 12:26 | |
| *** jcooley_ has quit IRC | 12:30 | |
| *** jcooley_ has joined #openstack-ironic | 12:31 | |
| *** rongze has joined #openstack-ironic | 12:34 | |
| *** jcooley_ has quit IRC | 12:36 | |
| *** jcooley_ has joined #openstack-ironic | 12:37 | |
| *** jcooley_ has quit IRC | 12:37 | |
| *** jcooley_ has joined #openstack-ironic | 12:38 | |
| *** rongze has quit IRC | 12:42 | |
| *** jcooley_ has quit IRC | 12:42 | |
| *** jcooley_ has joined #openstack-ironic | 12:43 | |
| *** jcooley_ has quit IRC | 12:43 | |
| *** jcooley_ has joined #openstack-ironic | 12:49 | |
| *** yuriyz has joined #openstack-ironic | 12:51 | |
| *** nosnos has quit IRC | 12:51 | |
| *** jcooley_ has quit IRC | 12:54 | |
| *** jcooley_ has joined #openstack-ironic | 12:54 | |
| *** jimjiang has quit IRC | 12:59 | |
| *** jcooley_ has quit IRC | 12:59 | |
| *** jcooley_ has joined #openstack-ironic | 13:00 | |
| *** jimjiang has joined #openstack-ironic | 13:00 | |
| *** mdurnosvistov has joined #openstack-ironic | 13:04 | |
| *** jcooley_ has quit IRC | 13:04 | |
| *** jimjiang has quit IRC | 13:04 | |
| *** jcooley_ has joined #openstack-ironic | 13:04 | |
| *** jimjiang has joined #openstack-ironic | 13:05 | |
| *** jcooley_ has quit IRC | 13:09 | |
| *** jcooley_ has joined #openstack-ironic | 13:10 | |
| *** jimjiang has quit IRC | 13:11 | |
| *** jimjiang has joined #openstack-ironic | 13:12 | |
| *** jcooley_ has quit IRC | 13:14 | |
| *** jcooley_ has joined #openstack-ironic | 13:14 | |
| *** jimjiang has quit IRC | 13:17 | |
| *** rongze has joined #openstack-ironic | 13:18 | |
| *** jimjiang has joined #openstack-ironic | 13:19 | |
| *** jcooley_ has quit IRC | 13:19 | |
| *** jcooley_ has joined #openstack-ironic | 13:19 | |
| *** urulama has quit IRC | 13:20 | |
| *** jimjiang has quit IRC | 13:24 | |
| openstackgerrit | Alexei Kornienko proposed a change to openstack/ironic: Refactored access to RequestContext. https://review.openstack.org/62639 | 13:24 |
| *** jcooley_ has quit IRC | 13:24 | |
| *** jcooley_ has joined #openstack-ironic | 13:26 | |
| *** jcooley_ has quit IRC | 13:30 | |
| *** jimjiang has joined #openstack-ironic | 13:30 | |
| *** jcooley_ has joined #openstack-ironic | 13:32 | |
| *** jdob has joined #openstack-ironic | 13:35 | |
| *** jimjiang has quit IRC | 13:35 | |
| *** jimjiang has joined #openstack-ironic | 13:36 | |
| *** jcooley_ has quit IRC | 13:36 | |
| *** jcooley_ has joined #openstack-ironic | 13:37 | |
| *** martyntaylor has quit IRC | 13:38 | |
| *** rongze_ has joined #openstack-ironic | 13:39 | |
| *** jimjiang has quit IRC | 13:41 | |
| *** jimjiang has joined #openstack-ironic | 13:42 | |
| *** jcooley_ has quit IRC | 13:42 | |
| *** jcooley_ has joined #openstack-ironic | 13:43 | |
| *** rongze has quit IRC | 13:43 | |
| *** rongze_ has quit IRC | 13:48 | |
| *** jcooley_ has quit IRC | 13:48 | |
| *** jcooley_ has joined #openstack-ironic | 13:48 | |
| *** rongze has joined #openstack-ironic | 13:48 | |
| *** rongze_ has joined #openstack-ironic | 13:49 | |
| *** jimjiang has quit IRC | 13:49 | |
| openstackgerrit | Imre Farkas proposed a change to openstack/ironic: Passing nodes more consistently https://review.openstack.org/62389 | 13:50 |
| *** martyntaylor has joined #openstack-ironic | 13:50 | |
| *** jcooley_ has quit IRC | 13:52 | |
| *** rongze has quit IRC | 13:53 | |
| *** jcooley_ has joined #openstack-ironic | 13:54 | |
| *** jcooley_ has quit IRC | 13:54 | |
| *** itooon has quit IRC | 13:55 | |
| *** martyntaylor has quit IRC | 13:56 | |
| *** itooon has joined #openstack-ironic | 13:56 | |
| *** jcooley_ has joined #openstack-ironic | 13:56 | |
| *** rloo has joined #openstack-ironic | 13:56 | |
| *** jimjiang has joined #openstack-ironic | 13:57 | |
| openstackgerrit | Imre Farkas proposed a change to openstack/ironic: Passing nodes more consistently https://review.openstack.org/62389 | 13:57 |
| *** jcooley_ has quit IRC | 14:01 | |
| *** jimjiang has quit IRC | 14:01 | |
| *** jcooley_ has joined #openstack-ironic | 14:01 | |
| *** jimjiang has joined #openstack-ironic | 14:01 | |
| *** matty_dubs|gone is now known as matty_dubs | 14:03 | |
| *** martyntaylor has joined #openstack-ironic | 14:03 | |
| *** jdob has quit IRC | 14:04 | |
| *** jdob_ has joined #openstack-ironic | 14:04 | |
| openstackgerrit | Alexei Kornienko proposed a change to openstack/ironic: Refactored access to RequestContext https://review.openstack.org/62639 | 14:05 |
| *** jcooley_ has quit IRC | 14:06 | |
| *** jcooley_ has joined #openstack-ironic | 14:07 | |
| openstackgerrit | Imre Farkas proposed a change to openstack/ironic: Passing nodes more consistently https://review.openstack.org/62389 | 14:09 |
| openstackgerrit | Aleksandr Gordeev proposed a change to openstack/ironic: [PROOF OF CONCEPT] Integration testing https://review.openstack.org/62410 | 14:11 |
| *** jcooley_ has quit IRC | 14:12 | |
| *** jcooley_ has joined #openstack-ironic | 14:13 | |
| *** jimjiang has quit IRC | 14:16 | |
| *** jcooley_ has quit IRC | 14:17 | |
| *** jimjiang has joined #openstack-ironic | 14:17 | |
| *** jcooley_ has joined #openstack-ironic | 14:18 | |
| *** jcooley_ has quit IRC | 14:18 | |
| *** jdob_ has quit IRC | 14:18 | |
| *** jdob has joined #openstack-ironic | 14:18 | |
| *** jcooley_ has joined #openstack-ironic | 14:20 | |
| *** Alexei_987 has joined #openstack-ironic | 14:21 | |
| *** jimjiang has quit IRC | 14:22 | |
| *** jimjiang has joined #openstack-ironic | 14:23 | |
| *** jcooley_ has quit IRC | 14:24 | |
| *** jcooley_ has joined #openstack-ironic | 14:25 | |
| *** jimjiang has quit IRC | 14:27 | |
| *** jcooley_ has quit IRC | 14:29 | |
| *** n16483_ has quit IRC | 14:30 | |
| *** jcooley_ has joined #openstack-ironic | 14:30 | |
| *** n16483_ has joined #openstack-ironic | 14:30 | |
| *** jimjiang has joined #openstack-ironic | 14:33 | |
| *** jcooley_ has quit IRC | 14:34 | |
| *** jcooley_ has joined #openstack-ironic | 14:39 | |
| *** jcooley_ has quit IRC | 14:44 | |
| *** jcooley_ has joined #openstack-ironic | 14:45 | |
| *** jcooley_ has quit IRC | 14:49 | |
| *** jcooley_ has joined #openstack-ironic | 14:51 | |
| *** jcooley_ has quit IRC | 14:55 | |
| *** jcooley_ has joined #openstack-ironic | 14:55 | |
| *** jcooley_ has quit IRC | 15:00 | |
| *** jcooley_ has joined #openstack-ironic | 15:02 | |
| NobodyCam | Good Mornig Ironic | 15:11 |
| devananda | g'morning, all. g'morning ,NobodyCam :) | 15:13 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Move and rename ValidTypes https://review.openstack.org/62675 | 15:14 |
| GheRivero | morning all | 15:14 |
| lucas-hungry | NobodyCam, devananda morning :) | 15:14 |
| dkehn | morning | 15:18 |
| NobodyCam | morning devananda lucas-hungry and dkehn | 15:21 |
| *** urulama has joined #openstack-ironic | 15:21 | |
| NobodyCam | :) | 15:21 |
| *** lucas-hungry is now known as lucasagomes | 15:21 | |
| * lucasagomes forgot to change his name | 15:21 | |
| NobodyCam | :) | 15:21 |
| lucasagomes | NobodyCam, how r u? | 15:21 |
| * NobodyCam is just get up | 15:21 | |
| NobodyCam | doing good | 15:21 |
| NobodyCam | cann't quite see yet | 15:21 |
| NobodyCam | lol | 15:21 |
| lucasagomes | hah | 15:22 |
| NobodyCam | lucasagomes: did you see I pushed a new patch to the driver | 15:22 |
| lucasagomes | sounds like time to get ur first cup of joe :) | 15:22 |
| lucasagomes | NobodyCam, to the driver? | 15:22 |
| lucasagomes | ahh | 15:22 |
| NobodyCam | already started on it :) | 15:22 |
| lucasagomes | not the one I reviewed? | 15:23 |
| NobodyCam | let me check. not the one that was there yesterday | 15:23 |
| yuriyz | morning Ironic | 15:23 |
| lucasagomes | NobodyCam, ah yea, I saw it | 15:24 |
| NobodyCam | :) | 15:24 |
| lucasagomes | I reviewed the new one then | 15:24 |
| NobodyCam | see I'm just getting going here | 15:24 |
| NobodyCam | TY | 15:24 |
| lucasagomes | np :) | 15:24 |
| lucasagomes | NobodyCam, btw, good stuff with the driver :) | 15:24 |
| * NobodyCam takes his coffee and reads lucasagomes review | 15:25 | |
| NobodyCam | heheh I am only co-author :) | 15:25 |
| *** urulama has quit IRC | 15:25 | |
| lucasagomes | There's missing parts in the driver, like trigger the deployment but the patches didn't land in ironic yet (and I've to fix some of them) | 15:25 |
| lucasagomes | so I didn't put on the review | 15:25 |
| NobodyCam | lol so thats why my tests did work... lol | 15:26 |
| NobodyCam | 20import moch :-p | 15:26 |
| lucasagomes | NobodyCam, haha | 15:26 |
| lucasagomes | I was like, hmmmm never saw this lib b4 | 15:26 |
| lucasagomes | NobodyCam, validating the node interfaces already landed on ironic and cli, so I left a comment with a TODO there as well | 15:27 |
| NobodyCam | ya I'll get that in todayy | 15:27 |
| NobodyCam | Thank you for the review | 15:28 |
| NobodyCam | we'll get all that going today | 15:28 |
| lucasagomes | awesome :) | 15:29 |
| NobodyCam | haha lucasagomes saw the comment on the inconsistent log msg's .. those are just so I could see whats getting called when | 15:41 |
| NobodyCam | :-p | 15:41 |
| romcheg | Morning all | 15:41 |
| NobodyCam | morning romcheg | 15:42 |
| lucasagomes | NobodyCam, heh well, it might be easier to search for a specific message if they are consistent | 15:42 |
| NobodyCam | lol :) | 15:42 |
| NobodyCam | they be removed b4 it lands | 15:42 |
| lucasagomes | oh yea I can figure out hehe right now it's very verbose | 15:42 |
| lucasagomes | :P | 15:42 |
| lucasagomes | morning romcheg | 15:42 |
| NobodyCam | lol uslyI use here1 here2 type logs :-p | 15:43 |
| lucasagomes | hah | 15:45 |
| NobodyCam | dkehn: did you have a chance to come up with a est on send neutron data patch? | 15:48 |
| dkehn | NobodyCam: I knew you were going to ask that | 15:49 |
| NobodyCam | lol :-p | 15:49 |
| NobodyCam | hehhehe | 15:49 |
| dkehn | NobodyCam: quick call? | 15:49 |
| NobodyCam | really I'm not pushing | 15:49 |
| NobodyCam | sure ... | 15:49 |
| dkehn | NobodyCam: np, just want to make sure that I understand where this is going | 15:49 |
| NobodyCam | should we conf with devananda and or lucasagomes ? | 15:50 |
| NobodyCam | devananda: lucasagomes got a quick second? | 15:50 |
| lucasagomes | NobodyCam, sure | 15:50 |
| *** vkozhukalov has quit IRC | 15:51 | |
| *** martyntaylor has quit IRC | 16:14 | |
| *** jistr has quit IRC | 16:14 | |
| *** ifarkas has quit IRC | 16:25 | |
| devananda | lucasagomes: 57495 looks ready to land, yes? | 16:26 |
| lucasagomes | devananda, yes :) it was approved before but I had to rebase and fix the merge errors | 16:27 |
| devananda | yea | 16:27 |
| *** martyntaylor has joined #openstack-ironic | 16:27 | |
| devananda | done :) | 16:28 |
| lucasagomes | devananda, ta much! | 16:28 |
| devananda | lucasagomes: on 60299, this is going to break the client (state -> states) | 16:28 |
| lucasagomes | devananda, yea, should land with https://review.openstack.org/#/c/60558 | 16:29 |
| devananda | lucasagomes: i'm not sure we care yet, but i still feel the need to point it out :) | 16:29 |
| devananda | lucasagomes: along with a new rev to pypi | 16:29 |
| devananda | otherwise anyone instlling the client from pip won't get the fix | 16:30 |
| NobodyCam | can we push a new version to pypi? | 16:30 |
| *** jcooley_ has quit IRC | 16:30 | |
| lucasagomes | that makes sense | 16:30 |
| openstackgerrit | A change was merged to openstack/ironic: Reworks Node validations https://review.openstack.org/57495 | 16:31 |
| lucasagomes | after the ironic gets release we won't be able to change the API like that anymore | 16:31 |
| lucasagomes | we are going to have tempest tests running and all | 16:31 |
| devananda | lucasagomes: eg, we'd need to leave /state in the API but have it return a 301 redirect | 16:32 |
| devananda | or something like that | 16:33 |
| lucasagomes | devananda, yea that could be done | 16:33 |
| devananda | lucasagomes: you may want to un-WIP https://review.openstack.org/#/c/60558/2 now :) | 16:35 |
| lucasagomes | devananda, yay! done :) | 16:35 |
| openstackgerrit | A change was merged to openstack/ironic: Refactor /node/<uuid>/state https://review.openstack.org/60299 | 16:38 |
| *** martyntaylor has quit IRC | 16:43 | |
| *** hemna has joined #openstack-ironic | 16:45 | |
| NobodyCam | updates.. rebooting brb | 16:53 |
| *** rongze_ has quit IRC | 16:53 | |
| *** rongze has joined #openstack-ironic | 16:53 | |
| devananda | agordeev: ping | 16:54 |
| openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Add RPC method for node maintenance mode https://review.openstack.org/62711 | 16:57 |
| devananda | yuriyz: ping | 17:02 |
| yuriyz | here | 17:02 |
| devananda | yuriyz: hi! about maintenance mode, have a few minutes to talk? | 17:03 |
| yuriyz | yes | 17:03 |
| devananda | yuriyz: i believe the admin/operator must be able to set maintenance mode regardless of what else is going on with the node | 17:03 |
| *** romcheg has quit IRC | 17:03 | |
| devananda | yuriyz: eg, if a node deploy is in progress and taking a very long time, admin should be able to set maintenance mode w/o interrupting the ongoing deploy. | 17:04 |
| devananda | yuriyz: what do you think? | 17:04 |
| yuriyz | maybe need abort current deploy first? | 17:04 |
| yuriyz | Im not sure | 17:05 |
| devananda | yuriyz: what if another deploy is started before operator is able to set maintenance mode? | 17:05 |
| NobodyCam | and back | 17:06 |
| yuriyz | but node state undefined in this case | 17:06 |
| devananda | yuriyz: how so? | 17:07 |
| yuriyz | maybe we need clear *states before maintenance? | 17:07 |
| devananda | yuriyz: clear states => abort any in-progress operations | 17:08 |
| devananda | yuriyz: perhaps there is another way | 17:09 |
| yuriyz | but if node is in ACTIVE state, should returns to this state after maintenance | 17:10 |
| NobodyCam | post breakfast walkies...brb | 17:11 |
| devananda | yuriyz: I just started https://etherpad.openstack.org/p/IronicMaintenanceMode to sketch some ideas | 17:12 |
| yuriyz | devananda, I will think about this, please comments if you have some ideas | 17:13 |
| devananda | yuriyz: what if maintenance wasn't a state? | 17:13 |
| yuriyz | maybe, but new column for nodes table IMO needs in this case | 17:14 |
| devananda | yuriyz: right | 17:16 |
| *** max_lobur is now known as max_lobur_afk | 17:19 | |
| *** martyntaylor has joined #openstack-ironic | 17:20 | |
| *** urulama has joined #openstack-ironic | 17:22 | |
| *** matty_dubs is now known as matty_dubs|lunch | 17:26 | |
| *** urulama has quit IRC | 17:26 | |
| devananda | yuriyz: any thoughts? | 17:27 |
| devananda | yuriyz: i see two patterns emerging from the different scenarios | 17:27 |
| yuriyz | devananda, one question about broken state of a node, can we define this? | 17:34 |
| *** martyntaylor has quit IRC | 17:37 | |
| *** rongze has quit IRC | 17:39 | |
| *** rongze has joined #openstack-ironic | 17:40 | |
| *** jcooley_ has joined #openstack-ironic | 17:43 | |
| devananda | yuriyz: not really. i thought it might matter but as i went through this, i don't think it does | 17:44 |
| *** hemna has quit IRC | 17:44 | |
| devananda | yuriyz: by "broken" i mean, eg, a HDD died and so provisioning just fails | 17:44 |
| *** vkozhukalov has joined #openstack-ironic | 17:44 | |
| *** hemna has joined #openstack-ironic | 17:44 | |
| NobodyCam | lucasagomes: got a second? | 17:48 |
| lucasagomes | NobodyCam, hey sure | 17:48 |
| NobodyCam | http://paste.openstack.org/show/K1rPbTmSMV5i5x92wiEM/ | 17:48 |
| NobodyCam | note no chassis id when adding a node | 17:48 |
| lucasagomes | NobodyCam, uhn, lemme see | 17:49 |
| *** ndipanov has quit IRC | 17:51 | |
| *** jcooley_ has quit IRC | 17:51 | |
| *** jcooley_ has joined #openstack-ironic | 17:51 | |
| lucasagomes | NobodyCam, I think ur using an old version of ironic, chassis_uuid got merged minutes ago | 17:51 |
| lucasagomes | also I can note that driver = None | 17:52 |
| *** mdurnosvistov has quit IRC | 17:52 | |
| lucasagomes | that patch also fixes it, driver is mandatory when creating a node | 17:52 |
| NobodyCam | yea image was built yesterday | 17:52 |
| lucasagomes | the chassis_uuid in the client landed before the one in the API | 17:52 |
| NobodyCam | ahh ok. I will rebuild | 17:53 |
| lucasagomes | cause the API was approved but, failed to merge | 17:53 |
| lucasagomes | :( | 17:53 |
| NobodyCam | :-P would be nice to have cross project deps | 17:53 |
| NobodyCam | for reviews | 17:53 |
| *** rongze has quit IRC | 17:53 | |
| *** rongze has joined #openstack-ironic | 17:54 | |
| * NobodyCam starts rebuilding | 17:54 | |
| lucasagomes | NobodyCam, yea | 17:54 |
| lucasagomes | NobodyCam, the trunk seems correct: http://paste.openstack.org/show/55181/ | 17:55 |
| *** jcooley_ has quit IRC | 17:56 | |
| NobodyCam | :) | 17:56 |
| * lucasagomes rembers that he needs to rebase a patch to valid the drivers | 17:58 | |
| *** derekh has quit IRC | 17:58 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: API: Validate driver when creating/updating a node https://review.openstack.org/61960 | 18:00 |
| *** jcooley_ has joined #openstack-ironic | 18:08 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Add trigger to start provisioning the node https://review.openstack.org/61160 | 18:08 |
| NobodyCam | lucasagomes: looking at the tests on 61960 is invalid_driver also a "vaild driver" is may not loaded on the current conductor? | 18:09 |
| NobodyCam | ie pxe is a valid driver but conductor only loads iboot | 18:10 |
| lucasagomes | NobodyCam, right... by valid we mean that the driver should also be loaded in one active conductor | 18:11 |
| lucasagomes | otherwise creating a node with a pxe driver where there's no active conductor that supports that driver will make the node incapable to be provisioned | 18:12 |
| lucasagomes | NobodyCam, to complement: https://blueprints.launchpad.net/ironic/+spec/node-out-of-service (wrote it today, might need some more info) | 18:13 |
| *** jcooley_ has quit IRC | 18:13 | |
| devananda | lucasagomes: question on https://review.openstack.org/#/c/55549/13/ironic/api/controllers/v1/node.py | 18:13 |
| * NobodyCam looks | 18:14 | |
| lucasagomes | devananda, sure, lemme open | 18:14 |
| NobodyCam | lucasagomes: ++ | 18:14 |
| devananda | lucasagomes: wouldn't it be possible to check if patch contains a 'reservation' attr before calling jsonpatch.apply_patch? | 18:15 |
| lucasagomes | devananda, you could, you could even extend the validate method of the NodePatch class to check for it | 18:16 |
| devananda | lucasagomes: the same question applies to 61960, too | 18:16 |
| devananda | lucasagomes: instead of putting "if field == 'driver'" inside the for loop, couldn't that be done earlier, eg: if 'driver' in patch: | 18:18 |
| *** rongze has quit IRC | 18:18 | |
| lucasagomes | devananda, right, that would be possible I just make a method because I also needs to check for the driver on the post method | 18:18 |
| devananda | lucasagomes: certainly. the _ensure_driver_is_supported() method is fine. I'm just referring to the order of things in the NodeController.patch() method | 18:19 |
| devananda | it looks like both your patch and yuriyz' could check for the presence of the change-in-question on the actual NodePatchType object now, instead of creating an RPC object from it, and then checking that | 18:20 |
| devananda | but IMBW .... | 18:20 |
| lucasagomes | devananda, right, the problem of checking in the NodePatch in my case is that I would need access to the db | 18:21 |
| lucasagomes | to get the list of supported drivers | 18:21 |
| *** harlowja_away is now known as harlowja | 18:22 | |
| lucasagomes | maybe I would have it (pecan.request.dbapi), will try it out | 18:23 |
| devananda | lucasagomes: hmm. i dont mean, add it to NodePatchType.validate() | 18:25 |
| devananda | though that is interesting, I don't think it's the right place | 18:26 |
| devananda | i was thinking more along the lines of yuriyz' patch doing something like this | 18:26 |
| devananda | if 'reservation' in [op for op in patch]: ... | 18:27 |
| lucasagomes | devananda, right, so yea you could as well, patch will be a list of dictonaries | 18:27 |
| lucasagomes | you can just iteract on it | 18:27 |
| devananda | right | 18:27 |
| lucasagomes | see if there's any p['path'] == '/driver' and get the value | 18:28 |
| devananda | so interacting with a list of dicts is kinda annoying, unless we write helper methods (like nova did) | 18:28 |
| devananda | right | 18:28 |
| devananda | er, yea, i meant 'path' not 'op' :) | 18:28 |
| *** romcheg has joined #openstack-ironic | 18:28 | |
| *** blamar has quit IRC | 18:29 | |
| *** matty_dubs|lunch is now known as matty_dubs | 18:29 | |
| lucasagomes | devananda, will check the nova methods | 18:29 |
| devananda | lucasagomes: cool. so it's possible, but not going to be all that much cleaner right now. thanks! | 18:29 |
| lucasagomes | but yea it's totally possible to do that before | 18:30 |
| devananda | lucasagomes: don't worry about it now. something to refactor later, perhaps | 18:30 |
| lucasagomes | devananda, right :) makes sense | 18:30 |
| devananda | lucasagomes: FYI - http://git.openstack.org/cgit/openstack/nova/tree/nova/utils.py#n873 | 18:31 |
| * lucasagomes clicks | 18:31 | |
| lucasagomes | yea having some helping functions can be useful, we already have 2 cases where we would need it | 18:33 |
| *** vkozhukalov has quit IRC | 18:36 | |
| lucasagomes | devananda, I saw you talking to yuriyz about the putting the node maintenance | 18:37 |
| devananda | lucasagomes: yep | 18:37 |
| devananda | lucasagomes: see the etherpad i started? | 18:37 |
| lucasagomes | devananda, put on my todo list will take a look at it later | 18:37 |
| *** vkozhukalov has joined #openstack-ironic | 18:37 | |
| *** ifarkas has joined #openstack-ironic | 18:37 | |
| lucasagomes | devananda, we might also need another field in db to be used as flag for other things in the node | 18:38 |
| lucasagomes | for e.g some node deployments can't be aborted, we need a flag to indicate that | 18:38 |
| lucasagomes | which is not a state | 18:38 |
| devananda | right | 18:39 |
| lucasagomes | or to mark the node as out-of-service (re https://blueprints.launchpad.net/ironic/+spec/node-out-of-service) | 18:39 |
| devananda | ^ is maintenance mode, no? | 18:39 |
| NobodyCam | lucasagomes: database field for propitery of the driver? | 18:39 |
| *** blamar has joined #openstack-ironic | 18:39 | |
| lucasagomes | devananda, sounds like, maybe | 18:39 |
| lucasagomes | by out-of-service I mean | 18:40 |
| NobodyCam | s/for/or | 18:40 |
| devananda | NobodyCam: I think this is more a node-meta-state thing | 18:40 |
| devananda | we have the particular states [target|actual]_[power|provision|other|foo]_state | 18:40 |
| lucasagomes | a node which contains a valid driver, but all the conductors that hold that driver went offline | 18:40 |
| NobodyCam | I see it a default prop of the driver. ie iboot can never be aborted type thing | 18:40 |
| lucasagomes | that would be a node out-of-service (in that bp scope) | 18:41 |
| NobodyCam | not per node | 18:41 |
| devananda | and we have another type of state, eg, maintenance Y/N, interruptible Y/N | 18:41 |
| lucasagomes | NobodyCam, yea metadata could be used as well | 18:41 |
| devananda | NobodyCam: some operaetiosn may be interruptible and others not | 18:41 |
| lucasagomes | NobodyCam, problem is that metadata could also be patched | 18:41 |
| NobodyCam | for other then deploy | 18:42 |
| NobodyCam | i saw 10:38 | lucasagomes > devananda, we might also need another field in db to be used as flag for other things in the node | 18:42 |
| NobodyCam | 10:38 | lucasagomes > for e.g some node deployments can't be aborted, we need a flag to indicate that | 18:42 |
| lucasagomes | NobodyCam, yup, now you mentioned the metadata and I think it suits. but what I'm afraid by using metadata is that it can be patched | 18:43 |
| *** jistr has joined #openstack-ironic | 18:44 | |
| lucasagomes | so a bad user could replace/remove our flag (we could add checks for that as well) | 18:44 |
| lucasagomes | it's FFT :) | 18:44 |
| devananda | lucasagomes: well, user/admin/operator must be able to set maintenance mode, too | 18:44 |
| NobodyCam | :) | 18:44 |
| *** jcooley_ has joined #openstack-ironic | 18:44 | |
| *** jcooley_ has quit IRC | 18:44 | |
| lucasagomes | devananda, oh yea def | 18:45 |
| *** jcooley_ has joined #openstack-ironic | 18:45 | |
| *** jcooley_ has quit IRC | 18:46 | |
| *** jcooley_ has joined #openstack-ironic | 18:46 | |
| lucasagomes | alright I'm done for the day | 18:50 |
| lucasagomes | have a g'night everyone! | 18:50 |
| devananda | lucasagomes: g'night! | 18:50 |
| lucasagomes | devananda, NobodyCam g'night :) | 18:50 |
| *** jcooley_ has quit IRC | 18:50 | |
| NobodyCam | night lucasagomes | 18:50 |
| *** jcooley_ has joined #openstack-ironic | 18:51 | |
| *** lucasagomes has quit IRC | 18:51 | |
| * devananda rebuilds his env | 18:53 | |
| *** docaedo has quit IRC | 18:53 | |
| *** prekarat has quit IRC | 18:53 | |
| NobodyCam | devananda: be sure to update tripleo-image-elements/elements/nova-ironic/install.d/89-nova-ironic-services to pull the latest patch | 18:55 |
| *** jcooley_ has quit IRC | 18:55 | |
| devananda | NobodyCam: i typically build master, then ssh in and 'git review -d' what i want | 18:56 |
| devananda | NobodyCam: were you and lucas discussing an objection to 61960? I think it's fine ... | 18:56 |
| NobodyCam | ??? I was asking about the tests on it | 18:57 |
| devananda | ah | 18:59 |
| *** Alexei_987 has quit IRC | 18:59 | |
| *** romcheg has quit IRC | 19:01 | |
| *** jcooley_ has joined #openstack-ironic | 19:04 | |
| *** jcooley_ has quit IRC | 19:08 | |
| *** rongze has joined #openstack-ironic | 19:13 | |
| *** rongze has quit IRC | 19:18 | |
| * NobodyCam makes a bagel | 19:20 | |
| *** urulama has joined #openstack-ironic | 19:23 | |
| *** jcooley_ has joined #openstack-ironic | 19:23 | |
| *** jcooley_ has quit IRC | 19:25 | |
| *** urulama has quit IRC | 19:27 | |
| openstackgerrit | Ruby Loo proposed a change to openstack/ironic: Add 'next' link when GET maximum number of items https://review.openstack.org/62743 | 19:27 |
| *** jcooley_ has joined #openstack-ironic | 19:28 | |
| *** harlowja is now known as harlowja_away | 19:30 | |
| devananda | NobodyCam: ever seen your seed vm come up but neutron give 403 errors? | 19:31 |
| *** jcooley_ has quit IRC | 19:31 | |
| *** jcooley_ has joined #openstack-ironic | 19:31 | |
| *** romcheg has joined #openstack-ironic | 19:31 | |
| NobodyCam | humm I have odd network errors | 19:31 |
| NobodyCam | I just run clenup-env and setup-network | 19:31 |
| NobodyCam | and relaunch everything | 19:32 |
| devananda | k | 19:32 |
| NobodyCam | seemd to clear themup for me | 19:32 |
| devananda | i did everything but setup-network | 19:32 |
| NobodyCam | :) | 19:32 |
| NobodyCam | that could do it | 19:32 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Improve method to get list of active conductors https://review.openstack.org/59795 | 19:36 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Improve method to get list of active conductors https://review.openstack.org/59795 | 19:36 |
| NobodyCam | devananda: on line 339 of ironic/db/api.py | 19:39 |
| devananda | ? | 19:39 |
| NobodyCam | why not def get_active_driver_dict(self, interval=CONF.conductor.heartbeat_timeout): and eleminate the need to pass default with each call | 19:40 |
| devananda | NobodyCam: that would be put in db/sqla/api.py, but, its a fair point | 19:40 |
| NobodyCam | :) | 19:41 |
| *** epim has joined #openstack-ironic | 19:41 | |
| NobodyCam | everytime I see that we are passing around a deafult value | 19:41 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Improve method to get list of active conductors https://review.openstack.org/59795 | 19:49 |
| devananda | NobodyCam: ^ :) | 19:49 |
| *** jimjiang has quit IRC | 19:50 | |
| * NobodyCam clicks | 19:50 | |
| *** jimjiang has joined #openstack-ironic | 19:51 | |
| *** jcooley_ has quit IRC | 19:51 | |
| *** jcooley_ has joined #openstack-ironic | 19:51 | |
| NobodyCam | devananda: reads much easier... at least for my eyes | 19:52 |
| devananda | NobodyCam: so. I just rebuild seed completely, including resetting local nets | 19:52 |
| devananda | NobodyCam: and same problem | 19:52 |
| devananda | $ neutron net-list | 19:52 |
| devananda | Connection to neutron failed: (403, 'Forbidden') | 19:52 |
| NobodyCam | humm... | 19:52 |
| devananda | however 'nova list' works fine, and if i ssh into seed, then it works fine | 19:52 |
| NobodyCam | maybe dkehn | 19:53 |
| NobodyCam | strange | 19:53 |
| *** epim has quit IRC | 19:55 | |
| *** jimjiang has quit IRC | 19:56 | |
| *** jcooley_ has quit IRC | 19:56 | |
| * NobodyCam wanders afk for a few min | 19:56 | |
| *** jimjiang has joined #openstack-ironic | 19:57 | |
| devananda | NobodyCam: it's $no_proxy -- i hadn't set that properly | 19:58 |
| *** jcooley_ has joined #openstack-ironic | 19:59 | |
| *** jcooley_ has quit IRC | 20:00 | |
| *** jimjiang has quit IRC | 20:03 | |
| *** ifarkas has quit IRC | 20:05 | |
| *** jimjiang has joined #openstack-ironic | 20:09 | |
| NobodyCam | Ahh | 20:10 |
| *** vkozhukalov has quit IRC | 20:11 | |
| *** harlowja_away is now known as harlowja | 20:14 | |
| *** mtaylor is now known as mordred | 20:20 | |
| NobodyCam | morning / afternoon mordred | 20:31 |
| NobodyCam | :) | 20:31 |
| *** epim has joined #openstack-ironic | 20:31 | |
| jdob | can anyone point me towards an example of using a POST call to create a Node? I'm looking at http://docs.openstack.org/developer/ironic/webapi/v1.html but it says that POST takes a Node in the request body and I'm having trouble resolving which of that data I need to pass in v. those that are just returned on a GET | 20:35 |
| NobodyCam | jdob: not using the client? | 20:35 |
| NobodyCam | echo '{"driver": "fake", "chassis_id": "1", "extra": {"foo": "bar", "baz": "kazoo", "number": "1"} }' > fake-node-spec | 20:36 |
| NobodyCam | curl -X POST -H 'Content-Type:application/json' --data @fake-node-spec http://localhost:6385/v1/nodes | 20:36 |
| jdob | not exactly. the larger context of my question is for tuskar -> ironic, but i'm asking in terms of REST since that's just where my head when to try to understand what the APIs looked like | 20:36 |
| jdob | i figured the best docs to understand what's handed on a node create, short of reading client code, would be the REST APIs | 20:36 |
| jdob | any other suggestions? | 20:37 |
| *** hstimer has joined #openstack-ironic | 20:38 | |
| devananda | jdob: REST API spec online should be accurate | 20:41 |
| devananda | jdob: as far as what is required / not required in the POST, you're right -- that's not well documented right now | 20:41 |
| devananda | jdob: IIRC, it is just driver + chassis_id | 20:42 |
| jdob | gotcha, it was very possible i was just reading it wrong which is why I asked :) | 20:42 |
| devananda | jdob: however taht's not enough to actually /do/ anything ... | 20:42 |
| *** epim has quit IRC | 20:42 | |
| jdob | what about ipmi credentials? are they not specified on the node? | 20:43 |
| devananda | in addition to teh chassis_id and what driver to load, ironic needs to pass some info to that driver | 20:43 |
| devananda | so you'll need to supply driver_info | 20:43 |
| devananda | that varies per driver | 20:43 |
| * jdob is hugely naive to this stuff, so apologies now for dumb questions | 20:43 | |
| devananda | and the list of what info each driver needs is not exposed in teh API yet.... | 20:43 |
| * devananda files a bug | 20:43 | |
| jdob | gotcha. still, very helpful to know where it'll go, thanks for the heads up | 20:44 |
| jdob | so driver is passed in the POST, thats just a string/ID of the driver, then those details would be in driver_info? | 20:44 |
| devananda | yes | 20:46 |
| devananda | send in subsequent PATCH requests | 20:46 |
| devananda | you can bundle >1 PATCH into a single request | 20:46 |
| jdob | that's the "op" : "add" syntax? | 20:46 |
| devananda | https://bugs.launchpad.net/ironic/+bug/1261915 | 20:47 |
| devananda | jdob: yea | 20:47 |
| jdob | i'd never seen that before this project, it's a pretty elegant approach | 20:47 |
| devananda | :) | 20:47 |
| jdob | ah cool, thanks for filing the bug :) | 20:47 |
| jdob | process question: the "marks as affecting you", is that used for anything other than flagging me for emails? | 20:48 |
| devananda | jdob: to a small degree, it'll effect bug prioritization | 20:48 |
| jdob | do you use that in triage? and/or does that trip any sort of automatic alarms that things are critical? | 20:48 |
| jdob | gotcha | 20:48 |
| devananda | for new bugs, yes, seeing Affects N ppl will get my attention faster when N != 1 | 20:49 |
| *** epim has joined #openstack-ironic | 20:49 | |
| devananda | it also raises the priority of a review which claims to fix the bug on http://status.openstack.org/reviews/ | 20:49 |
| jdob | since I have you, another question. what about removing a node? I don't see any DELETE APIs | 20:50 |
| devananda | ah | 20:50 |
| devananda | odd | 20:50 |
| * jdob really needs to look at the client code before pestering people with so many questions | 20:50 | |
| *** itooon has quit IRC | 20:50 | |
| devananda | i wonder if that's a bug in the sphninx extension | 20:51 |
| devananda | jdob: delete is in our API and totally supported AFAIK | 20:51 |
| devananda | i dont know why it's not showing up in the doc | 20:51 |
| jdob | cool, sounds good to me | 20:52 |
| devananda | jdob: as far as what driver_info/XXXX data to pass, you need to look in ironic/drivers/modules/XXX.py for that today | 20:52 |
| devananda | sorry for that. i'd love if it were doc'd somewhere :) | 20:52 |
| jdob | actually, i'm super happy you were able to point me at the .py files. that saved a ton of time as it was | 20:53 |
| *** itooon has joined #openstack-ironic | 20:53 | |
| jdob | i also spent the last two years on a project that was perpetually on its heels when it came to docs and often had to point people towards in code comments, so i'm highly forgiving of those situations :D | 20:53 |
| NobodyCam | delete is there. https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/node.py#L513 | 20:54 |
| devananda | NobodyCam: not in the docs, tho | 20:55 |
| devananda | i just filed https://bugs.launchpad.net/ironic/+bug/1261917 | 20:55 |
| jdob | holy crap, I see what you mean by bug in the sphinx extension, there's nothing in the .rst files themselves | 20:55 |
| jdob | you guys write these extensions yourselves or is this a third party extension? | 20:55 |
| devananda | dhellman wrote it, i beleive | 20:56 |
| jdob | slick | 20:56 |
| jdob | ok, last question and I'll leave you alone, but this has been driving me crazy for a while now | 20:56 |
| jdob | i'm in node.py | 20:57 |
| jdob | I see i18n translated stuff with _ | 20:57 |
| * devananda just filed https://github.com/dreamhost/sphinxcontrib-pecanwsme/issues/10 too | 20:57 | |
| NobodyCam | http://docs.openstack.org/developer/ironic/api/ironic.api.controllers.v1.node.html?highlight=delete#ironic.api.controllers.v1.node.NodesController.delete | 20:57 |
| jdob | but I can't see where _ is actually defined anywhere | 20:57 |
| devananda | jdob: standard magic | 20:57 |
| jdob | normally I see that as a renamed import of something like gettext | 20:57 |
| devananda | jdob: yes. it is. but it's done in only a few places, not in each module | 20:57 |
| devananda | jdob: look at ironic/cmd/__init__.py | 20:59 |
| jdob | doesn't that drive the IDE users insane? | 20:59 |
| devananda | IDE? what's that? | 20:59 |
| devananda | :p | 20:59 |
| jdob | well, that answers that question :D | 20:59 |
| NobodyCam | its a old hard disk controler | 20:59 |
| NobodyCam | :-p | 20:59 |
| devananda | :) | 20:59 |
| jdob | ahhhhhhhh.... """Install a _() function using the given translation domain. | 21:00 |
| jdob | ok, that at least answers it, thanks | 21:01 |
| * jdob goes to find some other IDE users to console me | 21:02 | |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Implement consistent hashing of nodes to conductors https://review.openstack.org/58895 | 21:02 |
| *** epim has quit IRC | 21:02 | |
| NobodyCam | :) | 21:02 |
| *** jistr has quit IRC | 21:02 | |
| *** jimjiang has quit IRC | 21:11 | |
| *** jimjiang has joined #openstack-ironic | 21:12 | |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: GET /drivers to show a list of active conductors https://review.openstack.org/60216 | 21:15 |
| *** jimjiang has quit IRC | 21:17 | |
| *** jimjiang has joined #openstack-ironic | 21:18 | |
| NobodyCam | quick walkies... brb | 21:21 |
| *** jimjiang has quit IRC | 21:23 | |
| *** jimjiang has joined #openstack-ironic | 21:23 | |
| *** urulama has joined #openstack-ironic | 21:24 | |
| *** urulama has quit IRC | 21:28 | |
| *** jimjiang has quit IRC | 21:29 | |
| *** jimjiang has joined #openstack-ironic | 21:30 | |
| *** glpupo has joined #openstack-ironic | 21:32 | |
| rloo | devananda: https://review.openstack.org/#/c/59795/14/ironic/tests/db/test_conductor.py | 21:33 |
| rloo | devananda: i'm assuming you really want it to be 2 minutes, not 2 hours? | 21:33 |
| devananda | rloo: yes i switched it. hopefully it is easier to read / reason about now? | 21:34 |
| rloo | 2 minutes, 2 hours, sure :-). Although two_minutes is better than two_minute but that's fine. | 21:34 |
| devananda | heh. one_minute, two_minute, red_minute, blue_minute .... | 21:34 |
| rloo | dr. zeussdeva | 21:35 |
| *** jimjiang has quit IRC | 21:35 | |
| *** jimjiang has joined #openstack-ironic | 21:36 | |
| *** briancline has quit IRC | 21:39 | |
| *** glpupo has quit IRC | 21:46 | |
| *** briancline has joined #openstack-ironic | 21:52 | |
| *** greghaynes has joined #openstack-ironic | 21:56 | |
| NobodyCam | devananda: do I need to don anything for sync_power_state periodic task (https://review.openstack.org/#/c/56530/) to work? | 22:03 |
| devananda | NobodyCam: don't think so | 22:04 |
| NobodyCam | humm ok | 22:05 |
| * devananda tests it locally | 22:05 | |
| devananda | had ironic turn on a node, to be sure it can | 22:05 |
| devananda | then manually powered if off | 22:05 |
| devananda | and ... after ~30 econds, it shows up in the state | 22:06 |
| devananda | so, yep, it works | 22:06 |
| NobodyCam | ok. something with fake driver | 22:06 |
| devananda | (ironic.conductor.manager): 2013-12-17 22:05:51,579 WARNING During sync_power_state, node 2bf254a2-19ff-412c-a103-c3b1ee236dc3 out of sync. Expected: power on. Actual: power off. Updating DB. | 22:06 |
| devananda | NobodyCam: oh! I'm using pxe_ssh driver. are you using fake_ssh? or just fake? | 22:06 |
| NobodyCam | http://paste.openstack.org/show/SqPRIsl48achkGgQl1nI/ | 22:07 |
| NobodyCam | just fake | 22:07 |
| devananda | right. so what's the problem? | 22:08 |
| NobodyCam | power_state | None | 22:08 |
| devananda | uh huh | 22:08 |
| NobodyCam | not a valid state for nova | 22:08 |
| devananda | but it's the fake driver | 22:08 |
| devananda | 32 def get_power_state(self, task, node): | 22:09 |
| devananda | 33 return node.get('power_state', states.NOSTATE) | 22:09 |
| devananda | if you want there to be a non-NULL state, you need to set it :) | 22:09 |
| NobodyCam | so with line 276 of https://review.openstack.org/#/c/51328/7/nova/virt/ironic/driver.py | 22:10 |
| *** jdob has quit IRC | 22:11 | |
| NobodyCam | we will need to curl a power state for any nodes with fake power driver | 22:11 |
| NobodyCam | I can do it ... | 22:11 |
| devananda | NobodyCam: not sure I follow | 22:11 |
| NobodyCam | to test nova we will need to manualy set any node with fake power driver | 22:12 |
| devananda | well, it's fake, so sure, you need to fake the power state too. | 22:12 |
| devananda | but outside of testing, i dont think that's an issue | 22:13 |
| NobodyCam | prob :) | 22:13 |
| devananda | like in my local env, power state comes up w/in a minute of me putting some info into the driver | 22:13 |
| devananda | often with an error state, LOL | 22:13 |
| NobodyCam | :) with ssh driver :) | 22:14 |
| devananda | eg, cause i forgot to set the right ssh credentials .... yea | 22:14 |
| NobodyCam | sweet | 22:14 |
| * devananda wanders off for food | 22:14 | |
| NobodyCam | :) | 22:14 |
| devananda | NobodyCam: client's ability to set power/provision state is broken until https://review.openstack.org/#/c/60558/ lands | 22:28 |
| NobodyCam | lol ofc https://review.openstack.org/#/c/60558 | 22:28 |
| NobodyCam | This change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset. | 22:28 |
| *** jimjiang has quit IRC | 22:28 | |
| devananda | hah! | 22:28 |
| NobodyCam | :-p | 22:28 |
| NobodyCam | I tried to fix that | 22:29 |
| * devananda fixes | 22:29 | |
| *** jimjiang has joined #openstack-ironic | 22:29 | |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/python-ironicclient: Rename nodes/<uuid>/state to nodes/<uuid>/states https://review.openstack.org/60558 | 22:31 |
| devananda | i'll +2/a once it passes | 22:31 |
| NobodyCam | :) awesomeness | 22:32 |
| devananda | and then kick off another pypi release | 22:32 |
| NobodyCam | does that mean we have to add the pinning to requirments? | 22:32 |
| devananda | not particularly | 22:32 |
| NobodyCam | :) | 22:32 |
| devananda | well | 22:33 |
| devananda | in the nova-ironic driver, yea... | 22:33 |
| NobodyCam | state is a breaking change | 22:33 |
| devananda | yea | 22:33 |
| NobodyCam | so for the nova/requirments.txt I'll add >=new ver | 22:33 |
| devananda | right | 22:34 |
| NobodyCam | :) | 22:34 |
| NobodyCam | 0.0.2? | 22:34 |
| NobodyCam | 0.1.0 | 22:34 |
| devananda | 0.1.0 seems reasonable. we may have a fe more bumps before we get deploy done anyway | 22:35 |
| devananda | so holding off another release for that is not helpful, IMO | 22:35 |
| NobodyCam | :) | 22:36 |
| NobodyCam | devananda: whats avg pypi rollout time? | 22:42 |
| devananda | dunno | 22:42 |
| NobodyCam | :) | 22:43 |
| openstackgerrit | A change was merged to openstack/python-ironicclient: Rename nodes/<uuid>/state to nodes/<uuid>/states https://review.openstack.org/60558 | 22:43 |
| NobodyCam | i guess the real question needs to be how long until nova gate see's it | 22:44 |
| devananda | NobodyCam: well, nova gate will still error on the requirements change -- that's not in global-req yet | 22:44 |
| * NobodyCam rebuilds | 22:44 | |
| NobodyCam | ahh yes | 22:44 |
| devananda | should be easy to push these bits into your local build env w/o a full rebuild... | 22:44 |
| openstackgerrit | A change was merged to openstack/python-ironicclient: Remove unused oslo-incubator modules https://review.openstack.org/62165 | 22:45 |
| NobodyCam | lol getting more +1's https://review.openstack.org/#/c/60638/ | 22:45 |
| devananda | ehehe | 22:48 |
| devananda | that's a lot of +1's | 22:48 |
| NobodyCam | and one +2 :-p | 22:48 |
| *** matty_dubs is now known as matty_dubs|gone | 22:54 | |
| *** jimjiang has quit IRC | 23:00 | |
| *** jimjiang has joined #openstack-ironic | 23:01 | |
| *** harlowja is now known as harlowja_away | 23:02 | |
| devananda | pushed 0.1.0. just waiting on zuul now... | 23:02 |
| devananda | https://github.com/openstack/python-ironicclient/releases/tag/0.1.0 | 23:02 |
| NobodyCam | :) | 23:04 |
| *** harlowja_away is now known as harlowja | 23:05 | |
| devananda | oddness | 23:13 |
| devananda | it's gone from http://pypi.openstack.org/openstack/ | 23:13 |
| NobodyCam | humm | 23:14 |
| lifeless | devananda: hey | 23:14 |
| lifeless | devananda: question for you on oslo config semantics | 23:15 |
| lifeless | devananda: in https://review.openstack.org/#/c/59795/11..14/ironic/db/sqlalchemy/api.py | 23:15 |
| devananda | shoot | 23:15 |
| lifeless | devananda: will the config value be known at *import* time ? | 23:15 |
| * NobodyCam steps afk for a bit... | 23:15 | |
| lifeless | devananda: and, is there any 'reconfigure' API where the config value might change without us exiting the process and starting a new process ? | 23:15 |
| dkehn | NobodyCam: u around | 23:17 |
| devananda | lifeless: ahhh. good questions... | 23:18 |
| lifeless | devananda: dats what revu is all about :) | 23:18 |
| devananda | lifeless: i vaguely recall a related discussion about a conf option in nova's db/sqla code affecting eventlet | 23:18 |
| lifeless | devananda: I bet you can see where I'm going with this too | 23:18 |
| devananda | yea | 23:19 |
| devananda | lifeless: as far as reconfig API, i haven't seen anything like that anywhere in openstack yet | 23:19 |
| devananda | lifeless: but the conf-at-import-time issue .... hrmm... | 23:19 |
| lifeless | if the config value isn't known at import time, you'll get None or a default or whatever | 23:19 |
| lifeless | and it won't ever be read again | 23:19 |
| devananda | right | 23:20 |
| * devananda tests it | 23:22 | |
| *** urulama has joined #openstack-ironic | 23:24 | |
| *** urulama has quit IRC | 23:29 | |
| *** romcheg has quit IRC | 23:41 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!