Thursday, 2014-01-02

« Wednesday, 2014-01-01 Index Friday, 2014-01-03 »
*** jcooley_ has joined #openstack-ironic00:13
*** jcooley_ has quit IRC00:19
*** rongze has joined #openstack-ironic00:42
*** rongze has quit IRC00:46
*** jcooley_ has joined #openstack-ironic01:00
*** jcooley_ has quit IRC01:06
*** jcooley_ has joined #openstack-ironic01:07
*** rongze has joined #openstack-ironic01:15
*** jcooley_ has quit IRC01:31
*** rongze has quit IRC01:34
*** rongze has joined #openstack-ironic01:49
*** rongze has quit IRC04:47
*** rongze has joined #openstack-ironic04:48
*** rongze has quit IRC04:52
*** urulama has joined #openstack-ironic04:59
*** rongze has joined #openstack-ironic05:18
*** rongze has quit IRC05:20
*** rongze_ has joined #openstack-ironic05:20
*** rongze_ has quit IRC05:25
openstackgerritJenkins proposed a change to openstack/ironic: Imported Translations from Transifex  https://review.openstack.org/6192006:04
*** jistr has joined #openstack-ironic06:08
*** rongze has joined #openstack-ironic06:18
*** rongze has quit IRC06:23
*** rongze has joined #openstack-ironic06:28
*** prekarat has joined #openstack-ironic06:55
*** zigo has joined #openstack-ironic06:56
*** prekarat has quit IRC06:59
*** prekarat has joined #openstack-ironic07:14
*** rcarrillocruz has joined #openstack-ironic07:32
*** ifarkas has joined #openstack-ironic07:44
*** rongze has quit IRC07:45
*** rongze has joined #openstack-ironic07:51
*** kpavel has joined #openstack-ironic08:52
*** derekh has joined #openstack-ironic09:10
*** mdurnosvistov has joined #openstack-ironic09:20
*** ndipanov has joined #openstack-ironic10:24
*** martyntaylor has joined #openstack-ironic10:33
*** rongze_ has joined #openstack-ironic10:43
*** rongze has quit IRC10:46
*** rongze_ has quit IRC10:48
*** martyntaylor1 has joined #openstack-ironic10:53
*** martyntaylor has quit IRC10:55
*** lucasagomes has joined #openstack-ironic10:55
*** lucasagomes has quit IRC10:56
*** lucasagomes has joined #openstack-ironic10:57
lucasagomesmorning, happy new year everybody :)10:57
*** romcheg has joined #openstack-ironic10:58
*** tatyana has joined #openstack-ironic11:03
*** rongze has joined #openstack-ironic11:14
*** romcheg has quit IRC11:15
*** rongze_ has joined #openstack-ironic11:18
*** rongze has quit IRC11:19
*** rongze_ has quit IRC11:22
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Improve the node validation output  https://review.openstack.org/6347711:24
Haomenglucasagomes: happy new year:)11:44
lucasagomesHaomeng, sup buddy! happy new year!11:45
Haomenglucasagomes: :)11:45
Haomenglucasagomes: how are you, I think you have a happy holiday these days:)11:47
*** romcheg has joined #openstack-ironic11:48
lucasagomesHaomeng, ah it's being great mate, I came to brazil to pass the xmas and nye with my family, will stay here til the end of the month. It's being great so far :)11:49
lucasagomesHaomeng, what about urs?11:50
Haomenglucasagomes: great11:50
Haomenglucasagomes: Lucas, our China Tradition new year is the end of Jan, that is based on our Chinese Lunar calendar11:52
Haomenglucasagomes: :)11:52
lucasagomesHaomeng, I see, I think I heard bout it, so you guys still have a big party ahead :)11:55
Haomenglucasagomes: yes:)11:57
Haomenglucasagomes: :)11:57
Haomenglucasagomes: but I will focus on our Ironic if I am free:)11:57
Haomenglucasagomes: :)11:57
lucasagomesHaomeng, good stuff :D11:57
Haomenglucasagomes: for our Ironic Graduation:)11:59
Haomenglucasagomes: our plan is our Ironic should be graduated on  Apri, right?11:59
lucasagomesHaomeng, actually as soon as possible :) hope by the end of this month or mid feb we get to get out of incubation12:01
Haomenglucasagomes: ok, got it12:01
lucasagomesas far as we get the pair features compatibility with nova bm + a migration path the best12:02
*** rongze has joined #openstack-ironic12:02
Haomenglucasagomes: yes12:03
*** mdurnosvistov has quit IRC12:22
*** rongze has quit IRC12:36
*** rongze has joined #openstack-ironic12:37
*** jistr has quit IRC12:39
*** rongze has quit IRC12:42
*** prekarat has left #openstack-ironic12:49
*** rongze has joined #openstack-ironic13:03
*** kpavel_ has joined #openstack-ironic13:05
*** mdurnosvistov has joined #openstack-ironic13:07
*** jistr has joined #openstack-ironic13:07
*** kpavel has quit IRC13:08
*** kpavel_ is now known as kpavel13:08
*** kpavel_ has joined #openstack-ironic13:24
*** kpavel has quit IRC13:24
*** kpavel_ is now known as kpavel13:24
openstackgerritA change was merged to openstack/ironic: Improve error handling in validate_vendor_action  https://review.openstack.org/6310613:26
openstackgerritA change was merged to openstack/ironic: Avoid a race when associating instance_uuid  https://review.openstack.org/6216013:36
openstackgerritA change was merged to openstack/ironic: Check connectivity in SSH driver 'validate' method  https://review.openstack.org/6087613:41
openstackgerritMartyn Taylor proposed a change to openstack/ironic: Remove POST calls in tests for resource creation  https://review.openstack.org/6467413:45
*** MIDENN_ has quit IRC13:46
*** mdenny has joined #openstack-ironic13:47
*** kpavel_ has joined #openstack-ironic14:02
*** kpavel has quit IRC14:04
*** kpavel_ is now known as kpavel14:04
*** kpavel_ has joined #openstack-ironic14:12
*** kpavel has quit IRC14:13
*** kpavel_ is now known as kpavel14:13
*** urulama has quit IRC14:14
*** kpavel has quit IRC14:29
*** matty_dubs|gone is now known as matty_dubs14:30
openstackgerritImre Farkas proposed a change to openstack/ironic: Make param names more consistent in API  https://review.openstack.org/6468414:41
*** martyntaylor1 has quit IRC14:52
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Improve the node driver interfaces validation output  https://review.openstack.org/6347714:55
NobodyCamgood morning Ironic15:01
NobodyCamand Happy New Year15:04
lucasagomesNobodyCam, happy new year!!! all the best for u and family :)15:11
NobodyCamand you your lucasagomes15:11
dkehn_NobodyCam: do you have some time today for a call, got questions about the Neutron Integration?15:11
lucasagomes:)15:12
NobodyCamdkehn_: sure... still waiting on coffee.. and of course I have prob forgotten evething I knew before the holiday15:14
lucasagomeslol15:14
* lucasagomes same here15:15
NobodyCam:)15:15
NobodyCamlucasagomes: looking at 6052815:15
NobodyCamhttps://review.openstack.org/#/c/60528/12/ironicclient/openstack/common/apiclient/client.py line 354... should that not be _("balh")15:16
*** dkehn_ is now known as dkehn15:17
dkehnNobodyCam: just let me know and I'll bore you with the details15:17
openstackgerritA change was merged to openstack/python-ironicclient: Update openstack-common.conf list, sync with oslo (0d8f18b)  https://review.openstack.org/6216415:18
lucasagomesNobodyCam, lemme take a look very soon (I'm on a call)15:18
*** martyntaylor has joined #openstack-ironic15:19
*** martyntaylor has left #openstack-ironic15:19
lucasagomesNobodyCam, so, that change is just a sync from oslo15:21
NobodyCamya15:22
NobodyCamso no i18n from oslo15:22
lucasagomesit lacks in i18n but that needs to be done in oslo before15:22
lucasagomesyea :/15:22
NobodyCamso should I -1 it for i18n?15:23
*** martyntaylor has joined #openstack-ironic15:24
lucasagomesNobodyCam, I didn't because it's not up to us to fix it in ironic15:24
lucasagomesbut yea it's confusing :/15:25
NobodyCambut we have worked quite hard to make everything i18n15:25
NobodyCamso I don't want to merge it in with out it15:25
lucasagomestrue, do you think we should send a patch to oslo fixing it? then wait to get merged15:26
lucasagomesand then sync it?15:26
lucasagomesNobodyCam, other modules from olso are not i18n as well15:27
lucasagomese.g15:27
lucasagomeshttps://github.com/openstack/python-ironicclient/blob/master/ironicclient/openstack/common/importutils.py#L3315:27
NobodyCamtrue.. prob not all projects support i18m15:28
NobodyCami18n even15:28
lucasagomesyea :(15:32
NobodyCamI commented on it.15:32
NobodyCamI am willing to change my vote15:32
lucasagomesI think the only exception for i18n in ironic (and client) are the oslo modules15:32
lucasagomesNobodyCam, cool yea, let's see what others have to say about it15:33
NobodyCam:)15:33
lucasagomesI'm kinda divided as u as well, maybe +1 would be more appropriated for that15:33
*** rongze has quit IRC15:34
NobodyCambulk of the code looks good to merge just that one issue for me15:34
lucasagomesyea15:35
NobodyCam:)15:35
*** jbjohnso has joined #openstack-ironic15:38
lucasagomesok lunch time, be back soon :)15:40
*** lucasagomes is now known as lucas-hungry15:40
NobodyCamenjoy15:41
*** rongze has joined #openstack-ironic15:44
NobodyCambrb15:46
devanandag'morning, all15:47
NobodyCamgood morning devananda15:50
NobodyCamdevananda: once your up can you take a look at 6052815:53
devanandasure15:54
*** tatyana has quit IRC15:56
devanandaNobodyCam: hmm... I'm not sure I see the point yet16:10
NobodyCamdevananda: on 6052816:11
*** ifarkas has quit IRC16:11
NobodyCamhttps://review.openstack.org/#/c/60528/12/ironicclient/openstack/common/apiclient/client.py line 354... should that not be _("balh")16:11
* devananda goes back in history and reads https://blueprints.launchpad.net/oslo/+spec/common-client-library16:12
* NobodyCam thinks mr jenkins is hungover today16:13
*** blamar has joined #openstack-ironic16:23
*** lucas-hungry is now known as lucasagomes16:24
devanandaNobodyCam: I see what you mean about i18n. All of exception.py is not _()'d16:25
NobodyCamyes16:26
devanandalucasagomes: what are the implications as far as our client lib codebase? how much will be replaced by this work in oslo?16:26
*** Rudeboy has joined #openstack-ironic16:26
devanandalucasagomes: also, when you're back, i'd like to chat about 6303716:28
lucasagomeshey devananda :) back, so idk the extension of the blueprint, but I hope it's not too big. The https://blueprints.launchpad.net/oslo/+spec/common-client-library-2 is a continuation of another blueprint16:30
devanandalucasagomes: yea, i went back and read the original16:30
lucasagomesI hope its only around the http client (post, get, patch, put methods)16:31
lucasagomesand their exceptions etc16:31
*** jistr has quit IRC16:32
lucasagomesdevananda, right, 63037. If no exception is raised on the power off, the last_error message will be kinda vague and won't contain the error returned by the deploy agent16:33
lucasagomesI think it would be a good information to have16:33
*** Rudeboy has quit IRC16:33
lucasagomesother last_error messages contains a more detailed message (for e.g on the ssh validation)16:33
*** mdurnosvistov has quit IRC16:34
jbjohnsohappy new year16:34
devanandalucasagomes: i noddled on it for a while and took the ramdisk error out of last_error because I dont think we should expose detailed, potentially private-data-containing error messages in the API16:34
NobodyCamhumm seems we have a broken pip16:34
NobodyCamhttps://review.openstack.org/#/q/status:open+project:openstack/ironic,n,z16:34
NobodyCamnote all three I just +a'd failed16:34
lucasagomesdevananda, right I see the benefits on that, but then we should also change other last_error messages such as https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ssh.py#L276-L277, no?16:35
lucasagomesNobodyCam, yea :( the one about driver's interface validation also failed for me16:36
devanandalemme poke infra16:36
devanandalooks ilke MySQL-python is broken16:36
NobodyCamdevananda: I am poking infra16:39
devanandalucasagomes: yes, I think we should not have overly-detailed messages in last_error anywhere16:39
devanandalucasagomes: I can toss taht up in another patch16:39
lucasagomesdevananda, right, I tend to agree since exposing internal errors on the API looks bad16:40
lucasagomesI will change my vote and pay more attention to that on the next reviews :)16:41
lucasagomesjbjohnso, hne :)16:43
*** rongze has quit IRC16:48
*** rongze has joined #openstack-ironic16:49
NobodyCammorning walkies time... bbiafm16:52
NobodyCamdevananda: you watching infra?16:52
devanandaNobodyCam: yea16:53
devanandalooks like several things may have broken16:53
NobodyCam:) ya16:53
NobodyCambrb16:53
dkehnNobodyCam: anytime? When u get back16:56
*** matty_dubs is now known as matty_dubs|lunch17:00
*** hemna has joined #openstack-ironic17:03
NobodyCamand back17:07
NobodyCamdkehn: should we conf with devananda on the call?17:08
dkehnNobodyCam: I think for now let just talk a bit could be quick, then if goes to hell yes17:09
*** mdurnosvistov has joined #openstack-ironic17:14
*** rongze has quit IRC17:17
*** rongze has joined #openstack-ironic17:18
*** rongze has quit IRC17:18
*** rongze has joined #openstack-ironic17:19
devanandalucasagomes, NobodyCam - in looking at conductor/manager.py, we're currently just copying the exception message into node.last_error all over the place17:21
devanandaI feel that is not a good idea. do you both agree?17:22
lucasagomesdevananda, I agree, that's why I pointed to that code on the ssh module17:24
lucasagomesif we want the last_error to not be super detailed about the error, we should change that a bit17:25
devanandait jumped out to me when thinking about the kinds of errors that the deploy ramdisk might pass back17:25
devanandabut yea, the more i look at it, the less i like stashing and exposing a whole exception message in the API17:26
NobodyCamdevananda: yes. right now the detailed errror messages can be helpful in tracking down issues17:26
*** rwsu has joined #openstack-ironic17:27
lucasagomesdevananda, NobodyCam, the ramdisk agent still can pass those detailed errors so they get logged by ironic17:27
devanandalucasagomes: yes17:27
lucasagomesbut we can then simplify the message when assigning a value to the last_error17:28
NobodyCamlucasagomes: +1 as long as the actual error is logged17:28
lucasagomesalso we might want to start thinking about the ramdisk agent. idk, before my vacations I was thinking a bit about it, how it's going to communicate with the ironic api to get the next steps to execute etc17:29
lucasagomesdo you guys think we should use something like taskflow to track what's next on the ramdisk to execute?17:30
devanandabecause we're setting last_error, target_state, etc, at the conductor level -- not within the drivers -- this means the drivers don't haev a means to dictate what the last_error string is17:30
devanandayurg17:33
devanandawe were relying on that in a few places17:33
devanandaeg, modules/pxe.py validate()17:33
*** kpavel has joined #openstack-ironic17:33
devanandathe InvalidParameterValue exception messages there include the names of any missing parameters17:33
devanandaso taht the client might know what they were supposed to pass17:33
lucasagomeshmm, yea, but at the same time idk if that should be done by the drivers. It makes them too powerful i think ironic itself should have control over those fields17:33
lucasagomesand drivers would just return the error17:33
lucasagomesI mean, powerful = complicated to implement17:34
devanandaright17:34
devanandadrivers raise the exception, expecting it to be logged // handled appropriately by the conductor17:34
devanandai think it's better that driver's DONT worry about their exceptions being exposed in the REST API17:35
lucasagomesyea that looks correct to me, the conductor is responsable for logging/setting the states17:35
lucasagomesdevananda, +117:36
NobodyCamthat makes sense to /me17:36
devanandacool, thx guys :)17:36
lucasagomesdrivers should do their thing and raise something if something goes bad, but don't need to be aware of how our states/errors feedback works internally17:36
NobodyCamlucasagomes: ya, that will also help prevent a flood of driver specific errors17:37
devanandayea17:38
devanandaclients shouldn't need to interpret tons of different driver errors17:38
lucasagomesyea17:38
NobodyCam:)17:38
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Remove the mandatory from chassis_uuid  https://review.openstack.org/6470117:42
*** rongze has quit IRC17:45
*** rongze has joined #openstack-ironic17:47
NobodyCambrb17:49
*** harlowja has joined #openstack-ironic17:49
lucasagomesdevananda, btw, https://bugs.launchpad.net/wsme/+bug/1256042 got confirmed, there's no fix for it yet tho. But once it get's fixed we can use the on_error hook to strip off the traceback from our exceptions before returning it to the api17:52
*** derekh has quit IRC17:53
*** prekarat has joined #openstack-ironic17:57
*** matty_dubs|lunch is now known as matty_dubs18:01
devanandanice18:09
*** rongze has quit IRC18:09
*** Rudeboy_ has joined #openstack-ironic18:17
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Sanitize node.last_error message strings  https://review.openstack.org/6471118:24
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Improve error handling in PXE _continue_deploy  https://review.openstack.org/6303718:24
*** mdenny has quit IRC18:28
*** mdenny has joined #openstack-ironic18:29
*** lynxman has quit IRC18:33
*** lynxman has joined #openstack-ironic18:33
NobodyCamdevananda: seems we mr Jenkins is still broken18:35
devanandaNobodyCam: yea18:35
NobodyCams/we//18:36
NobodyCam:)18:36
devanandainfra is still working on the problem18:36
NobodyCamya just read the scroll back in -infra18:36
*** rongze has joined #openstack-ironic18:40
NobodyCambrb18:43
*** rongze has quit IRC18:45
*** hstimer has joined #openstack-ironic18:46
*** Rudeboy_ has quit IRC18:46
*** marty- has joined #openstack-ironic18:47
*** hstimer has quit IRC18:47
*** ndipanov is now known as ndipanov_gone18:54
*** rongze has joined #openstack-ironic19:03
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Add unit tests for get_nodeinfo_list  https://review.openstack.org/6448519:07
*** rongze has quit IRC19:13
NobodyCamdkehn: will you able to put that WIP up, so we can get some eyes on it?19:38
dkehnNobodyCam: not immediately, its a bit out,19:39
devanandadkehn: what is the likelyhood of having pxe<->neutron integration done in the next 2 weeks?19:41
dkehndevananda: coding good, done, like with a ribbon, hmm not sure19:41
devanandadkehn: let's say "functional"19:42
dkehndevananda: dkehn thinking19:42
dkehndevananda: I'd like it there by the 14th, cause I have to go to the neutron sprint by then, but given the idea of get ting a testing env up and all, it could be very questionable19:44
devanandadkehn: test env is a separate question. a few of the mirantis folks are workign on that (romcheg, etc)19:44
dkehndevananda: taking that off the table I think its likely19:45
dkehndevananda: thats what I'm targeting19:45
devanandadkehn: great :)19:46
devanandadkehn: i'm targeting an I2 milestone release of ironic, which will be Jan 22. I'd like it to have all bits in place to do a deploy by then, if we can. as long as it mostly works, we can iron out bugs later19:50
dkehndevananda: understood19:50
NobodyCambrb... quick walkies19:52
NobodyCamand back19:56
*** michchap has quit IRC19:58
devanandaromcheg: ping20:14
*** michchap has joined #openstack-ironic20:15
NobodyCamdevananda: I think, but am not 100% sure, that it is still holiday for romcheg20:16
devanandaromcheg: actually, async is fine -- it looks to me like https://blueprints.launchpad.net/ironic/+spec/rpc-routing is superceded by https://blueprints.launchpad.net/ironic/+spec/instance-mapping-by-consistent-hash, and won't be needed once I finish the consistent hash code. What do you think?20:16
devanandaNobodyCam: probably - but he may get the message anyway :)20:16
NobodyCam:)20:16
jbjohnsodevananda, fyi, after I do one more test, I'm going to approve the intel patch for bridged requests20:19
jbjohnsodevananda, I can at least verify that non-bridged is no worse off20:20
devanandajbjohnso: nice. I know some HP folks who will be happy about that, too20:22
devanandajbjohnso: eg, those who were traking https://review.openstack.org/#/c/54480/ ....20:22
lucasagomesI gotta run, g'night everyone :)20:26
NobodyCamnight lucasagomes20:26
lucasagomesNobodyCam, night buddy! see y'all20:27
*** lucasagomes is now known as lucas-dinner20:27
* devananda steps away to resume packing20:35
NobodyCam:)20:35
*** lucas-dinner has quit IRC20:43
romchegHi guys21:08
romchegYes, it's still holiday for me and for folks in Russia21:08
devanandahi romcheg ! happy holidays :)21:09
romchegThanks21:09
devanandaromcheg: roughly when do ya'll get back?21:09
romchegJan 7th21:09
romchegRussians will be available on Jan 821:09
devanandaah, ok. I'll be in AU until the 16th21:09
romchegdevananda: I will take a detailed look on those BPs again21:10
romchegtomorrow21:10
romchegit's too late here and I'm after a few beers :)21:10
devanandahaha, no worries :)21:10
NobodyCamparty at romcheg's house21:10
NobodyCam:) Hi romcheg21:10
devanandaromcheg: fyi, i may be a bit closer to your timezone for a few days while attending LCA conference. may make it easier to sync up around the 8th or 9th21:11
romchegI think we might still need rpc routing to handle maintenance mode correctly21:12
*** rongze has joined #openstack-ironic21:12
romchegdevananda: I wrote that down :)21:12
romcheg¡Hola NobodyCam! How are you?21:13
NobodyCam:) doing great. :) had a really nice holiday time. trying to get back into the swing now.21:14
* NobodyCam is glad it thursday and that tomorrow is friday :-p21:14
romcheg*still has a few holidays* :-P21:15
*** rongze has quit IRC21:17
NobodyCamhehehe21:18
*** jbjohnso has quit IRC21:24
*** martyntaylor has quit IRC21:53
*** rongze has joined #openstack-ironic22:12
*** rongze has quit IRC22:17
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Sanitize node.last_error message strings  https://review.openstack.org/6471122:28
*** matty_dubs is now known as matty_dubs|gone22:32
*** rwsu has quit IRC22:33
devanandaNobodyCam: looks like gate is fixed. I've rechecked/reverified all the patches in the queue taht failed22:39
devanandashould see some land in a few min22:39
NobodyCamw00t22:39
NobodyCam:)22:39
*** rwsu has joined #openstack-ironic22:40
openstackgerritA change was merged to openstack/ironic: Add prepare, clean_up, take_over methods to deploy  https://review.openstack.org/5889422:41
openstackgerritA change was merged to openstack/ironic: Convert trycmd() to oslo's processutils  https://review.openstack.org/6170922:41
openstackgerritA change was merged to openstack/ironic: Move and rename ValidTypes  https://review.openstack.org/6267522:42
*** anniec has joined #openstack-ironic22:57
*** rwsu has quit IRC22:59
*** rwsu has joined #openstack-ironic23:12
*** rongze has joined #openstack-ironic23:13
*** anniec has quit IRC23:14
NobodyCambrb23:15
*** anniec has joined #openstack-ironic23:18
*** rongze has quit IRC23:18
*** hemna has quit IRC23:33
*** kpavel has quit IRC23:58
« Wednesday, 2014-01-01 Index Friday, 2014-01-03 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!