Wednesday, 2014-02-12

*** anniec has quit IRC00:00
*** epim has quit IRC00:03
rlooNobodyCam: it is fine to forget me;)00:04
NobodyCamrloo: not yiu found a good issue last look00:04
NobodyCamkeep it up... I luv it :)00:05
NobodyCams/yiu/you/00:05
*** matsuhashi has joined #openstack-ironic00:06
rlooNobodyCam: ha ha. I'll take a quick look but am too tired to do a detailed review tonight.00:07
NobodyCamlol :) its only 51 lines of code... and about 100 of tests :-p00:07
* NobodyCam *DUCKS*00:08
*** anniec has joined #openstack-ironic00:08
rlooI am short; ducking won't help ;)00:08
NobodyCamdoh :-p00:08
NobodyCamhehehe00:08
* NobodyCam Jumps?!?00:09
NobodyCam:-p00:09
rloodid you land yet?00:09
NobodyCamlol00:09
NobodyCamyep00:09
rlooso i know it was mentioned about assuming the task just has one node, but... how is anyone supposed to know that if they look at this code change?00:10
NobodyCamso a TODO: add multi node support?00:11
rlooI *think* deva and max_lobur mentioned not providing multinode support at all.00:11
devanandaNobodyCam: I just edited https://wiki.openstack.org/wiki/Ironic#Using_Disk_Image_Builder a bit00:12
NobodyCam:)00:12
devanandaso, yes00:12
devanandadropping multi-node support ++00:12
rlooNobodyCam, devananda. dropping multi-node support for this one method, or throughout ironic code?00:13
devanandathat derailed into an architectural discussion about schedudling and group oeprations and failt domains00:13
NobodyCamshould Include anyhting about it on the review?00:13
devanandaooh sweet - my undercloud node failed to boot with00:14
devanandautil.py: failed to resize filesystem00:14
NobodyCamout of disk space?00:15
devanandadisk is 16G00:15
NobodyCamfree space on host?00:16
devananda>50% free00:16
*** epim has joined #openstack-ironic00:16
NobodyCamhumm00:16
*** matsuhashi has quit IRC00:21
*** matsuhashi has joined #openstack-ironic00:21
*** matsuhashi has quit IRC00:25
*** matsuhas_ has joined #openstack-ironic00:25
*** anniec has quit IRC00:30
*** anniec has joined #openstack-ironic00:34
*** rloo has quit IRC00:35
devanandahmmm00:38
devanandaso i'm reminded of a bug i filed a bit ago00:39
devanandathink of this situation00:39
devanandadeploy starts00:39
devanandait locks a node, fetches the node and its ports from the db, and passes those objects to driver to work on them00:40
devanandahere's where the wierdness of single vs multi node task is currently being felt00:40
devanandabut also00:40
devanandawhat if another request comes in to update one of those ports?00:40
devanandalike -- to change it's MAC00:40
devanandaright now, ports don't have a "reservation" field.00:40
devanandathere's no locking done around updating ports at all. let alone cross-resource lock awareness00:41
devanandalike you can't update this port because the Node that it belons to is locked00:41
devanandabut we obviously shouldn't00:41
devanandaallow the port's mac to be changed mid-deploy00:41
devanandaNobodyCam ^00:42
NobodyCamyes00:43
devanandai was going to point rloo at that, but she's gone00:43
NobodyCamya00:44
NobodyCamalso digambar_ has started on https://bugs.launchpad.net/ironic/+bug/127639300:44
NobodyCamwhich seem to be along the same lines00:44
NobodyCammight be a good time to update the bug :-p out from under him00:45
devanandaoh00:45
devanandathat's the bug i filed :)00:46
NobodyCam:)00:46
devanandayep that's fine00:46
devanandathat solution is fine00:46
devanandaneeds a new RPC method00:46
devanandathat's probably all00:47
devanandaAPI should call update_port like it calls update_node today00:47
openstackgerritChris Krelle proposed a change to openstack/ironic: Implement _update_neutron in PXE driver  https://review.openstack.org/7046800:50
openstackgerritChris Krelle proposed a change to openstack/ironic: Implement _update_neutron in PXE driver  https://review.openstack.org/7046800:51
NobodyCamdevananda: updated per rloo's and max's comemnts00:52
*** epim has quit IRC00:53
devananda:)00:54
*** nosnos has joined #openstack-ironic01:01
NobodyCamok /me calles it a day. devananda tomorrow ^^^ I will work ^^^ until it land tomorrow!01:07
devananda:)01:12
devanandaromcheg: any progress on the nova_bm -> ironic db migration stuff?01:12
NobodyCam:)01:12
*** john-n-seattle1 has quit IRC01:13
*** jbjohnso has joined #openstack-ironic01:14
*** anniec has quit IRC01:17
*** anniec has joined #openstack-ironic01:38
*** killer_prince has quit IRC01:55
*** anniec has quit IRC02:03
*** jbjohnso has quit IRC02:34
*** john-n-seattle has joined #openstack-ironic02:44
*** anniec has joined #openstack-ironic02:45
*** anniec has quit IRC02:58
*** anniec has joined #openstack-ironic03:03
*** matsuhas_ has quit IRC03:39
*** dkehn__ has joined #openstack-ironic04:00
*** dkehn has quit IRC04:03
*** dkehn_ has quit IRC04:03
*** dkehn has joined #openstack-ironic04:05
*** dkehn__ is now known as dkehn_04:12
*** anniec has quit IRC04:27
*** killer_prince has joined #openstack-ironic04:33
*** shawal has joined #openstack-ironic04:43
*** harlowja is now known as harlowja_away04:44
*** shawal has quit IRC04:44
*** shawal has joined #openstack-ironic04:44
*** matsuhashi has joined #openstack-ironic04:52
*** lazy_prince has joined #openstack-ironic05:31
*** aignatov_ is now known as aignatov05:36
*** nosnos_ has joined #openstack-ironic05:43
*** nosnos_ has quit IRC05:44
*** nosnos_ has joined #openstack-ironic05:44
*** nosnos has quit IRC05:46
*** anniec has joined #openstack-ironic06:02
*** saju_m has joined #openstack-ironic06:02
*** nosnos_ has quit IRC06:04
*** nosnos has joined #openstack-ironic06:04
*** anniec_ has joined #openstack-ironic06:05
*** anniec has quit IRC06:06
*** anniec_ is now known as anniec06:06
openstackgerritJenkins proposed a change to openstack/ironic: Imported Translations from Transifex  https://review.openstack.org/7119206:06
*** hstimer has quit IRC06:12
*** dkehn__ has joined #openstack-ironic06:14
*** dkehn__ has quit IRC06:16
*** dkehn__ has joined #openstack-ironic06:17
*** dkehn has quit IRC06:17
*** dkehn_ has quit IRC06:17
*** shawal has quit IRC06:17
*** dkehn has joined #openstack-ironic06:19
*** lifeless has quit IRC06:34
lazy_princehi all,06:35
*** dkehn_ has joined #openstack-ironic06:36
lazy_prince I am using devstack and i am getting error when nova-api is starting. http://paste.openstack.org/show/64530/06:37
lazy_princecan someone please help..06:38
*** dkehn has quit IRC06:38
*** dkehn__ has quit IRC06:39
*** dkehn has joined #openstack-ironic06:40
*** max_lobur_afk has quit IRC06:40
*** max_lobur_afk has joined #openstack-ironic06:41
*** anniec has quit IRC06:41
*** romcheg has quit IRC06:42
*** romcheg has joined #openstack-ironic06:42
*** dshulyak has quit IRC06:44
*** max_lobur_afk has quit IRC06:44
*** mdurnosvistov has quit IRC06:44
*** romcheg has quit IRC06:44
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Make ironic-api not single threaded  https://review.openstack.org/7285106:44
*** max_lobur_afk has joined #openstack-ironic06:44
*** mdurnosvistov has joined #openstack-ironic06:44
*** max_lobur_afk has quit IRC06:45
*** mdurnosvistov has quit IRC06:45
*** mdurnosvistov has joined #openstack-ironic06:45
*** max_lobur_afk has joined #openstack-ironic06:45
*** romcheg has joined #openstack-ironic06:45
*** dshulyak has joined #openstack-ironic06:45
devanandalazy_prince: nova-api? i think you may be in the wrong channel06:48
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Add samples to serve API through Apache mod_wsgi  https://review.openstack.org/7206906:53
lazy_princedevananda: my mistake. i didnt notice that i am in wrong channel..06:56
*** aignatov is now known as aignatov_07:00
*** dkehn__ has joined #openstack-ironic07:01
*** aignatov_ is now known as aignatov07:02
*** dkehn has quit IRC07:04
*** dkehn_ has quit IRC07:04
*** dkehn has joined #openstack-ironic07:06
*** athomas has joined #openstack-ironic07:17
*** aignatov is now known as aignatov_07:19
*** coolsvap has joined #openstack-ironic07:21
*** coolsvap1 has joined #openstack-ironic07:26
*** coolsvap has quit IRC07:28
*** coolsvap1 has quit IRC07:36
*** coolsvap has joined #openstack-ironic07:36
GheRiveromorning all08:09
*** mdurnosvistov_ has joined #openstack-ironic08:10
*** romcheg1 has joined #openstack-ironic08:16
*** dkehn_ has joined #openstack-ironic08:24
HaomengGheRivero: morning:)08:24
*** pquerna has quit IRC08:25
*** dkehn_ has quit IRC08:26
*** pquerna has joined #openstack-ironic08:26
*** dkehn_ has joined #openstack-ironic08:26
*** dkehn has quit IRC08:26
*** dkehn__ has quit IRC08:27
*** dkehn has joined #openstack-ironic08:28
*** pquerna has quit IRC08:49
*** pquerna has joined #openstack-ironic08:58
*** coolsvap1 has joined #openstack-ironic08:59
*** mdurnosvistov_ has quit IRC09:00
*** coolsvap has quit IRC09:01
*** ifarkas has joined #openstack-ironic09:02
*** aignatov_ is now known as aignatov09:02
*** jistr has joined #openstack-ironic09:04
*** jistr is now known as jistr|sick09:04
openstackgerritYongli He proposed a change to openstack/ironic: Use six.moves.urllib.parse instead of urlparse  https://review.openstack.org/7288909:09
*** lucasagomes has joined #openstack-ironic09:15
*** yuriyz has joined #openstack-ironic09:19
*** tatyana has joined #openstack-ironic09:32
*** athomas has quit IRC09:36
Haomenglucasagomes: morning:)09:38
lucasagomesHaomeng, morning :)09:46
Haomenglucasagomes: :)09:46
Haomenglucasagomes: I have an idea about auto-discory and register ironic ipmi node utility, just ping ipmi port to discovery it and get arp list to find the mac by ip, how do you think about this idea, can we create a bp for this new feature?09:46
Haomenglucasagomes: auto-discovery09:47
lucasagomesHaomeng, nice! yea there's a bp already in the "discussion" state09:47
lucasagomesso we could update it with such infos09:47
* lucasagomes grabs the link09:47
lucasagomeshttps://blueprints.launchpad.net/ironic/+spec/discovery-ramdisk09:47
Haomenglucasagomes: I know this bp, but it is in-band09:47
Haomenglucasagomes: my idea is try to find ipmi physical node09:48
Haomenglucasagomes: does not depend on ramdisk09:48
lucasagomesHaomeng, ahh ack, yea that bp is in-band for a more generic type of discovery09:48
lucasagomessure feel free to put up a blueprint for that :)09:48
Haomenglucasagomes: this discovery tool can be run from our ironic conductor node09:49
Haomenglucasagomes: ok, thank you:)09:49
lucasagomesyea that would be pretty useful to have09:49
lucasagomesthank u!09:49
Haomenglucasagomes: and I want to get it with a discovery-template with default ipmi user/password and other parameters to be populated to our ironic node when creating09:50
Haomenglucasagomes: :)09:50
lucasagomesnice! btw I read something re ipmi / ibm yesterday09:51
Haomenglucasagomes: to auto-config our node driver info09:51
lucasagomeslemme try to find the link09:51
lucasagomesa guy was reverse engineering the protocol09:51
Haomenglucasagomes: ok09:51
lucasagomeshttp://mjg59.dreamwidth.org/29210.html09:51
Haomenglucasagomes: got, thk09:51
lucasagomesHaomeng, nice, yea auto-discovery is one of the most requested feature in Ironic09:52
lucasagomeswe def gotta include it in J09:52
Haomenglucasagomes: ok09:52
Haomenglucasagomes: let me prepare the draft first:)09:52
lucasagomesHaomeng, sure :) thanks09:52
Haomenglucasagomes: and welcome your comments once the bp is created:)09:52
lucasagomes^^ will do09:53
Haomenglucasagomes: :)09:53
Haomenglucasagomes: nice day, I will be away for a while:)09:53
lucasagomesHaomeng, cheers, for u too09:53
Haomenglucasagomes: :)09:54
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Fix API inconsistence when changing node's states  https://review.openstack.org/6750610:00
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Fix API inconsistence when changing node's states  https://review.openstack.org/6750610:16
*** martyntaylor has joined #openstack-ironic10:33
*** martyntaylor has quit IRC10:33
*** jbjohnso has joined #openstack-ironic10:38
*** matsuhashi has quit IRC10:41
*** aignatov is now known as aignatov_10:41
*** jbjohnso has quit IRC10:50
*** martyntaylor has joined #openstack-ironic10:52
*** saju_m has quit IRC10:57
*** jistr|sick has quit IRC10:57
*** max_lobur_afk is now known as max_lobur11:03
max_loburmorning Everyone!11:03
*** lifeless has joined #openstack-ironic11:07
lazy_princeHi.. I am planning to test https://review.openstack.org/#/c/64542. I have an esxi host registered to vCenter. do I need to provide creds for the the host or for the vCenter. i believe i have to use host creds.. do i need to specify any additional properties or any config change?11:11
openstackgerritMax Lobur proposed a change to openstack/ironic: Replace assertEqual(None, *) with assertIsNone in tests  https://review.openstack.org/7038211:13
lucasagomeshi lazy_prince yes you will need the host creds11:13
lucasagomeslazy_prince, you might want to take a look at https://etherpad.openstack.org/p/IronicDeployDevstack11:13
lucasagomesit's a guide to deploy a vm using ironic with pxe_ssh driver11:14
lucasagomesnote we are using  "ssh_virt_type=virsh" so you'll have o change it to "vmware" for ur test11:14
*** dkehn__ has joined #openstack-ironic11:18
*** john-n-seattle2 has joined #openstack-ironic11:18
*** dkehn__ has quit IRC11:20
*** dkehn__ has joined #openstack-ironic11:20
*** dkehn has quit IRC11:20
*** aignatov_ is now known as aignatov11:21
*** dkehn_ has quit IRC11:21
lazy_princelucasagomes: thanks. I am also assuming that for this to work the ESXi host should not be in locked-in mode. let me test it and get back to you11:21
lucasagomeslazy_prince, ack11:21
*** john-n-seattle has quit IRC11:21
*** dkehn has joined #openstack-ironic11:22
*** aignatov is now known as aignatov_11:37
*** saju_m has joined #openstack-ironic11:40
*** matsuhashi has joined #openstack-ironic11:44
max_loburtempest check for each comment seems to bring some sense11:44
max_loburmerge conflicts discovered on early stage11:44
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Fix API inconsistence when changing node's states  https://review.openstack.org/6750611:46
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Add topic to the change_node_maintenance_mode() RPC method  https://review.openstack.org/7272411:47
max_loburdoes anybody know how to properly apply this https://review.openstack.org/#/c/72069/2 ? :)11:49
max_loburI'm not very familiar with apache11:49
max_loburbut would like to test11:49
*** saju_m has quit IRC11:49
max_loburwhat should I do? I tried to copy to etc/apache2/ironic and restart apache, but it does not respond to after this (basically the api is not running)11:50
max_loburbrb11:54
devanandamorning, all11:59
max_loburmorning devananda :)12:01
max_loburyou're early today12:01
devanandaindeed. and i was up late12:02
lucasagomesmorning max_lobur devananda12:06
max_loburmorning Lucas12:06
yuriyzMorning Ironic12:13
*** coolsvap_ has joined #openstack-ironic12:14
max_loburmorning yuriyz 8)12:14
yuriyzdevananda, should "if self.host != mapped_hosts[0]" be here https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L364 ?12:15
yuriyzotherwise sync tasks duplicated IMO12:16
*** coolsvap1 has quit IRC12:17
*** dkehn_ has joined #openstack-ironic12:18
*** dkehn has quit IRC12:20
*** dkehn__ has quit IRC12:21
*** dkehn has joined #openstack-ironic12:22
devanandayuriyz: if hash_distribution_replicas > 1, then you're correct12:23
devanandayuriyz: actually, I think, instead of only checking if self.host == mapped_hosts[0], we should get list of dead conductors and exclude them, and see if self.host is the first one still alive12:25
*** aignatov_ is now known as aignatov12:26
devanandayuriyz: that is the intent of hash_distribution_replicas > 1 -- let next conductor in the ring take over for a temporarily down conductor, before a full rebalance is initiated12:26
*** jbjohnso has joined #openstack-ironic12:27
devanandauntil we finish implementing take over / rebalance things, perhaps hash distribution replicas should default to 112:36
*** lucasagomes is now known as lucas-hungry12:41
devanandamax_lobur: as you're testing your workerpool stuff, be sure you're using a threaded api server12:41
lucas-hungrydevananda, left some comments on the threaded api server review12:41
devanandamax_lobur: eg, 72851 or 7206912:41
devanandalucas-hungry: ack, just about to fix them12:41
lucas-hungryack12:42
lucas-hungrythere's one thing that happened on my env right now when using that patch12:42
lucas-hungryI gotta take a better look12:42
lucas-hungrygoing to grab some food first12:42
*** Alexei_987 has joined #openstack-ironic12:45
*** aignatov is now known as aignatov_12:45
max_loburdevananda, k, actually I didn't notice 72851 so far12:45
max_loburwill take a look12:45
max_loburthe 72851 and 72069 are alternatives to each other, right?12:46
devanandamax_lobur: right12:47
*** aignatov_ is now known as aignatov12:48
max_loburdevananda, and about 72069 - are there other steps except copy to /etc and restart apache to make it running?12:48
max_loburor there are much more?12:48
*** lucas-hungry has quit IRC12:50
openstackgerritMartyn Taylor proposed a change to openstack/ironic: Remove POST calls in tests for resource creation  https://review.openstack.org/6467412:54
*** mgoddard has quit IRC13:00
lazy_princeregarding https://review.openstack.org/#/c/64542, I have a small doubt, will SSHPower driver create the baremetal vm  on the ESXi host for me or do I have to create a VM manually and then create ironic node and set its MAC id..13:01
*** lucas-hungry has joined #openstack-ironic13:03
devanandamax_lobur: copy that and edit as needed for your enviroment (paths, etc) and install mod_wsgi13:04
max_loburdevananda, ack13:05
*** saju_m has joined #openstack-ironic13:05
devanandamax_lobur: greenthreaded api is sufficient for testing. production folks will want the apache mod_wsgi13:05
*** saju_m has quit IRC13:06
*** saju_m has joined #openstack-ironic13:07
devanandayuriyz: https://bugs.launchpad.net/ironic/+bug/127933113:08
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Make ironic-api not single threaded  https://review.openstack.org/7285113:12
*** mgoddard has joined #openstack-ironic13:15
lazy_princeSo I have tried testing https://review.openstack.org/#/c/64542 and the VM is not coming up. the logs and the node details are placed at http://paste.openstack.org/show/64631/ . can someone please take a look and help me figure out what did i miss..13:19
devanandalucas-hungry: what exception are you triggering? I'm seeing proper error returns for things13:21
devanandalazy_prince: the error is coming from http://git.openstack.org/cgit/openstack/ironic/tree/ironic/drivers/modules/ssh.py#n16813:23
devanandalazy_prince: there should be some ERROR in the logs before that EXCEPTION. it may also help to turn on DEBUG logging13:24
devanandalazy_prince: the SSH power driver is not able to find the VM you specified. This is the method that tries to search for the VM name based on MAC address of the node's port(s) -- http://git.openstack.org/cgit/openstack/ironic/tree/ironic/drivers/modules/ssh.py#n21313:26
devanandalazy_prince: have you associated a Port with the VM node?13:26
lazy_princeyes.. the mac id is 00:50:56:9c:30:ea13:27
*** jdob has joined #openstack-ironic13:28
lazy_princedevananda: I am using devstack, how do i turn debug logs..13:30
devanandalazy_prince: edit /etc/ironic/ironic.conf and uncomment this line13:32
devananda#debug=true13:32
devanandathen restart ir-cond service13:32
lazy_princedevananda: thanks.. let me try this.13:33
*** mdurnosvistov has quit IRC13:37
*** mdurnosvistov has joined #openstack-ironic13:38
devanandaagordeev: ping13:52
devanandaagordeev: question on https://review.openstack.org/#/c/70348/5/lib/ironic -- are you testing this with dnsmasq? I see your #TODOs about it, but I am not aware that Ironic works with dnsmasq today13:53
lazy_princedevananda: so i noticed that debug is already enabled in my case and the complete log along with node details, port details are available at http://paste.openstack.org/show/64641/13:56
*** lucas-hungry is now known as lucasagomes13:56
max_loburbbiaw13:58
lucasagomesdevananda, so afair, the exceptions was raised in the conductor but weren't send be to the api13:59
lucasagomesso the api was hanging on the request, I will take a better look at it14:00
lucasagomesI'm also testing the console patch on top of ur patch so it's a bit messy14:00
lazy_princedevananda: I am using esxi 5.1 build 1065491 and i notices that some of the commands that was coded for vmware does not work on the esxi shell14:01
*** coolsvap_ has quit IRC14:02
devanandalazy_prince: ahhh. ok! that's good to know -- i don't have access to vmwre/esxi shell to test14:03
devanandalazy_prince: can provide feedback on the review with details about those commands?14:03
devanandalucasagomes: exception in what RPC method?14:04
devanandalucasagomes: oh heh, nvm, you said you're also working on the console stuff14:05
lucasagomesdevananda, the exception was a RPC method which is not in trunk, I was testing the console patch14:05
lucasagomesyea14:05
devananda:)14:05
*** rloo has joined #openstack-ironic14:07
lazy_princedevananda: sure.. but before that i wanted to ensure that my setup is proper and there is no user mistake. since i am not able to execute certain commands like *vim-cmd list --all*, it makes me feel that its a bug in the code and i might be able to find what is the exact command that will work. but again it may depend on esxi version as well so I would like to know what version of esxi was used during development.14:08
lazy_princedevananda:  in the worst may be, we will end up using different ssh_virt_type for different versions of esxi.14:08
devanandalazy_prince: hm14:10
devanandathis is a copy/paste error:  "list --all|grep running|awk -v qc='\"' -F\" \" '{print qc$2qc}'",14:10
devanandathat is the command for virsh, not for vmware14:10
devanandalazy_prince: i'm going to post another rev of that patch. it's clearly a copy/paste error.... here is the original Nova patch with proper vmware commands: https://review.openstack.org/#/c/64542/1/ironic/drivers/modules/ssh.py14:12
devanandabad paste. i mean https://review.openstack.org/#/c/58940/9/nova/virt/baremetal/virtual_power_driver_settings.py14:13
lazy_princedevananda: okay.. thanks for the update. I will add my comments to the review and I will test it once its updated14:14
devanandaHaomeng: ping14:14
*** saju_m has quit IRC14:21
*** aignatov is now known as aignatov_14:25
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: SSHPower driver support VMware ESXi  https://review.openstack.org/6454214:27
devanandaHaomeng: I have updated your patch ^14:27
devanandalazy_prince: hope that helps14:28
*** aignatov_ is now known as aignatov14:28
*** matty_dubs|gone is now known as matty_dubs14:34
openstackgerritYuriy Zveryanskyy proposed a change to openstack/ironic: Add ability to break TaskManager locks via REST API  https://review.openstack.org/7121214:37
*** saju_m has joined #openstack-ironic14:38
lazy_princedevananda: I have tested the 2nd patch set and it seems to be working in my case.14:52
devanandalazy_prince: that's great :)14:53
agordeevdevananda: ping. hello!14:55
max_loburback14:55
agordeevmorning/evening, guys!14:55
lazy_princedevananda: my test just included creating a node in ironic and provisioning instance on the baremetal VM. is there any specific testing that I need to perform. please let me know.14:56
agordeevdevananda: i'm using https://etherpad.openstack.org/p/IronicDeployDevstack as the source. It suggests to use dnsmasq :)14:57
lazy_princei too am using dnsmasq as described in https://etherpad.openstack.org/p/IronicDeployDevstack and it works for me.14:59
devanandaagordeev: ahhh... right. I blame lucasagomes for that :)14:59
lucasagomeshah14:59
lucasagomeslemme read14:59
lucasagomesagordeev, oh yea my bad, I mean, it's a temporary solution15:00
devanandalucasagomes: have you gotten deploy with the noav driver to work with neutron? That shouldn't be dependent on neutron support in our PXE driver15:00
lucasagomesas the neutron integration is not yet complete (almost there)15:00
lucasagomesdevananda, not yet :( but we have a guy testing it in the moment15:00
lucasagomesifarkas,15:00
devanandak15:00
NobodyCamGood morning Ironic, says the man making coffee15:00
devanandaNobodyCam: morning!15:00
* ifarkas reading back15:01
devanandalazy_prince: so as a power driver, if you are able to start/stop/reboot an ESXi VM using ironic with the SSH power driver, then I think that is sufficient tests for that patch15:01
agordeevdevananda: also a question. lib/baremetal uses bm_poseur to maintain VMs and bridge. Should I reuse it? The code seems too obsolete and outdated, so I'm in doubt and introduced mine functions to lib/ironic which are duplicating lib/baremetal functionality15:02
devanandaagordeev: please don't reuse it, heh15:02
devanandaagordeev: i think it would be better to use the code from tripleo-incubator, or if it's not that much, just use your own15:02
lazy_princedevananda: I deleted the node using ironic node-delete but the VM is not powered off. is that expected..? or do i have to use a separate cmd to power off the VM..15:03
devanandalazy_prince: oh, huh. that could be a bug. please try all three commansd: power on, power off, reboot15:03
devanandalazy_prince: also please test it with more than 1 VM to make sure that it is correctly identifying the right VM15:04
lazy_princedevananda: can you please help me with the cmds, i am kinda new to these stuff...15:04
* lucasagomes adds a not to the pad saying that the dnsmasq step is a temporary solution15:04
lucasagomesnote*15:04
devanandalazy_prince: actually -- yes,that is expected right now. if you merely issue "ironic node-delete", it will not attempt to change the power state of the node prior to deleting it15:04
NobodyCammax_lobur: fyi: on 70468 I got this     for port in task.node.ports:15:05
NobodyCamAttributeError: 'Node' object has no attribute 'ports'15:05
lazy_princedevananda: okay...15:05
max_loburNobodyCam, lemme see15:05
devanandalazy_prince: once you have enrolled with node-creaet and node-update, then issue "ironic node-set-power-state $NODE $state" where state is one of "on", "off", and "reboot"15:06
max_loburNobodyCam, you're right15:06
max_lobursorry15:06
max_loburmy bad15:06
max_loburtask.node - is a reference to UOM node15:06
max_loburnot to the node resource15:06
max_loburtherefore will have to leave task.resources[0].ports15:06
max_lobursorry for confusion15:06
NobodyCam:)15:07
devanandamax_lobur: thus why i'd like to refactor the resource manager class :)15:08
max_lobur:)15:08
max_loburso far we have:15:08
max_lobur1. Node SqlAlchemy model15:08
max_lobur2. Node UOM15:08
max_lobur3. Node resource15:09
lazy_princedevananda: okay.. I will do that tomorrow. getting late.. will do rest of the SSHpower testing tomorrow.15:09
max_lobur4. Node object in the REST api15:09
max_loburmay be confusing for beginning :)15:09
devanandalazy_prince: thanks much!15:09
NobodyCammax_lobur: it is confusing for me at times15:10
max_loburgoing to grab some food15:10
max_loburbbiaw15:10
NobodyCam:)15:10
max_loburdevananda, https://review.openstack.org/#/c/72851/ - works for me15:10
devanandamax_lobur: dont forget node the actual hardware :)15:10
max_loburthough I'd like to wait while Lucas doing his investigation15:11
max_loburdevananda, ++ :D15:11
devanandamax_lobur: why +1 not +2?15:11
max_loburbecause I'm waiting for Lucas :)15:11
devanandamax_lobur: so +2 it :)15:11
max_loburk ;D15:12
devanandamax_lobur: then if lucas finishes his testing, he can +2/+A15:12
max_loburright15:12
max_loburdone :D15:12
devanandahahaha15:13
*** lazy_prince has quit IRC15:13
max_lobur:D15:14
max_loburbbiaw15:14
*** max_lobur is now known as max_lobur_afk15:14
devanandamax_lobur: you can always say "+2 but i want to give $someone time to test it" and other cores will honor that and not approve ....15:14
*** observer_ has joined #openstack-ironic15:18
NobodyCambrb15:20
*** observer_ has left #openstack-ironic15:21
openstackgerritAndrey Kurilin proposed a change to openstack/python-ironicclient: Sync latest code and reuse exceptions from oslo  https://review.openstack.org/7150015:24
*** aignatov is now known as aignatov_15:33
*** dkehn__ has joined #openstack-ironic15:37
*** coolsvap has joined #openstack-ironic15:37
*** dkehn has quit IRC15:38
*** dkehn_ has quit IRC15:38
*** dkehn has joined #openstack-ironic15:40
*** dkehn_ has joined #openstack-ironic15:43
*** dkehn has quit IRC15:45
*** dkehn__ has quit IRC15:47
*** dkehn__ has joined #openstack-ironic15:47
*** aignatov_ is now known as aignatov15:47
*** dkehn has joined #openstack-ironic15:48
*** tatyana_ has joined #openstack-ironic15:48
*** davidlenwell_ has joined #openstack-ironic15:49
*** MIDENN_ has joined #openstack-ironic15:50
*** SpamapS_ has joined #openstack-ironic15:51
devanandahttps://review.openstack.org/#/c/63937/ needs another core to review it15:54
romcheg1I'm on it15:54
*** thedodd has joined #openstack-ironic15:55
*** dkehn_ has quit IRC15:56
*** martyntaylor has quit IRC15:56
*** tatyana has quit IRC15:56
*** SpamapS has quit IRC15:56
*** davidlenwell has quit IRC15:56
*** mordred has quit IRC15:56
*** tatyana_ is now known as tatyana15:56
*** ifarkas has quit IRC15:58
lucasagomesdevananda, start/stop of the console, async or sync?15:59
lucasagomesdevananda, I thought about async, but I don't think it that a task like that15:59
lucasagomeswould take a long time15:59
lucasagomes(unless ipmi times out etc)16:00
lucasagomeshmm16:00
lucasagomesNobodyCam, ^16:00
devanandalucasagomes: hah. don't count on anything with ipmi being synchronous16:00
devanandalucasagomes: async it must be16:00
lucasagomesack16:00
devanandalucasagomes: also, other drivers ....16:00
devanandawe need to broadly adopt the model that all operations on nodes are async16:01
lucasagomeshah thanks16:01
lucasagomesindeed16:01
*** coolsvap1 has joined #openstack-ironic16:01
devanandawe already basicaly do that, but it's not explicitly documented anywhere that that is our policy16:01
lucasagomeswhat holds me on the async is always the feedback for the user16:01
lucasagomesto the*16:02
devanandayea, i get that -- we want instant gratification16:02
devanandabut this is a cloud :)16:02
devanandaeverything is async, because sync does not scale16:02
lucasagomesdevananda, yea, for e.g the console... should we use the last_error as well?16:02
devanandayep16:02
lucasagomesack16:02
lucasagomeswe might want to include a flag on states telling whether the console is enabled/disabled/not supported16:03
*** coolsvap has quit IRC16:03
*** martyntaylor has joined #openstack-ironic16:04
*** mordred has joined #openstack-ironic16:04
devanandalucasagomes: validate() :)16:04
devanandaalso, states/console should indeed indicate whether console is on/off16:05
lucasagomesdevananda, yea16:05
lucasagomestoday we have GET /nodes/<uuid>/states16:06
lucasagomeswhich show the current states + last_error16:06
lucasagomesso as we r using last_error I thought about having a field indicating whether the console is on or off there16:06
*** rloo has quit IRC16:08
*** rloo has joined #openstack-ironic16:08
devanandanot sure I follow16:09
devanandai would expect console to have an entry in /states just like power and deploy do16:09
lucasagomesack yea that was the question heh having an entry or not :)16:10
devanandaromcheg1: i've seen you post a few comments asking for LOG(_('message %s') % var) to be converted to LOG(_('message %s'), var)16:10
devanandaromcheg1: is there a particular reason or precedent for this?16:10
*** mrda_away is now known as mrda16:11
mrdamorning all!16:11
*** anniec has joined #openstack-ironic16:11
devanandamornin!16:11
romcheg1devananda: I've seen a lot of comments like that. That is the main reason I think. I could not find that in the Hacking but for me it looks better16:11
NobodyCammorning mrda16:12
devanandaromcheg1: ok, i would prefer not to spend review cycles on individual stylistic preferences -- we all have them, and they're all different :)16:12
*** nosnos has quit IRC16:12
max_lobur_afkback, but have to run again :/ what a day16:13
devanandaromcheg1: if it's not enforced by flake8 / hacking, we shouldn't really worry about it. or if it's worth fixing, then pls add it to hacking so that it doesn't take human eyes spotting non-compliance16:13
max_lobur_afkwill join later from home16:13
devanandacause we'll invariably miss a few ... that's what flake is for :)16:13
romcheg1devananda: There were a bigger problem. Otherwise I would not mentioned and -1ed the patch16:14
rloodevananda, romcheg1. icbw, but I thought someone mentioned that using string interpolation (%) was less efficient, cuz it was always done even if the string wasn't going to be logged.16:14
devanandarloo: if folks are concerned about the performance impact of that, i'd expect it to end up in hacking sooner or later16:15
*** anniec_ has joined #openstack-ironic16:16
*** anniec has quit IRC16:16
*** anniec_ is now known as anniec16:16
romcheg1devananda: I never -1 problems like PEP257 or interpolation in log messages, if there are no other problems. If the patch is going to get a new change set anyway, why not mention PEP257?16:16
NobodyCamoh sure16:16
rloodevananda, ido you know why lifeless asked you to make this change: https://review.openstack.org/#/c/70468/2/ironic/common/neutron.py16:16
NobodyCam:-p16:16
devanandarloo: hm, i thought it had to do with handling of LOG.exception, but IMBW too :)16:18
devanandanova has a mix of both % and ,16:20
openstackgerritChris Krelle proposed a change to openstack/ironic: Implement _update_neutron in PXE driver  https://review.openstack.org/7046816:23
NobodyCammax_lobur_afk: romcheg1 lucasagomes devananda ^^^ please ... if you have time16:23
*** rloo has quit IRC16:23
*** rloo has joined #openstack-ironic16:23
* devananda looks16:24
lucasagomesNobodyCam, ack16:24
NobodyCam:)16:24
devanandaNobodyCam: reviewed16:28
NobodyCamlol devananda -1 his own patch lol16:31
devanandaheh16:31
* NobodyCam waits to push up fixes until other look too...16:33
*** matty_dubs is now known as matty_dubs|lunch16:33
devanandarloo: sorry for the confusion, I think it stemmed from my misunderstanding lifeless' comment16:38
devanandai've replied on that rev16:38
rloothx devananda. I'm curious to know what he says. It may be that you interpreted his comment correctly ;) Will see...16:39
*** BLZbubba has joined #openstack-ironic16:40
*** yuriyz has quit IRC16:41
*** aignatov is now known as aignatov_16:44
*** coolsvap1 has quit IRC16:44
NobodyCamoh patch set #216:45
NobodyCam:-p16:45
devanandahehehe16:45
NobodyCammornig walkies.. bbaifm16:48
BLZbubbahi guys, n00b here to the bare metal provisioning system(s) but I an very interesting in setting up a proof of concept16:53
BLZbubbajust one quick question here, will it be possible to snapshot at least the /dev/sda ?16:54
BLZbubbaif it loads on the local disk instead of that crazy & unusable pxe/boot/iscsi stack16:55
BLZbubbaor could I use qlogic hba's mayabe16:55
BLZbubbamaybe too :P16:55
NobodyCamBLZbubba: their have talks about suck plans but right now that is not possiable16:56
NobodyCamand Welcome to Ironic16:57
BLZbubbaadmittedly it is a tough problem to grab sda through ipmi16:57
BLZbubbaor however else you might try it16:57
BLZbubbashould i try ironic or the havana version?16:58
BLZbubbaironic is a great project name16:58
NobodyCamif you are setting up now. I would point you to Nova-Baremetal16:59
NobodyCamThank you :)16:59
NobodyCamlook for us after Icehouse release16:59
*** rsacharya has joined #openstack-ironic17:00
BLZbubbaok cool, i'll lurk here again after I have havana working17:00
NobodyCam:)17:00
*** coolsvap has joined #openstack-ironic17:00
devanandaBLZbubba: nova-baremetal should be considered experimental, and is going to be deprecated in the Icehouse release (~2mo away)17:03
devanandaBLZbubba: if you're looking to contribute, i'd say, just start with ironic17:03
* lucasagomes thinking about the snapshot17:04
devanandaBLZbubba: otoh, if you want to install havana from packages and learn how to administer openstack in general, yea, go with havana & nova baremetal17:04
lucasagomesthere's no hypervisor, so no snapshot17:04
devanandalucasagomes: we could do a cold snapshot -- boot into separate ramdisk17:04
lucasagomesdevananda, yea17:04
lucasagomeswell it's more a copy the disk into glance17:04
lucasagomesI'm fine calling it snapshot tho17:05
devanandaright. that's a snapshot :)17:05
lucasagomesbut it's not really17:05
lucasagomes:P17:05
devanandahehe17:05
devanandaif the node uses a Cinder volume instead of local storage, then snapshotting that should be possible17:05
lucasagomesdevananda, we could have a snapshot like fs snapshot17:05
devanandavia the Cidner API17:05
* NobodyCam pulls out his old norton ghost disk 17:05
lucasagomesor using devicemapper17:05
lucasagomeswith the snapshot target17:05
lucasagomesdevananda, ahh cinder sounds good17:06
devanandalucasagomes: devmapper stil lrequires stopping the instance, booting into a separate environment17:06
lucasagomesyea that's correct17:07
*** dkehn__ is now known as dkehn_17:08
romcheg1lucasagomes: around?17:09
lucasagomesromcheg1, yes17:09
romcheg1Can you please take a look at test_maintenance_nodes_error https://review.openstack.org/#/c/63937/9/ironic/tests/api/test_nodes.py17:09
romcheg1Ah, no17:10
romcheg1N questions :)17:10
lucasagomesromcheg1, seems grand, since maintenance is a boolean17:11
lucasagomesblah is a wrong value inputed17:11
lucasagomesso 400 (badrequest)17:11
romcheg1lucasagomes: For a few seconds I confused 4** and 5**17:11
lucasagomesack :D17:11
NobodyCambbt..brb17:11
* lucasagomes always gets confused by http codes as well17:12
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: API: Expose a way to start/stop the console  https://review.openstack.org/7299817:17
*** anniec has quit IRC17:20
*** tatyana has quit IRC17:25
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: API: Expose a way to start/stop the console  https://review.openstack.org/7299817:25
*** jbjohnso has quit IRC17:29
*** athomas has joined #openstack-ironic17:29
NobodyCamdevananda: should I wait for lifeless's reply b4 push up new rev of neutron patch?17:32
openstackgerritRuby Loo proposed a change to openstack/ironic: Implement API to get driver properties  https://review.openstack.org/7300517:33
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Remove _load_one_plugin fallback  https://review.openstack.org/7300617:33
devanandaNobodyCam: regarding interpolation of params in LOG? nope. either way is fine according to hacking17:35
NobodyCam:)17:35
devanandaNobodyCam: stick with what ever you have for now. if we need , instead of % it should go in hacking17:35
NobodyCam:)17:36
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Remove _load_one_plugin fallback  https://review.openstack.org/7300617:36
*** lucasagomes is now known as lucas-afk17:37
* lucas-afk gotta go get a haircut17:38
*** matty_dubs|lunch is now known as matty_dubs17:38
openstackgerritChris Krelle proposed a change to openstack/ironic: Implement _update_neutron in PXE driver  https://review.openstack.org/7046817:38
NobodyCamlucas-afk: will you be back?17:38
lucas-afkNobodyCam, yup17:38
NobodyCam:)17:38
lucas-afkNobodyCam, it will be late, but I will read the scrollback17:38
NobodyCamlucas-afk: for me its just https://review.openstack.org/7046817:38
NobodyCamthat my project for the day17:39
NobodyCam(or until it lands)17:39
lucas-afkNobodyCam, ack, awesome yea I have to give neutron another go17:39
lucas-afkNobodyCam, thanks that! I will test it probably tomorrow17:39
NobodyCam:)17:40
*** matsuhashi has quit IRC17:48
*** saju_m has quit IRC17:50
*** saju_m has joined #openstack-ironic17:51
*** matsuhashi has joined #openstack-ironic17:51
*** matsuhashi has quit IRC17:55
*** saju_m has quit IRC17:58
*** saju_m has joined #openstack-ironic17:59
devanandaromcheg1: any progress on the db migration tool?18:01
*** pleia2 has quit IRC18:02
*** mdurnosvistov_ has joined #openstack-ironic18:02
romcheg1devananda: I was going to publish it but discovered a conceptual problem18:03
romcheg1Now it's almost ready18:03
romcheg1to be published18:03
*** pleia2 has joined #openstack-ironic18:04
devanandaromcheg1: I am going to send a status report today on our progress towards graduation18:04
devanandaromcheg1: that BP is an essential piece, and it looks pretty bad to have no code up still ...18:04
devanandaeven with conceptual problems, that would still show progress :)18:04
romcheg1That will be fixed this week18:04
*** rsacharya has quit IRC18:12
*** hstimer has joined #openstack-ironic18:21
*** marty- has joined #openstack-ironic18:23
*** hstimer has quit IRC18:23
*** marty- has quit IRC18:24
*** hstimer has joined #openstack-ironic18:24
*** aignatov_ is now known as aignatov18:27
*** harlowja_away is now known as harlowja18:28
*** dkehn__ has joined #openstack-ironic18:32
*** davidlenwell_ is now known as davidlenwell18:32
*** dkehn_ has quit IRC18:35
*** dkehn has quit IRC18:35
*** aignatov is now known as aignatov_18:36
lifelessdevananda: I don't think every API use can or should be resolved to a HACKING statement18:36
lifelessdevananda: thats kindof saying 'don't do reviews, just check HACKING approves'18:37
*** dkehn has joined #openstack-ironic18:37
*** dkehn__ is now known as dkehn_18:37
NobodyCambbiafm... running to starbucks for real coffee18:39
*** Alexei_987 has quit IRC18:49
*** saju_m has quit IRC18:51
*** saju_m has joined #openstack-ironic19:00
*** ndipanov has joined #openstack-ironic19:00
NobodyCamahh real coffee :)19:04
NobodyCamwell almost real :-p19:04
*** martyntaylor has left #openstack-ironic19:05
NobodyCamok rev 13 of https://review.openstack.org/#/c/70468 just passed mr J's inspection...19:32
NobodyCammax_lobur_afk: are you back?19:32
devanandaNobodyCam: lgtm, but it's my patch so I won't +2 :p19:42
NobodyCam:) w00t19:43
devanandaNobodyCam: also have you tested it with neutron to make sure it /actually/ works? :)19:43
NobodyCamdevananda: can I get a +1 for the record19:43
*** aignatov_ is now known as aignatov19:43
NobodyCamjust got my undercloud back up19:43
devanandaNobodyCam: i couldn't get seed to work this morning, was going to test it ...19:43
NobodyCamworking towards that atm19:44
NobodyCamalso working on the patch bash script19:44
NobodyCamlol keep getting distracted19:44
*** tatyana has joined #openstack-ironic19:47
*** saju_m has quit IRC19:48
*** max_lobur has joined #openstack-ironic20:19
max_loburback20:19
NobodyCamWb max_lobur20:20
max_loburthx, looking to https://review.openstack.org/#/c/7046820:21
NobodyCam:) hehehe20:21
NobodyCamTy max_lobur20:21
NobodyCamSide question anyone linaggo lately?20:22
rlooNobodyCam: have you tried sending her email?20:23
NobodyCamshould have been a seen in htere20:23
NobodyCamno.. but I will now20:23
max_loburNobodyCam: +2, ready for merge IMO20:34
NobodyCammax_lobur: w00t!!!20:34
NobodyCamnow just need romcheg or lucas-afk to eye it over :)20:35
NobodyCamI think lucas-afk wants to test it localy20:35
romcheg1NobodyCam: I will be available a bit later. Have a class now20:36
NobodyCam:)20:36
NobodyCamTy romcheg1 :)20:36
NobodyCamstay in school20:36
NobodyCam:-p20:36
NobodyCamhehehe20:36
max_lobur:)20:37
openstackgerritSirushti Murugesan proposed a change to openstack/ironic: Adds support for deploying Disk Images  https://review.openstack.org/7305420:46
*** harlowja is now known as harlowja_away20:48
devanandashortstop: thanks!20:56
*** tatyana has quit IRC20:56
*** jdob has quit IRC20:58
*** jdob has joined #openstack-ironic20:58
*** SpamapS_ is now known as SpamapS20:58
*** SpamapS has quit IRC20:58
*** SpamapS has joined #openstack-ironic20:58
shortstopdevananda, np :)21:00
NobodyCamhumm I didn't get a ssh key for power on my undercloud21:02
devanandaNobodyCam: see #tripleo. seems like several ppl have hit the same DBError today21:05
devanandai dunno about the ssh key tho21:05
NobodyCamatp i'm thinking its something I did incorrectly21:06
*** jdob has quit IRC21:08
*** jdob has joined #openstack-ironic21:08
openstackgerritA change was merged to openstack/ironic: SSHPower driver support VMware ESXi  https://review.openstack.org/6454221:11
*** derekh has joined #openstack-ironic21:13
devanandajust in case some of you don't often look at the mailing list, there are two emails up that i'd like to draw ya'll's attention to...21:15
*** ndipanov has quit IRC21:15
max_lobur:)21:22
NobodyCamwell its not db err and i did include nova-ironic element in dib build line, however dib did not even try to include the nova-ironic element, didn't even log anything about it21:24
rloodevananda: what is involved in installation/deployer docs for ironic? can we copy/paste some existing docn?21:26
devanandarloo: what's needed is akin to this ...21:27
* devananda hunts for the link21:27
devanandasomething like this for all the config options21:28
devanandahttp://docs.openstack.org/havana/config-reference/content/ch_configuring-openstack-compute.html21:28
devanandaand something like this in general for running / administering ironic21:29
devanandahttp://docs.openstack.org/admin-guide-cloud/content/ch_introduction-to-openstack-compute.html21:29
rlooeek. hmm. devananda. when does this doc need to be done?21:29
devanandaby when ever the graduation deadline is (which i'm not exactly clear on, tbh, but it's before the summit)21:30
devanandalemme ping ttx real quick21:30
rloook, would be good if this isn't needed til after icehouse 3 or whenever the last code freeze is.21:30
devanandaright21:31
devanandai'm sure it's after i321:31
devanandaone of the points of the FF period is to give time to documentation team :)21:31
devanandai'm just not sure on the exact date21:31
rlooso the documentation team will write this docn then?21:31
devanandawell... no, heh21:31
devanandait's a bit of chicken-and-egg. openstack-doc team doesn't have a responsibility to write docs for non integrated project21:32
devanandabut we have a responsibility to provide docs21:32
* devananda grumbles at the number of chickens and eggs21:32
rlooha ha. i can help with it i guess if no one else volunteers. Let me know when you're desparate. (I don't like writing docn.)21:32
NobodyCamthinks of chicken and waffles ...21:33
JoshNanghey guys, i'm working on https://bugs.launchpad.net/ironic/+bug/1272185. I'm running into the issue that if the partial uuid is an integer, add_identity_filter() in db/sqlalchemy/api.py will assume the uuid is a DB id. thoughts?21:38
JoshNang(because add_identify_filter can filter based on id or uuid)21:39
max_loburJoshNang: Hi!21:40
JoshNangmax_lobur: hi!21:40
max_loburthanks for your efforts21:40
max_loburI thought about where uuid like statement to solve this21:41
max_loburbut currently I don't see how to distinguis id and uuid prefix21:41
max_loburwe probably need some bigger refactoring to achieve this21:41
max_loburalso I've put those bug to wish list21:41
max_loburthis means we probably won't pay much attention to the patch now..21:42
JoshNangthat's fine. I was hoping it'd be an easy one to fix quickly and move on. a good way to get familiar with the code base.21:42
max_loburlemme see if I find better bug for this21:43
devanandamax_lobur: why do you think a partial uuid is valid at all?21:43
max_loburdo you mean we would need to break our validation to acheive this?21:44
max_lobur"where uuid startswith" I meant.21:45
*** dkehn__ has joined #openstack-ironic21:46
russell_hallowing a partial UUID seems a little odd21:46
russell_halthough I've always appreciated short git hashes21:46
devanandashort SHA is one thing21:47
max_loburrussell_h: +21:47
max_loburI thought about git as well21:47
devanandatruncated UUID is not a UUID21:47
devanandaUUID has a very specific format21:47
*** dkehn__ has quit IRC21:48
*** dkehn__ has joined #openstack-ironic21:48
*** dkehn has quit IRC21:48
*** dkehn_ has quit IRC21:49
JoshNangright, I was looking at it as a way to make the CLI a bit more friendly, like the bug says.21:50
devanandaJoshNang: adding names / aliases to Nodes would accomplish that21:50
russell_hif this happens, it feels like it needs to happen at the API layer21:50
*** dkehn has joined #openstack-ironic21:50
russell_hotherwise you can't use an index21:50
devanandaI just commented on the bug.21:50
max_loburhttps://bugs.launchpad.net/ironic/+bug/1277062 devananda , have you seen this21:50
devanandamax_lobur: ahh good point, yes21:54
devanandamax_lobur: see my emails to the dev list a bit ago? :)21:54
max_loburseem no, about what?21:55
max_loburdevananda: are we ok to give https://bugs.launchpad.net/ironic/+bug/1277062 to JoshNang?21:56
devanandamax_lobur: subject: [Ironic] [TripleO] Goal setting // progress towards integration21:57
devanandait pertains to 1277062 ...21:57
max_loburah, of course :)21:59
*** pleia2 has quit IRC22:01
*** pleia2 has joined #openstack-ironic22:07
max_loburdevananda: I understand this is low priority, but he wants a low-hanging-fruit to jump in, also if we would have review sessions like you proposed it will probably take 10 minutes of our common time to review it and merge22:07
max_loburEveryone, how about to have the first review session tomorrow ?22:07
NobodyCamcan we push 8 to 8:3022:08
NobodyCam:-p22:08
NobodyCammore time for coffee22:08
max_loburNobodyCam: that's OK to me as well :)22:09
NobodyCam:)22:10
devanandamax_lobur: yep, makes sense22:10
max_loburcool, JoshNang, would you please take https://bugs.launchpad.net/ironic/+bug/1277062 ?22:10
*** lucas-afk is now known as lucasagomes22:11
JoshNangmax_lobur: certainly!22:11
max_loburIf you push patch today than it's highly probably it will be reviewed tomorrow :)22:11
max_loburthanks :)22:11
devanandamax_lobur: hm... i think we should start at the end of the queue22:12
devanandait might take more than 3 hours to work through it :p22:12
devanandaafk a few... bbiah or so22:13
max_lobur:)22:13
max_loburI hope there are a lot of patches already +1 and +2ed, so we'll spend no more than 10 minutes on them :)22:14
lucasagomes:) yea nice idea to dedicate a time to review stuff22:16
lucasagomesNobodyCam, cool, btw, the neutron patch... it looks ok I'm grand +a that22:16
lucasagomeshave you tested on ur environment?22:17
openstackgerritRuby Loo proposed a change to openstack/python-ironicclient: Fix Iterface misspelling from node-validate cmd  https://review.openstack.org/7308222:18
NobodyCamlucasagomes: not yet... been tring22:24
NobodyCam:-p22:24
NobodyCamto many things22:24
lucasagomesNobodyCam, hah yea22:24
lucasagomesNobodyCam, np, I will give it a shot tomorrow morning22:24
lucasagomesbut code-wise it looks good22:24
NobodyCamawesome !!!!22:25
romcheg1lucasagomes, devananda: Did we came up with a consensus about this one https://review.openstack.org/#/c/71212 ?22:27
lucasagomesromcheg1, hmm idk really, but I liked the idea of using DELETE22:28
lucasagomesand suggested that on the review as well22:28
romcheg1I cannot remember this topic was discussed on the meeting, although it was planned22:28
lucasagomesromcheg1, yea it wasn't22:28
lucasagomesbut there are comments on that patch22:29
*** athomas has quit IRC22:29
romcheg1lucasagomes: I like DELETE as well. But I think we need more opinions22:29
lucasagomesromcheg1, yeah22:29
lucasagomesthat was mentioned as well22:29
lucasagomesthe review itself will be a good way to get some opnions22:29
lucasagomessince now it's using the delete operation22:29
romcheg1Yup, I just wanted to raise the question again :)22:30
*** mdurnosvistov_ has quit IRC22:30
lucasagomesromcheg1, ack, well delete is +1 for me I liked22:31
lucasagomesand saw some other apis also using it22:31
lucasagomeslike etcd22:31
lucasagomes(using it to release locks)22:31
*** matty_dubs is now known as matty_dubs|gone22:35
max_loburI like how it's implemented, but I'm not sure about the idea22:36
max_loburas I recall there was agrs that reservation should be broken only by another conductor22:36
max_loburthat going to pick that node22:36
lucasagomesmax_lobur, yea, automatic take over22:37
*** jdob has quit IRC22:37
lucasagomeswhich needs to be implemented as well22:37
max_loburIt might be misleading - to let user break the reservation, get control over the node, start some action ..22:37
romcheg1That is quite dangerous22:37
lucasagomes+122:37
max_loburand then conductor will take it back22:37
lucasagomesit's powerful indeed, and should be used with caution22:38
max_loburyep, that's kinda hack Ironic22:38
max_loburI tend to have some API gateway to force takeover22:38
romcheg1If a conductor is not sending heartbeats that might mean that it's dead or that the network is dead but the conductor is performing some actions against the node22:38
max_loburor like that22:38
max_loburto push the whole mechanism22:39
max_loburbut not changing particular links22:39
romcheg1In that case breaking the lock might lead to unpredictable consequences22:39
lucasagomesyea22:40
lucasagomesmaybe it's not that useful to have in the api22:40
lucasagomesthinking that22:40
lucasagomesour api users are admins22:40
lucasagomesthey also might have access to the db22:40
max_loburyup22:40
lucasagomesand if the _really_ wants to break the lock22:40
lucasagomesthey can go and update that field on the db22:40
romcheg1Admins can at least monitor the state of the conductor22:40
max_loburit's just a column in db22:41
lucasagomesdon't need us to expose that via an api resource22:41
romcheg1Automatic breaking system cannot22:41
max_loburI thought it can.. isn't it22:41
max_loburonce heartbeat stopped - other conductor takes control22:42
max_loburuntil the ring is fully rebalanced22:42
max_loburthough I'm not quite familiar with this part of code22:42
romcheg1Then we have to make sure the old conductor is not doing anything to that node22:42
romcheg1Two conductors will have conflict22:42
lucasagomesyea22:43
lucasagomesit's hard to map all the corner cases22:43
lucasagomesthere's some cases where the conductor is not even dead22:43
lucasagomesbut the network failed22:43
lucasagomesand a take over happened22:43
romcheg1yeah22:43
romcheg1It might be either problems with networking or heartbeat delivery22:44
lucasagomesyea22:44
openstackgerritRuby Loo proposed a change to openstack/python-ironicclient: Return node_uuid from a port-show cmd  https://review.openstack.org/7309122:45
romcheg1Humans looks more reliable in that case22:45
lucasagomesheh22:46
romcheg1They can call to the datacenter to be 100% sure the conductor is not working :D22:46
lucasagomeskinda, depends on how many things the human has to look at :P22:46
lucasagomescloud is about automation22:46
lucasagomesso we gotta try to automate as much as can22:46
romcheg1agree22:46
lucasagomesas we can*22:46
max_loburlucasagomes: +22:46
romcheg1and as safe as we can22:47
lucasagomesromcheg1, +122:47
max_loburbetter to focus on takeover enhancement22:47
romcheg1max_lobur: +122:47
romcheg1Nope, +2 :)22:47
max_lobur+A22:47
max_loburStarting gate jobs...22:47
lucasagomesyea!22:48
lucasagomeshah22:48
openstackgerritA change was merged to openstack/ironic: Implement a multiplexed VendorPassthru example  https://review.openstack.org/7086322:53
*** harlowja_away is now known as harlowja22:54
*** wusWWW has joined #openstack-ironic23:00
*** aignatov is now known as aignatov_23:03
lucasagomesdevananda, saw ur email about the ephemeral disks bp23:04
lucasagomesI will fix the two patches I've tomorrow23:04
*** rwsu has quit IRC23:06
*** rwsu has joined #openstack-ironic23:08
max_loburhttp://logs.openstack.org/79/71879/3/check/gate-ironic-python26/8f4ebfe LOST23:16
max_loburgah23:16
openstackgerritJosh Gachnang proposed a change to openstack/ironic: Removing unused get_node_power_state  https://review.openstack.org/7309723:19
lucasagomesmax_lobur, heh will recheck23:22
lucasagomesbtw, it's quite late here23:22
lucasagomesI'm gonna go :)23:22
lucasagomeshave a good night everybody23:22
*** lucasagomes has quit IRC23:23
max_loburnight Lucas23:24
NobodyCamnight lucas23:29
NobodyCammissed him :-p23:29
openstackgerritA change was merged to openstack/ironic: Add parameter for filtering nodes by maintenance mode  https://review.openstack.org/6393723:30
*** thedodd has quit IRC23:31
max_loburdevananda: if you have time today, could you please take a look at the https://review.openstack.org/#/c/69135/ (race bug)? If you don't spot any *conceptual* problems I'll make the same for vendor action23:39
max_loburi'm going sleep too, night folks23:41
NobodyCamnight max_lobur23:42
*** max_lobur has quit IRC23:42
*** derekh has quit IRC23:44
NobodyCambrb... quick walkies23:56
russell_hI'm thinking about how I could make a deploy agent autodiscover its node_uuid23:57
russell_hwe've got an existing system where we inventory the node and submit that to an API, which then finds a matching server in the database23:57
russell_hI'd like to do something similar here. It feels like there are two main options: I expose some sort of filtering on the nodes API, so the agent can try to find a matching node then use that23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!