openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Prevent a node in maintenance from being deployed https://review.openstack.org/77129 | 00:02 |
---|---|---|
devananda | NobodyCam: I didn't. | 00:03 |
devananda | NobodyCam: also, those two patches could use your eyes | 00:03 |
* NobodyCam clicks | 00:06 | |
*** awp has quit IRC | 00:06 | |
NobodyCam | approved already? | 00:06 |
*** jcooley_ has quit IRC | 00:08 | |
devananda | oh. the second one then | 00:10 |
NobodyCam | on that should we test that operstions like enable comsole still work? | 00:11 |
devananda | probably | 00:11 |
devananda | can do in a follow up | 00:12 |
NobodyCam | ++ | 00:12 |
NobodyCam | if we had a bug for light test coverage for maintenace mode we continute to work on it after next tuesday | 00:13 |
NobodyCam | lol | 00:13 |
devananda | yep | 00:14 |
NobodyCam | +2 plus a comment | 00:15 |
*** max_lobur has quit IRC | 00:15 | |
*** mdurnosvistov_lt has quit IRC | 00:26 | |
devananda | NobodyCam: another good/easy one - https://review.openstack.org/#/c/76494/ | 00:31 |
devananda | and another! https://review.openstack.org/#/c/76258/ | 00:32 |
NobodyCam | getting late on friday lol ... | 00:33 |
devananda | ooh. /me spots an issue in one of those patches. | 00:36 |
openstackgerrit | A change was merged to openstack/ironic: Add option to sync node power state from DB https://review.openstack.org/76293 | 00:38 |
*** jcooley_ has joined #openstack-ironic | 00:41 | |
wanyen | NobodyCam: Faizan posted a comment on the Nova ironic Driver code review regarding this driver to pass image_source, root_gb, instance_name to all drivers (not just to pxe driver). Will you plan to make the changes? iLO driver needs Nava Ironic driver to pass those info. | 00:42 |
wanyen | s/nava/nova. | 00:42 |
devananda | wanyen: yes. we realized this recently as well and haven't refactored it yet | 00:43 |
NobodyCam | wanyen: yes thats why I was asking about a bug o blue print | 00:43 |
wanyen | deva and NobodyCam: that's great! Thanks! | 00:44 |
NobodyCam | devananda: what was issue you spotted. did you comment on it? | 00:46 |
devananda | NobodyCam: filing a bug | 00:46 |
openstackgerrit | A change was merged to openstack/ironic: Allow clients to mark a node as in maintenance https://review.openstack.org/76614 | 00:48 |
* NobodyCam wishes bugs reported in channel like patch sets | 00:49 | |
devananda | yep | 00:52 |
NobodyCam | question about the tests on 76258 | 00:53 |
NobodyCam | should reservation be none if an error was raised | 00:54 |
devananda | eh? | 00:54 |
NobodyCam | line 762 of https://review.openstack.org/#/c/76258/2/ironic/tests/conductor/test_manager.py | 00:55 |
devananda | yes | 00:55 |
devananda | the task_manager lock had better be released if the delete fails :) | 00:55 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Add provision_updated_at to node's resource https://review.openstack.org/76494 | 01:02 |
*** jcooley_ has quit IRC | 01:04 | |
*** jcooley_ has joined #openstack-ironic | 01:05 | |
devananda | ok, i'm out for the evening -- will do some more reviews tomorrow | 01:06 |
*** openstackgerrit has quit IRC | 01:10 | |
*** openstackgerrit has joined #openstack-ironic | 01:11 | |
openstackgerrit | A change was merged to openstack/ironic: Prevent a node in maintenance from being deployed https://review.openstack.org/77129 | 01:18 |
openstackgerrit | A change was merged to openstack/ironic: Updated from global requirements https://review.openstack.org/75565 | 01:22 |
openstackgerrit | A change was merged to openstack/ironic: Add provision_updated_at to node's resource https://review.openstack.org/76494 | 02:09 |
*** lnxnut has joined #openstack-ironic | 02:10 | |
*** lazy_prince is now known as killer_prince | 02:41 | |
*** dtalton2 has quit IRC | 02:49 | |
*** lnxnut has quit IRC | 02:52 | |
*** lnxnut has joined #openstack-ironic | 02:55 | |
*** lnxnut has quit IRC | 04:18 | |
*** wanyen has quit IRC | 04:20 | |
*** lnxnut has joined #openstack-ironic | 04:22 | |
*** harlowja is now known as harlowja_away | 04:31 | |
*** jcooley_ has quit IRC | 04:50 | |
*** jcooley_ has joined #openstack-ironic | 04:50 | |
*** jcooley_ has quit IRC | 04:55 | |
*** marty_ has joined #openstack-ironic | 05:39 | |
*** hstimer has quit IRC | 05:43 | |
*** killer_prince has quit IRC | 06:05 | |
openstackgerrit | Jenkins proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/71192 | 06:08 |
*** killer_prince has joined #openstack-ironic | 06:08 | |
*** killer_prince has quit IRC | 06:08 | |
*** killer_prince has joined #openstack-ironic | 06:08 | |
*** vkozhukalov has joined #openstack-ironic | 06:18 | |
*** jcooley_ has joined #openstack-ironic | 06:19 | |
*** jcooley_ has quit IRC | 06:34 | |
*** jcooley_ has joined #openstack-ironic | 07:08 | |
*** killer_prince has quit IRC | 07:12 | |
*** killer_prince has joined #openstack-ironic | 07:46 | |
*** killer_prince has quit IRC | 07:46 | |
*** killer_prince has joined #openstack-ironic | 07:46 | |
*** killer_prince is now known as lazy_prince | 08:00 | |
*** jcooley_ has quit IRC | 08:10 | |
*** jcooley_ has joined #openstack-ironic | 09:02 | |
*** vkozhukalov has quit IRC | 09:08 | |
*** jcooley_ has quit IRC | 09:32 | |
*** jcooley_ has joined #openstack-ironic | 09:58 | |
*** jcooley_ has quit IRC | 10:30 | |
*** tatyana has joined #openstack-ironic | 10:36 | |
*** lazy_prince has quit IRC | 10:57 | |
*** jcooley_ has joined #openstack-ironic | 10:59 | |
*** tatyana has quit IRC | 11:15 | |
*** killer_prince has joined #openstack-ironic | 11:17 | |
*** killer_prince has quit IRC | 11:28 | |
*** jcooley_ has quit IRC | 11:29 | |
*** jcooley_ has joined #openstack-ironic | 11:55 | |
*** lazy_prince has joined #openstack-ironic | 11:58 | |
*** lazy_prince is now known as killer_prince | 11:58 | |
*** killer_prince has quit IRC | 12:10 | |
*** killer_prince has joined #openstack-ironic | 12:16 | |
*** jcooley_ has quit IRC | 12:26 | |
*** killer_prince has quit IRC | 12:30 | |
*** killer_prince has joined #openstack-ironic | 12:37 | |
*** jcooley_ has joined #openstack-ironic | 12:55 | |
*** jcooley_ has quit IRC | 13:26 | |
*** rameshg87 has joined #openstack-ironic | 13:37 | |
*** rameshg87 has quit IRC | 13:41 | |
*** dhellmann_ is now known as dhellmann | 13:41 | |
*** jcooley_ has joined #openstack-ironic | 13:44 | |
*** rameshg87 has joined #openstack-ironic | 13:47 | |
*** rameshg87 has left #openstack-ironic | 13:48 | |
*** rameshg87 has joined #openstack-ironic | 13:49 | |
*** rameshg87 has left #openstack-ironic | 13:50 | |
*** rameshg87 has joined #openstack-ironic | 13:50 | |
*** rameshg87 has left #openstack-ironic | 13:50 | |
*** rameshg87 has joined #openstack-ironic | 13:51 | |
*** dhellmann is now known as dhellmann_ | 13:57 | |
*** jcooley_ has quit IRC | 14:16 | |
*** vkozhukalov has joined #openstack-ironic | 14:47 | |
*** jcooley_ has joined #openstack-ironic | 14:52 | |
*** blamar has quit IRC | 14:52 | |
*** max_lobur has joined #openstack-ironic | 14:57 | |
*** lnxnut has quit IRC | 14:58 | |
*** jbjohnso_ has joined #openstack-ironic | 15:01 | |
*** lnxnut has joined #openstack-ironic | 15:04 | |
*** jcooley_ has quit IRC | 15:15 | |
*** jcooley_ has joined #openstack-ironic | 15:15 | |
*** jcooley_ has quit IRC | 15:24 | |
*** lnxnut has quit IRC | 15:27 | |
*** lnxnut has joined #openstack-ironic | 15:35 | |
*** lnxnut has quit IRC | 15:39 | |
*** jcooley_ has joined #openstack-ironic | 15:40 | |
*** blamar has joined #openstack-ironic | 15:56 | |
*** aignatov_ is now known as aignatov | 16:00 | |
*** jcooley_ has quit IRC | 16:07 | |
*** jcooley_ has joined #openstack-ironic | 16:07 | |
*** max_lobur1 has joined #openstack-ironic | 16:11 | |
*** max_lobur has quit IRC | 16:11 | |
*** max_lobur has joined #openstack-ironic | 16:13 | |
*** max_lobur1 has quit IRC | 16:15 | |
*** max_lobur has quit IRC | 16:17 | |
*** max_lobur has joined #openstack-ironic | 16:22 | |
*** jcooley_ has quit IRC | 16:25 | |
*** lnxnut has joined #openstack-ironic | 16:35 | |
*** aignatov2 has joined #openstack-ironic | 16:38 | |
*** lnxnut has quit IRC | 16:40 | |
*** aignatov has quit IRC | 16:41 | |
*** aignatov2 is now known as aignatov | 16:41 | |
*** jbjohnso_ has quit IRC | 16:53 | |
*** rameshg87 has quit IRC | 16:59 | |
*** lnxnut has joined #openstack-ironic | 17:00 | |
*** max_lobur1 has joined #openstack-ironic | 17:05 | |
*** max_lobur has quit IRC | 17:09 | |
*** jcooley_ has joined #openstack-ironic | 17:22 | |
*** jcooley_ has quit IRC | 17:24 | |
*** killer_prince is now known as lazy_prince | 17:32 | |
*** dhellmann_ is now known as dhellmann | 17:41 | |
*** lnxnut has quit IRC | 17:52 | |
*** lnxnut has joined #openstack-ironic | 17:53 | |
*** datajerk has joined #openstack-ironic | 17:53 | |
*** rameshg87 has joined #openstack-ironic | 18:07 | |
*** lnxnut has quit IRC | 18:20 | |
*** lnxnut has joined #openstack-ironic | 18:21 | |
*** lnxnut has quit IRC | 18:21 | |
*** lnxnut has joined #openstack-ironic | 18:22 | |
*** lnxnut has quit IRC | 18:26 | |
*** rameshg87 has quit IRC | 18:27 | |
openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Add IloDriver for HP Proliant Servers https://review.openstack.org/76144 | 19:06 |
*** lnxnut has joined #openstack-ironic | 19:23 | |
*** lnxnut has quit IRC | 19:27 | |
openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Add IloPower module for IloDriver https://review.openstack.org/76352 | 19:32 |
*** lnxnut has joined #openstack-ironic | 19:35 | |
*** lnxnut has quit IRC | 19:40 | |
*** jbjohnso_ has joined #openstack-ironic | 19:49 | |
*** max_lobur1 has quit IRC | 19:50 | |
openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Add IloVirtualMediaDeploy module for IloDriver https://review.openstack.org/77365 | 20:35 |
*** lnxnut has joined #openstack-ironic | 20:35 | |
*** rwsu has quit IRC | 20:40 | |
*** lnxnut has quit IRC | 20:40 | |
*** lnxnut has joined #openstack-ironic | 21:35 | |
*** lnxnut has quit IRC | 21:40 | |
*** lnxnut has joined #openstack-ironic | 22:35 | |
*** lnxnut has quit IRC | 22:40 | |
*** jbjohnso_ has quit IRC | 22:49 | |
*** vkozhukalov has quit IRC | 23:08 | |
*** lnxnut has joined #openstack-ironic | 23:35 | |
*** lnxnut has quit IRC | 23:40 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!